- 15 Nov, 2018 40 commits
-
-
Khushal authored
Add class comments and some renames for PaintCache. Following up from: https://chromium-review.googlesource.com/c/chromium/src/+/1321190/4 R=enne@chromium.org Bug: 894200 Change-Id: Ie8a0629071f8156e26945be7e9c61e04742158e5 Reviewed-on: https://chromium-review.googlesource.com/c/1336040Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#608298}
-
Alessio Bazzica authored
Bug: webrtc:7494 Change-Id: I0cdcf1ac0bb0726913a4fdd15fcdaa324c4e86b7 Reviewed-on: https://chromium-review.googlesource.com/c/1335488Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Ale Bzk <alessiob@chromium.org> Cr-Commit-Position: refs/heads/master@{#608297}
-
David Jean authored
Bug: 845472 Change-Id: Iac666731ad90f3ac69ed668406ca80e722c9c5cb Reviewed-on: https://chromium-review.googlesource.com/c/1335574Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#608296}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e36f46461df6..1315333b6bfb git log e36f46461df6..1315333b6bfb --date=short --no-merges --format='%ad %ae %s' 2018-11-15 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@1315333b6bfb The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: I3da15f0b1e9b621ef6fa6b2191c1d319099ffd05 Reviewed-on: https://chromium-review.googlesource.com/c/1337274Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608295}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5ad919faea83..52d757db392f Created with: gclient setdep -r src-internal@52d757db392f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iedd6a593d23a1e26a7bce0f372d6625f74eeac87 Reviewed-on: https://chromium-review.googlesource.com/c/1337469Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608294}
-
Noel Gordon authored
Ash immersive mode is not quite right anymore: remove it. Bug: 839243 No-Try: true Change-Id: If25f8e3411006c694825a38841fd1ae92f287623 Reviewed-on: https://chromium-review.googlesource.com/c/1336951Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#608293}
-
Koji Ishii authored
This patch moves the flag whether to force to create a box fragment for LayoutInline or not from NGInlineItem to LayoutInline. This is part of an effort to reduce re-collecting NGInlineItem when styles were changed. Re-collecting is rather an expensive operation that changes in, for instance, background should not require it. Note, this patch itself does not reduce the collection, because we require re-collection whenever NeedsLayout is set. It is planned in future patches, but this change is needed to make it happen. Also benefits to keep the flag turned on once it's on, until the LayoutInline is reattached. The change has minor performance gain in most blink_perf.layout https://pinpoint-dot-chromeperf.appspot.com/job/15f8c74be40000 Bug: 636993 Change-Id: I8d4e7c421d5fad26fee60832cdfbacd575f7ad34 Reviewed-on: https://chromium-review.googlesource.com/c/1333588Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#608292}
-
Nigel Tao authored
Change-Id: I7ddbabf86c83256d608bd0f97736e8ead373a81d Reviewed-on: https://chromium-review.googlesource.com/c/1337217Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#608291}
-
Joel Hockey authored
Unshares a path previously shared, and removes path from prefs. Bug: 878324 Change-Id: I9655c16851eed2eccca225fc3d9642db21b51dde Reviewed-on: https://chromium-review.googlesource.com/c/1317212 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#608290}
-
Benoît Lizé authored
The following sequence is racy with the current ASAN checks in ParkableString, on the main thread: Park() Lock() ToString() Unlock() Park() poisons the string, ToString() unpoisons it, and Unlock() poisons it again. If this last call happens while the compression is in progress, then this is a use-after-poison. This is not a real issue, merely an overaly eager poisoning, still making using ASAN builds painful. Fix it by making sure the string stays unpoisoned during compression. Also adds a regression test. Bug: 905137,877044 Change-Id: I5276b9ae6eee4abe2f2bf041818d1ba17358a80a Reviewed-on: https://chromium-review.googlesource.com/c/1335585Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#608289}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8a6451c727a2..d098799efb32 git log 8a6451c727a2..d098799efb32 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 sabbakumov@yandex-team.ru Fix race condition while handling errors Created with: gclient setdep -r src/third_party/catapult@d098799efb32 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I4e4286213e559250c206b596b98fc3b0ab4343ef Reviewed-on: https://chromium-review.googlesource.com/c/1337309Reviewed-by:
-
Koji Ishii authored
This patch changes LayoutInline to use |IsInLayoutNGInlineFormattingContext()| to determine whether it's in LayoutNG inline formatting context or not. This was revealed in crrev.com/c/1333588, tests will fail with the CL without this fix. Bug: 636993 Change-Id: I6ae4fb3bcaf18afceb4ab3486618a031b4a895c9 Reviewed-on: https://chromium-review.googlesource.com/c/1337212Reviewed-by:
-
Marc Treib authored
It's a simple test implementation of SyncUserSettings that mostly forwards calls to the TestSyncService. It is not actually used yet, but it unlocks the migration of tests over to SyncUserSettings. Bug: 884159 Change-Id: Id9d9c03f639c6523bb6d6592517ba46d1f8f4566 Reviewed-on: https://chromium-review.googlesource.com/c/1335565 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#608286}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb18f19dce17..5ad919faea83 Created with: gclient setdep -r src-internal@5ad919faea83 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie26dfafd1271a82eb4bea28cae1d65ed76a7e4f0 Reviewed-on: https://chromium-review.googlesource.com/c/1337310Reviewed-by:
-
Kent Tamura authored
Error -> Warning. Bug: 697443 Change-Id: Ib4e88bb64cd5f1a533ae88306c47e91ca0606085 Reviewed-on: https://chromium-review.googlesource.com/c/1337216Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#608284}
-
Joel Hockey authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/693e848cded9..9a5d5fab32aa $ git log 693e848cd..9a5d5fab3 --date=short --no-merges --format='%ad %ae %s' 2018-11-06 joelhockey vm_tools: seneschal: Add support for Unshare 2018-11-01 chirantan vm_tools: concierge: Remove StartContainer method Created with: roll-dep src/third_party/cros_system_api Change-Id: I73b23667ce4168d6a6d5c184376eda856ab15b14 Reviewed-on: https://chromium-review.googlesource.com/c/1337137Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#608283}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6b0ab168. With Chromium commits locally applied on WPT: f482e77e "Add report-only mode to Feature Policy" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I622df7e594bbff38c9752638e80a1ca926bbecb0 Reviewed-on: https://chromium-review.googlesource.com/c/1337291 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608282}
-
John Abd-El-Malek authored
Reland "Remove remaining components/domain_reliability dependency on content/ and components/keyed_service." This is a reland of bd611e3e Original change's description: > Remove remaining components/domain_reliability dependency on content/ and components/keyed_service. > > This way it can run in the network process, similar to Network Error Logging. > > Bug: 853251 > Change-Id: I403a5dcc3cae12b592a444c7e23f71c552b58e1f > Reviewed-on: https://chromium-review.googlesource.com/c/1334848 > Reviewed-by: Misha Efimov <mef@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608175} TBR=mef@chromium.org Bug: 853251 Change-Id: Iee089ae0cd422e242df53604da6dcb8ef25b74cb Reviewed-on: https://chromium-review.googlesource.com/c/1337373Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#608281}
-
Alexandre Courbot authored
User-allocated memory can be passed to some hardware (like video encoder). Such hardware is generally not happy if the memory is not page-aligned. This patch adds a new member to VideoFrameLayout that specifies the desired alignment of the buffer, and make VideoFrame comply to it when allocating memory. It also makes use of it by specifying a page-alignment to formats returned by V4L2Device. Other users of VideoFrame/VideoFrameLayout are not affected by this CL. BUG=b:80274650 TEST=Made sure the VEA unittest was working on Hana and Cheza. Change-Id: Id615ca1ba3f9b253ba774573146a3428c144f57f Reviewed-on: https://chromium-review.googlesource.com/c/1154769 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#608280}
-
Makoto Shimazu authored
Previously ServiceWorkerObserver::WaitForState(STOPPED) starts to observe the state when it's called, but sometimes it's too slow and restarting the worker is already happening when starting to wait for state STOPPED. This CL fixes it by keeping all state changes and returning from WaitForState() if the observer saw the state previously at least once. Bug: 889855 Change-Id: Ide180fa49c9f47f68e1482b9a368b386648a3d4e Reviewed-on: https://chromium-review.googlesource.com/c/1337214Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#608279}
-
Kentaro Hara authored
This reverts commit 21216eb0. Reason for revert: I'm 20% sure but this CL is suspicious for the failure on Linux Chromium OS ASan LSan Tests. Let me try to revert it and see how it goes. If it's innocent, let me reland! https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/30100 Original change's description: > cros: Turn LoginBubble flags into a LoginBaseBubbleView member function > > This prevents us from having to mutate the flags variable each time a bubble is > shown or hidden. > > Bug: 905436 > Change-Id: Ia40f2d0b9aa949fd6c67b46dcf22a5e5272f60a7 > Reviewed-on: https://chromium-review.googlesource.com/c/1336254 > Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608151} TBR=jdufault@chromium.org,qnnguyen@chromium.org Change-Id: Iebf03b66402b61999a53a1db372fbc36d9a91c0c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 905436 Reviewed-on: https://chromium-review.googlesource.com/c/1337141Reviewed-by:
-
Joel Hockey authored
I saw some flakiness today in the QuickView UI test where a volume can be unmounted whilst a rescan is in progress. Then when it is finally complete, this call to getLocationInfo fails. Change-Id: Ie29e551b980b3e4bacea7b6bd39746c8c140e1aa Reviewed-on: https://chromium-review.googlesource.com/c/1337136Reviewed-by:
-
Lei Zhang authored
TBR=halliwell@chromium.org,kbr@chromium.org,kinuko@chromium.org,marq@chromium.org, olka@chromium.org,thakis@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I40a84a602bfa25f6f38c8a9b1d8fc4015906563b Reviewed-on: https://chromium-review.googlesource.com/c/1279182 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#608276}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2eccd58916ee..e36f46461df6 git log 2eccd58916ee..e36f46461df6 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-15 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@e36f46461df6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: Ifb7138c0396e5a0f6ba8b378dac95e2046beecd6 Reviewed-on: https://chromium-review.googlesource.com/c/1337273Reviewed-by:
-
Jay Harris authored
The CustomTabBar will be added in a future CL. * Lifts LocationBar animation into Toolbar, so the same animation can be reused on the CustomTabBar without duplication. * Renames ShouldShowLocationBar to ShouldShowToolbar * Renames UpdateLocationBarVisibility to UpdateToolbarVisibility Bug: 853593 Change-Id: Ib303275f7d560cb67cc2e30767a7dbf2783da497 Reviewed-on: https://chromium-review.googlesource.com/c/1328081 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#608274}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d575a2d43a2d..c25d23445748 git log d575a2d43a2d..c25d23445748 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 srte@webrtc.org Adds OWNERS to api/transport. Created with: gclient setdep -r src/third_party/webrtc@c25d23445748 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic32c4a49597d57d252c5c595e315e019bab5f5bf Reviewed-on: https://chromium-review.googlesource.com/c/1337269Reviewed-by:
-
Hao Zhang authored
Bug: 899057 Change-Id: I4d87ee3b3f12d0f76376976b0be0460b8b94c007 Reviewed-on: https://chromium-review.googlesource.com/c/1334228 Commit-Queue: Hao Zhang <hozhng@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#608272}
-
Adrienne Walker authored
If non-lazy tasks are queued but never executed, it would still try to unref them, causing a crash. Add some tests to make sure that lazy and non-lazy images get unref'd (or not) appropriately and reenable the test. Bug: 902644,902022,905239 Change-Id: I778d81aa390c1a529b7bfd88a2e146f245fb35e5 Reviewed-on: https://chromium-review.googlesource.com/c/1324874 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#608271}
-
Joel Hockey authored
Convert Crostini to a class, and move state into bg so that all FilesApp windows will have a consistent view of which paths are shared. Bug: 878324 Change-Id: I3c21465b625091fd6360e6b799d9e85baf1ea614 Reviewed-on: https://chromium-review.googlesource.com/c/1335747 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Joel Hockey authored
When a user right-clicks and shares a root folder of a volume, a dialog is shown for the user to confirm the action. For Drive, the dialog with specific wording for Drive is shown for My Drive, Team Drives, and Computers. For other volumes, generic wording is used. Bug: 878324 Change-Id: I92dad87c8e7b042dd45902d93e08e3cd66abc753 Reviewed-on: https://chromium-review.googlesource.com/c/1337109 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Kentaro Hara authored
Revert "Remove remaining components/domain_reliability dependency on content/ and components/keyed_service." This reverts commit bd611e3e. Reason for revert: It looks like this CL broke CFI bots: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/11301 Original change's description: > Remove remaining components/domain_reliability dependency on content/ and components/keyed_service. > > This way it can run in the network process, similar to Network Error Logging. > > Bug: 853251 > Change-Id: I403a5dcc3cae12b592a444c7e23f71c552b58e1f > Reviewed-on: https://chromium-review.googlesource.com/c/1334848 > Reviewed-by: Misha Efimov <mef@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608175} TBR=jam@chromium.org,mef@chromium.org Change-Id: I57829e413ad57ec667882069f77bf2d97faec4a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 853251 Reviewed-on: https://chromium-review.googlesource.com/c/1337215Reviewed-by:
-
Nicolas Pena authored
Bug: 896024 Change-Id: Ie4a0ba6a07c96557f0bfd464e523c0ad8d804c8e Reviewed-on: https://chromium-review.googlesource.com/c/1336431Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#608267}
-
Koji Ishii authored
When NGInlineItemsBuilder removed an item, it needs to adjust BoxInfo::item_index. This patch fixes it. This was revealed in crrev.com/c/1333588, tests will fail with the CL without this fix. Bug: 636993 Change-Id: I7a996e358c0daa8e6c7aa1b5227e4027fe0295bd Reviewed-on: https://chromium-review.googlesource.com/c/1337210Reviewed-by:
-
Robbie McElrath authored
This is identical to crrev.com/c/1329897, but the underlying issue that caused that CL to break unit tests was fixed in crrev.com/c/1336066. Original change's description: > Get NetworkChangeNotifier working on ChromeOS with network service. > > The current NetworkChangeNotifierChromeOS implementation won't work > with the network service enabled because it listens for network changes > from Shill, which only supports a single client. The browser process > has other dependencies on Shill, so it has to be the client for the time > being, meaning the network service can't directly listen for network > changes and has to be notified of them from the browser process. > > This CL splits the NetworkChangeNotifierChromeOS into two parts; > the first will live in the browser process and listen to Shill, while > the second is the actual NetworkChangeNotifierChromeOS implementation > which will have an instance in both the browser and network processes. > Since NetworkChangeNotifierChromeOS can't actually listen for network > changes itself, it just gets notified of changes from part 1 via a new > method in NetworkChangeManager. When the thing listening to Shill sees > a network change, it notifies its local NetworkChangeNotifierChromeOS > instance, and calls the new NetworkChangeManager method, the > implementation of which then notifies the network service's > NetworkChangeNotifierChromeOS instance. > > Bug: 882610 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: Ib220575fbe42f026b1e5cb90d3bb6be9d0345414 > Reviewed-on: https://chromium-review.googlesource.com/c/1274445 > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606665} Bug: 882610 Change-Id: I05ecbac510b479eb28520cc0b0ad5b613519fab7 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/c/1336154Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#608265}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/43a35d299bbc..91de11099dcd git log 43a35d299bbc..91de11099dcd --date=short --no-merges --format='%ad %ae %s' 2018-11-15 yyanagisawa@chromium.org autoninja: fix shellcheck warnings Created with: gclient setdep -r src/third_party/depot_tools@91de11099dcd The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I8f9333288bfebeeafe6100b3a59331110818b1d0 Reviewed-on: https://chromium-review.googlesource.com/c/1337272Reviewed-by:
-
Xiaocheng Hu authored
The layout test has a "multiline" test case which isn't really multiline, as the linebreak characters in HTML are turned into whitespaces. This patch changes the <p> element into <pre> so that the linebreak characters are really breaking text into lines, and the test case is a multiline test case. This patch is a preparation for changing StartOfSentence() to use TextOffsetMapping (crrev.com/c/1335959). Bug: 778507 Change-Id: I77cd48eb13a1ff442e7ecbe1c71819055bccf078 Reviewed-on: https://chromium-review.googlesource.com/c/1336785 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
-
Kent Tamura authored
* kWebKitUserModifyEffective It counts if contenteditable content attribute value and -webkit-user-modify property value are mismatched. * kPlaintTextEditingEffective It counts if -webkit-user-modify:read-write-plaintext-only is effective or a user interact with an element with contenteditable=plaintext-only. The counters are triggered only in Element::IsFocusable(). - Checking all elements costs too much. - If a user interacts with an element, IsFocusable() must be called. It's ok to ignore elements without user interaction. The behavior of such elements isn't important for web-site compatibility. Bug: 687843 Change-Id: Idb7a9280e1f63c4ecdca0c4ce3298c3c9be715da Reviewed-on: https://chromium-review.googlesource.com/c/1335069 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Xiaoqian Dai authored
It's a speculative fix for https://listnr.corp.google.com/product/5015361/report/85785278442. In the report, the reporter observed (from offline email): 1. opened up my mewoth/brydge 2. noticed that brydge kb wasn't working, checked quick settings menu and noticed bluetooth was missing 3. tried to enter password but no virtual kb came up Since there is not a consistently repro way to repro this, my guess is the Bluetooth stack was broken somehow but Chrome didn't get notified. With this CL, the device should be able (hopefully) to enter the correct ui mode and have the virtual keyboard if Bluetooth stack is broken. Bug: None. See description Change-Id: Ic04a769c111f772211e99c25d187726b46429626 Reviewed-on: https://chromium-review.googlesource.com/c/1337011Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#608261}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5c1d38395f19..bb18f19dce17 Created with: gclient setdep -r src-internal@bb18f19dce17 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibd664f528939594fa4dd798e31f829572d6a2de7 Reviewed-on: https://chromium-review.googlesource.com/c/1336529Reviewed-by:
-
Xiaocheng Hu authored
This patch converts the layout test with W3C testharness to allow cross-platform evaluation of the test cases. Change-Id: Ifba919b388f8a6c6de062f8615d0547fac2d2ca6 Reviewed-on: https://chromium-review.googlesource.com/c/1336661Reviewed-by:
-
