GitLab

Clearer this way, especially since a deletion may entail a hierarchy
change.

BUG=365012
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/331243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277847 0039d316-1c4b-4281-b951-d872f2087c98

(Per review comment from https://codereview.chromium.org/330933004/.)

TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/339923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277846 0039d316-1c4b-4281-b951-d872f2087c98

After the landing https://codereview.chromium.org/317203004,
background_contents_service.cc doesn't need the command line switch
related headers anymore. So we can remove these.

BUG=350898

Review URL: https://codereview.chromium.org/338083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277845 0039d316-1c4b-4281-b951-d872f2087c98

Locally, this reduces the time the suite takes from ~15 seconds to ~5 seconds.

BUG=384314

Review URL: https://codereview.chromium.org/333893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277844 0039d316-1c4b-4281-b951-d872f2087c98

This is a straight upstream from Blink's IDL parser, which will allow
us to drop some overrides there, which in turn will allow us to update
this parser to use the grammar of current Web IDL, where static
attributes are supported differently (via a StaticMember production
that handles both static attributes and static methods.)

Preparation for:
IDL parser: drop AttributeOrOperation and StaticAttribute overrides
https://codereview.chromium.org/336733002/ (in Blink)

...and ultimately for:
IDL parser: align with current Web IDL specification
https://codereview.chromium.org/329853005/

BUG=

Review URL: https://codereview.chromium.org/333853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277843 0039d316-1c4b-4281-b951-d872f2087c98

Adding one more very tiny Android file here means fewer changes needed to
compile other files borrowed from Android or Android-x86.

BUG=358029

Review URL: https://codereview.chromium.org/331793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277842 0039d316-1c4b-4281-b951-d872f2087c98

Now, clicking the app item just emits onLaunched event, and the
app will create an app window on the event handler. The API handler
creates a ShellAppWindow for app_shell, but it should create
an activity on athena.

BUG=380421
R=jamescook@chromium.org, oshima@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/335003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277841 0039d316-1c4b-4281-b951-d872f2087c98

SyncMessageFilter::Send() returns false immediately, if the IPC connection
is not yet established. As connecting is done asynchronously, there is
no guarantee that the connection is established on the first Send() invocation.
By this CL, Send() blocks the caller thread if the connection is not yet
established.
Note that currently the ratio should be probably low, because there are some
more initialization steps between the ManifestService creation and the first
Send() invocation. We're switching to changing the initialization procedure,
and then this race would be hit more easily.

TEST=Ran browser_tests --gtest_filter=*NonSfi*:*NonSFI* locally, and trybots. Also, locally modified the code to delay OnFilterAdded with and without this CL, and made sure this CL works well.
BUG=333950
CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32

Review URL: https://codereview.chromium.org/334593004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277840 0039d316-1c4b-4281-b951-d872f2087c98

Extend and use android_profiling_helper.py to set up a symfs for VTune.
Queries the required libraries from the profiler's output and pulls them from
the device. This allows VTune to resolve all symbols in the profiling output.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276740

Review URL: https://codereview.chromium.org/308123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277839 0039d316-1c4b-4281-b951-d872f2087c98

> Refactor tool-bar event handlers.
> 
> The tool-bar is being phased out as part of the apps v2 work, but as
> part of the transition, the functionality it provides needs to be shared
> between it and the window frame. Step one is to disentangle some of the
> event handling code from client_session.js and toolbar.js.
> 
> NOTRY=true
> 
> Review URL: https://codereview.chromium.org/336293003

TBR=jamiewalch@chromium.org

Review URL: https://codereview.chromium.org/336423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277838 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Pick a fixed Clang revision for Windows now that we have an LKGR ASan builder (https://codereview.chromium.org/320383004/)

Reason for revert:
This was landed despite an explicit "not lgtm"

Original issue's description:
> Pick a fixed Clang revision for Windows now that we have an LKGR ASan builder
> This way, the LKGR builder and the developers who want to try ASan (or just Clang) on Windows won't get a broken Clang revision.
> 
> The FYI bots got LLVM_WIN_REVISION=HEAD in r276301 so won't be affected.
> 
> BUG=82385,345874
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276366

TBR=hans@chromium.org,rnk@chromium.org,timurrrr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=82385,345874

Review URL: https://codereview.chromium.org/342533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277837 0039d316-1c4b-4281-b951-d872f2087c98

This is the audio part of r277270.

When Decode(EOS) is called on DecryptingAudioDecoder, the decoder should keep
flushing the decryptor with EOS input until NeedMoreData() is returned. Then the
decoder can return the DecodeCB.

BUG=338529
TEST=Fix unittest to cover this case.

Review URL: https://codereview.chromium.org/332253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277836 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127016
TBR=rkc@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276656

Review URL: https://codereview.chromium.org/273533004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277835 0039d316-1c4b-4281-b951-d872f2087c98

The fix is in Blink r176323, and the blink roll just went past that.

BUG=385386
NOTRY=true
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/333273007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277834 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383153

Review URL: https://codereview.chromium.org/335243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277833 0039d316-1c4b-4281-b951-d872f2087c98

Adds BIONIC to the manifest.  This is a precursor to automated updates for bionic.

This change only affects the SDK updater and the automated JSON generator, and is not visible to chrome.

R=binji@chromium.org
BUG=344574
NOTRY=true
TEST=naclsdk update -U

Review URL: https://codereview.chromium.org/339933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277832 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383619
NOTRY=True

Review URL: https://codereview.chromium.org/339223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277831 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277830 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=176312:176327&mode=html
TBR=schenney@chromium.org,jamesr@chromium.org
BUG=

Review URL: https://codereview.chromium.org/332403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277829 0039d316-1c4b-4281-b951-d872f2087c98

Some logging statements snuck in.

BUG=381260
R=mattm@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/338653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277828 0039d316-1c4b-4281-b951-d872f2087c98

running under Dr.Memory

TBR=bruening@chromium.org
BUG=NONE

Review URL: https://codereview.chromium.org/343473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277826 0039d316-1c4b-4281-b951-d872f2087c98

Should say 'details' instead of 'advanced'.

BUG=381260
NOTRY=true

Review URL: https://codereview.chromium.org/343463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277824 0039d316-1c4b-4281-b951-d872f2087c98

We pass around ExtensionInstallPrompt::Prompt a lot by value and reference,
but should probably just have it ref-counted instead.  It's an expensive
object to copy (which we do far too much right now), and passing around
weak references is dangerous (and leads to crashing).

TBR=ben@chromium.org (c/b/ui minus c/b/ui/cocoa)
TBR=kinaba@chromium.org (c/b/chromeos/file_manager)
TBR=koz@chromium.org (c/b/apps)

All TBRs are for strictly mechanical changes.

Review URL: https://codereview.chromium.org/313203004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277823 0039d316-1c4b-4281-b951-d872f2087c98

Set the button size after setting the border.
(this takes the updated insets into account)

Refine BubbleFrameView's title bar layout calculations.
Return the close button's right inset in GetTitleInsets.

See before/after pics on the bug (expected is with this CL).

BUG=385422
TEST=Views dialogs place the (x) close button correctly.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/339063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277822 0039d316-1c4b-4281-b951-d872f2087c98

> Remove more unretained
> 
> BUG=349083
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277137
> 
> Review URL: https://codereview.chromium.org/322233002

TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/330623005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277821 0039d316-1c4b-4281-b951-d872f2087c98

BUG=385308

Review URL: https://codereview.chromium.org/336373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277820 0039d316-1c4b-4281-b951-d872f2087c98

* Shorten/simplify
* unix_hacker()-style functions should be defined inline, others not
* Eliminate unnecessary get()s
* Add more typedefs
* TabStrip has no subclasses, so don't declare anything protected
* Eliminate code that handles unselected tabs being wider than selected tabs
* No else after return
* Fix spelling error
* Definition order should match declaration order

BUG=none
TEST=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/331343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277819 0039d316-1c4b-4281-b951-d872f2087c98

(1) Prerenders an Instant search base page on the receipt of a high-confidence search suggestion.
(2) Prefetches the search results for the high-confidence suggestion using the prerendered page.
(3) When the user commits the search query, Android Chrome submits the query to the prerendered page and swaps the active tab contents with the prerendered contents.

BUG=382694
TEST= Apply this patch, build Android Chrome and run it against the server url specified in go/yzcku. Type a search query in the LocationBar. Android Chrome should identify the high-confidence suggestion for the typed query and prefetch the results for that suggestion. Commit the typed query. Android Chrome should swap the active tab contents with the prerendered page contents. You should see the search results instantaneously.

Review URL: https://codereview.chromium.org/321943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277818 0039d316-1c4b-4281-b951-d872f2087c98

glFlush() in render_widget_host_view_mac.mm requires gl.h since
10.9 SDK (I suppose it was included implicitly before).

Review URL: https://codereview.chromium.org/332383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277817 0039d316-1c4b-4281-b951-d872f2087c98

It's possible that we end up hanging the browser
process waiting for the response to a popup window
due to a bug in the AwContents hand-over when swapping
out the popup content into the user-supplied WebView.

This patch ensures that we don't end up with two AwContents
instances pointing to the same java AwContentsClientBridge
java object during deletion.

BUG=

Review URL: https://codereview.chromium.org/305823005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277816 0039d316-1c4b-4281-b951-d872f2087c98

- use high dpi resources
- add a logo to the tray
- css fixes: increase the tray height, hover/focused states of pods,
increase the profile name box
- ensure non-focused pods are faded out
- update/make equal the padding between pod rows and columns
- change the style of the action box drop down arrow

See crbug for mocks.
Screenshots:
https://drive.google.com/file/d/0B1B1Up4p2NRMUDFqWmgtSGVlbmM/edit?usp=sharing

BUG=380273

Review URL: https://codereview.chromium.org/330283004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277815 0039d316-1c4b-4281-b951-d872f2087c98

> Modifies AudioInputCallback::OnData and use media::AudioBus instead of plain byte vector
>
> BUG=375155
> TEST=WebRTC and WebSpeech demos
>
> Review URL: https://codereview.chromium.org/314713002

R=henrika@chromium.org
TBR=henrika@chromium.org

Review URL: https://codereview.chromium.org/335343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277814 0039d316-1c4b-4281-b951-d872f2087c98

If resolution failed, callback receives empty pointer.

BUG=385392

Review URL: https://codereview.chromium.org/333243007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277808 0039d316-1c4b-4281-b951-d872f2087c98

setlocale() isn't part of the std:: namespace. This was breaking libc++ builds.

BUG=318770
TBR=stgao@chromium.org
NOTRY=true
TEST=built with libc++ and libstdc++

Review URL: https://codereview.chromium.org/342433005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277805 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Change HungPluginTabHelper to listen for infobar changes through Observer style. (https://codereview.chromium.org/297293002/)

Reason for revert:
Caused a crash on Windows. See crbug.com/354380

Original issue's description:
> Change HungPluginTabHelper to listen for infobar changes through Observer style.
> 
> Test plan:
> 
> 1) out/Debug/chrome --no-sandbox --ppapi-flash-path=/opt/google/chrome/PepperFlash/libpepflashplayer.so --ppapi-flash-version=`grep -i version /opt/google/chrome/PepperFlash/manifest.json | awk '{print $2}' | awk -F"\"" '{print $2}'`
> 2) Go to a site that has flash, e.g., http://www.flash-game.net/
> 3) Open Task Manager, Shift+Esc
> 4) Search for "Plug-in: Shockwave Flash" in the list.
> 5) Select it and click on "End process" button.
> 6) Go to the website and observe the infobar.
> 
> Another way to test it is:
> 
> 1) Add an infinite loop into ppapi/examples/scripting/post_message.cc
> 2) Build ppapi_example_post_message
> 3) out/Debug/chrome --no-sandbox --register-pepper-plugins="/home/tfarina/chromium/src/out/Debug/lib/libppapi_example_post_message.so;application/x-ppapi-post-message-example" ppapi/examples/scripting/post_message.html
> 
> BUG=354380
> TEST=see above
> R=pkasting@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277292
NOTRY=true
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/338353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277804 0039d316-1c4b-4281-b951-d872f2087c98

This updates actions.xml to account for the new extended reporting option.

BUG=383866
NOTRY=true

Review URL: https://codereview.chromium.org/340553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277803 0039d316-1c4b-4281-b951-d872f2087c98

Generated using
src/tools/metrics/histograms/update_use_counter_feature_enum.py

NOTRY=true

Review URL: https://codereview.chromium.org/335373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277802 0039d316-1c4b-4281-b951-d872f2087c98

Previously, we would use the X-coordinate of the left edge of the dragged tabs,
and check whether it fell within the left or right half of each tab in the
strip.

This had a couple problems.  First, because tabs are wider than they appear (due
to a significant portion of the tab being the outside pieces that are flush or
nearly-flush with the top of the toolbar), the true left edge of the dragged
region is "to the left of" where the user thinks the drag point ought to be, and
this discrepancy becomes noticeable as tabs get narrow, with the insertion
sometimes seeming to happen a tab to the left of where it "ought to".  Instead,
we now use a (hardcoded) 16-px offset into the drag region, which is much closer
to where the user perceives the "start" of the region to be.

Second, again because tabs are wider than they appear, the right half of one tab
can overlap with the next tab, indeed sometimes even overlapping with the right
half of that next tab, so the insertion point can be calculated in a way that
appears to be off by a tab or so.  Instead, we now simply use the regions
between successive tab midpoints to calculate the desired insertion index.

The result of this is that the apparent "slop zone" between tabs gets slightly
larger, and it takes a slightly further drag to drag to the very beginning of
the tabstrip; but most noticeably, when dragging tabs that are very narrow (e.g.
in tabstrip overflow), dragging feels much more predictable and less like the
instant you grab a set of tabs, they get moved to somewhere strange.

BUG=none
TEST=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/338263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277801 0039d316-1c4b-4281-b951-d872f2087c98

BUG=384575

Review URL: https://codereview.chromium.org/339113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277800 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372306

Review URL: https://codereview.chromium.org/338113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277799 0039d316-1c4b-4281-b951-d872f2087c98