GitLab

e.g.

d:\src\cr2\src\crypto\p224.cc(478): error C2220: warning treated as error - no 'object' file generated
d:\src\cr2\src\crypto\p224.cc(478): warning C4456: declaration of 'j' hides previous local declaration
d:\src\cr2\src\crypto\p224.cc(447): note: see declaration of 'j'
d:\src\cr2\src\crypto\p224.cc(498): warning C4456: declaration of 'i' hides previous local declaration
d:\src\cr2\src\crypto\p224.cc(447): note: see declaration of 'i'
d:\src\cr2\src\crypto\p224.cc(516): warning C4456: declaration of 'i' hides previous local declaration
d:\src\cr2\src\crypto\p224.cc(447): note: see declaration of 'i'
d:\src\cr2\src\crypto\p224.cc(526): warning C4456: declaration of 'i' hides previous local declaration
d:\src\cr2\src\crypto\p224.cc(447): note: see declaration of 'i'
d:\src\cr2\src\crypto\p224.cc(694): warning C4458: declaration of 'x' hides class member
d:\src\cr2\src\crypto\p224.h(35): note: see declaration of 'crypto::p224::Point::x'
d:\src\cr2\src\crypto\p224.cc(694): warning C4458: declaration of 'y' hides class member
d:\src\cr2\src\crypto\p224.h(35): note: see declaration of 'crypto::p224::Point::y'

R=rsleevi@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/945633003

Cr-Commit-Position: refs/heads/master@{#317398}

When file errors are encountered by the chromium "env" for leveldb,
we encode the failing method and the specific error code into the messages
returned to leveldb so that when leveldb in turn returns the error
to the caller (e.g. Indexed DB) we can update histograms and/or
or emit more specific errors (e.g. disk full vs. i/o error).

This mechanism used to encode either base::File::Error codes (platform
file error) or "errno" codes, depending on which filesystem API was
used. Now that we only use base::File we can drop support for parsing
the "errno" codes.

R=cmumford@chromium.org

Review URL: https://codereview.chromium.org/936073003

Cr-Commit-Position: refs/heads/master@{#317397}

With ICU 54, the function name suffix has to be 54 instead 52.

BUG=223352,428145
TEST=Tsan bot does not complain about a data race in icu/source/common/cmemory.c
TBR=jyasskin
NOTRY=true

Review URL: https://codereview.chromium.org/946683003

Cr-Commit-Position: refs/heads/master@{#317396}

BUG=

Review URL: https://codereview.chromium.org/943853002

Cr-Commit-Position: refs/heads/master@{#317395}

Cause:
remoting.clientSession.disconnect() accidentally removed in
https://codereview.chromium.org/814133007

Fix:
Call remoting.clientSession.disconnect(), this will cause
a client state change and invoke onClientStateChange_

BUG=460324

Review URL: https://codereview.chromium.org/942933002

Cr-Commit-Position: refs/heads/master@{#317394}

The Windows HID library requires output report buffers to be exactly
the maximum length specified in the OutputReportByteLength field of
HIDP_CAPS. This patch automatically pads output reports to this length
with zeros and rejects reports longer than this length.

BUG=439775

Review URL: https://codereview.chromium.org/943783003

Cr-Commit-Position: refs/heads/master@{#317393}

BUG=460272, 403800

Review URL: https://codereview.chromium.org/942673002

Cr-Commit-Position: refs/heads/master@{#317392}

R=alekseys@chromium.org
BUG=459993

Review URL: https://codereview.chromium.org/927943006

Cr-Commit-Position: refs/heads/master@{#317391}

BUG=450050

Review URL: https://codereview.chromium.org/941473002

Cr-Commit-Position: refs/heads/master@{#317390}

BUG=459419

Review URL: https://codereview.chromium.org/933853003

Cr-Commit-Position: refs/heads/master@{#317389}

Adds ConnectivityChecker and CastResourceDispatcherHostDelegate
classes. Performs connectivity checks on startup, network changes
and failed resource loads.

R=gunsch@chromium.org,byungchul@chromium.org
BUG=336640

Review URL: https://codereview.chromium.org/925183003

Cr-Commit-Position: refs/heads/master@{#317388}

BUG=408152

Review URL: https://codereview.chromium.org/938713004

Cr-Commit-Position: refs/heads/master@{#317387}

https://codereview.chromium.org/939753003/ will change the name of the variable
used to build the network service from source. This CL prepares for that
change.

Review URL: https://codereview.chromium.org/944843002

Cr-Commit-Position: refs/heads/master@{#317386}

BUG=460512

Review URL: https://codereview.chromium.org/901673002

Cr-Commit-Position: refs/heads/master@{#317385}

d:\src\cr2\src\net\url_request\url_request_filter.cc(149): error C2220: warning treated as error - no 'object' file generated
d:\src\cr2\src\net\url_request\url_request_filter.cc(149): warning C4456: declaration of 'it' hides previous local declaration
d:\src\cr2\src\net\url_request\url_request_filter.cc(141): note: see declaration of 'it'

d:\src\cr2\src\net\url_request\url_request_http_job.cc(917): error C2220: warning treated as error - no 'object' file generated
d:\src\cr2\src\net\url_request\url_request_http_job.cc(917): warning C4456: declaration of 'context' hides previous local declaration
d:\src\cr2\src\net\url_request\url_request_http_job.cc(859): note: see declaration of 'context'

d:\src\cr2\src\net\url_request\url_request_job_manager.cc(79): error C2220: warning treated as error - no 'object' file generated
d:\src\cr2\src\net\url_request\url_request_job_manager.cc(79): warning C4456: declaration of 'job' hides previous local declaration
d:\src\cr2\src\net\url_request\url_request_job_manager.cc(71): note: see declaration of 'job'

ninja: build stopped: subcommand failed.
R=eroman@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/937393002

Cr-Commit-Position: refs/heads/master@{#317384}

BUG=460463

Review URL: https://codereview.chromium.org/945803007

Cr-Commit-Position: refs/heads/master@{#317383}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/de34936..8ca446a

TBR=yosin@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/946613003

Cr-Commit-Position: refs/heads/master@{#317382}

Revert of Test that visual state callbacks do not deadlock. (patchset #6 id:100001 of https://codereview.chromium.org/939673002/)

Reason for revert:
Timing out on Blink waterfall. See https://code.google.com/p/chromium/issues/detail?id=458577#c10 .

Original issue's description:
> Test that visual state callbacks do not deadlock.
>
> Visual state callbacks should always be received,
> even if there are no pending commits. We add
> a test for that. See crbug/458577 for more details.
>
> BUG=458577
>
> Committed: https://crrev.com/dcc18cb569b31bc07c97d49573e695ec8b1f80c0
> Cr-Commit-Position: refs/heads/master@{#317306}

TBR=piman@chromium.org,sievers@chromium.org,skyostil@chromium.org,igsolla@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=458577

Review URL: https://codereview.chromium.org/942973002

Cr-Commit-Position: refs/heads/master@{#317381}

BUG=452592

Review URL: https://codereview.chromium.org/945723003

Cr-Commit-Position: refs/heads/master@{#317380}

There have been several user complaints regarding extra announcements coming most likely from background tabs. Especially with many tabs open, this can become an issue. We should reexamine some other way to surface this type of functionality in ChromeVox Next.

The original cl was commited pre-Chrome migrated ChromeVox.

TBR=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/944063002

Cr-Commit-Position: refs/heads/master@{#317379}

For studies where there is a single group with 100%
probability, avoid doing more expensive random entropy
computation, since it's not needed to know the final
result.

BUG=460481

Review URL: https://codereview.chromium.org/947493002

Cr-Commit-Position: refs/heads/master@{#317378}

Work around exceptions when the 'high' value for a histogram is not present. This happens when the histogram hits the max value.

BUG=455349

Review URL: https://codereview.chromium.org/941803002

Cr-Commit-Position: refs/heads/master@{#317377}

Java-based WebContentsObservers can be relatively expensive, incurring
JNI overhead, including necessary object conversions, for each callback.
As AccessibilityInjector only relies on 2 observer methods, instead use
ContentViewCore's observer to signal the necessary events.

BUG=457748,440134

Review URL: https://codereview.chromium.org/941353002

Cr-Commit-Position: refs/heads/master@{#317376}

Invalid baked-in configs would be leaked (in FromJSON) and then crash
due to a null deref (in AddContext).

This change also makes two minor improvements:
- pass scoped_refptrs by const ref
- use a StringPiece rather than a std::string when parsing bake-in configs

BUG=460483
R=ttuttle@chromium.org

Review URL: https://codereview.chromium.org/945923002

Cr-Commit-Position: refs/heads/master@{#317375}

Fix what looks like a copy-paste error in the assignment of
|was_alternate_protocol_available|.

Review URL: https://codereview.chromium.org/941973004

Cr-Commit-Position: refs/heads/master@{#317374}

Reland:Refactored pixel format resize operations in media/video/capture into a function called VideoCaptureFormat::GetSizeForVideoPixelFormat().

Relanding Issue https://codereview.chromium.org/897483002.

Refactored pixel format resize operations in  media/video/capture into a function called VideoCaptureFormat::GetSizeForVideoPixelFormat().

TEST=VideoCaptureDeviceTest.* in media_unittests pass.

Committed: https://crrev.com/79288ba0b63021e8731e0401b8a4a9055d33fa10
Cr-Commit-Position: refs/heads/master@{#315175}

Review URL: https://codereview.chromium.org/907113002

Cr-Commit-Position: refs/heads/master@{#317373}

This patch implements the estimation of (dis)chargingTime on devices
running Android L (and above). Android L supports new properties in
BatteryManager which can be used to provide such estimates.

BUG=401553
TEST=http://jsbin.com/battery-status-test

Review URL: https://codereview.chromium.org/874713003

Cr-Commit-Position: refs/heads/master@{#317372}

This is the first of three CLs to add synthetic gesture commands to the DevTools Input domain. The changes need to be split up so that the code generated from protocol.json has some stub functions to call.

1. crrev.com/846113004
2. crrev.com/841013002
3. crrev.com/792883007

BUG=448182

Review URL: https://codereview.chromium.org/846113004

Cr-Commit-Position: refs/heads/master@{#317371}

d:\src\cr2\src\net\quic\crypto\cert_compressor.cc(198): error C2220: warning treated as error - no 'object' file generated
d:\src\cr2\src\net\quic\crypto\cert_compressor.cc(198): warning C4456: declaration of 'i' hides previous local declaration
d:\src\cr2\src\net\quic\crypto\cert_compressor.cc(189): note: see declaration of 'i'

d:\src\cr2\src\net\quic\crypto\quic_crypto_server_config.cc(668): error C2220: warning treated as error - no 'object' file generated
d:\src\cr2\src\net\quic\crypto\quic_crypto_server_config.cc(668): warning C4456: declaration of 'client_hello_serialized' hides previous local declaration
d:\src\cr2\src\net\quic\crypto\quic_crypto_server_config.cc(652): note: see declaration of 'client_hello_serialized'
d:\src\cr2\src\net\quic\crypto\quic_crypto_server_config.cc(1336): warning C4456: declaration of 'i' hides previous local declaration
d:\src\cr2\src\net\quic\crypto\quic_crypto_server_config.cc(1292): note: see declaration of 'i'
d:\src\cr2\src\net\quic\crypto\quic_crypto_server_config.cc(1481): warning C4457: declaration of 'token' hides function parameter
d:\src\cr2\src\net\quic\crypto\quic_crypto_server_config.cc(1472): note: see declaration of 'token'
d:\src\cr2\src\net\quic\crypto\quic_crypto_server_config.cc(1493): warning C4457: declaration of 'token' hides function parameter
d:\src\cr2\src\net\quic\crypto\quic_crypto_server_config.cc(1472): note: see declaration of 'token'

d:\src\cr2\src\net\quic\crypto\strike_register.cc(498): error C2220: warning treated as error - no 'object' file generated
d:\src\cr2\src\net\quic\crypto\strike_register.cc(498): warning C4456: declaration of 'i' hides previous local declaration
d:\src\cr2\src\net\quic\crypto\strike_register.cc(453): note: see declaration of 'i'
c:\program files (x86)\microsoft visual studio 14.0\vc\include\utility(151): note: while compiling class template member function 'std::pair<uint32,uint32>::pair<uint32,uint32,void>(std::pair<uint32,uint32> &&) noexcept'
d:\src\cr2\src\net\quic\crypto\strike_register.cc(502): warning C4456: declaration of 'bit' hides previous local declaration
d:\src\cr2\src\net\quic\crypto\strike_register.cc(454): note: see declaration of 'bit'
ninja: build stopped: subcommand failed.

d:\src\cr2\src\net\quic\quic_framer.cc(1350): error C2220: warning treated as error - no 'object' file generated
d:\src\cr2\src\net\quic\quic_framer.cc(1350): warning C4456: declaration of 'i' hides previous local declaration
d:\src\cr2\src\net\quic\quic_framer.cc(1338): note: see declaration of 'i'
d:\src\cr2\src\net\quic\quic_framer.cc(2102): warning C4456: declaration of 'time_delta_us' hides previous local declaration
d:\src\cr2\src\net\quic\quic_framer.cc(2080): note: see declaration of 'time_delta_us'
ninja: build stopped: subcommand failed.

BUG=440500
R=rtenneti@chromium.org

Review URL: https://codereview.chromium.org/941933002

Cr-Commit-Position: refs/heads/master@{#317370}

Adding knobs on HQP provider. Having an option of experimenting with topicality score and changing final relevance score ranges from omnibox bundled params.

1. Option to suppress the URLs with topicality score lower than the given threshold. This way we can control the URLs with high popularity and low topicality scoring.

2. Changing the final-relevance score buckets to linearly interpolate with in-certain ranges. This will help to control the score ranges.

With above options one can set the bundled params. Ex:

HQPExperimentalScoringEnabled="true"
HQPExperimentalScoringTopicalityThreshold="0.8"
HQPExperimentalScoringBuckets="0.0:400,1.5:600,12.0:1300,20.0:1399"

More details can be found in the bug: crbug/306198

BUG=306198
TEST=ScoredHistoryMatchTest.GetFinalRelevancyScore

Review URL: https://codereview.chromium.org/905023003

Cr-Commit-Position: refs/heads/master@{#317369}

Infobar which allows user to choose Credentials.
Infobar is triggered via Credentials Manager API.

R=vabr@chromium.org,brettw@chromium.org,newt@chromium.org
BUG=454815

Review URL: https://codereview.chromium.org/861103002

Cr-Commit-Position: refs/heads/master@{#317368}

The test was not resilient against arbitrary pipeline depths and encode
delays. It was possible for the encode request to keep overwriting
keframe_requested_at_ faster than the deadline check by which we would've
failed if no keyframe was provided. Thus it was possible for the test to
always pass, even without getting any keyframes.

Simplify this by just checking that each keyframe arrives before
every keyframe_period_ + kMaxKeyframeDelay.

Also, some cleanup for fake encoder validator creation.

BUG=None
TEST=veatest --gtest_filter=ForceKeyframes*

Review URL: https://codereview.chromium.org/942693003

Cr-Commit-Position: refs/heads/master@{#317367}

The ProcUtil tests HasOpenDirectory HasOpenDirectoryWithFD use
/dev to test HasOpenDirectory. /dev fails to open on Android
due to SELinux. This change picks /proc/self instead, which
will work on all linux platforms.

BUG=459360
TEST=sandbox_linux_unittests

Review URL: https://codereview.chromium.org/939723003

Cr-Commit-Position: refs/heads/master@{#317366}

Update //third_party/usb_ids/usb.ids to version 2015.02.03, released
2015-02-03 at 20:34:06.

This file was fetched from http://www.linux-usb.org/usb.ids and
includes vendor and product IDs for new USB devices and updates to
existing entries.

BUG=

Review URL: https://codereview.chromium.org/938203003

Cr-Commit-Position: refs/heads/master@{#317365}

BUG=454198
R=ellyjones@chromium.org

Review URL: https://codereview.chromium.org/935073003

Cr-Commit-Position: refs/heads/master@{#317364}

BUG=453471

Review URL: https://codereview.chromium.org/922293004

Cr-Commit-Position: refs/heads/master@{#317363}

This requirement is only a requirement on the Manifest content. It is
then up to the ManifestIconSelector to pick the best icon which might
be a smaller one.

BUG=457399

Review URL: https://codereview.chromium.org/946573002

Cr-Commit-Position: refs/heads/master@{#317362}

Feature is implemented in cl https://codereview.chromium.org/944533002/.
Checking in user visible string separately so that it is in time for translation.

BUG=456247

Review URL: https://codereview.chromium.org/939393002

Cr-Commit-Position: refs/heads/master@{#317361}

This moves EXPECT_CALL invocations into separate method, reducing
code duplicaton and increasing readability.

Also moves passphrase setting and state checks to separate methods,
also reducing code duplication.

BUG=

Review URL: https://codereview.chromium.org/937183002

Cr-Commit-Position: refs/heads/master@{#317360}

This will allow custom media renderers to instantiate
default renderer factory, which expects media log.

BUG=457959

Review URL: https://codereview.chromium.org/943903002

Cr-Commit-Position: refs/heads/master@{#317359}