GitLab

It is only used by the old-style Mojo JS bindings, which have been removed.

Bug: 718047
Change-Id: Ib3e112f8b2a9cd772bb15146ee52eb1de63b2eff
Reviewed-on: https://chromium-review.googlesource.com/809772
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522160}

The failure is likely caused by the scrollbar thickness varied across
platforms. So I use MaiximumScrollOffset as expected value in test.
This patch also check nullptr when getting ScrollableArea to fix a
clusterfuzz failure in the previous patch.

This is a reland of a9783e12
Original change's description:
> Snap at GestureScrollEnd on main thread.
>
> As the first step of ScrollSnapPoints, this patch implements it on main
> thread at GestureScrollEnd. It introduces necessary data structures:
> SnapAreaData and SnapContainerData, updates the data after style change
> and layout, implements a naive algorithm to select snap points at
> intended-end-position, adds unit-tests for logic and adds sim-tests for
> behavior.
>
> Bug: 778257
> Change-Id: I307d51254bd9ab9b7a42b0614d181adac662fa47
> Reviewed-on: https://chromium-review.googlesource.com/756887
> Reviewed-by: Jeremy Roman <jbroman@chromium.org>
> Reviewed-by: Darren Shen <shend@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Reviewed-by: Majid Valipour <majidvp@chromium.org>
> Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#521840}

TBR=bokan@chromium.org,jbroman@chromium.org,majidvp@chromium.org,shend@chromium.org

Bug: 778257
Change-Id: I437e7491c4a98c8ecaa5b15124c48e97e60fa57a
Reviewed-on: https://chromium-review.googlesource.com/810059
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Reviewed-by: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522159}

Suggestion from oshima@ and xdai@ from
https://chromium-review.googlesource.com/c/chromium/src/+/767044 but
already commited when seen.

Test: ash_unittests SplitViewControllerTest.LongPressExitsSplitView
Bug: 784013
Change-Id: Ib4123316e78060c4dbab86eb27dd193b8c888d9f
Reviewed-on: https://chromium-review.googlesource.com/798638
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522158}

NOTRY=true

Change-Id: Icc55d5cb438f4f74fb2b8ba66046375262844c08
Reviewed-on: https://chromium-review.googlesource.com/811292Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Katie D <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522157}

The views-based login screen shows the users on the device and the
basic login flow works, but lots of additional features, such as
registering a new user, do not work yet.

Bug: 784495
Change-Id: I67ee83d1ca84fedf465882a90e6be47e6b079967
Reviewed-on: https://chromium-review.googlesource.com/767647Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522156}

Background:
Usually if focus traversal is handled by FocusManager, then it will select
all text in the textfield in AboutToRequestFocusFromTabTraversal(). But we
customized the focus movement by using RequestFocus() to move focus from
the first search result to the search box. So
AboutToRequestFocusFromTabTraversal() will not be called, so we need to
manually select all text.

Changes:
1. Search box should select all query on focus traversal.
2. Search box should not select all query when OnFocus() is triggered by
   key event redirected to the search box. (e.g. backspace, character
   keys.)

Bug: 791754
Change-Id: I4220a83198f5d84780762a670a994cadcdfde05f
Reviewed-on: https://chromium-review.googlesource.com/809717Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522155}

We have not supported valgrind for some time (it was never ported to
the GN build IIUC, and has been obsoleted by ASan/MSan/TSan).

BUG=791518,431702

Change-Id: Ibfad450ee2973cf5916986559f543aced08e108a
Reviewed-on: https://chromium-review.googlesource.com/805894Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#522154}

This patch supports LayoutInline::Paint() when LayoutNGPaintFragments
is enabled.

Normally LayoutBlockFlow paints its InlineBox (in legacy) or its
NGPaintFragment (in LayoutNGPaintFragments), but when the inline box
has self painting layer (e.g., position: relative) and in some other
cases, this function is used to paint inline boxes.

The unexpected clipping still occurs. Investigation continues.

Bug: 714962
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iccd9fcfbce5b0fc1bbfb523730e7005f7d6e02d6
Reviewed-on: https://chromium-review.googlesource.com/803875
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522153}

Extensions can update the default settings of browser actions (such as
badge text, popup url, icon, and more). These settings are persisted in
storage across runs. However, currently the logic to persist these and
rewrite the values in storage is being triggered even if the extension
is only updating a specific tab's value (in which case it will just
rewrite all the same values). This is costly, as it requires both thread
hops and disk IO.

As a first step and low-hanging fruit, ensure that we don't try to write
the default values if the extension only updated the settings for a
specific tab (in which case we should know that nothing in the default
settings changed).

Bug: 505676
Change-Id: I612408740e88b76b234bf0d38433ab716485829b
Reviewed-on: https://chromium-review.googlesource.com/768307
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522152}

By default, small allocations are pruned from the heap dump. This reduces the
size of the compressed trace by 100x. If pruning is disabled, the
chrome://tracing UI may be unable to take or load the trace. The trace can
still be saved directly using chrome://memory-internals.

Other mechanisms [e.g. diff_heap_profiler.py] may be necessary to examine the
trace. Note that automatically uploaded traces will always be pruned. This only
affects manually taken memory-infra traces.;

Bug: 
Change-Id: I9aacc1d4e9ea65185b87f0a6ad53d727083576e8
Reviewed-on: https://chromium-review.googlesource.com/808995
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522151}

This allows the tracing infrastructure to query the list of categories we
recognize, so they are shown in the UI.

BUG=786091

Change-Id: I6f2fa08855944fd0e0c04f4431704477be551706
Reviewed-on: https://chromium-review.googlesource.com/811587Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522150}

Bug:792495
Change-Id: I7a2df9538b156721aa7cddc8171f3a03b5550b8c

TBR=hablich@chromium.org

Change-Id: I7a2df9538b156721aa7cddc8171f3a03b5550b8c
Reviewed-on: https://chromium-review.googlesource.com/810888Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#522149}

With one of the next roll V8 will stop running gc before reporting
scripts.

R=alph@chromium.org

Bug: chromium:655701
Change-Id: I58b86bb151420c0d848d3f1ccd4deb1d7890beb9
Reviewed-on: https://chromium-review.googlesource.com/806799
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522148}

This change moves all of the swipe detecting from the bottom sheet
into its own class. A relatively simple interface has been introduced
to prevent needing the entire bottom sheet to detect swipes.

BUG=

Change-Id: If8c61df4009320e016903d6f1ed0c231c9330e02
Reviewed-on: https://chromium-review.googlesource.com/792337
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522147}

BUG=761307
R=thestig@chromium.org
TBR=dpranke@chromium.org
CC=​ivica.bogosavljevic@imgtec.com,ukai@chromium.org,yyanagisawa@chromium.org,shinyak@chromium.org

Change-Id: Ib3419fc51c849cf8782a1d0910880c0e42c616e0
Reviewed-on: https://chromium-review.googlesource.com/809627Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522146}

This is the new version of base::debug::ScopedCrashKey.

Bug: 598854
Change-Id: Idfea07f414c4c68fb51909de467c8e666acd841d
Reviewed-on: https://chromium-review.googlesource.com/811287
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522145}

Remove ietestcenter/css3/grid/grid-column-003.htm from TestExpectations
as we didn't manage to reproduce the leak.
Let's see if the bots detect it again or it was already fixed.

BUG=622915

Change-Id: Ibd03c81d5074c6c73cf78abba3ef0abec07aea36
Reviewed-on: https://chromium-review.googlesource.com/809206Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#522144}

To do this, taint the source graphic of a canvas input to filters if it
is cross-origin.

Bug: 778506
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I7e070c887dbb8bfce64f660790d58836f5d75762
Reviewed-on: https://chromium-review.googlesource.com/782649
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#522143}

Bug: 
Change-Id: I872a6585d2a8a459ed06eb21d8eb92b8e14fc0b9
Reviewed-on: https://chromium-review.googlesource.com/802035Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522142}

Currently if you click on an item in the bookmark
bar, the item will lose its highlight state.

This CL makes sure it retains it by updating the
highlight on a mouse up.

Testing:
Unit test BookmarkButtonTest.MouseUpAndDownHighlight

Bug: 613208
Change-Id: I2a3063af49065d3e985f681f69b0978666455243
Reviewed-on: https://chromium-review.googlesource.com/804695Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522141}

The description for the ExtensionSettings policy exceeds the
 maximum size for Windows GPO templates. Move the full description
 to a seperate page on chromium.org and include a link here to
 the full description.

Bug: 789087
Change-Id: Ia56d861af49981b5eac8da57b63ad65040cff3bc
Reviewed-on: https://chromium-review.googlesource.com/810106Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Nick Peterson <nrpeter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522140}

Add double tap gesture recognition to MediaControlOverlayPlayButton so
it can detect double tap gestures on the side and jump accordingly. Adds
LayoutTests as a virtual test suite so they are tested with the modern
media controls flag on.

BUG=779989

TBR=jbroman@chromium.org

Change-Id: I2d6e3c79d5ca3b447eda70f35da3dd22283a14b3
Reviewed-on: https://chromium-review.googlesource.com/800150
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522139}

That was clearly not the author's intention.

Bug: 788337
Change-Id: I0b60d27ecf339aa2ca3caecdeb6327e08b2b3039
Reviewed-on: https://chromium-review.googlesource.com/810746Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522138}

The semantics of this property change pre- and post- surface synchronization.

BUG=789259

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I511d0c6fe2c465c7ef36076bd3b461f7d216a081
Reviewed-on: https://chromium-review.googlesource.com/808997Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522137}

Bug: 768373
Change-Id: I65b73ca4ff5ec2f318a2a2d03551b988c102e809
Reviewed-on: https://chromium-review.googlesource.com/776717
Commit-Queue: Lalit Maganti <lalitm@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522136}

Follow-up for that CL:
https://chromium-review.googlesource.com/803797

So we shouldn't re-declare common function in different places
since it breaks jumbo build (where multiple .cc files get merged).

Change-Id: I68a3a75ca31a373557f3bb8106140828eae23da6
Reviewed-on: https://chromium-review.googlesource.com/811084Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522135}

Fix a bug in UIControlsOzone that tracked the mouse button status for
each display host separately rather than one global state. This caused
all dual display tab drag tests to fail once the mouse warps to the other
display as it used to send a mouse move event rather than drag event to
continue the drag in the other host.

Also, tab dragging between two displays with touch is impossible, so no need
to test that as it will always fail.

BUG=714578
TEST=interactive_ui_tests --enable-pixel-output-in-tests --gtest_filter=*DetachToBrowserInSeparateDisplayTabDragControllerTest.*

Change-Id: I08132f41aa4923d2a2ae4faf6573068c1e2fcb08
Reviewed-on: https://chromium-review.googlesource.com/809714
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522134}

Currently BackgroundImageGeometry computes a tiling geometry in the
presence of borders.  This is correct, because (at least for
background-origin: padding-box/content-box) backgrounds are repeated
logically underneath the border.

But if the border is opaque and fully obscures the background, these
extra tiles are redundant.  What's more, tiling forces us to use
image shaders for painting, unnecessarily.

This CL introduces logic to minimize the background draw rect, and avoid
unnecessary tiling for opaque borders.

Also, because it is mostly used as an offset, replace box_outset with
box_offset in BackgroundImageGeometry::Calculate.

BUG=676636

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I6b7095036a197df104fb34422d33943f5901aa27
Reviewed-on: https://chromium-review.googlesource.com/809229
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522133}

Bug: 784495
Change-Id: I16557453bd167e49b2deaeb99f1c1eb2bb80d1c7
Reviewed-on: https://chromium-review.googlesource.com/809630Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522132}

Currently, if there's a crash - even in a debug build - on Mac, the
stack trace shown on the console (or on bots) is not symbolized. This
is because we disable this functionality when we're in the signal handler.

This makes it very frustrating for developers to diagnose failures - both
locally and on the bots. So this CL attempts to enable the symbolization.
The idea is that it's a better default since having useful stack traces
outweighs the risk involved in doing this.

TO SHERIFFS: It is possible that this may cause failures that would
previously crash to instead hang - and this may actually be worse than
the current behavior. If you see something like the above, then we may
want to revert this. I'm landing this to specifically see if we can do
this without ill effects.

BUG=

Change-Id: I9cdc03e2ee098305e32c8a4f119d7df6bdf3c3e4
Reviewed-on: https://chromium-review.googlesource.com/644142
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522131}

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I9d4b146bc1bb8f37d248df49f77452da67108866
Reviewed-on: https://chromium-review.googlesource.com/811424Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522130}

base/memory/ptr_util.h includes are changed with <memory> as well.

Bug: 755727
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ieb3fecb7841ff58dd8ddfee1c164ff522176da57
Reviewed-on: https://chromium-review.googlesource.com/807827
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522129}

This CL fixes a bug about the spinner logic for staggered background
tab opening feature. In this fix, we keep track of if the WebContents
was hiding throbber. So later when we need to show throbber, we can force
update the spinner even if the loading state is not changing.

Before: background tab keeps showing favicon even when it resume to load.
After: background tab will show spinner when it resumes to load.

For more details, see crbug.com/762133 for the desired behavior.

Bug: 762133,751210
Change-Id: Ice1643f3ebf08d2f1bf94a47245b6e272187d0fa
Reviewed-on: https://chromium-review.googlesource.com/810037
Commit-Queue: Zhen Wang <zhenw@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522128}

If the user waited 5 seconds and then hit 'Take Survey',
  recordInfoBarDisplayed would be called twice -
  once for waiting 5 seconds & once for accepting the survey.
In the second time, mSurveyInfoBarTab would be null & crash Chrome.

Bug: 791076
Change-Id: If79c2f4ddea92e6f60e575d549978c9173bf6de3
Reviewed-on: https://chromium-review.googlesource.com/809917Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Daniel Park <danielpark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522127}

Bug: none
Test: still compiles
Change-Id: Ibeb66ad808471b97d2ba7c766aae3de599b1ef94
Reviewed-on: https://chromium-review.googlesource.com/809891Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522126}

Bug: 514674
Change-Id: I60aa5d38cb31b52f74a053f2dd35a5db675a2fea
Reviewed-on: https://chromium-review.googlesource.com/627346
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522125}

This is not required now after
https://chromium-review.googlesource.com/c/chromium/src/+/802274

BUG=788937

Change-Id: I9a17610a9185a3a73fe59b3c0d64a35a13f8d41a
Reviewed-on: https://chromium-review.googlesource.com/809391Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522124}

multicol-rule-style-foo were covering exactly the same thing that
multicol-rule-foo did.

Bug: 788337
Change-Id: I4102a21194a6f99e595930054655f7aaeace432e
Reviewed-on: https://chromium-review.googlesource.com/811164Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522123}

Use mutable DataTransferItemList instead of eventSender, drag-n-drop,
CGIs, or Unicode files on the host filesystem to exercise multipart
form file upload filename encoding.

Add separate non-upload tests for dragging Unicode-named files from
the host filesystem onto <input type=file>.

This also stops relying on script-triggered onchange for input type=file, it
may be a bug - see crbug.com/792336 for discussion.

Finally, this re-fixes the out-of-process IFRAME breakage reintroduced in
https://crrev.com/521947

Technique from:

https://github.com/whatwg/html/issues/2861#issuecomment-348888148

Bug: 661819
Bug: 786539
Change-Id: I7d6c9d03770759d1552a4456d869eb544cb652a0
Reviewed-on: https://chromium-review.googlesource.com/807465Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Benjamin Wiley Sittler <bsittler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522122}

ssl_info now has a boolean is_fatal_cert_error flag. Flag gets
populated in GetSSLInfo. Separate |should_ssl_errors_be_fatal| bool was
removed from NavigationURLLoaderDelegate::OnRequestFailed and its
overrides.

Bug: 783262
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: If95f1ba06aeea177276cf10eac6b2a0484dfebbc
Reviewed-on: https://chromium-review.googlesource.com/778042Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522121}