- 31 Mar, 2018 40 commits
-
-
Yoshifumi Inoue authored
This patch changes "mixed-editability-9.html" to utilize |selection_test()| for ease of maintenance. Bug: 679977 Change-Id: Icdc428ea05eb69be3b15f563cf6126f66a7a69af Reviewed-on: https://chromium-review.googlesource.com/987416Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547386}
-
Takumi Fujimoto authored
Add the ViewsCastDialog feature, which replaces the WebUI Cast dialog with a Views toolkit dialog when enabled. The feature flag is also made accessible through chrome://flags. The implementation for the feature will land in the future. Bug: 825989 Change-Id: Ib69a2a56362093d0e42e53b747ba0fdc9f0c5778 Reviewed-on: https://chromium-review.googlesource.com/982635 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#547385}
-
Balazs Engedy authored
TBR=kpaulhamus@chromium.org Bug: 827172 Change-Id: I561b891e0440d59013c7d3da1e46062e96d30a95 Reviewed-on: https://chromium-review.googlesource.com/989552Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#547384}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/012013ee5940..0d466d22d8e2 $ git log 012013ee5..0d466d22d --date=short --no-merges --format='%ad %ae %s' 2018-03-23 svillar git cl believes I'm working inside GCE 2018-03-30 ehmaldonado gclient_scm: Don't try to update file_list if it's None. Created with: roll-dep src/third_party/depot_tools BUG=chromium:643346 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Idf2a74bcbc3fcb07d9a6cbf24d3b5c8ace6441c8 Reviewed-on: https://chromium-review.googlesource.com/989412Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547383}
-
https://skia.googlesource.com/skia.git/+log/95c478fe18ca..b33feaca1caa $ git log 95c478fe1..b33feaca1 --date=short --no-merges --format='%ad %ae %s' 2018-03-31 update-docs Update markdown files Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: Ib138ef796c7eec6eb47503ca2f64dd7cdcf5cab1 Reviewed-on: https://chromium-review.googlesource.com/989415 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547382}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c7cb8ed2a1ec..371913c4e6f0 $ git log c7cb8ed2a..371913c4e --date=short --no-merges --format='%ad %ae %s' 2018-03-29 rohitbm Kick off arc-cts-follower test suite from builders. Created with: roll-dep src/third_party/chromite The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6f67746d6d38afe47a55bb27aaf3188e036cf4ec Reviewed-on: https://chromium-review.googlesource.com/989336Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547381}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/a6bfc45b6286e358ba83f7daa769e1e9012cc7bb..eb7c3008cc85c9cfedca7690f147f5773483f941 BUG=none Change-Id: I75b00989c8c16959def5f38c70cdf6ba0e541814 Reviewed-on: https://chromium-review.googlesource.com/988192 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#547380}
-
David Tseng authored
This reverts commit bea32252. Reason for revert: various apps breaking e.g. scrolling Original change's description: > Enable ChromeVox ARC support for all apps > > Change-Id: I130db573fcc2ccbda3ce58c9d2bac845218ab1d9 > Reviewed-on: https://chromium-review.googlesource.com/961549 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: Yuki Awano <yawano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544283} TBR=dtseng@chromium.org,yawano@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I6a3c80ac74b3101a3ab756f4e0c5e74980019980 Reviewed-on: https://chromium-review.googlesource.com/989053 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#547379}
-
Blake O'Hare authored
Refactor direct calls into display::Screen. In the future, there will be more screen calls with regard to dragging the floating keyboard to adjacent displays, which will be added to this class. Change-Id: Ie45d5544ae4f18d98d2e54d8d634d11e38aa12ba Reviewed-on: https://chromium-review.googlesource.com/979878Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#547378}
-
Istiaque Ahmed authored
ContentVerifier::Shutdown is called on UI thread, but hash fetching code was testing the corresponding state variable (shutdown_) on IO thread. This is racey. Use sepearte shutdown state variables for each of UI and IO thread instead. Bug: 826621 Change-Id: I7592eede8eec4a85a60526825254b6c7a67e8fdd Reviewed-on: https://chromium-review.googlesource.com/989216 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547377}
-
Hirokazu Honda authored
VideoProtectedBufferAllocator is a newly introduced mojo interface. This implements its factory function, CreateProtectedBufferAllocator, for Viz. BUG=b:72354215 BUG=chromium:804687 TEST=Play Secure video using EXO Player TEST=CtsMediaTestCases TEST=GtsMediaTestCases Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I570a9c6778bbaa3447fbf17ed2acbf5ff2b582ee Reviewed-on: https://chromium-review.googlesource.com/983200 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#547376}
-
Hirokazu Honda authored
GpuArcVideoDecodeAccelerator (GAVDA) allocates/deallocates protected buffers by usingt ProtectedBufferAllocator. In new design, GpuArcVideoProtectedBufferAllocator (GAVPBAllocator) allocates/deallocates protected buffers, instead of GAVDA. This CL is a middle point between old design and the new design. GAVDA works rightly regardless of whether GAVPBAllocator is used or not. BUG=b:72354215 BUG=chromium:804687 TEST=Play Secure video using EXO Player. TEST=CtsMediaTestCases TEST=GtsMediaTestCases Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I2f1010c987565a7258d6a434cf05b884870e6b46 Reviewed-on: https://chromium-review.googlesource.com/883381 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
-
Stéphane Marchesin authored
This reverts commit 11b329d7. This breaks samus TBR=avi@chromium.org,marcheu@chromium.org,reveman@chromium.org,sky@chromium.org,danakj@chromium.org,alexst@chromium.org,dcastagna@chromium.org,piman@chromium.org,hoegsberg@chromium.org BUG=chromium:827188 TEST=revert fixes it Change-Id: Ieca93d4bc1d8827edc07749971f23e52291051ae Reviewed-on: https://chromium-review.googlesource.com/989076 Commit-Queue: Stéphane Marchesin <marcheu@chromium.org> Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Cr-Commit-Position: refs/heads/master@{#547374}
-
Wez authored
The existing DCHECK_EQ(result, ..) allows us to detect conditions other than wait completion, but doesn't provide any detail in case of a WAIT_FAILED result. Bug: 680698 Change-Id: Icfcda8d7f7a1664e0f966cf3774dd6aa6b5c1b13 Reviewed-on: https://chromium-review.googlesource.com/989309Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#547373}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/907239157e6a..c7cb8ed2a1ec $ git log 907239157..c7cb8ed2a --date=short --no-merges --format='%ad %ae %s' 2018-03-28 ayatane Rename venv_python script 2018-03-30 yunlian chromeos_config: Remove USE=thinlto from release builders. 2018-03-30 shapiroc CBuildBot support for YAML file 2018-03-25 jclinton cbuildbot/stages/build_stages: Make model probe at end silent Created with: roll-dep src/third_party/chromite BUG=chromium:810460,chromium:827217,chromium:none The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ifa38cba737199e75e2a1319150248a9bc1b31166 Reviewed-on: https://chromium-review.googlesource.com/989304 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Kim Paulhamus authored
TBR=darin@chromium.org Intent to ship thread: https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/intent$20ship$20web$20authentication$20api$20/blink-dev/o9RU6Vv0xeM/EGnQOExbAAAJ Bug: 664630 Change-Id: I617cec25080b4ec9df929b81494c82e04212047d Reviewed-on: https://chromium-review.googlesource.com/977031 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
-
Michael Giuffrida authored
When an AppWindow's bounds would place it on another display, reparent it to that display's root window. Bug: 827703 Test: ShellDesktopControllerAuraTest.MultipleDisplays Change-Id: I0506dbe13ef7cdb0cf88c71128e6a1b56e470780 Reviewed-on: https://chromium-review.googlesource.com/989020Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#547370}
-
Peter Kasting authored
BUG=none TEST=none Change-Id: I7bf9deba405fa33397c48d6f9e8e3340646c95a4 Reviewed-on: https://chromium-review.googlesource.com/855818 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#547369}
-
https://chromium.googlesource.com/catapult.git/+log/36c8db92200b..e910e99d1eb3 $ git log 36c8db922..e910e99d1 --date=short --no-merges --format='%ad %ae %s' 2018-03-30 crouleau Add third_party/mock/ChangeLog file that was missing. Created with: roll-dep src/third_party/catapult BUG=chromium:827614 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ia08e61818a99a8decb185c6c00e0621a09f018a1 Reviewed-on: https://chromium-review.googlesource.com/989054Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547368}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ia145650b65b89ac419db2f710ff16f51b16bf1a5 Reviewed-on: https://chromium-review.googlesource.com/989256Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#547367}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/62af4e40a8f4..012013ee5940 $ git log 62af4e40a..012013ee5 --date=short --no-merges --format='%ad %ae %s' 2018-03-30 mmoss Add tests and fixes for |None| url values in deps entries. 2018-03-30 jbudorick Kick the recipe roller to pick up gclient changes. Created with: roll-dep src/third_party/depot_tools BUG=chromium:825063,chromium:643346 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I8244d29e5855f54b16e03fa5b60f0cee4e828d36 Reviewed-on: https://chromium-review.googlesource.com/989285 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Alexandre Courbot authored
The VAAPI VEA was still using the deprecated linked_ptr where unique_ptr ought to be used. This patch performs the conversion. BUG=None TEST=Checked that video_VEAPerf was still passing on eve. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icd6096b59d4d1ef91e04347e15a52fe2a6b383fc Reviewed-on: https://chromium-review.googlesource.com/983333Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#547365}
-
https://skia.googlesource.com/skia.git/+log/e4be55dc2847..95c478fe18ca $ git log e4be55dc2..95c478fe1 --date=short --no-merges --format='%ad %ae %s' 2018-03-31 angle-skia-autoroll Roll skia/third_party/externals/angle2/ b33972d4a..d104918fd (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: I6aa144ca98bb48eb0f8b6eb1d0211b3d5e1db62b Reviewed-on: https://chromium-review.googlesource.com/989277Reviewed-by:
-
Daniel Cheng authored
For consistency, kMaxValue should share the value of the highest enumerator, not be unique. This also updates the internal macros for enumeration histograms to allow flags to be passed through, so it can be reused for both the regular and the local versions of the histogram macros. Bug: 705169, 742517 Change-Id: Ia93e18e3a69bd828f4cbc4c7f1020b4cf3f13ca1 Reviewed-on: https://chromium-review.googlesource.com/988678 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#547363}
-
https://webrtc.googlesource.com/src.git/+log/4157936823f7..0ffe03d2ef6f $ git log 415793682..0ffe03d2e --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:none,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1d66ca764c197d0761964cf1443929129e625c40 Reviewed-on: https://chromium-review.googlesource.com/988691Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547362}
-
Siddhartha authored
This reverts commit 2298aca2. Reason for revert: Remove changes made in monochrome since apk merge script needs to be updated first. Original change's description: > Revert "Reland "Enable extracting unwind table on official builds without channel"" > > This reverts commit 0db71a0d. > > Reason for revert: Monochrome apk merge is failing because the unwind > file for both apk has the same name. > > Original change's description: > > Reland "Enable extracting unwind table on official builds without channel" > > > > This reverts commit a2474b64. > > > > Reason for revert: The failure was due to parent CL getting reverted > > Relanded parent in: https://chromium-review.googlesource.com/c/chromium/src/+/984452 > > > > Original change's description: > > > Revert "Enable extracting unwind table on official builds without channel" > > > > > > This reverts commit eb07cea1. > > > > > > Reason for revert: Windows tryjobs are failing. > > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2Fwin-msvc-rel%2F81420%2F%2B%2Frecipes%2Fsteps%2Fanalyze%2F0%2Fstdout for an example. > > > > > > ERROR at //base/BUILD.gn:1802:33: Undefined identifier in string expansion. > > > "CAN_UNWIND_WITH_CFI_TABLE=$can_unwind_with_cfi_table", > > > ^------------------------ > > > "can_unwind_with_cfi_table" is not currently in scope. > > > See //BUILD.gn:65:5: which caused the file to be included. > > > "//base:base_perftests", > > > ^---------------------- > > > GN gen failed: 1 > > > > > > Original change's description: > > > > Enable extracting unwind table on official builds without channel > > > > > > > > This CL enables extraction of unwind tables for chrome when > > > > is_official_build is set to true and when android_channel is not set to > > > > a release channel. This affects build time only on official builds. > > > > Also, Set legacy heap profiler to use unwinder for profiling. > > > > > > > > TBR=dpranke@chromium.org > > > > BUG=819888 > > > > > > > > Change-Id: If9732b5ac1f9dff49c58e88e2ffb6cb387715244 > > > > Reviewed-on: https://chromium-review.googlesource.com/976944 > > > > Reviewed-by: Siddhartha S <ssid@chromium.org> > > > > Reviewed-by: agrieve <agrieve@chromium.org> > > > > Commit-Queue: Siddhartha S <ssid@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#546425} > > > > > > TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org > > > > > > Change-Id: Id033094871dfcf74248f631390f15f379d9cd3c7 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 819888 > > > Reviewed-on: https://chromium-review.googlesource.com/983893 > > > Reviewed-by: agrieve <agrieve@chromium.org> > > > Commit-Queue: agrieve <agrieve@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#546478} > > > > TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org > > > > Change-Id: I100f540c8d5bc9f59b9631ea207c7f290dc42e96 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 819888 > > Reviewed-on: https://chromium-review.googlesource.com/985112 > > Commit-Queue: Siddhartha S <ssid@chromium.org> > > Reviewed-by: Siddhartha S <ssid@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#547196} > > TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org > > Change-Id: Ifa59a5882b18c2634bcf96c2c1fc58b09d7f303f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 819888 > Reviewed-on: https://chromium-review.googlesource.com/989153 > Reviewed-by: Siddhartha S <ssid@chromium.org> > Commit-Queue: Siddhartha S <ssid@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547332} TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org,ctzsm@chromium.org Change-Id: I7750c70e52b55ccfbf1e2457a19fee4852575e59 Bug: 819888 Reviewed-on: https://chromium-review.googlesource.com/989192 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#547361}
-
Zhiling Huang authored
Bug: 803245 Change-Id: I0abe1da94bca9f38b99bf2fdaa0cd9cfa0f35783 Reviewed-on: https://chromium-review.googlesource.com/988842Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Zhiling Huang <hzl@chromium.org> Cr-Commit-Position: refs/heads/master@{#547360}
-
Malay Keshav authored
This patch implements a custom slider that provides the basic functionality of the paper-slider but provides an additional option to display a label for the current slider value. The slider has the Prefs Behavior integrated with it. This slider has a general implemention and is ready to be used in other locations as well. Functionalities implemented: - Slider works the same way as the paper-slider in terms of mouse and keyboard interactions. - Additionally The slider displays a label on mouse hover and keyboard focus. - The slider only works for discrete values or options. This patch also adds web ui tests for all the slider functionalities. A video of this slider in use can be found on the bug link below. Bug: 798906 Change-Id: Ib51ec47d0d2e8ad83ea66220ddf746fe15208d5f Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Component: Display Slider, display settings, webui tests Reverted Patch: https://chromium-review.googlesource.com/c/chromium/src/+/988092 TBR=stevenjb@chromium.org Change-Id: Ib51ec47d0d2e8ad83ea66220ddf746fe15208d5f Reviewed-on: https://chromium-review.googlesource.com/988823Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#547359}
-
Alexei Filippov authored
BUG=823874 Change-Id: Ib433aaf4bd56eef002861c0ea1a77f442283b5b6 Reviewed-on: https://chromium-review.googlesource.com/985248 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#547358}
-
Daniel Cheng authored
Change-Id: I4be44cede736df1aba6b92bf3674274a6e3ba40c Reviewed-on: https://chromium-review.googlesource.com/978467 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#547357}
-
Mike Wasserman authored
Use ChromeLauncherController's ShelfModel to get/set shelf pinning. Ash's Shell is inaccessible from Chrome in Mash. Fix unit tests to construct a ChromeLauncherController and ShelfModel. Make BrowserStatusMonitor check for a Shell to support non-Mash tests. Convert AshTestBase fixture to BrowserWithTestWindowTest; disable sync. Bug: 826415 Test: App list -> app context menu -> app info -> dialog shows [un]pin. Change-Id: Icdfdde84692184cf95dee83a71ff068cef5f98e9 Reviewed-on: https://chromium-review.googlesource.com/988825 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
-
Victor Costan authored
https://chromium.googlesource.com/external/leveldb.git/+log/41172a24016b..6fa45666703a $ git log 41172a240..6fa456667 --date=short --no-merges --format='%ad %ae %s' 2018-03-23 costan Rename CMake project / targets from Leveldb to leveldb. 2018-03-23 costan leveldb: Add more thread safety annotations. 2018-03-21 costan Take <atomic> for granted in port/atomic_pointer.h. 2018-03-21 costan leveldb: Require C++11. 2018-03-20 costan Remove build configuration for make. 2018-03-20 hyzeta Add export.h to CMakeLists.txt 2018-03-20 costan Replace SIZE_MAX with std::numeric_limits. 2018-03-16 costan Add CMake build support. 2018-03-16 costan Extend thread safety annotations. 2018-03-16 costan Fix includes in util/testharness.h. 2018-03-12 costan Remove extern from function declarations. 2018-03-12 costan Add tests for {Old}InfoLogFileName(). 2018-03-12 costan Remove unused function ExtractValueType. 2018-03-09 costan Bypass OSMemoryBarrier() warning on Mac. 2018-03-09 costan leveldb: Update Travis CI configuration for open source build. 2018-03-09 costan Expose Env::GetTempDirectory() for use in C test. 2018-03-09 costan Switch HAVE_ library detection macros to 0/1. Created with: roll-dep src/third_party/leveldatabase/src Change-Id: Ic8d8208d10ead9892c8f726b8cc4671f4b9b6389 Reviewed-on: https://chromium-review.googlesource.com/958224Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#547355}
-
Sammie Quon authored
Some artifacts show up on intel devices on the splitview indicators highlights, which are rounded_rect_views. Use addCircle and addRect as a temporary workaround. Test: manual Bug: 824564 Change-Id: Ic5bee0b6eaf412ea5fa569afefcde66843af4e4c Reviewed-on: https://chromium-review.googlesource.com/986974Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#547354}
-
Chris Harrelson authored
Bug:825742 Change-Id: I99a81da0a4275fcc6d5cb366f14706deaf3e686e Reviewed-on: https://chromium-review.googlesource.com/987111Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#547353}
-
Shubhie Panicker authored
Bug: 823482 Change-Id: I633fa3fc6be6b04cc9d58a8165fed1bc388f731b Reviewed-on: https://chromium-review.googlesource.com/981308 Commit-Queue: Shubhie Panicker <panicker@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547352}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/36a9c890b979..907239157e6a $ git log 36a9c890b..907239157 --date=short --no-merges --format='%ad %ae %s' 2018-03-28 cmtice Add new builder and builder stages for clang-tidy warnings. Created with: roll-dep src/third_party/chromite BUG=chromium:687243 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I51cccba654c5dd6ae667a49b2e6794017c5d9c24 Reviewed-on: https://chromium-review.googlesource.com/989113Reviewed-by:
-
arthursonzogni authored
Launch bug: https://crbug.com/805851 Design doc: https://goo.gl/Rrrc7n Bug: 705744 Change-Id: If959163cdafc49913edccbca980179aa5e97ef21 Reviewed-on: https://chromium-review.googlesource.com/852094Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#547350}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6ac0ae59. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14970 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources TBR=markdittmer No-Export: true Change-Id: Ia194aeadbaedae4235bc0c3d7c7168c04e3f3ede Reviewed-on: https://chromium-review.googlesource.com/988477 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#547349}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bb16e339ce72..62af4e40a8f4 $ git log bb16e339c..62af4e40a --date=short --no-merges --format='%ad %ae %s' 2018-03-30 ehmaldonado gclient setdep: Add support for more use cases 2018-03-30 amatyukhin [cipd] Do not rewrite ERRORLEVEL Created with: roll-dep src/third_party/depot_tools BUG=chromium:760633,chromium:none The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I0d76a0615d81b408fd825f0eb8f12a5fb065b09a Reviewed-on: https://chromium-review.googlesource.com/988690Reviewed-by:
-
Mike Wasserman authored
Refine existing MouseLeaveTest for more general mouse event testing. (renames, add click handlers, add basic test, cleanup helpers and html) Add a test that triggers click/double click handlers in html content. Remove IsX11SendEventTrue filtering to allow ui_controls double clicks. Originally added in https://chromiumcodereview.appspot.com/11761027 (I think to prevent reposted clicks from counting as double clicks) (crrev.com/c/980662's GetRepeatCount timestamp checks should suffice) TODO: try to enable more disabled tests, update cited bugs. Bug: 825695 Test: Automated; no double click when dismissing menus, no regressions. Change-Id: Iefcc2d313b36710a18e5c94079aa5dd75d8500bf Reviewed-on: https://chromium-review.googlesource.com/985904 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#547347}
-
