- 09 Sep, 2020 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fc89f636b89f..ca9406bac452 2020-09-09 hjd@google.com Merge "Revert "ui: Upgrade mithril 1.0.2 -> 2.0.3"" 2020-09-09 ssid@google.com Merge "Remove log that spams tests" 2020-09-09 taylori@google.com Merge "perfetto-ui: New version of marking" 2020-09-09 fmayer@google.com Merge "Heap Profiling quickstart for Windows." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1fe29b00b3fe8d5e35d90a71290a6d978301ad1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400273Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805283}
-
Jose Dapena Paz authored
GCC: make begin/end/empty methods of StringPiece constexpr to allow them to be called from base::ConsumeDurationNumber Compilation fails in GCC in base::ConsumeDurationNumber, as it is a constexpr but it calls methods begin/end/empty in StringPiece that are not constexpr. This change makes them constexpr. ../../base/time/time.cc: In function ‘constexpr base::Optional<base::{anonymous}::ParsedDecimal> base::{anonymous}::ConsumeDurationNumber(base::StringPiece&)’: ../../base/time/time.cc:67:63: error: call to non-‘constexpr’ function ‘const value_type* base::BasicStringPiece<STRING_TYPE>::begin() const [with STRING_TYPE = std::__cxx11::basic_string<char>; base::BasicStringPiece<STRING_TYPE>::const_iterator = const char*; base::BasicStringPiece<STRING_TYPE>::value_type = char]’ 67 | StringPiece::const_iterator orig_start = number_string.begin(); | ~~~~~~~~~~~~~~~~~~~^~ Bug: 819294, 1049498 Change-Id: If8813ac2651ac444cde7b874a1540c98c256c5b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394159Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#805282}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6c5e5870e09f..b820513f2f27 2020-09-09 sigurds@chromium.org Rewrite heap snapshot test as e2e test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110817 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I91dfa280b949527ad7089776b56d852990c9c6be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400880Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805281}
-
Egor Pasko authored
Not having csv imported causes the memory benchmark results to be reported as: "Error: global name 'csv' is not defined". Perhaps in the past the module was imported from some other file. Adding the necessary import will not fix the bug, rather will make us closer to see how bad the coverage-for-memory has been recently. When the bug gets fixed, it would be interesting to see whether it affected the memory usage. Bug: 1117184 Change-Id: I6ee502298e1d88aadbeb7a5866128743557cd753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401039 Commit-Queue: Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Auto-Submit: Egor Pasko <pasko@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#805280}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/12e97ed6a789..0a1061da0c7f 2020-09-09 aleksi@sapon.ca Fix CMake build with MSVC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I61ee9f75ede137365de6ca0fb02298842562ea9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400272Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805279}
-
Saurabh Nijhara authored
Most of the unit tests only require a single requirement in the policy value and the code to create such policy value is getting repeated in all tests. Now, extracting the code to create policy value into a function. Bug: 1126163 Change-Id: Ib4bd5743420c9dc962ca37216b9c2e0d9e3adb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398721Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#805278}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/fa82803f46aa..cb4733136992 2020-09-09 apodtele@gmail.com [raster] Introduce SMART macro. 2020-09-09 apodtele@gmail.com [raster] Improve tracing. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I1980f1f3040dfd36bc321187f67d84ec177cd9d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399884Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#805277}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/209d12c8b5b4..f9d5940fef55 2020-09-09 csmartdalton@google.com Use exp2 instead of ldexp/shifts in the middle out cubic shader If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: Ic99159c21a7cd57060dbef2cc42a7f03b5a08b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400266Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805276}
-
sandromaggi authored
There are some crashes from |WebController| when resetting the keyboard state through the |AutofillAgent|. These can happen if the |RenderFrameHost| is no longer valid when the final callback to clean up the state is executed. Bug: 1119918 Change-Id: I9bcd69ae125a1ab7918bc5671cb3b95c4cc82d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396121 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#805275}
-
ssid authored
Support stack unwinding for tracing sampling profiler, in arm64 builds. The builds always enable frame pointers, so stack unwinding can be done using frame pointers. Future work: Support module cache for arm 64. BUG=1110044 Change-Id: If98bcc5582edc75b61c5a385cd29535f4a6ee195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321230 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#805274}
-
Eric Lawrence authored
This policy controls the ability of cross-site images to trigger auth prompts when a page is loaded. The policy applies only to images, and applies to all HTTP authentication types (Basic/Digest/NTLM/Negotiate). This CL updates the policy caption for accuracy. Bug: 1124044 Change-Id: I6b6c06f3c73e524583262b623f0ea8ccd4ff5a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398893 Auto-Submit: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#805273}
-
Arnaud Mandy authored
use of test-only-api.js in preparation for launching official MojoJS support in WPT. This would not change the test results on Chromium waterfall (everything should continue to pass) or upstream WPT (tests currently fail because MojoJS isn't enabled). Bug: 1123989 Change-Id: Ib7fed092b37243b82fbbf38d871bb75728cb7744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395395 Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#805272}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9d7944292456..fc89f636b89f 2020-09-09 hjd@google.com Merge "ui: Upgrade mithril 1.0.2 -> 2.0.3" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I61c023fa0f9eaf9c5c702e6ffcd7740acb465f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400267Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805271}
-
Stepan Khapugin authored
This property was replaced with the UI blocker abstracted in a protocol in crrev/2288853 but it was still used in a few places, thus that CL introduced bugs, including potentially showing sign in promo when the blocking UI is shown, and switch-to-open-window button never working. Remove this property and replace it by extending UIBlocking* protocols. Bug: 1103565 Change-Id: Ib79d2968c1fe545ef5cd87cc196802ad6097345c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398684Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805270}
-
Oleg Davydov authored
When device is suspened during the session, session length limit should apply correctly. The new test simulates suspend and resume and verifies that session will be terminated at correct time. Bug: b:160454261 Change-Id: I382d5bd3c7b5a64e49783ed97eec08e19ff91810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283591Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#805269}
-
Alex Ilin authored
The histogram will be useful for the upcoming unbundled OAuth consent launch. Bug: 1109959 Change-Id: I48aef399b3970e49aee21b23dc72f8d74d8c4cc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400499 Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#805268}
-
Christian Dullweber authored
The flag is needed outside components/page_info/android. Bug: 1077766 Change-Id: Iae87a1229eec1aa0cedf8b957b1bfb940f2d941c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400519 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#805267}
-
Arthur Hemery authored
Reuses the general check for SiteInstance compatibility regarding COOP+COEP isolation. Bug: 1107814 Change-Id: I0ec25d36a650e23a103d2d509c034d240f953b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398520 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#805266}
-
Azhara Assanova authored
1. testMergeDuplicatesAndHidden: checks that hidden crashes are removed from the returning list 2. testUploadCrashLogFileWithNewCrashInfo: checks that updates the crash JSON log file with the new crash info Bug: 1059944 Test: run_webview_instrumentation_test_apk -f *WebViewCrashInfoCollectorTest* Change-Id: Id465000b2035a4efa91b59399ca961122e8fae4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379777Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Laís Minchillo <laisminchillo@chromium.org> Commit-Queue: Azhara Assanova <azharaa@google.com> Auto-Submit: Azhara Assanova <azharaa@google.com> Cr-Commit-Position: refs/heads/master@{#805265}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/5f71fdf34b76..ce08265ba5b7 2020-09-09 capn@google.com Fix register assignment for constant arrays If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I0cbebc5b1723f429b859ddf2554bcf058387b1dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400178Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805264}
-
Kent Tamura authored
It has circular dependencies with platform:platform and platform/scheduler:scheduler. They are safe because these targets are in a single library. This CL has no behavior changes. Bug: 800764 Change-Id: I613a6511d5f542b7c59004d99fa405f9c82ae226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397177Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#805263}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/41c93c550b07..7598f4b003ea 2020-09-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 4a41eb42 to e9ccdaed (365 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I49dbade945183dcdafab0144cb20b2bb39c71215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400358Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805262}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b7a88f49d2ab..6c5e5870e09f 2020-09-09 chrche@microsoft.com [Loc] Presubmit#1: Check unused resources in UIStrings 2020-09-09 tvanderlippe@chromium.org [globals] General cleanup If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1058320,chromium:941561 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I574e25120587f025b039414d186624c82eb9efee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400359Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805261}
-
Jana Grill authored
Adjust ADB sideloading notification strings based on the feedback received from the UX review. Bug: 1125611 Change-Id: I80c049f3f89cfb5ba50222799af42b813a0f6efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396216Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jana Grill <janagrill@chromium.org> Cr-Commit-Position: refs/heads/master@{#805260}
-
Kent Tamura authored
This CL updates all of circular dependencies with modules/service_worker:service_worker so that: - modules/service_worker:service_worker depends on other sub-modules - We allow circular includes from the sub-modules. It simplifies the management of |allow_circular_includes_from| significantly. Bug: 800764 Change-Id: Ie804d8ed1abebce65459e1f7408394d8783ef8fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400218Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#805259}
-
Fredrik Söderqvist authored
This removes the need of passing an out-parameter to the function. For calling code this means it's easy to separate the mutation of the object itself (the addition) from the rest of the computation. Move variable definitions around to move closer to their actual use. Bug: 1017723 Change-Id: Icca4d0cd3c0e421c8ba2c9867cdd60eabeac4c11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395716Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#805258}
-
Yuki Shiino authored
Since use_allocator="partition" means that PartitionAlloc should be used as the default allocator, select the partition alloc shim in case of use_allocator="partition". This patch doesn't take effect immediately as no bots currently specify use_allocator="partition" (PA-Everywhere is WIP). When PA-Everywhere will land, it will be enabled on all eligible platforms (Linux, Mac, Win, Android, CrOS, but not iOS), i.e. PA-Everywhere will be enabled on Linux as target and host env, Android as target env, and CrOS as target env, so there is no need to support a twisted case like PA-E on Android (target) + glibc on Linux (host). This patch simplifies and fixes the build settings. Bug: 998048 Change-Id: I7ae736e58e9b77185f7ad046f8cc5df56d9c02ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362352 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#805257}
-
dizg authored
Bug: 1115247 Change-Id: I42b0c92da476a1c7f094209de22a6756200ac924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398109Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Diana Zagidullina <dizg@google.com> Cr-Commit-Position: refs/heads/master@{#805256}
-
Nohemi Fernandez authored
Bug: 1125631 Change-Id: I643970c9131c34727d896f1fbabaa497003a37fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396299Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#805255}
-
Fredrik Söderqvist authored
No longer flaky. Tbr: schenney@chromium.org Fixed: 874567 Change-Id: I5979dd0fc541966f4ed67c359f73132ede7f46d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400458Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#805254}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fd05605bef1c..a187dd58a048 2020-09-08 stevenperron@google.com Allow SPV_KHR_8bit_storage extension. (#3780) 2020-09-08 stefanomil@google.com spirv-opt: Add function to compute nesting depth of a block (#3771) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC ianelliott@google.com,radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: ianelliott@google.com,radial-bots+chrome-roll@google.com Change-Id: I095c18f1adb30ac352ab53166f044905bff9614c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399897Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805253}
-
Trent Apted authored
These were slightly different when the duplication happened in r790679, but they appear to be identical now. Change-Id: I9e15f8c63084d2d98cf0c03695e87bc9392eb9d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397980Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#805252}
-
Kent Tamura authored
It has a circular dependency with modules/mediastream. The dependency is safe because these targets are in a single library. This CL has no behavior changes. Bug: 800764 Change-Id: I663ae35586865c65f5ced2eaac92737136684f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398445 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#805251}
-
Ye Kuang authored
Follow up of https://crrev.com/c/2400058 Bug: 894045 Change-Id: Id5837c7d742c060f1e2b7e969a7d337b193676f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400578 Auto-Submit: Ye Kuang <yekuang@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#805250}
-
Maksim Moskvitin authored
This reverts commit 73ac7d88. Reason for revert: new tests consistently crashes on Mac builders, see crbug.com/1126379. Original change's description: > Keep DevTools navigator.language in-sync with chromiums app language > > DevTools is considered part of the Chromium UI, so it should be > displayed in the same language as the Chromium UI and not the configured > accepted language (chrome://settings/languages). > > This CL moves the code where we override the DevTools renderer > preferences around so it works consistently across platforms. It also > installs an event handler in case the user changes his language settings > so `navigator.language` has consistently the same value in the > DevTools renderer. > > R=petermarshall@chromium.org > > Bug: chromium:1125490 > Change-Id: Iaac568d82357d6ae7c50d5022d687f4f1741b147 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398538 > Commit-Queue: Simon Zünd <szuend@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805219} TBR=caseq@chromium.org,petermarshall@chromium.org,szuend@chromium.org Change-Id: I5d80fbfce70fd62336b15beb0d29a7bbe09ba6fd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1125490, chromium:1126379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400280Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#805249}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b8ae7fa12aa0..209d12c8b5b4 2020-09-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e96bb06c to 02f4f19d (359 revisions) 2020-09-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 07d44b97cf65 to 41c93c550b07 (9 revisions) 2020-09-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 10121443c16d to 5f71fdf34b76 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1125354 Tbr: reed@google.com Test: Test: Test: angle_unittests.exe --gtest_filter=AtomicCounterBufferTest31.AtomicCounterBuffer* Change-Id: I4f7cab37a9580232c55473ddc8dfb94d02768e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399867Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805248}
-
arthursonzogni authored
RenderFrameHostImplBrowserTest defines: web_contents(). Tests can uses it, this is shorter and avoid doing many static_cast everywhere. This patch updates all the tests. This removes a lot of noise. This is 97 line shorter and ~50 static_cast are removed. By updating the whole file, goal is to make others start using it, instead of copy-pasting the old lines over and over. Bug: NONE Change-Id: Id06e69150ace6d9ba70983411c4830cfa4012a43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396117 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#805247}
-
Maksim Moskvitin authored
This reverts commit 7f67680c. Reason for revert: seems to cause telemetry_perf_unittests failing on Mac (crbug.com/1126367). Original change's description: > Roll Perfetto Trace Processor Mac from 6b0afc48ae3d to 9d7944292456 > > https://android.googlesource.com/platform/external/perfetto.git/+log/6b0afc48ae3d..9d7944292456 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Tbr: perfetto-bugs@google.com > Change-Id: If390c64139c1b24b220b4c0866bb26f9e6fb0db5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399439 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#805080} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com Change-Id: I6da871dd14e028bdf536ef2ae8457f31774dc3af No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400479Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#805246}
-
Joel Hockey authored
This reverts commit 3c2af663. Reason for revert: Test updated to hopefully fix flakes Original change's description: > Revert "Convert crostini and plugin VM shared paths settings lists to iron-list" > > This reverts commit 552c5361. > > Reason for revert: Breaking "browser_tests" failing on builder "linux-chromeos-rel" (specifically OSSettingsCrostiniPageTest.SubPageSharedPaths). See attached bug (https://bugs.chromium.org/p/chromium/issues/detail?id=1126295). > > Original change's description: > > Convert crostini and plugin VM shared paths settings lists to iron-list > > > > iron-list provides better focus management for tab/chromevox navigation. > > > > Bug: 1096143 > > Change-Id: Icaf2d27da606c9792a5aef9ac27226a77c63e76a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390939 > > Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> > > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > > Auto-Submit: Joel Hockey <joelhockey@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#805101} > > TBR=khorimoto@chromium.org,joelhockey@chromium.org > > Change-Id: I6ada643aa15046f223417a72518269a643221152 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1096143, 1126295 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398446 > Reviewed-by: Patti <patricialor@chromium.org> > Commit-Queue: Patti <patricialor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805194} TBR=khorimoto@chromium.org,patricialor@chromium.org,joelhockey@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1096143 Bug: 1126295 Change-Id: I6e793f762f9a3ba46d68ea095a1dde1284bebbb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398045Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#805245}
-
Ye Kuang authored
This is supposedly a transient config until CAS support. So far only the staging builders need to override this (to dev host). This CL adds the property to goma and webrtc builders. Bug: 894045, 1126307 Change-Id: I7cff2541d919fc1ad46be5dd550aad208fdb1ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400058Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ye Kuang <yekuang@google.com> Cr-Commit-Position: refs/heads/master@{#805244}
-