GitLab

BUG=122753

Review URL: https://codereview.chromium.org/11746012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175261 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168168,78283
TEST=none


Review URL: https://chromiumcodereview.appspot.com/11742028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175260 0039d316-1c4b-4281-b951-d872f2087c98

This also removes the warning shown when running Unity 2D
desktop - it's been working fine for quite a while.


BUG=168374


Review URL: https://chromiumcodereview.appspot.com/11791002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175259 0039d316-1c4b-4281-b951-d872f2087c98

Don't spam the log.

R=ccameron@chromium.org
BUG=none


Review URL: https://chromiumcodereview.appspot.com/11794004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175258 0039d316-1c4b-4281-b951-d872f2087c98

BUG=167521


Review URL: https://chromiumcodereview.appspot.com/11761022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175257 0039d316-1c4b-4281-b951-d872f2087c98

> Add "scrypt" to third_party for use in generating secure hash of user password that can later be used for off-line authentication in the case when on-line authentication is not available.
> 
> The planned use for this is profile-locking where unlocking has to be possible even when not connected to a network.
> 
> BUG=
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/11637016

TBR=bcwhite@chromium.org
Review URL: https://codereview.chromium.org/11776013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175256 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168084
TEST=none


Review URL: https://chromiumcodereview.appspot.com/11791005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175255 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100845


Review URL: https://chromiumcodereview.appspot.com/11635039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175254 0039d316-1c4b-4281-b951-d872f2087c98

No one ever subclasses FormFieldData, and it has no (other) virtual methods.


Review URL: https://chromiumcodereview.appspot.com/11737034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175253 0039d316-1c4b-4281-b951-d872f2087c98

This cleans up some longstanding TODOs that were creating when splitting
out logic into LayerTreeImpl.  It's possible that some of the helpers to
get at active tree layers (root, scrolling, etc) could be moved, but
given that scrolling only happens on the active tree (with the pending
tree being updated with the result), these accessors could arguably stay
permanently.

This also moves background color / has transparent background to the tree
itself, so that these changes will synchronize with any content on that
tree.  Things like viewport, device scale, and debug state are considered
host-specific and take effect immediately.

R=nduca@chromium.org
BUG=155209


Review URL: https://chromiumcodereview.appspot.com/11704003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175252 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/11788006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175251 0039d316-1c4b-4281-b951-d872f2087c98

--wallet-service-url now specifies a prefix rather than a full path to autocheckout.
The default value is https://wallet.google.com/online/v2/ and the rest of each Wallet
URL will be appended to construct a working URL.
Also changed function prototypes to use the namespace in a more common way.
(namespace wallet {... vs wallet::)

BUG=168278


Review URL: https://chromiumcodereview.appspot.com/11791003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175250 0039d316-1c4b-4281-b951-d872f2087c98

Also changed self-destruct to launch setup.exe using ShellExecute instead of base::LaunchProcess to allow us to specify SEE_MASK_FLAG_LOG_USAGE to flip to the desktop as documented in "DevelopinganewexperienceDesktopBrowser". This only seems to work when ShellExecute is called from an immersive process and thus setup.exe must be launched with this flag (if it's not and setup later tries to ShellExecute the system-level Chrome with that flag, the desktop flip doesn't occur...).

Also fixed InstallUtil::GetSentinelFilePath() which used to get DIR_EXE from the PathService to determine whether it was a user-level install and if so return DIR_EXE as the sentinel file path; this was wrong when called from setup.exe as DIR_EXE is not Application\ in that case, it's Application\<version>\Installer...! Thankfully this method was not used to set the sentinel (so that we don't have to keep checking for sentinel files in the wrong places); we could up until this CL however get constant false negatives when looking for sentinels with this method.

This CL depends on https://codereview.chromium.org/11636031/.

BUG=165048
TEST=Self-destruct with/without First Run having occured (prior to the system-level install) for the user-level Chrome; the self-destruct should occur and launch System-level Chrome with/without the First Run flow (i.e. with First Run only if the self-destructing Chrome itself hadn't undergone First Run already).
On Win8, the above scenarios should work whether the user-level Chrome prefers Metro or not (if it does prefer Metro the immersive launch should flip back to the desktop for the self-destruct -- the self-destruct message dialog is still suppressed in that case however).

Review URL: https://chromiumcodereview.appspot.com/11685006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175249 0039d316-1c4b-4281-b951-d872f2087c98

Directory.

Delete journals keeps deleted metas until the persistence of the deletes in
native model is confirmed. When an entry is deleted in sync model, a copy is 
added to delete journals in memory and saved in database later. Next time when
the client restarts, if some native data doesn't match with sync data but
matches with a delete journal, it's safe to assume that it's because native
delete was not persisted and the native data should be deleted. This helps
prevent back-from-dead problem due to native model and sync model get
out-of-sync.

BUG=121928

Review URL: https://chromiumcodereview.appspot.com/11441026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175248 0039d316-1c4b-4281-b951-d872f2087c98

Main review by mukai, miket for OWNERS review of
ui/notifications/notification_types.{h,cc} changes.

TBR=derat@chromium.org for OWNERS review of balloon_view_ash.cc changes.
BUG=164292

Review URL: https://chromiumcodereview.appspot.com/11639041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175247 0039d316-1c4b-4281-b951-d872f2087c98

Rename AppNotifyChannelUIImpl::InfoBar to AppNotifyChannelUIInfoBarDelegate for consistency with other infobars, and because the style guide pushes people away from member classes when not necessary.

BUG=none
TEST=none
Review URL: https://codereview.chromium.org/11740034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175246 0039d316-1c4b-4281-b951-d872f2087c98

TaskManager option only if the TaskManager option was added to the menu in the first place.

This causes a DCHECK for consecutive separators to fire on Chrome Windows 8 metro which does not have the
TaskManager option in the menu.

BUG=none
Review URL: https://codereview.chromium.org/11788007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175245 0039d316-1c4b-4281-b951-d872f2087c98

Speculative revert 175230. I suspect that dependency on propsys.dll makes chrome.dll unloadable on XP SP3 breaking NACL and chrome frame tests.

> [Fixit-Dec-2012] Also add dual_mode to Start Menu shortcuts in MigrateChromiumShortcuts.
> 
> Restructured this code quite a bit to use the new shortcut magic.
> 
> Added tests which turned out to expose edge cases that I think weren't covered by the previous implementation (i.e. would potentially update shortcuts when unecessary -- flashing the desktop in the process -- or not do it when necessary).
> 
> BUG=142980
> TEST=Pin Desktop shortcut to Start Screen or pin chrome.exe directly to the start screen via context menu.
> Notice that there are now multiple shortcuts of Chrome (non-tiled; 1 for each "Pin to Start" action; upon launching Chrome those should all be merged down to one Chrome tile shortcut (not on the file system, but visually on the Start Screen itself).
> Note: if you do try this; there is an intentional 15s delay before the migration kicks in to avoid delaying Chrome startup; so be patient, it will work ;)!
> 
> Review URL: https://chromiumcodereview.appspot.com/11712003

TBR=gab@chromium.org
Review URL: https://codereview.chromium.org/11777006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175244 0039d316-1c4b-4281-b951-d872f2087c98

The message is deleted on the following line. (And GetReplyDeserializer() does
nothing other than release and return a scoped_ptr member. And yes, Messages
have virtual destructors.)


Review URL: https://chromiumcodereview.appspot.com/11720005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175243 0039d316-1c4b-4281-b951-d872f2087c98

Don't access owner() in the constructor; eventually doing this won't work, because InfoBarDelegates won't be owned at creation.  (It's fine right now, but this is more efficient anyway, since the caller already has a Browser*.)

BUG=none
TEST=none
Review URL: https://codereview.chromium.org/11740035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175242 0039d316-1c4b-4281-b951-d872f2087c98

Rename HungPluginTabHelper::InfoBarDelegate to HungPluginInfoBarDelegate for consistency with other infobars, and because the style guide pushes people away from member classes when not necessary.

BUG=none
TEST=none
Review URL: https://codereview.chromium.org/11748027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175241 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168210
TEST=Before any client connects, "xdpyinfo -display :20|grep -A1 dimensions" shows ~96dpi.
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11782006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175240 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11696010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175239 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none


Review URL: https://chromiumcodereview.appspot.com/11748024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175238 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None


Review URL: https://chromiumcodereview.appspot.com/11778004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175237 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20ASAN%20Builder&number=15352

> Add trace event Pepper API
> 
> This facilitates adding trace data to chrome://tracing from plugins.
> 
> - broke out trace_event.h into trace_event.h/trace_event_internal.h
>   for easier transplanting to plugin code by eliminating dependence on base/.
> - inlined trace_event.cc methods (4 total) so the trace_event_internal
>   implementation is contained in headers.
> - added new PPB_TraceEvent_Dev interface (implemented entirely on the plugin side)
> 
> BUG=none
> TEST=base unittests, manual for plugin testing
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/11464005

TBR=elijahtaylor@chromium.org
Review URL: https://codereview.chromium.org/11782008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175236 0039d316-1c4b-4281-b951-d872f2087c98

glXGetSyncValuesOML gives us a count of the number of refreshes that have occurred (media stream counter). We can use this and the time between successive UST counters to measure the period of the screen refresh.

BUG=none
TEST=by hand on stumpy and alex using xrandr to force different refresh rates


Review URL: https://chromiumcodereview.appspot.com/11752002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175234 0039d316-1c4b-4281-b951-d872f2087c98

This facilitates adding trace data to chrome://tracing from plugins.

- broke out trace_event.h into trace_event.h/trace_event_internal.h
  for easier transplanting to plugin code by eliminating dependence on base/.
- inlined trace_event.cc methods (4 total) so the trace_event_internal
  implementation is contained in headers.
- added new PPB_TraceEvent_Dev interface (implemented entirely on the plugin side)

BUG=none
TEST=base unittests, manual for plugin testing


Review URL: https://chromiumcodereview.appspot.com/11464005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175233 0039d316-1c4b-4281-b951-d872f2087c98

BUG=162829
R=dhollowa@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11779004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175231 0039d316-1c4b-4281-b951-d872f2087c98

Restructured this code quite a bit to use the new shortcut magic.

Added tests which turned out to expose edge cases that I think weren't covered by the previous implementation (i.e. would potentially update shortcuts when unecessary -- flashing the desktop in the process -- or not do it when necessary).

BUG=142980
TEST=Pin Desktop shortcut to Start Screen or pin chrome.exe directly to the start screen via context menu.
Notice that there are now multiple shortcuts of Chrome (non-tiled; 1 for each "Pin to Start" action; upon launching Chrome those should all be merged down to one Chrome tile shortcut (not on the file system, but visually on the Start Screen itself).
Note: if you do try this; there is an intentional 15s delay before the migration kicks in to avoid delaying Chrome startup; so be patient, it will work ;)!

Review URL: https://chromiumcodereview.appspot.com/11712003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175230 0039d316-1c4b-4281-b951-d872f2087c98

BUG=167811

Review URL: https://codereview.chromium.org/11787009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175229 0039d316-1c4b-4281-b951-d872f2087c98

Note that Google Chrome will continue to use bundled re2.
The option is off by default, and is intended for Linux distros.

BUG=165264
TEST=none

Review URL: https://codereview.chromium.org/11366051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175227 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175225 0039d316-1c4b-4281-b951-d872f2087c98

TBR=cmp

BUG=136110

Review URL: https://codereview.chromium.org/11783004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175224 0039d316-1c4b-4281-b951-d872f2087c98

This undoes the change r139605.

The only reported failure of this test on Windows was the exit status
0xc000008f problem, which was a problem with all NaCl tests on 32-bit
Windows (not just this test) and has since been fixed.

BUG=130349
BUG=https://code.google.com/p/nativeclient/issues/detail?id=3227
TEST=browser_tests

Review URL: https://codereview.chromium.org/11778002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175223 0039d316-1c4b-4281-b951-d872f2087c98

Also remove an excess empty line.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/11669021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175222 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11745025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175221 0039d316-1c4b-4281-b951-d872f2087c98

Currently when the avatar button is clicked a second time the avatar bubble closes then immediately opens again.

The problem is that the same mouse event that closes the bubble also causes to open again.

To fix this I've changed AvatarMenuBubbleView to track it's current instance. If a caller tries to show the bubble while an instance is already being shown then the show request is ignored.

BUG=107876
TEST=Clicked on the avatar button a second time and verified that the avatar bubble stayed closed.

Review URL: https://chromiumcodereview.appspot.com/11646008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175220 0039d316-1c4b-4281-b951-d872f2087c98

> Separate apk_info and jar_info and move to utils dir.
> 
> This is in preparation for adding uiautomator test runner
> which runs tests without an apk.
> 
> BUG=167331
> 
> Review URL: https://codereview.chromium.org/11741025

TBR=craigdh@chromium.org

These will be replaced with concept of test packages.
Review URL: https://codereview.chromium.org/11780003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175218 0039d316-1c4b-4281-b951-d872f2087c98

There are memory leaks in this patch in RebuildTableFromDelegate

BUG=
TBR=brettw@chromium.org,joi@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11784006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175217 0039d316-1c4b-4281-b951-d872f2087c98