- 20 Mar, 2018 40 commits
-
-
Alexander Timokhin authored
Some Autofill-related code can hold persistent reference to last changed or focused <input> element that cause leak of whole Documents containing such element after navigation to other page. Some leaks fixed in https://chromium-review.googlesource.com/939224 This CL fixes other related leaks. Bug: 734427 Change-Id: Ic084d0670cccb9d11595d0bde8cf0d605bfa8911 Reviewed-on: https://chromium-review.googlesource.com/970582Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#544404}
-
Peter Kasting authored
This ensures the background images drawn by Tab will not be transparent even if they are transparent in the original theme. Tab assumes its background is fully opaque, so that subpixel AA is guaranteed to work. BUG=819865 TEST=Install theme in bug comment 25, verify background tab text is readable Change-Id: If75228398b9ae05b275e530c3900b087a5f94139 Reviewed-on: https://chromium-review.googlesource.com/969835Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#544403}
-
Matt Menke authored
In particular, replace about:net-internals with chrome://net-export, add link to end-user instructions to chrome://net-export itself, add a link to internal chrome network crash page, and slightly update instructions. Bug: None Change-Id: I8ce872f1874ca632c7a1417fb9727fe4e4131778 Reviewed-on: https://chromium-review.googlesource.com/964943 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#544402}
-
Justin Cohen authored
Previous CL (https://chromium-review.googlesource.com/c/chromium/src/+/964993) missed the last commit before sending to CQ. Added: Remove articlesListNeedsReload and re-set self.sectionInformationByCategory Bug: 805638 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If8327c26bab76219be336d667230cb31d67fd84e Reviewed-on: https://chromium-review.googlesource.com/971001Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#544401}
-
Leonard Grey authored
NSMenus on Mac block in a nested run-loop, so any tests that open a menu and try to do things to it or sense things on it either: - Succeed by accident because of a race condition with app activations - Block until the menu or another window is interacted with Disabling these until we've either been able to make NSMenus asynchronous to match views expectations, or found a way to test this functionality a different way. |AlwaysTranslateLanguageMenuItem| has an additional problem: pressing a button halfway through closes the bubble, but on non-Mac platforms, the test can continue due to asynchronous window closing. On Mac, the window's content view is removed as soon as closing begins. We'll probably need to address this by breaking it up into multiple tests and creating a way to sense the state without relying on an object owned by the closing bubble. Bug: 810479,823735 Change-Id: I9d9d9ca49a3436b91d3cc99fb43ecef13d2e77c0 Reviewed-on: https://chromium-review.googlesource.com/969653Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#544400}
-
Raphael Kubo da Costa authored
TBR=thomasanderson@chromium.org Change-Id: Idbc1734f5b3d0c74b4367f6aa71ced7cbe1415c4 Reviewed-on: https://chromium-review.googlesource.com/970587Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#544399}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e57b381c..610f27b9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I741b7f082eca142ff3294575f44d2bf7e76e6d13 Reviewed-on: https://chromium-review.googlesource.com/970849Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#544398}
-
chaopeng authored
Bug: 779372 Change-Id: Ibee8c53d6a7f5eb08669620f5fe26403fa4ba2b0 Reviewed-on: https://chromium-review.googlesource.com/963013Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#544397}
-
spqchan authored
Bug: 792276 Change-Id: I406f6ccee9df505b2ba7bf6c7585160a6b56173a Reviewed-on: https://chromium-review.googlesource.com/969943Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#544396}
-
Evan Stade authored
They're already on by default for Mash. This makes Chrome use the mojo ("native") interface for notifications even in non-Mash. Bug: 578868 Change-Id: If1ee85e2136dc0480ccee9a57835b0ffb9b47b8b Reviewed-on: https://chromium-review.googlesource.com/963518 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#544395}
-
CrystalFaith authored
Replacement/update for the get starter tutorial. Tutorial walks developers through extension creation and includes an options page. Some links in tutorial depend on new user interface article. Will not be able to go live without those updates, or will need some adjustment. Bug: none Change-Id: Ib7dbe75bf6e6471d7c81565d805fc6a8d487e0a3 Reviewed-on: https://chromium-review.googlesource.com/795057 Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544394}
-
Raphael Kubo da Costa authored
TBR=thomasanderson@chromium.org Change-Id: I6c30fe8fcf3fdcdcae7f4910e78d755168831200 Reviewed-on: https://chromium-review.googlesource.com/970585Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#544393}
-
Mark Cogan authored
This CL has the slider on the tab grid page control move as the tab grid scroll view decelerates after a drag, as well as while dragging. Bug: 804500 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic3d35b1abd4e588f212b59ebf72027fe4ce040ff Reviewed-on: https://chromium-review.googlesource.com/970480Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#544392}
-
Matt Menke authored
It was making enough connections to exceed the total socket pool limit, which is currently 256, and apparently large enough to cause timeouts on some bots. Switch to using the per-group limit instead - socket pool tests themselves should make sure that ignore_limits ignores the global pool limits as well, as there's no other way to exceed the per-group limit, so just checking the per-group limit should be sufficient. Bug: 820845 Change-Id: I2a661b535492c5bbca4e90710bd2d91e6115edfe Reviewed-on: https://chromium-review.googlesource.com/964542 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#544391}
-
Yuqian Li authored
Change-Id: I3b63a8689254137773bf18ff1b930e5eee508709 Bug: skia:7731 Reviewed-on: https://chromium-review.googlesource.com/969114Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Yuqian Li <liyuqian@chromium.org> Cr-Commit-Position: refs/heads/master@{#544390}
-
https://webrtc.googlesource.com/src.git/+log/9047dac7576d..2e0da5aa389f $ git log 9047dac75..2e0da5aa3 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0f099fa9053a36e98bcdd8f12b94d39010751ac1 Reviewed-on: https://chromium-review.googlesource.com/970862 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544389}
-
kylechar authored
Bug: none Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I2d750279c9811ba931fd07630bdc401e6a98ee5c Reviewed-on: https://chromium-review.googlesource.com/969070Reviewed-by:
Ria Jiang <riajiang@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#544388}
-
Fergal Daly authored
part= attribute. R=hayato@chromium.org Bug: 805271 Change-Id: Ie3ebecb3848b21d93189c6044d2c410490bb4ded Reviewed-on: https://chromium-review.googlesource.com/958311 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#544387}
-
Mike Wasserman authored
The Window Service operates in pixels. Any translations in the transform need to be scaled by the dsf. Based on sky@'s CL: http://crrev.com/c/966498 (copied in patch set 1) This CL keeps existing scaling, etc. (SetTranslate first clears to identity). (the original CL doesn't fix clicks on the overview window previews) BUG=822917 TEST=chrome --enable-features=Mus --force-device-scale-factor=2 overview (F5) mouse hover/click works well Change-Id: I1031d0a66dd5b014656ef974d382293e0da52906 Reviewed-on: https://chromium-review.googlesource.com/969072 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#544386}
-
Tomas Popela authored
Change-Id: I93102ac63ae73770f0012a6a0b2c92030ad8b83e Reviewed-on: https://chromium-review.googlesource.com/970244Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#544385}
-
Boris Sazonov authored
This CL adds account picker to the streamlined sign-in screen. It will be wired up by subsequent CLs. RelativeLayout is used to avoid using nested LinearLayouts and minimize the depth of the layout. Strings in grd file are currently marked as not translateable as they haven't been confirmed by the UI team yet. This CL also adds initialization for ConsentTextTracker in SigninFragmentBase. Bug: 814728 Change-Id: I60ae3841998d5dd9c13d35583915e7fe443d3b31 Reviewed-on: https://chromium-review.googlesource.com/966902 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#544384}
-
Gauthier Ambard authored
This CL changes the frame for the bounds, as a follow up for the creation CL. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic1cea75158aac141c11807d82a2c910dbf792cea Reviewed-on: https://chromium-review.googlesource.com/970476Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#544383}
-
Filip Gorski authored
Bug: 820361 Change-Id: I1996da98a7b1d750f33f702a8251b46e566f900d Reviewed-on: https://chromium-review.googlesource.com/969097 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#544382}
-
Alexander Potapenko authored
BUG=794920 TBR=rsesek@chromium.org Change-Id: I3ea15492e4f08a0879fdd0c5476a09bcf5db6836 Reviewed-on: https://chromium-review.googlesource.com/970477Reviewed-by:
Alexander Potapenko <glider@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Alexander Potapenko <glider@chromium.org> Cr-Commit-Position: refs/heads/master@{#544381}
-
gogerald authored
Bug: 782270 Change-Id: Idbc5696044aec4da0efed8c6f30f867e1b335fb9 Reviewed-on: https://chromium-review.googlesource.com/969605 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#544380}
-
Balazs Engedy authored
No production code is calling U2fDiscovery::Stop, and all observer method implementations are no-ops. Similarly, no U2fDiscovery has more than a single observer added, and the only time that observer is removed is when both the discovery and that observer (the owner) dies. It sounds like we are not going to make use of this functionality in the near future, so this CL removes: -- the ability to Stop() U2fDiscoveries, and -- the ability to have more than a single Observer per U2fDiscovery. The CL also moves slightly more functionality into the U2fDiscovery base class from derived classes, most importantly with the goal of making sure the fake and production implementations function consistently in the following areas: -- U2fDiscovery now keeps track of whether Start NotifyDiscoveryStarted have been called, and exposes corresponding getters. -- It is now enforced that Start() and NotifyDiscoveryStarted() can be called once each, and in this order, as well as that NotifyDeviceAdded cannot be called before Start() is called. -- It is now enforced that Observer::DiscoveryStarted is never invoked synchronously while Start() is still on the call stack. Bug: 822244, 823686 Change-Id: Ia029646d43481a1a2ca58452577727f96d6aade1 Reviewed-on: https://chromium-review.googlesource.com/964301 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#544379}
-
Justin Cohen authored
Adds new articles header view with a toggle button and update logic to honor prefs::kArticlesListVisible. Bug: 805638 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I882cb19c9dd1bf6c1c6d232dab0413e01835a402 Reviewed-on: https://chromium-review.googlesource.com/964993Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#544378}
-
Fredrik Söderquist authored
Also eliminate a few copies in TranslateTransformOperation::Blend. Change-Id: Icb390e3da70e2c3b651c34758f8e0fefa7bb4484 Reviewed-on: https://chromium-review.googlesource.com/970821Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#544377}
-
David Tseng authored
Bug: 819848 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If57780e21ca7a865bb6d0318d3809db916c7db28 Reviewed-on: https://chromium-review.googlesource.com/969705Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#544376}
-
Charles Harrison authored
A followup will hook this pref with a new enterprise policy to turn the feature off. Bug: 823700 Change-Id: I06096460a372941ba06f3bf3e9cc63b9084f82cd Reviewed-on: https://chromium-review.googlesource.com/970729Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#544375}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 86ab60eb. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14253 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=kereliuk No-Export: true Change-Id: I5689b096bd9391d91b2e7dafbdf75f3c95734989 Reviewed-on: https://chromium-review.googlesource.com/970842 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#544374}
-
https://skia.googlesource.com/skia.git/+log/ec77963bf32e..0060c3394c6b $ git log ec77963bf..0060c3394 --date=short --no-merges --format='%ad %ae %s' 2018-03-19 joe [lottiecap] Moved over from buildbot repo. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: Iece4b08b33d9a51ac98192a9d01b1c6d2e7f7c9a Reviewed-on: https://chromium-review.googlesource.com/970727 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544373}
-
https://chromium.googlesource.com/angle/angle.git/+log/aa5d883e0215..b391ec40837c $ git log aa5d883e0..b391ec408 --date=short --no-merges --format='%ad %ae %s' 2018-03-12 oetuaho Generate code for looking up built-ins Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ie1b40e2112a9b13f9fbaa4285c0be51819fbee03 Reviewed-on: https://chromium-review.googlesource.com/970481Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544372}
-
Michael Lippautz authored
Construction order is always base before derived, so having a default implementation allows us to get around trying to call a pure virtual method before it is set up. This is orthogonal to the problem of whether the object is fully initialized which will be added later to the loop that drains the marking stack. The current implementation handles - Draining at the event loop (which is a safepoint). - Conservative GCs which are free to ignore the object if it is still under construction. Bug: chromium:757440 Change-Id: Ib1f16fa80f99ac53b369bc184d42f947e58d2723 Reviewed-on: https://chromium-review.googlesource.com/949464 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#544371}
-
tzik authored
This CL changes the ownership of base::Clock and base::TickClock from injectee-owned to injecter-owned. Before this CL, these instances are owned by the owner of the injectee or one of the injectees themselves. That makes the ownership handling complex. After this CL, the injectee of clocks never own the clock. Instead, injecters owns a clock for testing, and a shared clock is used on the production code. Bug: 789079 Change-Id: I98eabd76f378c15bccf637c3d6748c2a2aba417e Reviewed-on: https://chromium-review.googlesource.com/956167 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#544370}
-
Alexander Timin authored
Make RendererScheduler aware of tasks which are run after frame has been detached. As there is no TaskQueue reference at this point (only TaskQueueImpl), nullptr is passed to MetricsHelper. This patch ensures that MetricsHelper supports that. R=alexclarke@chromium.org,farahcharab@chromium.org Change-Id: Id9b7f0efe6f384bf57b56420ff63382729e191a2 Reviewed-on: https://chromium-review.googlesource.com/970802 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#544369}
-
Friedrich Horschig authored
In order to proceed the rollout for the password search feature in http://cl/189730122, add the test group to the field trial config. Change-Id: I281c4908826fee3247a66a29f94699044c9ec03e Reviewed-on: https://chromium-review.googlesource.com/970344Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#544368}
-
Gauthier Ambard authored
This CL adds a gesture recognizer delegate for the popup menu. It allows the gesture to be sent to other gesture recognizers when the tap occurs inside the container. In particular, it will allow the content of the menu to receive the gesture. Bug: 822703 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4773824e7b7c4b5d1ea0713df34e87a10a9a40ee Reviewed-on: https://chromium-review.googlesource.com/965068 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544367}
-
Alexander Potapenko authored
These tests are causing data races due to incorrect use of base::FeatureList. BUG=823713 TBR=nasko@chromium.org Change-Id: Ia15c5fa8e067af17dfbe2e2de9f6489688f188ce Reviewed-on: https://chromium-review.googlesource.com/970654Reviewed-by:
Alexander Potapenko <glider@chromium.org> Commit-Queue: Alexander Potapenko <glider@chromium.org> Cr-Commit-Position: refs/heads/master@{#544366}
-
Gauthier Ambard authored
This CL creates a table view used to display the elements of the popup menus and the items to be presented by this table view. It also creates the mediator used to create and manage the items. Bug: 804770 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icc861cc1d8d2c37bdc3d5dc70f2b072d657dd721 Reviewed-on: https://chromium-review.googlesource.com/966201 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#544365}
-