- 11 Jun, 2020 40 commits
-
-
Rachel Wong authored
This CL adds the Mojo broker interface and associated structs for Local Search Service. The next CL will add StructTraits to allow for easy conversion between the Mojo structs and their C++ counterparts. Bug: 1092767 Change-Id: Ib4ca2dd1a61ccc775a36d4f99776bcdc62256b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235575Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#777285}
-
Bao-Duy Tran authored
Things were moved approx 8 years ago: https://crrev.com/10735074. Change-Id: I14829a47fb7221310fb54f24e1dec96b9a1118dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230435Reviewed-by:
Darren Shen <shend@chromium.org> Auto-Submit: Bao-Duy Tran <tranbaoduy@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/master@{#777284}
-
Kunihiko Sakamoto authored
external/wpt/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.resize.html is failing after http://crrev.com/777259. TBR=aaronhk@chromium.org No-Try: true Bug: 1093709,1091267 Change-Id: Ifc285409dd7c1f014d0c8450ace0ccfb538ba3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241052Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#777283}
-
Ramin Halavati authored
This reverts commit 8149e2bd. Reason for revert: Removed metrics are needed for other studies. Original change's description: > Remove four Bookmark metrics. > > The following metrics were used to measure Incognito mode usage and are > expired: > - Bookmarks.BookmarkAllTabsWithTabsCount.Incognito > - Bookmarks.BookmarkAllTabsWithTabsCount.Regular > - Bookmarks.AddedPerProfileType > - Bookmarks.UsageCountPerProfileType > > Added code to support these metrics is also cleaned up. > > Bug: 1088669 > Change-Id: I22fd2ac7392be179c275afa079bfd961672fc95f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228550 > Commit-Queue: Ramin Halavati <rhalavati@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775949} TBR=sky@chromium.org,holte@chromium.org,rhalavati@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1088669 Change-Id: I4a2c4287795db4ec57112e0c5fc6589ea47ea99b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235824Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#777282}
-
Kunihiko Sakamoto authored
TBR=khushalsagar@chromium.org Bug: 1067662 Change-Id: I6a9c6de903d7b4b3f6dd5caa118f9f1af9fb8634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239144Reviewed-by:
-
Kent Tamura authored
Bug: 1069817 Change-Id: I9d4966bcffeeffae8d457e01d070fc5c276259bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239779 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#777280}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1591732735-0015e64d5031c088448e4bf6bbe4dc15e4f90ad0.profdata to chrome-win32-master-1591847470-22394db4eae687d46ca49599d3bc16bb448d2db1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Id0e9226097aeca175d56e69bae86032b249a4adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240751Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#777279}
-
Harald Alvestrand authored
Test is flaky. Bug: 1093198 Change-Id: Ia2310631c6ce3aa1f4dcb65890996c72ee7b36ee No-try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241112Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Auto-Submit: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#777278}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e3eb327e8c3c..45510ad8a778 2020-06-11 capn@google.com Validate the SPIR-V code in debug builds 2020-06-11 capn@google.com Add a triangle rendering benchmark 2020-06-11 capn@google.com Add glslang dependency to VulkanBenchmarks 2020-06-11 capn@google.com Add glslang as a submodule 2020-06-11 capn@google.com Move CMake build targets for PowerVR samples before unit tests 2020-06-11 capn@google.com Add microbenchmarks for vkCmdClear*Image 2020-06-11 capn@google.com Add back vulkan.hpp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I1ce9f46277fe163a8e2922649ad945d1f8947d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239661Reviewed-by:
-
Bartek Nowierski authored
Bug: 1086388 Change-Id: Ib506d39f21dcfabab4e207ee72cd57da23435799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239734 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#777276}
-
chrome://media-appZain Afzal authored
Currently the host frame is focused, which means keyboard shortcuts installed on 'window' in the sandboxed iframe will not see events until the iframe is clicked on or otherwise interacted with. Bug: b/158707819 Change-Id: I866776c41b90faaa2e2cb7814fc3f714c4e81725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239140 Commit-Queue: Zain Afzal <zafzal@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#777275}
-
My Nguyen authored
First cut based on spec at http://go/e14s-emoji-addition-mock Bug: 1093178 Change-Id: I274d95df44ccc04d03fddec60b90b6a679ee3000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239908Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 85-4147.10-1591010642-benchmark-85.0.4163.0-r1 to 85-4147.33-1591609027-benchmark-85.0.4163.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If1506db22d6bb95001fab1cb3a39d50b0893ae4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240760Reviewed-by:
-
David Benjamin authored
This has successfully shipped in M81, so enable it in SSLContextConfig by default. (Admin policy and the base::Feature still controls the setting for SSLConfigServiceManagerPref.) See discussion in https://chromium-review.googlesource.com/c/chromium/src/+/1965952/1/net/ssl/ssl_config_service.h#44 Bug: 1033598 Change-Id: I2e3a25f34d1b7efdc849bac2a00e56fcabbae47f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238502Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#777272}
-
Alan Cutter authored
This is a reland of 61579f7a The original CL was optimisic that all linux bots used the same system theme colors. This is not the case for Linux MSan Tests: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8877850460224985872/+/steps/browser_tests/0/logs/Deterministic_failure:_WebAppOpaqueBrowserFrameViewTest.SystemThemeColor__status_FAILURE_/0 This revised CL loosens the expectations to allow for any light title bar color. Original change's description: > Fix GTK+ themed web app windows using incorrect window title color > > This CL fixes a bug where web app windows on Linux with GTK+ themes set > would use system colors for the title bar but web app colors for the text. > This sometimes resulted in unreadable contrast levels. > > Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=450694&signed_aid=ojOLuOeFlvGsonFz7D8lkA==&inline=1 > After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=450693&signed_aid=CN1FqbV6S5JWEJfOW5L4oQ==&inline=1 > > Bug: 1087693 > Change-Id: Ifc408c4c1fb1c6cae4014f806248a05f5e2f617f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239769 > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776994} Bug: 1087693 Change-Id: I3f924f2976114f8bfe58e8a230a036eed9b0df0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239912Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#777271}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 85-4147.21-1591007597-benchmark-85.0.4163.0-r1 to 85-4161.0-1591613309-benchmark-85.0.4163.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Iaeb403b809fba50b7fb88afe20a34ff1f69a032c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240759Reviewed-by:
-
Leo Lai authored
Bug: None Change-Id: Ibf775d40a0445a33deaa8fbc7e664b4bdd65b7dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239913 Auto-Submit: Leo Lai <cylai@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#777269}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 85-4147.21-1591004251-benchmark-85.0.4163.0-r1 to 85-4147.33-1591609549-benchmark-85.0.4163.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ib4b7e19040faee6c5aa9d2387526fce1b78bb073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240754Reviewed-by:
-
Jing Wang authored
Bug: 1042084 Test: tested with emulator and DUT Change-Id: I78ef83ad4db887285ee01b7d350f2124f7cfdeb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237562 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
-
Naoki Fukino authored
This CL adds a "File location" item to the quick view metadata box if the selected entry is a file (not a directory). The file's location should be same as the breadcrumbs path, but each component is concatenated by '/'. Bug: 1092950 Test: Run browser_tests Change-Id: I68333c36c1a77665f28b0f6fa3379978ce7bd9ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237445 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#777266}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1591286362-102873a0b212b7d3d19b6bf651c7d4720fb0d502.profdata to chrome-mac-master-1591847470-e9a3ba2de654706356c199369cb3647da2838543.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ife2c0780e0cabfcfed206e62c45611a141106d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239662Reviewed-by:
-
edchin authored
This CL fixes the NTP coordinator so that the delegate gets updated properly, and is removed when detached. Bug: 1087844 Change-Id: I2c58645997a86a88704ec2895d5f4e3b7502c0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236226 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#777264}
-
Joey Arhar authored
This patch makes it so we only sanitize the text in input elements when the value attribute (defaultValue) when the default value is actually being used. Before this patch, the visible text entered by the user is sanitized in-place every time the value attribute (for the default value) is modified, even though we aren't using the default value anymore. This patch will check the dirty flag, which signals if we are using the default value attribute or not, before sanitizing the visible value. This way we will still apply sanitization to default values provided programmatically when they are actually used, but won't change text a user entered. Bug: 1067117 Change-Id: Ic185d6d173d40c1b0726c0c3fb67a6937fc8534f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133229 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#777263}
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile and HasOffTheRecordProfile without argument is getting deprecated. Use cases of this call that ONLY refer to incognito or guest mode can use [Get/Has]PrimaryOTRProfile() instead. Use cases of these functions in AccessibilityManager are updated to use the new APIs. This CL does not change any behavior. Bug: 1060940 Change-Id: I51877f1b5d4e8d520b640ef91134a3291dc59bb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239845 Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#777262}
-
Gang Wu authored
Make two field trial name match about_flags.cc to avoid crash when start Change-Id: I3ca9f0bef88b0b4ff4d6744c0fb4b9166b5ca2c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240451Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#777261}
-
Gang Wu authored
Update the owner for the following metrics. Since Android still rolling out clipboard image suggestions, change milestone to M93. Omnibox.ClipboardSuggestionShownNumTimes.URL Omnibox.ClipboardSuggestionShownWithCurrentURL.IMAGE Omnibox.ClipboardSuggestionShownAge Omnibox.ClipboardSuggestionShownWithCurrentURL.TEXT Omnibox.ClipboardSuggestionShownNumTimes.IMAGE Omnibox.ClipboardSuggestionShownAge.IMAGE Omnibox.ClipboardSuggestionShownWithCurrentURL.URL Omnibox.ClipboardSuggestionShownAge.TEXT Omnibox.ClipboardSuggestionShownWithCurrentURL Omnibox.ClipboardSuggestionShownNumTimes.TEXT Omnibox.ClipboardSuggestionShownAge.URL Omnibox.ClipboardSuggestionShownNumTimes Bug: 1089168 Change-Id: I17a759a8d19647dffbfae4552cc31dee8d0d0c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239372Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2cb52356. With Chromium commits locally applied on WPT: 9c24e63c "Check for first frame in CreateImageBitmap" a8a28083 "[Security][Coop] Browsing context switch reporting WPT" b2436c3b "Ensure cloning a template element into an inactive document does not crash." 027aefc6 "OPTION element: Update OPTION label even if it has invalid markup" 0776aa6d "Mark pointerevent_pointermove_in_pointerlock test non flaky" d2ee98f4 "Move manual offscreen wpt tests to own folder" 458dc853 "WPT: Migrate content-visibility tests to wpt." 84f61c81 "Exclude non relevants reports from the COOP-opener-breakage tests." e106756f "[COOP] Access reporting. Update the test." b447a3ac "De-flake cross-domain-iframe.sub.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: Ia566ae1a120186ed982db8b20d932098deeb10b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237989Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#777259}
-
Chen-Yu Tsai authored
V4L2PixFmtIsEqual seems to have been renamed to CheckFromV4L2PixFmtAndBack during development, as there is no trace of the former in tree. But tests for two newer pixel formats were not converted. This was found while building media_unittests for ARM desktop Linux with use_v4l2_codec=1 with the current sysroot. Convert the remaining ones so the test builds correctly. R=acourbot@chromium.org Test: Build media_unittests with use_v4l2_codec=1 and v5.2+ kernels Bug: None Change-Id: Ic7743af5089795c0a9a821ef01de90b5a1e05f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232102Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#777258}
-
kylechar authored
It is expiring and is no longer needed. Bug: 1089601 Change-Id: Ieaa9cce6c3a90ea6355fefc3e97405157891eabb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238373Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#777257}
-
tby authored
Settings results aren't distinguishable from other results when used with a screen reader. This CL manually sets their accessible name, and includes the name of the settings app at the end to mark them. Settings results are read as, for example: "Powerwash, reset settings, settings" This is consistent with other results' a11y names, which have a "result, category" pattern. Bug: 1068851 Change-Id: I24e12e21c05d43bcc99ab89c34a5b508d0f6fff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237563Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#777256}
-
dpapad authored
No longer used anywhere. Also removing IronValidatableBehavior which was only used by iron-input, and is now also unused. Fixed: 899982 Change-Id: I12cedab34ee8ab62e0b40ef4e69d67970d123f2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238997Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#777255}
-
Dana Fried authored
This fixes a bug where in full screen mode it was not possible to interact with elements in the extreme upper right of the window, because the caption button container was still there but hidden and the browser view layout did not know to exclude the hit test for them despite not actually owning the caption buttons (they were still on the frame). Now the browser layout only hit tests caption buttons if they are part of the top container rather than the frame. This fixes a specific issue where it was not possible to close Dev Tools using the mouse when the browser was in fullscreen mode (see attached bug). Bug: 1093205 Change-Id: I8798db65be56bad1fd9a32f4a54867d0a15482ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240036Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#777254}
-
Nathan Zabriskie authored
Currently CanvasResourceProvider::WritePixels writes directly to SkCanvas but this won't work with OOPR Canvas which won't have access to Skia in the renderer process. This CL adds an override for CanvasResourceProviderSharedImage which checks for OOP support and calls RasterInterface::WritePixels if it's in use. Bug: 1063725 Change-Id: Ib2ebfe48c3c5b837caf242b1e64c926287072b00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239763Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#777253}
-
Yuzu Saijo authored
This CL disables BackForwardCache when a WebContents gets embedded inside a WebContents. Bug: 1090651 Change-Id: I5410116a393e916bafba208117b0c7050c5384b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228629Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#777252}
-
Sammie Quon authored
It worked OK before, but only if the current active window was also of the same app. This is for browser and V1 apps. Test: Bug: 1088312 Change-Id: I96cbf4f433b1ed7a73014a5ebd442dbc86093a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240266 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#777251}
-
Kelvin Jiang authored
This CL adds evaluation of modifyHeaders actions for incoming requests. Currently, headers can only be removed. Change-Id: I046e032c39710b6c0791f8ac9bb5577c87b3343f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2177310 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#777250}
-
Eric Orth authored
Bug: 1093369 Change-Id: Ia04f5a7f3b44c34aa543919ff7c8a8d6468f1792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238376 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#777249}
-
Weilun Shi authored
This cl implements GetCountAndBucketData and GetParameters function for the SparseHistogram class. These two functions are required in HistogramBase::WriteJSON. Bug: 990131 Change-Id: I023b40ce1a25142b3142f1a97db719333098ec49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233924 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#777248}
-
John Palmer authored
Bug: 1060433 Change-Id: I1e3e1a976a45cdfb24c7fa1b7562eef6339950ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239437 Auto-Submit: John Palmer <jopalmer@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
-
Omid Tourzan authored
The buffer length set to 30 as they operate on external storages and there are more chance of fluctuations. Add a rate limiter to progress update for drive sync as it updates foreground continuously. Disable eslint no-var rule as var can't change to let/const in namespace redeclaration like here. Bug: 953308 Change-Id: I6aff7e5467ff68cdc016d00c090d2d31b17ba1bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237489 Commit-Queue: Omid Tourzan <oto@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#777246}
-
