GitLab

This patch converts "editing/pasteboard/8145-[1-3].html" to use w3c
test harness and consolidates into "insert_html_as_plain_text.html" to simplify
test case for ease of maintenance.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2179373002
Cr-Commit-Position: refs/heads/master@{#407735}

WebsiteSettingsUI::SetPermissionInfo doc says 'The callee is expected to take
ownership of the objects in |chosen_object_info_list|.'
Android implementations don't do anything with |chosen_object_info_list|, so
memory leaks are possible.

R=yfriedman@chromium.org
BUG=424667

Review-Url: https://codereview.chromium.org/2173773003
Cr-Commit-Position: refs/heads/master@{#407734}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/61e64edd..d07de081

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2180123002
Cr-Commit-Position: refs/heads/master@{#407733}

This patch converts "editing/inserting/typing-00[1-3].html" to use w3c
test harness and consolidates into "typing.html" to simplify test case
for ease of maintenance.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2184503003
Cr-Commit-Position: refs/heads/master@{#407732}

This patch converts "editing/typing-around-br-001.html" to use w3c test
harness to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2184603002
Cr-Commit-Position: refs/heads/master@{#407731}

TBR=kinuko, clamy
BUG=631322, 631323
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2179353002
Cr-Commit-Position: refs/heads/master@{#407730}

Cr-Commit-Position: refs/heads/master@{#407729}

Since ImageDecoder allows the same ImageRequest to be reused,
ArcWallpaperHandler can implement ImageRequest. We just need to
call ImageDecoder::Cancel() as needed (e.g. on destruction).

BUG=None
TEST=Tested setting wallpaper manually with ARC enabled device.

Review-Url: https://codereview.chromium.org/2175213002
Cr-Commit-Position: refs/heads/master@{#407728}

BUG=598902, 629735, 628496
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2174353003
Cr-Commit-Position: refs/heads/master@{#407727}

The vector of delegates_ was previously being walked on the FILE
thread. This could lead to a crash if a new delegate were to be added on
the UI thread. Now, the driver bounces back to the UI thread to send
progress updates to the delegates.

Also changes the use of scoped_refptr to be up-to-date with current
style.

BUG=none
R=pmonette@chromium.org

Review-Url: https://codereview.chromium.org/2176123002
Cr-Commit-Position: refs/heads/master@{#407726}

NOTRY=1
TBR=fs@opera.com

BUG=630967

Review-Url: https://codereview.chromium.org/2183753002
Cr-Commit-Position: refs/heads/master@{#407725}

TBR=machenbach
BUG=631315

Review-Url: https://codereview.chromium.org/2185473002
Cr-Commit-Position: refs/heads/master@{#407724}

This patch makes |ExceptionState| parameter of |ContainerNode::querySelector()|
as an optional parameter to reduce source code size for improving code
readability and ease of writing tests, since there are lots of call of
|querySelector()| with |ASSERT_NO_EXCEPTION| in Blink unit tests.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2178243002
Cr-Commit-Position: refs/heads/master@{#407723}

Like Emacs, textfields in Cocoa have a notion of a kill buffer. Certain deletion
commands (delete to beginning/end of line/paragraph) add the deleted text to the
kill buffer. All textfields in an application share the same kill buffer. This
is distinct from the system clipboard. Executing yank pastes the text in the
kill buffer at the insertion point or selection.

This CL implements the yank editing command for views::Textfield. It only has a
key binding defined on MacViews.

BUG=586985
TEST=Enable MacViews. Give focus to a MacViews textfield. Enter some text. Press
Ctrl+K to delete to end of paragraph. Verify pressing Ctrl+Y pastes the deleted
text.

Review-Url: https://codereview.chromium.org/2119813002
Cr-Commit-Position: refs/heads/master@{#407722}

Many of users of TaskRunnerHelper have ExecutionContext or ScriptState
rather than Document or Frame, which are a few step away from EC or SS.
This CL add overloads of TaskRunnerHelper::getUnthrottledTaskRunner for
EC and SS for shorthand.

BUG=624696

Review-Url: https://codereview.chromium.org/2178263002
Cr-Commit-Position: refs/heads/master@{#407721}

MemoryCoordinator sets its memory pressure notification dispatcher
in the constructor and sets back to
MemoryPressureListener::NotifyMemoryPressure() in the destructor.
This seems weird. Using MemoryPressureListener instance makes
things simpler.

BUG=617492

Review-Url: https://codereview.chromium.org/2180843004
Cr-Commit-Position: refs/heads/master@{#407720}

Use a StrongBinding in SearchProviderInstallState in place of OwnedInterface.

Review-Url: https://codereview.chromium.org/2170313002
Cr-Commit-Position: refs/heads/master@{#407719}

This patch converts "editing/inserting/insert-paragraph-0[1-5].html" to use w3c
test harness and consolidates into "insert_paragraph.html" to simplify test
case for ease of maintenance.

This patch is a preparation of getting rid of grammar checking feature.

Review-Url: https://codereview.chromium.org/2175233002
Cr-Commit-Position: refs/heads/master@{#407718}

Revert of Disable Many AppBannerDataFetcherBrowserTest Failing Tests (patchset #3 id:40001 of https://codereview.chromium.org/2184503002/ )

Reason for revert:
Speculative revert to see if reverting crrev.com/2183783002 fixes the failing tests in crbug.com/631190.

App banners use methods touched by that CL to check if a service worker is registered.

This CL will be relanded if the re-enabled tests still fail on https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29

Original issue's description:
> Disable Many AppBannerDataFetcherBrowserTest Failing Tests
>
> TBR=dominickn@chromium.org
>
> BUG=631190
>
> Committed: https://crrev.com/3429dff80be28f18b66b7d93718d131dc4aea9de
> Cr-Commit-Position: refs/heads/master@{#407653}

TBR=mpearson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=631190

Review-Url: https://codereview.chromium.org/2185483002
Cr-Commit-Position: refs/heads/master@{#407717}

Reading consumeClipPath() mislead me into thinking clip-path
supported <basic-shape> values. This rename makes it clearer
that only the prefixed version supports those.

Review-Url: https://codereview.chromium.org/2181893002
Cr-Commit-Position: refs/heads/master@{#407716}

Revert of Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks. (patchset #4 id:80001 of https://codereview.chromium.org/2181553003/ )

Reason for revert:
Speculative revert to see if this caused crbug.com/631190. App banners use methods touched by this CL to check if a service worker is registered; this is the only relevant-looking CL in the blamelist for the app banner data fetcher tests starting to fail on the Win7 SP1 bot.

This CL will be relanded if re-enabling the disabled app banner data fetcher tests still causes failures on https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29

Original issue's description:
> Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks.
>
> BUG=616502
>
> Committed: https://crrev.com/36986071183bdb219186aa9f63f9ee4b162d91b9
> Cr-Commit-Position: refs/heads/master@{#407487}

TBR=nhiroki@chromium.org,peter@chromium.org,dgozman@chromium.org,mmenke@chromium.org,jkarlin@chromium.org,horo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=616502

Review-Url: https://codereview.chromium.org/2183783002
Cr-Commit-Position: refs/heads/master@{#407715}

This reverts commit 2cba6671.

Reason: Speculative revert so that crrev.com/2181553003 can be reverted.
This may have caused crbug.com/631190.

This CL will be relanded if reverting the dependent CL and re-enabling
the disabled app banner data fetcher tests still causes failures on
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29

TBR=horo@chromium.org,jochen@chromium.org,nhiroki@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=631190

Review-Url: https://codereview.chromium.org/2181983002
Cr-Commit-Position: refs/heads/master@{#407714}

Reland of current program can be null in ES2/ES3 contexts. (patchset #1 id:1 of https://codereview.chromium.org/2181193002/ )

Reason for revert:
I don't think this is related.  See crbug.com/631316 and here the conversion between me and Mark.

Original issue's description:
> Revert of current program can be null in ES2/ES3 contexts. (patchset #2 id:20001 of https://codereview.chromium.org/2174173002/ )
>
> Reason for revert:
> Caused webkit test failure on WebKit Win7 (dbg)
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/6624
>
> unexpected_failures:
> printing/webgl-oversized-printing.html
> virtual/threaded/printing/webgl-oversized-printing.html
>
> https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7__dbg_/6624/layout-test-results/results.html
>
> ---
> --- E:\b\rr\tmpymgexl\w\layout-test-results\printing/webgl-oversized-printing-expected.txt
> +++ E:\b\rr\tmpymgexl\w\layout-test-results\printing/webgl-oversized-printing-actual.txt
> @@ -1,5 +1,5 @@
> -PASS successfullyParsed is true
> +CONSOLE ERROR: line 13: Uncaught TypeError: Cannot read property 'clearColor' of null
> +FAIL successfullyParsed should be true. Was false.
>
>  TEST COMPLETE
> -PASS Printed without crashing.
> ---
>
> ---
> --- E:\b\rr\tmpymgexl\w\layout-test-results\virtual/threaded/printing/webgl-oversized-printing-expected.txt
> +++ E:\b\rr\tmpymgexl\w\layout-test-results\virtual/threaded/printing/webgl-oversized-printing-actual.txt
> @@ -1,5 +1,5 @@
> -PASS successfullyParsed is true
> +CONSOLE ERROR: line 13: Uncaught TypeError: Cannot read property 'clearColor' of null
> +FAIL successfullyParsed should be true. Was false.
>
>  TEST COMPLETE
> -PASS Printed without crashing.
> ---
>
> Original issue's description:
> > current program can be null in ES2/ES3 contexts.
> >
> > They are only required to be non null in WebGL.
> >
> > This also did some clean up and a minor optimization.
> >
> > BUG=630802
> > TEST=fuzzer case in the bug
> > R=piman@chromium.org
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> >
> > Committed: https://crrev.com/14ef40159115ca5059907835a34bcd1667af7631
> > Cr-Commit-Position: refs/heads/master@{#407659}
>
> TBR=piman@chromium.org,yunchao.he@intel.com,zmo@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=630802
>
> Committed: https://crrev.com/e9c2cd979c8114b75bbc2640a43a1371d64f502b
> Cr-Commit-Position: refs/heads/master@{#407711}

TBR=piman@chromium.org,yunchao.he@intel.com,mpearson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630802

Review-Url: https://codereview.chromium.org/2186473002
Cr-Commit-Position: refs/heads/master@{#407713}

Move Node::*editable* functions to core/editing/EditingUtilities

TEST=No change in behavior

Review-Url: https://codereview.chromium.org/2177783003
Cr-Commit-Position: refs/heads/master@{#407712}

Revert of current program can be null in ES2/ES3 contexts. (patchset #2 id:20001 of https://codereview.chromium.org/2174173002/ )

Reason for revert:
Caused webkit test failure on WebKit Win7 (dbg)
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/6624

unexpected_failures:
printing/webgl-oversized-printing.html
virtual/threaded/printing/webgl-oversized-printing.html

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7__dbg_/6624/layout-test-results/results.html

---
--- E:\b\rr\tmpymgexl\w\layout-test-results\printing/webgl-oversized-printing-expected.txt
+++ E:\b\rr\tmpymgexl\w\layout-test-results\printing/webgl-oversized-printing-actual.txt
@@ -1,5 +1,5 @@
-PASS successfullyParsed is true
+CONSOLE ERROR: line 13: Uncaught TypeError: Cannot read property 'clearColor' of null
+FAIL successfullyParsed should be true. Was false.

 TEST COMPLETE
-PASS Printed without crashing.
---

---
--- E:\b\rr\tmpymgexl\w\layout-test-results\virtual/threaded/printing/webgl-oversized-printing-expected.txt
+++ E:\b\rr\tmpymgexl\w\layout-test-results\virtual/threaded/printing/webgl-oversized-printing-actual.txt
@@ -1,5 +1,5 @@
-PASS successfullyParsed is true
+CONSOLE ERROR: line 13: Uncaught TypeError: Cannot read property 'clearColor' of null
+FAIL successfullyParsed should be true. Was false.

 TEST COMPLETE
-PASS Printed without crashing.
---

Original issue's description:
> current program can be null in ES2/ES3 contexts.
>
> They are only required to be non null in WebGL.
>
> This also did some clean up and a minor optimization.
>
> BUG=630802
> TEST=fuzzer case in the bug
> R=piman@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/14ef40159115ca5059907835a34bcd1667af7631
> Cr-Commit-Position: refs/heads/master@{#407659}

TBR=piman@chromium.org,yunchao.he@intel.com,zmo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630802

Review-Url: https://codereview.chromium.org/2181193002
Cr-Commit-Position: refs/heads/master@{#407711}

R=tsergeant@chromium.org
BUG=630619
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2182863002
Cr-Commit-Position: refs/heads/master@{#407710}

Add blink::WebInputElement::filteredDataListOptions(), and it implements the
filtering logic which was in GetDataListSuggestions().
The logic should be in Blink because it affects a web-platform behavior.

This CL doesn't have behavior changes.

BUG=153991

Review-Url: https://codereview.chromium.org/2174303002
Cr-Commit-Position: refs/heads/master@{#407709}

Revert of Hack to fix settings-checkbox mixin for 1.6.0 (patchset #2 id:20001 of https://codereview.chromium.org/2168383003/ )

Reason for revert:
Not required if we disable useNativeCSSProperties for 1.6.0.

Original issue's description:
> Hack to fix settings-checkbox mixin for 1.6.0
>
> BUG=
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Committed: https://crrev.com/8f718e9ac7ba2194633a6a827a0dbc57570714a7
> Cr-Commit-Position: refs/heads/master@{#407347}

TBR=dbeam@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=

Review-Url: https://codereview.chromium.org/2179053002
Cr-Commit-Position: refs/heads/master@{#407708}

I didn't see these failures in the original lists I checked.

TBR=dominickn@chromium.org

BUG=631190

Review-Url: https://codereview.chromium.org/2183743002
Cr-Commit-Position: refs/heads/master@{#407707}

- highlight errors in snippet source;
- fix location of Syntax Errors in console messge;
- fix location of Snippet result in console message

BUG=479712
R=lushnikov@chromium.org

Review-Url: https://codereview.chromium.org/2173233002
Cr-Commit-Position: refs/heads/master@{#407706}

Review-Url: https://codereview.chromium.org/2180853003
Cr-Commit-Position: refs/heads/master@{#407705}

Cast device certificates may be revoked through two ways:
1. The hash of the public key.
2. A serial number range for an issuer identified by the hash
   of its public key.

A customized proto is used as the medium for this information.

This change contains the implementation for verifying the custom CRL
and verifying a certificate's revocation status based on that CRL.

BUG=618463

Committed: https://crrev.com/698608f28ed2df276f920c9691cbfcb8f9069337
Review-Url: https://codereview.chromium.org/2050983002
Cr-Original-Commit-Position: refs/heads/master@{#407492}
Cr-Commit-Position: refs/heads/master@{#407704}

Currently Tab is consuming the device BACK key even when suggestion window
is visible and doing page navigation instead of dismissing suggestion
window. Added changes to consume BACK key at suggestion window, so that
it can consume BACK key and execute respective actions.

BUG=630633

Review-Url: https://codereview.chromium.org/2174633004
Cr-Commit-Position: refs/heads/master@{#407703}

This only affects the Linux build.

BUG=607968

Review-Url: https://codereview.chromium.org/2158753003
Cr-Commit-Position: refs/heads/master@{#407702}

R=michaelpg@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true  # crisper.js

Review-Url: https://codereview.chromium.org/2167383003
Cr-Commit-Position: refs/heads/master@{#407701}

Reland of HttpChunkedDecoder: Support chunks longer than 2^31-1 bytes. (patchset #1 id:1 of https://codereview.chromium.org/2183433003/ )

Reason for revert:
The CL was blamed for compile failures it didn't cause, re-landing.

Original issue's description:
> Revert of HttpChunkedDecoder: Support chunks longer than 2^31-1 bytes. (patchset #4 id:60001 of https://codereview.chromium.org/2170133004/ )
>
> Reason for revert:
> Speculative revert for bug 631246.  Have no better ideas.
>
> Apologies if this wasn't the cause.
>
> Original issue's description:
> > HttpChunkedDecoder: Support chunks longer than 2^31-1 bytes.
> >
> > We were using HexStringToInt to parse chunk size, which returns a
> > 32-bit int.  This CL switches to using HexStringToInt64, which uses
> > 64-bit ints, so we can now support chunks up to 2^63-1 bytes.
> >
> > That should be enough for anybody. [Cue dramatic music]
> >
> > BUG=630680
> >
> > Committed: https://crrev.com/8ea249f8b70f154f9995ed538fc853fe9cf46503
> > Cr-Commit-Position: refs/heads/master@{#407549}
>
> TBR=eroman@chromium.org,mmenke@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=630680
>
> Committed: https://crrev.com/2321e8a45603ca595296b67e4d064c070f2b3591
> Cr-Commit-Position: refs/heads/master@{#407651}

TBR=eroman@chromium.org,mpearson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630680

Review-Url: https://codereview.chromium.org/2180063002
Cr-Commit-Position: refs/heads/master@{#407700}

This patch updates the code to prevent auto deducing to a raw pointer.

R=dalecurtis@chromium.org
BUG=554600

Review-Url: https://codereview.chromium.org/2181163002
Cr-Commit-Position: refs/heads/master@{#407699}

WebUI URLRequest source data is (on desktop) backed by a memory-mapped
file. Copying that data in CompleteRead can trigger jankiness due to
potential file IO caused by the read.

This CL moves the memcpy on the file thread.

R=dbeam@chromium.org
BUG=455423

Review-Url: https://codereview.chromium.org/2158123003
Cr-Commit-Position: refs/heads/master@{#407698}

Cr-Commit-Position: refs/heads/master@{#407697}

Per-request from rkaplow

BUG=

Review-Url: https://codereview.chromium.org/2168233002
Cr-Commit-Position: refs/heads/master@{#407696}