- 11 Jul, 2019 40 commits
-
-
Yuzu Saijo authored
This CL makes PageMsg IPCs unfreezable (non-stoppable) all the time, regardless of its associated frame's frozen status. Currently, PageMsg IPCs sometimes share the same routing_id with its frame and they get posted to freezable per-frame task runners, which is a bug. This should fix some browser tests that were disabled. So this CL also enables the tests that were disabled because of the bug. Bug: 981886, 978021, 978028 Change-Id: I9761b020b1d569189ff3ddc1524a6bf9fcb43953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690052Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#676348}
-
Matt Falkenhagen authored
It wasn't actually waiting for |num_jobs| when NavigationLoaderOnUI is enabled. When that feature is enabled, the function is called directly from the UI thread, and if |ongoing_mock_requests_| doesn't have size |num_jobs| it would return without waiting. This was discovered by https://chromium-review.googlesource.com/c/chromium/src/+/1688592 which will introduce a thread hop in order to perform service worker interception before doing an outgoing network request, so WaitForJobs() will be called before a request is added to ongoing_mock_requests_. Bug: 824858, 978556 Change-Id: I7264f1a4f04e517694417affcd5a8d20d0f4b9b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689979 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#676347}
-
Colin Blundell authored
Per offline discussion Change-Id: Ib48bf55a6fac69c2ede0c1261bc1283feaa4e04a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697184Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#676346}
-
Friedrich Horschig authored
With this CL, we will now show the origins as user info titles iff the the credential origin differs from the current site origin. Mock about how this will look like are in the linked bug. The changes only affect the not yet launched accessory V2. Bug: 981928 Change-Id: Id3c26c8d224222f2160965ca43f95cfafcd64767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695294 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#676345}
-
Leon Han authored
This CL removes all includes of content/common/service_worker/service_worker_types.h from content/renderer/service_worker/, to facilitate merging service_worker_types.h into content/browser/service_worker/ later. BUG=789854 Change-Id: I918070fe6bc21972d32d330a93bdbab117ff37e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695062 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#676344}
-
Staphany Park authored
We expect https://crrev.com/c/1635430 to have fixed the flakiness and manually confirmed that the test now passes across 100 repeated runs. Bug: 827231 Change-Id: I4599671cf6db1192847585ba2789995b377d23aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696449 Commit-Queue: Staphany Park <staphany@chromium.org> Auto-Submit: Staphany Park <staphany@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#676343}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding DeviceO2TSDelegate into DeviceO2TS now that the latter is no longer an O2TS subclass. It moves GetRobotAccountId(), CheckRobotAccountId(), OnServiceAccountIdentityChanged(), and |service_account_identity_subscription_| which are related to the robot account ID. Bug: 967598 Change-Id: I63ffc5c9ee6f56bdadfdaf47b5b2eb870c77187f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694901 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
-
Matthias Körber authored
Bug: 881346 Change-Id: I68c6b18bcb21cca20ec194d2d9dcfee17d5cceec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662411 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#676341}
-
Tsuyoshi Horo authored
So that we can start the OriginTrial experiment in specific milestone's Chrome. Bug: 935267, 980828 Change-Id: Ibb7bf6f071023504adb1d3ddf74921b195a427a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697063Reviewed-by:
-
Michael Lippautz authored
- Remove eager sweeping as the support will be dropped - Extend pre-finalizer examples - Clarify that pre-finalizers are not allowed to resurrect Bug: 982754 Change-Id: Ia3a0a4bfa4c872d1eeacd568920ba5b820703828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697603Reviewed-by:
-
Robbie Gibson authored
Bug: 932116 Change-Id: I5c53bb39d4edab10c7aba2ece6462ddf2ce12f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695363Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#676338}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ffcc6abe..062d4a74 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib7e683b3cc4f7aa60812fc66c7567c06718086bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695322Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676337}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b1d9da985777..80fe6f05f6bd Created with: gclient setdep -r src-internal@80fe6f05f6bd The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=hcarmona@google.com,hajimehoshi@google.com,jbroman@google.com Change-Id: I95fd0e8ca790bce3eb46dd7ab041ea154a52934d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697177Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676336}
-
Nazerke authored
Bug: 973040, 979183 Change-Id: I2ec413e4220129bcd8bc29975c51fd29c17190c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678177 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
Fix mojo connection error handling on extensions to fix flaky tests. Document that in network_context.mojom. Bug: 981467, 967524 Change-Id: I51cd834ca71cb712b1538196ba5e2d730a0c2eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689554 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
-
Darren Shen authored
There's a bug with SetCompositionRange: 1. XKB calls SetCompositionRange. 2. InputMethodEngine asks text client to underline the text. 3. InputMethodEngine does not update local composition, so it's empty. 4. XKB switches input methods. 5. When disabling the InputMethodEngine, we commit the composition text. But it thinks composition text is empty! 6. InputMethodEngine commits nothing and XKB will switch to new input method, with existing text left in composition. To avoid this stale cache issue, we'll use ConfirmCompositionText instead of committing the cached composition. We will remove the cached composition in a future patch. TEST=InputMethodChromeOSTest.ConfirmCompositionText* InputMethodEngineTest.TestDisableAfterSetCompositionRange Bug: 980437 Change-Id: Ia7cdf2d6be7d892595211dfaca67a1eefc71686c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687720Reviewed-by:Shu Chen <shuchen@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#676333}
-
Adam Ettenberger authored
It's unsafe to look at any node other than the node being updated while handling AXTree::UpdateNode. Removing logic in |AXEventGenerator::OnNodeDataWillChange| which called |GetUnignoredParent| and moved it to where the event is handled with a stable tree in |BrowserAccessibilityManagerWin::FireGeneratedEvent|. Bug: 651614, 974444 Change-Id: I1e0254ea25003c827f625bbb9a256f66a3817a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693776 Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#676332}
-
chrome://autofill-internalsDominic Battre authored
This CL introduces logging mechanisms for chrome://autofill-internals that are more high fidelity than what we have today. They allow to log structured data, use colors to indicate the context, etc. As a first usecase, the CL starts logging parsed forms. Bug: 928595 Change-Id: Ib304de4dafe0686ed9f8d6720f43b2416c49c8dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689204 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Gabriel Charette authored
This reverts commit 7c7e0f8d. Reason for revert: crbug.com/982998 (flaky on win7_rel) Original change's description: > UIA: Upon visibility change, fire UIA_AriaPropertiesPropertyId event > > - Implemented firing property changed event for > UIA_AriaPropertiesPropertyId - hidden upon visibility change > introduced by aria-hidden and visibility:hidden, accompanied by > associated browser dump tests. > > - Documentation on UI Automation AriaProperties > (see the second table's last column for AriaProperties > properties): > https://docs.microsoft.com/en-us/windows/desktop/WinAuto/uiauto-ariaspecification > > Bug: 928949 > Change-Id: I7808ba8fe352d515a054027217afc34892b38732 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659970 > Commit-Queue: Victor Fei <vicfei@microsoft.com> > Reviewed-by: Katie Dektar <katie@chromium.org> > Reviewed-by: Ian Prest <iapres@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#675876} TBR=katie@chromium.org,iapres@microsoft.com,vicfei@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 928949, 982998 Change-Id: I401c2a439a35b22232655e3bba91977f3c450538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696846Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#676330}
-
Colin Blundell authored
This CL moves the files that are currently in the //components/signin/core/browser:shared GN target into the structure described in this document: https://docs.google.com/document/d/1p_kahITGFgv7PehQ61-thRVR3Hrdaf3tLryMytTRPYs/edit# Namely, files intended for usage by the entire signin component and its consumers are moved into a new //signin/public/base/ directory. Files that are conceptually part of the IdentityManager public interface are moved into //signin/public/identity_manager/. This change was done in two parts: 1. A script that did the code moves and corresponding renames, include path changes, etc. 2. Manual followup that changed GN files and DEPS to reflect the new structure. For ease of reviewing, I uploaded 1 as the original PS and 2 as PS2. TBR=jochen@chromium.org Bug: 952788 Change-Id: I88afc79b426f3acc954d78006ed88d4cd0579672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687239Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Aga Wronska authored
Bug: 975504 Change-Id: Id28552a8f51501accccbf0b640245ac981f9a13b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691910Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#676328}
-
Leon Han authored
This CL removes those unnecessary things from content/common/service_worker/service_worker_types.h, follow-up CLs will remove all dependencies on it from all code other than content/browser/service_worker/, then move/merge it into content/browser/service_worker/ finally. BUG=789854 Change-Id: Ied002b16718d345bd038f11c4486d703cdc4bdfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692206Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#676327}
-
Jinsuk Kim authored
This CL modifies the feature flag overscroll navigation so that users can enable/disable navigation sheet as an option. Bug: 937946 Change-Id: Id7bf39054d561927be74262331226ce112ef7caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694184 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#676326}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I47238b1530a47dbd48415d2fd17a6ca752c43ed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697171Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676325}
-
Noel Gordon authored
Update the metadata sub-system to extract RAW image file ifd via Image Loader. Add metadata/BUILD.gn dependency on Image Loader. Change metadata box controller to request ifd for RAW images, and show the result in the <files-metadata-box>. Change ‘openQuickViewImageRaw’ test to verify that RAW image metadata is shown in the metadata box. Test: browser_tests —gtest_filter=“QuickView*openQuickViewImageRaw” Bug: 965370 Change-Id: Ie70aba24904e392724c3ce6b1183f1b24b207b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697701 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#676324}
-
Naoki Fukino authored
We are still monitoring Cryptohome.MigrationUI.* metrics to see if the migration of cryptohome encryption stay normal over version-ups of Chrome OS. Let me unset the expiracy of the metric. Bug: 975971 Test: None Change-Id: I9431d5263bfc43b19e0a9a035c5c1770592c124b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692462Reviewed-by:
Junichi Uekawa <uekawa@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Auto-Submit: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#676323}
-
Peter K. Lee authored
This fixed unit test failures when Manual Translate is enabled by default. This is required for http://crrev/c/1693506. Change-Id: I462487633925de4c19f6a65ba986df3d96bb881b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695654 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Henrique Ferreiro authored
Remove unnecessary includes from //components/user_manager public API and fix its build dependencies. Change-Id: Ia275cd10bfdf49013e604b59e8f3c19b3df880ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695542Reviewed-by:
-
Austin Tankiang authored
The "Open with" context menu item can contain an icon displayed on the right. This icon is implemented as a background image, so the text can overlap the icon if it is too long. Fix this by adding a margin to the end of the element when we show an icon. Bug: 958719 Change-Id: Ic8108e8300cdd1c584d483ce442e2a6362814bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697001Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
-
Omer Katz authored
Both PreFinalizers reset host_ pointer and close binding_. Bug: 981043 Change-Id: I8f4a22e696e3c5c0532b8021d0ae1c207e9fef0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692417Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Omer Katz authored
Replaced dtor with equivalent pre-finalizer. Bug: 981043 Change-Id: I6a5e4df7ae5438c3dafee0122d3965564fbf7ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692416Reviewed-by:
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding DeviceO2TSDelegate into DeviceO2TS now that the latter is no longer an O2TS subclass. It moves RefreshTokenIsAvailable and GetAccounts from DeviceO2TSDelegate to DeviceO2TS not to refer to |delegate_|. Bug: 967598 Change-Id: I75faec6e9aa747dc908f9d9c2782dd01e426b847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692382Reviewed-by:
-
Matt Falkenhagen authored
Refactoring only. There's no need for the interface. Bug: 926114, 824858 Change-Id: Ia7d5784f3f87710e26cde7469f655655e74e846f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694248Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f304969e0f53..4e6a4416e5df git log f304969e0f53..4e6a4416e5df --date=short --no-merges --format='%ad %ae %s' 2019-07-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-07-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 4e71b2bc2546..9668237739a2 (7 commits) 2019-07-11 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-07-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 9d81bd85..17462d53 (335 commits) 2019-07-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 8c4c9e37bf96..28ae0a4b2810 (3 commits) Created with: gclient setdep -r src/third_party/skia@4e6a4416e5df The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@google.com Change-Id: I45b32c82b7554e6f776017b241affff603266292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697166Reviewed-by:
-
Noel Gordon authored
Bug: 965370 Change-Id: I63542b98125102022fb00a79b12ef64ad1ad4439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697125Reviewed-by:
-
Staphany Park authored
Change-Id: Ic0a245f29020ec2c2b8679ed56f285312312d126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696834 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Staphany Park <staphany@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8f0eabe40a7c..b1d9da985777 Created with: gclient setdep -r src-internal@b1d9da985777 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=hcarmona@google.com,hajimehoshi@google.com,jbroman@google.com Change-Id: I9c5797980b72a987da8c0631543cab8c1114065a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697044Reviewed-by:
-
Takashi Sakamoto authored
Bug: 981058 Change-Id: Iea49ab3f5dc112ccf4475f08d807d2ff8ed94f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692111 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#676311}
-
Hitoshi Yoshida authored
Date and RegExp were IDL type, but they were removed in Oct. 2015.[1] In current spec, they are not reserved words and can be used as identifiers. This CL drops these words from keywords in Blink IDL parser, to follow the current spec. [1] https://github.com/heycam/webidl/pull/69 Bug: 839389 Change-Id: I2592573ba0c1875a3e828a54adfc5e040184d3fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696842Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#676310}
-
Wei Lee authored
This CL removes cache fps range entry if SetFpsRange() gets invalid input so that it will use default fps range rather than unexpected cache range. In addition, it fixes a bug of method typo in options.js and avoids reporting error when the SetFpsRange() fails intendedly. Bug: None Test: Manually. Change-Id: I924a663607a5d0829c8f0aa5873a7488aca072f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687569 Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sheng-hao Tsao <shenghao@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#676309}
-
