- 12 Dec, 2020 40 commits
-
-
Khushal authored
R=bsalomon@google.com Change-Id: I72615b36891e9e5ee568a8332bf0b6344b8188da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545684 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#836396}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I45540b59015197932e32719f58284f3153470d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587585Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836395}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I6db944ffd01e9008b0c56eace8831a166511a357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587589Reviewed-by:
-
Julie Jeongeun Kim authored
Previously RendererStartupHelper::GetRenderer() returns mojom::Renderer* having DCHECK that makes sure the map includes it. But, GetRenderer() would be accessed before the map is updated. This CL returns nullptr from RendererStartupHelper::GetRenderer() when |process_mojo_map_| doesn't have the information corresponding to the process. Bug: 1157200 Change-Id: Ifacc4cfcd9457716d7eca700b7df4be8576f68b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583663 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#836393}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/da7e8b6d..dc599083 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4afc136c2ff5f3fd63c8b1b7854d44aec923d887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587702Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836392}
-
Gyuyoung Kim authored
This CL migrates AwViewMsg_ResetScrollAndScaleState to LocalMainFrame interface. Bug: 1157122 Change-Id: I353739146052f471d2f45bbfd7b0d579cd2f0772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583588 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#836391}
-
Mitsuru Oshima authored
Bug: 1157664 Test: Coverd by unittests Change-Id: Id2c676779101f10e046ad4b8d168317316fd9db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587610 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#836390}
-
Mario Sanchez Prada authored
This reverts commit a1caa660. Reason for revert: It seems that the migration of RequestPause is causing some crashes, along with some flakiness in quite a few tests (see bugs 1157572, 1157779, 1157263, 1157241 and 1157239), so let's revert this patch for now. Original change's description: > Migrate MediaPlayerDelegateMsg_Request{Play,Pause} to mojo > > This migrates these legacy IPC messages to the media.mojom.MediaPlayer > mojo interface, now implemented by HTMLMediaElement inside of Blink, > and updates its callers in the browser process. > > Relevant design document: > https://docs.google.com/document/d/1OLMNxLvGkRO6ju_WfHbRMrgaVnW7bsMnW7XlJQI0A2E > > Bug: 1039252 > Change-Id: Ia4c873402179fb3eb918a3bc077b19842026ce21 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543025 > Commit-Queue: Mario Sanchez Prada <mario@igalia.com> > Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835304} TBR=kinuko@chromium.org,haraken@chromium.org,mlamouri@chromium.org,chcunningham@chromium.org,beccahughes@chromium.org,mario@igalia.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1039252 Change-Id: I2fe99c76d5d35be344d9578d489292d2cf4ab9a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586350Reviewed-by:
Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#836389}
-
Yi Gu authored
[CodeHealth] Convert chrome/browser/supervised_user/ from base::Bind and base::Callback to Once/Repeating Bug: 1152281 Change-Id: I51b6bf363ac5cbbefa1e602a1a6b1245350d1d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587349Reviewed-by:
Dan S <danan@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#836388}
-
Erik Chen authored
Previously, protocol errors would result in graceful termination of this browser. This would visibly appear like a crash to users but no crash report would be generated. Bug: 1151480 Change-Id: I76209bd5b57471f6fc8e435027f1be286894c991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586194 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#836387}
-
Alex Moshchuk authored
This reverts commit 7ffd10d3. Reason for revert: [Sheriff] Suspected to be causing widespread accessibility test failures on MSAN bots due to use of uninitialized value in code that was added to CreateOrUpdateLayer in this CL (line 73, presumably for `stack_at_top`) Build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21677 Sample failure: [ RUN ] AccessibilityFocusRingControllerTest.FocusRingWorksOnMultipleDisplays 2020-12-11T22:10:55.266324Z 8322331852 ERROR ash_unittests[24691:24691]: [cras_audio_handler.cc(1611)] Failed to retrieve WBS mic deprioritized flag ==24691==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x5653d294dffa in ash::AccessibilityLayer::CreateOrUpdateLayer(aura::Window*, char const*, gfx::Rect const&, bool) ./../../ash/accessibility/accessibility_layer.cc:73:7 #1 0x5653d294788e in ash::AccessibilityFocusRingLayer::Set(ash::AccessibilityFocusRing const&) ./../../ash/accessibility/accessibility_focus_ring_layer.cc:116:3 #2 0x5653d29383cb in ash::AccessibilityFocusRingGroup::UpdateFocusRingsFromInfo(ash::AccessibilityLayerDelegate*) ./../../ash/accessibility/accessibility_focus_ring_group.cc:82:25 #3 0x5653d293baa9 in ash::AccessibilityFocusRingGroup::UpdateFocusRing(std::__1::unique_ptr<ash::AccessibilityFocusRingInfo, std::__1::default_delete<ash::AccessibilityFocusRingInfo> >, ash::AccessibilityLayerDelegate*) ./../../ash/accessibility/accessibility_focus_ring_group.cc:152:3 #4 0x5653d2932f04 in ash::AccessibilityFocusRingControllerImpl::SetFocusRing(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::unique_ptr<ash::AccessibilityFocusRingInfo, std::__1::default_delete<ash::AccessibilityFocusRingInfo> >) ./../../ash/accessibility/accessibility_focus_ring_controller_impl.cc:67:25 #5 0x5653cda0dbe2 in ash::AccessibilityFocusRingControllerTest_FocusRingWorksOnMultipleDisplays_Test::TestBody() ./../../ash/accessibility/accessibility_focus_ring_controller_unittest.cc:106:15 #6 0x5653d24cc4a7 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #7 0x5653d24cc4a7 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2689:5 #8 0x5653d24ceb57 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2866:11 #9 0x5653d24d0e64 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3020:28 #10 0x5653d24fb28a in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5730:44 #11 0x5653d24fa26c in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10 #12 0x5653d24fa26c in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5313:10 #13 0x5653d3c13224 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2485:46 #14 0x5653d3c13224 in base::TestSuite::Run() ./../../base/test/test_suite.cc:480:16 #15 0x5653d3c1addf in Run ./../../base/callback.h:101:12 #16 0x5653d3c1addf in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:179:38 #17 0x5653d3c1a853 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:249:10 #18 0x5653cf8bc976 in main ./../../ash/test/ash_unittests.cc:25:10 #19 0x7fe4936dd83f in __libc_start_main ??:0:0 #20 0x5653cd7f7409 in _start ??:0:0 Uninitialized value was created by a heap allocation #0 0x5653cd86a7c9 in operator new(unsigned long) /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/msan/msan_new_delete.cpp:45:35 #1 0x5653d2938051 in make_unique<ash::AccessibilityFocusRingLayer, ash::AccessibilityLayerDelegate *&> ./../../buildtools/third_party/libc++/trunk/include/memory:3043:28 #2 0x5653d2938051 in ash::AccessibilityFocusRingGroup::UpdateFocusRingsFromInfo(ash::AccessibilityLayerDelegate*) ./../../ash/accessibility/accessibility_focus_ring_group.cc:69:11 #3 0x5653d293baa9 in ash::AccessibilityFocusRingGroup::UpdateFocusRing(std::__1::unique_ptr<ash::AccessibilityFocusRingInfo, std::__1::default_delete<ash::AccessibilityFocusRingInfo> >, ash::AccessibilityLayerDelegate*) ./../../ash/accessibility/accessibility_focus_ring_group.cc:152:3 #4 0x5653d2932f04 in ash::AccessibilityFocusRingControllerImpl::SetFocusRing(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::unique_ptr<ash::AccessibilityFocusRingInfo, std::__1::default_delete<ash::AccessibilityFocusRingInfo> >) ./../../ash/accessibility/accessibility_focus_ring_controller_impl.cc:67:25 #5 0x5653cda0dbe2 in ash::AccessibilityFocusRingControllerTest_FocusRingWorksOnMultipleDisplays_Test::TestBody() ./../../ash/accessibility/accessibility_focus_ring_controller_unittest.cc:106:15 #6 0x5653d24cc4a7 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #7 0x5653d24cc4a7 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2689:5 #8 0x5653d24ceb57 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2866:11 #9 0x5653d24d0e64 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3020:28 #10 0x5653d24fb28a in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5730:44 #11 0x5653d24fa26c in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10 #12 0x5653d24fa26c in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5313:10 #13 0x5653d3c13224 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2485:46 #14 0x5653d3c13224 in base::TestSuite::Run() ./../../base/test/test_suite.cc:480:16 #15 0x5653d3c1addf in Run ./../../base/callback.h:101:12 #16 0x5653d3c1addf in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:179:38 #17 0x5653d3c1a853 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:249:10 #18 0x5653cf8bc976 in main ./../../ash/test/ash_unittests.cc:25:10 #19 0x7fe4936dd83f in __libc_start_main ??:0:0 SUMMARY: MemorySanitizer: use-of-uninitialized-value (/b/s/w/ir/out/Release/ash_unittests+0x65feffa) Original change's description: > Re-land: Move focus rings and highlight layers under accessibility bubbles. > > Original patch: http://crrev.com/c/2568547 > Revert: http://crrev.com/c/2583106 > > Fix for issue where focus ring appears below switch access panel. Now clients can specify if they want their focus ring to appear above or below accessibility bubble panels. STS will specify they appear below, though other clients will (by default) specify they appear above all panels. This fixes an issue with the switch access focus ring didn't appear above the switch access panel. > > Original description: > > Move focus rings and highlight layers under accessibility bubbles. > > Will allow Select-to-speak panel UI to appear above focus ring and highlight layers. This also avoids the need to create more window containers. > > Bug: 1157261, 1143814 > Change-Id: Ibd8dd577ecd4fb5767b628c2eff679a2f6931b9c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582997 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Joel Riley <joelriley@google.com> > Cr-Commit-Position: refs/heads/master@{#836222} TBR=xiyuan@chromium.org,dmazzoni@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,shannc@google.com,joelriley@google.com Change-Id: I08b819849d13fb5d01f67c5bbd3083ed0e445e7e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1157261 Bug: 1143814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587604Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#836386}
-
Daniel Cheng authored
Followup CLs will change how speculative RFH is cleaned up by relying on the fact that provisional frames are now owned by the frame they will replace in the renderer. Add tests to ensure nothing breaks in those followups. Bug: 838348 Change-Id: I66d34aa8ce1d5b2d65468c63c6629e58243080c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586525 Commit-Queue: Charlie Reis <creis@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#836385}
-
Alex Moshchuk authored
Bug: 626703 Change-Id: I9c165aeae54f54cc6a1c1d1a97e43f7ef5f02531 Notry: true Tbr: robertma@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587973Reviewed-by:
-
Kyle Horimoto authored
This CL fixes an issue which re-shows notifications which have already been shown to the user after the user has (1) suspended their device, (2) locked their device, or (3) turned Bluetooth off. When these situations occur, we silently add the notification to the notification shade but do not pop it up. This fixes an issue which caused notifications to appear spammy when we'd show them multiple times. Bug: 1157523, 1106937 Change-Id: I58efe0d96f226a75e07a137e22081637ebb524a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587700Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#836383}
-
Kyle Horimoto authored
Before this CL, we would show the "connecting" UI when we were waiting for a pending host to be set. This was misleading, since we were not actually connecting at all. Even worse, we'd show this UI when the user had accidentally picked the wrong device in the drop-down menu, perhaps due to crbug/923594. This CL updates Phone Hub so that it does not show any UI when we're in this state. Once the phone is actually set up, then we show the "connecting" UI. Bug: 1157971, 1106937 Change-Id: I3cc896335b436849e05a8bc2d6b0adbbdc8edfb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587563Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607709601-c889cff9228ed2a408f7c416b610f665b13ded19.profdata to chrome-mac-master-1607731149-2a55b7cdbe080700f7cc337cacf74a6b6e2cffc4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I76059014b42d07a9dc9cd6672ca6c633c17d9afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587762Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/82e0d524143f..346dd53ac087 2020-12-11 ethannicholas@google.com Reland "Reland "Reland "Revert "Initial land of SkSL DSL."""" 2020-12-11 kjlubick@google.com [canvaskit] Remove filterquality on paint. 2020-12-11 bsalomon@google.com Revert "Add new SkCanvas methods for Android Framework WebView queries." 2020-12-11 brianosman@google.com SkSLSlide: Add shadertoy iResolution & iMouse 2020-12-11 egdaniel@google.com Store command buffer usages to GrSurface's on GrVkCommandBuffer. 2020-12-11 jvanverth@google.com Increase QuadEdge precision on all platforms 2020-12-11 brianosman@google.com SkSLSlide: Add geometry options If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Change-Id: I9af1bfab027e2fe37776ea7680f665060e8945ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587595Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8bf9fbd7. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools kojii@chromium.org: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/variables rego@igalia.com: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I16e4731a3cf12b0b800ead0fdb5a860ad445811a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586854Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836379}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607709601-325646cf3b47651e58817955f6116187a5cde36c.profdata to chrome-linux-master-1607731149-f9d7b6048f47267213c698b8417226050a69f328.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iee67c91a4c64b41358f1230196ef69e87fe7d7df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587627Reviewed-by:
-
Julie Jeongeun Kim authored
This is a reland of 9b07e5e0 with a fix of a failure on Linux MSan Test builder. Added an initial value for |action_data.target_rect| to AccessibilityTest.TestSelectionActionHandling. Original change's description: > [a11y] Add scrolling action to PP_PDF_SET_SELECTION > > This CL adds scrolling when PDFiumEngine::HandleAccessibilityAction > is called with PP_PDF_SET_SELECTION and the selection is not > visible since Blink triggers also scrolling with setting selection. > So, this change makes PDF document scroll the page when a selection > is set. > > AX-Relnotes: When SetSelection action is handled on pdf, it also > triggers scrolling if the selection is not in the visible area. > For instance, atk_text_set_caret_offset() on pdf scrolls the page > if the text is not in the view port. > > Bug: 993456 > Change-Id: I8323eff293b3216e2b862f8df3e896380b1c9945 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573975 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: K. Moon <kmoon@chromium.org> > Reviewed-by: Martin Robinson <mrobinson@igalia.com> > Commit-Queue: Julie Kim <jkim@igalia.com> > Cr-Commit-Position: refs/heads/master@{#835994} Bug: 993456 Change-Id: Ie7c683d062c50d4eade2b5fb4990bc6ca2be12ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586644Reviewed-by:
K. Moon <kmoon@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#836377}
-
Chris Lu authored
Bug: 1152900 Change-Id: Id9b1db55a09487cf3e237d2d5de390c5afb9b5ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587388 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#836376}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/dbfb3029b9ff..86263397d149 2020-12-11 tsepez@chromium.org Pass new flags to cppgc heap initialization. 2020-12-11 tsepez@chromium.org Roll v8/ 61f3e6140..c52956d09 (100 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1156170 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I513306f17d1237a5ef067ee04d25e8a2ab4b88bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587405Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e94526b4043b..778b2c216924 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I02e120e4a0a487308f615fac30fc25fde22d56b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587504Reviewed-by:
-
Gyuyoung Kim authored
This CL migrates AwViewMsg_SetTextZoomFactor to LocalMainFrame interface. Bug: 1157121 Change-Id: Ieece64440d74fe38b6e7ee6073f98f495aebe058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583667 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
-
Patrick Noland authored
Bug: 1147581 Change-Id: I95664f5d6e28041143de27a1a7d2798b0ba5ae7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586093 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#836372}
-
Gordon Seto authored
Add switch to toggle high visibility mode in nearby_share_subpage. Screenshots: https://screenshot.googleplex.com/7gpoKJmsBx7GW9c.png https://screenshot.googleplex.com/Ak79VN82QFsGSkK.png https://screenshot.googleplex.com/6aVSR3FqyfvMRz6.png Fixed: 1154830 Change-Id: I2c59c8cb5a90ee7469eddfe04d691280044967d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584355 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#836371}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0d5c00517887..6798d1b9dc14 2020-12-11 yiorsi@gmail.com Fix: no space at the bottom of the image in ImageView 2020-12-11 cpinnamaneni@microsoft.com adding link support for markdownview 2020-12-11 chrche@microsoft.com [Loc] Migrate components to Localization V2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655,chromium:1154783,chromium:11574664 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia153ef44fe3239e4f122608dfcd221568999baf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585662Reviewed-by:
-
Xing Liu authored
Read later needs to be added to ChromeCachedFlags. TBR=dtrainor@chromium.org Bug: 1157113 Change-Id: Ie6dc92314603df4e8e44cd684a74a9ad64f4f1b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587622Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#836369}
-
Rouslan Solomakhin authored
Before this patch, the expiration month, year, and CVC text fields in the CVC unmask dialog were all 45dp tall, which is smaller than the 48dp required for accessibility. This patch sets the minimum height to 48dp for the expiration month, year, and CVC text fields. After this patch,the expiration month, year, and CVC text fields are at least 48dp tall. Bug: 977272 Change-Id: I955bc9a4ca88e4d813119d7e1f3f1f697a27aafe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585689Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#836368}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e94526b4043b..778b2c216924 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I534ce04cb32e1a241014f27a722c214776ea6374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587696Reviewed-by:
-
Tom Anderson authored
* Get rid of XEventDispatcher and just use XEventObserver. The difference is that 1. XEventDispatcher allows stopping of further event dispatching. However, this is dangerous because there's no guarantees of what order the dispatchers will run in. IIRC, this caused a subtle bug in the past that was difficult to fix. Stopping event dispatching is not necessary because all dispatchers already check if the event is meant for them or not. I checked the number of registered dispatchers, and it's less than 10 for the normal case, so performance isn't a concern either. 2. XEventObservers always run before XEventDispatchers. This is no longer relevant now that we've gotten rid of the "stop further dispatch" behavior from (1). * Change observer function signature from void WillProcessXEvent(x11::Event* xev) to void OnEvent(const x11::Event& xev) since the "XEvent" in "WillProcessXEvent" is misleading, since we're no longer using Xlib XEvents. Also "WillProcess" can be removed too since the corresponding "DidProcess" function was removed in the previous CL. Finally, pass the event by const& instead of by pointer to ensure dispatchers don't mutate the event, and to make it clear that the event will never be null. R=sky Bug: 739898 Change-Id: If7ce28514eb4207d8a58e71cb3e39d7ace336b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582832Reviewed-by:Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#836366}
-
David Tseng authored
These tests appear to be stable on release and debug. R=akihiroota@chromium.org Bug: none Change-Id: I838022efab03c267f27e68b642ca3c0749935b37 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587689 Commit-Queue: David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Auto-Submit: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#836365}
-
edchin authored
This test was already disabled for iOS 12 devices. But looking through the notes, it looks like it only affects iPads. Furthermore, I found it affects iOS 13 iPad devices as well. ios_chrome_settings_eg2tests_module_iPad 7th Gen 13.5.1 https://ci.chromium.org/ui/p/chrome/builders/ci/eg2-device-runner/2400/overview Nov 3, 2020 ios_chrome_settings_eg2tests_module_iPad 7th Gen 13.5.1 https://ci.chromium.org/ui/p/chrome/builders/ci/eg2-device-runner/2174/overview TBR=jlebel@chromium.org Bug: 1140400 Change-Id: I0ec87a993e01258051c0d9facbb6bbabd62f591e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587407 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#836364}
-
Trent Begin authored
This change adds the captive portal routine and group to the connectivity diagnostics application. Bug: chromium:1142857 Change-Id: I64759b54a34ee2291ebdfac273da85f9157740fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583030Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Trent Begin <tbegin@chromium.org> Cr-Commit-Position: refs/heads/master@{#836363}
-
Sammie Quon authored
This requires adding support to context menus to close without animation, otherwise it will still be visible as the default close has a fade out animation, and the screenshot will capture a near-opaque version of the menu. Accelerators by default will also close menus with fade out, so add the desk activation acclerator to the exception list and let the desk animation code handle the closing. Fixed: 991939 Test: manual Change-Id: I273042a216c651022215929594a2cedd1efecc82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586013 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#836362}
-
James Vecore authored
Change-Id: Iafa6c4057fde064553ece03b3c90009184fbf868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578008Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#836361}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0bf3f26cf343..8093cb08ef89 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC alexmos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1056387 Tbr: alexmos@google.com Change-Id: Iccce963d4f19d0ed7feee154320c1a901e1eafbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587752Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836360}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607687924-42a73eb0331784066b7e53d64e9d9a239913c74b.profdata to chrome-win64-master-1607698715-e13d73f1fde8c8ea06b6de4bb97b90c11d1836bd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I87f542471a2da868c78368896d73155384b72d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587390Reviewed-by:
-
Brian Sheedy authored
Moves the splitting of expectations based on staleness out of the output code and uses it to automatically remove stale expectations from the expectation file if specified by the user. Bug: 998329 Change-Id: I317ded44447203b8fddc2c6277ed3f5f5b66a0f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585846Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#836358}
-
Artem Bolgar authored
Dev and debug versions throw DCHECK in OnDecodeDone due to wrong syntax of logging statement: ``` FUNCTION_DVLOG(status.is_ok() ? 3 : 1) << ": " << status.code(); ``` The FUNCTION_DVLOG is defined as follows: ``` DVLOG(level) << __func__ << "<" << GetStreamTypeString() << ">" ``` The issue is that the condition "status.is_ok() ? 3 : 1" should become "level", but in reality, since there are no braces around it, it gets parsed incorrectly and the number "3" becomes a severity level (see base/logging.h), which corresponds to "FATAL" severity level, which ends up which crash / assert. Here is the code after preprocessor for that line 524 BEFORE the fix: !(((status.is_ok() ? 3 : 1) <= ::logging::GetVlogLevel("../../media/filters/decoder_stream.cc")) && (true)) ? (void) 0 : ::logging::LogMessageVoidify() & (::logging::LogMessage("../../media/filters/decoder_stream.cc", 524, -status.is_ok() ? 3 : 1).stream()) << __func__ << "<" << GetStreamTypeString() << ">" << ": " << status.code(); and this is the fixed version: !((((status.is_ok() ? 3 : 1)) <= ::logging::GetVlogLevel("../../media/filters/decoder_stream.cc")) && (true)) ? (void) 0 : ::logging::LogMessageVoidify() & (::logging::LogMessage("../../media/filters/decoder_stream.cc", 524, -(status.is_ok() ? 3 : 1)).stream()) << __func__ << "<" << GetStreamTypeString() << ">" << ": " << status.code(); Pay attention to this part: LogMessage("../../media/filters/decoder_stream.cc", 524, -status.is_ok() ? 3 : 1).stream()) and LogMessage("../../media/filters/decoder_stream.cc", 524, -(status.is_ok() ? 3 : 1)).stream()) So, basically, before the fix the negative sign is applied to the wrong statement, therefore the LogMessage will get +3 instead of -3. +3 means FATAL, while -3 means verbosity level 3, as far as I understand. Fixed: 1157701, 1156942 Change-Id: I3132dde1dbd7d18460b74715016b74228e52ad7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586656Reviewed-by:danakj <danakj@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Artem Bolgar <artyom@fb.com> Cr-Commit-Position: refs/heads/master@{#836357}
-
