- 28 Oct, 2020 40 commits
-
-
sandromaggi authored
Bug: b/171782156 Change-Id: I032f22571e342e47a2d6c8b33ce735fab40acf88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504313 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#821720}
-
Rainhard Findling authored
Bug: 1087263,1139806 Change-Id: I2bafbcb8b9fdd9a806e7d5bef68d200dd025ab4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505137Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#821719}
-
Mathias Bynens authored
Fixed: chromium:1143205 Change-Id: I95d7797c33c98de901b5c88904ddaac0e757df4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503695Reviewed-by:
Eric Robinson <ericrobinson@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#821718}
-
Arthur Hemery authored
ProcessLock.ToString() has grown in size with information such as their cross-origin isolation status and locked origin. To be able to record the full information the crash keys need to be bumped to 256B. Bug: 1142391 Change-Id: Ibdedf81ef4315248337b323734c8241361a8fbea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502331Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#821717}
-
Dominik Lang authored
Calling MemoryAllocatorDump::AsProtoInto was causing a DCHECK failure. Bug: 1098746 Change-Id: Iac11e583b7888dfe7e0b673bf47894f3ad038df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501481Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#821716}
-
arthursonzogni authored
The origin stored inside and outside blink uses a different convention for the "unspecified" port. ┌──────────────────┬───────────┐ │ port unspecified │ port zero │ ┌─────────────────────┼──────────────────┼───────────┤ │url::Origin │ -1 │ 0 │ ├─────────────────────┼──────────────────┼───────────┤ │blink::SecurityOrigin│ 0 │ 0 │ └─────────────────────┴──────────────────┴───────────┘ As a result, this property do not survive the conversion in between those types. This patch temporary provide different expectations, so that the fuzzer can continue to explore more cases. Fixed: 1143052 Bug: 1136678,1143052 Change-Id: Ibbc9f5757a190c52fdb0d8c26c0b98cc30f353fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505649Reviewed-by:Mike West <mkwst@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#821715}
-
Kuo-Hsin Yang authored
When the ram_vs_swap_weight file is not available, the ram_swap_weight varialbe is zero. CalculateAvailableMemoryUserSpaceKB uses the ram_swap_weight variable as denominator and crashes. Always set ram_swap_weight to non-zero value to avoid the dividing by zero issue. Bug: b/171033232 Change-Id: I82e2cfd28ea21e57f3e6dd40f8cd68ee9f265c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503914 Commit-Queue: Brian Geffon <bgeffon@chromium.org> Reviewed-by:
Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#821714}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603864709-80e0b66faf89b1f5bb0f1645a135a447551ec59a.profdata to chrome-linux-master-1603884477-6bc4961628956c25c92dc091d1c24520abfa529f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5681402c6a80ddc7991aa2ad20388add906517b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505572Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821713}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ecbac8fd..3f40a48d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4204fafcf5c6ab5f671012317ad19b3994bae63a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505450Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821712}
-
Oriol Brufau authored
NextVisuallyDistinctCandidateAlgorithm used to iterate forwards and return the first candidate whose MostForwardCaretPosition was different than the MostForwardCaretPosition of the original position. However, it could happen that the returned candidate and the original position had the same MostBackwardCaretPosition, leading to crashes. Therefore, this patch ensures that both the forward and backward caret positions of the candidate are different. And for consistency, the same is done for PreviousVisuallyDistinctCandidateAlgorithm, even though I couldn't find a problematic case. Bug: 1138054 TEST=VisibleUnitsTest.nextPositionOfTable Change-Id: I1e97e42765d58f5db70fb79410c8e471582a9d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501041 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#821711}
-
Marc Treib authored
PasswordManager.SaveUIDismissalReason has a base version (without suffix), and also suffixed versions split by PasswordAccountStorageUserState. Before this CL, the split versions were only recorded if features::kEnablePasswordsAccountStorage was enabled. That didn't really make sense: Some of the UserStates don't exist without that feature, but for the remaining states, the split histograms still make sense. So this CL adds recording of these histograms for users with that feature disabled. Bug: 1142797 Change-Id: I969bfe48f2337377deba6f102208e0c59ddf2309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503519Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#821710}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603864709-845b29927599ab12682abdf7fcfbf1ec60b2364e.profdata to chrome-mac-master-1603884477-73d70e68a4c2b6db53055c0ce78d0123cab0e9a7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I08fb86dbd14cc49fa407dee5168b5148b0c9ce02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505571Reviewed-by:
-
Aya ElAttar authored
Given that ClipboardDataEndpoint and ClipboardDlpController will be used for both clipboard and drag&drop, so - Used DataTransfer prefix instead as it refers to both; drag&drop and clipboard. - Renamed ClipboardDataEndpoint to DataTransferEndpoint. - Renamed ClipboardDlpController to DataTransferPolicyController. - Renamed EnterpriseClipboardDlpController to DataTransferDlpController. Bug: 1141488 Change-Id: Ib9a5be48384c6bc04a8bfd0de02b78652d9930a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489889 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#821708}
-
Sadrul Habib Chowdhury authored
The bugs for cc/metrics currently get assigned under the incorrect component (Internals>Compositing). So add a DIR_METADATA for the directory with the correct component (Internals>GPU>Metrics). BUG=none Change-Id: I63cd83b265938d21a5807bc1e7e0428e514b50c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499202 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#821707}
-
Dave Tapuska authored
One of the last RenderWidget messages handled, move it to WidgetHost. Remove widget_messages.h since it is no longer needed. BUG=1097816 Change-Id: Ic8512f82ab82eeb4687594d090002b56750be9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490346 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#821706}
-
Andreea Costinas authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/acf8878dcf83..763dc305cc96 $ git log acf8878dc..763dc305c --date=short --no-merges --format='%ad %ae %s' 2020-10-19 acostinas system_api: Update system-proxy D-Bus API 2020-10-19 kevinptt runtime_probe: align mmc_stroage fields with Python probe 2020-10-02 stevenjb shill: Add PortalDetectionFailedStatusCode Created with: roll-dep src/third_party/cros_system_api Change-Id: I5c4cf1674cae7886f6071ea9a68c4274d16e9982 Bug: 1132247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498582Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#821705}
-
Hiroshige Hayashizaki authored
This CL fixes html/semantics/scripting-1/the-script-element/module/dynamic-import/dynamic-imports-credentials.sub.html and html/semantics/scripting-1/the-script-element/module/credentials.sub.html by: - Using `set-cookie.py` instead of `document.cookie = 'same=1';`, and - Passing `origin` parameter instead of relying on Origin request header, as Firefox doesn't send Origin header in same-origin requests. This CL also adds credentials mode tests for dynamic imports from classic scripts and setTimeout(with a string argument). Bug: 1133238, 1114988 Change-Id: I18dce474f46e79c7d4161461760f0739806a1984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437556Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#821704}
-
Michael van Ouwerkerk authored
TBR=mahmoudi@chromium.org Bug: 1143219 Change-Id: If6ac545238ff7c11f883294ed1fb6d96df2254fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505629 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#821703}
-
Guido Urdaneta authored
Also rename to PushableMediaStreamVideoSource. This class is a generic building block that will be used by Raw Access Insertable Streams (a.k.a. Breakout Box). This class is very generic, so the mediastream module is a natural place for it. Bug: 1142955 Change-Id: Ibceb38dfae8638a49ce87dc735c2114a2e863145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503511 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#821702}
-
Fergal Daly authored
See https://chromium.googlesource.com/chromium/src/+/HEAD/docs/render_document.md When RenderDocument for subframes is enabled, 2 tests fail: - AdsPageLoadMetricsObserverTest.HeavyAdCpuInterventionInBackground - AdsPageLoadMetricsObserverTest.HeavyAdNetworkInterventionInBackgrounded Failures can be seen in the CQ of this change which enables RD for subframes: - https://crrev.com/c/2241368/6 They fail because the timing changes and SendInterventionReport ends up being processed before FlushForTesting is called. At that point there is no quit closure and so the message is dropped. This is fixed by storing the message even if there is no quit closure. This then requires a fix for HeavyAdPolicyProvided because it reuses the same FrameRemoteTester for many tests and some messages from one iteration linger for the next. This flushes the pipe at the start of each iteration. Also added a SCOPED_TRACE to this loop so you know which test failed when one fails. Bug: 1064944 Change-Id: I67b38f48e562ba4ecd4fad25afdc58cfb18f2b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500975 Auto-Submit: Fergal Daly <fergal@chromium.org> Reviewed-by:
-
Kyle Williams authored
Adds GetService to ServiceAdaptor to access CfM services from the CfmServiceContext. BUG=chromium:1105567, b:165864612 TEST='autoninja -C out/Default/ chrome/test:unit_tests && \ xvfb-run ./out/Default/unit_tests \ --gtest_filter=CfmServiceAdaptorTest.*' Change-Id: I33368364c7aaf2532f0bd593439ee3be21d415dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480583Reviewed-by:Alexander Alekseev <alemate@chromium.org> Commit-Queue: Kyle Williams <kdgwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#821700}
-
Sebastien Lalancette authored
Connected the Bling link-to-text JavaScript code with the open-sourced text-fragments-polyfill library. Moved out the response handling logic from LinkToTextTabHelper into LinkToTextResponse and utility functions. This enabled better readability, testability, and made it simpler to handle error cases. In error cases, the desired UX is to show an alert to the user. This first CL sets-up the handling of link-to-text link generation failures. A subsequent CL will be adding an alert coordinator to BrowserContainerCoordinator to handle showing the alert. Bug: 1136043 Change-Id: Icf204c55457e1f1bfef116d7a9986ec0cefdbd3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492241Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#821699}
-
Matt Menke authored
Also update RenderFrameHostImpl to pass in the correct NIK. Other callers have been left as TODOs. Bug: 993805 Change-Id: Ie127842ada00e7e21dfd74f3039f1ecfb0356d04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488000Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#821698}
-
Anders Hartvoll Ruud authored
We are currently able to create new CSSAnimations linked to CSSScrollTimelines, but we can not change the timeline of a CSSAnimation that is already running. There are three types of changes that can trigger a timeline change for a running animation: 1. When a @scroll-timeline rule is inserted, either via DOM mutation, or via a change in @media query evaluation. 2. When the computed value of 'animation-timeline' changes. 3. When the elements referenced by a @scroll-timeline rule changes, for example 'source:selector(#foo)' references an element with #foo, hence we need a new timeline if #foo is reassigned to point to a different element. This CL implements "timeline change detection" in CSSAnimations, which can discover whether a new timeline is needed or not. This detection runs whenever there's a non-animation-style-change, in other words, whenever something is marked for regular style style recalc, we will check if the timeline currently associated with an animation is up-to-date, and create a new one if needed. In this CL, only Item 1 in the above list is fully solved. However, since this adds the general capability to reconsider previous timeline choices upon style recalc, it also lays the groundwork for solving Item 2 & 3. InertEffect makes things a bit awkward, as usual: we basically have to predict the effect setTimeline will have on the current time of the Animation, without actually calling setTimeline. Hence there's a rather complicated if-statement which makes this prediction. We should ideally try to get rid of InertEffect and do the setTimeline call right away. In the WPT I'm also trying to cover both the result produced by InertEffect, _and_ the result produced by setTimeline. Hence each test is run twice: once for the result produced the same frame the style recalc took place, and once again after scrolling a bit. Bug: 1074052 Change-Id: Ida36a00eb91e26b493c1e70c20dc7b23be7c9a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335282 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#821697}
-
Anton Bikineev authored
This reduces the average PCScan time on the renderer process (with PA as a malloc) from 269ms to 29ms (9x). Bug: 11297512 Change-Id: I445f609751e25d943ed779453aa07a0142cbf5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498464 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#821696}
-
Kyle Williams authored
Ease indirect dependency requirements by adding sources directly into the main browser/chromeos build target BUG=chromium:1105567, b:165864612 TEST='autoninja -C out/Default/ chrome/test:unit_tests \ && xvfb-run ./out/Default/unit_tests \ --gtest_filter=CfmServiceAdaptorTest.*' Change-Id: Idc69f08b44e0fdd5c85895ed5b92a75226adb6d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495409Reviewed-by:Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Williams <kdgwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#821695}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I9bd86e8040109917232c9477c7e9d5f418f47f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504741Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#821694}
-
Vidhan authored
AlternativeStateNameMap encapsulates mappings from state names in the profiles to their localized and the abbreviated version. AlternativeStateNameMap can provide the following data for the states: 1. The state string stored in the address profile. 2. The state canonical name (StateEntry::canonical_name) which acts as the unique identifier representing the state. It is used for the comparison and determining the mergeability of the address profiles. 3. The abbreviations of the state (StateEntry::abbreviations). 4. The alternative names of the state (StateEntry::alternative_names). StateEntry holds the information about the abbreviations and the alternative names of the state. Example of a StateEntry object: { 'canonical_name': 'California', 'abbreviations': ['CA'], 'alternate_names': ['The Golden State'] } Bug: 1111960 Change-Id: I3dc3aa6f9c52c160d179e6dcad646b52b619b9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360274Reviewed-by:Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vidhan Jain <vidhanj@google.com> Cr-Commit-Position: refs/heads/master@{#821693}
-
Yuki Shiino authored
Blink-V8 bindings haven't supported IDL namespaces for a long time, however, finally IDL namespaces get supported. This patch changes `window.CSS` from an IDL interface to an IDL namespace in conformance to the standard. Change-Id: I60a7129df48b68e890ed30bf7ed03d7f79228522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434404Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
-
Oriol Brufau authored
In InsertListCommand::UnlistifyParagraph, if `list_element` has no <li>, then `list_child_node` will be a non-<li> child. In that case, `previous_list_child` and `next_list_child` may end up being the same `list_child_node` if it has multiple block children. This would make some DCHECKs fail. However, the behavior seems fine, so this patch changes the DCHECKs to ensure that `previous_list_child` and `next_list_child` are obtained from nodes different than the block where the caret is. Bug: 1138054 TEST=InsertListCommandTest.UnlistifyParagraphCrashOnNonLi Change-Id: I18631b1c90d59539433373a2139aab36115e59ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497161 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
-
Peter McNeeley authored
Overlay selection is extremely important for optimal power and performance.The |OverlayCandidateTemporalTracker| class provides a way to temporally track overlay candidate properties and to categorize them. This tracker operates on highly opaque input; it only understands resource id (changes) and damage ratios. The hysteresis in categorization is intentional and its purpose is to temporally stabilize result. Bug: 1113306 Change-Id: I3da04cd075208fab936d426d8d6c05473fbd659c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491015Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Peter McNeeley <petermcneeley@chromium.org> Cr-Commit-Position: refs/heads/master@{#821690}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/11223a39..ecbac8fd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5f17891727d8c3dfdd4e1c908a66f37661ac7227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504222Reviewed-by:
-
Alice Wang authored
This CL extracts the account picker bottom sheet header in a separate file to reuse it in different account picker view xml files after the refactoring. Bug: 1138824 Change-Id: I025c9aac45ca5022a6b95d4ba3d847120d7cf3b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502588Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#821688}
-
Dominik Röttsches authored
This reverts commit 0d7be96e. Reason for revert: Suspected of causing failures on CrOS device bots, see https://crbug.com/1143224 Original change's description: > Add --use-swarming-go to the custom trigger scripts > > Design doc: http://go/roll-go-swarming-to-trigger-scripts > > Bug: 1127205 > Change-Id: I8ca8e2bb381f340fc23b91339cdb56374f8eead8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500976 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Wenbin Zhang <wenbinzhang@google.com> > Commit-Queue: Ye Kuang <yekuang@google.com> > Cr-Commit-Position: refs/heads/master@{#821619} TBR=tikuta@chromium.org,wenbinzhang@google.com,yekuang@google.com Change-Id: I017fc7ef2947a7d0f2e077e6d8eafd98b7f2865f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1127205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505509Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#821687}
-
Dominik Röttsches authored
Bug: 1143206 Change-Id: I2aa70984f0b03d9c59ed2ac8e738bfea051e8a3b Tbr: titouan Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503696Reviewed-by:
-
Eric Seckler authored
Makes it possible to enable LITTLE-cores-only mode via Finch, by replacing the existing command line flag with a base::Feature. It can still be enabled locally by passing --enable-features=WebViewCpuAffinityRestrictToLittleCores or enabling the feature in WebView DevTools. Test: Run WV shell with flag above & check chrome://histograms/Power. Bug: 1111789 Change-Id: I209b132ccd5354e41849a33bb0509773b619fc62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502511 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#821685}
-
Sergey Poromov authored
According to the latest UX mocks, when the running video screen capture is interrupted due to confidential content that appears in the captured area a corresponding notification should be shown to the user. See mocks: https://docs.google.com/presentation/d/1v0GM-lwHCznFJ6hnZlUH37eBOuAkJMw5Q6UnSkcKOgA/edit?hl=en#slide=id.ga41d6e7481_4_0 Bug: 1133324 Change-Id: Ibde37d0d5980b2ebe67f5b69cc2ab3f96e4fab99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502341 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#821684}
-
chrome://sync-internalsVictor Hugo Vianna Silva authored
For context please see crbug.com/1138535#c6. This CL brings back the code in SyncInternalsMessageHandler and about.js to fill the entity counts table in chrome://sync-internals. Some differences however: - StatusCounters is renamed to TypeEntitiesCount. - StatusCounters::ToValue() is inlined in SyncInternalsMessageHandler, since it's that layer which knows about the JS, and in particular that some hardcoded strings must agree with the JS code. - TypeEntitiesCount lives under model/, not under engine/cycle/, since it's not used by SyncEngine et al anymore. - SyncInternalsMessageHandler used to receive notifications for updates on these counts via a dedicated TypeDebugInfoObserver interface. Now, it actively queries SyncService::GetEntityCountsForDebugging() every time it gets notified via SyncServiceObserver::OnStateChanged(). Note that the SyncServiceObserver is only registered once the page loads [1], which means the counts aren't propagated before that, as it should be. - Notifications sent by SyncInternalsMessageHandler to the JS now include all data types at once. The notifications were coming for all data types in a for-loop before anyway [2]. - Value::Set*Path() APIs are used instead of the deprecated Set*(). Bringing back the code in ModelTypeProcessor to actually compute the counts is left for next CLs. [1] https://source.chromium.org/chromium/chromium/src/+/9b0dbaf8e5f258c1da4236e12edca53d7524344b:components/sync/driver/resources/about.js;l=206 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2474877/2/components/sync/driver/profile_sync_service.cc#1554 Bug: 1138535 Change-Id: Iae9f62cd5003b3e481d0e1814ff53c30a0002574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503728 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#821683}
-
Anders Hartvoll Ruud authored
Currently we assume that element-based offsets always have non-null targets ResolveOffset-time, since we enforce this during the creation of the (non-CSS) ScrollTimelines. However, for CSSScrollTimelines, we can't invalidate the rule this way, since we're referring to an element indirectly via an ID, not with a pointer to a specific element. Checking whether or not the target is null during ResolveOffset fixes this, and it's also what we're supposed to be doing per spec. This fixes a crash when using @scroll-timelines with element-based offsets that reference non-existent IDs. Also removed a nearby comment that's outdated (but not strictly related to the change in this CL). Bug: 1074052, 1102788 Change-Id: I4e138b55c3ef8cb122c58755a72a586e94c97e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498463 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
-
Eric Seckler authored
Switches the implementation of the --webview-force-little-cores switch from base::SetProcessCpuAffinityMode to content::EnforceProcessCpuAffinity. The latter periodically verifies that the affinity setting remains active, to detect when the system resets the affinity setting, and reapplies it if necessary. Test: Run system WV shell with the flag & check chrome://histograms Bug: 1111789 Change-Id: Icf4c360a36b8588086a0beb1caedd0e5869e3b59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502430Reviewed-by:
Laís Minchillo <laisminchillo@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#821681}
-
