- 18 Nov, 2020 40 commits
-
-
Andrew Grieve authored
It's required to retrieve results files, but was only being called as a side-effect of pushing *multiple* files to the device. A test that pushes only one file does not use "_PushChangedFilesZipped()" under-the-hood, and so would fail due to not having "adb root" called. Bug: 1145570, 1150237 Change-Id: I826db1db303144320ea75841da5902171b66c136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545651 Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#828960}
-
Nektarios Paisios authored
We don't need to use an object replacement character in IAccessible2, UI Automation and Linux ATK if the node whose text is replacing is not visible to those APIs, i.e. if the node lies outside the part of the accessibility tree that could be accessed by platform APIs. Object replacement characters are only meaningful when they appear in the accessible text for IAccessible2 and ATK, and only when they are used as a word or character boundary for UI Automation. Therefore, any object replacement character that cannot be accessed either via IAccessibleText, UIATextRangeProvider,, ATKText, etc. is unnecessary. We currently don't expose such characters in IA2 hypertext, for example. It can also make it impossible to compute the equivalent ancestor AXPosition on a text field for a text position that is pointing to an inline text box inside that field. This patch improves and generalizes the fix in https://chromium-review.googlesource.com/c/chromium/src/+/2473065 AX-Relnotes: n/a. R=dmazzoni@chromium.org, kschmidt@microsoft.com, vicfei@microsoft.com Bug: 1141171 Change-Id: Ia6699a841dfca59558ed1188de04a06e5b13e66c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504504Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Victor Fei <vicfei@microsoft.com> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#828959}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. The implementation of LacrosChromeServiceImpl depends on many version checks against AshChromeServiceVersion. New code can easily set the wrong version due to a rebase. Using gneerated MinVersion enums sidesteps this failure case. Change-Id: I350dc69f430e7dab81eceaeb118ecdd5687be7dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547789 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#828958}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=sky@chromium.org Bug: 1145565 Change-Id: I92bcf71a7f5296555933003d799fcb0fff7968e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548001 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#828957}
-
wutao authored
This is a update based on spec. Bug: b/173476221 Test: manual Change-Id: Id0450fb90084b9932cb534da475d1a7ab3f98d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546601Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#828956}
-
Anton Bikineev authored
Bug: 11297512 Change-Id: I7bf329df83e8ae0185578cc0bf1b68090a937b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547323Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#828955}
-
Charlie Hu authored
Feature Policy reporting origin trial ended in July 2019 (https://developers.chrome.com/origintrials/#/view_trial/2206763817411543041). Related tests should be removed, as the trial itself has expired. Bug: 1148804 Change-Id: I275cf2b0c9a35f7c535bcf5c5c7430576f6b30f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532670Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#828954}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ib7fc68197279ae8dc3f4317337e9afd7af80ad85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547885Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828953}
-
Jason Lin authored
...in which case, the new vmshell will have the CWD the same as the terminal with the id. Bug: 1113207 Change-Id: I9cc49c5fde3c58eeebb8707c4190040a15dd2ac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532340Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Auto-Submit: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#828952}
-
Michael Checo authored
- Add placeholder icon - Adjust sizing of percent_bar_chart/realtime_cpu chart - Will be updated to adhere to the spec in the future. - A follow-up CL will update the labels for the percent_bar_chart and the realtime_cpu chart Screenshot: http://shortn/_4EPGfnWJW6 Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Id05f75cd46a0b01887788f964c9e19a1843dc900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536472 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#828951}
-
Jeroen Dhollander authored
This crash could happen if the enrollment update comes after the Assistant has been stopped. Bug: 1147895 Change-Id: I56b1db6e859fc24c621c36fe984f31168365fcf5 Tests: Compiled Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533194Reviewed-by:
Yue Li <updowndota@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#828950}
-
Findit authored
This reverts commit 35f1e6ba. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 828763 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzM1ZjFlNmJhODk1ZDM2MDI5OGU0YTM5YTE4YzNhODZkZDA5ZGRiNDMM Sample Failed Build: https://ci.chromium.org/b/8863253709258648432 Sample Failed Step: compile Original change's description: > [third_party] Uprev grpc to v1.33.0+ > > Bug: b/132440534 > Test: CQ and manual size check. > Change-Id: Ie892c66dd5773e93ed154d3754add455e1f47041 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518775 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Sean Topping <seantopping@chromium.org> > Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org> > Commit-Queue: Andres Medina <medinaandres@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828763} Change-Id: I0b47e5727536cab1f5a25d02171b6e60e3978b74 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/132440534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548501 Cr-Commit-Position: refs/heads/master@{#828949}
-
Maksim Ivanov authored
Change tests in webview_login_browsertest.cc to explicitly specify which client certificates need to be put into the fake system slot. This is preparation for a follow-up CL that will add new tests that actually select different client certificates than the previously single "client_1" cert. Also change some of the existing tests to additionally load some unrelated certificates in cases where it's meaningful to test that no wrong cert is selected. Bug: 905994 Change-Id: I3227e9f3f42f900b9f0a587ae65a5da1676f8e10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426497 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#828948}
-
Samuel Huang authored
Now that size config JSON files have become the default way for android binary size bots to pass data to binary size scripts, deprecated arguments can be removed: * generate_commit_size_analysis.py: Remove {--apk-name, --mapping-file} (replaced by --size-config-json). * trybot_commit_size_checker.py: Remove --apk-name (replaced by --size-config-json-name). * Remove functions to guess .mapping file names (no longer needed). Bug: 1040645 Change-Id: I62aab4982edb523ea66a9c14ef5fc541260e922a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546445Reviewed-by:Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#828947}
-
Chris Hamilton authored
Currently this class maintains several maps and sets of objects, indexed by content::MediaPlayerId. Long lived WebContents that dynamically play media can accumulate an unlimited number of these objects, as the destruction of the objects is not tracked. This CL adds WebContentsObserver::MediaDestroyed(), and plumbing for this via MediaWebContentsObserver and WebContentsImpl. BUG=885394,1014165,1144736 Change-Id: If275ccb7fc6e4fd518e4a2bcc3a79f1b09b5fa5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545502Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#828946}
-
Xianzhu Wang authored
This reverts commit f139bbf8. Reason for revert: Fix crash in PaintFastBottomLayer() in box_painter_base.cc when painting a rounded custom scrollbar parts with background image. Original change's description: > Revert "Use only one way to check if we are printing or painting preview" > > This reverts commit c5bbd834. > > Reason for revert: Breaks custom scrollbar background painting (null > pointer when dereferencing a Node when getting the Document). > > Original change's description: > > Use only one way to check if we are printing or painting preview > > > > We had 3 ways to check printing status: > > - Document::Printing()/Document::IsPaintingPreview()/Document::IsCapturingLayout() > > - GraphicsContext::Printing()/GraphicsContext::IsPaintingPreview()/GraphicsContext::IsPrintingOrPrintingPreview() > > - PaintInfo::IsPrinting() > > > > Now keep the first way only to ensure consistency and reduce chance > > of errors. > > > > Also simplify PaintRecordBuilder constructor parameters to avoid > > multiple default parameters, and let callers set some GraphicsContext > > related configs directly instead of through PaintRecordBuilder > > constructor. > > > > Change-Id: I479b98b19700c5bed077ec9ef00bd148e3b33c63 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535627 > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Reviewed-by: Stefan Zager <szager@chromium.org> > > Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org> > > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#828385} > > TBR=szager@chromium.org,wangxianzhu@chromium.org,mstensho@chromium.org,ckitagawa@chromium.org > > Change-Id: I9854b70695cf588fbc8f704c60fd211c936bd132 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1150260 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547424 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828780} TBR=szager@chromium.org,wangxianzhu@chromium.org,mstensho@chromium.org,ckitagawa@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1150260 Change-Id: Ic3e3986d467054c9bf634eb40cd66d60bbc59147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547766Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#828945}
-
Christoph Schwering authored
Bug: 1142413, 1150277 Change-Id: I60d8161fa25ef2cdeb2312a9eaf6b8e8c04f3669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547980 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Auto-Submit: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#828944}
-
Ahmed Fakhry authored
This is a reland of https://crrev.com/c/2536030, which was reverted by mistake. The actual failure was caused by another CL (https://crrev.com/c/2537939) which was also reverted. No changes were made in this CL from the original. TBR=jamescook@chromium.org, dcheng@chromium.org Original CL description: This is a follow-up CL to handle requests made on the recording service CL (https://crrev.com/c/2404145): - The Record*() APIs of the service should provide the needed client, video capturer, and audio stream factory, instead of exposing APIs in the client so that anyone can bind to those capturers. - The service is launched to handle video recording, and terminated once recording ends, and all the chunks have been sent. - A GPU crash is handled by ending the recording. BUG=1126586, 1147989, 1143411 TEST=Manually, existing tests. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536030Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#828943}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Id374aceee6695867966d720a2b80703e0c1619ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547880Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828942}
-
Nina Satragno authored
Disable TopControlsSlideControllerTest.TestClosingATab. Flaky on chromeos (but only runs on chromeos). Tbr: afakhry@chromium.org Bug: 1110442 Change-Id: I916aed85364645227ae2b5f29e7e9a52470ae483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546979Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#828941}
-
Christopher Cameron authored
The code prior to this patch did not fail if GetImage returns nullptr. Bug: 1149954 Change-Id: If87d16ea2573cc8e5db1e419b743d37bc5062ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545035Reviewed-by:
Yi Xu <yiyix@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#828940}
-
Dave Tapuska authored
Collapse root layer implementation into a common implementation. One subtle difference is that the root layer on the child root frames is now set to null during destruction, I believe this is more correct. BUG=1097816 Change-Id: I5556680d0170280918a21027ff602c37b16d5598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542757 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#828939}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/19da6ff2e87e..484196b73916 2020-11-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: Icc0a185dc3cba7ffb664be535a72a7d3c7f49a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547101Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2e4ad365f6e4..5c2ea4d80c2b 2020-11-18 vidorteg@microsoft.com [Loc] Migrate layer_viewer to Loc V2 2020-11-18 aerotwist@chromium.org [unit test] Add inspector_overlay to coverage 2020-11-18 tvanderlippe@chromium.org Typecheck lighthouse_worker/LighthouseService.js with TypeScript 2020-11-18 aerotwist@chromium.org [unit test] Add placeholder test for missing entrypoints 2020-11-18 tvanderlippe@chromium.org Use TypeScript-authored files in node_main/ 2020-11-18 tvanderlippe@chromium.org Use TypeScript-authored files in wasmparser_worker/ 2020-11-18 tvanderlippe@chromium.org Use TypeScript-authored files in worker_main/ 2020-11-18 tvanderlippe@chromium.org Use TypeScript-authored files in workspace_diff/ 2020-11-18 tvanderlippe@chromium.org Use TypeScript-authored files in js_main/ 2020-11-18 tvanderlippe@chromium.org Use TypeScript-authored files in search/ 2020-11-18 tvanderlippe@chromium.org Typecheck input/InputTimeline.js with TypeScript 2020-11-18 tvanderlippe@chromium.org Use TypeScript-authored files in quick_open/ 2020-11-18 jacktfranklin@chromium.org [DataGrid]: disable pointer events on filler row 2020-11-18 jacktfranklin@chromium.org Remove UIComponents import eslint exception. 2020-11-18 alcastano@google.com Protocol update for Breakpoints on Trusted Type violation 2020-11-18 aerotwist@chromium.org [perf] Restore boot perf test 2020-11-18 tvanderlippe@chromium.org Use TypeScript-authored files in inspector_main/ 2020-11-18 bmeurer@chromium.org [bindings] Fix leaked UISourceCode's with Breakpoints. 2020-11-18 jacktfranklin@chromium.org Remove LitHtml and Marked exemption from ESLint modules rule. 2020-11-18 alexrudenko@chromium.org Implement persistent overlay for flexbox 2020-11-18 pfaffe@chromium.org Revert "Aria-label the scope entries" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1136655,chromium:1142804,chromium:1145997,chromium:1147888,chromium:1148296,chromium:1150259 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifb9117661d309a01044850282a5399f366a1a8d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547882Reviewed-by:
-
Ben Mason authored
Chrome will run in 64-bit, but WebView will run in 32-bit mode by default. Change-Id: Idc240b62a5c18c9109c02853459c073e4c53d851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536784 Commit-Queue: Ben Mason <benmason@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#828936}
-
Mason Freed authored
The [1] CL moved >210 tests to SlowTests and removed them from flaky status in TestExpectations. There were several fall-outs from this move: tests that are still flaky, even when given much more time. This CL groups them together in TestExpectations, and removes them from SlowTests. TBR=schenney@chromium.org TBR=wangxianzhu@chromium.org Editing the end of TestExpectations is hard: notry=true [1] https://chromium-review.googlesource.com/c/chromium/src/+/2538144 Bug: 1095379 Change-Id: I3ea0d4d115b08dffb9a3465f6c3dd7b993cd14d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547469 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#828935}
-
David Benjamin authored
Saves a tiny bit of code. Change-Id: I694306ac83c425a2d42c7381f9bc024c417591b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547760Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#828934}
-
Darren Shen authored
AutocorrectManager was hard to test because it required a full InputMethodEngine as a dependency. However, it really only needs two dependencies: an input context handler to manipulate text, and a suggestion handler to manipulate the autocorrect range. Pass in the suggestion handler via the ctor, and grab the input context handler via IMEBridge*. Add a few unit tests with mock handlers. In a future patch, we will add a proper fake input context handler so that it's easy to test UndoAutocorrect. * Note that there's an open bug to remove IMEBridge as it is global state. See crbug.com/1149751. Bug: b/172969200 Change-Id: Ic9deefb873ee94895846bd91efe608ef10418eb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543537 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#828933}
-
Koji Ishii authored
NOTRY=True TBR=yosin@chromium.org Change-Id: If8f1a4632b151e26372a54351ba3d232b0d3bdad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547745Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#828932}
-
Dale Curtis authored
These appear to be commonly generated from the canvas capture path when '{alpha: false}' is not specified. They may also be generated from alpha vp8/vp9 decoding R=sandersd Fixed: 1148800 Change-Id: I5da2aed405b6ed7c0708dae1aee2bb397731c26e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542936Reviewed-by:Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#828931}
-
Yicheng Li authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/50b570a8b17f..dfd19c1b9bbc $ git log 50b570a8b..dfd19c1b9 --date=short --no-merges --format='%ad %ae %s' 2020-11-12 acostinas system_api: Add method for NTLM token creation 2020-11-17 yichengli system_api: Add user_display_name to WebAuthn MakeCredential parameters Created with: roll-dep src/third_party/cros_system_api Change-Id: I6520c1af0ee3fcdaf8672b8fd6d5654183160802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547431Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Yicheng Li <yichengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#828930}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b61a10d6bd1f..1ba982f47a9f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC dmazzoni@google.com,nsatragno@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1131051,chromium:912681 Tbr: dmazzoni@google.com,nsatragno@google.com Change-Id: I39d0af9c31dfc00f2d27d133893f3ffecf239969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547787Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828929}
-
Vladimir Levin authored
This patch ensures that we propagate the positioned movement layout dirty bit since it affects "self layout" in the sense that it is the object itself that could be positioned differently, not necessarily its child. The early out right now protects us from propagating child only dirty bits, since those updates would be blocked anyway. R=ikilpatrick@chromium.org, chrishtr@chromium.org Change-Id: I1ed4850317ff0248fc74a9ad09fedba2d5fa2041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542305Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#828928}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/43fcd32b4fae..259ce70939a8 2020-11-18 capn@google.com Only lower MSan codegen optimization for LLVM JIT If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ie470dee7969c91c364585198195586847a8e6162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547109Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/de5334a0..6e7e3279 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I55367e7d4f94cd5d2ffcbe3bb6ddfcc2fd5ee1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547428Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828926}
-
Dominic Mazzoni authored
Bug: 981423 Change-Id: I4755f16d954eae2aa1566e166007fea4a4260a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533818 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Chris Hall <chrishall@chromium.org> Reviewed-by:
Meredith Lane <meredithl@chromium.org> Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#828925}
-
Alex Newcomer authored
It should exist, and we assume that it exists. I'm not sure how it would not exist, but return in this case to avoid a crash. Bug: 1138665 Change-Id: I7a667f4e3744f7f5bb580139962b92860f763d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546853Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#828924}
-
Kartik Hegde authored
To facillate testing in classes that use the UdpProber, create an abstract UdpProber. Tests can derive from this abstract UdpProber class. BUG=b/172994051 TEST=unit_tests --gtest_filter=UdpProberWithFakeNetworkContextTest.* Change-Id: Ibdfba9690e996e211f1db85888f66fe15f24c75e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545047 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#828923}
-
Brian Geffon authored
When we added support for versioned message we accidentally introduced a behavior where messages can be shorter than expected. This is what the behavior should be to allow older messages to be received. However, we know the minimum size is the oldest message version. We should never be allowed to go smaller than that. This second attempt will explicitly shutdown the channel in the test to avoid a UAF on Mac. BUG=chromium:1149805 Change-Id: I0a1daaf69db7ca74963803f8a92c31bfea3aa0df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547479 Auto-Submit: Brian Geffon <bgeffon@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#828922}
-
Anthony Vallee-Dubois authored
Bug: 1150509 Change-Id: If67fb599658b610c25498ebd8967dc4997314033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546996Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#828921}
-
