GitLab

Revert of DevTools: use explicit IPC messages for enabling/disabling tracing instead of intercepting protocol… (patchset #3 of https://codereview.chromium.org/511873002/)

Reason for revert:
Creates timeout failures on a lot of inspector/ tests in Blink:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28deps%29/builds/33453/steps/webkit_tests/logs/stdio

Original issue's description:
> DevTools: use explicit IPC messages for enabling/disabling tracing instead of intercepting protocol events
>
> Added IPC plumbing that allows InspectorTracingAgent to enable/disable  browser-wide tracing. It was implemented by intercepting Tracing.started/Tracing.stopped events in the browser. Tracing.stopped event in the DevTools protocol was used by the renderer to notify the browser that it should stop trace event recording and it didn't make much sense for the client as there is already Tracing.tracingComplete event in the protocol.
>
> BUG=398787
>
> Committed: https://chromium.googlesource.com/chromium/src/+/a449adae35631e4791547bd0b14403d1766f9ddf

TBR=dcheng@chromium.org,caseq@chromium.org,loislo@chromium.org,vsevik@chromium.org,yurys@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=398787

Review URL: https://codereview.chromium.org/516963003

Cr-Commit-Position: refs/heads/master@{#292390}

Changing WebMediaPlayerImpl and related media code to use task runners
instead of MessageLoopProxy to avoid presubmit errors when moving this
code to media/blink. There is no functional change here. Just making the
tools happy. :)

BUG=408338

Review URL: https://codereview.chromium.org/508293003

Cr-Commit-Position: refs/heads/master@{#292389}

brings in https://codereview.chromium.org/515263002

TBR=rnk@chromium.org

Review URL: https://codereview.chromium.org/513973004

Cr-Commit-Position: refs/heads/master@{#292388}

BUG=404355
R=yurys, pfeldman-OOO, horo

Review URL: https://codereview.chromium.org/479673004

Cr-Commit-Position: refs/heads/master@{#292387}

Consolidate the code to set accessibility focus to one place.
Fix it so we never set accessibility focus to the same id twice in a row,
as that puts things in a weird state (because we then get a "clear"
accessibility focus action on the current focused view).

In a couple of places where we want to explicitly update the focus,
set focus away and then back again so Android can't ignore it.

BUG=407871

Review URL: https://codereview.chromium.org/513483002

Cr-Commit-Position: refs/heads/master@{#292386}

BUG=407718

Review URL: https://codereview.chromium.org/510583002

Cr-Commit-Position: refs/heads/master@{#292385}

When tab focus is placed on the security warning primary button, Chrome
should outline the button. However, the outline is not shown during
button activation to prevent it from making the button border an odd
white-gray-blue.

BUG=387163
R=bauerb@chromium.org

Review URL: https://codereview.chromium.org/511073002

Cr-Commit-Position: refs/heads/master@{#292384}

This pulls in the following Native Client changes:

r13667: (yyanagisawa) Re-enable use of Goma on Windows, except when using the PNaCl toolchain
r13668: (noelallen) Force rebuild on cmd change.

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build
TBR=bradnelson@chromium.org

Review URL: https://codereview.chromium.org/513933003

Cr-Commit-Position: refs/heads/master@{#292383}

. Make HistoryService::Cleanup() private. Making this public can leave
  HistoryService in a bad state.
. HistoryServiceFactory would leak a HistoryService if
  HistoryService::Init() failed.

BUG=none
TEST=none
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/510033004

Cr-Commit-Position: refs/heads/master@{#292382}

BUG=394287

Review URL: https://codereview.chromium.org/512683003

Cr-Commit-Position: refs/heads/master@{#292381}

BUG=408525

Review URL: https://codereview.chromium.org/513173002

Cr-Commit-Position: refs/heads/master@{#292380}

DevTools: use explicit IPC messages for enabling/disabling tracing instead of intercepting protocol events

Added IPC plumbing that allows InspectorTracingAgent to enable/disable  browser-wide tracing. It was implemented by intercepting Tracing.started/Tracing.stopped events in the browser. Tracing.stopped event in the DevTools protocol was used by the renderer to notify the browser that it should stop trace event recording and it didn't make much sense for the client as there is already Tracing.tracingComplete event in the protocol.

BUG=398787

Review URL: https://codereview.chromium.org/511873002

Cr-Commit-Position: refs/heads/master@{#292379}

Move ExtensionWarningService and ExtensionsWarningSet, which are used by webrequest api, to extensions.

This cl resolve the dependencies of ExtensionsWarningSet of chrome strings:
- move the declarations of IDS_EXTENSION_WARNINGS_XXX to extensions_strings.grd;
- replace the usage of "IDS_PRODUCT_NAME" by creating GetProductName() function in ExtensionsClient and its subclasses.

BUG=352293

Review URL: https://codereview.chromium.org/503033002

Cr-Commit-Position: refs/heads/master@{#292378}

BUG=None

Review URL: https://codereview.chromium.org/512223002

Cr-Commit-Position: refs/heads/master@{#292377}

It was moved in https://crrev.com/55b8563

Found by git grep 'components.*breakpad'

BUG=406410
R=rsesek@chromium.org
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/511223002

Cr-Commit-Position: refs/heads/master@{#292376}

BUG=408285
R=glider@chromium.org

Review URL: https://codereview.chromium.org/510913004

Cr-Commit-Position: refs/heads/master@{#292375}

BUG=none

Review URL: https://codereview.chromium.org/501153006

Cr-Commit-Position: refs/heads/master@{#292374}

This removes an ash dependency from the system.display API in order to move it to extensions/. As a side effect, we got rid of #ifdefs on system_info_api.cc

BUG=392842

Review URL: https://codereview.chromium.org/507783003

Cr-Commit-Position: refs/heads/master@{#292373}

Instead add a run_mojo_python_bindings_tests.py that will be run from
the bots. This also refactor run_mojo_python_tests.py to factorize the
common code.

BUG=407818

Review URL: https://codereview.chromium.org/509863002

Cr-Commit-Position: refs/heads/master@{#292372}

BUG=405951
TBR=lally@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/515193002

Cr-Commit-Position: refs/heads/master@{#292371}

These functions where invaluable when trying to debug and fix the
cc::OrderedTestRunner as they let me easily inspect the tasks without having to
fire up GDB. They should also be useful in development / testing of other task
runners.

Added a very simple test for ShouldRunBefore which shows this stuff working. If
that test fails, the output looks like the following;
-------------------------------------------------------------------------------
../../base/test/test_pending_task_unittest.cc:49: Failure
Value of: task_after.ShouldRunBefore(task_first)
  Actual: false
Expected: true
TestPendingTask(
  {"delay":2000,"nestability":"NESTABLE","post_time":0,
   "posting_function":"Unknown@Unknown:-1","run_at":2000}
).ShouldRunBefore(TestPendingTask(
  {"delay":1000,"nestability":"NESTABLE","post_time":0,
   "posting_function":"Unknown@Unknown:-1","run_at":1000})
)
-------------------------------------------------------------------------------

BUG=380889

Review URL: https://codereview.chromium.org/491743002

Cr-Commit-Position: refs/heads/master@{#292370}

flight.

Merge internal change: 74165077

Renabled flaky LargePostZeroRTTFailure to see if this CL fixes issue
407756 on chromeos valgrind.

R=rch@chromium.org, rjshade@chromium.org
BUG=407756

Review URL: https://codereview.chromium.org/511003002

Cr-Commit-Position: refs/heads/master@{#292369}

BUG=408179
NOTRY=true

Review URL: https://codereview.chromium.org/509333002

Cr-Commit-Position: refs/heads/master@{#292368}

Revert of Modify test case to support streaming operation in sandbox file system. (patchset #6 of https://codereview.chromium.org/491813002/)

Reason for revert:
This is breaking fast/filesystem/op-copy.html in Blink:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=fast/filesystem/op-copy.html

Original issue's description:
> Modify test case to support streaming operation in sandbox file system.
>
> BUG=360088
> TEST=content_unittests passed
>
> Committed: https://chromium.googlesource.com/chromium/src/+/2332db94ec6c42aaa3d66f5226a4c17b85c1553e

TBR=tzik@chromium.org,iseki@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=360088

Review URL: https://codereview.chromium.org/510323003

Cr-Commit-Position: refs/heads/master@{#292367}

This pulls in the following changes:

* dbus: Add method for cryptohomed GetKeyDataEx
* Remove deprecated shill::kPaymentURLProperty
* Add a constant for the 'org.freedesktop.DBus' interface.
* dbus/service_constants.h: Remove
      "Cellular.ActivateOverNonCellularNetwork"
* Add portal detection failed phase and status to service property

BUG=367847
TEST=Everything still compiles

Review URL: https://codereview.chromium.org/507973003

Cr-Commit-Position: refs/heads/master@{#292366}

https://skia.googlesource.com/skia/+log/6b0d6b43cf662735dc804d8142383452c7f246f9..b2f7fce9e034c3b6749e75a129e7836df3529706

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/512183002

Cr-Commit-Position: refs/heads/master@{#292365}

This fixes a FindBugs warning.

NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/517453003

Cr-Commit-Position: refs/heads/master@{#292364}

BUG=110610
TBR=kaznacheev@chromium.org

Review URL: https://codereview.chromium.org/513673004

Cr-Commit-Position: refs/heads/master@{#292363}

TBR=vogelheim@chromium.org

Review URL: https://codereview.chromium.org/510303003

Cr-Commit-Position: refs/heads/master@{#292362}

We have observed on some Mac that video frames are delivered back to back from the build in video capture device. This can potentially happen on all platforms. If that happen, the simple filter used for frame rate calculation get scewed. This cl fix that by dropping all frames received within 5ms of the previous frame.

BUG=394315

Review URL: https://codereview.chromium.org/516783002

Cr-Commit-Position: refs/heads/master@{#292361}

This patch introduces OpenPDFParamsParser class which is responsible
to parse open pdf parameters and set them in a dictionary. This
dictionary will be used to set initial viewport settings when opening
pdf document.

BUG=303491

Review URL: https://codereview.chromium.org/477933003

Cr-Commit-Position: refs/heads/master@{#292360}

BUG=405504

Review URL: https://codereview.chromium.org/501473002

Cr-Commit-Position: refs/heads/master@{#292359}

BUG=360088
TEST=content_unittests passed

Review URL: https://codereview.chromium.org/491813002

Cr-Commit-Position: refs/heads/master@{#292358}

Add __init__.py file to the password manager python tests to
make it a module so that it could be imported from python
files in the parent folder.
BUG= 408198

Review URL: https://codereview.chromium.org/511943002

Cr-Commit-Position: refs/heads/master@{#292357}

Reason for revert:
It broke some antialiasing tests on Win7, see:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/19724/steps/webkit_tests/logs/stdio

The output has some odd comma added after each character. It doesn't seem to be a rebase problem.

Original issue's description:
> Skia roll 6b0d6b4:b2f7fce
>
> https://skia.googlesource.com/skia/+log/6b0d6b43cf662735dc804d8142383452c7f246f9..b2f7fce9e034c3b6749e75a129e7836df3529706
>
> CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
> TBR=djsollen@google.com
>
> Committed: https://chromium.googlesource.com/chromium/src/+/98c591a509f0c760d514fe079cf507ef1f7e76a4

TBR=djsollen@google.com,skia-deps-roller@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/515753004

Cr-Commit-Position: refs/heads/master@{#292356}

BUG=chromium:353050
TEST=unit_tests

Review URL: https://codereview.chromium.org/468873002

Cr-Commit-Position: refs/heads/master@{#292355}

The only use of Profile in that file is to get net::URLRequestContextGetter. This CL pulls that out, so that instead of getting a Profile, and asking for URLRequestContextGetter, the affected class gets URLRequestContextGetter directly.

This reduces a //chrome dependency to a //net one, and is part of preparations for content settings componentisation.

BUG=384873

Review URL: https://codereview.chromium.org/508223002

Cr-Commit-Position: refs/heads/master@{#292354}

BUG=none

Review URL: https://codereview.chromium.org/493293002

Cr-Commit-Position: refs/heads/master@{#292353}

BUG=403846
TEST=manually tested

Review URL: https://codereview.chromium.org/514103002

Cr-Commit-Position: refs/heads/master@{#292352}

* Make MalwareIframeReportDetails work with V3 and reenable it
* Make ReportingDisabled work with V3 and reenable it
* Remove TODO from PhishingProceed, since it's been enabled for a while
* Remove TODO from PhishingLearnMore, since it's been enabled for a while
* Remove logging statements scattered around

BUG=273302,247763
R=mattm@chromium.org

Review URL: https://codereview.chromium.org/512073002

Cr-Commit-Position: refs/heads/master@{#292351}