- 14 Apr, 2020 40 commits
-
-
Thomas Lukaszewicz authored
Bug: None Change-Id: Iaf002daa7d743e9bf7bf725a86566f984c2ae0ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148533 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#758902}
-
Kyle Horimoto authored
Screenshot: https://screenshot.googleplex.com/8hf9ZVFEaNc.png Bug: 1067212 Change-Id: I2f16184b5b72aa68f57597161ecca40eac3a6bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145964Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#758901}
-
David Bertoni authored
The EventsApiTest.NewlyIntroducedListener test isn't flaky on Windows, although it still flakes on other platforms. Bug: 833854 Change-Id: Ib524f61b79d6ae83c1e7e39c63c0522429a3f118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139450Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#758900}
-
Owen Min authored
Add two tests to verify the claim in the WallClockTimer documentation. 1) Restart a running timer will replace the current task and reset the desired run time. 2) Stop a non-running timer is a no-op. Bug: 1062410 Change-Id: Id5f9b7cc7d55db66cccf085d8260965633a23a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144414 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#758899}
-
Ken Rockot authored
Bug: 1059389 Change-Id: I90a58a2cad2cc7da9a5512b327f3b4d16567154f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112894 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#758898}
-
Ian Prest authored
This change caches the strokes (converting them to separate paths) used for hit-testing in SVG, so they don't need to be recomputed on every hit-test / mouse-move. This change is motivated by a subsequent change that will increase hit-testing precision while significantly worsening performance. By caching the stroke path, the aggregate result of the two changes is expected to perform better than the current status quo. Bug: 964614 Change-Id: I48de70a22c2f8137604f214a699bae258ff741d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140819Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#758897}
-
Alex Turner authored
Reenables the previously flaky test AdTaggingBrowserTest. ChildrenOfFrameWithWindowStopAbortedLoad_StillCorrectlyTagged, with the following changes. The scripts added by createFrameWithWindowStopAbortedLoad now have async set to false to ensure that they are loaded in insertion order. This allows the last script's onload handler to correctly signal that all three scripts have loaded. This change was made for create*Ad*FrameWithWindowStopAbortedLoad (crrev.com/c/2144832), but this function also needs to be changed to avoid flakiness. Bug: 1069346 Change-Id: I32733290cb41a03351b969b62e8118c5be1401e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148544Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#758896}
-
Chris Hamilton authored
This will be used in upcoming page load prioritization logic. BUG=1064763 Change-Id: I6290b4e500edc39759411f9a00f6f4255e1e0acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144312Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#758895}
-
Haiyang Pan authored
Bug: 922145 Change-Id: Ica6b8f94bf47b7c10dadad6e6ecdddf31b14166c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146060Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#758894}
-
Stephen Chenney authored
It is possible for the renderer to navigate and reset the have_emitted_uma_ flag while the compositor thread is processing input and checks the flag. Make it atomic to avoid this problem. Bug: 1068119 Change-Id: If6d633f18a6bb645a479cc27317ab6bb99fed708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144776Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#758893}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/871d40b74c63..eb1d5a2e233c git log 871d40b74c63..eb1d5a2e233c --date=short --first-parent --format='%ad %ae %s' 2020-04-14 reed@google.com Move markerstack into its own object: 2020-04-14 brianosman@google.com Fail gracefully in SkSLSlide on raster backend Created with: gclient setdep -r src/third_party/skia@eb1d5a2e233c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: Id9e0f6b00895e07fde879669bafe1a1804f28824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149262Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758892}
-
Daniel Hosseinian authored
Test two simple cases, COLOR and GRAY, and add death tests for corner cases. Bug: 1069537 Change-Id: I892da4f1daa384d795fb94a5810a698dfc9544b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148093Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#758891}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e9d37e79b47f..9aba22264b1b git log e9d37e79b47f..9aba22264b1b --date=short --first-parent --format='%ad %ae %s' 2020-04-14 saklein@chromium.org message_util: Default to an empty JSON dict. 2020-04-14 hidehiko@chromium.org chromite: Add --build-label to chrome-sdk command. 2020-04-14 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-14 sanikak@chromium.org auto_updater_transfer: add stdout argument to cros_build_lib.run call 2020-04-13 navil@google.com chromite: update generated protos for build api. 2020-04-13 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-13 mmortensen@google.com build_query_logs: Support -ns (not match) argument. Created with: gclient setdep -r src/third_party/chromite@9aba22264b1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I5c6ecae07eb64405b3425a684827a0d76cd4ae2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149260Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758890}
-
Tobias Sargeant authored
Bug: 1068864 Change-Id: I8e25de6cfa9cbe99a7aa7326650ecb871a7539a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146550Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#758889}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/39fb817efdce..3e2809f4f0cd git log 39fb817efdce..3e2809f4f0cd --date=short --first-parent --format='%ad %ae %s' 2020-04-14 danilchap@webrtc.org Drop support for receiving generic frame descriptor v1 2020-04-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 41d2eaa4..304e175c (758687:758795) 2020-04-14 mbonadei@webrtc.org Remove WebRTC-Rfc5389StunRetransmissions. 2020-04-14 mbonadei@webrtc.org Remove deprecated SSLAdapter::SetIdentity. 2020-04-14 mbonadei@webrtc.org Remove deprecated RtpPacketInfo::RtpPacketInfo. 2020-04-14 mbonadei@webrtc.org Remove WebRTC-Audio-NewOpusPacketLossRateOptimization. Created with: gclient setdep -r src/third_party/webrtc@3e2809f4f0cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I516931c489101d7354152ad6fc670210e07104e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149264Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758888}
-
Matthias Körber authored
Change-Id: Id0ce647400bdce2eb4cdd358432b7c647f880570 Bug: 1062861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122057Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#758887}
-
Paul Wankadia authored
This is part of an effort to rewrite calls to utf8() and set_utf8() (in RE2::Options) as calls to encoding() and set_encoding(), respectively. utf8() and set_utf8() have been marked as the "legacy" interface since 2008, so it is long past time that we get rid of them. R=parastoog@google.com Change-Id: I62c48cd575a55b519d5264ed857f927c163068b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145261Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Paul Wankadia <junyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#758886}
-
Chris Mumford authored
These tests required some refactoring to sqlite_cherry_picker.py to support testing. Bug: 945204 Change-Id: I66eb10ca94a736a58ca75475d2fee3ba65f62dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131249 Commit-Queue: Chris Mumford <cmumford@google.com> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#758885}
-
Ionel Popescu authored
Prior to FormControlsRefresh, expanding the select popup for up/down arrows was controlled via LayoutThemeMac::PopsMenuByArrowKeys. Since for FormControlsRefresh, LayoutThemeMacRefresh that inherits from LayoutThemeDefault is used instead, the PopsMenuByArrowKeys is also added there as we want to keep the same behavior for up/down arrows. Bug: 1064455 Change-Id: I3e6006d84549ff1421e9f3aeae381241dc81468d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148156Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Dan Clark <daniec@microsoft.com> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#758884}
-
Mohamed Amir Yosef authored
This is to allow the calling site to introduce custom post migration logic after each migration step. Bug: 1032992 Change-Id: Id03ee9ee0a5a1a679f19ea7f7fbe572a6977f77a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139726 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#758883}
-
Alexandre Courbot authored
OnPipelineFlushed() implied that this method would be called for all pipeline flushed, while it is actually called only during resolution changes, to apply the new resolution. Use a less confusing name. BUG=978737 TEST=VDAtest --use_vd passes on Kukui. Change-Id: I6bf93fd67bdb1316993a6df1d64284b527ba1be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143423 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#758882}
-
Christian Dullweber authored
The preference only needs to know which radio button is selected to determine its state. Removing the variables avoids inconsistencies. The values used for initialization are moved into a class to avoid a large number of boolean parameters. Change-Id: I1cde64d6c14c396b2997aafdcbaf26a49453b25d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139727 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#758881}
-
Adam Langley authored
By moving the authenticator code to a dynamic module we eliminate code-size concerns in the base module for a feature that is flag protected and, for a while at the very least, will be used by a tiny fraction of users. BUG=1002262 Change-Id: I9418d7873091741e189629755033842023166ed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145759Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#758880}
-
Hazem Ashmawy authored
Document WebView DevTools Crashes UI. Bug: 1058571 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: I1e8948fb94585402c156503cef06b92732587626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142215 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#758879}
-
Sahir Vellani authored
Currently, if physics based fling curve is enabled, even if the fling is boosted, the scroll distance is capped by upper bound which is three times the size of viewport. Thus it nullify the effect of fling boosting and travels the same distance as it would if fling is not boosted. This CL fixes fling boosting with physics based fling curve. It does so by increasing the upper bound every time a fling is boosted. Bug: 647137 Change-Id: Ib2dd51b37df91168ae1f1e8d33888e3b5dc43e23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118218Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Cr-Commit-Position: refs/heads/master@{#758878}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I1a9188613b21296335597bdadaf6efdc4427a6f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149266Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758877}
-
Greg Thompson authored
BUG=933975,1069116 R=etiennep@chromium.org Change-Id: I294eba49176369fe06f541e681b7fee84aba48bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146548 Commit-Queue: Greg Thompson <grt@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#758876}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/575e040c7661..decaee5ce9bf git log 575e040c7661..decaee5ce9bf --date=short --first-parent --format='%ad %ae %s' 2020-04-14 changhaohan@chromium.org TextPrompt: skips ")" entry if there is a unmatched "(" Created with: gclient setdep -r src/third_party/devtools-frontend/src@decaee5ce9bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1065728 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6f824cd9507dc2ecacac6e0cac436ce981961c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149257Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758875}
-
Koji Ishii authored
|NGBoxFragmentPainter| skips painitng if the ink overflow is outside of culled rect, but doesn't apply the optimization to <br> because its ink overflow is empty but selection needs to be painted. This patch restricts it only when the <br> is selected. Note, currently there are 3 code paths that paint <br>: 1. Legacy 2. LayoutNG (NGPaintFragment) 3. LayoutNG (NGFragmentItem, not enabled yet, crbug.com/982194) This patch changes 2 and 3. Bug: 982194 Change-Id: I87a0b21b5dae3e9d04daa71a3366f4b37cdb7268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147439Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#758874}
-
Clark DuVall authored
These are now being build on the official builders, so it probably makes sense to enable by default. Bug: 1033098 Change-Id: I04224c174ac3de526cadd26f05fe34fdd77d2ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145821 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#758873}
-
Constantin Manea authored
handling ephemeral profiles As described in https://crbug.com/1064758 the kProfilesLastActive pref list is not explicitly cleared when ephemeral profiles are handled. In some cases this can cause profiles to be created at browser start when they should not be. This change adds safeguards that mitigate against this issue. Bug: 1064758 Change-Id: Ib16f85b2c511a27a5fe618c10bfea1704b8e567f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122917 Commit-Queue: Constantin Manea <comanea@microsoft.com> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#758872}
-
David Bokan authored
Add a DumpWithoutCrash to KeyPress events where the timestamp of the OS differs from the current time by more than 5 seconds. We see in UMA that we often see events in the 95% percentile reaching many seconds of difference. Hopefully the crash stacks will reveal something about what's causing this. A previous iteration of this investigation in https://crrev.com/c/2111782 showed that we sometimes redispatch events that have been reinjected back from the renderer. This should never happen. This CL adds crash keys to dump some of the related app state to help explain how this happens. However, not all such stack traces showed reinjection so that can't be the cause of all these bad timestamps. This CL also adds some timing information to the existing crash key in NSApp:sendEvent which might reveal something. Bug: 1039833 Change-Id: I90a8bb210debc8e9f0fcfba23a566200de72e9c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144627Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#758871}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6ca7a1bee1ab..38cf748e7a5f git log 6ca7a1bee1ab..38cf748e7a5f --date=short --first-parent --format='%ad %ae %s' 2020-04-14 fmayer@google.com Merge "Use package name for deobfuscation." 2020-04-14 lalitm@google.com Merge "tp: move context to types" 2020-04-14 treehugger-gerrit@google.com Merge "Fix bazel build win: make Subprocess os-conditional via #if" Created with: gclient setdep -r src/third_party/perfetto@38cf748e7a5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iac9c0918f11b1833845b953c5d58ee569d50c865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148932Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758870}
-
Jonathan Metzman authored
Fuzzer is causing flakiness in CQ. It can be added back if build issues are fixed. Bug: 1028212 Change-Id: I45e764e20af1cbc59763cff32f4d379d67b47278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142589Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#758869}
-
Bo Liu authored
Add an error if marker file creation failed. Bug: 1065585 Change-Id: Iaa86c52b63111097b675f93bdad95ce706cde3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148840Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#758868}
-
Sadrul Chowdhury authored
If a reporter is replaced by a new reporter, but the frame had not produced a frame, then use the timestamp of the 'did not produce' notification as the termination-time to end the trace-event, rather than the time of the replacement. BUG=none Change-Id: I91ad6b9a1b0c31afe5309f89e7f8aaf43121e8eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146517 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#758867}
-
Caroline Rising authored
Bug: 1067783 Change-Id: I624d43ee3863272bb4d7bef347b157164e886d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145861Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#758866}
-
Peter Kasting authored
https://chromium-review.googlesource.com/c/chromium/src/+/2079258 deleted third_party/blink/common/origin_policy, but not the public API. Additionally, various OWNERS files were left pointing at a nonexistent file. AFAICT the new canonical home is services/network/origin_policy, so point to that. Bug: none Change-Id: I2f27b9a63083e92c708590955849122fef9ffe00 No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144106Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#758865}
-
Sadrul Habib Chowdhury authored
The member variables should be private, and can be accessed in tests via protected accessors. BUG=none TBR=behdadb@chromium.org Change-Id: I40e19a3d76323800df9b6c2aa45ad27efe1bc31a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149275Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#758864}
-
Trent Begin authored
Update cros_healthd telemetry handling code to check for and log errors from TimezoneInfo request. Bug: chromium:1041153 Change-Id: I2319094bd80b478c275ee4ceee35faa9e75263f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145925Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Trent Begin <tbegin@chromium.org> Cr-Commit-Position: refs/heads/master@{#758863}
-