GitLab

Revert of Set the Ash browser frame color for MD WebUI (Settings) (patchset #3 id:40001 of https://codereview.chromium.org/2676673003/ )

Reason for revert:
Broke this builder:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/83127

Original issue's description:
> Set the Ash browser frame color for MD WebUI (Settings)
>
> Currently Settings is the only Web IU we show in a dedicated browser
> window on Ash (Chrome OS).
>
> BUG=684129
>
> Review-Url: https://codereview.chromium.org/2676673003
> Cr-Commit-Position: refs/heads/master@{#448024}
> Committed: https://chromium.googlesource.com/chromium/src/+/31dc779f1ecd8dabd26dfed11bef773c95ae5b47

TBR=sky@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=684129

Review-Url: https://codereview.chromium.org/2672083002
Cr-Commit-Position: refs/heads/master@{#448029}

https://skia.googlesource.com/skia.git/+log/113628d76176..20f00784b850

$ git log 113628d76..20f00784b --date=short --no-merges --format='%ad %ae %s'
2017-02-02 mtklein Restore ios_flavor.
2017-02-03 bsalomon Make shadow tessellators fail gracefully and add unit test for this.
2017-02-03 senorblanco GrTessellator (AA): Fix for missing fill artifacts.
2017-02-03 jvanverth Initialize some more variables in SpotShadowTessellator
2017-02-02 reed experimental tight-bounds

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=halcanary@google.com

Review-Url: https://codereview.chromium.org/2674573009
Cr-Commit-Position: refs/heads/master@{#448028}

BUG=688004

Review-Url: https://codereview.chromium.org/2669263002
Cr-Commit-Position: refs/heads/master@{#448027}

BUG=

Review-Url: https://codereview.chromium.org/2651623005
Cr-Commit-Position: refs/heads/master@{#448026}

https://boringssl.googlesource.com/boringssl/+log/772a5bed7d5065b301c3979c325248689d36b92c..5fa2cdf1ed4069be359038107e144cd7c7506dca

This picks up the CPU flag fix.

BUG=688384

Review-Url: https://codereview.chromium.org/2672603005
Cr-Commit-Position: refs/heads/master@{#448025}

Currently Settings is the only Web IU we show in a dedicated browser
window on Ash (Chrome OS).

BUG=684129

Review-Url: https://codereview.chromium.org/2676673003
Cr-Commit-Position: refs/heads/master@{#448024}

base::Time and base::TimeTicks interfaces expose a is_null() method. Unfortunately
in current implementation is_null() == is_zero() which means that it is possible
to write code that produces valid zero time but is confused with null time.
So depending on this API can lead to brittle and buggy code. There is also a desire
to eventually get rid of |is_null()| in base/ interface.

Given above we shouldn't depend on this behavior in Blink. Any code that needs to have
a "null" or "invalid" time value can use WTF::Optional<WTF::Time> instead which
is more readable and explicit.

BUG=625680

Review-Url: https://codereview.chromium.org/2656843003
Cr-Commit-Position: refs/heads/master@{#448023}

Previously the GCMKeyStore tests used net/ EXPECT_DFATAL(), which avoids forking but is designed to expect LOG(DFATAL) in net/ code, rather than DCHECKs.

The InkDropImplTest used ASSERT_DEATH_IF_SUPPORTED but ran conditional on DCHECK_IS_ON(), whereas EXPECT_DCHECK_DEATH() is implicitly executed only if DCHECK_IS_ON().

BUG=596231

Review-Url: https://codereview.chromium.org/2642173002
Cr-Commit-Position: refs/heads/master@{#448022}

Revert of binding: Makes xss-DENIED-window-name-navigator deterministic. (patchset #2 id:20001 of https://codereview.chromium.org/2673583003/ )

Reason for revert:
Builds on https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29 have been consistently failing since this CL was landed.  Reverting for that reason.

Original issue's description:
> binding: Makes xss-DENIED-window-name-navigator deterministic.
>
> Makes the test result of xss-DENIED-window-name-navigator.html
> deterministic and fixes the flakiness.
>
> BUG=686470
>
> Review-Url: https://codereview.chromium.org/2673583003
> Cr-Commit-Position: refs/heads/master@{#447958}
> Committed: https://chromium.googlesource.com/chromium/src/+/114e65b6ddfd281fadd15c8ee43894b40b984b91

TBR=haraken@chromium.org,yukishiino@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=686470

Review-Url: https://codereview.chromium.org/2673833004
Cr-Commit-Position: refs/heads/master@{#448021}

TBR=wangxianzhu@chromium.org

Review-Url: https://codereview.chromium.org/2674963002 .
Cr-Commit-Position: refs/heads/master@{#448020}

BUG=687976

Review-Url: https://codereview.chromium.org/2678463002
Cr-Commit-Position: refs/heads/master@{#448019}

If we cannot instantiate a shader (due to e.g. a non-invertible local
matrix), the expectation is to not draw anything.  We're currently
filling with black.

This unblocks https://skia-review.googlesource.com/c/7885/, which
prevents creation of shaders with non-invertible matrices.

R=reed@google.com

Review-Url: https://codereview.chromium.org/2677633004
Cr-Commit-Position: refs/heads/master@{#448018}

- Have native pass app button presses up to the UI.
- The UI decides whether or not to be in menu mode.
- The UI may call back down to native to pause content, if desired.

BUG=644565
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2664973002
Cr-Commit-Position: refs/heads/master@{#448017}

This allows listing the QR Code scanner entry directly in the .plist listing the
force touch actions, as opposed to adding it at runtime,

BUG=675625

Review-Url: https://codereview.chromium.org/2676803002
Cr-Commit-Position: refs/heads/master@{#448016}

BUG=629123

patch from issue 2244283002 at patchset 1 (http://crrev.com/2244283002#ps1)

Review-Url: https://codereview.chromium.org/2675753004
Cr-Commit-Position: refs/heads/master@{#448015}

Fix for an issue where the tabstrip animates out when you're still
cycling between tabs.

BUG=591776

Review-Url: https://codereview.chromium.org/2672913002
Cr-Commit-Position: refs/heads/master@{#448014}

BUG=686803

TBR=reillyg@

Review-Url: https://codereview.chromium.org/2675963003
Cr-Commit-Position: refs/heads/master@{#448013}

Fake identity service is not a mock, and it shouldn't use mocks when possible.
Those mocked methods were never overriden anyway.

BUG=None

Review-Url: https://codereview.chromium.org/2670843003
Cr-Commit-Position: refs/heads/master@{#448012}

Revert of Use trace-pc-guard for libFuzzer. (patchset #1 id:1 of https://codereview.chromium.org/2672853002/ )

Reason for revert:
Still borked on bots.

Original issue's description:
> Reland of Use trace-pc-guard for libFuzzer. (patchset #1 id:1 of https://codereview.chromium.org/2668093004/ )
>
> Reason for revert:
> Got upgraded builders.
>
> Original issue's description:
> > Revert of Use trace-pc-guard for libFuzzer. (patchset #1 id:1 of https://codereview.chromium.org/2665243002/ )
> >
> > Reason for revert:
> > causing build failures: https://crbug.com/687570
> >
> > Original issue's description:
> > > Use trace-pc-guard for libFuzzer.
> > >
> > > BUG=651540
> > >
> > > Review-Url: https://codereview.chromium.org/2665243002
> > > Cr-Commit-Position: refs/heads/master@{#447392}
> > > Committed: https://chromium.googlesource.com/chromium/src/+/002dca9ca557b96939ed99ae9450dcb42f5d1620
> >
> > TBR=inferno@chromium.org,kcc@chromium.org,aizatsky@chromium.org,mmoroz@chromium.org,dpranke@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=651540
> >
> > Review-Url: https://codereview.chromium.org/2668093004
> > Cr-Commit-Position: refs/heads/master@{#447552}
> > Committed: https://chromium.googlesource.com/chromium/src/+/23d6de2177b812285946bce6f459815799d825c5
>
> TBR=inferno@chromium.org,kcc@chromium.org,aizatsky@chromium.org,mmoroz@chromium.org,dpranke@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=651540
>
> Review-Url: https://codereview.chromium.org/2672853002
> Cr-Commit-Position: refs/heads/master@{#447825}
> Committed: https://chromium.googlesource.com/chromium/src/+/28fbc2f08338a66ed15e96fd2841c66cbbda212f

TBR=inferno@chromium.org,kcc@chromium.org,aizatsky@chromium.org,mmoroz@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=651540

Review-Url: https://codereview.chromium.org/2675983002
Cr-Commit-Position: refs/heads/master@{#448011}

The histograms "Session.ClosedTabCounts", "Session.NewTabCounts" and
"Session.OpenedTabCounts" have never been documented and cannot be
easily be checked on uma. Document them to fix this.

BUG=None

Review-Url: https://codereview.chromium.org/2671993003
Cr-Commit-Position: refs/heads/master@{#448010}

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2672643004
Cr-Commit-Position: refs/heads/master@{#448009}

Since Wallet addresses don't have an email address, the signed-in
user's email address should be used if the Wallet address is not
merged into an existing local profile.

BUG=680182

Review-Url: https://codereview.chromium.org/2671813005
Cr-Commit-Position: refs/heads/master@{#448008}

BUG=none

Review-Url: https://codereview.chromium.org/2677683002
Cr-Commit-Position: refs/heads/master@{#448007}

This CL changes the use of ImageDataFetcher in BrowserViewController.
This needs the ImageDataFetcher to be able to have the referrer set.

BUG=683918

Review-Url: https://codereview.chromium.org/2674653003
Cr-Commit-Position: refs/heads/master@{#448006}

https://skia.googlesource.com/skia.git/+log/3f36369a94d2..113628d76176

$ git log 3f36369a9..113628d76 --date=short --no-merges --format='%ad %ae %s'
2017-02-02 ethannicholas Added dead variable / code elimination to skslc.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=halcanary@google.com

Review-Url: https://codereview.chromium.org/2678453002
Cr-Commit-Position: refs/heads/master@{#448005}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7c13382c..5de4d94e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2669283004
Cr-Commit-Position: refs/heads/master@{#448004}

Makes the context menu manager from the bottom sheet listen to
context menu close events from the parent ChromeActivity

BUG=688391

Review-Url: https://codereview.chromium.org/2675723004
Cr-Commit-Position: refs/heads/master@{#448003}

Review-Url: https://codereview.chromium.org/2645393002
Cr-Commit-Position: refs/heads/master@{#448002}

Previously UMA of PrePaint with SlimmingPaintInvalidation disabled
count twice for the old path and prePaint() (which skips the real
pre-paint tree walk and so added many near 0 results).

BUG=646176

Review-Url: https://codereview.chromium.org/2670013004
Cr-Commit-Position: refs/heads/master@{#448001}

So that it can be used in other processes as well.
There as some comment changes, and added @MainDex. But otherwise
a straightforward move.

BUG=680775

Review-Url: https://codereview.chromium.org/2667263002
Cr-Commit-Position: refs/heads/master@{#448000}

Revert of Add main lib section sizes to resource_sizes.py. (patchset #5 id:80001 of https://codereview.chromium.org/2675703003/ )

Reason for revert:
Breaks some Cronet builders because their native lib has different sections:
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20ARM64%20Builder/builds/48257

Original issue's description:
> Add main lib section sizes to resource_sizes.py.
>
> This CL adds detailed metrics for the main native library section sizes,
> grouped into "text", "data", "relocations", "unwind", "symbols", and
> "other" sections. These categories are added under a new subtest:
> "_MainLibInfo".
>
> BUG=681153
>
> Review-Url: https://codereview.chromium.org/2675703003
> Cr-Commit-Position: refs/heads/master@{#447991}
> Committed: https://chromium.googlesource.com/chromium/src/+/51583da63dae5f4c3baa9a229160b2c027afffb4

TBR=agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=681153
TBR=agrieve@chromium.org

Review-Url: https://codereview.chromium.org/2673043002
Cr-Commit-Position: refs/heads/master@{#447999}

As a precursor to a refactoring of the identity extension API implementation
to use the Identity Service, I am moving the implementations of the six
identity extension API functions to their own files, rather than all
being lumped together in identity_api.*. This will make it easier to
analyze each of these function implementations independently and
incrementally convert them to use the Identity Service.

BUG=685654

Review-Url: https://codereview.chromium.org/2671653004
Cr-Commit-Position: refs/heads/master@{#447998}

If the page is distilled and led to a redirection, the favicon to display
is the favicon of the final page.

BUG=688273

Review-Url: https://codereview.chromium.org/2673003002
Cr-Commit-Position: refs/heads/master@{#447997}

Prior to this change, other children would end up with references to an
earlier child's stdout handle, thereby preventing it from being deleted.

This change alone makes things better, but doesn't entirely plug the
hole: OpenFile (used by ReadFileToString) inadvertently opens its
handles for inheritance due to implementation details of the Microsoft
CRT. There exists an undocumented "N" mode flag for opening file streams
that disables allowing the opened file to be inherited into child
processes. Another CL will address this.

BUG=671990
R=phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2670213004
Cr-Commit-Position: refs/heads/master@{#447996}

They were previously un-restricted, and bd716dcb
regressed that.

BUG=682488
R=jorgelo@chromium.org

Review-Url: https://codereview.chromium.org/2669293003
Cr-Commit-Position: refs/heads/master@{#447995}

Combine enums SpdyRstStreamStatus and SpdyGoawayStatus into
SpdyErrorCode, and change underlying type to uint32.

Also rename *status arguments, local variables, members, accessors, and
log messages to *error_code.  It seems to me that "status" is leftover
terminology from early SPDY versions: RFC 7540 clearly talks about
"error code".

This CL lands server changes 144330546 and 145469431,
and parts of 145013960, by bnc.

BUG=488484

Review-Url: https://codereview.chromium.org/2675593002
Cr-Commit-Position: refs/heads/master@{#447994}

The old name is going away.

R=tandrii@chromium.org
NOTRY=True
BUG=

Review-Url: https://codereview.chromium.org/2671593004
Cr-Commit-Position: refs/heads/master@{#447993}

This CL removes one obsolete variation param and associate another one by
the feature name.

BUG=686778

Review-Url: https://codereview.chromium.org/2665743002
Cr-Commit-Position: refs/heads/master@{#447992}

This CL adds detailed metrics for the main native library section sizes,
grouped into "text", "data", "relocations", "unwind", "symbols", and
"other" sections. These categories are added under a new subtest:
"_MainLibInfo".

BUG=681153

Review-Url: https://codereview.chromium.org/2675703003
Cr-Commit-Position: refs/heads/master@{#447991}

Add mojoms and StructTraits so that a complete DisplayLayout can be
serialized. This includes DisplayPlacement and some enums. DisplayLayout
is serialized via unique_ptr since it is normally stored as a
unique_ptr.

This is required to pass the DisplayLayout from mus-ws to chrome for the
display options page.

BUG=686848

Review-Url: https://codereview.chromium.org/2661663002
Cr-Commit-Position: refs/heads/master@{#447990}