- 20 Aug, 2019 40 commits
-
-
Peng Huang authored
Bug: 900973 Change-Id: I67570ec7f0fcf7daa9bd1234d17ae5a9c9b9bf23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761634Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#688744}
-
Oksana Zhuravlova authored
This change adds a SetBinderForTesting() method to BrowserInterfaceBrokerProxy and modifies MojoInterfaceInterceptor to call this new method if a script passes a new "useBrowserInterfaceBroker" parameter. Also converts IdleManager to use BrowserInterfaceBrokerProxy as a use case for overriding interface handlers in web tests. Bug: 985118 Change-Id: I8dc3fc1c4beb2ae375a2534b03cd890ce1e3b52c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756480 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#688743}
-
Connor Clark authored
Change-Id: Id9c20b4f4c7f34e5d8e3670889703e87ad17fc45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762582Reviewed-by:
Paul Irish <paulirish@chromium.org> Commit-Queue: Connor Clark <cjamcl@google.com> Cr-Commit-Position: refs/heads/master@{#688742}
-
Robert Ogden authored
Another hopeful fix. Bug: 969163 Change-Id: I797e2053d455b0d921ffdb5e6badac5c53135961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762793Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#688741}
-
John Lee authored
cr.icon.getFavicon previously took in a URL and used regex to determine if the URL is a favicon or a site/page URL, but each caller already knows if the URL is an icon or a page URL. This is to ultimately be able to use this method for the WebUI tab strip given a favicon URL and bypass the regex check since favicons out in the web can technically be gifs, jpgs, data URLs, etc. This CL also fixes an issue where favicon .ico/.png URLs had params added at the end and were therefore not detected by the regex. Bug: 989131 Change-Id: I999ccf7d75e4e2401d54e861c735487c33ee1bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761327 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#688740}
-
Martin Kreichgauer authored
This adds operator<<(std::ostream&) overloads for <webauthn.h> types and FIDO_LOGs for each call to the WebAuthNMakeCredential() and WebAuthNGetAssertion() Windows API functions. Change-Id: I8c70efbe7c91daeb11fe66871379d8f457a6681d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759224 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#688739}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/35815c5fbd26..4bc8f4f7252c git log 35815c5fbd26..4bc8f4f7252c --date=short --no-merges --format='%ad %ae %s' 2019-08-20 saklein@chromium.org TestService: Add cros_signing tests endpoint. Created with: gclient setdep -r src/third_party/chromite@4bc8f4f7252c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I1e367f338b3877e6989d3ef82cabb8e30a9b5639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762781Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688738}
-
minch authored
Color of |vertical_label_minutes_| will be set through TimeView::SetTextColorBasedOnSession at https://cs.chromium.org/chromium/src/ash/system/time/time_view.cc?rcl=3886244ecee4d53af5684b966f679ba9c8838de9&l=115 No need to SetEnabledColor for it anymore. Bug: 982950 Change-Id: I2d867f9e55c47c42d1ced5da52895bbb6b774857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762698Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#688737}
-
James Cook authored
Use FakeDisplaySnapshot::Builder to avoid the very-long argument list for DisplaySnapshot. Fix include-what-you-use. Bug: none Change-Id: I83f5f1d0a240c9e589d5de1baa6bd2159127a1d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761445Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#688736}
-
Tomasz Wiszkowski authored
This is part of the flags experiment cleanup. We need this flag for a little longer. Bug: 951392 Change-Id: I97b381c6d8eeb4ce6581b4d142c4f437447deaea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762530 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#688735}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/fd72dd0a439f..92eb0415d0b1 git log fd72dd0a439f..92eb0415d0b1 --date=short --no-merges --format='%ad %ae %s' 2019-08-20 capn@google.com Refactor GLES routine cache keys to use Memset<T> Created with: gclient setdep -r src/third_party/swiftshader@92eb0415d0b1 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/135744933 Change-Id: I348af6fa52ed15b996c8cc2f5b4428bd08f34f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762779Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688734}
-
Thomas Guilbert authored
This CL adds a singleton LearningSession to BrowserContext. This provides a single location from which to get LearningTaskControllers, which will allow aggregating observations accross multiple frames. Bug: 994831 Change-Id: Ibeaf47a09ae7408d0afab9bc113a98e9f1532199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758625Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#688733}
-
kylechar authored
Bump to M79 since we still need the flag. Bug: none Change-Id: Iaa06e3f8fd03dc9b52aa3c20ab5cba1dfe6097d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762694 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#688732}
-
Matt Reynolds authored
The gamepad blocklist is used to exclude HID devices that look like gamepads to our HID gamepad heuristics but are not gamepads. This CL blocks all devices from these vendors, none of which are known to make gamepads: Alps Electric Co., Ltd D-WAV Scientific Co., Ltd Elan Microelectronics Corp. Elo TouchSystems LG Display Co., Ltd. Quanta Computer, Inc. Silicon Integrated Systems Corp. Sun Microsystems, Inc. Synaptics, Inc. Wacom Co., Ltd Additionally, some devices from these vendors are blocked: Apple, Inc. Atmel Corp. Award Software International Corsair Cypress Semiconductor Corp. Darfon Electronics Corp. Holtek Semiconductor, Inc. Lenovo Microsoft Corp. BUG=994457 Change-Id: I10aabb56ff4945391d1bfb01be90fc9748e4dfbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759007Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#688731}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/210fac8904dc..068e0cc6f357 git log 210fac8904dc..068e0cc6f357 --date=short --no-merges --format='%ad %ae %s' 2019-08-20 zoddicus@users.noreply.github.com Manually cast fuzzing data to avoid new GCC warning (#782) Created with: gclient setdep -r src/third_party/shaderc/src@068e0cc6f357 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I4c5268029105907b47eb9e33e9a37ae5c460677f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762774Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688730}
-
minch authored
Bug: 982950 Change-Id: I8a0b77bfcbe4142aad80f7f0ad63eb9203ba567b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762416 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#688729}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/26cade66d004..921f54270edc Created with: gclient setdep -r src-internal@921f54270edc The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: Ibef2272d747afe2219160f4ef5f611e460fe2b46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761686Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688728}
-
John Delaney authored
Updates the expiry of this histogram. This metric is still used to monitor what percent of bandwidth is used for ads. Bug: 986525 Change-Id: I969f4cca666471056c1dfc3c5f5a55dca0c5dbc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762355Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#688727}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/451ed2dbac83..269f2aedd69d git log 451ed2dbac83..269f2aedd69d --date=short --no-merges --format='%ad %ae %s' 2019-08-20 tsepez@chromium.org Rename IPDFSDK_PauseAdapater to CPDFSDK_PauseAdapter. 2019-08-20 thestig@chromium.org Mention how much memory FPDFBitmap_Create() can allocate. 2019-08-20 tsepez@chromium.org Rename IPDF_FormNotify to CPDF_InteractiveForm::NotifierIface 2019-08-20 tsepez@chromium.org Mark some xfa-only methods private in cffl_interactiveformfiller.h 2019-08-20 tsepez@chromium.org Remove constants/ from module diagrams. 2019-08-20 thestig@chromium.org Add {{streamlen}} macro to javascript tests. Created with: gclient setdep -r src/third_party/pdfium@269f2aedd69d The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I5d5eb27bec74e53d8d8edaa5f6566d49c0ece149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762772Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688726}
-
Sunny Sachanandani authored
This CL adds low latency mode support using shared image swap chains to canvas2d. CanvasResourceProviderSwapChain manages a single swap chain resource binding the back buffer as a render target to an SkSurface, and exporting the front buffer mailbox to the compositor. At the end of every frame ProduceCanvasResource() presents the swap chain and copies the front buffer to back buffer to retain rendered contents. This mode is guarded behind the --enable-canvas2d-swap-chain flag and Canvas2dSwapChain web runtime feature. The 2D low latency canvas demos https://codepen.io/miguelao/full/ZjJNNw https://codepen.io/miguelao/full/mLLKLg can run with swap chains with the following flags: --enable-canvas2d-swap-chain --enable-direct-composition-layers Other changes: 1) PresntationMode is now a bitmask since we want to support both swap chain and overlay image modes when creating resource provider. 2) SwapChainFactoryDXGI now supports BGRA_8888 in addition to RGBA_8888 since canvas2d prefers BGRA format when Skia does. The underlying swap chain format is same (BGRA) in both cases. 3) Move --enable-webgl-swap-chain flag to content_switches. Change-Id: Iaed22a8e46f410aba11aff7d2e5b4fa6d1ee0909 Bug: 939659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747159 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#688725}
-
Martin Kreichgauer authored
AreGetAssertionRequestMapKeysCorrect() contained a tautological comparison. Also clean up the surrounding code a little. Bug: 995867 Change-Id: Ib585f08a9727d604dfc8af07cc0cb67d8e524fca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762579 Auto-Submit: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#688724}
-
Shakti Sahu authored
As per the discussions, added few changes to the accessibility mode : 1 - Removed announceForAccessibility calls 2 - Removed dismiss on timeout from the IPH when on a11y mode Bug: 871455 Change-Id: I1d5f47ac5cfb7bcf890b539552d69fff01503456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759203Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688723}
-
Elly Fong-Jones authored
These tests were disabled a while ago when they broke. This change: 1) Implements some parts of FakeKeystoneGlue and FakeKeystoneRegistration so that these tests pass 2) Updates the BasicUse test to more closely check the contract of KeystoneGlue Bug: 16360 Change-Id: Ic28de2440f792751cf856e8ea61d5ff309c23f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757368 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#688722}
-
Jamie Walch authored
Change-Id: I402f691a57d73ca287441d202034418f5a9a3920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726905 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#688721}
-
Bettina authored
This change depends on cr/1693188. Bug: 914410 Change-Id: I510f2e63c924bc7860325601d6c4d1b93c542091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709893Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#688720}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/81080a729af568f7b5fde92b9170cc17065027c9..44544d9d2d624cbfff9b1e77cb77f8dfc70d073c Bug: none Change-Id: I588aaa765ae59dd85a6f236ef7d861ae0e9f293c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760871 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#688719}
-
Joshua Peraza authored
8edbc7439b2b codereview.settings: stop forcing squashing 64399c514ff2 Implement Exception context for minidump 6b5e30db285f Fix signed-unsigned-wchar build failure efaebfc482b7 fuchsia: Capture from SP (+slop) to stack base, rather than entire stack ec56fc6a38f0 linux: add Get/SetHandlerSocket() 3a6c6012ba2b linux: override exception thread ID Change-Id: I2a9c12ec841ec053d7558a7e2d40dee0587fe1d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762682Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#688718}
-
Yi Gu authored
The drag and drop issue with Viz hit testing has been fixed in crrev.com/c/1693442. Bug: None Change-Id: Ifbca617f1a0391dc6bd6465d0ee0de1c1aba3d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761776Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688717}
-
Matt Reynolds authored
Previously, HID gamepad haptics duplicated the OS-specific logic for writing HID output reports. This CL factors out the duplicated logic. BUG=984155 Change-Id: I31001415f840a169a261ee9c1e84030e0e6ee17e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754666 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#688716}
-
Etienne Bergeron authored
This CL is fixes the unit tests for the PlatformFontSkiaOnWindows experiment. 1) It fixes the off-by one due to rounding (e.g. font height computation). 2) It uses the DirectWrite Skia font manager by default; otherwise the default is the GDI font manager which is not giving the appropriate metrics. 1) Off-by-one due to rounding: PlatformFontWin is computing the font metrics with Skia in the function PlatformFontWin::CreateHFontRefFromSkia. See: https://cs.chromium.org/chromium/src/ui/gfx/platform_font_win.cc?l=515 SkFontMetrics skia_metrics; font.getMetrics(&skia_metrics); const int height = std::ceil(skia_metrics.fDescent - skia_metrics.fAscent); PlatformFontSkia is computing it this way (ComputeMetricsIfNecessary): See: https://cs.chromium.org/chromium/src/ui/gfx/platform_font_skia.cc?l=342 SkFontMetrics skia_metrics; font.getMetrics(&skia_metrics); ascent_pixels_ = SkScalarCeilToInt(-metrics.fAscent); height_pixels_ = ascent_pixels_ + SkScalarCeilToInt(metrics.fDescent); The height computation is also not consistent with the way it's computed on Mac(platform_font_mac). See: https://cs.chromium.org/chromium/src/ui/gfx/platform_font_mac.mm?q=platformfont+mac&dr=C&l=355 height_ = ceil(ascent_ + std::abs([font descender]) + [font leading]); This difference is making the font height on linux/windows off by one pixel. Unittests were adjusted for these off-by-one on each platform. The migration of PlatformFontWin to PlatformFontSkia is making these tests to fail. Ideally, we should choose one implementation and fix the code. To ease the migration, this CL implements on Windows the same computation used in PlatformFontWin to minimize the visible changes in Chrome. 2) DirectWrite Font Manager The unittests are not calling InitializeDirectWrite(..) to force an override of the Skia font manager. The browser code currently fails if the font manager is not set to DirectWrite. Unfortunately, the unittests are not calling the initialization function and were using by default the GDI adapter. The simple way to fix this issue is to ensures that Chrome code (browser and tests) are only using the DirectWrite version. This is fine since WinXP is no longer maintained and DirectWrite is always available on Win7+. Bug: 944227 R=robliao@chromium.org, asvitkine@chromium.org Change-Id: Ide54b96d576c5e4ec862dabb5aef6c735a3ffdc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721453 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#688715}
-
Gabriel Charette authored
This is a partial reland of https://chromium-review.googlesource.com/c/chromium/src/+/1635827 for the documentation update (while not yet mandatory, it's already the desired syntax while we fix the remaining straddlers). TBR=fdoray@chromium.org Bug: 968047 Change-Id: I7e897f4ecb2ba6075ba754695bbbd30ff0439de0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759055 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#688714}
-
Matt Menke authored
This CL adds NetworkIsolationKey as an argument to AlternativeServiceInfoVector methods in HttpServerProperties, and makes consumers pass in the correct key. Bug: 969890 Change-Id: Icc25b3a944f574522c52d5f1035fdb26539e0b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754271 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#688713}
-
Steven Bingler authored
The mode policy, DnsOverHttpsMode, has 3 possible values: off, automatic, and secure; these set the DNS-over-HTTPS mode to off, automatic, and secure mode respectively. secure will be, initially, unsupported and will map to off. This policy will also have an enterprise default value of off so that enterprise machines will not take part in the DNS-over-HTTPS experiment by default. Bug: 955454 Change-Id: I776ff016aa01b18dd507facd0e6a11a6b4d2f310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752931Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#688712}
-
Chris Palmer authored
Bug: 984742 Change-Id: I35a17fc8b923c949125ff63511c424143f3f80e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761402 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#688711}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e6ff7901. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools jsbell@chromium.org: external/wpt/encoding NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I322a3959f77d129ec0954968a96ba98cc102b0da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758465Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688710}
-
Fredrik Söderquist authored
Use the StringHasher::ComputeHash() helper. Change-Id: Ic43c19467a9d15f1b82c4ac586ebe7b80f937c60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762220Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#688709}
-
Corentin Wallez authored
These were removed from WebGPU because they cannot be supported everywhere, for example on recent Qualcomm chips. BUG=dawn:128 Change-Id: I235539916730001ad329f9ad067da7599e109360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760959 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#688708}
-
Evan Stade authored
Wait for theme update by listening for notification instead of RunUntilIdle. This fix is prospective: I couldn't get it to flake locally with or without the change. Bug: 995851 Change-Id: I5a3a4dda389178f6e3dd114ee14da9ea593254d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762353Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#688707}
-
Yue Li authored
Some spacing updates and move the voice match animation to the middle. Bug: 994462 Test: Manual test Change-Id: Id81f555cdfd6d620138831c426ba8ae6eb77e8c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761647 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#688706}
-
Yi Gu authored
Previously we had both kEnableVizHitTestDrawQuad (VizHitTesting v1) and kEnableVizHitTestSurfaceLayer(v2). After v1 being shipped, the function IsVizHitTestingDrawQuadEnabled() was no longer useful. It just returns !IsVizHitTestingSurfaceLayerEnabled(). Bug: 917015 Change-Id: Id7791763704235238cf0cfbc91bbf580128fa543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762588Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688705}
-