- 22 Jun, 2018 40 commits
-
-
Kyle Milka authored
Add error strings for various errors that can occur while using NTP custom backgrounds and custom links. Bug: 851217 Change-Id: I4cd68efedfb12fbf89150c8ee72aeaa859f7ec15 Reviewed-on: https://chromium-review.googlesource.com/1102001 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#569519}
-
Mounir Lamouri authored
Bug: 846490 Change-Id: Ibbae79a3658c26f0d3260d4b9e480c456c4716e6 Reviewed-on: https://chromium-review.googlesource.com/1101650Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#569518}
-
Helen Li authored
Add test coverage for whitelist matching code. Change-Id: I74cb692518ca1e14d5d534ac4c49f6a07734d716 Reviewed-on: https://chromium-review.googlesource.com/1110558Reviewed-by:
Siddhartha S <ssid@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#569517}
-
David Bokan authored
To see logs start chrome/content_shell with: --vmodule=layer_tree_host=3 Bug: 854200 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1b03c2f11e0a05fa7588c8e31837e12488fc7b15 Reviewed-on: https://chromium-review.googlesource.com/1107263Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#569516}
-
Donna Wu authored
This CL changes MtpDeviceManager from forwarding to MediaTransferProtocolManagerImpl to directly having the implementations of the latter in the methods that previously forwarded. As MediaTransferProtocolManagerImpl was previously an implementation detail hidden in media_transfer_protocol_manager.cc, the relevant parts of the MediaTransferProtocolManagerImpl declaration are moved from that cc file to mtp_device_manager.h, while the relevant parts of the impl are inlined into the corresponding MtpDeviceManager method implementations in mtp_device_manager.cc. BUG=769630 Change-Id: Ia3ce06a69b8b4574b666711c2d8811d71101f579 Reviewed-on: https://chromium-review.googlesource.com/1096656 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#569515}
-
Kunihiko Sakamoto authored
This will be used by SignedExchangeHandler to verify that certificates for signed exchanges have the testCanSignHttpExchanges extension. Bug: 851778 Change-Id: Ib32a00246da5176b3077e7fcf70ad283a8511b98 Reviewed-on: https://chromium-review.googlesource.com/1103430 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#569514}
-
Christopher Cameron authored
This is a race between navigation and surfaces on their way to the browser. Here is the way that things work when the test passes: 1. Renderer process navigates a. Renderer calls RenderFrameImpl::DidCommitNavigationInternal - This will go more-or-less directly to the browser process b. Renderer calls SubmitCompositorFrame with the current surface id - This goes off to the viz process, and eventually will land back in the browser 2. The browser process gets the message from [1.a.] a. Comes in as RWHI::DidNavigate b. Calls RWHV::DidNavigate - This will skip allocating a new surface id, because this is the first navigation c. STARTS the NewContentRenderTimeout (at the end of RHWI::DidNavigate) 3. The browser process gets notified of the frame sent in [1.b.] a. Comes in as DelegatedFrameHost::OnFirstSurfaceActivation b. STOPS the NewContentRenderTimeout (in RHWI::DidReceiveFirstFrameAfterNavigation). So we stop the timer, and so we don't evict our frame. But notice how we're relying on [1.a.] arriving at the browser before [1.b.], even though they take completely independent routes? What ends up happening to us when we get a flake is: 1. Renderer process navigates a. Renderer calls RenderFrameImpl::DidCommitNavigationInternal b. Renderer calls SubmitCompositorFrame with the current surface id 2. The browser process gets notified of the frame sent in [1.b.] a. Comes in as DelegatedFrameHost::OnFirstSurfaceActivation b. In RHWI::DidReceiveFirstFrameAfterNavigation, we don't stop the NewContentRenderTimeout, because we never started it. 3. The browser process gets the message from [1.a.] a. Comes in as RWHI::DidNavigate b. Calls RWHV::DidNavigate - This will skip allocating a new surface id, because this is the first navigation c. STARTS the new NewContentRenderTimeout (at the end of RHWI::DidNavigate) We'll never hit OnFirstSurfaceActivation for this surface id again (because we already hit it), and so the timeout will always fire. The fix is to change RHWI::DidNavigate to only start the timer when RWHV::DidNavigate changes the surface id. Two reasons: - If we didn't change the surface id, it was because this was the first navigation, and so we don't need to clear the frame. - If we allocate a new surface id, then that will kick the renderer to trigger OnFirstSurfaceActivation that will tell us to stop the timer (and if we don't allocate a new id, we won't necessarily hit OnFirstSurfaceActivation, and we won't stop the timer). R=samans, kbr TBR=piman (for content/ OWNERship) Bug: 853651 Change-Id: I25a8fbf5f6b618b64d764546056fd342e8fc50f9 Reviewed-on: https://chromium-review.googlesource.com/1109448Reviewed-by:Kenneth Russell <kbr@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#569513}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9457546761a4..f01c24ff435e git log 9457546761a4..f01c24ff435e --date=short --no-merges --format='%ad %ae %s' 2018-06-22 rmistry@google.com Whitespace change to trigger flutter roller Created with: gclient setdep -r src/third_party/skia@f01c24ff435e The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I6509ba4d27c5015dca156dc42614d61f32a088d2 Reviewed-on: https://chromium-review.googlesource.com/1111437Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569512}
-
Nikunj Bhagat authored
Bug: 842370 Change-Id: I5ecc2536c6f205c2d6974c555a46e227488d26e3 Reviewed-on: https://chromium-review.googlesource.com/1108551Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#569511}
-
Stephen Martinis authored
This argument is passed when the test is being retried. Parse and ignore it so the retry without patch logic works correctly. Also fixes the json test result output for the test, so that if the test fails, it's marked as unexpected. Also moves the wrapper script into //testing/scripts, which is where wrapper scripts are supposed to live. Bug: 533481 Change-Id: I4409be32a84c885d677ae90791a51c847d0c7e1f Reviewed-on: https://chromium-review.googlesource.com/1107054 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#569510}
-
Tetsui Ohkubo authored
Do not distrub button and notifier settings should be hidden when a user is not logged in / locked. TEST=QuietModeFeaturePodControllerTest BUG=853622 Change-Id: If9f9bf923814c8b45c6ddf9dd4109f44ca1ff617 Reviewed-on: https://chromium-review.googlesource.com/1107530 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#569509}
-
Moe Ahmadi authored
- Replaces the credit card save infobar icon with a new one with smaller intrinsic padding so it can be better aligned with the title text. - Also adjusts the line height of the labels in the infobar. - New PNGs are pngcrushed. TBR=mathp Bug: 854246 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0425e43e3d44b058df3badd7dd1fa8d16d5787e6 Reviewed-on: https://chromium-review.googlesource.com/1111013 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#569508}
-
Patti authored
This is a reland of e2cac39f Original change's description: > Settings: Content settings can now be reset for a group of origins in All Sites. > > Add a three-dot / overflow menu to groups of origins in All Sites. This overflow > menu allows the entire list of origins to have all their content settings reset > in one go. This will be preceded with a confirmation dialog. > > Manual test - With #enable-site-settings turned on, change a content setting via > Page Info > Site settings on both https://permission.site and > http://permission.site. Navigate to chrome://settings/content/all and see that > both sites are listed under 'permission.site'. Verify there is an overflow menu > on this entry and that inside the overflow menu, there is a 'Reset permissions' > option. Clicking this should bring up a reset permission dialog and confirming > the dialog should remove this entry from All Sites. > > Bug: 835712, 717468 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: I777f759c26bf0fe7f8da086fa887969897cf9833 > Reviewed-on: https://chromium-review.googlesource.com/1098577 > Commit-Queue: Patti <patricialor@chromium.org> > Reviewed-by: Dave Schuyler <dschuyler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568742} Bug: 835712, 717468 Change-Id: I6560d10b31602038daa03f57fc67b6a878794d5a Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1109537 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#569507}
-
Ned Nguyen authored
This is to debug why the actual shard runtime is so different from predicted shard's runtime Change-Id: I025de62a10729d17790bb22650dfa61423daf7ce TBR=eyaich@chromium.org Change-Id: I025de62a10729d17790bb22650dfa61423daf7ce Reviewed-on: https://chromium-review.googlesource.com/1110554Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#569506}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4099daa97b38..09098853e107 git log 4099daa97b38..09098853e107 --date=short --no-merges --format='%ad %ae %s' 2018-06-21 vadimsh@chromium.org Demote linux-386 to "best effort support", just like e.g. linux-ppc64. 2018-06-21 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-21 ehmaldonado@chromium.org gclient: Make gclient respect unmanaged dependencies when syncing. 2018-06-21 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-21 vadimsh@chromium.org Stop checking CIPD packages exist on linux-386. 2018-06-21 ahassani@google.com cpplint: Pull in upstream changes 2018-06-21 tandrii@chromium.org bot_update: default to non-shallow checkouts. 2018-06-21 iannucci@chromium.org Fix minor regression in git_upstream_diff. Created with: gclient setdep -r src/third_party/depot_tools@09098853e107 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:854300,chromium:853032,chromium:854300,chromium:852898,chromium:855137 TBR=agable@chromium.org Change-Id: Id8a265a396d0d7fdbdad58688673e2acb30a3446 Reviewed-on: https://chromium-review.googlesource.com/1111137Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569505}
-
Dale Curtis authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/c3b8d611c12f..de23348fef6f $ git log c3b8d611c..de23348fe --date=short --no-merges --format='%ad %ae %s' 2018-06-21 dalecurtis Update patches file for cherry-pick from upstream. 2018-06-12 modmaker-at-google.com avformat/mov: Add check for per-sample IV size. Created with: roll-dep src/third_party/ffmpeg BUG=853416 TBR=liberato Change-Id: I8794e0e7151258f0ad7d599803a0aeb90efa2917 Reviewed-on: https://chromium-review.googlesource.com/1111267Reviewed-by:
-
Chong Zhang authored
This CL: 1. Allows chrome to add policy headers for navigations and redirects via content API. 2. Removes the old |PolicyHeaderIOHelper| codepath and moves policy header tests to a new location. 3. Adds a move constructor/assignment for |net::HttpRequestHeaders|. Bug: 832749,845683 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I713ed30da33ba5feb5f437f8927b173c2f84d91a Reviewed-on: https://chromium-review.googlesource.com/1100393 Commit-Queue: Chong Zhang <chongz@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#569503}
-
David Tseng authored
Change-Id: If274eda790046a53dffb0f4d3724aaaa1904699f Reviewed-on: https://chromium-review.googlesource.com/1096422 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#569502}
-
Jeremy Roman authored
Change-Id: Ic5dde187984e827fde4dba21b1df3ef399c6a56f Reviewed-on: https://chromium-review.googlesource.com/1110941Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#569501}
-
Matt Falkenhagen authored
These are only flaky on OOPIF (site-per-process), and there are existing flaky expectations for the non-OOR-CORS tests. I'm not sure why the OOR-CORS tests regressed recently, but since it's an experimental feature and the non-OOR-CORS tests are also flaky I'll leave it for OOR-CORS or OOPIF team to look. Bug: 854630, 834185 Change-Id: I93db44e01e96adb0d0f715061b66f0f7ec3f2862 TBR: dgrogan NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/1111479Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#569500}
-
Tetsui Ohkubo authored
Changing focus of a view may cause UnifiedSystemTrayBubble to destruct. (See stack trace of https://crbug.com/853434#c6) At the point UnifiedSystemTrayBubble is deleted, the widget is still not deleted, so we should explicitly check if the widget is closing. TEST=manual BUG=853434 Change-Id: I2d4a146393ad6d0a39d5c8b78ea3c3623d04b91e Reviewed-on: https://chromium-review.googlesource.com/1107036Reviewed-by:
-
Ned Nguyen authored
Add --exact-test-filter flag to telemetry unittest script when --isolated-script-test-filter is passed to trampoline script Bug: chromium:533481 Change-Id: Ib2716c4f7fa62df15b4b53b29bb11dc4d55e984b Reviewed-on: https://chromium-review.googlesource.com/1110598Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#569498}
-
Sunny authored
According to HTML document parsing spec[1], there is no special procedure for <template> tag when in "in frameset" insertion mode. Besides, in "in template" insertion mode, the parser should not process <frameset> tag by changing insertion mode to "in frameset" mode. Around 18 failed tests should be passed after this change. For standalone html5lib tests in LayoutTests/html5lib, template.dat is updated to match the correct behavior. [1] https://html.spec.whatwg.org/multipage/parsing.html BUG=829668 Change-Id: Id25e6ab9ce47042a8e86a30aa2827f529f24f463 Reviewed-on: https://chromium-review.googlesource.com/1108191Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#569497}
-
Aidan Wolter authored
In order to bind to interfaces, the MultizoneAudioDecoder needs the service_manager::connector from the parent service. Bug: 110480251 Test: Build, run multizone Change-Id: Ibd11f2ef05f6712d10a13748349e24fa13e8a63e Reviewed-on: https://chromium-review.googlesource.com/1110657Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Aidan Wolter <awolter@chromium.org> Cr-Commit-Position: refs/heads/master@{#569496}
-
Tetsui Ohkubo authored
The tooltip text for UserAvatarButon was set but not visible, because can_process_event_within_subtree for its child view was true. TEST=manual BUG=853710 Change-Id: I081a96628b1ab77e4ca57ef7d5900777a864b297 Reviewed-on: https://chromium-review.googlesource.com/1107432Reviewed-by:
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0d22d3fa3ae1..694c8ff073d5 git log 0d22d3fa3ae1..694c8ff073d5 --date=short --no-merges --format='%ad %ae %s' 2018-06-21 metzman@chromium.org [fuzzing] Make env more realistic 2018-06-21 dgarrett@google.com cros_tryjob: Use "default_debug" email template for --debug. 2018-06-21 ayatane@chromium.org Revert "chromeos-infra-go: Disable tests" 2018-06-21 dgarrett@google.com cbuildbot_launch: Tiny tweak to _MaybeCleanDistfiles. 2018-06-21 dgarrett@google.com cbuildbot: Remove .trybot marker concept. 2018-06-21 dgarrett@google.com config_lib: Remove config_lib.UseBuildbucketScheduler. 2018-06-21 dgarrett@google.com buildbucket_lib: Remove config_lib.UseBuildbucketScheduler. Created with: gclient setdep -r src/third_party/chromite@694c8ff073d5 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:648042,chromium:854734,chromium:852633,chromium:None,chromium:None,chromium:853025,chromium:853025 TBR=chrome-os-gardeners@chromium.org Change-Id: Ifce3485cd2e96d41803591c9a039daf716555a68 Reviewed-on: https://chromium-review.googlesource.com/1111158Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569494}
-
jonross authored
Except on Android, surface sync (--enable-surface-synchronization) is on by default. So keeping tests of it around are actually redundant. This removes them from all configs except for 'viz_fyi_android_gtests' where we want coverage to find bugs until we are ready to ship on Android. TEST=surface_sync_browser_tests, surface_sync_content_browsertests Bug: 843511 Change-Id: Icabccb7427c62844b9e56df1628e13f04d4b759a Reviewed-on: https://chromium-review.googlesource.com/1111098Reviewed-by:
-
Matt Wolenetz authored
Adds ability for ChunkDemuxer and SourceBufferState to indicate whether a changeType request's type can be satisfied (using successful construction of an associated StreamParser as the condition), and to effect changeType by resetting the SourceBufferState's StreamParser. SourceBufferState's state machine is expanded to allow for enforcing at-most-one invocation of it's |init_cb_|, while continuing to require that a newly constructed StreamParser first successfully handle an initialization segment. Since this CL does not relax the existing codec-strictness of StreamParserFactory (and, by extension, MediaSource.addSourceBuffer), it uses the same strictness for CanChangeType. Any relaxation can be done in later CLs. Also, since such codec strictness is still in place, SourceBufferStream codec changes (more than just existing support for same-codec config changes) are allowed only when handling the first initialization segment following a changeType request, and only if the SourceBuffer had previously handled an initialization segment. Later CLs will include changeType pipeline integration tests, Blink API experimental support for changeType, and changeType web-platform-tests. BUG=605134 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I57e6ef175c9e06ca59db03f8c07ebd6070504af4 Reviewed-on: https://chromium-review.googlesource.com/1110483 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#569492}
-
Dave Tapuska authored
Attempt an alternate for https://chromium-review.googlesource.com/c/chromium/src/+/1096133 by defining uint64_t based constructors and keeping the strlen intrinsic. BUG=588506 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7edecb3a9c9ca111584dbe0454bf818cad1b2382 Reviewed-on: https://chromium-review.googlesource.com/1105187 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#569491}
-
Khushal authored
If we have a valid transfer cache entry but it doesn't exist in the cache, we proceed with using an empty image. Since any referenced entries must be serialized and locked with each command, it should be considered an error. R=ericrk@chromium.org Bug: 853491 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I328d441163aa290693efd4870aeb3717c1586163 Reviewed-on: https://chromium-review.googlesource.com/1108556Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#569490}
-
Lukasz Anforowicz authored
r567099 introduced a bug, where the loop in SpellcheckService::OnCustomDictionaryChanged could spin forever without calling RenderProcessHost::iterator::Advance. This CL fixes this. Bug: 854540 Change-Id: I6a1829a3595a1414ceb75b125b54a4576b3c02a6 Reviewed-on: https://chromium-review.googlesource.com/1108540Reviewed-by:
-
Darren Shen authored
Timeouts on mac_chromium_rel_ng TBR=smcgruer@chromium.org Bug: 855055 Change-Id: Ifb98ee39067afac3d82e8655d784224d27dc57eb Reviewed-on: https://chromium-review.googlesource.com/1111178 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#569488}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/61582510eeb8..9457546761a4 git log 61582510eeb8..9457546761a4 --date=short --no-merges --format='%ad %ae %s' 2018-06-21 bsalomon@google.com Alternative fix for stale MIP maps on texture export/import. 2018-06-21 bungeman@google.com Revert "SkRefCnt, SkTypes: fix includes for clients" 2018-06-21 herb@google.com Revert "Add SkGlyphRunList" 2018-06-21 herb@google.com Use local strike caches to avoid flaky test behavior 2018-06-21 herb@google.com Make SkStrikeCache::Validate call non global version 2018-06-21 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 78ef7c5c81fb..97bcdb1d73a1 (1 commits) 2018-06-21 herb@google.com Add SkGlyphRunList 2018-06-21 benjaminwagner@google.com Revert "[infra] Enable retries for Windows compiles" 2018-06-21 egdaniel@google.com Fix vulkan copy resolve. 2018-06-21 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 20eea3cd3b2d..050ef946947a (1 commits) 2018-06-21 caryclark@skia.org make includes available for flutter 2018-06-21 benjaminwagner@google.com Add Perf NoGPUThreads jobs. 2018-06-21 herb@google.com Expand ExclusiveStrikePtr with StrikeCache 2018-06-21 ruiqimao@google.com fixed NIMA deformed vertices rendering 2018-06-21 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms eb7de4255855..78ef7c5c81fb (1 commits) 2018-06-21 borenet@google.com [recipes] Housekeeper-PerCommit-BundleRecipes needs vpython 2018-06-21 fmalita@chromium.org [skottie] Simplify AttachMask 2018-06-21 allanmac@google.com OpenGL interop is simplified when the cl_context is not created by SKC. 2018-06-21 robertphillips@google.com Switch to swap in moveOpListsToDDL for SkTArray 2018-06-21 reed@google.com use double to compute root to avoid overflow 2018-06-21 robertphillips@google.com Move taskgroup initialization closer to where it is used 2018-06-21 caryclark@skia.org abort really big path fuzzing 2018-06-21 reed@google.com add test for wacky conic edges (disabled for now) 2018-06-21 halcanary@google.com Mark all deleted methods private 2018-06-21 brucewang@google.com Implement onMakeClone(const SkFontArguments& args) in class SkTypeface_AndroidSystem. 2018-06-21 herb@google.com Allow access to global glyph cache 2018-06-21 bsalomon@google.com Blacklist ReimportImageTextureWithMipLevels on AndroidOne 2018-06-21 stephana@google.com [infra] Remove PixelC bot Created with: gclient setdep -r src/third_party/skia@9457546761a4 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:850617,chromium:850350,chromium:850350 TBR=kjlubick@chromium.org Change-Id: I1e29242736d9855813ae91a481d5564ce97adc76 Reviewed-on: https://chromium-review.googlesource.com/1111157Reviewed-by:
-
Takuto Ikuta authored
This is follow up of https://chromium.googlesource.com/chromium/src/+/f7d47b7e8c03400343d4b6753ff79ade9d09ca68 This CL specifies libpath explicitly for LIB directories. Bug: 854849, 787903 Change-Id: I9b65b0c0980af1f7eb4ece2ffbb31d8bde44e7ce Reviewed-on: https://chromium-review.googlesource.com/1109452 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium c0dbb3da. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19949 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/IndexedDB timvolodine@chromium.org, reillyg@chromium.org: external/wpt/orientation-event TBR=robertma No-Export: true Change-Id: I3746b7fc790017c4daac1875fc885d9aeaface00 Reviewed-on: https://chromium-review.googlesource.com/1111008 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#569485}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6f440ed5b51f..5f5819f8ed8a git log 6f440ed5b51f..5f5819f8ed8a --date=short --no-merges --format='%ad %ae %s' 2018-06-21 buildbot@webrtc.org Roll chromium_revision 105c0431..cb8b61b4 (569260:569376) 2018-06-21 mhoro@webrtc.org Fix for VP9 K-SVC video freeze frame when send bandwidth is restricted. 2018-06-21 sergio.garcia.murillo@gmail.com Generalize SimulcastEncoderAdapter, use for H264 & VP8. 2018-06-21 phoglund@webrtc.org Convert video quality test from a TEST_F to a TEST fixture. 2018-06-21 buildbot@webrtc.org Roll chromium_revision e1ef7d4b..105c0431 (568794:569260) 2018-06-21 minyue@webrtc.org Aligning time in audio jitter buffer plot to other plots in rtc event log visualizer. 2018-06-21 phensman@webrtc.org Reland "Reland "Injectable logging"" Created with: gclient setdep -r src/third_party/webrtc@5f5819f8ed8a The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I386ba5c2adbdb646319c88312422e86ff9f96470 Reviewed-on: https://chromium-review.googlesource.com/1111058Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569484}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/3d8131535e6b..c3cc2ab66d3d git log 3d8131535e6b..c3cc2ab66d3d --date=short --no-merges --format='%ad %ae %s' 2018-06-21 rharrison@chromium.org Clean up constant values for JS alert and beep 2018-06-21 hnakashima@chromium.org Use enum for stages of CPDF_Creator. 2018-06-21 hnakashima@chromium.org Do not save content stream if all page objects were removed from it. 2018-06-21 rharrison@chromium.org Use the length of calculated string instead of source Created with: gclient setdep -r src/third_party/pdfium@c3cc2ab66d3d The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:854623 TBR=dsinclair@chromium.org Change-Id: I033b1457e15085df69d794da8d42dfcc3e015713 Reviewed-on: https://chromium-review.googlesource.com/1111057Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569483}
-
Peter Boström authored
Adds MATERIAL_REFRESH and MATERIAL_TOUCH_REFRESH to MD modes used in ToolbarActionsBarUnitTest and fixes the test to account for the separator area used in Refresh modes. Bug: chromium:846410 Change-Id: Ib6d45d26fc3ba273e3cc3c3613dae07c31af0c2b Reviewed-on: https://chromium-review.googlesource.com/1111269Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#569482}
-
Caleb Rouleau authored
This test isn't really necessary. The case is handled slightly differently on windows and mac, but it is not important to the product. This test was just added in https://chromium-review.googlesource.com/c/chromium/src/+/1106769 https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/22045 https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/78366 Bug: chromedriver:2474 Change-Id: I3a339886e479182ec28914292c43d8dbe62d5e84 Reviewed-on: https://chromium-review.googlesource.com/1111323Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#569481}
-
Kenneth Russell authored
It's passing on the new Intel HD 630 bots. Bug: 635528 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3c6b1f88f7f26ec71ac716f4fd135517dc07b158 Tbr: zmo@chromium.org Tbr: jdarpinian@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1111019Reviewed-by:
-
