- 11 Jan, 2017 39 commits
-
-
sashab authored
Changed EUnicodeBidi to an enum class and gave it an unsigned underlying type. Also renamed its members to match the CSS keywords they represent, and added the 'k' prefix in line with the Blink rename to match Chromium style. Changing it to an enum class enforces better namespacing and code practices. Adding the unsigned underlying type is pre-work for when the class is eventually stored as an enum bitfield (it would be done in this patch, except a presubmit warning already exists that prevents that. The presubmit warning needs to be updated before that change can occur.) This is also pre-work to allow EUnicodeBidi to be used by generated fields in ComputedStyleBase. BUG=628043 Review-Url: https://codereview.chromium.org/2625553005 Cr-Commit-Position: refs/heads/master@{#442775}
-
lazyboy authored
BUG=None Test=None, no visible change. Review-Url: https://codereview.chromium.org/2619973002 Cr-Commit-Position: refs/heads/master@{#442774}
-
ananta authored
This test turns off caching for the reload request initiated via the DevTools network agent. Without PlzNavigate, this goes through the normal resource load path, where in RenderFrameImpl::decidePolicyForNavigation is invoked after which the cache policy is set in the WebURLRequest to disabled correctly. With PlzNavigate, the reload request is sent out to the browser via the BeginNavigate IPC in RenderFrameImpl::decidePolicyForNavigation() and we indicate to blink that the client handled the request. As a result the cache policy does not get set to disabled. Fix is to add query the dev tools agent if caching is disabled. To achieve this following changes were needed. 1. Add a virtual function cacheDisabled() to the WebDevToolsAgent class. 2. This function calls to the newly added cacheDisabled() function in the InspectorNetworkAgent class. which checks the state variable for the same. BUG=673745 Review-Url: https://codereview.chromium.org/2611183007 Cr-Commit-Position: refs/heads/master@{#442773}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/854df3eb017b..8b10e7828ad2 $ git log 854df3eb0..8b10e7828 --date=short --no-merges --format='%ad %ae %s' 2017-01-10 bpastene devil: Push devil onto path when running adb_run_shell_cmd.py BUG=672189 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2626903002 Cr-Commit-Position: refs/heads/master@{#442772}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1f92260e..dd4cb049 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2628663002 Cr-Commit-Position: refs/heads/master@{#442771}
-
tombergan authored
On receiving a PUSH_PROMISED, the pushed stream is assigned an IDLE priority because it is "speculative". When the pushed stream matches an actual request, the stream's priority is updated to match that of the request. In addition to unit tests, I tested this against a local HTTP/2 server that served the following page: <html><body> <script type="application/javascript" src="/a.js"></script> <script type="application/javascript" src="/b.js"></script> <script type="application/javascript" src="/c.js"></script> </body></html> The server was configured to push "/b.js" when serving the HTML. I verified that the server's priority tree went through the following sequence: 1. {html -> b.js}, after receiving the PUSH_PROMISE 2. {html -> a.js -> b.js}, after the preload scanner finds a.js 3. {html -> a.js -> b.js}, after the preload scanner finds b.js 4. {html -> a.js -> b.js -> c.js}, after the preload scanner finds c.js Before this change, the final priority tree would have been: {html -> {b.js, {a.js -> c.js}}} BUG=668298 R=rdsmith@chromium.org,bnc@chromium.org Review-Url: https://codereview.chromium.org/2596703002 Cr-Commit-Position: refs/heads/master@{#442770} -
chenwilliam authored
See bug for screenshots. You can use it with graphviz or d3! BUG=679901 Review-Url: https://codereview.chromium.org/2624873002 Cr-Commit-Position: refs/heads/master@{#442769}
-
yusukes authored
Previously, the instance was prioritized when the OS fully started. However, it turned out that the prioritization caused Chrome UI jank on some boards. This CL changes the way of prioritization more dynamic to prevent such a jank. BUG=chrome-os-partner:60946 TEST=try Review-Url: https://codereview.chromium.org/2624513004 Cr-Commit-Position: refs/heads/master@{#442768}
-
reveman authored
This adds the "--crosh-command" command line switch that cab be used to specify an alternative crosh command. BUG=677267 TEST=chrome --crosh-command=/bin/bash Review-Url: https://codereview.chromium.org/2579833005 Cr-Commit-Position: refs/heads/master@{#442767}
-
chrome://webrtc-internalsdeadbeef authored
Just the SLD-equivalent of: https://codereview.chromium.org/2622453002 Also adds tests. BUG=chromium:677550 Review-Url: https://codereview.chromium.org/2619343003 Cr-Commit-Position: refs/heads/master@{#442766}
-
alokp authored
This patch changes the AudioOutputProxy -> AudioOutputDispatcher reference from raw pointer to a weak pointer to allow the dispatcher to be deleted before AudioOutputProxy instances can be closed. BUG=608049 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2621993002 Cr-Commit-Position: refs/heads/master@{#442765}
-
horo authored
BUG=630495,630496 Review-Url: https://codereview.chromium.org/2620913002 Cr-Commit-Position: refs/heads/master@{#442764}
-
mgiuca authored
The flag was for an old feature that was never launched. Removes the code behind this feature. BUG=540055 Review-Url: https://codereview.chromium.org/2621833003 Cr-Commit-Position: refs/heads/master@{#442763}
-
servolk authored
Typically renderer needs to do Flush + StartPlaying in response to stream status change (i.e. when stream gets enabled or disabled). But since Flush is an async operation we might get another status change of the same stream, while the renderer is still handling the previous one. In the past renderer has simply ignored status changes while another status change was processed. But that was problematic, since we couldn't guarantee that the renderer status will be correct after stream has been enabled/disabled very quickly a few times. This CL fixes that issue by postponing status changes handling if necessary, instead of dropping those notifications. BUG=678031 Review-Url: https://codereview.chromium.org/2605473002 Cr-Commit-Position: refs/heads/master@{#442762}
-
ccameron authored
This moves initialization of parameters to SetSubclassProperties. The next step is to clean up initialization to use a common program descriptor. In that patch, I'll change these functions to CheckSubclassProperties, so that I can DCHECK that I didn't change anything. BUG=667966 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2626823002 Cr-Commit-Position: refs/heads/master@{#442761}
-
rdevlin.cronin authored
Add a histogram to analyze extension initialization time. BUG=677299 Review-Url: https://codereview.chromium.org/2607773003 Cr-Commit-Position: refs/heads/master@{#442760}
-
rdevlin.cronin authored
Listeners can throw exceptions (as with any third-party code). Ensure that we have tests for this. When a listener throws an exception, it should be logged to the console, but not bubbled up to external try- catches (so that JS code that may have triggered the event doesn't receive it). This is the same as we do for web events. BUG=653596 Review-Url: https://codereview.chromium.org/2613093002 Cr-Commit-Position: refs/heads/master@{#442759}
-
caseq authored
Revert of DevTools: move front-end URL handling to DevToolsUIBindingds (patchset #2 id:40001 of https://codereview.chromium.org/2607833002/ ) Reason for revert: A better fix is coming, reverting this one to make it a part of the new fix so that one CL may be merged onto a branch. Original issue's description: > DevTools: move front-end URL handling to DevToolsUIBindingds > > BUG=662859 > > Committed: https://crrev.com/eea3300239f0b53e172a320eb8de59d0bea65f27 > Cr-Commit-Position: refs/heads/master@{#440926} TBR=dgozman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=662859 Review-Url: https://codereview.chromium.org/2620193002 Cr-Commit-Position: refs/heads/master@{#442758}
-
dmazzoni authored
Chrome now has support for more fine-grained accessibility modes. Individual accessibility APIs now enable parts of accessibility support as needed, but log data is suggesting that lots of clients are calling QueryService with IAccessible2 as the IID argument even though they don't need full accessibility support, so let's delete this particular trigger. BUG=672205,644647 Review-Url: https://codereview.chromium.org/2627733003 Cr-Commit-Position: refs/heads/master@{#442757}
-
yhanada authored
BUG=678558 TEST=Notification doesn't overlap with Uber Tray when ChromeVox is enabled. Review-Url: https://codereview.chromium.org/2625663002 Cr-Commit-Position: refs/heads/master@{#442756} -
tommycli authored
This fixes a regression where the tooltip to the profile picture is never updated. BUG=676782 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2622973002 Cr-Commit-Position: refs/heads/master@{#442755}
-
chenwilliam authored
Compiling frontend runs in ~13 seconds (including dependency check) instead of 22 seconds. Examples of the RegEx match: http://regexr.com/3etk5 The following CL needs to land before this CL lands: https://codereview.chromium.org/2623743002/ BUG=673445 Review-Url: https://codereview.chromium.org/2588843002 Cr-Commit-Position: refs/heads/master@{#442754}
-
rockot authored
This requirement is missing from content_utility's manifest. BUG=None TBR=ben@chromium.org Review-Url: https://codereview.chromium.org/2621203002 Cr-Commit-Position: refs/heads/master@{#442753}
-
jinsukkim authored
This is to fix the reported bug before branching. Will reintroduce this together with what's being handled in https://crrev.com/2595263002. This reverts commit 603de249. BUG=671967, 671401 TBR=boliu@chromium.org, tedchoc@chromium.org, dtrainor@chromium.org, bshe@chromium.org Review-Url: https://codereview.chromium.org/2626723003 Cr-Commit-Position: refs/heads/master@{#442752}
-
brucedawson authored
VC++ was initializing all of the static PathElement arrays in GetPathForVectorIcon and GetPathForVectorIconAt1xScale at runtime, which meant that these were the largest and sixth largest functions in chrome.dll, and similarly in chrome_child.dll. Tagging the arrays and types as constexpr shrinks these functions down to nothing, saves about ~50 KB of per-process private data, and actually helps them compile slightly faster. The approximate section size changes are: .text: -164224 bytes change .rdata: 51984 bytes change .data: -54976 bytes change .reloc: -23204 bytes change These gains apply both to chrome.dll and chrome_child.dll. BUG=679539 Review-Url: https://codereview.chromium.org/2620653004 Cr-Commit-Position: refs/heads/master@{#442751} -
qinmin authored
This is crashing on Xiaomi phones Android API doc never deprecates the call, so it is their ROM issue Catch the exception so Chrome will not crash. But click on download completion notification will not have any effect. BUG=678938 Review-Url: https://codereview.chromium.org/2616893005 Cr-Commit-Position: refs/heads/master@{#442750}
-
jbauman authored
This will allow other GL Surface implementations than ChildWindowSurfaceWin to create a child window on a new thread. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2623763003 Cr-Commit-Position: refs/heads/master@{#442749}
-
michaelpg authored
Make AppShell always the "unknown" channel, instead of always being "stable", because (a) it doesn't have channels, (b) we want to test unstable APIs too, and (c) saying app_shell is "dev channel" would be insulting to chrome dev channel. This allows APIs like chrome.hid.getUserSelectedDevices to exist in app_shell. (That particular one crashes, but what can you do...) BUG=none R=steel@chromium.org Review-Url: https://codereview.chromium.org/2580063003 Cr-Commit-Position: refs/heads/master@{#442748}
-
estade authored
BUG=615892 Review-Url: https://codereview.chromium.org/2607103003 Cr-Commit-Position: refs/heads/master@{#442747}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/3444cadedd47..fb00390b46b3 $ git log 3444caded..fb00390b4 --date=short --no-merges --format='%ad %ae %s' 2017-01-10 mtklein pretty up some SkSplicer code Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=kjlubick@google.com Review-Url: https://codereview.chromium.org/2625863002 Cr-Commit-Position: refs/heads/master@{#442746}
-
kbr authored
When the hardware-accelerated video decoding path is in use, the expected size of the destination WebGL texture is the video's natural width and height. However, the code was blindly copying the entire video source texture, which might include padding rows from the video encoder. Change to using CopySubTextureCHROMIUM in these code paths, and rely on the caller to allocate the destination texture with the expected size. A regression test for this bug is being added to the WebGL 2.0 conformance suite in https://github.com/KhronosGroup/WebGL/pull/2202 . BUG=672895 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2562003003 Cr-Commit-Position: refs/heads/master@{#442745}
-
stip authored
BUG=670147 Review-Url: https://codereview.chromium.org/2549393004 Cr-Commit-Position: refs/heads/master@{#442744}
-
wkorman authored
Improves on element-id-to-layer-id followed by layer-id-to-node-index lookups. BUG=674258 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2619383004 Cr-Commit-Position: refs/heads/master@{#442743}
-
dschuyler authored
Revert of A simple, practically zero cost fallback crash handler for Crashpad handler process. (patchset #14 id:260001 of https://codereview.chromium.org/2596463002/ ) Reason for revert: Sorry, it looks like the new patch also has a build failure. See crbug 679920. (I'm not 100% sure, this is my best guess, apologies if it turns out incorrect). Original issue's description: > A simple, practically zero cost fallback crash handler for Crashpad handler process. > > This implements a fallback crash handler launcher. The launcher will be instantiated in the Crashpad handler process, where it pre-computes a command line to be launched on crash. This will be triggered off the UEF, under some form of single-instance locking. > > BUG=678959 > > Review-Url: https://codereview.chromium.org/2596463002 > Cr-Original-Commit-Position: refs/heads/master@{#442596} > Committed: https://chromium.googlesource.com/chromium/src/+/d4e43bb5146c7a59123ff5f3b6e853d8e8c29130 > Review-Url: https://codereview.chromium.org/2596463002 > Cr-Commit-Position: refs/heads/master@{#442698} > Committed: https://chromium.googlesource.com/chromium/src/+/f87fdaa12b09ff286d873e7a3ea459507d7adb83 TBR=scottmg@chromium.org,siggi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=678959 Review-Url: https://codereview.chromium.org/2620213002 Cr-Commit-Position: refs/heads/master@{#442742}
-
oshima authored
It was updating the child window instead. This CL hooks up the bounds change to the desktop widget correctly. BUG=612270 TEST=fixed test harness to do the correct check. Review-Url: https://codereview.chromium.org/2583873002 Cr-Commit-Position: refs/heads/master@{#442741}
-
estade authored
BUG=618624 Review-Url: https://codereview.chromium.org/2623613009 Cr-Commit-Position: refs/heads/master@{#442740}
-
timloh authored
Revert of Sub-sample accurate start of OscillatorNode (patchset #11 id:200001 of https://codereview.chromium.org/2186813003/ ) Reason for revert: Added test is failing on WebKit Mac10.11 (retina) https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29 Original issue's description: > Sub-sample accurate start of OscillatorNode > > Previously, an oscillator would start at the nearest sample frame > boundary. This can produce noticeable effects. > > Instead, make the oscillator start at the requested sample time and > sample the curve appropriately. > > BUG=631576 > TEST=Oscillator/start-sampling.html > > Review-Url: https://codereview.chromium.org/2186813003 > Cr-Commit-Position: refs/heads/master@{#442669} > Committed: https://chromium.googlesource.com/chromium/src/+/7909df464ca46a1ea121b0c54e5d04cfa521e38c TBR=hongchan@chromium.org,rtoy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=631576 Review-Url: https://codereview.chromium.org/2623063002 Cr-Commit-Position: refs/heads/master@{#442739}
-
rlanday authored
Android InputConnection has two related methods - setComposingText() replaces the current compose region with a given piece of text and sets a composing span around the new text - commitText() replaces the text the same way but then closes out the compose region instead of putting it around the new text. Support was added for parsing BackgroundSpan and UnderlineSpan annotations in setComposingText() to support the Google Japanese Input IME (newly entered text in the compose region is underlined and highlighted in a blue background). The Android Voice IME instead uses commitText() because it wants the highlighted regions to persist after the compose region is closed out. Closing out the compose region after calling setComposingText() would clear the highlight regions. So to support this, we need to parse the spans for commitText() in ImeAdapterAndroid just as we do for setComposingText(), and also thread this information all the way back to InputMethodController as we do for setComposingText(). I tested this by forwarding calls of setComposingText() to commitText() and verifying that highlighting works for the Google Japanese IME. It's highlighting the character immediately ahead of the insertion point instead of the newly typed character when I do this; I suspect this may be because the IME is expecting something about the setComposingText() behavior (e.g. the compose range) that's different in commitText(), but it's also possible I have a bug in the new logic. Once I write some code to start parsing out SuggestionSpans from the Voice IME, I'll be able to test this better (I might be able to get this done tomorrow). BUG=673491 Review-Url: https://codereview.chromium.org/2568093003 Cr-Commit-Position: refs/heads/master@{#442738}
-
mcasas authored
This CL homogenises the behaviour of the ShapeDetector's detect() in case of an input element with any zero dimension. Assuming such input element pass the cross origin test and its underlying pixel data can be retrieved, then if either width or height is zero, detect() Promise is resolved with an empty array. LayoutTests are adapted/extended/cleaned up. BUG=674306 Review-Url: https://codereview.chromium.org/2626743002 Cr-Commit-Position: refs/heads/master@{#442737}
-
- 10 Jan, 2017 1 commit
-
-
allada authored
This patch moves NetworkRequest.prototype.url to a proper getter/setter function to be within our styleguide. R=caseq,luoe,einbinder,dgozman BUG=679105 Review-Url: https://codereview.chromium.org/2626553002 Cr-Commit-Position: refs/heads/master@{#442736}
-
