- 25 Feb, 2019 40 commits
-
-
Maksim Sisov authored
WaylandScreen::GetDisplayForAcceleratedWidget might be called right after the browser closed the WaylandWindow (on shutting down, for example), which may result in segfault or DCHECK. R=rjkroege@chromium.org Bug: 578890 Change-Id: Ic2b6fc5b9853a1aec7e5e70a0e979dc6c9e87aea Reviewed-on: https://chromium-review.googlesource.com/c/1485933Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#635130}
-
kylechar authored
Post[Delayed]TaskWithTraits() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?TaskWithTraits)\((?:\n\s*)?FROM_HERE,\n?\s*(\{.*?\n?.*?\}),(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=morlovich@chromium.org Bug: 714018 Change-Id: I6a5e8501e1bb824afc1e9ceb11232709b4eb47fd Reviewed-on: https://chromium-review.googlesource.com/c/1486631 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:Maks Orlovich <morlovich@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#635129}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/37b584a73669..fc3897b5f585 git log 37b584a73669..fc3897b5f585 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 9856269+sarahM0@users.noreply.github.com Validate: (data) Block can't appear within a Block (#2410) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@fc3897b5f585 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idb74ecc2017c17c66d7ee87ddc4b85cde2771e67 Reviewed-on: https://chromium-review.googlesource.com/c/1486651Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635128}
-
Chris Lu authored
Bug: 919685 Change-Id: I29969e5029028e7af0c64a4f6089aabc4b884055 Reviewed-on: https://chromium-review.googlesource.com/c/1483260 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#635127}
-
Sebastien Marchand authored
This relands commit 90ffaeaa, which has been reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1484088 See fix in ps2, the issue is that DCHECK(foo) calls aren't optimized away in release builds (they're disabled but still compiled). (TBR'ing jwd@ as this is a reland and nothing has changed in the code he owns). TBR=jwd@chromium.org Bug: 771478 Change-Id: Ifbd9873a1db870b35a7ad6fafc7763b0f2f3c090 Reviewed-on: https://chromium-review.googlesource.com/c/1486451 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#635126}
-
Andrew Grieve authored
Change-Id: I989e2d26c4ce97c5cdcf2d54fa2d5bc024ba9087 Reviewed-on: https://chromium-review.googlesource.com/c/1477962 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#635125}
-
Lukasz Anforowicz authored
Now that |CommonNavigationParams::initiator_origin| is available (and trustworthy - see https://crbug.com/919144#c12 and #c7) RenderFrameHostImpl (and its helper function GetOriginForURLLoaderFactory) can calculate an exact origin lock (rather than falling back to a site-URL-based lock). Bug: 918967, 888079 Change-Id: I3b180a785d5171bb924761e44fafb482314c1132 Reviewed-on: https://chromium-review.googlesource.com/c/1450237 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#635124}
-
Alexandre Frechette authored
We do not expect user location to change drastically in between Chrome sessions. Hence, caching the geolocated languages persistently in a pref should reduce the number of times we will need to inflate geo-language data. Bug: 929155 Change-Id: I894b8828d5411e652b44d10ff70adfb07a3a7f6e Reviewed-on: https://chromium-review.googlesource.com/c/1476987 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#635123}
-
Nico Weber authored
After https://chromium-review.googlesource.com/c/1019978, the fontconfig cache is independent of the name of the build directory. With this, the linux/release build is the first build configuration where all files mentioned in isolates (i.e. all executables covered by tests, including chrome, and all files needed to run chrome) are deterministic and independent of the name of the checkout directory and of the name of the build directory. If your local build dir is two levels deep (so that the path from build dir to checkout root is ../..) and you use the same gn args and the same revision as the det bots, you will get exactly the same bits in your local build as the bots. (Also add todo comments pointing out that the android and mac bots currently test a weaker form of build determinism than the linux and win bots.) Bug: 908463,314403,330263 Change-Id: Ic571b8ad63323f381f36539540545f19d295989d Reviewed-on: https://chromium-review.googlesource.com/c/1486071Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#635122}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ee9ff700224e..4b1953a0012f Created with: gclient setdep -r src-internal@4b1953a0012f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iabdf24ac587fb313de3e5125544587ecc55bd0aa Reviewed-on: https://chromium-review.googlesource.com/c/1486063Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635121}
-
Leonard Grey authored
Tracing categories are mostly guesswork; we'll need to refine these down the line. Bug: 934981 Change-Id: I96b86f67b01eafbb81ac12fc209bacba69fb0dfb Reviewed-on: https://chromium-review.googlesource.com/c/1483707 Commit-Queue: Leonard Grey <lgrey@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#635120}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/601d898e6096..8747978ce6f5 git log 601d898e6096..8747978ce6f5 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 lalitm@google.com Merge "Fix PagedMemory, use -1 FD for mmap to fix WASM" 2019-02-25 lalitm@google.com Merge "trace_processor: fix printing of clock sync rate events" Created with: gclient setdep -r src/third_party/perfetto@8747978ce6f5 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I10388e0ee58f5ba316f0e4ca6e3cd48fe2c8516d Reviewed-on: https://chromium-review.googlesource.com/c/1486068Reviewed-by:
-
Sylvain Defresne authored
Update the implementation of NotificationPromo to use JSONReader::Read instead of JSONReader::ReadDeprecated and fix calling code. Convert to use new base::Value API instead of using base::DictionaryValue too. Bug: 925165 Change-Id: I2077c0537fa416478b62a017b8617c842b32706c Reviewed-on: https://chromium-review.googlesource.com/c/1477229 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#635118}
-
dalyk authored
Cached results that are obtained insecurely are not a valid substitute for sending a DoH query. This cl takes the first step towards this goal by storing results in the cache with a key that indicates whether the results were obtained via DoH ("secure") or not. Some results that are stored with an "insecure" key may have actually been obtained securely (i.e. via DoT), but we store them with an insecure key because we don't know how they were obtained. CT log inclusion checks will be updated in a follow-up CL to use secure DNS if the associated hostname lookup was resolved securely. The behavior of the CT log inclusion checks is not altered by this CL. Bug: 878582 Change-Id: Ic88bb3c4a3af4e2695e8b382d598de042e26e580 Reviewed-on: https://chromium-review.googlesource.com/c/1450434 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#635117}
-
Eyor Alemayehu authored
Per feedback from: https://chromium-review.googlesource.com/c/chromium/src/+/1465070 updated documentation for preferences that can be overridden by administrator policies. Bug: b:124113875 Change-Id: I2b47ae6a031b3e65dcbc1348d4050600c63a8307 Reviewed-on: https://chromium-review.googlesource.com/c/1483258Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Eyor Alemayehu <eyor@google.com> Cr-Commit-Position: refs/heads/master@{#635116}
-
Elly Fong-Jones authored
This change assigns: enable-gpu-appcontainer enable-appcontainer to forshaw@ and wfh@. Bug: 933708, 807249 Change-Id: I9cf2cb5561bcd7c9dfa2129a191e91e51d3e1bd2 Reviewed-on: https://chromium-review.googlesource.com/c/1486432 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#635115}
-
Denis Kuznetsov authored
Bug: 912704 Change-Id: Ie1804ce8a6f05721e28a6d2c703530d8e0c53841 Reviewed-on: https://chromium-review.googlesource.com/c/1481511 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#635114}
-
Stephane Zermatten authored
This change removes dead code from the controller, which would register itself as WebContentsObserver. This was never exercised in production, because there's already a WebContentsObserver and there can be only one (on Android, it's TabWebContentsDelegateAndroid.) Bug: 806868 Change-Id: I7920010cfe6df2ceb241fd393faf427adb46d83a Reviewed-on: https://chromium-review.googlesource.com/c/1486272Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#635113}
-
Lowell Manners authored
Calling GetSafeWeakWrapper() is preferable to explictly constructing a WeakWrapperSharedURLLoaderFactory, because GetSafeWeakWrapper guarantees that Detach() will be called when the underlying TestURLLoaderFactory is destructed. Bug: 924960 Change-Id: I9e61c0b098a50972a189c1cdac56fc661f455e0d Reviewed-on: https://chromium-review.googlesource.com/c/1475448Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#635112}
-
Anthony Cui authored
Previously GVR was registered when Chrome starts at JNI_OnLoad. Moving GVR Java to the VR DFM means that this registration fails and Chrome crashes. Move the registration of GVR to RegisterJni, so that it occurs only after GVR is already loaded. Bug: 862706 Change-Id: If68fafa46859eeac62a6d4e633aa1f5519048164 Reviewed-on: https://chromium-review.googlesource.com/c/1478990Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Anthony Cui <cuianthony@google.com> Cr-Commit-Position: refs/heads/master@{#635111}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0b43037aaed9..601d898e6096 git log 0b43037aaed9..601d898e6096 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 lalitm@google.com Merge "trace_processor: don't assume prev's next_comm == next's prev_comm" Created with: gclient setdep -r src/third_party/perfetto@601d898e6096 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I6b8222cf9610b110fc73934ac6169f202b07a1fa Reviewed-on: https://chromium-review.googlesource.com/c/1486052Reviewed-by:
-
Elly Fong-Jones authored
These are being removed at the moment, but for now I'm assigning them to get them out of the unowned flags queue. TBR=slangley@chromium.org Bug: 934467, 935217 Change-Id: Ib8d84ecf3daf7ac37c8d57aa439066b863acbccd Reviewed-on: https://chromium-review.googlesource.com/c/1486371Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#635109}
-
Sigurdur Asgeirsson authored
Bug: 910288 Change-Id: I1381260a1001c236e9d65d5fb28778436268e61a Reviewed-on: https://chromium-review.googlesource.com/c/1483693Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#635108}
-
Dmitry Gozman authored
We are currently waiting for navigation commit, which is too early to immediately access document.body. We should instead wait for load event. This happens to work today because the first data chunk we process when committing navigation is big enough to construct document.body in these tests. This may not always be the case though. Bug: none Change-Id: I0025f9419e700b9eb6f472f051dc92888b4be19e Reviewed-on: https://chromium-review.googlesource.com/c/1483362Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#635107}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a006cbc1d04c..37b584a73669 git log a006cbc1d04c..37b584a73669 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 43968114+francoisbertelatschrodinger@users.noreply.github.com Fixed undefined reference to 'clock_gettime' by linking rt library (#2409) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@37b584a73669 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I86c23a7e0bf84b69598e2fc65b3c1fd1b223c8f3 Reviewed-on: https://chromium-review.googlesource.com/c/1486057Reviewed-by:
-
chuanl authored
Dynamic module, when enabled, will not be availbe until native initialization is finished. This causes an issue of showing CCT header and then hiding it right away by dynamic module on a module managed URL. By using session params, we can hide CCT header early until taken over by dynamic module. Bug: 882404 Change-Id: I57d60e70c1dc03a733e9093d235d816b3e220675 Reviewed-on: https://chromium-review.googlesource.com/c/1482463 Commit-Queue: John Lin <chuanl@google.com> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#635105}
-
Polina Bondarenko authored
Create new boolean policy to control wilco DTC. BUG=b:123926018 TEST=unit_tests/browser_tests Change-Id: Ib93830ad7ba4e9bc03d77a54fa426d64c6b09473 Reviewed-on: https://chromium-review.googlesource.com/c/1485932Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#635104}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/478d7d46f8d7..507158f88d4d git log 478d7d46f8d7..507158f88d4d --date=short --no-merges --format='%ad %ae %s' 2019-02-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader b47c816ad7e6..e2d8b1286ce3 (1 commits) Created with: gclient setdep -r src/third_party/skia@507158f88d4d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Icd33b24c1c5aac56a231dfe802602024464efde7 Reviewed-on: https://chromium-review.googlesource.com/c/1484630Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/94d5c4836101..ee9ff700224e Created with: gclient setdep -r src-internal@ee9ff700224e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibdbf8b5d91bc4d149cdadaf0f0eb8de243af344b Reviewed-on: https://chromium-review.googlesource.com/c/1484628Reviewed-by:
-
Anthony Cui authored
Modify InstallFakeModules to handle case where fake_modules is None. Refactor InstallFakeModules to use less nesting. Bug: 934370 Change-Id: I67bfa6b63330efffcdf053e1c23d371073eeefce Reviewed-on: https://chromium-review.googlesource.com/c/1480999 Commit-Queue: Anthony Cui <cuianthony@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#635101}
-
Alex Clarke authored
This reverts commit e92ad529. The underlying problem is not fixed. Original change's description: > Revert "Disable WorkerThreadTest.TestTaskExecutedBeforeThreadDeletion on Linux" > > This reverts commit 122a91af. > > Speculative revert, the underlying problem may have been fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1480462 > > Original change's description: > > Disable WorkerThreadTest.TestTaskExecutedBeforeThreadDeletion on Linux > > > > The test is flaky > > https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_platform_unittests&tests=WorkerThreadTest.TestTaskExecutedBeforeThreadDeletion > > > > Bug: 934088 > > Change-Id: I4d783da07af305a094d41f32383e16e98ca48f43 > > Reviewed-on: https://chromium-review.googlesource.com/c/1481310 > > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > > Auto-Submit: Christos Froussios <cfroussios@chromium.org> > > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#634589} > > TBR=alexclarke@chromium.org,altimin@chromium.org,cfroussios@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 934088 > Change-Id: I502e52fad830c8403d431fbe4675bb3ea9bff6c1 > Reviewed-on: https://chromium-review.googlesource.com/c/1484308 > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635052} TBR=alexclarke@chromium.org,altimin@chromium.org,cfroussios@chromium.org Change-Id: I74ddbd712d31568968cc0234c35662c219372236 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 934088 Reviewed-on: https://chromium-review.googlesource.com/c/1486332Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#635100}
-
Pavol Marko authored
If there's policy for Ethernet with Auth: None, which doesn't set any "Recommended" information, assume that IP and DNS config fields are "Recommended" so they are still editable in the UI. This is for backwards compatibility, as some users are setting e.g. Proxy through policy but want to edit IP settings on the device. This can be overriden by setting Recommended: [] and should be removed when we implement setting Recommended by default on the server (https://crbug.com/931412). Bug: 820213 Test: Manual with CL:1468501 Change-Id: Ie642a2722bd1a4506148f3352ebfb37d12a47bcc Reviewed-on: https://chromium-review.googlesource.com/c/1474650 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#635099}
-
Maks Orlovich authored
This reverts commit 90c86f0c. Justification for revert of revert: Fixed build/merged with a trunk change Bug:850044 Change-Id: Ie96c714b34aad37684692cf1a644cf15e1fae8ea Reviewed-on: https://chromium-review.googlesource.com/c/1482562Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
Adding advanced section in Manage Sync settings, with: + "Encryption" + "Google Activity Controls" + "Data from Chromium sync" Screenshot: https://screenshot.googleplex.com/kNxH9b2eZBf Bug: 914059 Change-Id: I6863362d19a6b8fdc5690b11802a5376b877b152 Reviewed-on: https://chromium-review.googlesource.com/c/1477231Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
Olivier Robin authored
The web_state will be used to access helpers that can provide custom error pages. The URL is a convenience parameter to avoid checking the error.userData every time the URL is checked. Change-Id: I091cdc5f25f25aa500d629cb27885aac97049511 Reviewed-on: https://chromium-review.googlesource.com/c/1482971 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
jonross authored
When perfoming a navigation while hidden on Android, we invalidate the LocalSurfaceId. We were however not always allocating a new id when becoming visible. Most of the time different sources generate an id: - WebContentsAndroid::OnScaleFactorChanged - WebContentsViewAndroid::OnSizeChanged - RenderWidgetHostViewAndroid::OnDidUpdateVisualPropertiesComplete - RenderWidgetHostViewAndroid::ShowInternal (for evicted frame) However it is possible to perform a naviation to the same page, while hidden, and not evicted. Which bypasses all of these. This change updates RenderWidgetHostViewAndroid::ShowInternal to also generate an id when the current one is invalid. Additionally we no longer notify DelegateFrameHostAndroid::DidNavigate when navigating while hidden. As this takes the current embedded surface to be the fallback. Since we are navigating, the current surface is not correct. Instead we will notify it after the embed from becoming visible again. TEST=NoCompositingRenderWidgetHostViewBrowserTest.ValidLocalSurfaceIdAllocationAfterHiddenNavigation BUG=931215 Change-Id: I28e4d2bf3633dd4d21c484be5fdbffeeaefc91b5 Reviewed-on: https://chromium-review.googlesource.com/c/1483364 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#635095}
-
Mikel Astiz authored
The actual logic being toggles was removed in https://chromium-review.googlesource.com/c/1349649 and the feature toggle became unused even before that, so let's clean it up. Bug: 905639 Change-Id: Iabc1d043b5d8e8a4bfcfd7586ef324a7fdae91d7 Reviewed-on: https://chromium-review.googlesource.com/c/1477836Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#635094}
-
Abhijeet Kandalkar authored
WebRemotePlaybackState is referenced only from the Blink side. This CL drop web_remote_playback_state.h from public/ and replace enum WebRemotePlaybackState with PresentationConnectionState. Bug: 919392 Change-Id: Ib1b8428b56085a23108cd5f7f7deb9094ac0ab65 Reviewed-on: https://chromium-review.googlesource.com/c/1480010Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#635093}
-
Julia Feitosa authored
Bug: 933768 Change-Id: I8778058205a5e6f6f5973cb2831292c7da985329 Reviewed-on: https://chromium-review.googlesource.com/c/1479730Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Julia Feitosa <carvalheira@google.com> Cr-Commit-Position: refs/heads/master@{#635092}
-
Thomas Tangl authored
- Linkify 'settings' instead of 'choose what to sync in settings'. - Add a period(.) at the end of the sentence. Bug: 930928 Change-Id: I1d565ce978026956db98d627d2cc12f269928c46 Reviewed-on: https://chromium-review.googlesource.com/c/1482461 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#635091}
-
