- 13 Mar, 2018 40 commits
-
-
Michael Lippautz authored
- Avoid nullptr checks when the visitor knows that it should be non-null - Avoid duplicate methods: MarkHeader and MarkHeaderNoTracing are enough represent all use cases - Style cleanups Bug: chromium:757440 Change-Id: I8f4ed806670a1d4e9967a16596b520cb8133cfc3 Reviewed-on: https://chromium-review.googlesource.com/959963Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#542799}
-
Eugene But authored
This simplifies DownloadManagerCoordinator code, which does not have to clear download task for mediator anymore. Also adding OnDownloadDestroyed to Download ManagerMediator will help with future changes related to UMA logging. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id7aaab8ddbcce5be6a9d1c408c464df0f69c54b9 Reviewed-on: https://chromium-review.googlesource.com/959707Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#542798}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5831022b..70196515 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I1bbda0c0ca4b67e83e7279819d063d6679d2e469 Reviewed-on: https://chromium-review.googlesource.com/960244Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#542797}
-
https://skia.googlesource.com/skia.git/+log/cc59c278ab0d..4ce53a6ffd3c $ git log cc59c278a..4ce53a6ff --date=short --no-merges --format='%ad %ae %s' 2018-03-13 caryclark remove paint flatten unflatten from generated docs Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I1b0ea37a7b6b81b275bce642cf57c97ba127bbda Reviewed-on: https://chromium-review.googlesource.com/960361Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542796}
-
Colin Blundell authored
Moves this service into the canonical location for services within //components. The existing code causes several presubmit warnings. This CL does not attempt to fix them. TBR=dcheng@chromium.org NOPRESUBMIT=true Change-Id: I3301416c1f7dd619d2a24d165c4fed9267b4eb77 Reviewed-on: https://chromium-review.googlesource.com/948913 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#542795}
-
Miguel Casas authored
I reverted the original CL because of a silly typo. This CL fixes it (see diff between PS1 and PS2): https://chromium-review.googlesource.com/c/chromium/src/+/957144/1..2/media/gpu/vaapi/vaapi_picture_factory.cc Original CL description ------------------------------------------------ This CL splits VaapiDrmPicture into a common part named VaapiPictureNativePixmap, and two subclasses, namely: - VaapiPictureNativePixmapOzone, containing the current #if defined(USE_OZONE) sandwiched parts, and - VaapiPixtureNativePixmapEgl with the other parts. So the class tree should look like: +-----------------+ | VaapiPicture | +-----------------+ ^ ^ | +----+ +--------------+ +------------------+ | VaapiPicture | | VaapiPictureTFP | | NativePixmap | | (existing on ToT)| +--------------+ +------------------+ ^ +---------------+ | | +-------+ +-------+ | VPNP | | VPNP | | Ozone | | Egl | +-------+ +-------+ The point here is to reduce the amount of if-defs to one single point, the VaapiPictureFactory. BUILD.gn is changed to reflect that VaapiDrmPicture is egl-specific (see bug, |use_egl| definition in [1]), while VaapiDrmPictureOzone is |use_ozone| [2] specific. Note that |use_egl| can coexist with |use_x11| [3]. This CL just moves code around, no new code introduced in either vaapi_picture*.cc. [1] https://cs.chromium.org/chromium/src/ui/gl/features.gni?q=ui/gl/features.gni&sq=package:chromium&dr&l=16 [2] https://cs.chromium.org/chromium/src/build/config/ui.gni?q=build/config/ui.gni&sq=package:chromium&dr&l=26 [3] https://cs.chromium.org/chromium/src/build/config/ui.gni?type=cs&sq=package:chromium&l=47 Bug: 785201 Change-Id: I9c1dbc2e7f6cf1fb851d0d6dffa068fad9652edd Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/951928Reviewed-by:
Julien Isorce <julien.isorce@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/957144 Cr-Commit-Position: refs/heads/master@{#542794}
-
https://webrtc.googlesource.com/src.git/+log/1288c59c352c..e61bf67b99a9 $ git log 1288c59c3..e61bf67b9 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I932b19f6b7c32116d06bc2b73623691951c22cc2 Reviewed-on: https://chromium-review.googlesource.com/960421Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542793}
-
Tarun Bansal authored
On some devices, calling SignalStrength.getLevel throws a security exception when the app does not have READ_PHONE_STATE permission available. The Android API documentation does not mention this permission as being necessary for calling the getLevel API. This CL simply catches the exception on these subset of devices. Bug: 820564 Change-Id: I8c32fd63e4e0bf9c08bed69919f7f6a541c0fae5 Reviewed-on: https://chromium-review.googlesource.com/958051Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#542792}
-
Luna Lu authored
This reverts commit fb1f63f0. Reason for revert: Suspect breaking the build https://ci.chromium.org/buildbot/chromium/Linux%20x64/60367 Original change's description: > Reland "Add Finch feature to gate Enterprise Password Protection" > > This is a reland of 063960e4 > > Original change's description: > > Add Finch feature to gate Enterprise Password Protection > > > > Also added finch experiment to fieldtrial_testing_config.json > > > > Bug: 804490,818559 > > Change-Id: I70b0bfdaf7d59ca91f27d634363221b5f3cdb403 > > Reviewed-on: https://chromium-review.googlesource.com/942308 > > Commit-Queue: Jialiu Lin <jialiul@chromium.org> > > Reviewed-by: Luke Z <lpz@chromium.org> > > Reviewed-by: Gayane Petrosyan <gayane@chromium.org> > > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#542502} > > TBR=lpz@chromium.org, dvadym@chromium.org, gayane@chromium.org > > Bug: 818559 > Change-Id: Ia7e8378b28255a61a70e65e89b50912bda5b8e7f > Reviewed-on: https://chromium-review.googlesource.com/960221 > Commit-Queue: Jialiu Lin <jialiul@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Reviewed-by: Jialiu Lin <jialiul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542786} TBR=pastarmovj@chromium.org,gayane@chromium.org,dvadym@chromium.org,jialiul@chromium.org,lpz@chromium.org Change-Id: Ie78ca40253f255e5893f108c8ddc4178514a0f50 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 818559 Reviewed-on: https://chromium-review.googlesource.com/960641Reviewed-by:
Luna Lu <loonybear@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#542791}
-
sebsg authored
The code that decides whether to offer to Upsream now checks whether Sync is in a permanent error state, like an auth error. Bug: 819727 Change-Id: I27efaaf31794b8a6921e24cbbc0d6bb5e1154d1f Reviewed-on: https://chromium-review.googlesource.com/959174Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#542790}
-
Koji Ishii authored
Following bot results are included. 4191 4192 4193 4196 221 lines were removed and 5 lines were deflaked by consecutive results since 4162. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I31c1581c2982738c55e35408c1179328e5249139 Reviewed-on: https://chromium-review.googlesource.com/958665 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#542789}
-
Ashley Enstad authored
https://chromium-review.googlesource.com/c/chromium/tools/build/+/930025 Bug: 785966 Change-Id: I3e0e501abf7d97deb95151afc3b08a94924815e0 Reviewed-on: https://chromium-review.googlesource.com/948922Reviewed-by:
Emily Hanley <eyaich@chromium.org> Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#542788}
-
Theresa authored
BUG= Change-Id: I6022bc7a09f07cd9c3d89b3558479b0c4cdea639 Reviewed-on: https://chromium-review.googlesource.com/957878Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#542787}
-
Jialiu Lin authored
This is a reland of 063960e4 Original change's description: > Add Finch feature to gate Enterprise Password Protection > > Also added finch experiment to fieldtrial_testing_config.json > > Bug: 804490,818559 > Change-Id: I70b0bfdaf7d59ca91f27d634363221b5f3cdb403 > Reviewed-on: https://chromium-review.googlesource.com/942308 > Commit-Queue: Jialiu Lin <jialiul@chromium.org> > Reviewed-by: Luke Z <lpz@chromium.org> > Reviewed-by: Gayane Petrosyan <gayane@chromium.org> > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542502} TBR=lpz@chromium.org, dvadym@chromium.org, gayane@chromium.org Bug: 818559 Change-Id: Ia7e8378b28255a61a70e65e89b50912bda5b8e7f Reviewed-on: https://chromium-review.googlesource.com/960221 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#542786}
-
https://chromium.googlesource.com/angle/angle.git/+log/64e5ed2abd8a..f0b30dd8bd2b $ git log 64e5ed2ab..f0b30dd8b --date=short --no-merges --format='%ad %ae %s' 2018-03-12 lucferron Vulkan: Enable a bunch of dEQP texture related tests 2018-03-02 oetuaho Use non-human-readable mangled names for types Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I8f87a8ff0e81ad69533a61c78cabfeeebd03060c Reviewed-on: https://chromium-review.googlesource.com/960261Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542785}
-
Tao Bai authored
don't know why it only happens for select control. Bug: 820773 Change-Id: Id036a10c8fa33792fa50023444ba68dadadbf90f Reviewed-on: https://chromium-review.googlesource.com/959447 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#542784}
-
Thomas Tangl authored
The accounts submenu positioning has to be adjusted because native combobox menus on Mac are always TOPLEFT aligned. Screenshots: https://drive.google.com/file/d/1yibhKX3giSaMrXaDXfEyQM99MAwIg2RF/view?usp=sharing https://drive.google.com/file/d/14k2wIXyL37IPSQm0jNt9zj9ePZXBXZB-/view?usp=sharing Bug: 813805 Change-Id: I04c60167f0123a320c10e579b77e834bc63a0b6f Reviewed-on: https://chromium-review.googlesource.com/959321 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#542783}
-
Elly Fong-Jones authored
This change causes AnchorViewForBrowser() to return nullptr when the MacViews browser is in Cocoa mode. This fixes the various ExtensionInstalledBubbleBrowserTest.* tests and the crash when showing this bubble in Polychrome browsers. Bug: 817408 Change-Id: I28a54fb4c4b7b30febf312d3c5d5c5608922e6cc Reviewed-on: https://chromium-review.googlesource.com/959427Reviewed-by:
Sarah Chan <spqchan@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#542782}
-
Gauthier Ambard authored
This CL fixes the presentation of the toolbar when entering and leaving the stack view. During those animations, the toolbar should represent the state of the new page, in particular when going from/to a NTP. Bug: 819826 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie1d9f7be805b267e52de9871c0fc99f3dcd21130 Reviewed-on: https://chromium-review.googlesource.com/957027Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#542781}
-
Keishi Hattori authored
blink_perf.parser query-selector-all tests regressed by around 20% when r539841 landed. This aims to improve its performance by avoiding TLS. Bug: 757440 Change-Id: Ie1b91824f2fb3d0e494501d634b4ac0cc7345a72 Reviewed-on: https://chromium-review.googlesource.com/959945Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Eric Seckler authored
Adds a paintOrder field to LayoutTreeNodes returned by DOMSnapshot.getSnapshot. The field describes the layering of nodes and their order during painting, which can help clients judge whether a node may visually affect rendering. Change-Id: Id54e0b5faed23b769e39c40af1cead9228866da1 Reviewed-on: https://chromium-review.googlesource.com/955848 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#542779}
-
https://webrtc.googlesource.com/src.git/+log/2f28c3ae6999..1288c59c352c $ git log 2f28c3ae6..1288c59c3 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2a8644b309ef41957f6180ef9c28ee2316f67741 Reviewed-on: https://chromium-review.googlesource.com/960245Reviewed-by:
-
Balazs Engedy authored
Furthermore, move it out of the device::test:: and into the device:: namespace, in preparation for being used from //content/browser to service the Web Authentication Testing API. Bug: 785955 Change-Id: I6c9112c4cec127fe77702dd5389f95fc084df9b5 Reviewed-on: https://chromium-review.googlesource.com/960008Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#542777}
-
Takuto Ikuta authored
regexp search in format_blink_cpp_source_code is slow. In this patch, I introduced simple pruning to skip time consuming regexp search. Without this patch, generate_bindings_core_v8_interfaces took 12.513s on z840 linux. With this patch, generate_bindings_core_v8_interfaces took 6.562s. Bug: 821256 Change-Id: I3de39d72f4fa8e9f4991a90bc6dd0ba90511e634 Reviewed-on: https://chromium-review.googlesource.com/958810Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@google.com> Cr-Commit-Position: refs/heads/master@{#542776}
-
Takuto Ikuta authored
This is for reducing total cpu consumption by idl_compiler, and let other parallel build tasks can utilize cpu more efficiently. If we use larger -j and modifying idl files frequently, this introduces around 10 seconds build speed regression, but in other cases, this patch has advantage because this lets other generator tasks run simultaneously at the same time. I expect this improves build speed around 20~30 seconds on linux bot and 1 minutes on win bots if the build runs idl_compiler. In buildbot, generating bindings/core/* files took more than 20 seconds (94s ~ 116s in below trace). https://chromium-build-stats.appspot.com/ninja_log/2018/03/12/swarm979-c4/ninja_log.swarm979-c4.chrome-bot.20180311-201738.14539.gz/trace.html from https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/43925 In this 22 seconds, mojom generator tasks are blocked to run. Build trace with this patch shows other tasks run somewhat simultaneously (13s ~ 41s). https://chromium-build-stats.appspot.com/ninja_log/2018/03/12/swarm979-c4/ninja_log.swarm979-c4.chrome-bot.20180311-215549.20798.gz/trace.html from https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/43949 In this 28 seconds, mojom generator tasks can run at the same time. idl_compiler tasks block other tasks around 10 seconds. * for the record With this patch, generate_bindings_core_v8_interfaces took 14.574s on Z840 Linux. Without this patch, on Linux, it took 5.115s with -j48 7.317s with -j16 13.296s with -j8 95.401s with -j1 With this patch, generate_bindings_core_v8_interfaces took 21.230s on Z840 Win10. Without this patch, on Win10, it took 9.460s with -j48 12.086s with -j16 23.497s with -j8 169.762s with -j1 Bug: 821256 Change-Id: Ic3163edfd3cfb4be375e6f24ffc7c11cc9025783 Reviewed-on: https://chromium-review.googlesource.com/958804 Commit-Queue: Takuto Ikuta <tikuta@google.com> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9cb5583e. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13804 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=leon.han@intel.com No-Export: true Change-Id: I15ef59bb5ed8820133aa4301ef0702ac2c559964 Reviewed-on: https://chromium-review.googlesource.com/960241 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#542774}
-
Robert Ma authored
In consistency with the upstream WPT behaivor, we wait for web fonts to be loaded before taking the screenshot in reftests. It is implemented by modifying the JavaScript code we already injected (to support WPT reftest-wait). In addition, the conditions for injecting the JS code are changed so that it is injected to WPT reftests instead of all WPT (see below for how we determine WPT reftests). And since we now know TestRunnerBindings::Install might be called multiple times on a frame (https://crbug.com/772386), we put the whole code segment behind a flag to prevent it from running twice. To decide if we are running a WPT reftest, we combine two conditions: 1. We are in WPT mode (is_web_platform_tests_mode). 2. We are asked to generate pixel results (i.e. '--pixel-test is appended to the test path in stdin). In the WPT suite, run-webkit-tests should only set this flag for reftests. * * Unfortunately, this was not exactly true. run-webkit-tests incorrectly set this flag for /harness-tests/wpt as well. This is a special directory outside external/wpt that is treated as WPT mode by the Blink test runner, but not run-webkit-tests. The inconsistency is fixed in this CL, so the two conditions above for WPT reftests hold. Lastly, TestExpectations is modified accordingly. The affected tests now produce the same results as on wpt.fyi (i.e. using `wpt run`). Acknowledgement: foolip@ provided invaluable help debugging! Bug: 507054 Change-Id: I05b6aad8335553ff48c8b0e8701539e7ecd71651 Reviewed-on: https://chromium-review.googlesource.com/954044 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#542773}
-
Benoit Lize authored
This CL adds a new "extraCallback()" callback to notify a client that the warmup() sequence is done. It also converts tests to this method, vs the previous custom callback runnable, and cleans up a tiny bit some tests. Bug: 816837 Change-Id: I8a5f432839be8d0394b03afb6d3ad587adbda6eb Reviewed-on: https://chromium-review.googlesource.com/957736 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#542772}
-
Peter E Conn authored
Origin unfortunately requires native to be loaded to use. Make sure native is loaded for tests that use it. Bug: 821156 Change-Id: Ibbf79976d49e2b0beb839034d1852b3699bfbcab Reviewed-on: https://chromium-review.googlesource.com/960022Reviewed-by:
-
Eric Boren authored
Bug: skia:7685 Change-Id: I8285262ed95306559b979aa13cbfa6437e48c9a3 Reviewed-on: https://chromium-review.googlesource.com/951503Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Eric Boren <borenet@chromium.org> Cr-Commit-Position: refs/heads/master@{#542770}
-
Morten Stenshorne authored
If clear is specified on an element whose first piece of content is inside a child (so that the element's BFC offset cannot be determined at the beginning of layout), we need this child to know about the clearance offset on the parent, or it will not be pushed below adjacent floats as it should. Just pushing the parent, but leaving the children unaffected by clearance won't do. We need this in order to be able to lay out in a single pass (and apply clearance when we detect it, rather than doing it on the element with 'clear' and relayout the children if something moved). Since a constraint space's clearance offset is now "inherited" down the tree, as long as we're within the same block formatting context, we now also need to propagate the "is pushed by floats" flag upwards, or we won't detect class C break points correctly. Without this the unit test ClassCBreakPointBeforeBlockMarginCollapsing in NGColumnLayoutAlgorithmTest would regress, because it would incorrectly detect a class C break point before the break-inside:avoid block. We must make sure that class C break points are only detected on the outermost block that got pushed by floats, because it's there that we'll get the gap between the inner edge of the container and the outer edge of the child. Added some tests. One of them fails in legacy (but not in NG). One of the tests, clear-on-child-with-margins.html, passes both with and without this code change, but I started to wonder if we'd suddenly could end up pulling the parent of the box with 'clear' downwards, so thought I better add it, to make sure we don't regress in this regard. The test NoClassCBreakPointBeforeBfc in NGColumnLayoutAlgorithmTest no longer needs its workaround, because the display:flow-root child of #container now sets its position correctly (past the float) right away. Acid2 also looks slightly better now! Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I732b19398bd43b9874f6bb8c57ce435d1c510754 Reviewed-on: https://chromium-review.googlesource.com/957045 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#542769}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/21cb7e30..5831022b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I325d1ef62b02fca2e8dba7cba40f127b722e0739 Reviewed-on: https://chromium-review.googlesource.com/959822Reviewed-by:
-
Daniel Bratell authored
In jumbo builds, many files share the same anonymous namespace so having a file local symbol name might still clash with other files having the same file local name. This patch renames a couple of g_delegate variables that caused clashes in some (non-default) jumbo configurations. Bug: 746957 Change-Id: I732d7223be88d4871a4ae7294377bc558a2ac2ca Reviewed-on: https://chromium-review.googlesource.com/957727Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#542767}
-
Ramin Halavati authored
Network traffic annotation of direct, settings, and headless proxies are updated. Bug: 656607 Change-Id: I8513c05e7cda77aa62bb2cd85c90afb316996a90 Reviewed-on: https://chromium-review.googlesource.com/958504 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
https://webrtc.googlesource.com/src.git/+log/207a75d8f3fa..2f28c3ae6999 $ git log 207a75d8f..2f28c3ae6 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I38253408c26eaeba793db7520f67711d42a37166 Reviewed-on: https://chromium-review.googlesource.com/959902Reviewed-by:
-
Pavol Marko authored
Add a PRESUBMIT check for policy_templates.json which generates an error when the default_for_enterprise_users flag is used with a policy that is marked 'device_only': True. Also introduce doc_default_for_managed_devices to be able to document a (manually implemented) special default value for device policies on managed devices. There's also a PRESUBMIT checking that doc_default_for_managed_devices is not used with a 'device_only': False policy. Bug: 809653 Change-Id: I06a9a7a23998d918b252ad3718a279804d4adaa8 Reviewed-on: https://chromium-review.googlesource.com/926324Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#542764}
-
Alan Cutter authored
This CL implements a title bar animation for hosted apps on chromeOS that shows the URL's origin for a few seconds when the window opens. This CL omits the menu button highlight animation as that will be implemented in a follow up CL. See bug for screencasts. Bug: 809794 Change-Id: Ied16c5720722f994fa73cafd15c2f42e3d671e50 Reviewed-on: https://chromium-review.googlesource.com/942722 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#542763}
-
David Roger authored
This function is called by the settings page even when the user is not signed-in. The DCHECK can be removed, because it was not actually necessary. Bug: 820083 Change-Id: I910e1b22acf99a2c3d755523569a67c2ef252dfa Reviewed-on: https://chromium-review.googlesource.com/957184Reviewed-by:
-
Han Leon authored
[ServiceWorker] Remove |source_origin| parameter of ServiceWorkerObjectHost.PostMessageToServiceWorker() This CL lets browser-side get the source origin of the posted message correctly by itself rather than relying on the |source_origin| passed from renderer-side. This is for security consideration, because browser-side can not trust renderer-side to tell the truth. BUG=772713 Change-Id: Ifd8d92a6bb150de245feb6a4ef7f0efb73c28119 Reviewed-on: https://chromium-review.googlesource.com/954983 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#542761}
-
Jialiu Lin authored
This reverts commit 063960e4. Reason for revert: Breaking waterfall builds Original change's description: > Add Finch feature to gate Enterprise Password Protection > > Also added finch experiment to fieldtrial_testing_config.json > > Bug: 804490,818559 > Change-Id: I70b0bfdaf7d59ca91f27d634363221b5f3cdb403 > Reviewed-on: https://chromium-review.googlesource.com/942308 > Commit-Queue: Jialiu Lin <jialiul@chromium.org> > Reviewed-by: Luke Z <lpz@chromium.org> > Reviewed-by: Gayane Petrosyan <gayane@chromium.org> > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542502} TBR=gayane@chromium.org,dvadym@chromium.org,jialiul@chromium.org,lpz@chromium.org Change-Id: Iaf5149ca999a951775bdd4b90282e31ee8507469 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 804490, 818559 Reviewed-on: https://chromium-review.googlesource.com/960201Reviewed-by:
-
