GitLab

https://chromium.googlesource.com/chromiumos/chromite.git/+log/889ec0706417..53cfcd3219c1


git log 889ec0706417..53cfcd3219c1 --date=short --no-merges --format='%ad %ae %s'
2019-06-12 dburger@chromium.org Add moblab-generic-vm-postsubmit to list of ignoreds for skew check.


Created with:
  gclient setdep -r src/third_party/chromite@53cfcd3219c1

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Change-Id: I344c6ef63e8795a98347fd9e3f1a652e8a40b278
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655973Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#668471}

Fix a bug that with "new popup ui" flag but without the DSE favicons
flag, the omnibox loads a favicon if it's available. It should fall
back to the search loupe icon.

Bug: 973366
Change-Id: Id27dcb737f161c1047d8bebd2e1a6baf2abe87de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655473
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#668470}

https://webrtc.googlesource.com/src.git/+log/e794243650a0..08fa95371129


git log e794243650a0..08fa95371129 --date=short --no-merges --format='%ad %ae %s'
2019-06-12 danilchap@webrtc.org Reland "Delete TestAudioDeviceModule factory which uses GlobalTaskQueueFactory"
2019-06-12 ssilkin@webrtc.org Create rate allocator after codec bitrates are set.
2019-06-12 sprang@webrtc.org Add new RtpPacketPacer interface, with callback.


Created with:
  gclient setdep -r src/third_party/webrtc@08fa95371129

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:none
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I78811a022c490a6d48f5e02fca867dd10bec7fec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654978Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#668469}

The img tag for the regulatory info contains role="presentation" which
makes the screen reader skip the alt tag. This tag was originally added
because the a11y tests were failing
(https://chromium-review.googlesource.com/c/chromium/src/+/1345127).

The original issue of test failures was actually because regulatory
info is asynchronously filled in, so when the page is loaded,
regulatoryInfo_.text which is used as the alt tag is empty. This makes
the a11y tests fail since it expects a non empty string as the value.

This change fixes the tests by setting the regulatory info text through
the fake browser proxy, and removes the role="presentation" tag since
it's not needed anymore to make the tests pass.

BUG=950842

Change-Id: I136456fab06c15b9d13f0d7827f251062d242c25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653085Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: May Lippert <maybelle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668468}

This will make sure everything underneath is completely occluded, so
nothing gets drawn.

Test: manual
Bug: 961549
Change-Id: I5124f8ffcee607964b8460f7214d962092a2e697
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642370Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668467}

This reverts commit ecb3164a.

Reason for revert: Accidental no-try submission of the original revert! Reverting to be safe.

Original change's description:
> Revert "Use AddLocalizedStringsBulk() on version_ui to reduce code size."
> 
> This reverts commit 7d8834bd.
> 
> Reason for revert: Crash in ui::ReplaceTemplateExpressions (crbug.com/972995)
> 
> Original change's description:
> > Use AddLocalizedStringsBulk() on version_ui to reduce code size.
> > 
> > Refactored to use AddLocalizedStringsBulk() instead of
> > source->AddLocalizedString() to reduce code size and separated
> > data strings from localized strings.
> > Follow up of changes https://crrev.com/c/1591712 and
> > https://crrev.com/c/1628757
> > 
> > Bug: 957201
> > Change-Id: I9f9e01468ac8eedfbaf035b03f9bacbd7e4efcf2
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630467
> > Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
> > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#667625}
> 
> TBR=droger@chromium.org,thestig@chromium.org,michaelpg@chromium.org
> 
> Change-Id: I7cfd452ad6176d657cfddfe1de78585e6c98a33b
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 957201,972995
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653313
> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#668465}

TBR=droger@chromium.org,thestig@chromium.org,michaelpg@chromium.org,henrique.ramos.limas@gmail.com

Change-Id: Iebf60be5f684a8576dfbada96005b9184956fe42
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 957201, 972995
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656030Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668466}

This reverts commit 7d8834bd.

Reason for revert: Crash in ui::ReplaceTemplateExpressions (crbug.com/972995)

Original change's description:
> Use AddLocalizedStringsBulk() on version_ui to reduce code size.
> 
> Refactored to use AddLocalizedStringsBulk() instead of
> source->AddLocalizedString() to reduce code size and separated
> data strings from localized strings.
> Follow up of changes https://crrev.com/c/1591712 and
> https://crrev.com/c/1628757
> 
> Bug: 957201
> Change-Id: I9f9e01468ac8eedfbaf035b03f9bacbd7e4efcf2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630467
> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#667625}

TBR=droger@chromium.org,thestig@chromium.org,michaelpg@chromium.org

Change-Id: I7cfd452ad6176d657cfddfe1de78585e6c98a33b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 957201,972995
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653313Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668465}

- Over 46kB of resources not used on Android
- webui/favicon_source previously compiled but never used
- Remove webui/favicon_source from Android builds

TBR: trivial unit test change
Bug: 799078
Change-Id: I91a99f893d2f9503f5baaeaf199d51d475241916
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651114
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668464}

This reverts commit 98846b50.

Reason for revert: Appears to have broken android-cronet-asan-arm-rel.

Original change's description:
> Update asan_device_setup.sh to r351636.
> 
> Improves support for running 32-bit binaries on the N5Xs, at least.
> 
> Bug: 790202
> Change-Id: I2a870d3b5a1e88992d8908358e21f159d1740fce
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648665
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Commit-Queue: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#667692}

TBR=martiniss@chromium.org,rspier@google.com,bpastene@chromium.org,jbudorick@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 790202
Change-Id: I9bc4e05b818ec56b0255d3debfbb5c666958ee4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655989Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668463}

This CL is adding code to detect when GDI Handles (HFONT)
are going to high because too many gfx::Font exists.

There is a plan to fix the incorrect uses of gfx::Font
and these dump will help tracking the source of these leaks.

Bug: 972689
Change-Id: I326938c3751766e01b3c318b5397ef8f4d4f9ae9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648398Reviewed-by: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668462}

Bug: 970224

Change-Id: I4a12a8fd723399db7d12b62f33f62d7ec25c3ca5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654688Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668461}

It has launched to M75:
https://chromiumdash.appspot.com/commit/31293e8ee41e25575ff9fafdaac23554851c9fcf

Bug: 906494

Change-Id: I26ac098f53cf57267990429d6b1fa9d2a7ed9f6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653418Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668460}

This is already enabled on Chrome for Android. This CL also enables
it on WebView.

Changes:
- Check IsPerOriginProvisioningSupported() instead of checking persistent
  license support in both MediaDrmBridgeFactory and MediaDrmBridge.
- Register cdm::MediaDrmStorageImpl in WebView's PrefService (provided by
  AwBrowserContext). Also mark it to be persistent across runs in
  kPersistentPrefsWhitelist. Persistence is preferred here to avoid
  having to provisioning MediaDrm frequently.
- Hook up CreateMediaDrmStorage() for WebView, using the PrefService
  provided by AwBrowserContext. Note that the returned origin IDs are
  not provisioned. MediaDrmBridge in the GPU process will trigger the
  provisioning process.
- Add logs.

Tested with Shaka player demo and made sure per-origin provisioning is
used. Test log is at go/eme-webview-test-log.

Bug: 493521,947286
Test: See above.
Change-Id: Ie260b917571f37712ff223030567709b8f97bf31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588518
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668459}

The recorder is created in constructor, so only scenario that I can
think of is that resizer is destroyed during SetBounds.

I also added CHECK to catch the scenario where the resizer is destroyed
during resize for other reasons. I'll remove the code once fix is confirmed.

Bug: 970911
Test: None. Repro step is unknown and this is speculative fix.
Change-Id: I58e20fe916664867b776d36b7720a2a2fb5ee357
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655968Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668458}

The reordering gesture must be canceled when closing all tabs in the
tab switcher.

Bug: 961045
Change-Id: I595761b90e9bf896668922c36a9933446b846c65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654409Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Auto-Submit: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668457}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/602da62c..ece78714

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I8435a21b7bf1d56a62d6a02a4cf3bdc5930a8d08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655037Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#668456}

This CL makes SkiaOutputSurfaceImpl use Skia's YUV readback API instead
of doing an RGB readback and a conversion afterwards. This CL also adds
a feature to always use Skia's API for readback instead of
GLRendererCopier, which is useful for testing Skia's GL readback and
doing finch trials later on.

Bug: 898595
Change-Id: I493edc8f2a406f0b015b1dfa580d41c97a088f34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643501
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668455}

The exit_on_context_loss GPU driver bug workaround shouldn't be applied
when the GPU process is already exiting since it can trigger a
use-after-free.

Bug: 971904
Change-Id: I775c9fd29b1f9bdb71c28f0cb428951718001973
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655340
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668454}

Bug: 968217
Change-Id: I97f4470edcf170a94e084ab208046be2024633b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646973Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668453}

Remove WallpaperUserInfo (see PS1 for use of UserInfo instead).
Pass AccountIds to WallpaperController instead of structs.
Encapsulate lookup of the user type and ephemeral flag.

Remove now-unused ephemeral flag from OnlineWallpaperParams.
Remove InitializeUser test helper and inline Clear* as needed.
Add optional user type argument to SimulateUserLogin.

Bug: 958227
Test: No wallpaper regressions.
Change-Id: I768e6ac748faa008f7947839d56c2ce7e75be1bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648749Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Auto-Submit: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668452}

These resources will not be available at runtime according to
crbug.com/948234.

TBR: jdemeulenaere
Bug: 948234, 973431
Change-Id: Ib4bdf649ef8cee0821469154845d746f55435c42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656009
Commit-Queue: Sam Maier <smaier@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Auto-Submit: Sam Maier <smaier@chromium.org>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668451}

This is to diagnose a bug.

NOTE: Will be reverted after releasing it on Canary once.

Binary-Size: Temporary increase due to adding strings to diagnose a bug. Will be reverted afer ~1 Canary.
Bug: 971424
Change-Id: I5ddadeaafb8645b9fd83d7fdc2d88caa1780881a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655532
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668450}

https://dawn.googlesource.com/dawn.git/+log/3e51fada2912..17738b6d8c4f


git log 3e51fada2912..17738b6d8c4f --date=short --no-merges --format='%ad %ae %s'
2019-06-12 jiawei.shao@intel.com Fix wrong computation of texture copy buffer size


Created with:
  gclient setdep -r src/third_party/dawn@17738b6d8c4f

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
TBR=cwallez@google.com

Change-Id: Id5930427a2609c68efe8b551436a494663d79698
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655041Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#668449}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2875b88d0b00..9b2fc666bf9c


Created with:
  gclient setdep -r src-internal@9b2fc666bf9c

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=haraken@google.com,tangltom@google.com,flackr@google.com

Change-Id: I972cf28c1bdbedb216c74bb1a5e660dbe090ee64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655047Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#668448}

I2S: https://groups.google.com/a/chromium.org/d/msg/blink-dev/rZOaOONFCNI/4IZTJBYMCAAJ

Bug: 904351
Change-Id: I461472c4b3b5d9711684edfd6460fdfac9eaaea8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647008Reviewed-by: Luna Lu <loonybear@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668447}

This is follow-up to the launch of the PIN UI in M75 and contains
changes requested by accessibility:
  ∙ There is now a show/hide PINs icon, as found in the passwords UI,
    which makes the PIN visible. (This helps screen readers.)
  ∙ The button to set the PIN is now always enabled and errors are only
    surfaced when the user attempts that action. (Previously the button
    was only enabled when the dialog was in a valid state.)

Change-Id: I6d47900681cc04369e0c9ccb9edb10884eab5557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641764
Auto-Submit: Adam Langley <agl@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668446}

https://skia.googlesource.com/skia.git/+log/698fa78b3cae..d62d406aa24c


git log 698fa78b3cae..d62d406aa24c --date=short --no-merges --format='%ad %ae %s'
2019-06-12 reed@google.com Revert "Revert "try resolver pattern""


Created with:
  gclient setdep -r src/third_party/skia@d62d406aa24c

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=herb@google.com

Change-Id: Idd5e849543b79b2a6fbdd52bb9f3ec204a7a4491
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655045Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#668445}

Includes persistent=true to the manifest to allow for a
lower oom_adj score when running the browser instance
on Android Things so low memory killer doesn't
incorrectly tear down required processes when under
memory pressure.

Bug: internal
Change-Id: I34e04f8d4485c613fef3187a6e305e17b9e51855
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653652
Commit-Queue: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Auto-Submit: Brett Kilty <brettk@google.com>
Cr-Commit-Position: refs/heads/master@{#668444}

I have no idea what I'm doing (I'm not sure how to test this change),
please review this carefully :)

See the discussion at [1] for more context.

Chromium documentation claims that LeakSanitizer runs on all ASan trybots [2],
but I have been unable to replicate this behavior myself.

To test, I created a CL (https://crrev.com/c/1550630/4) that intentionally
leaks memory inside of a test. None of the trybots, including the ASan
trybot, were able to find the leak.

In contrast, a similar test that had a gtest expectation failure
(https://crrev.com/c/1588945/1) and another test that had a
use-after-free bug (https://crrev.com/c/1588858/1) were both
successfully caught by the ASan trybot.

Despite the inability to catch leaks using trybots, I was able to catch
the leak locally on my workstation by following the instructions in [2].

I noticed that the trybot test was built with 'is_lsan=true' and
'is_asan=true' [3].  However, the runtime ASAN_OPTIONS listed in [4] do
not include 'detect_leaks=1' as required by the documentation [2].

I found that running locally without the 'detect_leaks=1' in
ASAN_OPTIONS, my leak test passed (that is, the leak wasn't caught).

The src/testing/test_env.py script appears to add 'detect_leaks=1' to
ASAN_OPTIONS if the script is passed the '--lsan' flag [5][6].

However, the script that calls test_env.py, tools/mb/mb.py, doesn't seem
to ever pass this flag [7] -- that is what this CL attempts to fix.

[1]
https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/UEnRGM43MYE/3LnWa4k5BwAJ

[2]
https://www.chromium.org/developers/testing/leaksanitizer

[3]
https://ci.chromium.org/p/chromium/builders/try/linux_chromium_asan_rel_ng/264888

[4]
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8914804258249981008/+/steps/cronet_tests__with_patch_/0/stdout

[5]
https://cs.chromium.org/chromium/src/testing/test_env.py?l=95&rcl=fba6691ffca770dd0c916418601b9c9c019a2929

[6]
https://cs.chromium.org/chromium/src/testing/test_env.py?l=294&rcl=fba6691ffca770dd0c916418601b9c9c019a2929

[7]
https://cs.chromium.org/chromium/src/tools/mb/mb.py?l=1229&rcl=57ddea756f68c9d95dcdec9e02b86fd1f5860b60

Bug: 948939
Change-Id: I7237e76aad395271ddc2403612a62aaaa18ae0f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590404Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668443}

This CL allows for a payments request to include a FIDO assertion response instead of a CVC to unmask a credit card.

Bug: 949269
Change-Id: Icdae1023f8b9f3eac1e6e19b595990229a3f9236
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623920Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#668442}

Bug: 972687
Change-Id: I2fa46c1c503d3e6a319343eabf36bc74859e825d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650296
Commit-Queue: Kristyn Hamasaki <khamasaki@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668441}

This fixes multi line elision for text that contains newline
characters. This had the following two issues:

1) RenderText::Elide renders the given text on a single line.
This is fixed by only passing in a single line when eliding the text in
RenderText::UpdateDisplayText.

2) The HarfBuzzLineBreaker keeps track of the min and max ascent.
This needs to ignore newline characters in multiline modes as they are
not drawn.

Bug: 972997
Change-Id: Ie7f6d84d61000595eaa53a660caff7b98b0fb17c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649778
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668440}

https://swiftshader.googlesource.com/SwiftShader.git/+log/b8260a8e915d..6dd5f3358713


git log b8260a8e915d..6dd5f3358713 --date=short --no-merges --format='%ad %ae %s'
2019-06-12 chrisforbes@google.com Fix Android build


Created with:
  gclient setdep -r src/third_party/swiftshader@6dd5f3358713

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Change-Id: I3225509394b7188c9277986834237b620e5cfce9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655042Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#668439}

This CL adds Open in Chrome feature in Share extension.
It also refactor the command system from the notification
center extension in ios/chrome/common so they can be
in share extension.

Bug: 972076
Change-Id: If5d0592e2dd72a396958a496f0f7250a2481829c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643534
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668438}

https://chromium.googlesource.com/catapult.git/+log/1750292dc4b6..b64faff265e8


git log 1750292dc4b6..b64faff265e8 --date=short --no-merges --format='%ad %ae %s'
2019-06-12 khokhlov@google.com Make StoryRun manage its own artifacts


Created with:
  gclient setdep -r src/third_party/catapult@b64faff265e8

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:972025
TBR=simonhatch@google.com

Change-Id: I75bbaf01b3a03472b93ce0688070f18aea205f00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655043Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#668437}

The previous "extra field" VisitedLinkColor did not follow the pattern
of having custom getter/setter in order to put them in the a private
segment. This CL changes that to align with the other -color properties.

Note that the "elif header" change in the .tmpl fixes a bug in the code
generation where Apply*-functions could be incorrectly _declared_ in the
.cc file, when it shouldn't have appeared there at all.

Bug: 972388
Change-Id: I411b61eef7ad2a6cd9a61439351ddb7b09a28c97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651813
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668436}

Currently, it is possible to spoof the URL of a site by starting a
navigation in the main frame and having a cross-site iframe initiating
another navigation in its parent frame (with extra steps for it to be
user visible).

This can also be used to cancel any browser initiated navigation in the
main frame.

The CL adresses the issue by adding checks similar to what exists in
BeginNavigation on the FrameProxy::OpenURL path.

Bug: 966914
Change-Id: If547c2ef4b30b2e0323141005583412c12bfef8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643191Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668435}

This fixes a longstanding issue where guest mode users cannot change
the browser's preferred language list.

The main profile in guest mode is an off-the-record/incognito profile.
This CL from 2.5 years ago https://codereview.chromium.org/2499093002
changed the settingsPrivate API in guest mode to use the backing
("recording") profile instead of the main incognito profile for pref
writes. The languages UI continued to function because the incognito
profile's preferences were "overlaid" onto the recording profile prefs.

By default, all prefs were overlaid, except for a block-list. That
block-list was changed to a whitelist, and the whitelisted prefs
were gradually removed. This CL removed the language prefs from the
list:
https://chromium-review.googlesource.com/c/chromium/src/+/1174118/
which made the guest mode language section stop working.

For guest mode we want to use the incognito pref store where possible.
The incognito pref store is in-memory. The backing user profile is
deleted after logout (it is on a tmpfs) but it's better to just avoid
writing the prefs.

Change the BCKSFactories to prefer the incognito profile. Return null
services in tests because unit tests with TestingProfile generally
don't need these services.

Bug: 887383
Test: added to browser_tests, manual test in guest mode on eve

Change-Id: Ib4bbe45662b13aa3b733eaddc4342de5b68086b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653748
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668434}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/286660f0dde0..889ec0706417


git log 286660f0dde0..889ec0706417 --date=short --no-merges --format='%ad %ae %s'
2019-06-12 saklein@chromium.org BinhostService: Fix prebuilts path fetch.


Created with:
  gclient setdep -r src/third_party/chromite@889ec0706417

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Change-Id: I06bf84c08a4878aad73e4fece6fe9959a9736fe4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655046Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#668433}

This cl is part of the effort to use CoreAccountId instead of std::string
to denote account_id. The virtual functions of this class has been refactored
as part of another cl.

Bug: 959157
Change-Id: Ia73f41bcbb9bc1d4a8bfe1e57337e0d77be8dbf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649550
Commit-Queue: Tanmoy Mollik <triploblastic@google.com>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668432}