- 06 Dec, 2020 12 commits
-
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607201953-b2b7a443b02ef7212492f7bec00cc4818a742d69.profdata to chrome-win64-master-1607212443-2da7b3f6840c7ce2903e99dd840e51f484764ec7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9735af010b7813cf2d9b7506c328d140db01d492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576482Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834058}
-
Kartik Hegde authored
This reverts commit d5e51b0e. Reason for revert: Fix MSan issue The following on the original CL caused an MSan issue: `const GURL& url = media_hostnames_.back(); media_hostnames_.pop_back();` A reference to the URL is taken and then immediately after the URL is deleted. The fix removes access to the deleted memory. Original change's description: > Revert "network_diagnostics: Add VideoConferencing routine" > > This reverts commit 2f0a1300. > > Reason for revert: VideoConferencingRoutineTest fails on MSan bot due to use-of-uninitialized-value: > https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21568 > > Original change's description: > > network_diagnostics: Add VideoConferencing routine > > > > Tests for successful UDP and TCP connections to a STUN server and > > whether several Google media hostnames are reachable. > > > > BUG=b/172994051 > > TEST=unit_tests --gtest_filter=VideoConferencingRoutineTest.* > > > > Change-Id: I64d2784c3b3ae111c9e924b1296a5463dcb7cea2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535997 > > Commit-Queue: Kartik Hegde <khegde@chromium.org> > > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > > Reviewed-by: Hugo Benichi <hugobenichi@google.com> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#833465} > > TBR=stevenjb@chromium.org,dcheng@chromium.org,hugobenichi@google.com,khegde@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: I6d4f020371052227ab20ab45c3ffe85bb6f57310 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: b/172994051 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573557 > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> > Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833611} TBR=stevenjb@chromium.org,dcheng@chromium.org,ksakamoto@chromium.org,hugobenichi@google.com,khegde@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because this is a reland. Bug: b/172994051 Change-Id: Iaf12c4be3e9776188c545b2a792557bb9549edf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575365Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kartik Hegde <khegde@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#834057}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/952584d5b9bb..bf6e20b17e48 2020-12-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifdf5ecd783644f589cd16335ffb825c601d88779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576485Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Idb5238e67ed1145d8c3afb462f457bd84d608efb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575011Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834055}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I502f07f6cfabcdb164375f0a3ceb01b2a9e051ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575847Reviewed-by:
-
Kyle Horimoto authored
If Phone Hub notification access is prohibited due to the user having a work profile on their phone, disable the toggle and show a (?) icon with a tooltip explaining why the toggle is disabled. Note that currently, the prohibited value is never passed; a follow-up CL passes this value when appropriate. Screenshot: http://go/chrome-ss/c999f0fb3f14985d9eef8b59bd8c1cb0e09f6282 Bug: 1155151, 1106937 Change-Id: I3062f37731d5b21fecc8a1da642d0d0e4b5e97d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575423 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#834053}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607188490-01893ccb74f7e9cad0b1c9d01df378ae016644d8.profdata to chrome-linux-master-1607212443-4f55413e7f0a00392e94ff2d89d38e0836b7dc85.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Icda0af99b5154ed08432257c23f1ed723be11974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576481Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607188490-e2abda13ddf90d5b8d192d7422e940065dd9a9d4.profdata to chrome-win64-master-1607201953-b2b7a443b02ef7212492f7bec00cc4818a742d69.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I79e3a310fd8f8bc48ab64a87a736ca623a5269c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576103Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607188490-ce7b02b4e02b77e7f75110583023cf555cf2eef0.profdata to chrome-mac-master-1607212443-566f174f3f06644fe189c59ee7d3f2305744b3d5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9b715bad08dcfec2aca7a1931fa5adec8aa6b64b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576480Reviewed-by:
-
Kyle Horimoto authored
This CL adds support for a new state in the notification access opt-in flow which displays an error when notification access is prohibited due to a work profile on the user's phone. This new state (NOTIFICATION_ACCESS_PROHIBITED) is not actually passed to the settings app yet, but a follow-up CL provides this value when appropriate. Screenshot: http://go/chrome-ss/2d53bf170afdbdbcc73d341c1e2fe774bfa30391 Bug: 1155151, 1106937 Change-Id: I00e852fc7b7c4281340fe7c8d02bcc6619f8862c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573887 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f36e874ade1d..7c84426d2abe 2020-12-05 capn@google.com Remove stlport C++11 extensions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I2d3e95eb3bca8a3ea2057ebee777b018032665f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576087Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e6a623392d60..e602c60a2b59 2020-12-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I1f494f5bfdccb359e40ceb5d8e9e9b69210dab7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576339Reviewed-by:
-
- 05 Dec, 2020 28 commits
-
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1607147157-aa03f5071526bec501a925219d4b546c82550b2e.profdata to chrome-win32-master-1607188490-0683b8def32d9e9e1371f360a091c73b91ba0b4c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I30c240e721f25e1340bd169c8d8ab682f36280a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576461Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607179152-5b4699a702547a5be32091b1b306083e2a5d86b6.profdata to chrome-win64-master-1607188490-e2abda13ddf90d5b8d192d7422e940065dd9a9d4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3e9993650583fb1451668b2f9bb37ab2a1844da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576463Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/36207e820037..c3cb170d73a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Icb5b5e4f2721f2d3b396872c6fa15d3d16b970a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576471Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834044}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/30f45a6f043f..e05f7b914762 2020-12-05 kmoon@chromium.org Manually roll build and tools/memory 2020-12-05 tsepez@chromium.org Fix SEGV in chrome under XFA for xfa_node_caption.pdf 2020-12-05 kmoon@chromium.org Roll third_party/zlib/ e84c9a3fd..c29ee8c9c (3 commits) 2020-12-05 kmoon@chromium.org Roll v8/ e05d24f98..61f3e6140 (403 commits) 2020-12-05 kmoon@chromium.org Roll third_party/skia/ 1ce8964db..ae95077db (317 commits) 2020-12-05 kmoon@chromium.org Roll third_party/icu/ 7db579a73..6a33b647c (4 commits) 2020-12-05 kmoon@chromium.org Roll tools/clang/ c72342ce9..9ec0bb322 (13 commits) 2020-12-05 kmoon@chromium.org Roll third_party/freetype/src/ 32b14552d..8cc4d0dc3 (5 commits) 2020-12-05 kmoon@chromium.org Roll third_party/depot_tools/ da73999f7..18f45d287 (51 commits; 16 trivial rolls) 2020-12-04 tsepez@chromium.org Fix some grammar in cjx_node.cpp 2020-12-04 kmoon@chromium.org Roll third_party/android_ndk/ 85c22b30b..27c0a8d09 (0 commit) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I77deada861e6597f006fd6417e5e9f49a0c350c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576468Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d9042e3e6082..36207e820037 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ia4a2b7093fb84d3ca8a26d6a8608241879a2d64f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576464Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c532048062be..d63d562d1b26 2020-12-05 stha09@googlemail.com IWYU: include string.h for memcpy If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I8dcc179611e208d79c481f20945b917301075f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576465Reviewed-by:
-
Liquan (Max) Gu authored
This CL clean-up the files according to Android Studio's cleanup advise. This CL does not cause any behavioural changes. Bug: 1155582 Change-Id: Ia5d63a43e867744ee6f25f90e0cff0007e1a0fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575756 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#834040}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ifb5a65ab5639e989364a7efab35238e56fa51b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576419Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834039}
-
Stephan Hartmann authored
Bug: None Change-Id: Iba75af392d248846b1d86b21b5ff4b45dce2e054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575120Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#834038}
-
Chris Mumford authored
mojo_blob_storage_context() and native_file_system_context() are only used by IndexedDBDispatcherHost. Making them private to simplify the interface. Bug: none Change-Id: I7647d6c8301e7ccce9e60d0ea363202ed8e80d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575897Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#834037}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607166734-69b9a909cc2088c22879c6c9e7f8fd519f4237d8.profdata to chrome-mac-master-1607188490-ce7b02b4e02b77e7f75110583023cf555cf2eef0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2cc0a04e30b45e4424430f905c1212df20cbd4cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575347Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607166734-e9365668558fc300c935cf3532da06f65c9b06bd.profdata to chrome-linux-master-1607188490-01893ccb74f7e9cad0b1c9d01df378ae016644d8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3cf440eccabb08966c5400cd7b14862429700710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576375Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607158109-cb59c5163bb73c4e3a2267188e86d32f6337beac.profdata to chrome-win64-master-1607179152-5b4699a702547a5be32091b1b306083e2a5d86b6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I19ecbc86272322c648fe3106301d46a965bf2ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576364Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e0dee01043d1..f326e4faef66 2020-12-05 michaelludwig@google.com Remove SkCanvas::LayerIter used in SkCanvasStateUtils If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: Icc93dce6cd752b73a8e970dc69bc286b378a4a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576367Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I7e6298d7283364ae2d1a132b008b0da5624390af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576356Reviewed-by:
-
Wez authored
This reverts commit f3dce521. Reason for revert: We have no urgent need for this feature so removing it in favour of introducing a caller (vs system) controlled API. Original change's description: > [fuchsia] Allow system config to request Android-ish user agent OS. > > Allow WebEngine to be configured to report an Android-like UserAgent > via the system-provided config-data, to allow it to be fetch the right > form of content for the device form-factor. > > This will likely be replaced with options to configure the Client Hints > reported, on a per-instance basis, once those are standardized. > > Bug: b/171582703, 1010256 > Change-Id: I9db408be09ec9b9a78facc7b078d635b96c3637b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522071 > Commit-Queue: Wez <wez@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Auto-Submit: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825042} Bug: b/171582703 Bug: 1010256 Change-Id: If513affc89195fb78eafb1e9160e583b41708f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574976 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#834031}
-
David Dorwin authored
Previously, the string positions were calculated then used to replace parts of the string left to right, which produced the wrong string when code was added earlier in the file causing the messages to be logged from a four-digit line number in frame_impl.cc. (It would have also failed had the function been moved to the beginning of the file and had a two-digit line number.) Bug: 1136681 Change-Id: Ia5e9a7f11a676d8fc538a19322274ae66e47d9a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573198 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#834030}
-
Liquan (Max) Gu authored
PaymentRequestUi is the details of PaymentUiService and so CPRService should not have access to it. This CL hides PaymentRequestUi from CPRService. After the CL, CPRService uses it by the proxy of PaymentUiService. For the methods that have been moved into PaymentUiService, this CL adds the null-check in them. Bug: 1155582 Change-Id: Iaf5a8624232226c5c9c6fe29c411e377f10e8735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574777 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607147157-7253fb93519f47883631135ae2487e5bf63d1c0b.profdata to chrome-win64-master-1607158109-cb59c5163bb73c4e3a2267188e86d32f6337beac.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib96f3c3ed24293030f77035a02ab961c91752976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576093Reviewed-by:
-
Abigail Klein authored
observer. This CL does two things: 1. Do not notify SODAInstallerObservers when the component has not been updated. The crash was initiated when the component updater sent a status update saying that the SODA component was up-to-date, which occurred while SODA was running and not when it was installing. These up-to-date messages should not be relayed to the SODAInstallerObservers. 2. Remove the CaptionsHandler from the SODAInstaller observer list when the CaptionsHandler is destructed. The crash occurred because the CaptionsHandler had not properly removed itself as an observer. Before this CL, the CaptionsHandler removed itself when javascript was disallowed, which was assumed to occur when the CaptionsHandler was destructed. On testing, it turns out that this is not the case, so this CL ensures that the CaptionsHandler is removed as an observer on destruction. Bug: 1055150, 1155625 Change-Id: Icb2073a1380f1d1cefc25690d84aa840804ff29c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575005Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#834027}
-
Scott Violet authored
onOffsetsChanged() does nothing if fullscreen. This changes the code to call to setControlsOffset() so that the offsets are correctly updated. BUG=1149335 TEST=testTopViewRemainsHiddenOnFullscreenRotation Change-Id: I419f629292caf5f4454a04920c6a9778c8f16731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575898Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#834026}
-
Aaron Leventhal authored
Also unify HasARIAOwns() logic, while ensuring that different types of aria-owns are handled. Bug: 1155617 Change-Id: If2f76e35ca8b444a620ca052281953258937a9f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575445 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
-
Eric Lawrence authored
The specification says that Referrer policies should only permit a comma delimited list when delivered via the HTTP header, but not via the meta tag. Match other browsers and ignore a meta-specified policy if it contains commas. Bug: 1093914, 1111447 Change-Id: Ie2528c968e1e45a2209d611aee37fa406987074c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567572Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#834024}
-
Liquan (Max) Gu authored
MinimalUi is the implementation details of PaymentUiService and so should not be exposed to the payment request service. This CL encapsulate the MinimalUI logic in PaymentUiService so that PaymentUiService no longer provides the MinimalUICoordinator instance. Bug: 1155582 Change-Id: Ica49ae9190248d400f29ef8102c9a4394356ad85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575342 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a488b77c17f5..952584d5b9bb 2020-12-05 tvanderlippe@chromium.org Upgrade third_party/codemirror to 5.58.3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2bd83a4ae7d1838ce05772b0f8ef632b572da6c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576337Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607147157-f5b7556f12cc4a67a4d86e796b1f10a124355671.profdata to chrome-linux-master-1607166734-e9365668558fc300c935cf3532da06f65c9b06bd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2dcb3562abb37d16c52cfd3cdb217f84b655eb2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576095Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607147157-05c119e40ba733e24d2e3874fc8b53f1f41ca77b.profdata to chrome-mac-master-1607166734-69b9a909cc2088c22879c6c9e7f8fd519f4237d8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6a9fe6c5f2e5bc0af5b613e456cd03d0b237de82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576091Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ab784e384be6..a488b77c17f5 2020-12-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2674f71d5424ba7dd4bdd86532825244b9e92aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576318Reviewed-by:
-
