GitLab

BUG=NONE
TEST=NONE

Review URL: https://chromiumcodereview.appspot.com/9701073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126981 0039d316-1c4b-4281-b951-d872f2087c98

This makes the scrollbar align where we would expect it to, after the close button's target.

BUG=118070
TEST=None

Review URL: https://chromiumcodereview.appspot.com/9701066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126980 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9704056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126979 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/9706010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126978 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/9705045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126977 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126976 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/9699077

TBR=reed@google.com
Review URL: https://chromiumcodereview.appspot.com/9702085

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126975 0039d316-1c4b-4281-b951-d872f2087c98

BUG=117473


Review URL: http://codereview.chromium.org/9703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126974 0039d316-1c4b-4281-b951-d872f2087c98

Unless your user name is chronos.

BUG=chromium-os:27859
TEST=manually with --vmodule=wizard_controller=1

Review URL: https://chromiumcodereview.appspot.com/9704064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126972 0039d316-1c4b-4281-b951-d872f2087c98

Since the items are already highlighted, remove underlining on hover for
'Settings' entry.

BUG=118328
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9703078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126971 0039d316-1c4b-4281-b951-d872f2087c98

Two different scenarios are fixed by this:
a) When Range:0- receives a 200 request, don't make a new connection asking for
   the same data without the Range:0- request heaeder (bug 104783). 
b) When a 4xx or malformed HTTP response is received on a Range:0- request,
   don't re-attempt the request without the Range header (bug 105230).

BUG=104783,105230
TEST=awesome scherkus@ tests now pass w/ the extra expectations removed.


Review URL: http://codereview.chromium.org/9699035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126970 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90078
TEST=none
TBR=sky

Review URL: http://codereview.chromium.org/9699080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126969 0039d316-1c4b-4281-b951-d872f2087c98

On device, FileManager should always see at least one root (Downloads), but when doing development on Linux some engineers may not have any local paths setup.  This CL improves error handling in this case.

Also I realized that our directory scan logic is setup to periodically retry (silently dropping the completion callback on the floor) rather than have any hard failure notification.  I don't know when this could happen in practice, but if it did it could break my redraw reduction optimization. Similarly, if a scan is aborted (eg. because the active root is quickly changed and a new scan is started) we may not get the callback.  I don't see any trivial low-risk solutions to this problem, so given where we are in the schedule I decided it was better to remove this optimization for now rather than risk any further regression.

BUG=chromium-os:27241
TEST=

Review URL: https://chromiumcodereview.appspot.com/9701063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126968 0039d316-1c4b-4281-b951-d872f2087c98

The reason is that there are a lot of RunMenu() functions all over the code,
and actually the event for this function is that the menu button was pressed.
So we tell that to subclasses and they do whatever they want; they do not necessarily need to run a menu.
Thus this patch renames RunMenu to OnMenuButtonClicked.

BUG=117092
R=sky@chromium.org
TBR=stevenjb@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9693022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126967 0039d316-1c4b-4281-b951-d872f2087c98

Increments and decrements of minimized panel count in the docking strip would not balance out in certain scenarios, e.g.: 
- if you add a panel that is already minimized (the count was incremented before the panel is added, sometimes causing a DCHECK to fire) 
- if you minimize a panel that is in "temporary layout" 
- if a panel's expansion state is changed when it is not in the docked strip (that is very hard to guard against, since a panel can jump into the overflow strip as a side effect of many operations) 

Changed the handling of minimized panel count to be more bullet-proof; added a test 

BUG=113682
TEST=PanelOverflowBrowserTest::AddMinimizedTillOverflow()

Review URL: http://codereview.chromium.org/9699036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126966 0039d316-1c4b-4281-b951-d872f2087c98

This CL moves UI tests from the patch off issue 9420040 to WebUI testing framework.


TEST=browser_tests --gtest_filter=NTP4*WebUITest*
     ui_tests --gtest_filter=NewTabUI*


Review URL: http://codereview.chromium.org/9625020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126965 0039d316-1c4b-4281-b951-d872f2087c98

There may be a way to add this at a lower level (i.e. in ui/aura) but that seems somewhat risky. I haven't come up with the good generic rule yet.

http://crbug.com/108753
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9703068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126964 0039d316-1c4b-4281-b951-d872f2087c98

* Use GetSearchProviderHistogramID() more instead of hardcoding the expected histogram ID, for future-proofing against changing how we histogram these, as well as clarity
* No else after return

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9701037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126962 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90078
TEST=none

Review URL: http://codereview.chromium.org/9701065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126961 0039d316-1c4b-4281-b951-d872f2087c98

Refactor GpuProcessHost::GetForClient to GpuProcessHost::Get, which takes a GPU process kind rather than a client ID.

There is no longer a plan to have a GPU process for each client to identify the GPU process by its kind (sandboxed or unsandboxed) rather than client ID.

I checked about:gpu still works and that the limit on the number of times the sandboxed GPU is relaunched is still limitted.
Review URL: https://chromiumcodereview.appspot.com/9559013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126960 0039d316-1c4b-4281-b951-d872f2087c98

Re-factor location bar/toolbar code to get rid of the browser dependency. This CL is needed to allow code reusing by captive portal view, which will show web content using DomView.

BUG=chromium-os:22630
TEST=browser_tests,unit_tests works

Review URL: http://codereview.chromium.org/9479008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126959 0039d316-1c4b-4281-b951-d872f2087c98

nss_util_unittest.cc calls PR_ImplodeTime, so this dependency is needed in
the components build.

BUG=90078
TEST=none

Review URL: http://codereview.chromium.org/9701059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126958 0039d316-1c4b-4281-b951-d872f2087c98

script to make them more userfriendly.

In particular, we now recognize systems that have multiple filesystems
(e.g. /home on NFS) and offer to do the right thing.

We also have better support for new Ubuntu distributions (both as
host and as guest). This means, we can now test on "precise".

Added a lot of extra error handling to catch common problems and either
fix them or offer suggestions on how the user can fix them. For example,
we now detect if the user tries to re-install the same chroot environment
multiple times; and we then offer to delete or overwrite the old
installation.

We also detect if a chroot environment is still in active use, and then
refuse to damage it.

In order to help users, who accidentally left an old chroot enviroment
running, we have added a "clean up" option to the wrapper script.

We automatically invoke install-build-deps.sh from install-chroot.sh,
so users only need to run install-chroot.sh and then answer a couple
of questions.

BUG=none
TEST=run install-chroot.sh on a Ubuntu machine and install both lucid32 and precise32. Verify that afterwards, we can build Chrome inside the chroot.
Review URL: https://chromiumcodereview.appspot.com/9702047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126957 0039d316-1c4b-4281-b951-d872f2087c98

Add code to convert from native Mac keycodes into USB keycodes so that Pepper can correctly populate the |usb_key_code| field in the InputEvent.
Review URL: https://chromiumcodereview.appspot.com/9701030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126956 0039d316-1c4b-4281-b951-d872f2087c98

The changes:
 * The network list scrolls on mouse-wheel.
 * The items in the network list cover the whole width of the list.
 * Increase the font-size of the date in the tray.
 * Adjust spacing between items in the tray.
 * Adjust padding in the user card.
 * Adjust the spacing and border around the shutdown etc. buttons in the user card.
 * Fix a crash from non-ascii username/email address.

BUG=110130,118326
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9706063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126955 0039d316-1c4b-4281-b951-d872f2087c98

The downloads system renames the file twice. It saves the file to a temporary
location as soon as you click Save As, and once the file picker chooses the
target location, say foo, it renames the file to foo.crdownload. This rename can
cause Open to fail. 

When the file is completely downloaded, there's another rename from foo.crdownload to 
foo. This can also cause Open to fail. 

This patch handles both failures.

TODO: Write unit tests for GDataUploader. 


BUG=chromium-os:23516
TEST=test downloading a large file.
Review URL: https://chromiumcodereview.appspot.com/9706009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126954 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
BUG=105508
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9706070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126952 0039d316-1c4b-4281-b951-d872f2087c98

This fell out between review and commit during a rebase.

BUG=none
TEST=verified build

Change-Id: I7a352bce306ff25dcfbfee39100b8a005eb3c18f

TBR=jhawkins@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9700069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126951 0039d316-1c4b-4281-b951-d872f2087c98

Require the spdy protocol version to be passed to   CreateSpdyHeadersFromHttpRequest so that the correct headers will be generated.

Add GetProtocolVersion methods to SpdyStream and SpdySession.



Review URL: http://codereview.chromium.org/9705046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126950 0039d316-1c4b-4281-b951-d872f2087c98

BUG=113496
TEST="Google Dashboard" link in Sync settings loads in new process.


Review URL: http://codereview.chromium.org/9663045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126949 0039d316-1c4b-4281-b951-d872f2087c98

Prevent RenderWidgetHostView from calling KeyPressListenersHandleEvent on a NULL member.


BUG=118351
TEST=No more crashes in content::RenderWidgetHostImpl::KeyPressListenerHandleEvent


Review URL: http://codereview.chromium.org/9702070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126948 0039d316-1c4b-4281-b951-d872f2087c98

Bluetooth is to be enabled by default for R19, the UI already includes
a separate "Enable bluetooth" checkbox that is connected to the radio
power, so there is no need to leave the flag in place.

BUG=chromium-os:23022,chromium:106446
TEST=verified bluetooth now enabled by default

Change-Id: I0814b903d4764774cb63fb0b2c003ee0d5c9a49e

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126809

Review URL: https://chromiumcodereview.appspot.com/9702028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126947 0039d316-1c4b-4281-b951-d872f2087c98

Since we don't set adapter_ early, it's possible for the destructor
to be called without it ever being initialized. Guard that call.

BUG=none
TEST=emerge chromeos-chrome

Change-Id: I64724c3bf7272b9d5588713872627462ebcbe878

R=jhawkins@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9702076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126946 0039d316-1c4b-4281-b951-d872f2087c98

xp-release-single-core: intl2 is now flakily failing, but does not seem to have regressed much.
http://build.chromium.org/f/chromium/perf/xp-release-single-core/intl2/report.html?history=450&rev=126909

TBR=cmp
Review URL: https://chromiumcodereview.appspot.com/9699086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126945 0039d316-1c4b-4281-b951-d872f2087c98

This makes them clickable when the cursor is at the edge of the screen.

For maximized windows we suppress the resize area that extends 1 pixel inside the window bounds, as maximized windows can't be resized (at least for now).  This allows double-clicking on the top edge of the screen to restore a maximized window and suppresses misleading resize cursors.

BUG=117952
TEST=manual, maximize a window and try single and double-clicking along the top screen edge.

Review URL: https://chromiumcodereview.appspot.com/9706044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126943 0039d316-1c4b-4281-b951-d872f2087c98

Add skia's SkMorphologyImageFilter.* to the Chrome build.  I'll be needing these for an upcoming WebKit change.

Review URL: http://codereview.chromium.org/9704043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126942 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:27699,chromium-os:27754
TEST=

Review URL: https://chromiumcodereview.appspot.com/9701012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126938 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=bshe@chromium.org
TBR=bshe@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9706065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126937 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126936 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116572
R=asvitkine@chromium.org
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9705063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126935 0039d316-1c4b-4281-b951-d872f2087c98