GitLab

Settings link in ARC++ OptIn UI is used in section about statistics
collection. It is more usable to user to open settings at privacy page
that contains relevant information.

Test: Manually
Bug: 821328
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8a4d9809618dedfdae7ca06e55680290ffb3eb5d
Reviewed-on: https://chromium-review.googlesource.com/1061623Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yury Khmel <khmel@google.com>
Cr-Commit-Position: refs/heads/master@{#559293}

Provide a GpuFence::Wait() method to hide the implementation details of
waiting for a GpuFence object.

Bug: 828393
Change-Id: I2153ebcb4b8cca6bb43c827fb0a9740f6a6cc221
Reviewed-on: https://chromium-review.googlesource.com/1021513Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559292}

This makes spacing between expiration date and logo for credit
card suggestions consistent across languages. The fix replaces
a left padding to the image (which doesn't work for RTL) with
a fixed spacer between the label and the image, which will be
rendered according to expected.

One alternative for this is to set either left or right padding
according to the browser language's direction, but I'd rather
only test for language direction when it's strictly necessary.

See screenshots in this deck:
https://drive.google.com/open?id=1rcdEKbMWxsABDRAWDjlIa5FgJrNsUro8EKECD99tSDg

Bug: 768881
Change-Id: I362e75f78cabee357ca83c118cf58b788462e952
Reviewed-on: https://chromium-review.googlesource.com/1057420Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559291}

This patch merges the template function into inline_box_traversal.cc
to reuse the left and right traversal strategies defined there, and also
hide implementation details of bidi adjustment

This is also a preparation for implementing NG bidi implementation by
generalizing existing code: crrev.com/c/1038058

Bug: 822575
Change-Id: Ie64f005b3e5f510cf3664000ecb5fd5d157b6bac
Reviewed-on: https://chromium-review.googlesource.com/1048974
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559290}

Clear Key CDM supports both 'cenc' and 'cbcs' now, while Widevine gets
the set derived from its manifest.

BUG=657957,658026
TEST=new media_unittests pass

Change-Id: I217bb06634e0a19a1a9fb46fb82cd4692a21bbea
Reviewed-on: https://chromium-review.googlesource.com/1056028
Commit-Queue: John Rummell <jrummell@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559289}

BUG=762641
TBR=zelidrag@chromium.org

Change-Id: Id50f5f3cf12f93bbfcb96325c56913b88c7b1f67
Reviewed-on: https://chromium-review.googlesource.com/1062632Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559288}

Specs: https://screenshot.googleplex.com/JRjnsxbBdeH

Screenshot: https://screenshot.googleplex.com/1pxi3nJM6nr

Bug: 803292
Test: tested on device
Change-Id: I8878a426ac87a180af5fb791b8457f0ef3433cf7
Reviewed-on: https://chromium-review.googlesource.com/1057992Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#559287}

https://pdfium.googlesource.com/pdfium.git/+log/67268cd0efa2..33515fbec463

$ git log 67268cd0e..33515fbec --date=short --no-merges --format='%ad %ae %s'
2018-05-16 thestig Do more optimizations to make FindBit() faster.
2018-05-16 tsepez Use pdfium::span<> in cpdf_crypto_handler.h
2018-05-16 thestig Avoid a memset() in FindBit() in the fax codec.
2018-05-16 tsepez Remove two unused #defines in cjs_globaldata.cpp.
2018-05-16 dsinclair Convert CJX_Object::Set* methods to return void
2018-05-16 tsepez Use pdfium::span<> in cpdf_creator.
2018-05-16 vmiklos core: allow building against system icu-uc

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ic7ab6344e11a92a497e419ccf03aa6a3518d2849
Reviewed-on: https://chromium-review.googlesource.com/1062493Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559286}

Pixel_OffscreenCanvas2DResizeOnWorker flaky also on Linux
Correct bug number for Pixel_WorkerRAF_OOPD expectation

TBR=kbr@chromium.org

Bug: 833902, 840394
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie2d90eedc8b16baec2890f09dd8ef96c40293ada
Reviewed-on: https://chromium-review.googlesource.com/1062194
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559285}

Usage of net/ code has been moved to NetworkContext IPCs as part of
servicification.

Bug: 721398
Change-Id: I2fdcac208d5e402b2c53fb62f86e426c122cae1b
Reviewed-on: https://chromium-review.googlesource.com/1053839
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559284}

The following bots have been migrated to LUCI:
  GPU Linux Builder (dbg)
  Linux Debug (NVIDIA)
  GPU Win Builder (dbg)
  Win10 Debug (NVIDIA)

Bug: 790065, 790069, 790078, 810318, 815092
Change-Id: I2d6e6c1ea9103c91750127974d0768afa65aa88e
Reviewed-on: https://chromium-review.googlesource.com/1062663Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559283}

This CL makes it easier to filter MCAD logs.

See media logging guidance at
https://chromium.googlesource.com/chromium/src/+/master/media/README.md#logging

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I5f510999273af202e0f28dc33a8e1b51b126f0d4
Reviewed-on: https://chromium-review.googlesource.com/1062648Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559282}

Bug: 822849
Change-Id: Ic1dbcc80e3be599f9c8e1fbff0d6230f5f3f6c37
Reviewed-on: https://chromium-review.googlesource.com/1057364
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559281}

Bug: 842006
Change-Id: Idc7959c00d8ec22b824242db97923c3985f44d2f
Reviewed-on: https://chromium-review.googlesource.com/1062365Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559280}

Windows 10 RS4 (maybe older as well) x64 implementation of CopyFile expects
that the HANDLE passed to NtCreateFile is not modified upon error. Old
implementation of TouchMemory 'destroys' the buffer before passing it to
the broker. This can be fixed by first reading the original value and then
restoring back at the original place. This has to be done carefully so
optimizer won't remove the code.

R=wfh@chromium.org

Bug: 839775
Change-Id: Iff80f3a5f145b85da2f0ba500e74387fce4e0e4b
Reviewed-on: https://chromium-review.googlesource.com/1061460Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559279}

 - Add hover background color.
 - Add hover box shadow effect.

Bug: 832173
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I89eb5bb9c9b088ad85fbf5d22dd3735392d1ecd8
Reviewed-on: https://chromium-review.googlesource.com/1060554Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559278}

This moves all of the responsibility for handling PageAlmostIdle to TabLoadTracker.

Change-Id: I9325109e896910d76b6aa6a615f9004dc1a4e67d
Reviewed-on: https://chromium-review.googlesource.com/1060569
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559277}

Relanding the move zygote to the service manager. It was causing an TSAN
failure that now cannot be reproduced.

Original description:

"This CL moves the zygote code from content/ to
services/service_manager/zygote. This involves moving some switches from
content_switches.h to services/service_manager/embedder/switches.h and
moving some codes from content/public/common/result_codes.h to the new
services/service_manager/embedder/result_codes.h."

Tbr: avi@chromium.org
Tbr: sky@chromium.org
Tbr: scottmg@chromium.org
Tbr: rockot@chromium.org
Tbr: slan@chromium.org
Tbr: eseckler@chromium.org
Tbr: rsesek@chromium.org
Bug: 831846
Change-Id: Ief3c55a1d76ab0b0ded922770d14402c0c3b37b9
Reviewed-on: https://chromium-review.googlesource.com/1048040Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559276}

Bug: 840427
Change-Id: I1d658ed8c005ab29ec4754b1586257aec8b2c106
Reviewed-on: https://chromium-review.googlesource.com/1062286Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559275}

It now matches the name in histograms.xml.

TBR=dmazzoni@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8aa7ed7086bc2abbafe68aa2dcc3b75c1c982334
Reviewed-on: https://chromium-review.googlesource.com/1062210
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559274}

It seems to be flaky about 5% of runs since it was added on the Mac10.10 bot.

TBR=imcheng@chromium.org

Bug: 843599
Change-Id: I94b4dde41e2455af3fa3fe3f4e02f6c3a3a14013
Reviewed-on: https://chromium-review.googlesource.com/1062593
Commit-Queue: Robert Flack <flackr@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559273}

This reverts commit 46a6d04b.

Reason for revert: Introduced and inconsistency in how the Sync Payments cards toggle. See crbug.com/839643

Original change's description:
> Settings[DICE]: changing sync-everything doesn't impact on-disk prefs
>
> This CL stops toggling "sync everything" from overriding all individual
> prefs' on-disk value with "true" (see reasoning in bug report).
>
> Bug: 815018
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: If6287376009b200355426113618933af9ad78243
> Reviewed-on: https://chromium-review.googlesource.com/935836
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Reviewed-by: Tommy Li <tommycli@chromium.org>
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Commit-Queue: Scott Chen <scottchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542929}

TBR=tommycli@chromium.org,dpapad@chromium.org,mastiz@chromium.org,scottchen@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 815018,839643
Change-Id: Iba41940bdfde775048553dd4e0abd6c52e85f7bf
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1061893
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559272}

This increases code coverage based on what is observed in this report:
https://chromium-coverage.storage.googleapis.com/reports/558266_tests_only/linux/chromium/src/base/json/json_parser.cc.html

Bug: 489301
Change-Id: Ia7f9ef97e93fb92e440717d9463d810dab4f87dc
Reviewed-on: https://chromium-review.googlesource.com/1059717
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559271}

On navigation, or at other times, content was flashing.  This was
happening because unrelated code presumably mucks with the GL blend
mode, and we weren't setting it before drawing content via the new
quad-layer mechanism.

BUG=838695

Change-Id: I93791ff26cf52d74db410cf1590b9f5baca21765
Reviewed-on: https://chromium-review.googlesource.com/1062196Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559270}

Without --local, the dumpsys command changes the memory usage of the
app! With --local, we lose:

Objects
               Views:        0         ViewRootImpl:        0
         AppContexts:        4           Activities:        0
              Assets:        2        AssetManagers:        2
       Local Binders:        3        Proxy Binders:        7
    Death Recipients:        0
     OpenSSL Sockets:        0

Added --query-app flag to get these back.

Change-Id: If47994b64620ae266c6109d9747a81aa805b293c
Reviewed-on: https://chromium-review.googlesource.com/1062329Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559269}

BUG=843075

Change-Id: Iccb161d3d584cf434ae20b5ec91134b04996c999
Reviewed-on: https://chromium-review.googlesource.com/1062411Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559268}

This CL makes software compositing for the cc::Surface for video case
by making VideoFrameSubmitter a SharedBitmapReporter. Before we would
see blue boxes instead of the video frames. Now we see video frames as
they should be.

Bug: 807840
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I486456f4d4e96b05317089557084242eeda04455
Reviewed-on: https://chromium-review.googlesource.com/1057962Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559267}

Those tests don't pass, but the rest of jingle_unittests seems to do so.

Bug: 843104, 840756, 842698
Change-Id: I9895fa88042ec5decdc70e33fceb362d14638f1d
Reviewed-on: https://chromium-review.googlesource.com/1059613Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559266}

Bug: none
Change-Id: I520b73ca3732be6a38b941e14a56d7e07e8c2bf3
Reviewed-on: https://chromium-review.googlesource.com/1062718Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559265}

When destroying the page we may need to cancel timers. Currently, the timers
will be free'd before the page. This CL changes the destruction order to free
the pages before freeing the timers.

Bug: 843493
Change-Id: Ic96707bd1dc7510f65218679dc12cd44ba012db8
Reviewed-on: https://chromium-review.googlesource.com/1062195Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559264}

9115494e8aa4 fuchsia: Increase timeout for WorkerThread.DoWork test
dea8fa51d0b5 fuchsia: Changes to allow analyzer-style exception handling
d78bd067c7f3 linux: Initialize a crashing thread's stack from its
             exception context
75b672be06c5 Fix arm build with glibc 2.27

Change-Id: I1187b6c1f651761dc65818c24441943b25b7519c
Reviewed-on: https://chromium-review.googlesource.com/1060117Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559263}

Replaces the iOS icon with what's being used on Android.

Bug: 841758
Change-Id: I31576c9bd4925c91ca28afe46c9071d97cb0ea43
Reviewed-on: https://chromium-review.googlesource.com/1061586Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559262}

What:
1. Sends a message to the browser part of the subresource_filter component to
   make it aware of which frames have been identified as ads by the AdTracker.

2. The browser monitors movement of RFHs across processes and copies over the
   ad_subframe bit to new RFHs in ReadyToCommitNavigation.

3. Simplified OngoingThrottleInfo::is_ad_subframe and renamed it to
   OngoingThrottleInfo::navigating_to_ad_url.

4. Added tests.

Why:
Because while the render process knows if a subframe that it creates is an ad
frame or not, if the frame changes processes (due to site isolation) the
browser has to tell the new process that the frame is an ad.

Bug: 993493
Change-Id: I2a17660251cdd238853990e2384a7e287f5c659b
Reviewed-on: https://chromium-review.googlesource.com/1044425
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559261}

This CL replicates existing test expectations for
media/video-controls-focus-movement-on-hide.html
into the virtual/video-surface-layer flavour of the test.

Before this CL:

crbug.com/833658 [ Linux Win Mac ] media/... [ Pass Failure ]
crbug.com/841922 [ Mac10.12 Mac10.13 Win7 ] virtual/video-surface-layer/media/... [ Failure Pass ]

After this CL:

crbug.com/833658 [ Linux Win Mac ] media/... [ Pass Failure ]
crbug.com/841922 [ Linux Win Mac] virtual/video-surface-layer/media/... [ Pass Failure ]

Bug: 833658, 841922
Change-Id: Ib3de8102f5e947215133f42c2dc522d612394789
Reviewed-on: https://chromium-review.googlesource.com/1062587Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559260}

https://chromium.googlesource.com/catapult.git/+log/72b67fe2e3ac..d95db22a613c

$ git log 72b67fe2e..d95db22a6 --date=short --no-merges --format='%ad %ae %s'
2018-05-15 benjhayden Add app-route to third_party/polymer2.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Ic5e25e2af70e188a51c43dbe25b6986ac15dbd0b
Reviewed-on: https://chromium-review.googlesource.com/1062205
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559259}

This data will be passed to DownloadTask so DownloadManagerTabHelper
can distinguish downloads requested by the user vs. downloads requested
by a web page. DownloadManagerTabHelper drops subsequent downloads
requested by the web page to prevent spam. Currently tab helper relies
on download task's transition type (which is incorrect). Fixing download
transition type is possible, but much harder (see crbug.com/549301).

This API mirror's content's NavigationHandle::HasUserGesture

Bug: 842828
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I79fc2a57af4594494e27613996c39e0153857e5c
Reviewed-on: https://chromium-review.googlesource.com/1060575Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559258}

Removing the namespace preffix since its redundant, also adding
comments to the parameters (i.e. "should_persist").

Bug: None
Test: Build
Change-Id: I266396e75d5d12c86dfd53f0099d1b63c61998b9
Reviewed-on: https://chromium-review.googlesource.com/1059720Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: David Jacobo <djacobo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559257}

This allows the clients of UpdateClient inspect the error codes when
an update is complete.

Bug: 843657

Change-Id: I667a58a2723846cdcc4070fc9b103419ea4859d1
Reviewed-on: https://chromium-review.googlesource.com/1060586Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559256}

- This is a speculative fix to address a large performance regression
  on Android WebView.
- Restricts the range on 64 bit ARM Android to 0x20000000 - 0x60000000.

Bug: chromium:837640
Change-Id: I913ed62a9d360ae96aeaab80f468c18f357f956f
Reviewed-on: https://chromium-review.googlesource.com/1062012Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559255}

The test verifies is_post argument passed to WebClient::PrepareErrorPage

Bug: 725241
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I9f5a6035f1c49dc3cc0a1a144b096ff2fc035989
Reviewed-on: https://chromium-review.googlesource.com/1062079Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559254}