GitLab

This change fills the font-family, font-size, font-weight, italic, bold
and color attributes of the AXNode with exposed values from the PDFium
APIs.

I've also added a PDF accessibility tree dump test using the filter
properties to dump those attributes in the expected file. The test file
is "text-style.pdf".

Somehow, I added in a previous change text-format-expected-blink.txt.
This file should have never been committed. I removed it in this CL.

Bug: 985604
Change-Id: I70a4729269aea69e184e61710d7977425b431704
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755412Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Ian Prest <iapres@microsoft.com>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711942}

https://chromium.googlesource.com/chromium/deps/icu.git/+log/481b5ca7b..88ea42af73
  88ea42a Sort variants in locale code.

Bug: v8:9741
Change-Id: Iccd5d661d439babaae59f358059bd6c1bb1f0606
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896236Reviewed-by: Jungshik Shin <jshin@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711941}

We define a new 'app.display_mode' key to record the display from
the web app manifest.

https://w3c.github.io/manifest/#display-modes

Back and Reload buttons are only shown when a bookmark app
is opened in a window, and 'display' in the web app manifest
is minimal-ui or browser (or omitted).

Equivalent functionality was recently implemented for BMO web_apps, after the design discussion summarized in
https://docs.google.com/document/d/11E_gSSeJlECwvFqO_Tf-urmpYbx4c5MowHDC53xj0Ig/edit?usp=sharing

TBR=ellyjones@chromium.org

Bug: 1014346
Change-Id: I7dab174905e43f829a1b13bbe714d716ed8aeda1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888611Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711940}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/9faf2ee6c3b6..4d17287a4eae

git log 9faf2ee6c3b6..4d17287a4eae --date=short --no-merges --format='%ad %ae %s'
2019-11-01 gbiv@google.com build_stages: remove a broken test assertion

Created with:
  gclient setdep -r src/third_party/chromite@4d17287a4eae

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I2405cb35380048aead051c09acc889eac298f4f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895890Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711939}

Add 2 command line options, one each to query the current state of the
Accessibility and Screen Recording permissions. MacOS-only.

Change-Id: Ic5a6323f71509327b4af00c56db15e8beb2bba8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874504Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Gary Kacmarcik <garykac@chromium.org>
Auto-Submit: Gary Kacmarcik <garykac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711938}

Uses explicit deletion instead, removes use of base/macros.h.

Bug: chromium:1010217
Change-Id: I907f74658c7667794d5c0ef7555104d5fb7cccbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895082
Commit-Queue: Peter Boström <pbos@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Boström <pbos@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711937}

This patch implements intrinsic-size to work with a grid container.
The general strategy is to treat intrinsic-size, if specified in a direction,
as size containment in that direction while overriding the correct size.

Adds tests for the both intrinsic dimensions specified, as well as
only one specified and the other left as legacy to ensure that the correct
override is picked in the code.

R=rego@igalia.com, chrishtr@chromium.org

Bug: 991096
Change-Id: I1eefda7ae5288442716eb19cf945770cba2f1dca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893734Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711936}

Change interfaces to use cc::PaintCanvas and SkIRect. Immediately
convert back to gfx types.

Touch up colors so that the diffs in layout tests will be minimized.

Add code to paint the corner. Share this with the track painting code,
and split the track painting code into helper functions for this
purpose.

Bug: 961835
Change-Id: I451f16711afce8e4a0bff5e963f1dc3e06f22410
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896044Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711935}

Since some Android devices are more sensitive on network and data usage,
we want to enable real time url lookup on high end devices first. Whether
a device is high end or not is based on its system memory size. The memory
size threshold is controlled by an experiment parameter.

Bug: 1014202
Change-Id: I2dd399e71b35694b08ae0024140918d5e0d390ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893989
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711934}

In the future we will animate when the hotseat state changes.
Ensure that the bounds are set before the state changes, so that
the animations know where to animate to.

Change-Id: Icad9b0d1024bbe5d10d00fc369439b2418c16963
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896082Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Auto-Submit: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711933}

https://pdfium.googlesource.com/pdfium.git/+log/dd9ef1c0d58f..c3a91730e33e

git log dd9ef1c0d58f..c3a91730e33e --date=short --no-merges --format='%ad %ae %s'
2019-11-01 tsepez@chromium.org Make CPDFSDK_Pageview observable across mouse move callbacks
2019-11-01 dhoss@chromium.org Remove jumbo usage in GN files throughout PDFium
2019-11-01 tsepez@chromium.org Run another embedder test with javascript disabled.

Created with:
  gclient setdep -r src/third_party/pdfium@c3a91730e33e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=pdfium-deps-rolls@chromium.org

Bug: chromium:1017494
Change-Id: Ib0f25d57b2868bbec3fc46b5825d6085611dc284
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896139Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711932}

This CL handles the following issues on intestitial pages
1 - The links for privacy, support etc will be open in a CCT. This is
accomplished by any time there is a request to open in new tab, we will use CCT.
2 - The link Back to Safety will go to the previous page. If there is
no previous page, i.e. previous page is NTP, the preview tab will be closed.

Bug: 1014689
Change-Id: I469fd4597800796bc1eaa47569012d9e937082c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868094
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711931}

https://skia.googlesource.com/skia.git/+log/6751f171c662..8e083eee8ece

git log 6751f171c662..8e083eee8ece --date=short --no-merges --format='%ad %ae %s'
2019-11-01 robertphillips@google.com Tighten up min and max vertex indices passed to GrTextureOp's meshes
2019-11-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-01 michaelludwig@google.com Progress towards consolidating aa mask and edge distances
2019-11-01 ethannicholas@google.com Revert "Implement sample mask and sample locations support in Vulkan"
2019-11-01 ethannicholas@google.com Implement sample mask and sample locations support in Vulkan
2019-11-01 kjlubick@google.com [canvaskit] Add relative SkPath operators
2019-11-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-01 robertphillips@google.com Revert "Reduce max # of AA Quads that can be merged or chained into a single GrTextureOp"
2019-11-01 borenet@google.com Revert "[recipes] Assert that Git is obtained from CIPD"
2019-11-01 senorblanco@chromium.org Dawn: update to recent texture proxy changes.

Created with:
  gclient setdep -r src/third_party/skia@8e083eee8ece

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@google.com

Bug: chromium:b/143572065
Change-Id: Id9323154e625a1afb52244869e82e64559905ded
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896136Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711930}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c39a77883d7b..79d9e4b8508d

git log c39a77883d7b..79d9e4b8508d --date=short --no-merges --format='%ad %ae %s'
2019-11-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/depot_tools@79d9e4b8508d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: None
Change-Id: I1b2c3524e105cdcf69e20ce5a1bed7d4c1517e21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896138Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711929}

Besides the implementation, there's little refactor happending for
DisallowedFeatures struct as we triggered the complex class/struct
explict out-of-line constructor conditions.

Bug: 455150
Change-Id: I84e52c4818a8a95aa3c8cb08e5e08d0e6f75ac72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881482Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>
Cr-Commit-Position: refs/heads/master@{#711928}

Bug: 1020661
Change-Id: I720511c79c6a161352223c8a7b610806af0f177f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895169Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Jonathan Freed <freedjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711927}

Updates UserScriptListener which was using the Notification System to
instead use UserScriptLoader::Observer. Also updates associated
UserScriptListener tests.

Bug: 268984
Change-Id: I5f686352be13d6223a5b6271047fc966c3486a9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874819
Commit-Queue: Tim Judkins <tjudkins@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711926}

Both gpu/shared-images/* and gpu/shared_images/* are used as the memory
dump name for shared images. Other GPU code uses an underscore in dump
names so use gpu/shared_images.

Bug: none
Change-Id: I03466b6ca43cd4d35e5227804d7de1125b3ac865
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894465
Auto-Submit: kylechar <kylechar@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711925}

The issue is that os.path uses backslashes when run on Windows, and
makes it fail unittests.

This change should make it so that it always uses forward slashes.

R=sajjadm,martiniss,joenotcharles

Bug: 1020240
Change-Id: Ie8637a23f6799d2d353971b7ce31c306edfaffa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894328Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711924}

This is a reland of 34445e49

CoreFoundations APIs usage was preserved since Cronet still requires
32-bit support.

Original change's description:
> [ios] Use posix TimeExploded
>
> With 32 bits build gone, iOS can use the posix implementation of
> TimeExploded, which is faster.
>
> Bug: 985061
> Change-Id: Ic1d42ebddfa2d0bb0d37bb7b2086683914aa87a5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763679
> Commit-Queue: David Jean <djean@chromium.org>
> Reviewed-by: Mark Cogan <marq@chromium.org>
> Reviewed-by: Yuri Wiitala <miu@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: kylechar <kylechar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#691094}

Bug: 985061
Change-Id: I42ee2b64a3ed7b6c3c98d1593cd4d762377f7b33
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856961
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: David Jean <djean@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711923}

The bot's served its purpose.

Bug: 989314
Change-Id: Ia4a961453cb9e993ef54da2048129b4ba472b8a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896116
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711922}

CellPreceding and CellAbove were only used to determine if
this was the first cell in the table.

Bug: 958381
Change-Id: I372331b7a9534200ae7f060a5b67d91d9bd7ec49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896036
Auto-Submit: Aleks Totic <atotic@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711921}

This CL extends the following metrics:
  SBDownloadFeedback.UploadResult
  SBDownloadFeedback.SizeSuccess
  SBDownloadFeedback.ActiveFeedbacks
  SBDownloadFeedback.SizeFailure
There is planned work to make uploads more reliable, which will be tracked
by improvements in these metrics.

Bug: 988669
Change-Id: Ifb49101e348e95ce09a9fed8e54c6b193e0d903b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895388Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711920}

This CL restores the missing scrim when there is a single entry on the
navigation sheet. The repro step is unique in that it's the only
situation where the sheet with a single entry "Show full history" is
displayed. All the others show at least 2.

The scrim didn't appear since BottomSheet didn't trigger the event
|onSheetOpened|. The minimum swipable state is set to
peek(https://crrev.com/c/1880495), but the sheet height with a single
entry is smaller than that of the peek state (1.5 x entry height),
therefore didn't meet the condition that fires the event.

To address the issue, following changes were made:

1) BottomSheetContent disables peek/half state for this occasion so
that the sheet can go straight to full state.

2) Skip calling |expandSheet| but used BottomSheetContent state info
to have the same effect. The explicit call to the API, when combined
with the above change, causes the same state transition (full ->
full), which cancels the animation effect.

Bug: 1020408
Change-Id: I2b9d3d2f495a167dd844be82b9796bfeeb2fda81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893129Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711919}

Form submission stopped working after crrev.com/c/1850358 when using
event.preventDefault() and form.submit() in a click event handler for a
<button type=submit> when the button has child elements and the click
was made on one of the child elements.

Bug: 1020086
Change-Id: I8976298ac56a64ff7033cb2f7b46ee5116229464
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896050Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711918}

This adds internal state to the PermissionWizard class, and logic to
show the UI for all pages and states of the wizard.

This also fixes the button action selectors and targets.

Bug: 1015201
Change-Id: I49690bceba7f9f55ae07ddde171b5a4eda4faa3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895786
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711917}

When the embedded Assistant is initially shown, it uses a small window.
When a big response arrives, its size is increased (to what is called
|ash::AppListViewState::kHalf|).  When this happened, the focus was lost
from the input text box (and moved to the - at this point not visible -
launcher search box).

This is fixed by updating the |AppListView| to not move the focus to the
launcher search box if the embedded Assistant UI is showing.

I also introduced a new |AssistantTextfield| which is used for inputting
text based queries. This makes things like logs and stacktraces easier
to parse as they will now mention |AssistantTextfield| instead of just
|Textfield| which is used everywhere.

test: Added unittests and manually verified.
bug: b/143715841
Change-Id: I4da2b363ec6c93b5bb166b415e45c60c08206810
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896047
Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711916}

Bug: 1014313
Change-Id: I21f170d67f92a3514040d2f8fb3315c0770379ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894254
Auto-Submit: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711915}

Using wpt-import in Chromium a9ceb3fa.
With Chromium commits locally applied on WPT:
1d5b803f "Add WebVTT support for inline styling - Web Platform Tests"
9be931cb "[WPT/common/security-features] Refactor navigable tests"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
rego@igalia.com:
  external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: Icf9092a879be83b1c407b0759f4bb465d907e67d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895799Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711914}

Uses explicit deletion instead, removes use of base/macros.h.

Bug: chromium:1010217
Change-Id: I187bba0ded61bd50a0488fe9f5f001e032d5ae0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836134
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711913}

My best idea to address Oshima's code review comment at [1] is by
renaming things to reflect workflows, and as a first step toward doing
so, the present CL removes IndicatorState::kDragAreaLeft which does not
correspond to any workflow. The current split view drag indicators code
is full of naming that attempts to describe visuals but does so
inadequately. Look at the code comment that I am adding to
DragWindowFromShelfController::GetIndicatorState in [2]. Even worse than
that, look at the comments on the following unit tests:
SplitViewTabDraggingTest.DragSnappedWindow
SplitViewTabDraggingTest.DragSnappedWindowWhileOverviewOpen

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1894754/1/ash/wm/splitview/split_view_highlight_view.cc
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1894754/1/ash/home_screen/drag_window_from_shelf_controller.cc

Bug: None
Change-Id: I4f9cb85c818023c0a3b5c12e818d3a3ccf56e158
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895390Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711912}

Bug: 1020384
Change-Id: Ief2a422511d70b667aea3d7b48d5731848ba2bd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895888Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Tina Lu <ltina@google.com>
Cr-Commit-Position: refs/heads/master@{#711911}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/a95cbb23f5dc..9faf2ee6c3b6

git log a95cbb23f5dc..9faf2ee6c3b6 --date=short --no-merges --format='%ad %ae %s'
2019-11-01 bpastene@chromium.org cros_chrome_sdk: Print a link to a board's builder when its SDK is missing.

Created with:
  gclient setdep -r src/third_party/chromite@9faf2ee6c3b6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I701aee03d28d23a690649f96b5e709fdda4afe2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896095Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711910}

Speculatively fixes RenderWidget::DidCommitAndDrawCompositorFrame in
performance_browser_tests not being parsed as a perf result by changing
it to RendererFrameDraw. It is believe that the colons in the original
name were interfering with the parser script's ability to correctly
extract the metric name.

Bug: 923564
Change-Id: I3f5a91a0b11ea8a6bd3363b8ecf6aa044a8425d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888774
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711909}

The following bots:
  Linux FYI Debug (NVIDIA)
  Linux FYI GPU TSAN Release
  Linux FYI Release (AMD R7 240 / Intel [U]HD 630 / NVIDIA)

  Mac FYI Debug (Intel)
  Mac FYI Retina Debug (AMD / NVIDIA)
  Mac FYI GPU ASAN Release
  Mac FYI Release (Intel)
  Mac FYI Retina Release (AMD / NVIDIA)
  Mac Pro FYI Release (AMD)

  Win10 FYI x64 Release (NVIDIA GeForce GTX 1660)
  Win10 FYI x64 Debug (NVIDIA)
  Win10 FYI x64 Exp Release (Intel HD 630)
  Win10 FYI x64 Release (AMD RX 550 / Intel [U]HD 630 / NVIDIA)

Will run the following tests:
  dawn_end2end_tests
  dawn_end2end_validation_layers_tests
  dawn_end2end_wire_tests

On the DEPS version of Dawn

Bug: chromium:1016948
Change-Id: I91029164d935e4d91d28eb3b802232a358645b0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873288
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711908}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5689bf7c..aadf1619

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I3d807da2280ea357275b0c648e4786111b94c215
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895397Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711907}

When loading the offline dino after a navigation, the UserAgent is reset
to the CriOS user agent. This CL makes sure that we also consider that
we are on iOS when CriOS is present in the UserAgent.

Bug: 1008774
Change-Id: I67238b0f137e626476e635593651b8d716472cd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893959Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711906}

Always activate MetricsAndCrashSampling so that we can emulate the
sampling for users that didn't apply it client side.

Adds a feature that we can use to start having all clients apply it.

Change-Id: I497f36bc093945b225db853fe4d271680cab1e8e
Bug: 1016572
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872988
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711905}

This CL moves the MPRIS implementation into the SystemMediaControls
component. It deletes the usage of the MPRIS-specific API in favor of
the platform-agnostic SystemMediaControls API.

Public design doc:
https://docs.google.com/document/d/1_UjhXdXzQlPEwFKpogTZm-ILylKid4lTiOomqHv-IPg/edit?usp=sharing

Bug: 949596
Change-Id: I2af605dd742969fa474dfe14ec62167ebb80852b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895385Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711904}

This change moves the LevelDBScopes implementation from content/browser
to componenets/services/storage.

Other than the file moves (and associated macro, include, and export
updates), this change:
* Deletes the BarrierBuilder in lieu of having an anonymous version in
  the unittests file directly.
* Moves the scopes lock range test for IndexedDB-specific lock ranges
  to indexed_db_unittest, as that is where the test should go.

R: rockot@google.com
Bug: 1015212
Change-Id: Ied21b955b903d06621798091771a46d4f3e47854
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895863Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Auto-Submit: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711903}