- 22 Oct, 2019 40 commits
-
-
Christian Dullweber authored
Change the flow from keeping the UI open to closing the bubble when a button is clicked. This is the typical behavior of most bubbles and doesn't lead to users accidentially reversing their previous action. Bug: 1016747 Change-Id: Ia9ad0f73ff02af8cab6f5a53b9385676b8ef9661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873746Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#708174}
-
Olivier Li authored
This is ground work for experimenting with running ProfileSyncEngine's backend work on the ThreadPool. This is done as the last mile of the chrome-wide effort to coalesce as much work as possible to the ThreadPool. For the change that will enable the experiment please refer to: https://chromium-review.googlesource.com/c/chromium/src/+/1856922 Bug: 1014464 Change-Id: I60e8081eefe40c90fc258aa9ac0467f910ca3356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872410Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#708173}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/27f6d3d34924..4ec0e215bc4a Created with: gclient setdep -r src-internal@4ec0e215bc4a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I43f773fe979d734a501f511ab47f5f5dba0a6c3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873595Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708172}
-
Clemens Arbesser authored
Bug: b/142864606 Change-Id: I9e21c4f42e55ae6c5cdd84621da73bc6bd6bf590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871555Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#708171}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/85a10001a508..528a03441eac git log 85a10001a508..528a03441eac --date=short --no-merges --format='%ad %ae %s' 2019-10-22 saza@webrtc.org Fix fuzzer-found inconsistency in AEC3 config json parsing 2019-10-22 ilnik@webrtc.org VP9 decoder: replace DCHECK with error message 2019-10-22 nisse@webrtc.org Delete unused members of MediaReceiverInfo and MediaSenderInfo Created with: gclient setdep -r src/third_party/webrtc@528a03441eac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:1016139,chromium:1016160 Change-Id: If0cf8eeb9ee754b7d982b2021c1b2b7e8ce28c60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873594Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708170}
-
Vasiliy Telezhnikov authored
This CL adds HardwareRendererViz as part of implementation of 'Viz for WebView' path. HardwareRendererViz responsible for submitting root CompositorFrames. Bug: 805739 Change-Id: If5b57c39e3d625286248598f23aaa29a9ab55025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863136 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#708169}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I28d12515eb518579f1cbf1b90b6ee61568314f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871903Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708168}
-
Francois Beaufort authored
This CL adds the data attribute to NDEFRecord as specified in https://github.com/w3c/web-nfc/pull/379 Bug: 520391 Change-Id: Icab2c69d6cec95540e6f8525354e86a6937aa4e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871369Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#708167}
-
Vasiliy Telezhnikov authored
This CL extracts surfaces initialization from SurfacesInstance class to be later reused in HardwareRendererViz. Bug: 805739 Change-Id: Ic7cd344c4c250dfb2be08aaf1dc5acd5ad80fa11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868975 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1e7968db31d4..c4191602bb51 git log 1e7968db31d4..c4191602bb51 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 khokhlov@google.com [tracing] Add HistogramSet.Merge method Created with: gclient setdep -r src/third_party/catapult@c4191602bb51 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:981349 Change-Id: Ia0d28fade66a729de31ef9045b944e4539994bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873593Reviewed-by:
-
Dominik Inführ authored
Add flag for promoting all live young objects during a Mark-Compact GC. Flag is disabled by default. Bug: chromium:1014943 Change-Id: Iaad05f0f99c87756230519c9be7e0ec9a59ca37a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865331Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#708164}
-
Mike West authored
We're defining the `gopher:` protocol only so that we can declare it as "standard" and assign it a default port. Since there's no actual support for the Gopher protocol in //net or //content (or //chrome (or anywhere else in the repository)), we can remove the definition with no practical effects. Hopefully, that makes evaluating Chrome's support for various protocols a little simpler to ascertain while skimming through code. This follows along with WebKit's change in https://bugs.webkit.org/show_bug.cgi?id=201852 and the related proposal in https://github.com/whatwg/url/issues/342. Change-Id: Ia18d862e574dcaea796041d27210cec235d97d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/612983 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#708163}
-
Andreas Haas authored
We are removing external uses of ArrayBufferContents::DataHandle so that eventually we can remove the whole class and change the implementation of WTF::ArrayBuffers. This CL is an intermediate step on the way which replaces the external use of DataHandle to make a later refactoring of ArrayBufferContents easier. Bug: chromium:1008840 Change-Id: I9bcdee83e26eeccc7a8028c0bf3dd8fe9a455692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868993Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#708162}
-
Julian Pastarmov authored
Those fields are irrelevant for the user when local sync is turned on because no connection with a sync server can be established in this case. BUG=972563 Change-Id: I8dab3c48215b8c8fa05218d0df5e318923a849da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859974Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#708161}
-
Andy Paicu authored
This is a reland of 55a4bb68 The original CL caused a crash (crbug.com/1016233) The first patchset is the original CL, unmodified. https://chromium-review.googlesource.com/c/chromium/src/+/1860015 introduced a crash because InfoBarService::RemoveInfoBar DCHECKS that the infobar is part of the owned list of infobars. When the tab is closed, the infobar is removed but then the PermissionPromptAndroid object destructor attempts to remove it again. This CL ensures that that this situation does not happen by listening for the infobar remove event and ensuring we don't try to remove the infobar that was already removed. Original change's description: > Kill quiet permission requests if a new request is made > > Bug: 1014026 > Change-Id: I5fe93b9bc7b39873900d9e15dcba66dfddd7c4ef > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860015 > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706445} Bug: 1014026, 1016233 Change-Id: Iaa857811c6617afd97af9708a51ea49ea98fe385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871698 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#708160}
-
Manu Cornet authored
That CL had removed the line that is being re-added here, causing the |home_launcher_animation_state_| field to never get updated. TBR=newcomer@chromium.org Bug: 1006013, 1012353, 1013737, 1015995, 1012760 Change-Id: I489a4df984b2221b299a2bc31692b2ce38b9730a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873725Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#708159}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/74d521f2..704ce5c7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I13d420c6ff5caa01d2df93375459cadecb621b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871902Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708158}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b9014fb4bb68..85a10001a508 git log b9014fb4bb68..85a10001a508 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 danilchap@webrtc.org Use deprecated SingleThreadedTaskQueueForTesting as regular task queue Created with: gclient setdep -r src/third_party/webrtc@85a10001a508 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Id24d86e7932540276a21e661097134cec758196a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873590Reviewed-by:
-
Peter Kasting authored
Bug: 82078 Change-Id: I83c992a0c9eaaf1130ace3892cc38dbfeb266214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872983 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#708156}
-
Leo Zhang authored
Add the IME decoder flag in the chrome://flags, so that QA/Dev can turn on/off the feature to verify native deocers. Bug: 837156 Change-Id: I6ace99acf2127958ec4f0868962c721c035fd06d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866370 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Cr-Commit-Position: refs/heads/master@{#708155}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ca28b0ef0037..e3dcc758ca56 git log ca28b0ef0037..e3dcc758ca56 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 dburger@chromium.org Change controller_util and goma_util to handle custom goma approach. Created with: gclient setdep -r src/third_party/chromite@e3dcc758ca56 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I00260f81a2e7489aad99e0ff600cbe0cd3f2ee4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873592Reviewed-by:
-
Mihai Sardarescu authored
This CL ensures that the OAuth multi-login endpoint is always used by the Mirror account reconcilor. The feature |kUseMultiloginEndpoint| is removed from ChromeOS, Android and iOS and is now moved to DiceAccountReconcilorDelegate. Bug: 1013610 Change-Id: I02299b15225e1666d5160bac2ef25d767c3d01c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859966 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#708153}
-
Jan Wilken Dörrie authored
This change replaces existing usages of mutable base::Value::GetList() with newly introduced ListValue APIs in //components/autofill and //components/password_manager. Bug: 646113 Change-Id: I0b0bea5d341951585698ad7438a43be459198c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872212Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#708152}
-
Bettina authored
Currently, there is only one callback in the hash_password_manager.h file and the comments aren't clear enough. The callback is currently only called when there is a change in the |kPasswordHashDataList| and the change is not associated to a first sign-in and the save was successful. Bug: 1016458 Change-Id: I422843144778a2e40eafd1f831576fae9a2d5fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872737 Auto-Submit: Bettina Dea <bdea@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
-
Clemens Backes authored
The methods are deprecated and will be removed in V8 v8.1, thus we need to stop overriding them in chromium. R=rmcilroy@chromium.org CC=ulan@chromium.org Bug: v8:9810 Change-Id: I43d47c87c388a7c93ea87956b75f1db79d78fdb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871592Reviewed-by:
-
Mathias Carlen authored
Before this patch we only provided listAction and performAction as _pure_ direct actions. Via listActions more actions would be exposed and available to be performed via performAction. This patch also exposes dynamic actions as reported by listAction as _pure_ direct actions so that an external direct action user can perform them directly instead of the indirecation through performAction. R=szermatt@google.com Bug: b/138833619 Change-Id: If8d0f09d28bd8fa8f9d1681570cfc3dbfbbb5c18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866830 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#708149}
-
Oriol Brufau authored
This reverts commit 8d3d941a. Reason for revert: 20% performance regression in nested-grid. Bug: 1015213, 935102 Original change's description: > [css-grid] Accommodate spanning items crossing flexible tracks > > The specification added a step to increase sizes to accommodate spanning > items crossing flexible tracks instead of ignoring their contents > completely. This is done after handling all grid items that don't cross > such tracks, and this time items are considered together, not grouped by > their span size. > > Spec: https://drafts.csswg.org/css-grid/#algo-spanning-flex-items > > BUG=935102 > > TEST=third_party/blink/web_tests/external/wpt/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-001.html > TEST=third_party/blink/web_tests/external/wpt/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-002.html > TEST=third_party/blink/web_tests/fast/css-grid-layout/flex-and-content-sized-resolution-columns.html > TEST=third_party/blink/web_tests/fast/css-grid-layout/grid-gutters-and-flex-content.html > > Change-Id: Ic91a2eb471fae23cde1570c461f491cd5335d771 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492337 > Reviewed-by: Javier Fernandez <jfernandez@igalia.com> > Reviewed-by: Sergio Villar <svillar@igalia.com> > Commit-Queue: Oriol Brufau <obrufau@igalia.com> > Cr-Commit-Position: refs/heads/master@{#705228} TBR=jfernandez@igalia.com,rego@igalia.com,svillar@igalia.com,obrufau@igalia.com Change-Id: Id6ad085e32bfb3ae947459c2fc56d097c2dadb94 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 935102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872593Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#708148}
-
Rune Lillesveen authored
We checked for non-null GetComputedStyle(), but it may also be non-null inside display:none when ensured from getComputedStyle(). Skip generating pseudo elements for that case. This caused a DCHECK failure due to an incorrect marking for layout tree re-attachment inside display:none. Bug: 1013570 Change-Id: I75318b9d3bed1ed68dab232d90bbdc9b68655152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872096Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#708147}
-
Juan Antonio Navarro Perez authored
Fix was landed in: https://chromium-review.googlesource.com/c/chromium/src/+/1691586 Keeps browse:social:tumblr_infinite_scroll:2018 disabled as the story is constantly failing in CQ. Bug: 970058 Bug: 1016701 Change-Id: Ifc128a5c00d00f04c9773f6be11bf9a145403d38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872057 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#708146}
-
Francois Beaufort authored
This CL makes sure NDEF tags still fire an onreading Web NFC event even if there are no messages yet. This results in a NDEFMessage with no records as discussed in https://github.com/w3c/web-nfc/issues/367. Bug: 520391, 1012463 Change-Id: Ib87980cfc7354561146f7854272b247fb6df5a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871550 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
-
Alex Chau authored
Bug: 1011364 Change-Id: I74c42e37b9ca04c22e0d3ce1e84873b4a2765309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872217 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#708144}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9df4d22529ce..1e7968db31d4 git log 9df4d22529ce..1e7968db31d4 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 ulan@chromium.org Revert "[vinn] Enable snapshots and update Windows d8 binary to 7.6.303.31" Created with: gclient setdep -r src/third_party/catapult@1e7968db31d4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:1001953 Change-Id: If1ae7ebc940629b1e655f000d6e8fb11f179522b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873589Reviewed-by:
-
Richard Knoll authored
We only handled some whitespace characters by using \s in the regex. One example that is not handled by that is the non breaking space which is quite common in HTML formatted text. Switching to \p{Z} to consider all unicode characters for whitespace fixes this. Bug: 1015189 Change-Id: Id3e6b3fe98a303e84d1b8427a227bc12a42d6664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872089 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#708142}
-
Tanja Gornak authored
Bug: 945553, 1009993, 960043 Change-Id: Ie359b8088943177af3eb7fe5689662d188d65650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864688Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#708141}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dd844944..74d521f2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I100f66d9633d8b52c34380d661b1ee8252ea605a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871901Reviewed-by:
-
Juan Antonio Navarro Pérez authored
This reverts commit 02b03541. Reason for revert: Test no longer appears to fail. Original change's description: > Disable flaky system_health.memory_desktop/browse_accessibility:media:youtube > > TBR=perezju@chromium.org > > Bug: 983326 > Change-Id: I22be996f9054935f378a05b95f7f7924a9c5f63b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699097 > Reviewed-by: danakj <danakj@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#677130} TBR=crouleau@chromium.org Bug: 983326 Change-Id: If9cb5e9a1d674e49709edbbee4dd2ceafe5bb21b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871998Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#708139}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e8c3f9b0b463..615918c91d1d git log e8c3f9b0b463..615918c91d1d --date=short --no-merges --format='%ad %ae %s' 2019-10-21 stevenperron@google.com Update CHANGES Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@615918c91d1d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,jonahr@google.com Bug: None Change-Id: I61e2804c96dd058af5f8c9b918d0bfdc1a1b358f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873588Reviewed-by:
-
Ankit Jain authored
This reverts commit 77cff635. Reason for revert: <Reverting because of issue (https://bugs.chromium.org/p/chromium/issues/detail?id=1016357#c3) > Original change's description: > Adding asyn auth api, and moving Windows auth call to thread pool. > > When user tries to export password or view saved password by visiting > chrome://settings/passwords url and clicking on "Export passwords..." > or eye icon on password list respectively, OS Reauthentication is > triggered, and on successful authentication plain text password is > revealed. Currently OS authentication call is on UI Thread. > And if OS authentication takes time, it freezes/hangs > browser. This change has made authentication api async, and moved > windows authentication call to thread pool from UI thread. Since the > UI thread will be freed, browser will not freeze or hang. > > Bug: 1007950 > Change-Id: I2f35707fe458687a4ec22de1381d21ec9603733f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828730 > Commit-Queue: Ankit Jain <ankjain@microsoft.com> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707029} TBR=vasilii@chromium.org,ankjain@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1007950 Change-Id: I911ec3a83b24394ce5544e6ecb7f819e519a6bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873567 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#708137}
-
Gauthier Ambard authored
Bug: 987646 Change-Id: I6a7b80daea151ba6bb1400ab578ad35a1a51be53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872211Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#708136}
-
Yi Su authored
web::features::UseWKWebViewLoading is a helper method that uses 3 related feature flags to control the new feature of using WKWebView.loading for WebState::IsLoading: 1. kSlimNavigationManager is used because we only want to fix the failing test cases with slim-nav enabled; 2. kLogLoadStartedInDidStartNavigation is used because the CPM metric was logged in WebStateDidStartLoading. This flag moves the logging to WebStateDidStartNavigation, and if it's enabled then the CPM won't be affected by this feature; 3. kUseWKWebViewLoading is the flag for this feature, because we want to use it for experiment with kLogLoadStartedInDidStartNavigation enabled to make sure that this feature doesn't change CPM. Bug: 991763 Change-Id: I99fe31317277163eb4768b2db1c9ef8f5d2dd844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833470Reviewed-by:
-
