- 28 Sep, 2018 40 commits
-
-
Mike Wasserman authored
This CL reverts my recent cleanup changes here: https://crrev.com/c/1246826/7/ui/aura/window_targeter.cc#b140 The event target may not be |root_window| nor one of its descendants. Bug: 890062 Test: Touch input on linux desktop works correctly. Change-Id: Icf49255b55797488ecc186597de910ecde600efc Reviewed-on: https://chromium-review.googlesource.com/1251467 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#595206}
-
Etienne Bergeron authored
Follow-up on this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1249909 R=piman@chromium.org, oysteine@chromium.org Bug: 888580 Change-Id: Ia8a6404b7a750f102d224f173abf59c48c5e3b10 Reviewed-on: https://chromium-review.googlesource.com/1251765Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#595205}
-
Jialiu Lin authored
A CHECK in base::Value::FindKey(..) is hit in a small number of crashes during shutdown. A check should be in place to make sure the base::Value instance is in fact a dictionary before calling FindKey(..) Bug: 890399 Change-Id: I0b24395afc192dbab03f241d94b25309923758d6 Reviewed-on: https://chromium-review.googlesource.com/1252623Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#595204}
-
James Cook authored
This reverts commit e392dddd. Reason for revert: Follow-up design discussions with dmazzoni and dtseng suggest that this might not be the right direction to go. Instead we might want to use AXHostService as the way that both out-of-process ash and remote app windows/widgets talk to the browser. We may also have a different mechanism for assigning AX child tree IDs per-widget. Original change's description: > chromeos: Move AXHostService into ash > > This is a step toward supporting multiple remote apps and widgets. We > need this for browser windows under single-process-mash. > > Under mash the ash process is responsible for top-level window creation > for remote apps. It will need to route accessibility actions (like hit > testing) to the correct remote app. Likewise it manages window frames > and focus. Therefore it should own the mojo AXHostService, not the > browser. > > Accessibility events from the remote app must be routed out of ash > into chrome to the accessibility extension. For now we do this with > the in-process AccessibilityDelegate. I didn't introduce a new delegate > because the mojo service is lazily created and it's hard to connect > a new delegate at startup. Subsequent CLs will: > * Always create the service at ash startup > * Convert the delegate methods to mojo > > See go/mash-ax-node-tree for the full plan. > > Bug: 888147 > Test: ash_unittests, manually use ChromeVox and STS with shortcut viewer > Change-Id: Ia9e63689a8cb407b66397778be4617479fdf6c92 > Reviewed-on: https://chromium-review.googlesource.com/1249920 > Commit-Queue: James Cook <jamescook@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594949} TBR=jamescook@chromium.org,sky@chromium.org,dtseng@chromium.org Change-Id: I156656b5114a28693308252ee531bbf4c3db867a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 888147 Reviewed-on: https://chromium-review.googlesource.com/1252629Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#595203}
-
Becca Hughes authored
Adds a NewTabWithUserActivation method to open a new tab with a user activation. This means that the page will behave as if the user has interacted with it and autoplay will always be allowed. This CL also tweaks assistant to use it so that it can open tabs without the autoplay restriction. BUG=884777 Change-Id: I7c9327b438ac51003442f0e97bd6e63086fb48cd Reviewed-on: https://chromium-review.googlesource.com/1239543Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
-
Vladimir Levin authored
This patch ensures that we don't leak geometry outside of paint contained element, which may incorrectly affect layout oveflow of other elements. Added a WPT with a tall clipped div which causes scrollbars without this patch, and passes with the patch. R=chrishtr@chromium.org Bug: 882322 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I929542d4ad643df8dad1ab388a878bd0892c0c69 Reviewed-on: https://chromium-review.googlesource.com/1246922 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595201}
-
Devlin Cronin authored
In practice, Extension objects are pretty much always const. Update extensions/browser/api_unittest.h to use const Extension objects, rather than mutable ones. Bug: 889925 Change-Id: I7e13dac4376eb0e358a30e2fe49154976f02fb0d Reviewed-on: https://chromium-review.googlesource.com/1252008Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595200}
-
Kyle Milka authored
When undo is pressed on the theme installation info bar the background should be reset to the selected custom background. To accomplish this run the same update theme info logic whenever the theme is changed. Bug: 881750 Change-Id: I1fe5d8d2f8c6d9459a65a4cd801b5583b8f21935 Reviewed-on: https://chromium-review.googlesource.com/1252461 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#595199}
-
Benjamin Shaya authored
Also refactors all FilterGroup contruction out of StreamMixer into a more focused class. Bug: 112439135 Test: tuning console Change-Id: I2c8011a73bdc641eb0b014a18dd3448b6bacb5ed Reviewed-on: https://chromium-review.googlesource.com/1244608Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Benjamin Shaya <bshaya@chromium.org> Cr-Commit-Position: refs/heads/master@{#595198}
-
Nick Harper authored
This removes most Token Binding code from chromium. There are a few places that still have Token Binding references (but will go unused) that can possibly be removed in the future. These are: - android_webview/ - net/third_party/quic/ - third_party/tlslite/ There are two UMA histograms in //net that also have TokenBinding in their name; these are (confusingly) used by Channel ID code as part of the work on debugging Channel ID mismatches, and can be removed with the rest of the Channel ID code. Bug: 875046 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ie3d23f8e9580f2d582febfb04e777006f57baa17 Reviewed-on: https://chromium-review.googlesource.com/1248125Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#595197}
-
Patrick Monette authored
Bug: 889346 Change-Id: I44a357c52c0a37064e1bb98bf2cfaef44e60db6b Reviewed-on: https://chromium-review.googlesource.com/1246947Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#595196}
-
Vladimir Levin authored
R=chrishtr@chromium.org, pdr@chromium.org, wangxianzhu@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3d4efdc5e5f164cd990f76a8d5f863f3e5db3942 Reviewed-on: https://chromium-review.googlesource.com/1249861 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
-
Aaron Leventhal authored
For get_characterExtents() at the offset just past the last character, return bounds equivalent to the caret's bounds if it placed there, e.g. width of 1, but the same height as the current line. Bug: 869985 Change-Id: Ib544b863c1fd7ab132dc5ff4ddbeebdde8ed342b Reviewed-on: https://chromium-review.googlesource.com/1157228 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#595194}
-
Aaron Leventhal authored
In some versions of MacOS, live regions don't work consistently, due to a bug in those versions of VoiceOver. Due to these bugs, use the announce API when running on an older version of MacOS. Bug: 884801,875843 Change-Id: Ia9711cf935ba605785dfb3cfaf32f85bd2c8cf13 Reviewed-on: https://chromium-review.googlesource.com/1228635 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
-
Charlie Harrison authored
This CL keeps most usage of the DocumentLoadStatistics struct as a normal struct and not a *Ptr, since we don't really need nullability. Bug: 820612 Change-Id: Ib00002d6b5d320fa7bf4341812f3aca26da2e244 Reviewed-on: https://chromium-review.googlesource.com/1214506 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595192}
-
Steve Anton authored
This change implements the RTCQuicTransport.start() method and associated events: onstatechange, onerror. Bug: 874296 Change-Id: I8cb5d525ff5dd9d7d0a07a306f72297febc9aaaa Reviewed-on: https://chromium-review.googlesource.com/1171904 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#595191}
-
Stefan Zager authored
Prior to this patch, IntersectionObserverEntry was reporting coordinates in device pixels. BUG=887974 Change-Id: Ic91748cd2eb9b828a787bb4372d5d5b10bcf8cfb Reviewed-on: https://chromium-review.googlesource.com/1250121 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
-
Mustaq Ahmed authored
Change-Id: If1678386ef82177792ed0b5e3ed091249eb901c6 Reviewed-on: https://chromium-review.googlesource.com/1251764Reviewed-by:
-
Egor Pasko authored
Introduce a commandline flag --ignore-background-tasks that would be set by Telemetry when running startup benchmarks to avoid random tasks from caching the process and skewing the metrics that are based on process creation. The bug has an example trace and more details. Bug: 890424 Change-Id: I456e0f15406ebba7c930f8ec445da0759e9a087d Reviewed-on: https://chromium-review.googlesource.com/1252382Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#595188}
-
Peter K. Lee authored
Official build with Firebase enabled uses variants to specify which Info.plist to use as resource for Firebase. This causes a conflict as two bundle_data have the same output path. Move the dependency on ios_firebase_resources_target to the definition of the "chrome" target, behind the check for use of the variants to prevent this conflict. Patchset 1 is the original CL http://crrev/c/1250924 by sdefresne from which this CL is cloned from. TBR=sdefresne@chromium.org, justincohen@chromium.org Bug: 845383 Change-Id: I0e74f04f27708eb970c61b1048cb2492c45cbba4 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1252321 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#595187}
-
Chong Zhang authored
Some tests (e.g. ArcSessionManagerTest.ConsumerAccount) are already flaky on waterfall, and we don't want them here to avoid confusions. Bug: 881976 Change-Id: Iddc8fd5f18ab6abe54038a5078750bf16968c272 Reviewed-on: https://chromium-review.googlesource.com/1252011Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#595186}
-
Vasilii Sukhanov authored
Bug: 890336 Change-Id: I649336ca32aa4b23b8859a06f44bdf8dc7a6da26 Reviewed-on: https://chromium-review.googlesource.com/1251464 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#595185}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/656cefe65d62..f88f49d2a52e git log 656cefe65d62..f88f49d2a52e --date=short --no-merges --format='%ad %ae %s' 2018-09-28 mtklein@google.com Revert "Have Renderer use combined path code" 2018-09-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 e8dd07969872..af0f31d3a909 (2 commits) 2018-09-27 csmartdalton@google.com Cleanup resource flags 2018-09-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 122919bddd98..e8dd07969872 (4 commits) 2018-09-27 bungeman@google.com Detect macOS font smoothing behavior. 2018-09-27 egdaniel@google.com Remove assert about top left origin in lazy image generator unique key. 2018-09-27 herb@google.com Have Renderer use combined path code 2018-09-27 nathanrogers@google.com Fix a typo in SkISize comments 2018-09-27 bsalomon@google.com Reland "Change how GrTextureOp computes outset vertices." 2018-09-27 scroggo@google.com Make SkCodec truly default to sRGB 2018-09-27 borenet@google.com [infra] Add nightly UpdateGoDEPS Created with: gclient setdep -r src/third_party/skia@f88f49d2a52e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:858861,chromium:887372 TBR=bsalomon@chromium.org Change-Id: I4800ec89e6f922e57489b97b2672cf009c93dd34 Reviewed-on: https://chromium-review.googlesource.com/1250949 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595184}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f0aa6f4e3a57..32381e30ef56 git log f0aa6f4e3a57..32381e30ef56 --date=short --no-merges --format='%ad %ae %s' 2018-09-28 stevenperron@google.com Handle decoration groups with no decorations. (#1921) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@32381e30ef56 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iac1c369a62c44201f68dabec0be16659431390e7 Reviewed-on: https://chromium-review.googlesource.com/1252262Reviewed-by:
-
Theresa authored
Add an animtion for the button appearing and disappearing. Also animate the button when the URL is focused/unfocused. BUG=889536 Change-Id: I7ca53c2e41da3bedab5b07a133ab4475887c3e17 Reviewed-on: https://chromium-review.googlesource.com/1246944 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#595182}
-
Torne (Richard Coles) authored
The supported version of the Android NDK now provides sys/ucontext.h for all architectures, and we no longer need to provide our own definitions. Keep the ones used by PNaCl but update the defines to no longer use them on Android. Bug: 437330 Change-Id: Ia46c746b17b72261842284d4fed3772fea3a96ef Reviewed-on: https://chromium-review.googlesource.com/1252243Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#595181}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7453eba4feb2..d525ef309fca git log 7453eba4feb2..d525ef309fca --date=short --no-merges --format='%ad %ae %s' 2018-09-28 perezju@chromium.org [pinpoint_cli] Add isolate_service module. Created with: gclient setdep -r src/third_party/catapult@d525ef309fca The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:879526 TBR=sullivan@chromium.org Change-Id: Ic1f1490a93133c829095aa4f3d53710bf58a6fa7 Reviewed-on: https://chromium-review.googlesource.com/1250945Reviewed-by:
-
Fabio Tirelo authored
Bug: 874094 Change-Id: Id80332c84f574b70ba0b0e50f54aebb681276082 Reviewed-on: https://chromium-review.googlesource.com/1251229Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#595179}
-
Egor Pasko authored
This is a followup to crrev.com/595106, realizing that there are ~80 more lines to change. The same (anti)pattern is found in: shell> git grep '\\\\\\/' -- '*.py' # my job is counting slashes android_webview/support_library/PRESUBMIT.py mojo/PRESUBMIT.py native_client_sdk/PRESUBMIT.py third_party/blink/PRESUBMIT.py third_party/blink/renderer/bindings/PRESUBMIT.py Not updating these files now because: 1. lazy 2. allowing the world where this might break 3. will shoot those at different OWNERS Bug: None Change-Id: Ib9d9209098147fa9a36bb179a138b625ad2ff3d6 Reviewed-on: https://chromium-review.googlesource.com/1251629Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#595178}
-
Jialiu Lin authored
The incognito mode profile should be aware of the user's advanced protection status (from original profile) if the user signs into Chrome. Bug: 887754 Change-Id: Ic4dec677f9adf1464b8c7398934f2d10cb62323b Reviewed-on: https://chromium-review.googlesource.com/1247001Reviewed-by:
-
Matt Wolenetz authored
In 1240638e, AVC keyframeness analysis result in MP4 was used instead of MP4 keyframe metadata, but the conversion of the AVC frame to Annex-B (and the conditional injection of SPS/PPS) still relied upon the MP4 keyframe metadata. Since that metadata could be incorrect, decode errors could occur on some decoders due to missing SPS/PPS data for incorrectly muxed AVC keyframes. This change performs the bitstream analysis as part of frame conversion, after converting to Annex-B, but before the conditional SPS/PPS injection, and uses the analysis's keyframe result (if determined) to condition the injection instead of the MP4 keyframe metadata. BUG=889311 Change-Id: I1ef327ef7d399d5a9da552e0da4a58b0f0b04435 Reviewed-on: https://chromium-review.googlesource.com/1250171 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#595176}
-
Troy Hildebrandt authored
Keys and entries can currently be loaded separately, but never at the same time, meaning it requires separate calls to LoadKeys/LoadEntries to get keys and entries. Some users of ProtoDatabase have resorted to storing the keys in the entries to get around this. This CL adds LoadKeysAndEntries(WithFilter) that returns both at the same time. ProtoDatabase's new LoadKeysAndEntriesCallback gives back a vector of string/proto pairs. Bug: 883409 Change-Id: Id624bbdeb356395c6ce679528d85c1f934a9772e Reviewed-on: https://chromium-review.googlesource.com/1228305 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#595175}
-
Chris Palmer authored
De-confuse the terminology. Bug: None TBR: avi, caitkp, rdevlin.cronin, eugenebut, dalecurtis, mmenke, jsbell, foolip, tsepez, dcheng Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo Change-Id: I47f32cdd2e937c0f0014a4813a4ddfd74b049d73 Reviewed-on: https://chromium-review.googlesource.com/1247227 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#595174}
-
Jeffrey Kardatzke authored
This is a temporary solution to taking screenshots for tast-tests that will work properly on ARM devices as well as deal with hardware overlays. Longer term the plan is to implement this via the DRM API with a write-back connector and then use that from the CLI screenshot program. BUG=chromium:849438,chromium:880597,chromium:887016 TEST=tast run graphics.Screenshot (after updating it to use this) Change-Id: I3919822599338e4786c715d7b0419742417b83c2 Reviewed-on: https://chromium-review.googlesource.com/1247181 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#595173}
-
Avi Drissman authored
BUG=none TBR=wittman@chromium.org Change-Id: If60be20e1ef4e59838be04821eec0b30eba4d2be Reviewed-on: https://chromium-review.googlesource.com/1252242Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#595172}
-
Avi Drissman authored
BUG=880210 TEST=as in bug Change-Id: I9f305084bf9f6b146d0323baeabc4437466857df Reviewed-on: https://chromium-review.googlesource.com/1252241Reviewed-by:
-
Francois Doray authored
TBR=acondor@chromium.org Bug: 890380 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibce268155e198a855e6815bced44578001b8279e Reviewed-on: https://chromium-review.googlesource.com/1252083Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#595170}
-
Ben Pastene authored
Bug: 876587 Change-Id: I340c12102a697d6f1b710594111536de564a338c Reviewed-on: https://chromium-review.googlesource.com/1239354 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#595169}
-
Tonko Sabolčec authored
This CL includes: - Enable feature for deleting corrupted passwords - Enable feature for preventing overwriting the encryption key - Disable feature that recovers passwords for Sync users (covered with the new feature) - Update tests Bug: 791541 Change-Id: I1726515dbd74ad2fa64ef1abf419e88c65d48bf0 Reviewed-on: https://chromium-review.googlesource.com/1240300 Commit-Queue: Tonko Sabolčec <tsabolcec@google.com> Reviewed-by:Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#595168}
-
Xida Chen authored
We have num_of_active_touches_for_test in both TouchActionFilter and InputRouterImpl class which are used in InputRouterImplTest only. This CL makes InputRouterImplTest a friend class to TouchActionFilter so that we can just access its private member. This CL is a code cleanup, there is no behavior change introduced. Bug: None Change-Id: I768a5e293f5c16d1f1d39af7e2abf161f35e669d Reviewed-on: https://chromium-review.googlesource.com/1246274Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595167}
-
