- 11 Aug, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/109ff207de7d..5edf510941a3 2020-08-11 robertphillips@google.com Add plumbing for access to the flush-time GrSmallPathAtlasMgr 2020-08-11 adlai@google.com Revert "Migrate GrSurfaceContext readPixels to take direct context" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: fmalita@google.com Change-Id: I9b4124294f4a05ab39b9fb3e563c07e55dbc65ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348201Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796825}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea4f2acc6399..ad052807cdc7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC apotapchuk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: apotapchuk@google.com Change-Id: I71e9d2d21d6cc1d1e23f95bfa2ce9e59964c6789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347175Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796824}
-
Anatoliy Potapchuk authored
Previously, if a test was a part of a suite, we would not have filtered it out properly using oobe_{positive,negative}.filter files. This cl fixes that TBR=antrim@chromium.org Bug: 1114907 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ib6b8adf5be12b7f0e5c7cc599dc049a7ecf748eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346336Reviewed-by:Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#796823}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dc4568899168..21e5b4554a5f 2020-08-11 fmayer@google.com Merge changes I5ec5382a,I40f4bf4a 2020-08-11 fmayer@google.com Merge "Disable MTE when copying stack." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I07b10519de332bb8eb25ffdc2e755244f1ebca53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348277Reviewed-by:
-
Friedrich Horschig authored
In order to natively delete a credential, the compromised credential on the java-side needs to contain unformatted information about username, origin, sign-on real, and password. Therefore, this CL: * adds the required key attributes * makes the key attributes accessible by making JNI headers available * makes interfaces that pass 7 attributes to construct a credential pass the credential directly instead (minimizes confusion) The actual delete call is only one line in the password_check_manager that triggers the deletion and indirectly updates to the UI once the deletion happened. The deletion promoted two smaller errors which were one-line-fixed: * the mediator never clear old credentials — it just appended new ones * the confirmation dialog triggered twice (once with a null handler) Screenshot of the entire flow in the linked bug. Bug: 1108358, 1092444 Change-Id: I1f1a3f6e73c40c316cb2f711c44236388ff05b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346345 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#796821}
-
Joe DeBlasio authored
This CL ensures that a given URL is not on the lookalikes / safety tips allowlist before eliding to eTLD+1. At present, the allowlist is very coarse-grained and doesn't disambiguate between what the allowlist entry is there to allowlist against (i.e. which UI treatment shouldn't be applied). A future change will add a bit more nuance. Bug: 1106962 Change-Id: I31eeb921afd5af89c8a1a2b1efc2b91c521eedc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346841Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#796820}
-
Marc Treib authored
Followup to https://crrev.com/c/1989533 Sync supports delaying the engine startup by 10 seconds. This is meant for avoiding contention during browser startup. Before this CL, the 10-second delay would also apply in one other (rare) situation, for no good reason other than some tests depending on this behavior. Two of these tests were recently fixed (in crrev.com/c/2339986), and the one remaining one is fixed in this CL. With that, the delayed startup can now go away! Bug: 1035874 Change-Id: I865d0bc3caac4d8f0712489ccbad526f912ccdce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343036Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#796819}
-
Alice Wang authored
This CL adds a spinner for sign-in in progress page of web sign-in and makes the horizontal divider disappear on the same page according to the UI mock. Screenshot: https://crbug.com/1102784#3 Bug: 1102784 Change-Id: I95cbc474a161c58ba235ddede70405c55e7db3b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345147Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#796818}
-
Ella Ge authored
This CL adds a UMA metrics to record when a TWA quality enforcement violation occurs. It records a enum of the type of violations. Bug: 1109609 Change-Id: Ic889b98fbb68a734d3bdd956a1ec76ef9a099d1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340123 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#796817}
-
Elly Fong-Jones authored
It is flaky on every platform to differing degrees. Tbr: sadrul@chromium.org Change-Id: I4dde9bdc58aafc958b95cedda2a4ade29943d03a Bug: 1086334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348691Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#796816}
-
Chris Sharp authored
Bug: 1109226 Change-Id: I48686b49c58a9b26a1aeae5e1634c1a2f2840930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347024Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#796815}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dd1a9165..c2df5e99 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6b46033f8a37978b647b35eeefb0852716746976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348576Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796814}
-
Elly Fong-Jones authored
This reverts commit b772a8f1. Reason for revert: introduced https://crbug.com/1115091 Original change's description: > [Web Payment] Secure payment confirmation Blink parameters. > > Before this patch, requesting "secure-payment-confirmation" method in > PaymentRequest API would not validate the parameters. > > This patch adds the "secure-payment-confirmation" parameters to > PaymentRequest API and validates them, if the > "SecurePaymentConfirmation" feature is enabled. > > After this patch, PaymentRequest API validates the secure payment > confirmation parameters. > > Explainer: https://github.com/rsolomakhin/secure-payment-confirmation > Feature status: https://chromestatus.com/feature/5702310124584960 > Intent to prototype: > https://groups.google.com/a/chromium.org/g/blink-dev/c/myUR5gyd5Js/m/iELL67NQAgAJ > > Bug: 1110324 > Change-Id: I7a4b6f9da1b3e1d7604bcd9e4733dc789f77ec4b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341163 > Reviewed-by: Nick Burris <nburris@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org> > Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796792} TBR=rouslan@chromium.org,kouhei@chromium.org,nburris@chromium.org Change-Id: I5c07ed9bdb1bcd9526ab84e7fdd1ed3a842737a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1110324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348532Reviewed-by:
-
ckitagawa authored
It looks like the previous fix: https://crrev.com/c/2339757 introduced a bug where the first bitmap doesn't display in portrait mode. The fix is simply adding a missing = sign. Bug: 1113322 Change-Id: Ie04ab5607f1eb4f6a4182581d373a78b9c4090c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347370 Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#796812}
-
Kyle Horimoto authored
This CL creates the //chromeos/components/phonehub/ directory and introduces a new class which provides the status of the Phone Hub feature. Currently, this new class is unit tested but not actually instantiated in real code yet. A future CL will create a KeyedService and initialize the class when the KeyedService starts up. Bug: 1106937 Change-Id: I27f46f62d3246149d0cef53e4ea01dd41bb879e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345665 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#796811}
-
Annie Sullivan authored
This allows the developer to easily implement a threshold different from the default 500ms, and brings the implementation into conformance with the spec. Bug: 1114793 Change-Id: I2b3ed36679f113576e4d301ab734270ae92ebb69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346793Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796810}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597125357-adec03df0679051d9df22e43cd9f58968dde96e7.profdata to chrome-mac-master-1597147084-8c4cc9658838494b8781316d2fe64028822c8b91.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I275b39a0a2768b05f62d2d2b6fb82da1d973790b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348200Reviewed-by:
-
Kent Tamura authored
PaintMask() should take care of the rendered legend. - NGBoxFragmentPainter::PaintMask() checks if the fragment is a fieldset container, and delegate to NGFieldsetPainter if so. - NGFieldsetPainter::PaintMask() creates FieldsetPaintInfo, and adjust the paint rectangle. - NGFieldsetPainter now has CreateFieldsetPaintInfo() to share FieldsetPaintInfo creation logic between PaintMask() and PaintBoxDecorationBackground(). - Merge NGFieldsetPainter::PaintFieldsetDecorationBackground() into PaintDecorationBackground(). Bug: 875235 Change-Id: If6f7e709db538f99d699458938f5a1b2db9a8e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348229 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#796808}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fe1bb43b7a38..7e3e7bb35184 2020-08-11 aerotwist@chromium.org Early exit from copy-file(s).js 2020-08-11 jacktfranklin@chromium.org Add enum generation to bridges 2020-08-11 nidhijaju@google.com Reland "Removing "other origins" UI from DevTools Service Worker tab" 2020-08-11 szuend@chromium.org [ts] Type check ui/Action.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:807440 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I31f79ab12ce6462e79a332cf89fb4685930e2d44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347169Reviewed-by:
-
Andrew Grieve authored
Adds -Xmx1G to limit heap size to 1GB. My local test of R8 on MonochromePublic.aab had a peak RSS of 1.8GB with this flag and 8GB without it. Does not seem to cause the command to run measurably slower. I found that the r8 wrapper script in AOSP uses this same flag and so does the Android lint wrapper script. Bug: 1098333 Change-Id: Icca79bf6c1e9c8f003f613c178983f63cf9fbf04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348018 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#796806}
-
Niels Möller authored
Webrtc no longer uses the CodecInfo::is_hardware_accelerated, so we can rely on the default implementation of QueryVideoEncoder. Followup to https://chromium-review.googlesource.com/c/chromium/src/+/2338614. Bug: None Change-Id: I6446b1b42e60354d59d5b00f8aa7a841214e5a20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346655Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#796805}
-
Hazem Ashmawy authored
No change to logic. Adding hazems@chromium.org to aw/nonembedded/OWNERS. Bug: N/A Test: N/A Change-Id: I01d2ca22b638e36d02e83872bff760b86d3e061a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346270Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#796804}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c61e780dc832..64a60835a190 2020-08-11 eshr@google.com [Adaptation] Remove processing_in_progress_ from ResourceAdaptationProcessor 2020-08-11 nisse@webrtc.org Delete deprecated variant of VideoCodingModule::RegisterReceiveCodec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iefd1a7ee6d962fe1b57232708a9cb9bea573b90b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347172Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/01e0ccdc9b8b..dc4568899168 2020-08-11 fmayer@google.com Merge "Use typedef (as described in NDK API guide)." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9267f5476cf2d468d5da7dffcc024c2968ede61f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347171Reviewed-by:
-
Elly Fong-Jones authored
Bug: 1101399 Change-Id: I4d4b5201209371a20beb656137de2c3aff09ed94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346997Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#796801}
-
Swapnil authored
We want to improve the installation time for force installed extensions. For this, we need to first gather the statistics regarding which installation stages are time consuming. We collect the UMA statistics for the time taken to copy the extension archive to the working directory. Following histogram is added: Extensions.ForceInstalledTime.CopyingStartTo.UnpackingStart Bug: 1102369 Change-Id: I09f27e2f656581f318f32cbe137b0d1da9ab5e62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338794Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Saurabh Nijhara <snijhara@google.com> Reviewed-by:
-
Anatoliy Potapchuk authored
This has been causing a lot of NOTRUNS on the CQ. Since these tests are being run in the suite, they ware not properly filtered out by the CQ. Will upload another patch to mark all the suites properly in the filters after making the builder green. TBR=antrim@chromium.org Bug: 1114907 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I5e528e5c59d95f75c4dba679d23e0edd1533496d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346357Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/cbec3179ef87..11c0f579b1d2 2020-08-11 tommek@google.com Adding validation for requiredBytesInCopy overflow If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I38a6c3fe1ed8f78d66a61e19ed936bf084fa8774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349311Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bb67d54f9310..109ff207de7d 2020-08-11 robertphillips@google.com Tweak GrSmallPathAtlasMgr's cached path discovery methods If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: I87741282d8fe6ca13ee058033d90f8a58ae907ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347170Reviewed-by:
-
arthursonzogni authored
Patch [3/N] modified blink windows's binding to call CheckCoopAccess() whenever a "CrossOrigin" attribute/methods was accessed. This adds the same check for the named getter. COOP access reporting: [ 1/N] https://chromium-review.googlesource.com/c/chromium/src/+/2264294 [ 2/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270185 [ 3/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270472 [ 4/N] https://chromium-review.googlesource.com/c/chromium/src/+/2273120 [ 5/N] https://chromium-review.googlesource.com/c/chromium/src/+/2309433 [ 6/N] https://chromium-review.googlesource.com/c/chromium/src/+/2308715 [ 7/N] https://chromium-review.googlesource.com/c/chromium/src/+/2309697 [ 8/N] https://chromium-review.googlesource.com/c/chromium/src/+/2275889 [ 9/N] https://chromium-review.googlesource.com/c/chromium/src/+/2310530 [10/N] https://chromium-review.googlesource.com/c/chromium/src/+/2315024 [11/N] https://chromium-review.googlesource.com/c/chromium/src/+/2323250 [12/N] https://chromium-review.googlesource.com/c/chromium/src/+/2339353 [13/N] this patch. Bug: 1090273 Change-Id: I889031acfb0e925c8fa3cd0fd4c057c538d09332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346650Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#796796}
-
arthursonzogni authored
Patch [3/N] modified blink windows's binding to call CheckCoopAccess() whenever a "CrossOrigin" attribute/methods was accessed. This adds the same check for the indexed getter. COOP access reporting: [ 1/N] https://chromium-review.googlesource.com/c/chromium/src/+/2264294 [ 2/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270185 [ 3/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270472 [ 4/N] https://chromium-review.googlesource.com/c/chromium/src/+/2273120 [ 5/N] https://chromium-review.googlesource.com/c/chromium/src/+/2309433 [ 6/N] https://chromium-review.googlesource.com/c/chromium/src/+/2308715 [ 7/N] https://chromium-review.googlesource.com/c/chromium/src/+/2309697 [ 8/N] https://chromium-review.googlesource.com/c/chromium/src/+/2275889 [ 9/N] https://chromium-review.googlesource.com/c/chromium/src/+/2310530 [10/N] https://chromium-review.googlesource.com/c/chromium/src/+/2315024 [11/N] https://chromium-review.googlesource.com/c/chromium/src/+/2323250 [12/N] this patch. Bug: 1090273 Change-Id: Ia0e53c48de1859c734736a599f5050dca3b0b6a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339353Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
-
arthursonzogni authored
Expand the WPT tests: - property.https.html Into: - property.https.html - property-indexed-getter.https.html - property-named-getter.https.html This adds more test cases for accesses made using the indexed/named getter. This is subject to change, but the future implementations of COOP access reporting for the CrossOrigin named/indexed getter might have some limitations. The new tests were made to reflect this. We might catch only the accesses that would have returned an iframe. This is mainly caused by addressing this suggestion: https://chromium-review.googlesource.com/c/chromium/src/+/2339353/1/third_party/blink/renderer/bindings/templates/interface.cc.tmpl The call to ReportCoopAccess is likely going to be made from: V8Window::NamedPropertyGetterCustom(..) which is called by: -> V8Window::CrossOriginNamedGetter(..) -> V8Window::NamedPropertyGetterCallback This function is called numerous time, not only for the CrossOrigin method, but for almost all accesses. For now, the scope of COOP access reporting is limited to the "CrossOrigin" attribute/methods from the Window.idl file. This function is trying match the "name" with: 1. A CrossOrigin attribute/operations. 2. A named iframe. 3. A cross-origin interceptor. 4. An element with a matching name or ID in the document. 5. Abort and fallback to checking the context (unsure). Even if we don't catch all accesses, we must at least catch (2) and likely (4). Bug: 1090273 Change-Id: Id2b115dab83f0e53b4ab459dbb1f500d64d59956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346247Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/870a1acaea40..ea4f2acc6399 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC apotapchuk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:897470 Tbr: apotapchuk@google.com Change-Id: I6b0ff33230c6386e3643b4840082d4d6df02f94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348198Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, requesting "secure-payment-confirmation" method in PaymentRequest API would not validate the parameters. This patch adds the "secure-payment-confirmation" parameters to PaymentRequest API and validates them, if the "SecurePaymentConfirmation" feature is enabled. After this patch, PaymentRequest API validates the secure payment confirmation parameters. Explainer: https://github.com/rsolomakhin/secure-payment-confirmation Feature status: https://chromestatus.com/feature/5702310124584960 Intent to prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/myUR5gyd5Js/m/iELL67NQAgAJ Bug: 1110324 Change-Id: I7a4b6f9da1b3e1d7604bcd9e4733dc789f77ec4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341163Reviewed-by:
Nick Burris <nburris@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796792}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I9d66bcc60d13a2bc5480eef731069ef589500170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349310Reviewed-by:
-
Wez authored
Since there have been several AEMU rolls since the last version that we think was good, doing this as a normal CL rather than a revert. Tbr: chonggu@google.com Bug: fuchsia:58045 Change-Id: Ib534292189155bc7bd6313c67f61c5327f44175a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346334Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#796790}
-
Bruce Long authored
This change fixes an issue with the delayed initialization of the spellcheck service (a feature that in Chromium is currently behind the WinDelaySpellcheckServiceInit feature flag). While the first click in the editable content indeed initializes the spellcheck service by loading dictionaries, it does not guarantee a successful spell check request. Spelling may not be checked until further typing or focusing in a different editable element. If the text is long enough (multilined?), then a single click works. The bug is caused by a race condition in the mojo calls from the browser to the renderer process. There is no guarantee that the callback to the renderer process when InitializeDictionaries completes will be invoked in the renderer process after the call to SpellCheck::Initialize that results from the browser method SpellcheckService::InitForRenderer. If the first call wins the race, no spellchecking will occur because the spellcheck provider thinks there are no dictionaries available and does not check spelling. Mojo does not guarantee ordering in separate message pipes, which the SpellChecker and SpellCheckHost interfaces comprise. One fix that I considered was to make these associated interfaces that share a single channel between the browser and renderer processes. But I believe this risks breaking other platforms. So the fix I have here instead ensures that when the InitializeDictionaries callback is received in the renderer, SpellCheck::Initialize is called with the list of dictionaries provided by the browser process. Test coverage is provided by a browser test based on the original test that caught this bug (ChromeSitePerProcessTest.OOPIFSpellCheckTest): ChromeSitePerProcessSpellCheckTestDelayInit.OOPIFSpellCheckTest. The HTML source for this browser test contains just a snippet of editable content, so putting focus in it to invoke spellchecking and initialize the spellcheck service on demand exposed the issue. Bug: 1103847 Change-Id: I809e4aef3d51808d222012ddd0c0b46e3d57098a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335028Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Guillaume Jenkins <gujen@google.com> Commit-Queue: Bruce Long <brlong@microsoft.com> Cr-Commit-Position: refs/heads/master@{#796789}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/86f54785..dd1a9165 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia84c44fc4d9005e328d0f97a855319e058d4713e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348029Reviewed-by:
-
Rushan Suleymanov authored
This CL removes following feature toggles as they were enabled by default in M83 or earlier: * InvalidateBookmarkSyncMetadataIfClientTagDuplicates * SyncScheduleForEntityMetadataChangesOnly Bug: 1114738 Change-Id: Ic15e946e52124d49e28343e0969ffe0ed4931cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346654 Commit-Queue: Rushan Suleymanov <rushans@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#796787}
-
Wei Lee authored
We can pouplate the following data on load time: 1. I18N strings 2. Chrome specific data * Such as board name, CrOS version, etc Bug: 980846 Test: Check chrome://camera-app/strings.js Change-Id: Ieb46d4007ca93ca4d9e7a23bcd8005da65617ef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245986 Commit-Queue: Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#796786}
-
