- 09 Nov, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2f30936d46eb..5de0b38dd133 2020-11-09 rmistry@google.com [bugs-central] Add documentation for sheriffs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jlavrova@google.com Change-Id: I73e0b9d9cea981f7e99bf177ff73d3ad917c1e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525749Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825473}
-
Owen Min authored
Removing future and using unlisted and cloud_only for the following policy: AssistantOnboardingMode BYPASS_POLICY_COMPATIBILITY_CHECK=AssistantOnboardingMode is a launched policy with future tag. Bug: 1117637 Change-Id: Idf964a9e6bc661c4fd4d7e0eada34d847d9b286d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488043 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Felipe Andrade <fsandrade@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#825472}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b21a40d6e974..5226a88fe0de 2020-11-09 tvanderlippe@chromium.org Update karma-related packages 2020-11-09 jacktfranklin@chromium.org Fix new data-grid text overflowing in cells If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ica94a3f19faec1c7a440b851609c6f74ae520976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525751Reviewed-by:
-
Zach Trudo authored
EncryptedReportingJobConfiguration will allow CloudPolicyClient to upload EncryptedReportingJobs. Bug: chromium:1078512 Change-Id: I9b124346f4628eab888d591a1658a63d56fa6a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499072 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#825470}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b4a39160..c19c1b2c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I31e51003e0bc9680b0d78885249106728a900f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526626Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825469}
-
Friedrich Horschig authored
This CL defers adding the "Use other [password|username]" button until the newly introduced helper confirmed that there is at least one credential to show. To do that, the helper fetches the passwords when it's created. If it finishes before suggestions are to be refreshed, the stored boolean is used, otherwise, the callback is queued and will trigger an update. Smaller clean-ups: * New test fixture for filling (mostly moved to save setup code and to prevent ScopedFeatureList issues) * Moved accessory sheet state (focused field) into helper since frame state shouldn't be used by the accessory controller (if possible but required by all pwds sheet) Bug: 1104132 Change-Id: I4fa5757744dda5c2091fec24daf0654f92b2be46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489914 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#825468}
-
Victor Hugo Vianna Silva authored
This CL fixes the implementation of SendTabToSelfBridge::DismissEntry() to upload an updated sync entity with the notification_dismissed field set. As a bonus: - It increases test coverage for server uploads after the operations of sharing a tab, deleting an entity (e.g. on history deletion) and opening a notification. - Removes unused instances of ScopedFeatureList from the test suite. Bug: 1146376, 956722 Change-Id: Idc0c27fde0cb4444900cf4f64d0f8161f6fee0b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521816Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#825467}
-
Chong Gu authored
Bug: 1080853 Change-Id: Ibdb7b1b295e2ee05016baea32358dbc6a18c4cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523961 Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#825466}
-
Olivier Li authored
Bug: 1135528 Change-Id: I5d1a406854e5b6e7ef7a6c2421198c1358a2497c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499423Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#825465}
-
Scott Violet authored
This is a regression from: https://chromium-review.googlesource.com/c/chromium/src/+/2483342 The case under which the crash happens is when the internal cache (URLIndexPrivateData) is being rebuilt on the history thread and GetMostRecentVisitsForURL() returns false. I believe that basically only happens if there is a problem with the db. I would have liked a test for this, but there is no way to force the db to return false. BUG=1146970 TEST=none Change-Id: Ied6a7e1c75ef8fcc47043d231f4877a597757bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527006Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#825464}
-
Livvie Lin authored
Makes Safety Tip component updater logic available on iOS for use in lookalike interstitials and Safety Tips. Bug: 1140271 Change-Id: Iacf47c91d9fcaadf8a12a9475352eee27e882a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521446Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#825463}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9eff30af501c..0bec1380d03d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I91dca03f7a3bd073eb11b360ae94ef2baa5c846a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526905Reviewed-by:
-
Robert Kaplow authored
Remove the tracking/persisting of these metrics in prefs. Removed uploading in uninstaller. Bug: 1107516 Change-Id: I84499820cea86b5f785949d9274e8b2205714aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308133Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#825461}
-
Evan Stade authored
Bug: 1146058 Change-Id: Id8bbf7e0b964385016d74bf21d94874e5afa9883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523103Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#825460}
-
My Nguyen authored
Bug: None Change-Id: I21a97767ac8d7d5e8f4ce677805c32e98bbf7f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524803Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#825459}
-
Andrew Xu authored
TBR=xdai@chromium.org Bug: 1126904 Change-Id: I5de8d44012cab485298dcb00804708638e52a949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527742Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825458}
-
Yuheng Huang authored
Reason for the revert: Because tab search is disabled when #top-chrome-touch-ui is enabled, it fails on chromeos-eve-chrome, which is a touch based device and have #top-chrome-touch-ui enabled. Solution: 1. Disable #top-chrome-touch-ui for this test 2. Add a small delay to open tabs 3. Exclude UNSCHEDULED_tab_search from benchmark_smoke_unittest While the 1st change fixes the failure of chromeos-eve-chrome, it's safer to exclude UNSCHEDULED_tab_search from the test in case it breaks other trybots. We will reenable it in a follow up CL when we have more confidence this test can pass all trybots. This is a reland of 683608bf Original change's description: > Tab Search: Implement performance benchmark > > Doc: > https://docs.google.com/document/d/1-1ijT7wt05hlBZmSKjX_DaTCzVqpxbfTM1y-j7kYHlc > Usage: > tools/perf/run_benchmark run UNSCHEDULED_tab_search --browser-executable=out/Default/chrome --story-filter=tab_search:top10:2020 > tools/perf/run_benchmark run UNSCHEDULED_tab_search --browser-executable=out/Default/chrome --story-filter=tab_search:top50:2020 > tools/perf/run_benchmark run UNSCHEDULED_tab_search --browser-executable=out/Default/chrome --story-filter=tab_search:top100:2020 > > Change-Id: I684024f9cf3264ac2ed4feca15c6059342a493c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461224 > Commit-Queue: Yuheng Huang <yuhengh@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824599} Change-Id: I99a1b357e9d1e911a6966180df15d025faa27e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523752Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#825457}
-
Sorin Jianu authored
This seems to work and no change in the unit tests was needed after removing the clutter of how StateChecking::DoHandle works. High level, the state transitions kNew->kChecking and kChecking->whatever don't need to count callbacks. Instead, the code relies on the sequence provided by the task runner. This streamlines the execution path of UpdateEngine::DoUpdateCheck since it makes clear that it can't be invoked multiple times during a single call to UpdateEngine::Update. Bug: 1146864 Change-Id: I116e0f68b6668856aa3c3564ed4f51bf7efd4026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523788Reviewed-by:
-
Jazz Xu authored
This CL changes the logic for displaying controls in quick settings such that we will only show controls if the title of the session is not empty and the session is controllable. This also matches the logic for showing notification in Chrome global media controls. Bug: 1142625 Change-Id: I91d7f8279b8602d89af50bdf7c891b3440abd9ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523735 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#825455}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6e8f1f65. With Chromium commits locally applied on WPT: 4a72139a "Add test for hit-testing floats in relatively positioned inline" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I81a562fabe0ff7efa54f255aa2654917f0a2539b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526945Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825454}
-
Sky Malice authored
TBR: fergal@chromium.org Bug: 1101292 Change-Id: I038a00bed21f399e47760df00b54b5b05866302f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525857 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#825453}
-
David Bienvenu authored
I did not do the CreateVEA callbacks because these are supposed to be removed by http://crbug.com/454029. Bug: 1007801 Change-Id: Id4947a8f71079cb4456716c4e3a242d8515d039a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523369Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825452}
-
Rainhard Findling authored
Bug: 1087263 Change-Id: Iea65cdcf64691e6b97dac8c867d4aedf46c595f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523037Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#825451}
-
Kushagra Sinha authored
Move `Account` serializes and deserializers from `AccountManagerAsh` to //components/account_manager_core, where it can be depended on by ash and lacros both. Bug: 1117466 Change-Id: I4927e89be2e909888f5ccf9ac19ad00b9f007ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510055 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#825450}
-
ckitagawa authored
Still seeing likely OOMs in the utility process, trying another fix. This CL - Prevents starting the compositor if the device is already under moderate pressure before loading it. - Stops requesting out-of-viewport bitmaps when under moderate memory pressure or worse. - Adds a listener to the compositor process to stop when it detects it is under memory pressure. This works in harmony with the browser side equivalent, but since there is a monitor per-process, this should catch more cases. Bug: 1144768 Change-Id: I08d38f55cfe90eabb364efa85839861028b9cc99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526165Reviewed-by:
Fred Mello <fredmello@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#825449}
-
Randy Rossi authored
This CL fixes an issue that was causing the screen reader to unnecessarily re-focus when a node with scopes route flag was found without any descendant names route node. This caused the scopes route node to be added to the cache but then immediately removed by the check for empty scopes route. That causes a refocus. Bug: None Test: Manual w/ display assistant, unit tests Change-Id: Idbafc1cff79150d8be7f790612d342cd674d16e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525771Reviewed-by:
Ryan Daum <rdaum@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#825448}
-
Dominique Fauteux-Chapleau authored
This adds evidence_locker_filepath in ContentAnalysisResponse::Result and a corresponding reporting field. This should be removed once a better propagation for this info is agreed upon. Bug: 1147036 Change-Id: I496d13a80fd7f06a83f534afa0b6d673184a6bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526929 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#825447}
-
Xiaoqian Dai authored
Bug: 1144767 Change-Id: I8e4b613fbed55cc7336a0bf4ac144d7dd4834dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521572 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#825446}
-
Kushagra Sinha authored
Add a standalone account_manager::AccountType enum that can be depended on by Lacros and Ash, both. The existing proto chromeos::account_manager::AccountType will be visible only to Chrome OS Account Manager. Bug: 1117466 Change-Id: I952bf0d1a81577609103e3f7d9467cc2c0631431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505833 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#825445}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/9abc1e30cfe5..1030c88a4bb8 2020-11-09 mfoltz@chromium.org [Open Screen] Fix two unitialized reads dicovered by MSAN. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1143946 Tbr: jophba@chromium.org Change-Id: I0d26a74f836cf24b1b60eaf6d607e6a42d1b91db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526606Reviewed-by:
-
Jeffrey Kardatzke authored
This completes the H265Decoder by adding picture output flags, picture order counts, ref pic list calculations and DPB management operations. The unit tests were updated for this and a fuzzer was also added for the decoder. BUG=chromium:1141237,b:153111783 TEST=media_unittests, media_h265_decoder_fuzzer Change-Id: Ieaa1da24d1e93ea017e1d5d68e67e07596347879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521113 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#825443}
-
Darin Fisher authored
Change-Id: Ia023f30e7ebc952da99e0390082d61fb5174da18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521448Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#825442}
-
Peter Wen authored
Bug: None Change-Id: Ie57dec47c4467bbdaa44ad0bc38d27b1d55fbb6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526484 Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#825441}
-
Mark Cogan authored
In some cases a crash is happening when building the BVC view hierarchy (see the linked bug); this is due to UIKit throwing an exception when a constraint is created between views that aren't in the same view tree. This CL just adds an explicit CHECK for the views that were triggering this crash, so that we can get more information about the state of these views when this occurs. Bug: 1136765 Change-Id: I9d9c0431663aaa26df38bac1b66c476938320d7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510213 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#825440}
-
Becca Hughes authored
This is a reland of ddb531f7 There is a fix in media_session_service.cc to allow the tests to pass when ash-chrome is not running. Original change's description: > [Media Session] Fix for Lacros > > At the moment in Lacros there are two instances of the > Media Session Service (MSS) one hosted in ash-chrome and > the other in lacros-chrome. This means that sessions in > either browser process cannot see sessions from the other. > > This changes it so when a client asks for lacros-chrome > MSS instead of providing a locally hosted MSS it binds > the MSS in ash-chrome. > > BUG=1140215 > > Change-Id: Ic155a6cd928f0735095f849f309f9075dbb1d36f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485850 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825016} Bug: 1140215 Change-Id: I64834d9be778998b42bf3447444a6955265215ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525851Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#825439}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=msramek@chromium.org Change-Id: I118ba2a88ecbbbe731ff98061c4e11c6255abcb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525764 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#825438}
-
Erik Jensen authored
Previously, rtcLogTransfer and webrtcIceSdpRestartAction were appended to the host capability set in me2me_desktop_environment.cc and it2me_desktop_environment.cc, but not in desktop_session_proxy.cc. The latter omission prevented the associated functionality from working with me2me on Windows hosts. Rather than setting the capabilities in yet another location, this change moves setting them to client_session.cc, which applies to all hosts, and is also where the associated functionality is hooked up. Change-Id: Ib534a52016b30382f40e6cbbee0c7376b684514d Bug: 1147147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525239 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#825437}
-
Chris Lu authored
This change adds setup for a client-driven experiment that buckets users on First Run into 3 groups, two experiment and one control. This reland removes the setup in Create() so that the final hookup can be landed separately. Bug: 1138603, 1146408 Change-Id: I0f3c73c11a07a966cf7ba7cae7bc7feaa85daad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523247 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#825436}
-
Dale Curtis authored
This fixes a few different issues with our HLG support: - Windows was missing the DXGI define for HLG. - Windows was not excluding HLG content from the brightness slider. - HLG AV1 was not decoding to P010 where available. To avoid having HLG content scaled by the brightness slider the unused |f| parameter in the skcms_TransferFunction for HLG is used to store the SDR white level. Skia will need to be updated to use this scaling factor to fix HLG based HDR images. gfx::ColorTransform has been updated to use the SDR white level information in its HLG transforms. Bug: 1144260 Test: Manual + updated unittests. Change-Id: Iedd5d4b1ae0e67de685300306384e8a4e6edf086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511269 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#825435}
-
Reilly Grant authored
This change reduces the latency between when a byte is received and when it is available to script by configuring the COMMTIMEOUTS structure so that ReadFile() return immediately rather than either waiting for the buffer to be full or a timeout to be exceeded. The previous timeout of 1ms was insufficient because on Windows the minimum timing interval is frequently 16ms and so this introduced a sizable amount of latency. Bug: 1142799 Change-Id: Ie02cb64162dcf7ee178ab9dfcca614d63f79c13e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522196 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#825434}
-
