- 03 May, 2019 40 commits
-
-
Dominik Röttsches authored
This reverts commit 501ae8c7. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Trusty%20Leak/33553 suspected to cause failures on WebKit Linux Trusty Leak detector bot Original change's description: > Use testdriver Action API in WPT pointerevent tests - Part 4 > > In order to run the web-platform-tests automatically, we will use > testdriver Action API in all the wpt to simulate inputs. Here we are > changing some pointerevent input tests which are doing dragging and > some tests test touch, mouse and pen inputs. > > This is the four CL that changes part of the pointerevent input tests. > > Bug: 606367 > Change-Id: I179917a46a3fc759b4f1763a0595b977589435cf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592527 > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#655997} TBR=lanwei@chromium.org,nzolghadr@chromium.org Change-Id: I5e4a84e6dc2b466d4d46df4821dff8b63eb5c537 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 606367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591597Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#656329}
-
Darwin Huang authored
Change-Id: I8c35e336ff72365888ad767ab3179cfac6383b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594080 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#656328}
-
Anna Malova authored
Bug: 951762 Change-Id: I97c93ce76a7619b1f876a730c1e21b92f190bb6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591912Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#656327}
-
Yi Su authored
crw_wk_navigation_states* are navigation related files and should be located in ios/web/navigation. Bug: 956511 Change-Id: Ic166765e465095e77456763d816144c40531840e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591840 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#656326}
-
Dominik Röttsches authored
This reverts commit 1aaab3f0. Reason for revert: Suspected of causing WebKit LayoutTests failures on 10.11, compare https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/37268 FindIt points out this CL. Original change's description: > Disallows reusing RTCIceTransport. > > Currently if an RTCIceTransport that comes from an RTCPeerConnection is > reused to create and RTCQuicTransport there is a crash. This disallows > this from happening by throwing an exception if the client attempts to > do this. > > Bug: 10589 > Change-Id: Idcf538972516825fef3b275d062a19d0bd7a68c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593872 > Commit-Queue: Seth Hampson <shampson@chromium.org> > Reviewed-by: Steve Anton <steveanton@chromium.org> > Auto-Submit: Seth Hampson <shampson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#656241} TBR=shampson@chromium.org,steveanton@chromium.org,amithi@chromium.org Change-Id: I7eca98de36593304f7fbedeb9cfa2b12dc276254 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 10589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593379Reviewed-by:
-
Sean Kau authored
HandleAddDiscoveredPrinter is crashing because we forgot to set the resolver. This happens when trying to resolve a discovered printer. I will follow up with a unit test. Bug: 954623 Change-Id: I749f5802d58b28ad2a87dd7f42952f88cdc42b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576229 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#656324}
-
Dominik Röttsches authored
This reverts commit ca80dfd9. Reason for revert: Causes Mac LayoutTest failures, details in https://crbug.com/959104 Bug: 959104 Original change's description: > [Dark Web Contents]: Implement color inversion using CIELAB. > > To invert color: > 1. Tranform color to CIELab. > 2. Invert the L and add 10. > 3. Transform back to RGB. > > Bug: 939312 > Change-Id: Iadeec2232afbe35cb189f0a36722392514db4781 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547830 > Commit-Queue: Anna Malova <amalova@chromium.org> > Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Cr-Commit-Position: refs/heads/master@{#656195} TBR=tobiasjs@chromium.org,schenney@chromium.org,amalova@chromium.org Change-Id: I4b2602ccb012427f3efc285e2ad44777406fbe57 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 939312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591596Reviewed-by:
-
Martin Robinson authored
Add support for setting the AtkObject state and sending the appropriate AtkWindow events when a toplevel window in Chrome is minimized and restored. Bug: 866336 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ida3d38258405c46890223b88d67bdb8fa7fa11c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1280549Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#656322}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7169463dd948..cc5410498c59 Created with: gclient setdep -r src-internal@cc5410498c59 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=gogerald@chromium.org,caseq@chromium.org,ksakamoto@chromium.org,drott@chromium.org Change-Id: Iaf59a91beca3467162143e7d3417c3c4f7a9c587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594472Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#656321}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/58d7a99b6dea..fd105f1b76a7 git log 58d7a99b6dea..fd105f1b76a7 --date=short --no-merges --format='%ad %ae %s' 2019-05-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 3089f92e8a77..ddc4d33a259a (3 commits) 2019-05-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 1745a957..b81b7098 (397 commits) Created with: gclient setdep -r src/third_party/skia@fd105f1b76a7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I6c650d00913ee9b8f932ce4901d42d8b35a2a1a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593471Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#656320}
-
Dominik Röttsches authored
This reverts commit f62ecc3c. Reason for revert: Breaks Linux CFI bot due to Clang CFI finding issues with indirect calls, details see crbug.com/959100 Bug: 959100 Original change's description: > Inline static Create() from core/html - 9 > > As advised in [1], after porting calls to Foo::Create() factory > functions to use MakeGarbageCollected<Foo> from classes in > //third_party/blink/renderer/core/html, this CL removes unused Create() > methods. > > [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBg> > > Bug: 939691 > Change-Id: Iefe48afd34fe4d232bffec293a6ebdc818e8f8b9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583895 > Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#655982} TBR=haraken@chromium.org,hferreiro@igalia.com Change-Id: Ib97eec938d277b88cc1690ddc8f52a2372d0b551 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 939691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594512Reviewed-by:
-
Huanzhong Huang authored
Better alternative to 1591526: Show Separators of Last Cells in CBD Thanks to thegreenfrog@ Make use of TableViewCell's custom separator to allow showing separators for certain cells that come last in their sections. Bug: 935346 Change-Id: Ibfb1af04026de829950a2d23b7f1618b25d47455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591278Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#656318}
-
Anders Leino authored
Video processor blit to swap chain results in column of black pixels on NVIDIA drivers < 419 at certain scaling factors. As a workaround, disable direct composition layers for these drivers. Bug: 911349 Change-Id: Ic40a6f5068372e48e437c89930cb589de0d3a301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559175 Commit-Queue: Anders Leino FI <aleino@nvidia.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#656317}
-
Jimmy Gong authored
- Expand width of inputs and searchable drop downs to 100% of dialog. Bug: 955173 Test: End to End manual Change-Id: I27ef20385af45946571c8fe23b2ebc5b79a673a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578118Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#656316}
-
Giovanni Ortuño Urquidi authored
This allows test to make sure the right options were passed when there are multiple calls to FinalizeInstall. Bug: 916381 Change-Id: I395d561c3a25b9b1d4dd7aba8ee136fa23943c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594383Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#656315}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f616294c0b2a..f27057bbc6ff git log f616294c0b2a..f27057bbc6ff --date=short --no-merges --format='%ad %ae %s' 2019-05-03 dberris@chromium.org Prepare dashboard for Python3 Created with: gclient setdep -r src/third_party/catapult@f27057bbc6ff The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:957870 TBR=zhanliang@chromium.org Change-Id: I6621454a8d362834dd892f77a57480df98016c7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593470Reviewed-by:
-
Alan Cutter authored
This CL makes ExtensionIdsMap use the AppRegistrar instead of the ExtensionRegistry in order to be agnostic to the BMO refactor. This is in preparation to move its functionality into the AppRegistry. There is a slight change in behaviour where this now only looks at enabled extensions when checking for existing installation. This should be okay as we shouldn't need to be checking the blocked/disabled/terminated/blacklisted extensions anyway. Bug: 891172 Change-Id: I529530a328708833f2b6241894538c065bf5e38a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594374 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#656313}
-
James West authored
If the decoder were being bypassed in AudioDecoderForMixer and SetConfig() were called with a new sample rate while a task to call OnBufferDecoded() was pending, OnBufferDecoded() would set the sample rate back to the old sample rate when the task was run. This changes OnBufferDecoded() to ignore the sample rate when bypassing the decoder because the sample rate is always based on the config, not the decoded buffer. Bug: internal b/131527230 Test: None Change-Id: I784ac7b8fa936cdfaa86f6925a01c6478db3189f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594237 Commit-Queue: James West <jameswest@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#656312}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f6e10911735b..7169463dd948 Created with: gclient setdep -r src-internal@7169463dd948 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=gogerald@chromium.org,caseq@chromium.org,ksakamoto@chromium.org,drott@chromium.org Change-Id: Ie1a47687996b14bb93d6f7ad44dd6d9e23cc1269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593499Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/10f7befc49a7..4fe8eb31e4a4 git log 10f7befc49a7..4fe8eb31e4a4 --date=short --no-merges --format='%ad %ae %s' 2019-05-03 swiftshader.regress@gmail.com Regres: Update test lists @ 10f7befc Created with: gclient setdep -r src/third_party/swiftshader@4fe8eb31e4a4 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ib92cd46da2ba9d18a1d49f100d4e172c65dbc3ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593500Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/666a9f9f8bb9..58d7a99b6dea git log 666a9f9f8bb9..58d7a99b6dea --date=short --no-merges --format='%ad %ae %s' 2019-05-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 20aab4e9c149..10f7befc49a7 (17 commits) Created with: gclient setdep -r src/third_party/skia@58d7a99b6dea The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I36abe77f75c01983a520397212be02f6820fa4dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594196Reviewed-by:
-
Rob Schonberger authored
This CL adds a policy control ability for the fast App Recommendation Reinstall feature. This allows enterprise managers to disable/enable the policy as per other features. Bug: 914864, 911427 Change-Id: I316f342638a7d8069579926bfff0c62d6a148a8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556273 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#656308}
-
Abhijeet Kandalkar authored
In the original CL |V0InsertionPoint&| is converted to |auto*|. This CL changes |auto*| by |auto&| to follow consistency with actual |V0InsertionPoint&| Bug: 891908 Change-Id: I3a34eb5bec2b5155b2bb69b24c02d1ce573d2545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591664Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#656307}
-
Adam Langley authored
Bug: 941120 Change-Id: I486fbbf5505a30cdfdf1450a8754a35f44265b94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593875 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#656306}
-
Ashitha Santhosh authored
CreateSwapChain method creates DXGI Swap chain and then wraps its front and back buffer D3D11 textures into GLImages. For each buffer, a GL Texture is created which is stored as gles2::Texture or gles2::TexturePassthrough in SharedImageBackingDXGISwapChain that was created. The backing also holds reference to created swap chain. PresentSwapChain is implemented in SharedImageBackingDXGISwapChain. After flipping the swap chain, we also have to rebind the surface representing the back buffer. This is implemented in the BindTexImage implementation in the GLImageDXGISwapChain subclass. Bug: 939655 Change-Id: I646206f532728be4ae85af54f3eae5cc5fc4e74a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573092Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Ashitha Santhosh <ashithasantosh@google.com> Cr-Commit-Position: refs/heads/master@{#656305}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e207b5651204..8e144bde1f39 git log e207b5651204..8e144bde1f39 --date=short --no-merges --format='%ad %ae %s' 2019-05-03 nednguyen@google.com chromite/api: add the full depgraph to depgraph's response message directly 2019-05-03 evanhernandez@chromium.org chromite: Remove TreeIsOpen and dependencies. Created with: gclient setdep -r src/third_party/chromite@8e144bde1f39 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I70720af49f6689bb143e7c84678fde675f93e795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594195Reviewed-by:
-
Luciano Pacheco authored
Closure only outputs warnings when there is at least one error. I noticed this warnings when working in other CL. These were introduced on ES6 class conversion CL:1588066 Change-Id: I66418a5f4d37b3bb3bf9ed0f1e0819c5df8538a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593880 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#656303}
-
Alex Danilo authored
CL:1546804 added scrolling for when directory tree items get focus (to allow items that are tabbed with the keyboard to come into view). A side-effect of this caused selection and window focus to scroll the directory tree even if the item was within view, causing non-focussed items to be scrolled out of view. This change uses the non-standard scrollIntoViewIfNeeded() method to scroll the item only when necessary and then checks the element to see if it moved. If it has moved, the scrollIntoView() method is called to horizontally position the element since the latter method honours the 'inline' positioning property whilst the former method does not. Bug: 955172 Change-Id: I61e04cdd2529274ee19cfd9b8e7a0e387132af35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593885Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#656302}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d22de7578813..f6e10911735b Created with: gclient setdep -r src-internal@f6e10911735b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=gogerald@chromium.org,caseq@chromium.org,ksakamoto@chromium.org,drott@chromium.org Change-Id: Icf1cbdd12697f0c92b9cf2efd7be5c14c13943f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594245Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bf6e6c9070d3..f616294c0b2a git log bf6e6c9070d3..f616294c0b2a --date=short --no-merges --format='%ad %ae %s' 2019-05-03 dberris@chromium.org SheriffRedux: Sheriff Config Service 2019-05-02 rmhasan@google.com [Typ] Use value of the all command line argument in should_skip 2019-05-02 rmhasan@google.com [Typ] Add validation for expectations globs that checks if they only have the '*' in the end Created with: gclient setdep -r src/third_party/catapult@f616294c0b2a The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:953181,chromium:945481,chromium:698902 TBR=zhanliang@chromium.org Change-Id: I772d3dd4fdd0d288b12e731976247662cd4afabb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594240Reviewed-by:
-
Chris Hamilton authored
The overhead introduced by using an owned TLS pointer caused a performance regression of 0.5% at the median, as this is a hot code path executed for every single task that is evaluated. This CL reverts to using a plain TLS pointer as before, and repurposes the inline |ipc_program_counter| storage in PendingTask to store the current IPC message context. BUG=957693 Change-Id: I32ddf9a28b924b5a45301d4855dc08d8b914fbbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590247 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#656299}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e99e2408e96d..f54bb68f47ec git log e99e2408e96d..f54bb68f47ec --date=short --no-merges --format='%ad %ae %s' 2019-05-03 rafael.cintron@microsoft.com Improve usage of static_casts over reinterpret_casts Created with: gclient setdep -r src/third_party/dawn@f54bb68f47ec The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@chromium.org Change-Id: Ib47dbf42b9ecb7d693f63b0fcdd1e4649d8b3335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594244Reviewed-by:
-
Toni Barzic authored
Tests existing user controller actions on: * TPM_ERROR * MISSING_CRYPTOHOME * OWNER_REQUIRED * wrong password * cryptohome service not available BUG=949231 Change-Id: I694bc364dfef3d1b655633b32910d858902a86f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592859Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#656297}
-
Nico Weber authored
Using `!is_mac && !is_ios` instead of `is_win || is_fuchsia || is_android || is_linux` should be behavior-preserving and is simpler now that all the special cases we used to have have been fixed. Bug: none Change-Id: I78ec8f06bfdc2171deb9cdd060bb148a82926415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593730 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#656296}
-
Alexander Alekseev authored
This CL adds OfflineGaiaLogin mixin. Bug: 950236 Change-Id: I704795a7877375f150aabe8a872b4e6c9c5530df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590898 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#656295}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c57ec6f0af33..10f7befc49a7 git log c57ec6f0af33..10f7befc49a7 --date=short --no-merges --format='%ad %ae %s' 2019-05-03 capn@google.com Fix overwriting of filter factor Created with: gclient setdep -r src/third_party/swiftshader@10f7befc49a7 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/129523279 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I8d76225ad3694719ec9ca0eb8254b83b1491ec00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594243Reviewed-by:
-
David Bokan authored
To understand why this is needed, note that the size of the layout viewport is calculated based on the minimum scale factor of the page. That is, we size the layout viewport to the size of the visual viewport when it's at the minimum allowable scale factor. |position: fixed| elements are sized relative to the layout viewport; therefore, their size depends on the minimum scale factor. When we override the minimum scale of a page, this can cause the layout viewport, and thus |position: fixed| elements, to increase in size. If we respect the initial-scale, this can cause fixed elements to appear cut-off by the viewport without a good visual indication to the user that zoom-out or horizontal scrolling is available. This is especially bad since the typical case here is a banner with a close [X] button at its far right. This causes those buttons to get cut out of view. Bug: 929709 Change-Id: Iacb6f6e92a5db11037710380e736f1f429575262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591888 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#656293}
-
Jeevan Shikaram authored
The app list in App Management would not render when navigating to it via a back button. This was caused by an onDomChange not being triggered by the page change while navigating within App Management. Bug: 948444 Change-Id: I9567a3baa6512550fdee221dfc062b5042925ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560878Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#656292}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b9046c85c3ce..d22de7578813 Created with: gclient setdep -r src-internal@d22de7578813 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=gogerald@chromium.org,caseq@chromium.org,ksakamoto@chromium.org,drott@chromium.org Change-Id: I28250c5688b85ac0d7ff4804b4e10edaf119372b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594242Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I589470df2c015be520f0a229b9434dd64dc2ca35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594334Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#656290}
-
