- 05 Apr, 2018 40 commits
-
-
Adam Langley authored
The code casts an |int| to a |SimpleValue|. Since |SimpleValue| is an |enum class|, this is safe. But it might not be for a traditional |enum|, so add a comment in case it flags for anyone else. Change-Id: Ifc50115d0ae9b047167f48b3d031b89d4494eda9 Reviewed-on: https://chromium-review.googlesource.com/982609Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#548474}
-
John Abd-El-Malek authored
With this change, CertificateReportingService now only lives on the UI thread. Bug: 825242 TBR=rhalavati for test annotation removal Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I3945ab88a8d2f0507b4a2572df6c79edd7aab036 Reviewed-on: https://chromium-review.googlesource.com/996021 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#548473}
-
Emily Hanley authored
Refactored our execution of non-telemetry tests so we wouldn't have to generate new isolates for every non-telemetry test during migration. Instead you need to just pass --migrated-test=true in the src side json. Also pulled out the perf script deps so we wouldn't have to update every time the perf isolated script deps changed. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I27fac5c9a36f9321be80f0c60ab8b53eaefdc1c4 Reviewed-on: https://chromium-review.googlesource.com/995576Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#548472}
-
Boris Sazonov authored
This CL reimplements how ic_check_googblue_24dp_animated is animated by replacing path morphing with trimPathEnd and removing no longer necessary AnimatorSet. This fixes the issue when the first line in the checkmark wasn't animated because both objectAnimators were trying to animate pathData simultaneously (because default android:ordering for AnimatorSet is "together"). Bug: 829388 Change-Id: I05e568e8f289cb71c869c916f488a159f11f6a64 Reviewed-on: https://chromium-review.googlesource.com/998034Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#548471}
-
https://pdfium.googlesource.com/pdfium.git/+log/32942201a456..14f8897509d9 $ git log 32942201a..14f889750 --date=short --no-merges --format='%ad %ae %s' 2018-04-05 rharrison Remove spellchecking code from XFA Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I342d1d16619bdba0d0b3ac11d2abf5b55276716a Reviewed-on: https://chromium-review.googlesource.com/997896 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#548470}
-
Alan Lau authored
Change-Id: I50b6a8ed6f5b214c0ae6816a40d037107741f7e0 Reviewed-on: https://chromium-review.googlesource.com/996297Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Alan Lau <alanlau@google.com> Cr-Commit-Position: refs/heads/master@{#548469}
-
Scott Violet authored
WaylandPointer was supplying the complete set of flags to MouseEvent rather than the button that actually changed. BUG=none TEST=covered by test Change-Id: Ib44585549d67001fdab847205819cea4cd646544 Reviewed-on: https://chromium-review.googlesource.com/996924Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#548468}
-
Biao She authored
Bug: 819875 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I95e91504b6e28ac2f762881dde31924f05c2cf6e Reviewed-on: https://chromium-review.googlesource.com/987388Reviewed-by:
Yash Malik <ymalik@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#548467}
-
Lei Zhang authored
Better document pointer ownership. BUG=123762 Change-Id: I7be106bbf079ea2a30024e129d693ebe49454acf Reviewed-on: https://chromium-review.googlesource.com/993236Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#548466}
-
Jochen Eisinger authored
BUG=828963 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I7d17bfdc8f4b312ff70bba4d700c528eaabd7948 Reviewed-on: https://chromium-review.googlesource.com/992322Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#548465}
-
Jinho Bang authored
Until now, we had to use IsSecureContext() to check whether an execution context is a secure context manually. But we can use [SecureContext] instead of the manual check now. Bug: none Change-Id: Ibfcd4a9a2eed3e7ac67819b9bf4204f4c73412d8 Reviewed-on: https://chromium-review.googlesource.com/990014Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#548464}
-
Ken Rockot authored
This is marginally better than what we're doing now, but more importantly it satisfies a reasonable DCHECK that we currently violate in these cases. Bug: 829290 Change-Id: I68621d4f1c8f40c1b689d74e801c1cdb77e4663a Reviewed-on: https://chromium-review.googlesource.com/997769Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#548463}
-
Nate Fischer authored
This adds the FeatureFlagHolderBoundaryInterface. Support-lib-created callback objects will implement this to indicate, on a per-object granularity, which features they support. Doc: http://go/wv-callback-feature-detection Bug: 752521 Test: N/A Change-Id: Iac86615052069d091a0db66f41bc9c852498815f Reviewed-on: https://chromium-review.googlesource.com/997021Reviewed-by:
Gustav Sennton <gsennton@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#548462}
-
Ian Vollick authored
This turned out to be slow. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id2b89db4cd7fcd8b96eed66415a30afe33af0e59 Reviewed-on: https://chromium-review.googlesource.com/997755Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#548461}
-
Rohit Rao authored
This asset will be shared by both the popup menu and collections. BUG=None TEST=None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id6c87412a3a4ebd5e7755058a67288fdcc035ced Reviewed-on: https://chromium-review.googlesource.com/997156Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#548460}
-
Jiaquan He authored
This commit: - adds a class ChromeSearchResult; - changes all SearchResult references to ChromeSearchResult in Chrome; - fixes lint errors and presubmit errors on creating unique_ptr. This commit touches a lot of files. To make it simple, we simply extend SearchResult to create ChromeSearchResult, and cast between types for mojo calls. We'll reorganize their contents and break the inheritance in future CLs. Bug: 733662 Change-Id: Iaef5174580dbd06bb26b4e864a6a367336458604 Reviewed-on: https://chromium-review.googlesource.com/996381Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#548459}
-
Mike Dougherty authored
Ensure that expected FindElementResultHandler messages do not trigger the ContextMenu.UnexpectedFindElementResultHandlerMessage histogram. The message should not be considered unexpected even if the message is received after the CRWContextMenuController has cancelled showing the context menu. Bug: 228355 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iff6535420cd7a2eb8ba516f5d777c07352915852 Reviewed-on: https://chromium-review.googlesource.com/996526Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#548458}
-
Francois Doray authored
This flag delays execution of base::TaskPriority::BACKGROUND tasks until shutdown. This CL first landed as https://chromium-review.googlesource.com/919866. It was reverted because the CommandLine wasn't always available during TaskScheduler initialization (e.g. https://cs.chromium.org/chromium/src/components/cronet/cronet_global_state_stubs.cc?l=34&rcl=975444866735e5e44b024707a7ff28582b8383cd). This CL fixes the issue by adding a check for CommandLine initialization before accessing it during TaskScheduler initialization. TBR=gab@chromium.org,jam@chromium.org,tmartino@chromium.org Bug: 726937 Change-Id: I0500c54222234e6cb88a1f2d7e92a7e87b6656fa Reviewed-on: https://chromium-review.googlesource.com/996439Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#548457}
-
Wei Li authored
For inactive tabs, we prefer showing favicon, then alert button, then close button. When there is no favicon or alert button, we need to show title first instead of the close button, so the tab can be identified. BUG=826750 Change-Id: I5148e13ce8faceff73ec73fede9d319422595685 Reviewed-on: https://chromium-review.googlesource.com/996809Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#548456}
-
chrome://webrtc-logsElad Alon authored
When WebRTC textual log files are deleted, either because of expiration or because the user clears browsing history, entries from the logs' index are now also removed. As a drive-by: * Fixed the unbounded reading of a file into memory. * Marked with TODOs (and filed bugs) for several other problems found. Bug: 825977, 827131 Change-Id: If34acf6290ec90c3ce99c0704c58bc8a8188f92d Reviewed-on: https://chromium-review.googlesource.com/982055Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#548455}
-
Danyao Wang authored
When handling a no-Internet-connection error, WKBasedNavigationManager incorrectly triggers WebState::OnPageLoaded with load completion status SUCCESS when the native error view is loaded. This prevented ReadingListWebStateObserver from triggering and loading offline content and is now fixed. Since offline reading list is essentially another type of native error, we must not update the navigation item's |errorRetryState| when loading a chrome://offline URL. This is so that a reload of the page will retry loading the original URL. This is fixed by only updating the error retry state machine when the URL is a web URL. This is OK because app-specific URL should never fail to load. Bug: 819805 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I870ef99522ba6f5aeb4d37c58289155aa8cb79c9 Reviewed-on: https://chromium-review.googlesource.com/996434 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
-
sebsg authored
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3161ec166dce92c8f8014df17bd5315e05502058 Reviewed-on: https://chromium-review.googlesource.com/997155 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#548453}
-
Nektarios Paisios authored
R=dmazzoni@chromium.org, aleventhal@chromium.org Tested: Manually with Jaws, layout test Change-Id: Iddc30de6ad10825dd9f99af059d89032cba5af98 Reviewed-on: https://chromium-review.googlesource.com/990537 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#548452}
-
Anna Offenwanger authored
Add a metric to track how presentation was started. Bug: 808586 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2abda74f64ddc5fed58c6b71fbebcdddd2f8bab8 Reviewed-on: https://chromium-review.googlesource.com/986976 Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Mikel Astiz authored
The ancient experiment concluded with neutral results and the code has been around but inactive for two years, so let's remove it. Bug: 523008 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I45369874c2a2853e107b5bd039bcc7e8cd4e7dae Reviewed-on: https://chromium-review.googlesource.com/995012 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#548450}
-
Vadym Doroshenko authored
On CL https://chromium-review.googlesource.com/c/chromium/src/+/943321 it was implemented JS message of type "form_changed", which is called when dynamically added form is found. This message shouldn't initiate showing autofill input accessories, because input accessories has to be shown only on user action. Bug: 708597, 798675 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib4d687ab2c7b344ec8f448ebef5025e7b68c3883 Reviewed-on: https://chromium-review.googlesource.com/997840Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
Fredrik Söderquist authored
Since the (CSS) parser allows numeric weight values in the range [1, 1000], adjust the ranges in FontDescription::Lighter/BolderWeight to match that. Also factor in that the values can have fractions (by implicitly truncating them) and simplify the range check since there's now a set of adjacent intervals in practice. Bug: 828747 Change-Id: I5fe3405ca45ed8016530d995976e36a6ebbcf366 Reviewed-on: https://chromium-review.googlesource.com/995452Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#548448}
-
Min Qin authored
TBR=horo@chromium.org BUG=829417 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I1a2b8c446cd5003bccc07eae997b146bbb008850 Reviewed-on: https://chromium-review.googlesource.com/998305Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#548447}
-
Stephen McGruer authored
This reverts commit d1f4cdd4. Reason for revert: Breaks compile on WinMSVC64 (dbg), due to unreachable code (the return after the #endif): https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.win%2FWinMSVC64__dbg_%2F4540%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout c:\b\c\b\win\src\chrome\browser\chrome_content_browser_client.cc(4172) : warning C4702: unreachable code Original change's description: > [Picture in Picture] Move generic code to content/. > > Currently, all Picture in Picture code is housed in chrome/. Since > only some of the Picture in Picture work is Chrome specific, we move > the more generic work into content/. > > This change completely moves the PictureInPictureWindowController > and OverlaySurfaceEmbedder into content/. > > This change will also pave for some future work related to user > initiated commands from the window, such as play/pause. IPC messaging > for MediaPlayerDelegateMsg must be done through content/ rather than > in chrome/. > > OverlayWindowViews continues to be the desktop Chrome implementation > of OverlayWindow, which is now moved into content/. With the > convergence of historically platform-dependent implementations (views > vs cocoa) into just views, there will only be one window implementation > for Chrome. > > BUG: 726619 821874 > Change-Id: I6ef73552c6729aec235f4a6d176fd4109f6674b3 > Reviewed-on: https://chromium-review.googlesource.com/972841 > Commit-Queue: apacible <apacible@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548428} TBR=ellyjones@chromium.org,kinuko@chromium.org,lazyboy@chromium.org,mlamouri@chromium.org,apacible@chromium.org Change-Id: I3a18da4e27bbff14d2acfa11707727d46e033f73 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/998173Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#548446}
-
Gauthier Ambard authored
This CL adjusts the color of the elements of the tools menu when they are enabled. Bug: 824210 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7aaca16482f40a97dfe713a1847e25ea697103f9 Reviewed-on: https://chromium-review.googlesource.com/997818Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#548445}
-
Lutz Justen authored
Created specializations of ActiveDirectoryPolicyManager for user and device policy instead of handling everything inside the base class. The differences between user and device policy are still small right now, but they're only going to grow (as I noticed while working on policy for extensions), so it's important to do the split early on. Keeps all ActiveDirectory*PolicyManagers in one file to simplify reviews, but they are going to be moved to their own files in an upcoming CL. BUG=chromium:735100 TEST=out/Release/unit_tests --gtest_filter=*ActiveDirectoryPolicyManagerTest.* Tested on device Change-Id: I55b5d8cfb3646058510729f2028a6b6aa2f9584e Reviewed-on: https://chromium-review.googlesource.com/972482 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by: -
Jun Choi authored
Since AAGUID always has fixed size(16), change |aaguid_| of AttestedCredentialData from std::vector<uint8_t> to std::array<uint8_t, 16>. This is a reland of https://crrev.com/c/981682, which was reverted due to combining use of templates with COMPONENTS_EXPORT and failed compilation in win_msvc_dbg. Bug: 780078 Change-Id: Iaa97895cabaa4685ca5909df8c3544a6e84ecf78 Reviewed-on: https://chromium-review.googlesource.com/996963Reviewed-by:
-
Ramin Halavati authored
Switches that are passed from traffic annotation auditor to clang tool are moved from source to a text file for easier update. Bug: 690323 Change-Id: Icb1fbfdfde6898532158bb3c9ee0e4710a3e043b Reviewed-on: https://chromium-review.googlesource.com/997738Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#548442}
-
Mitsuru Oshima authored
This reverts commit 0abbd025. Reason for revert: other git cl upload uploaded the wrong CL. Original change's description: > Don't skip updating widget when resizing ClientControlledShellSurface > > ClientControlledShellSurface doesn't use configure to resize. > > BUG=828586 > TEST=manual > > Change-Id: I19c165741917f8a6855fab20a5938e9b020e02c0 > Reviewed-on: https://chromium-review.googlesource.com/994173 > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: David Reveman <reveman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548433} TBR=reveman@chromium.org,oshima@chromium.org Change-Id: Iac7a79ec338601463261650cbfcec5f91ea44a61 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 828586 Reviewed-on: https://chromium-review.googlesource.com/998172Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#548441}
-
Ken Rockot authored
This reverts commit 7c2240a7. Reason for revert: https://crbug.com/829218 Original change's description: > Re-enable WebRequestApiTest.WebRequestClientsGoogleComProtection > > Re-enables this test with the Network Service enabled. > > This test did some things which the Network Service does not support and > does not need to support, or which otherwise made testing with the > Network Service more complex than necessary. The following changes have > been made: > > * We no longer attempt to load a network resource from a WebUI > renderer. This will not be supported with Network Service and is no > longer desirable to have working in production anyway. There should > no longer be any WebUI pages making network requests. > > * Use http instead of https for the clients1.google.com requests. This > allows such requests to be handled by the EmbeddedTestServer which > already exists in BrowserTestBase, which is itself not configured to > handle HTTPS requests. Since these requests are filtered by > hostname, the scheme doesn't matter. > > * Switch the test to use a SimpleURLLoader instead of a > FakeURLFetcher. This allows the test code to exercise the same > behavior with or without the Network Service enabled. > > Bug: 721414 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: Iad1f2deaec2e218b9cb168acbe71c90591dc6acf > Reviewed-on: https://chromium-review.googlesource.com/972425 > Commit-Queue: Ken Rockot <rockot@chromium.org> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548137} TBR=jam@chromium.org,rockot@chromium.org,karandeepb@chromium.org Change-Id: I054a7e11a4945e379cd45405546a90ee4d1e9577 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 721414 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/998076Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#548440}
-
Michael Thiessen authored
Allows Chrome to stay in VR when Chrome is paused, so that when Chrome is resumed it's still in VR. We use the isInVrSession API to know when Chrome is resumed whether the user is still in VR or not, and if not we exit VR. There are a few edge cases, like making sure we close the old DLA when launching a new DLA, and making sure we exit WebVR presentation when launched from an intent rather than resumed from Dashboard. Bug: 780887 Change-Id: I4c399080958a65744bb1e89a16d1493cb1ef0a52 Reviewed-on: https://chromium-review.googlesource.com/986745 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
-
Dale Curtis authored
Layout tests do not always meet the requirements to avoid being "napped", in which case test timeouts and other odd behavior may occur; this is most prevalent with large repeat values and a small number of tests. This sets NSAppSleepDisabled to YES for blink tests. BUG=811525 TEST=manual Change-Id: I80ae1aeb0f5577f1977b3685e98655ea1253e3e6 Reviewed-on: https://chromium-review.googlesource.com/996483Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#548438}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/78ba74d75584..ecf6e8e622df $ git log 78ba74d75..ecf6e8e62 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal BUG=chromium:815077,chromium:659188 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If68f8532b45c663ca8f23029bb4f22f30f367ad4 Reviewed-on: https://chromium-review.googlesource.com/997762 Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#548437}
-
Matthew Jones authored
This change implements a simple bottom toolbar that has an android view, a composited component, resizes the viewport, and scrolls on and off-screen. This toolbar is implemented using the new MVC guidelines: - The BottomToolbarController sets up all the components of the bottom toolbar. - The BottomToolbarMediator is responsible for pushing updates to the model and running most of the business logic. - The BottomToolbarModel is a blob of state with no actual business logic. - The BottomToolbarViewBinder reacts to events from a PropertyModelChangeProcessor and updates the relevant views. BUG=815324,825965 Change-Id: I75e5aac6a2bb2a21ea9e4010fc81076d2d39da8b Reviewed-on: https://chromium-review.googlesource.com/980577 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Christian Dullweber authored
Similar to site settings and chrome://settings/siteData, cookies should by counted by the number of hosts instead of origins to avoid confusion. Change-Id: Ib148c5c1131a63adadce523e30e1453f69c9b318 Reviewed-on: https://chromium-review.googlesource.com/997842 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
-
