- 09 Sep, 2020 40 commits
-
-
Nate Chapin authored
Ensure orientation changes propagate to a grandchild even if the child's controller is not initialized When an orientation change occurs, the ScreenOrientationController of the local frame root propagates the orientation change event to subframes. However, if the frame doesn't have a ScreenOrientationController initialized, it skips that frame. However, it also incorrectly skips any children of that frame, so if a child does not a ScreenOrientationController, but one if its children does, that grandchild will not receive the orientation change event like it should. Do a full traverse of the frame tree, rather than a layer-by-layer one. Bug: 1121482 Test: ScreenOrientationControllerTest.OrientationChangePropagationToGrandchild Change-Id: If9c9e8ef9aa3ad2047aa97778dbfb503d1d827ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399008Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#805337}
-
David Bienvenu authored
Calls SetAppIdForWindow() in OverlayWindowViews::Create, using the appid of the web contents window that opened the Pip Window. This makes the Pip window get grouped with the window the Pip window was opened from on the Windows taskbar. Bug: 1116776 Change-Id: I23bb2cb8770c1778817a09139cb778f2b2e5549e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388274 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#805336}
-
ckitagawa authored
Record the FirstPaintBeforeTabLoad metric to include cases where the page has loaded before the compositor is has even started. Change-Id: I64423a3b153779bf429ac9644d8b9c71acbaed3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401279Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#805335}
-
Roberto Moura authored
If we translate the tab strip and switch tabs, the tab strip and the toolbar will be repositioned. To prevent that, we take a snapshot of the tab strip and move it instead. Two methods were added to the view revealing vertical pan handler delegate protocol to allow this. One executed before the animation and one after. The method executed before is required because if we add a view (the snapshot) and set its frame (to match the tab strip's) inside an animation block, the frame will be misplaced in the beginning and will only be updated during the animation. - Create a TabStripContainerView class and change the type of the tab strip controller's view from UIView to TabStripContainerView. _ The class TabStripContainerView contains only one method, used to provide a snapshot of the tabStripView (the only subview of tab strip controller's view). Bug: 1094335 Change-Id: I09bca78f4099bd28a943976e8bc888b70cb4b8d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339741 Commit-Queue: Roberto Moura <mouraroberto@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#805334}
-
Evan Stade authored
The failure was not caught by the CQ because there's no >=N coverage in the CQ, and the test is disabled for <N. Bug: none Change-Id: I3003ed59630b707314cbc23b882bb57ba3ac8add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398855Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#805333}
-
Evan Stade authored
Bug: 1125860 Change-Id: I1aa892bad4b66a8518076244025f6fbafcf9b518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399403Reviewed-by:
-
arthursonzogni authored
The RenderFrameHostImpl::is_mhtml_document_ attribute is reset after same-document navigation, which is a bug found in: https://chromium-review.googlesource.com/c/chromium/src/+/2395777 This adds regression tests. The fix is easy and will come in follow-ups. Bug: 1126391 Change-Id: Ic5d166da4a73cda7e5fe9a04402cb0a813c9bf49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401019Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#805331}
-
Aaron Colwell authored
Removing GetSoleProcessHostForURL() because all existing usage can be handled by GetSoleProcessHostForSite() and this will avoid recomputing the SiteInfo for the url. There are no user visible changes in behavior in this change. Bug: 1085275 Change-Id: I127d46e7a3f7217921e31eee57f1788b4d32ae63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399311Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#805330}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599609504-6aed31ad43427a24d3f18572e204bc1984bf6c08.profdata to chrome-win64-master-1599630228-06e78b920e92149bcb86488690cdbb2bed08546f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I9ff4f7e40864b14723f863ac1cd210598f15fbea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400318Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805329}
-
Oleh Lamzin authored
Use new method ServiceConnection::FlushForTesting instead of RunUntilIdle. Change-Id: If8b30b4b7a42206af83ae248a109590316e46a3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398546Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#805328}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/81c6d6eeb4cf..1313d1aa7a18 2020-09-09 brianosman@google.com Make enum symbol tables standalone (no parent table) 2020-09-09 reed@google.com use pathbuilder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: Id8ffa68648d3d0629b59ba890dea7973654810be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400887Reviewed-by:
-
David Jean authored
Bug: 1115961 Change-Id: I85f9a8b4e0589b3ede00f49df71762acf46e9978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400518 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#805326}
-
Geoff Lang authored
BUG=1112390 Change-Id: I2c477a7dd9af29ebf86fea85c53ecd3bd447ac30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398912 Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#805325}
-
Christian Dullweber authored
Show security indicator and icons for permissions and cookies in PageInfo. Screenshot: https://crbug.com/1077766#c33 Bug: 1077766 Change-Id: I664ca1cf120016c24ae165d4fc0b0667a308412b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398508Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#805324}
-
Leonard Grey authored
This change allows code outside of c/b/ui/views to access the main AcceleratorProvider (which happens to be BrowserView on desktop platforms). Bug: 1041639 Change-Id: I20167475c769ba3921e20ddd0cc8419aad839edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399444Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#805323}
-
Liquan (Max) Gu authored
* Move PaymentRequestImpl's mMethodData into PaymentRequestSpec. * mSpec's parsed values are still be available after mSpec is closed. This change is motivated by the fact that AutofillPaymentAppFactory accesses PRImpl#getMethodData() after mSpec is closed, causing NullPointerException[1]. In particular, this change includes: - mSpec is no longer set null when destroyed. - the callers check mSpec.isDestroyed() (added method) before using its updateWith(), retry(), recomputeSpecForDetails(), selectedShippingOptionError(). Other methods are accessible even after mSpec is destroyed. [1] https://ci.chromium.org/p/chromium/builders/try/android-marshmallow-arm64-rel/648624? Bug: 1102522 Change-Id: I018d35f50bd2ab42aa4d3b0c80e5245ad86394fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390867 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#805322}
-
Nohemi Fernandez authored
Intercepts a user tap on sign-in to display an account consistency promo that is to be defined. Bug: 1125631 Change-Id: Id8c84e066b0f9c5a3c61dd88de6716da75320bb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398523 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#805321}
-
Aaron Colwell authored
Renamed the single param version of GetSiteInfoForURL() to ComputeSiteInfoForURL() to make it a little more clear that these functions behave differently in subtle ways. The new name reflects that this method behaves like SiteInstanceImpl::ComputeSiteInfo(). This change also updates a few pieces of code to go through this renamed method so that it is clear that each of these places expect the same behavior. There are no behavior changes. Bug: 1085275 Change-Id: Ie1a1911c5d92ba620789f456f10cdc732ee95244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399450 Auto-Submit: Aaron Colwell <acolwell@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
-
Clark DuVall authored
This allows using Process.getStartUptimeMillis() for startup metrics, which will include the time spent loading java code. Bug: 1126301 Change-Id: Ia5b050ba268b3445a7dd934fab409298ce9b3c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399918Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#805319}
-
Hajime Hoshi authored
This CL adds a new UKM event * BackForwardCacheDisabledForRenderFrameHostReason and a new UKM to HistoryNavigation * BackForwardCache.DisabledForRenderFrameHostReasonCount for further analysis. The UKM privacy doc is: https://docs.google.com/document/d/1GDsehNwMEHXef_o2XqNbsXk2F0pdhXt1khVVE4cRcLw/edit?usp=sharing Bug: 1122491 Change-Id: I21fd6c9ef122b8b84d231cddea6e68fd9592bad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392188 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805318}
-
ckitagawa authored
This CL adds the ability to pre-warm a compositor process for use by paint preview show-on-startup. 1. The compositor is started when native is initialized if the experiment is enabled. 2. Depending on the situation the compositor is then used or killed. a. Compositor is used: disconnect handler is updated and it is used as if there was a compositor already. b. Compositor is not used: the process is killed immediately. This moves initialization of the compositor service up to O(100 ms) earlier (in local tests). Bug: 1126180 Change-Id: I1e6f627403e8c020b6551c510ad908bba0fc24a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398562Reviewed-by: -
Adithya Srinivasan authored
Bug: 1124352 Change-Id: I272834d52b0373334f741596e497e465c09ea712 Tbr: mmoskvitin@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401320Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#805316}
-
Maciej Malinowski authored
The Chrome Graph Processor is a wrapper for a graph processor implementation from Perfetto. This class takes care of all required input and output parameters conversion. See crbug.com/1095982 for more details. Bug: 1095982 Change-Id: I3c6a320fe354bcd4bbd93388dfc013244bc9f261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299348 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#805315}
-
Egor Pasko authored
The stories we use for getting memory usage results (as "browse_news@@NativeCodeResidentMemory_avg") got removed from Telemetry. Instead there are new stories with very similar names. Let's try them. I checked locally that the new stories are picked up and run successfully on Pixel 2/P. Bug: 1117184 Change-Id: If82ba747ea04df3a644f11d415d07525a51a7dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401100Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#805314}
-
Matt Falkenhagen authored
Change-Id: I0d6671c150f81df315f63972e757f35a389f8532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397038Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#805313}
-
Jan Wilken Dörrie authored
This change makes use of absl::variant in PasswordFormManager, which can only observe one of a form or digest at a given time. Bug: 943045 Change-Id: If81d636f0388c4730dfd585d6c68d28afba3b8ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341123 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#805312}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I17d2840c67574adeb0e474a26d0c17f36a6d88b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400885Reviewed-by:
-
Alice Wang authored
This CL disables the web sign-in bottom sheet when there are no accounts on device. Bug: 1120334 Change-Id: I0ac3be7022540bd2aed42ce638be69ce6c9ca515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397893 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#805310}
-
David Roger authored
The color for the new profile is now created earlier (before the bubble is shown), and passed to the bubble in the BubbleParameters structure. This required moving the color out of loadTimeData. Fixed: 1126238 Change-Id: Ia544b51370011addebd1ec1ba786db23cdfe6ce3 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398511Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#805309}
-
Andrei-Laurențiu Olteanu authored
Add implementation to chrome://. Add implementation to chrome-untrusted://. Add tests. Bug: b:162051831 Change-Id: Ib74ab98c7f04208b2206f8fe0988a79ee0aa87e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375286 Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#805308}
-
Alice Wang authored
This CL sets the selected account before collapsing the bottom sheet. It is a minor improvement to avoid showing empty collapsed account list. Bug: 1124737 Change-Id: I5f69cfe2a209ed0ef7bb9c17078b84452e743078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400279Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#805307}
-
Michael Lippautz authored
- Allow downcast construction; - Disallow conversion to T* directly; - Disallow Get(); This CL concludes hardening as all uses left go through an intermediate CTP handle which retains the object as long as the thread does not terminate. Bug: 1125495 Change-Id: I4ab837127745378a57513d11ffbdea3fd961b20b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396140 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#805306}
-
danakj authored
While unable to reproduce the exact failure, it is the case that if the renderer does not respond in time to previous IPCs sent through SynchronizeVisualProperties(), by submiting a new compositor frame, then a new request from the test will be dropped due to waiting for an ack. We do not need to wait for a compositor frame, but we do need the SynchronizeVisualProperties() call to send an IPC to the renderer, so we can use SynchronizeVisualPropertiesIgnoringPendingAck() instead to ensure progress. We also note that the test failed to set up an in-process child widget previously, and adjust it to have one. R=avi@chromium.org Bug: 1126153 Change-Id: I38d6f738696abf428defed966200b2c1dd6f0f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399313 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#805305}
-
Jan Wilken Dörrie authored
Bug: 791541, 1126051 Change-Id: I545bf52bb42864e5ea8e3a900ef30bce20180297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400420Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2f163ad2. With Chromium commits locally applied on WPT: de03f74d "WPT: Refactor contacts tests to use test-only-api.js" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: igrigorik@chromium.org, yoavweiss@chromium.org: external/wpt/preload yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I7ed51e9e0ceae873cb066e5af21ac7849d9715b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401058Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805303}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ca9406bac452..b7310899f126 2020-09-09 hjd@google.com Merge "Revert "Revert "ui: Upgrade mithril 1.0.2 -> 2.0.3""" 2020-09-09 treehugger-gerrit@google.com Merge "Ensure that our join key doesn't contain "NoJank"." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1b18f384e8535efadfc1fba80f513cc7fffe4d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400883Reviewed-by:
-
Adithya Srinivasan authored
This reverts commit 74b8ec6f. Reason for revert: Suspect that its causing ios test failures in bots, see https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq/11779 Original change's description: > [Empties] Enable the IllustratedEmptyStates field trial testing config. > > Change-Id: I664fa63b5b69369cb69fb4b87463ba3bb4cfc94d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386295 > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: sebsg <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805136} TBR=holte@chromium.org,sebsg@chromium.org,sczs@chromium.org Change-Id: I5a1aa3987b4591a1a5b511df4d3834c1455ea643 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401300Reviewed-by:
-
Miguel Casas authored
Decoding a bitstream in VA has two steps: one, submitting the parsed parameters and encoded chunk, and two, executing the decode. For the first part, ToT VaapiWrapper submits every piece of data individually, acquiring and releasing |va_lock_| every time. This is unnecessary, so this CL refactors the SubmitBuffer() method into a new SubmitBuffer_Locked() and adds a SubmitBuffers() to bundle a couple of submissions together. This is verified via chrome:tracing and codepen.io/full/RwarYvG that plays 4 1280x572 VP9 videos at the same time. Tracing is captured for a few seconds, results are summarised in [1,2], basically: The total decode CPU time doesn't change much on neither kohaku nor Braswell(reks) but batch-submitting takes less time, specially on BSW from ~3x0.089ms= ~0.267ms to ~0.236ms [3], so about 10%. Having less contention in the Lock makes for an ancillary reduction in Execute_Locked() from 3.295 to 3.165ms. Improvements are of course extremely small, the advantages of this CL are in reducing lock/unlock churn and associated contention. This benefit grows with the amount of decodes (e.g. Meet grid scenarios). Later CLs will migrate the other decoders, and possibly avoid the call to vaCreateBuffer() that takes a good 50% of the SubmitBuffer/s() time. [1] Kohaku w/o patch https://imgur.com/a/nVuE0Nk, [2] Kohaku with patch https://imgur.com/a/xhdbqHn [3] VP9 ToT calls SubmitBuffer 3 times per incoming encoded buffer. Bug: b/166646505 Change-Id: I1b8e36bb1d7107b5367b0b41137e2dc6625e1569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393629 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#805300}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599609504-d5a4da8648bee9c45af68f0bedc0e876fcbf0d82.profdata to chrome-mac-master-1599651808-76687bf9821b87304e86bb785c30a5b3566b2da2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I91fe8486bd7bc100144bf9ce19a4e34587d45996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400277Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b820513f2f27..88a5d76f5f62 2020-09-09 tvanderlippe@chromium.org Fix auto-unittest compile target 2020-09-09 mathias@chromium.org Force accessible link color for invalid network requests 2020-09-09 tvanderlippe@chromium.org [globals] More cleanup 2020-09-09 alexrudenko@chromium.org Remove unnecessary file pattern in karma.conf.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1058320 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I774842637aaa5376c8ba79601cb942029e8c2969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400882Reviewed-by:
-
