- 08 Apr, 2011 15 commits
-
-
rniwa@webkit.org authored
Reviewed by Eric Seidel. dump-as-markup conversion: editing/pasteboard/paste-text-001.html and paste-text-011.html https://bugs.webkit.org/show_bug.cgi?id=58078 Converted the tests. * editing/pasteboard/paste-text-001-expected.txt: Added. * editing/pasteboard/paste-text-001.html: * editing/pasteboard/paste-text-011-expected.txt: Added. * editing/pasteboard/paste-text-011.html: * platform/chromium-linux/editing/pasteboard/paste-text-001-expected.checksum: Removed. * platform/chromium-linux/editing/pasteboard/paste-text-001-expected.png: Removed. * platform/chromium-linux/editing/pasteboard/paste-text-011-expected.checksum: Removed. * platform/chromium-linux/editing/pasteboard/paste-text-011-expected.png: Removed. * platform/chromium-win/editing/pasteboard/paste-text-001-expected.checksum: Removed. * platform/chromium-win/editing/pasteboard/paste-text-001-expected.png: Removed. * platform/chromium-win/editing/pasteboard/paste-text-001-expected.txt: Removed. * platform/chromium-win/editing/pasteboard/paste-text-011-expected.checksum: Removed. * platform/chromium-win/editing/pasteboard/paste-text-011-expected.png: Removed. * platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Removed. * platform/gtk/editing/pasteboard/paste-text-001-expected.txt: Removed. * platform/gtk/editing/pasteboard/paste-text-011-expected.checksum: Removed. * platform/gtk/editing/pasteboard/paste-text-011-expected.png: Removed. * platform/gtk/editing/pasteboard/paste-text-011-expected.txt: Removed. * platform/mac-leopard/editing/pasteboard/paste-text-011-expected.checksum: Removed. * platform/mac-leopard/editing/pasteboard/paste-text-011-expected.png: Removed. * platform/mac/editing/pasteboard/paste-text-001-expected.checksum: Removed. * platform/mac/editing/pasteboard/paste-text-001-expected.png: Removed. * platform/mac/editing/pasteboard/paste-text-001-expected.txt: Removed. * platform/mac/editing/pasteboard/paste-text-011-expected.checksum: Removed. * platform/mac/editing/pasteboard/paste-text-011-expected.png: Removed. * platform/mac/editing/pasteboard/paste-text-011-expected.txt: Removed. * platform/qt/editing/pasteboard/paste-text-011-expected.checksum: Removed. * platform/qt/editing/pasteboard/paste-text-011-expected.png: Removed. * platform/qt/editing/pasteboard/paste-text-011-expected.txt: Removed. git-svn-id: svn://svn.chromium.org/blink/trunk@83246 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Darin Adler. [Mac] Editor::setComposition() should not trigger correction panel timer. https://bugs.webkit.org/show_bug.cgi?id=58049 <rdar://problem/9226305> On Mac OS X that supports autocorrection panel, typing unconfirmed composition (i.e. unconfirmed Japanese or Chinese input) should not start autocorrection timer. We added a member variable, m_shouldPreventSpellChecking, to TypingCommand. When this value is true, markMisspellingsAfterTyping() will not be called in TypingCommand::typingAddedToOpenCommand(). m_shouldPreventSpellChecking is set to true in the TypingCommand objects created by Editor::setComposition(). No new tests. No deterministically reproducible test case. Patch is based on static code analysis. Testing this also requires firing autocorrection panel timer, which can not be easily done in automated fashion. * editing/Editor.cpp: (WebCore::Editor::deleteWithDirection): (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::confirmComposition): (WebCore::Editor::setComposition): * editing/EditorCommand.cpp: (WebCore::executeDelete): * editing/TypingCommand.cpp: (WebCore::TypingCommand::TypingCommand): (WebCore::TypingCommand::deleteSelection): (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed): (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::insertLineBreak): (WebCore::TypingCommand::insertParagraphSeparator): (WebCore::TypingCommand::typingAddedToOpenCommand): * editing/TypingCommand.h: (WebCore::TypingCommand::create): (WebCore::TypingCommand::setShouldPreventSpellChecking): git-svn-id: svn://svn.chromium.org/blink/trunk@83245 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tkent@chromium.org authored
[Chromium] Update expectations for r83216 and r83235. * platform/chromium-linux/svg/custom/foreign-object-skew-expected.png: Added. * platform/chromium-linux/svg/custom/foreign-object-skew-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/custom/foreign-object-skew-expected.txt. * platform/chromium-mac-leopard/svg/custom/foreign-object-skew-expected.checksum: Removed. * platform/chromium-mac-leopard/svg/custom/foreign-object-skew-expected.png: * platform/chromium-mac/svg/custom/foreign-object-skew-expected.checksum: Removed. * platform/chromium-mac/svg/custom/foreign-object-skew-expected.png: * platform/chromium-mac/svg/zoom/text/zoom-foreignObject-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/custom/foreign-object-skew-expected.png. * platform/chromium-win-vista/svg/custom/foreign-object-skew-expected.checksum: Removed. * platform/chromium-win-vista/svg/custom/foreign-object-skew-expected.png: * platform/chromium-win/svg/custom/foreign-object-skew-expected.checksum: Removed. * platform/chromium-win/svg/custom/foreign-object-skew-expected.png: * platform/chromium-win/svg/custom/foreign-object-skew-expected.txt: * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@83244 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jchaffraix@webkit.org authored
Reviewed by Eric Seidel. Test for Bug 51465 - chrome.dll!WebCore::RenderLayer::currentTransform ReadAV@NULL (8968fc97874fa23b6799ff8f09c142e4) Forgot to add them to the original patch. * fast/css/webkit-empty-transform-preserve3d-crash-expected.txt: Added. * fast/css/webkit-empty-transform-preserve3d-crash.html: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@83243 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Kenneth Russell. clearIfComposited call is really slow https://bugs.webkit.org/show_bug.cgi?id=57999 Move getContextAttributes call after the if, so it isn't called nearly as often. No new tests. * html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::clearIfComposited): git-svn-id: svn://svn.chromium.org/blink/trunk@83242 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Dimitri Glazkov. Implement Backgroun and Mask properties in CSSStyleApplyProperty https://bugs.webkit.org/show_bug.cgi?id=57922 No tests added as no behavioral changes. * css/CSSStyleApplyProperty.cpp: Added ApplyPropertyFillLayer test to handle Background and Mask CSS Properties. (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Added constructor calls to set up: CSSPropertyBackgroundAttachment CSSPropertyBackgroundClip CSSPropertyWebkitBackgroundClip CSSPropertyWebkitBackgroundComposite CSSPropertyBackgroundOrigin CSSPropertyWebkitBackgroundOrigin CSSPropertyBackgroundSize CSSPropertyWebkitBackgroundSize CSSPropertyWebkitMaskAttachment CSSPropertyWebkitMaskClip CSSPropertyWebkitMaskComposite CSSPropertyWebkitMaskOrigin CSSPropertyWebkitMaskSize * css/CSSStyleApplyProperty.h: (WebCore::CSSStyleApplyProperty::setPropertyValue): Add function to specify an equivalent property value in the lookup table. * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove sections now implemented by CSSStyleApplyProperty. * css/CSSStyleSelector.h: Make CSSStyleApplyProperty a friend class so that the mapFill* functions are accessible. git-svn-id: svn://svn.chromium.org/blink/trunk@83241 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Ryosuke Niwa. Split run storage out from BidiResolver into a new BidiRunList class https://bugs.webkit.org/show_bug.cgi?id=57764 Part of what makes BidiResolver and InlineIterator so difficult to understand (and bug 50912 so difficult to fix) is that BidiResolver is both a state machine for the Unicode Bidi Algorithm (UBA) as well as storage for the resulting BidiRuns from the algorithm. This patch breaks the storage aspect off into its own class BidiRunList. This patch is only a start. It does not actually fix the problematic ownership relationship, but it does make it possible to fix such in a second patch. The run pointers and addRun/prependRun, etc. were already a tightly coupled logical subset of the BidiResolver class, so moving them into their own class was both obvious and easy. The only piece of logic I had to move was that deleteRuns() had a side-effect of setting the m_emptyRun bit on the resolver. I believe this deleteRuns side-effect was only ever used for one place (right after findNextLineBreak) and that it's only needed because findNextLineBreak can sometimes create bidi runs. Run creation appears to be an unintentional side-effect of how InlineIterator calls through to BidiResolver as part of bidiNext and not a desired effect of the code. I have added the call to markCurrentRunEmpty to both places deleteRuns was called (where the resolver could get re-used) as a safety precaution. We could replace both with ASSERTs in a later patch. I suspect there may be a small performance win from further refactoring so that findNextLineBreak does not need to create BidiRuns. As I commented in the code, callers should own their own BidiRunList which they pass to BidiResolver::createBidiRunsForLine. I attempted to implement that in an earlier version of this patch, but it was too complicated with the current twisted dependencies between InlineIterator/bidiNext and InlineBidiResolver. raise/lowerExplicitEmbeddingLevel are called unconditionally from commitExplicitEmbedding (which is called by bidiNext) and expect to have access to a runs list even in cases where we don't want any runs (findNextLineBreak). I also cleaned up some of the callers to pass around BidiRunList objects instead of InlineBidiResolvers now that they're separate objects. * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawBidiText): * platform/text/BidiResolver.h: (WebCore::BidiResolver::BidiResolver): (WebCore::BidiResolver::runs): (WebCore::BidiResolver::markCurrentRunEmpty): (WebCore::::appendRun): (WebCore::::lowerExplicitEmbeddingLevel): (WebCore::::raiseExplicitEmbeddingLevel): (WebCore::::reorderRunsFromLevels): (WebCore::::createBidiRunsForLine): * rendering/InlineIterator.h: (WebCore::InlineBidiResolver::appendRun): * rendering/RenderBlock.h: * rendering/RenderBlockLineLayout.cpp: (WebCore::createRun): (WebCore::RenderBlock::appendRunsForObject): (WebCore::reachedEndOfTextRenderer): (WebCore::RenderBlock::handleTrailingSpaces): (WebCore::RenderBlock::layoutInlineChildren): git-svn-id: svn://svn.chromium.org/blink/trunk@83240 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
enne@google.com authored
[chromium] Unreviewed, add baseline pixel images for decorations-transformed. * platform/chromium-mac/fast/text/decorations-transformed-expected.png: Added. * platform/chromium-win/fast/text/decorations-transformed-expected.png: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@83239 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jberlin@webkit.org authored
* WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::checkSpellingOfString): Do not risk an overflow. (WebKit::WebEditorClient::checkGrammarOfString): Ditto. git-svn-id: svn://svn.chromium.org/blink/trunk@83238 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Adam Barth. [Chromium] Fix relocation problem of popup window which introduces autofill popup sometimes moves to screen's top left corner. https://bugs.webkit.org/show_bug.cgi?id=57911 http://code.google.com/p/chromium/issues/detail?id=78073 Manual test added: manual-tests/autofill-popup-location.html Originally only height is checked so that it introduces the bug. So I changed it to check both width and height as size. * manual-tests/autofill-popup-location.html: Added. * platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::refresh): Check window size between original and new before calling setFrameRect(). git-svn-id: svn://svn.chromium.org/blink/trunk@83237 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
lforschler@apple.com authored
git-svn-id: svn://svn.chromium.org/blink/trunk@83236 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
abarth@webkit.org authored
Reviewed by Eric Seidel. Implement img-src style-src and font-src https://bugs.webkit.org/show_bug.cgi?id=58018 Test a bunch of allow/block tests for these new directives. * http/tests/security/contentSecurityPolicy/image-allowed-expected.txt: Added. * http/tests/security/contentSecurityPolicy/image-allowed.html: Added. * http/tests/security/contentSecurityPolicy/image-blocked-expected.txt: Added. * http/tests/security/contentSecurityPolicy/image-blocked.html: Added. * http/tests/security/contentSecurityPolicy/resources/blue.css: Added. * http/tests/security/contentSecurityPolicy/resources/style.xsl: Added. * http/tests/security/contentSecurityPolicy/style-allowed-expected.txt: Added. * http/tests/security/contentSecurityPolicy/style-allowed.html: Added. * http/tests/security/contentSecurityPolicy/style-blocked-expected.txt: Added. * http/tests/security/contentSecurityPolicy/style-blocked.html: Added. * http/tests/security/contentSecurityPolicy/xsl-allowed.php: Added. * http/tests/security/contentSecurityPolicy/xsl-blocked-expected.txt: Added. * http/tests/security/contentSecurityPolicy/xsl-blocked.php: Added. 2011-04-07 Adam Barth <abarth@webkit.org> Reviewed by Eric Seidel. Implement img-src style-src and font-src https://bugs.webkit.org/show_bug.cgi?id=58018 These are pretty straight forward given the rest of the infrastructure we've built so far. Tests: http/tests/security/contentSecurityPolicy/image-allowed.html http/tests/security/contentSecurityPolicy/image-blocked.html http/tests/security/contentSecurityPolicy/style-allowed.html http/tests/security/contentSecurityPolicy/style-blocked.html http/tests/security/contentSecurityPolicy/xsl-allowed.php http/tests/security/contentSecurityPolicy/xsl-blocked.php * loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::canRequest): * page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowImageFromSource): (WebCore::ContentSecurityPolicy::allowStyleFromSource): (WebCore::ContentSecurityPolicy::allowFontFromSource): (WebCore::ContentSecurityPolicy::addDirective): * page/ContentSecurityPolicy.h: git-svn-id: svn://svn.chromium.org/blink/trunk@83235 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
levin@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=58080 Reviewed by Darin Adler. No change in functionality so no new tests. * loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::writeToDatabase): Changed to used the accessor functions. (WebCore::IconDatabase::writeIconSnapshotToSQLDatabase): Ditto. * loader/icon/IconRecord.h: (WebCore::IconSnapshot::IconSnapshot): Changed to use the new member variable names. (WebCore::IconSnapshot::iconURL): Expose the property. (WebCore::IconSnapshot::timestamp): Ditto. (WebCore::IconSnapshot::data): Ditto. * loader/icon/PageURLRecord.h: (WebCore::PageURLSnapshot::PageURLSnapshot): Changed to use the new member variable names. (WebCore::PageURLSnapshot::pageURL): Expose the property. (WebCore::PageURLSnapshot::iconURL): Ditto. git-svn-id: svn://svn.chromium.org/blink/trunk@83234 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
enrica@apple.com authored
include the bug that tracks the changes required in WebKitTestRunner. * platform/win-wk2/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@83233 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jberlin@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=57862 Reviewed by Brian Weinstein. Part 4: Implement checkGrammarOfString. * Scripts/webkit2/messages.py: The generated files should include TextCheckerClient.h for WebCore::GrammarDetail. * Shared/API/c/win/WKBaseWin.h: * Shared/APIObject.h: * UIProcess/API/C/win/WKAPICastWin.h: * UIProcess/API/C/win/WKGrammarDetail.cpp: Added. (WKGrammarDetailGetTypeID): (WKGrammarDetailCreate): * UIProcess/API/C/win/WKGrammarDetail.h: Added. * UIProcess/API/C/win/WKTextChecker.h: Add the checkGrammarOfString WKTextCheckerClient function. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::checkGrammarOfString): * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: * UIProcess/TextChecker.h: * UIProcess/win/TextCheckerWin.cpp: (WebKit::TextChecker::checkGrammarOfString): Call the TextCheckerClient. * UIProcess/mac/TextCheckerMac.mm: (WebKit::TextChecker::checkSpellingOfString): Add a comment about this not being used on Mac. (WebKit::TextChecker::checkGrammarOfString): Ditto, and call notImplemented. * UIProcess/gtk/TextCheckerGtk.cpp: (WebKit::TextChecker::checkGrammarOfString): Call notImplemented. * UIProcess/qt/TextCheckerQt.cpp: (WebKit::TextChecker::checkGrammarOfString): Ditto. * UIProcess/win/WebGrammarDetail.cpp: Added. (WebKit::WebGrammarDetail::create): (WebKit::WebGrammarDetail::WebGrammarDetail): Initialize the underlying WebCore::GrammarDetail. * UIProcess/win/WebGrammarDetail.h: Added. (WebKit::WebGrammarDetail::grammarDetail): (WebKit::WebGrammarDetail::type): * UIProcess/win/WebTextCheckerClient.cpp: (WebKit::WebTextCheckerClient::checkGrammarOfString): Populate the Vector of WebCore::GrammarDetails with the WebGrammarDetails. * UIProcess/win/WebTextCheckerClient.h: * WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::checkSpellingOfString): Use WTF::notFound as the initial value for resultLocation. (WebKit::WebEditorClient::checkGrammarOfString): Send a sync message to the UI Process (similar to checkSpellingOfString and checkTextOfParagraph). * win/WebKit2.vcproj: Add WKGrammarDetail.h/.cpp and WebGrammarDetail.h/.cpp. * win/WebKit2Generated.make: Copy over WKGrammarDetail.h. git-svn-id: svn://svn.chromium.org/blink/trunk@83232 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
- 07 Apr, 2011 25 commits
-
-
barraclough@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=56913 Patch by Zoltan Herczeg <zherczeg@webkit.org> on 2011-04-07 Reviewed by Gavin Barraclough. Instead of having a seperate tag field for booleans, the logical values are stored in the payload field (for JSValue32_64 representation). 1.007x speedup on SunSpider. * jit/JIT.h: * jit/JITInlineMethods.h: (JSC::JIT::emitStoreBool): * jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_not): (JSC::JIT::emit_op_jfalse): (JSC::JIT::emitSlow_op_jfalse): (JSC::JIT::emit_op_jtrue): (JSC::JIT::emitSlow_op_jtrue): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_eq): (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emitSlow_op_neq): (JSC::JIT::compileOpStrictEq): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null): * jit/JSInterfaceJIT.h: * runtime/JSValue.h: (JSC::JSValue::JSValue): (JSC::JSValue::isTrue): (JSC::JSValue::isFalse): (JSC::JSValue::getBoolean): git-svn-id: svn://svn.chromium.org/blink/trunk@83230 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
enrica@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=58056 <rdar://problem/8862023> Reviewed by Oliver Hunt. Adding support for execCommand('undo') and execCommand('redo') in WebKit2 for Windows. * UIProcess/API/C/win/WKView.h: * UIProcess/win/WebUndoClient.cpp: (WebKit::WebUndoClient::canUndoRedo): (WebKit::WebUndoClient::executeUndoRedo): * UIProcess/win/WebUndoClient.h: * UIProcess/win/WebView.cpp: (WebKit::WebView::canUndoRedo): (WebKit::WebView::executeUndoRedo): git-svn-id: svn://svn.chromium.org/blink/trunk@83229 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dbates@webkit.org authored
Reviewed by Darin Adler. Add a layout test to ensure that mousemove is fired from a subframe https://bugs.webkit.org/show_bug.cgi?id=58094 * fast/events/iframe-onmousemove-expected.txt: Added. * fast/events/iframe-onmousemove.html: Added. * fast/events/resources/iframe-onmousemove.html: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@83228 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ossy@webkit.org authored
* platform/qt-wk2/Skipped: - Add canvas tests not to break css2.1 tests. - Remove passing css2.1 tests. git-svn-id: svn://svn.chromium.org/blink/trunk@83227 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mitz@apple.com authored
* platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::roundToDevicePixels): git-svn-id: svn://svn.chromium.org/blink/trunk@83226 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Adam Barth. Add stub support for generating Gtk build system from gyp https://bugs.webkit.org/show_bug.cgi?id=58086 This adds support for a new --port argument and plumbs through the necessary paths to allow generating for a port other than Mac. * Source/gyp/configure: 2011-04-07 Eric Seidel <eric@webkit.org> Reviewed by Adam Barth. Add stub support for generating Gtk build system from gyp https://bugs.webkit.org/show_bug.cgi?id=58086 This does not produce a buildable JavaScriptCore, but it does allow running gyp/configure --port=gtk and having it generate a gtk.Makefile which we can use for testing the rest of the plumbing. * gyp/gtk.gyp: Added. 2011-04-07 Eric Seidel <eric@webkit.org> Reviewed by Adam Barth. Add stub support for generating Gtk build system from gyp https://bugs.webkit.org/show_bug.cgi?id=58086 This does not produce a buildable WebCore, but it does allow running gyp/configure --port=gtk and having it generate a gtk.Makefile which we can use for testing the rest of the plumbing. * gyp/gtk.gyp: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@83225 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
scherkus@chromium.org authored
Revert ENABLE_TRACK patch due to compile failures. git-svn-id: svn://svn.chromium.org/blink/trunk@83223 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jer.noble@apple.com authored
* platform/gtk/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@83222 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hyatt@apple.com authored
Reviewed by Dan Bernstein. Crash on openstreetmap.org while using the map. Fix a bad interaction between the positioned movement layout optimization and the simplified layout optimization that could lead to blocks remaining marked as dirty when layout finished. This would eventually lead to an inability to properly determine the correct layout root and would cause a deleted root to be used later on. Added fast/block/positioning/complex-positioned-movement.html. Source/WebCore: * page/FrameView.cpp: (WebCore::FrameView::scheduleRelayoutOfSubtree): Add asserts to catch cases in the future where a layout root is set that has a dirty containing block. * rendering/RenderBlock.cpp: (WebCore::RenderBlock::simplifiedLayout): Change simplified layout so that the positioned movement optimization no longer clears the other layout flags. This will ensure that we still lay out our descendants if they need it. (WebCore::RenderBlock::layoutPositionedObjects): Changed to clear our layout flags now if the positioned movement is successful, since tryLayoutDoingPositionedMovementOnly no longer does the clear. * rendering/RenderBox.h: (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly): tryLayoutDoingPositionedMovementOnly now returns a boolean indicating success or failure. On success it no longer does setNeedsLayout(false), but instead will let the caller take care of it. This way the caller can still look at the other flags in case other kinds of layout are still needed. * rendering/RenderObject.h: (WebCore::RenderObject::setNeedsPositionedMovementLayout): (WebCore::RenderObject::setNeedsSimplifiedNormalFlowLayout): Changed these methods to only set their respective flags and not to try to be clever about avoiding propagation. LayoutTests: * fast/block/positioning/complex-positioned-movement.html: Added. * platform/mac/fast/block/positioning/complex-positioned-movement-expected.checksum: Added. * platform/mac/fast/block/positioning/complex-positioned-movement-expected.png: Added. * platform/mac/fast/block/positioning/complex-positioned-movement-expected.txt: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@83221 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
scherkus@chromium.org authored
Reviewed by Eric Carlson. Setup ENABLE(TRACK) feature define https://bugs.webkit.org/show_bug.cgi?id=53556 * configure.ac: 2011-04-07 Anna Cavender <annacc@chromium.org> Reviewed by Eric Carlson. Setup ENABLE(TRACK) feature define https://bugs.webkit.org/show_bug.cgi?id=53556 * Configurations/FeatureDefines.xcconfig: 2011-04-07 Anna Cavender <annacc@chromium.org> Reviewed by Eric Carlson. Setup ENABLE(TRACK) feature define + initial HTMLTrackElement https://bugs.webkit.org/show_bug.cgi?id=53556 No new tests. No real functionality added just yet. * CMakeLists.txt: * Configurations/FeatureDefines.xcconfig: * DerivedSources.make: * GNUmakefile.am: * WebCore.gypi: * WebCore.xcodeproj/project.pbxproj: * features.pri: * html/HTMLAttributeNames.in: * html/HTMLTagNames.in: * html/HTMLTrackElement.cpp: Added. (WebCore::HTMLTrackElement::HTMLTrackElement): (WebCore::HTMLTrackElement::create): (WebCore::HTMLTrackElement::insertedIntoTree): (WebCore::HTMLTrackElement::willRemove): (WebCore::HTMLTrackElement::src): (WebCore::HTMLTrackElement::setSrc): (WebCore::HTMLTrackElement::kind): (WebCore::HTMLTrackElement::setKind): (WebCore::HTMLTrackElement::srclang): (WebCore::HTMLTrackElement::setSrclang): (WebCore::HTMLTrackElement::label): (WebCore::HTMLTrackElement::setLabel): (WebCore::HTMLTrackElement::isDefault): (WebCore::HTMLTrackElement::setIsDefault): (WebCore::HTMLTrackElement::isURLAttribute): * html/HTMLTrackElement.h: Added. * html/HTMLTrackElement.idl: Added. 2011-04-07 Anna Cavender <annacc@chromium.org> Reviewed by Eric Carlson. Setup ENABLE(TRACK) feature define + initial HTMLTrackElement https://bugs.webkit.org/show_bug.cgi?id=53556 * WebKit.xcodeproj/project.pbxproj: 2011-04-07 Anna Cavender <annacc@chromium.org> Reviewed by Eric Carlson. Setup ENABLE(TRACK) feature define https://bugs.webkit.org/show_bug.cgi?id=53556 * features.gypi: 2011-04-07 Anna Cavender <annacc@chromium.org> Reviewed by Eric Carlson. Setup ENABLE(TRACK) feature define https://bugs.webkit.org/show_bug.cgi?id=53556 * Configurations/FeatureDefines.xcconfig: 2011-04-07 Anna Cavender <annacc@chromium.org> Reviewed by Eric Carlson. Setup ENABLE(TRACK) feature define https://bugs.webkit.org/show_bug.cgi?id=53556 * Configurations/FeatureDefines.xcconfig: 2011-04-07 Anna Cavender <annacc@chromium.org> Reviewed by Eric Carlson. Setup ENABLE(TRACK) feature define https://bugs.webkit.org/show_bug.cgi?id=53556 * Scripts/build-webkit: 2011-04-07 Anna Cavender <annacc@chromium.org> Reviewed by Eric Carlson. Setup ENABLE(TRACK) feature define https://bugs.webkit.org/show_bug.cgi?id=53556 * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: git-svn-id: svn://svn.chromium.org/blink/trunk@83220 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tony@chromium.org authored
Reviewed by Eric Seidel. update DRT to embed checksums in png files https://bugs.webkit.org/show_bug.cgi?id=57871 We insert the bytes for the comment in printPNG rather than at encode time because each platform does its own PNG encoding (either using CG or cairo). Putting this in pringPNG avoids having to duplicate this code, although it's not as clean as doing it at encoding time. We insert the comment right after the IHDR chunk of the PNG. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/CyclicRedundancyCheck.cpp: Added. (makeCrcTable): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js (computeCrc): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js * DumpRenderTree/CyclicRedundancyCheck.h: Added. * DumpRenderTree/PixelDumpSupport.cpp: (dumpWebViewAsPixelsAndCompareWithExpected): (convertChecksumToPNGComment): Generate the bytes to insert. (printPNG): Insert the png comment before the first IDAT section. * DumpRenderTree/PixelDumpSupport.h: * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: (printPNG): (dumpBitmap): * DumpRenderTree/cg/PixelDumpSupportCG.cpp: (printPNG): (dumpBitmap): * DumpRenderTree/win/DumpRenderTree.vcproj: * GNUmakefile.am: git-svn-id: svn://svn.chromium.org/blink/trunk@83219 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mrobinson@webkit.org authored
Fix the WebKit2 GTK+ build for older versions of GTK+. * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Include the GtkVersioning.h header. git-svn-id: svn://svn.chromium.org/blink/trunk@83218 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
abarth@webkit.org authored
Fix whitespace in GNUmakefile.am. * GNUmakefile.am: git-svn-id: svn://svn.chromium.org/blink/trunk@83217 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rdar://problem/9018212mitz@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=58083 Reviewed by Simon Fraser. Source/WebCore: Test: fast/text/decorations-transformed.html * platform/graphics/GraphicsContext.h: Added a RoundingMode enum with two values. RoundAllSides is the existing rounding mode, where each side of the rectangle snaps to the nearest pixel gridline. RoundOriginAndDimensions snaps the origin to the nearest pixel gridpoint and rounds the width and the height. In this new mode, translating a rectangle in user space never changes its dimensions in device pixels. * platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::roundToDevicePixels): Implemented RoundOriginAndDimensions. (WebCore::GraphicsContext::drawLineForText): Use RoundOriginAndDimensions, thus ensuring that all underlines have the same thickness in device pixels. * platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::roundToDevicePixels): Added RoundingMode parameter, but did not implement it. * platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::roundToDevicePixels): Ditto. * platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::roundToDevicePixels): Ditto. * platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::roundToDevicePixels): Ditto. * platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::roundToDevicePixels): Ditto. * rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintDecoration): LayoutTests: * fast/text/decorations-transformed.html: Added. * platform/mac/fast/text/decorations-transformed-expected.checksum: Added. * platform/mac/fast/text/decorations-transformed-expected.png: Added. * platform/mac/fast/text/decorations-transformed-expected.txt: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@83216 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mrobinson@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [GTK] Implement SharedMemory for WebKit2 https://bugs.webkit.org/show_bug.cgi?id=49791 Share the SharedMemory, Attachment and Connection implementations with the Qt port. Both implementation are, in fact, general Unix implementations using standard Unix domain sockets and sendmsg / recvmsg. This should reduce the amount of duplicated code greatly and lay the groundwork for GTK+/Qt implementations for other operating systems. * GNUmakefile.am: Replaced GTK+ versions of files with the Unix ones. * Platform/CoreIPC/ArgumentDecoder.cpp: Extended Qt #ifdefs to include GTK. (CoreIPC::ArgumentDecoder::~ArgumentDecoder): * Platform/CoreIPC/ArgumentEncoder.cpp: Ditto. (CoreIPC::ArgumentEncoder::~ArgumentEncoder): * Platform/CoreIPC/Attachment.h: Ditto. * Platform/CoreIPC/Connection.h: Combined the GTK+ and Qt sections. * Platform/CoreIPC/unix/AttachmentUnix.cpp: Renamed from Source/WebKit2/Platform/CoreIPC/qt/AttachmentQt.cpp. * Platform/CoreIPC/unix/ConnectionUnix.cpp: Renamed from Source/WebKit2/Platform/CoreIPC/qt/ConnectionQt.cpp. * Platform/unix/SharedMemoryUnix.cpp: Renamed from Source/WebKit2/Platform/qt/SharedMemoryQt.cpp. * UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp: (WebKit::ProcessLauncher::launchProcess): Use SOCK_DGRAM instead of SOCK_STREAM to match Qt. * WebKit2.pro: Updated source list to reflect file renaming. git-svn-id: svn://svn.chromium.org/blink/trunk@83215 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jer.noble@apple.com authored
The legacy full screen API now redirects to the new full screen API, breaking the media-fullscreen-inline.html test. * platform/mac-snowleopard/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@83214 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
vitalyr@chromium.org authored
Reviewed by Nate Chapin. [V8] Remove custom DOMImplementation getter on Document. https://bugs.webkit.org/show_bug.cgi?id=57991 The custom getter is no longer required because DOMImplementation objects are now created per document. Test: fast/dom/DOMImplementation/implementation-identity.html * bindings/scripts/CodeGeneratorV8.pm: * bindings/v8/custom/V8DocumentCustom.cpp: * dom/Document.idl: 2011-04-06 Vitaly Repeshko <vitalyr@chromium.org> Reviewed by Nate Chapin. [V8] Remove custom DOMImplementation getter on Document. https://bugs.webkit.org/show_bug.cgi?id=57991 * fast/dom/DOMImplementation/implementation-identity-expected.txt: Added. * fast/dom/DOMImplementation/implementation-identity.html: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@83213 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
barraclough@apple.com authored
* jit/JITOpcodes.cpp: (JSC::JIT::emit_op_not): * runtime/JSImmediate.h: git-svn-id: svn://svn.chromium.org/blink/trunk@83212 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ap@apple.com authored
REGRESSION (r83081): Use of deallocated memory in WebEditorClient::respondToChangedSelection() https://bugs.webkit.org/show_bug.cgi?id=58082 * WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::respondToChangedSelection): Now that the Range is used outside the full expression where it's created, it needs to be protected with RefPtr. git-svn-id: svn://svn.chromium.org/blink/trunk@83211 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Eric Carlson. Make various video layout tests platform independent by selecting an appropriate media file. Various layout tests depend on mp4 files. https://bugs.webkit.org/show_bug.cgi?id=57804 * http/tests/media/remove-while-loading.html: * http/tests/media/video-load-and-stall.cgi: * http/tests/media/video-play-stall-before-meta-data.html: * http/tests/media/video-play-stall-seek.html: * http/tests/media/video-play-stall.html: * http/tests/media/video-seekable-stall.html: * media/media-file.js: (mimeTypeForFile): (stripExtension): * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@83210 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
inferno@chromium.org authored
Reviewed by Dimitri Glazkov. setHasID() is only called for styled elements https://bugs.webkit.org/show_bug.cgi?id=57267 Test: fast/dom/non-styled-element-id-crash.html * dom/Element.cpp: (WebCore::Element::attributeChanged): (WebCore::Element::idAttributeChanged): * dom/Element.h: * dom/StyledElement.cpp: (WebCore::StyledElement::parseMappedAttribute): 2011-04-07 Sergey Glazunov <serg.glazunov@gmail.com> Reviewed by Dimitri Glazkov. setHasID() is only called for styled elements https://bugs.webkit.org/show_bug.cgi?id=57267 * fast/dom/non-styled-element-id-crash-expected.txt: Added. * fast/dom/non-styled-element-id-crash.html: Added. * svg/custom/embedded-svg-disallowed-in-dashboard.xml: Fix the failing test. git-svn-id: svn://svn.chromium.org/blink/trunk@83209 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jer.noble@apple.com authored
Reviewed by Eric Carlson. HTMLVideoElement::webkitEnterFullscreen does not use new Full Screen API when available. https://bugs.webkit.org/show_bug.cgi?id=58070 Make the HTMLMediaElement full screen functions call into the new Full Screen API when FULLSCREEN_API is enabled. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::enterFullscreen): (WebCore::HTMLMediaElement::exitFullscreen): git-svn-id: svn://svn.chromium.org/blink/trunk@83208 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
bweinstein@apple.com authored
* platform/win-wk2/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@83207 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rdar://problem/9251566mrowe@apple.com authored
doesn't account for items removed by filter callback. Reviewed by Dan Bernstein. * UIProcess/cf/WebBackForwardListCF.cpp: (WebKit::WebBackForwardList::createCFDictionaryRepresentation): Update the current item index when we omit an item due to the filter callback. git-svn-id: svn://svn.chromium.org/blink/trunk@83206 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
abarth@webkit.org authored
Reviewed by Eric Seidel. Implement CSP's options directive https://bugs.webkit.org/show_bug.cgi?id=58014 * http/tests/security/contentSecurityPolicy/inline-script-allowed-expected.txt: Added. * http/tests/security/contentSecurityPolicy/inline-script-allowed.html: Added. * http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy-expected.txt: Added. * http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy.html: Added. 2011-04-07 Adam Barth <abarth@webkit.org> Reviewed by Eric Seidel. Implement CSP's options directive https://bugs.webkit.org/show_bug.cgi?id=58014 This patch contains the full options parser, but we only have enough of CSP implemented to see the effects of disable-xss-protection. Will need to do some more work before we can see eval-script in action. Tests: http/tests/security/contentSecurityPolicy/inline-script-allowed.html http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy.html * page/ContentSecurityPolicy.cpp: (WebCore::CSPOptions::CSPOptions): (WebCore::CSPOptions::disableXSSProtection): (WebCore::CSPOptions::evalScript): (WebCore::CSPOptions::parse): (WebCore::ContentSecurityPolicy::allowJavaScriptURLs): (WebCore::ContentSecurityPolicy::allowInlineEventHandlers): (WebCore::ContentSecurityPolicy::allowInlineScript): (WebCore::ContentSecurityPolicy::addDirective): * page/ContentSecurityPolicy.h: git-svn-id: svn://svn.chromium.org/blink/trunk@83205 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-