1. 25 Jan, 2010 21 commits
    • eric@webkit.org's avatar
      2010-01-25 Yury Semikhatsky <yurys@chromium.org> · ccc79b1a
      eric@webkit.org authored
              Reviewed by Timothy Hatcher.
      
              Test that Web Inspector doesn't change methods declared by the inspected
              page.
              https://bugs.webkit.org/show_bug.cgi?id=34089
      
              * inspector/inspected-objects-not-overriden-expected.txt: Added.
              * inspector/inspected-objects-not-overriden.html: Added.
      2010-01-25  Yury Semikhatsky  <yurys@chromium.org>
      
              Reviewed by Timothy Hatcher.
      
              Instead of adding inspector methods to the inspected global objects
              use private implementation visible from inspector code only.
              https://bugs.webkit.org/show_bug.cgi?id=34089
      
              Test: inspector/inspected-objects-not-overriden.html
      
              * inspector/front-end/InjectedScript.js:
              (injectedScriptConstructor):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53807 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ccc79b1a
    • pfeldman@chromium.org's avatar
      2010-01-25 Pavel Feldman <pfeldman@chromium.org> · 8f872c06
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: don't show headers/content tabs in scripts view.
      
              https://bugs.webkit.org/show_bug.cgi?id=34083
      
              * inspector/front-end/ResourceView.js:
              (WebInspector.ResourceView):
              (WebInspector.ResourceView.prototype.set headersVisible):
              (WebInspector.ResourceView.prototype._selectContentTab):
              (WebInspector.ResourceView.prototype._innerSelectContentTab):
              * inspector/front-end/ResourcesPanel.js:
              (WebInspector.ResourcesPanel.prototype.show):
              (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
              (WebInspector.ResourcesPanel.prototype.showResource):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel.prototype.show):
              (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
              * inspector/front-end/inspector.css:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53806 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8f872c06
    • philn@webkit.org's avatar
      2010-01-25 Philippe Normand <pnormand@igalia.com> · 0a8a597c
      philn@webkit.org authored
              Rubber-stamped by Xan Lopez.
      
              [Gtk] media/video-reverse-play-duration.html fails on and off on Gtk buildbots
              https://bugs.webkit.org/show_bug.cgi?id=34086
      
              * platform/gtk/Skipped: Skipping the test, requires investigation
              on the failure.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53805 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0a8a597c
    • eric@webkit.org's avatar
      2010-01-25 Simon Hausmann <hausmann@webkit.org> · 04744a15
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Reduce the size of the library when compiling for Maemo5
              https://bugs.webkit.org/show_bug.cgi?id=34050
      
              Exclude the Web Inspector's qrc file in the Maemo5 build, just
              like we do for the Symbian build. Saves about ~900k.
      
              * WebCore.pro:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53804 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      04744a15
    • eric@webkit.org's avatar
      2010-01-25 Simon Hausmann <hausmann@webkit.org> · c3ec0eeb
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] In the StyledPainter determine the style from the Render and Scrollbar theme instead of from the paint device
              https://bugs.webkit.org/show_bug.cgi?id=34054
      
              Getting the style from the painter's paint device is a hack that breaks when
              the paint device's style is different than the style that is used when
              calculating the metries earlier when there is no painter available.
      
              This change moves us closer to always using the same style.
      
              * platform/qt/RenderThemeQt.cpp:
              (WebCore::StylePainter::StylePainter):
              (WebCore::StylePainter::init):
              (WebCore::RenderThemeQt::paintButton):
              (WebCore::RenderThemeQt::paintTextField):
              (WebCore::RenderThemeQt::paintMenuList):
              (WebCore::RenderThemeQt::paintMenuListButton):
              (WebCore::RenderThemeQt::paintSliderTrack):
              (WebCore::RenderThemeQt::paintMediaMuteButton):
              (WebCore::RenderThemeQt::paintMediaPlayButton):
              (WebCore::RenderThemeQt::paintMediaSliderTrack):
              (WebCore::RenderThemeQt::paintMediaSliderThumb):
              * platform/qt/RenderThemeQt.h:
              * platform/qt/ScrollbarThemeQt.cpp:
              (WebCore::ScrollbarThemeQt::paint):
              (WebCore::ScrollbarThemeQt::hitTest):
              (WebCore::ScrollbarThemeQt::shouldCenterOnThumb):
              (WebCore::ScrollbarThemeQt::scrollbarThickness):
              (WebCore::ScrollbarThemeQt::thumbLength):
              (WebCore::ScrollbarThemeQt::trackPosition):
              (WebCore::ScrollbarThemeQt::trackLength):
              (WebCore::ScrollbarThemeQt::paintScrollCorner):
              (WebCore::ScrollbarThemeQt::style):
              * platform/qt/ScrollbarThemeQt.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53803 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c3ec0eeb
    • eric@webkit.org's avatar
      2010-01-25 Simon Hausmann <hausmann@webkit.org> · 09bb5305
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] In RenderThemeQt determine the QStyle from the page client instead of the page's view
              https://bugs.webkit.org/show_bug.cgi?id=34053
      
              * platform/qt/QWebPageClient.h: Add function to return the style.
              * platform/qt/RenderThemeQt.cpp:
              (WebCore::RenderThemeQt::qStyle): Determine the style from the page client instead of the page's view.
      2010-01-25  Simon Hausmann  <hausmann@webkit.org>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] In RenderThemeQt determine the QStyle from the page client instead of the page's view
              https://bugs.webkit.org/show_bug.cgi?id=34053
      
              * Api/qgraphicswebview.cpp:
              (QGraphicsWebViewPrivate::style): Implement QWebPageClient::style() and return the graphics
              widget's style.
              * Api/qwebpage.cpp:
              (QWebPageWidgetClient::style): Implement QWebPageClient::style() and return the widget's style.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53802 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      09bb5305
    • hausmann@webkit.org's avatar
      [Qt] Clean up code to determine palette from page client in RenderThemeQt · 35dbea40
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=34052
      
      Patch by Simon Hausmann <hausmann@webkit.org> on 2010-01-25
      Reviewed by Kenneth Christiansen.
      
      Use the RenderTheme's associated page instead of going through the
      render tree and the document.
      
      * platform/qt/RenderThemeQt.cpp:
      (WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
      (WebCore::RenderThemeQt::initializeCommonQStyleOptions):
      * platform/qt/RenderThemeQt.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53801 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      35dbea40
    • hausmann@webkit.org's avatar
      [Qt] Fix the build on Maemo5. · 25a17af6
      hausmann@webkit.org authored
      Reviewed by Laszlo Gombos.
      
      https://bugs.webkit.org/show_bug.cgi?id=34051
      
      * WebKit.pri: Disable the use of uitools, just like it's done for Symbian.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53800 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      25a17af6
    • eric@webkit.org's avatar
      2010-01-25 Janne Koskinen <janne.p.koskinen@digia.com> · 7a335a35
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Phone backup support for QtWebkit for Symbian devices.
              https://bugs.webkit.org/show_bug.cgi?id=34077
      
              * WebCore.pro:
      2010-01-25  Janne Koskinen  <janne.p.koskinen@digia.com>
      
              Reviewed by Simon Hausmann.
      
              [Qt] Phone backup support for QtWebkit for Symbian devices.
              https://bugs.webkit.org/show_bug.cgi?id=34077
      
              * symbian/backup_registration.xml: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53799 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7a335a35
    • yurys@chromium.org's avatar
      2010-01-25 Yury Semikhatsky <yurys@chromium.org> · bc577a80
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Update inspector test expectations. Line number and source
              name are present only in Chromium when console message is
              logged before document load is completed.
      
              https://bugs.webkit.org/show_bug.cgi?id=34078
      
              * platform/chromium/inspector/console-log-before-inspector-open-expected.txt: Added.
              * platform/gtk/inspector/console-log-before-inspector-open-expected.txt: Copied from LayoutTests/inspector/console-log-before-inspector-open-expected.txt.
              * platform/mac/inspector/console-log-before-inspector-open-expected.txt: Copied from LayoutTests/inspector/console-log-before-inspector-open-expected.txt.
              * platform/win/inspector/console-log-before-inspector-open-expected.txt: Renamed from LayoutTests/inspector/console-log-before-inspector-open-expected.txt.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53798 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      bc577a80
    • eric@webkit.org's avatar
      2010-01-25 Benjamin Poulain <benjamin.poulain@nokia.com> · 0035fbd8
      eric@webkit.org authored
              Reviewed by Antti Koivisto.
      
              Do not render the full frame when there is some elements with fixed positioning
              https://bugs.webkit.org/show_bug.cgi?id=33150
      
              Do not render the full frame when there is some elements with fixed positioning
              https://bugs.webkit.org/show_bug.cgi?id=33150
      
              * page/FrameView.cpp:
              (WebCore::FrameView::useSlowRepaints):
              (WebCore::FrameView::useSlowRepaintsIfNotOverlapped):
              (WebCore::FrameView::registerFixedPositionedObject):
              (WebCore::FrameView::unregisterFixedPositionedObject):
              (WebCore::FrameView::scrollContentsFastPath):
              * page/FrameView.h:
              * platform/ScrollView.cpp:
              (WebCore::ScrollView::scrollContents):
              (WebCore::ScrollView::scrollContentsFastPath):
              * platform/ScrollView.h:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::styleWillChange):
              (WebCore::RenderObject::destroy):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53797 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0035fbd8
    • eric@webkit.org's avatar
      2010-01-25 Chris Jerdonek <cjerdonek@webkit.org> · 62304ffe
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Improved prepare-ChangeLog so that it preserves the relative
              indentation of a git commit message.
      
              https://bugs.webkit.org/show_bug.cgi?id=34058
      
              * Scripts/prepare-ChangeLog:
                - Also adjusted the script so that it does not add white
                  space characters to empty lines.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53796 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      62304ffe
    • pfeldman@chromium.org's avatar
      2010-01-24 Pavel Feldman <pfeldman@chromium.org> · d6b791db
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: Add support for addMessage/clearMessages to SourceFrame2.
      
              https://bugs.webkit.org/show_bug.cgi?id=33904
      
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * inspector/front-end/SourceFrame2.js:
              (WebInspector.SourceFrame2):
              (WebInspector.SourceFrame2.prototype.addMessage):
              (WebInspector.SourceFrame2.prototype.clearMessages):
              (WebInspector.SourceFrame2.prototype._incrementMessageRepeatCount):
              (WebInspector.SourceFrame2.prototype._addExistingMessagesToSource):
              (WebInspector.SourceFrame2.prototype._addMessageToSource):
              (WebInspector.SourceFrame2.prototype.resize):
              * inspector/front-end/TextEditor.js:
              (WebInspector.TextEditor):
              (WebInspector.TextEditor.prototype.setDivDecoration):
              (WebInspector.TextEditor.prototype._lineHeight):
              (WebInspector.TextEditor.prototype._highlightChanged):
              (WebInspector.TextEditor.prototype.packAndRepaintAll):
              (WebInspector.TextEditor.prototype._updateSize):
              (WebInspector.TextEditor.prototype._repaintAll):
              (WebInspector.TextEditor.prototype._paint):
              (WebInspector.TextEditor.prototype._paintLinesContinuation):
              (WebInspector.TextEditor.prototype._mouseOut):
              (WebInspector.TextEditor.prototype._updateDivDecorations):
              (WebInspector.TextEditor.prototype._positionDivDecoration):
              (WebInspector.TextEditor.prototype._paintSelection):
              (WebInspector.TextEditor.prototype._replaceSelectionWith):
              * inspector/front-end/TextEditorHighlighter.js:
              (WebInspector.TextEditorHighlighter.prototype.updateHighlight):
              * inspector/front-end/WebKit.qrc:
              * inspector/front-end/inspector.css:
              * inspector/front-end/inspector.html:
              * inspector/front-end/textEditor.css: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53795 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d6b791db
    • pfeldman@chromium.org's avatar
      2010-01-24 Pavel Feldman <pfeldman@chromium.org> · dc7fa5c3
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: Replace split pane with tabbed pane in resource
              contents view.
      
              https://bugs.webkit.org/show_bug.cgi?id=32453
      
              * inspector/front-end/ResourceView.js:
              (WebInspector.ResourceView):
              (WebInspector.ResourceView.prototype.attach):
              (WebInspector.ResourceView.prototype.show):
              (WebInspector.ResourceView.prototype._selectTab):
              (WebInspector.ResourceView.prototype._selectHeadersTab):
              (WebInspector.ResourceView.prototype._selectContentTab):
              * inspector/front-end/ResourcesPanel.js:
              (WebInspector.ResourcesPanel.prototype.show):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53794 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      dc7fa5c3
    • rolandsteiner@chromium.org's avatar
      build fix: rubber-stamped by Eric Seidel. · a38c841b
      rolandsteiner@chromium.org authored
      Fix expected baselines for ruby layout tests on Windows.
      
      * platform/win/fast/ruby/ruby-empty-rt-expected.txt:
      * platform/win/fast/ruby/ruby-length-expected.txt:
      * platform/win/fast/ruby/ruby-run-break-expected.txt:
      * platform/win/fast/ruby/ruby-runs-expected.txt:
      * platform/win/fast/ruby/ruby-runs-spans-expected.txt:
      * platform/win/fast/ruby/ruby-simple-expected.txt:
      * platform/win/fast/ruby/ruby-simple-rp-expected.txt:
      * platform/win/fast/ruby/ruby-trailing-expected.txt:
      * platform/win/fast/ruby/rubyDOM-insert-rt-expected.txt:
      * platform/win/fast/ruby/rubyDOM-insert-text1-expected.txt:
      * platform/win/fast/ruby/rubyDOM-insert-text2-expected.txt:
      * platform/win/fast/ruby/rubyDOM-insert-text3-expected.txt:
      * platform/win/fast/ruby/rubyDOM-remove-rt1-expected.txt:
      * platform/win/fast/ruby/rubyDOM-remove-rt2-expected.txt:
      * platform/win/fast/ruby/rubyDOM-remove-text1-expected.txt:
      * platform/win/fast/ruby/rubyDOM-remove-text2-expected.txt:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53793 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a38c841b
    • eric.carlson@apple.com's avatar
      2010-01-24 Eric Carlson <eric.carlson@apple.com> · b1caeb4d
      eric.carlson@apple.com authored
              Reviewed by Dan Bernstein.
      
              Media element duration changes to zero after playing in reverse
              https://bugs.webkit.org/show_bug.cgi?id=34041
      
              Test: media/video-reverse-play-duration.html
      
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
              (WebCore::MediaPlayerPrivate::didEnd): QTKit's ended notification fires at time zero when 
              playing in reverse, so don't reset duration in that case.
      
      2010-01-24  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Media element duration changes to zero after playing in reverse
              https://bugs.webkit.org/show_bug.cgi?id=34041
      
              * media/video-reverse-play-duration-expected.txt: Added.
              * media/video-reverse-play-duration.html: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53792 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b1caeb4d
    • rolandsteiner@chromium.org's avatar
      Bug 28420 - Re-enable ruby Windows layout tests · b5df1379
      rolandsteiner@chromium.org authored
      (https://bugs.webkit.org/show_bug.cgi?id=28420, patch 5b)
      
      Reviewed by Maciej Stachowiak.
      
      After creating new Latin-character-only layout tests for ruby
      (https://bugs.webkit.org/show_bug.cgi?id=31865) and resolving the issue
      that caused layout tests to fail then due to the addition of the ruby
      layout tests (cf. https://bugs.webkit.org/show_bug.cgi?id=31200, problem
      not actually caused by ruby), the ruby layout tests should als be
      un-skipped for the Windows platform.
      
      * platform/win/Skipped:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53791 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b5df1379
    • mjs@apple.com's avatar
      2010-01-24 Maciej Stachowiak <mjs@apple.com> · 60d108fe
      mjs@apple.com authored
              Reviewed by Dan Bernstein.
      
              Content with heavily nested residual style is so slow, it seems like a hang
              https://bugs.webkit.org/show_bug.cgi?id=34059
              <rdar://problem/7292906>
              
              Test cast: fast/parser/residual-style-hang.html
      
              * html/HTMLParser.cpp:
              (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
              Limit the number of iterations of the main loop to 5.
              
              The reason this limit is necessary is that otherwise, N misnested open tags followed
              by N misnested close tags will cause O(N^2) of work due to cloning and attaching subtrees;
              at a fixed limit, the cost is at worst O(N).
              
              The code that was in the loop originally ran exactly once - the loop was added in
              r21472 to fix <https://bugs.webkit.org/show_bug.cgi?id=13603>. I have verified that
              with the iteration limit, the bug is still fixed, both with the original test case
              and with the layout tests tht were added.
      2010-01-24  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Content with heavily nested residual style is so slow, it seems like a hang
              https://bugs.webkit.org/show_bug.cgi?id=34059
              <rdar://problem/7292906>
      
              Test case for the above bug fix.
      
              * fast/parser/residual-style-hang-expected.txt: Added.
              * fast/parser/residual-style-hang.html: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53790 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      60d108fe
    • eric@webkit.org's avatar
      2010-01-24 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 11dc7527
      eric@webkit.org authored
              Reviewed by Maciej Stachowiak.
      
              Refactor JITStubs.cpp so that DEFINE_STUB_FUNCTION is only used once for each function
              https://bugs.webkit.org/show_bug.cgi?id=33866
      
              Place the guard USE(JSVALUE32_64) inside the body of the DEFINE_STUB_FUNCTION
              macro for those functions that are always present.
      
              * jit/JITStubs.cpp:
              (JSC::DEFINE_STUB_FUNCTION):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53789 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      11dc7527
    • eric@webkit.org's avatar
      2010-01-24 Kent Tamura <tkent@chromium.org> · a6475a4d
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Improve portability of listbox-selection-2.html
              https://bugs.webkit.org/show_bug.cgi?id=33994
      
              - Convert to dumpAsText().
              - Determine the height of an item at runtime
      
              * fast/forms/listbox-selection-2-expected.txt: Added.
              * fast/forms/listbox-selection-2.html:
              * fast/forms/script-tests/listbox-selection-2.js
              * platform/mac/fast/forms/listbox-selection-2-expected.checksum: Removed.
              * platform/mac/fast/forms/listbox-selection-2-expected.png: Removed.
              * platform/mac/fast/forms/listbox-selection-2-expected.txt: Removed.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53788 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a6475a4d
    • tkent@chromium.org's avatar
      2010-01-24 Kent Tamura <tkent@chromium.org> · fc90f2dd
      tkent@chromium.org authored
              Reviewed by Darin Adler.
      
              HTMLInputElement::valueAsDate setter support for type=week.
              https://bugs.webkit.org/show_bug.cgi?id=33986
      
              Add setter tests to input-valueasdate-datetime.js, and update the
              expectation.
      
              * fast/forms/input-valueasdate-week-expected.txt:
              * fast/forms/script-tests/input-valueasdate-week.js:
      
      2010-01-24  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Darin Adler.
      
              HTMLInputElement::valueAsDate setter support for type=week.
              https://bugs.webkit.org/show_bug.cgi?id=33986
      
              Introduce ISODateTime::setMillisecondsSinceEpochForWeek() and add
              Week type support to ISODateTime::toString().
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::valueAsDate): Avoid default:.
              (WebCore::HTMLInputElement::setValueAsDate):
                Add WEEK type handling and avoid default:.
              * html/ISODateTime.cpp:
              (WebCore::offsetTo1stWeekStart):
              (WebCore::ISODateTime::setMillisecondsSinceEpochForWeek):
              (WebCore::ISODateTime::millisecondsSinceEpoch):
              (WebCore::ISODateTime::toString):
                Add Week type support and avoid default:.
              * html/ISODateTime.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53787 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      fc90f2dd
  2. 24 Jan, 2010 14 commits
  3. 23 Jan, 2010 5 commits
    • kenneth@webkit.org's avatar
      [Qt] Unreviewed build fix · d5b987f6
      kenneth@webkit.org authored
      * QtLauncher/QtLauncher.pro:
      * QtLauncher/webinspector.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53772 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d5b987f6
    • kenneth@webkit.org's avatar
      Rubberstamped by Simon Hausmann. · 9dcce452
      kenneth@webkit.org authored
      [Qt] Move the WebInspector class to it's own header file.
      
      * QtLauncher/main.cpp:
      * QtLauncher/webinspector.h: Added.
      (WebInspector::WebInspector):
      (WebInspector::showEvent):
      (WebInspector::hideEvent):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53771 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9dcce452
    • eric@webkit.org's avatar
      2010-01-23 Robert Hogan <robert@roberthogan.net> · 52a8b624
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              Qt DRT: respect window.close() and window.closed()
      
              Qt DRT needs to maintain a correct count of open windows
              for windowCount(). It also needs to delete windows that
              have been closed by window.close().
      
              This fixes the following tests:
      
              plugins/destroy-during-npp-new.html
              fast/dom/Document/early-document-access.html
              fast/dom/Window/window-early-properties.html
              fast/events/open-window-from-another-frame.html
              fast/events/popup-blocking-click-in-iframe.html
      
              https://bugs.webkit.org/show_bug.cgi?id=32953
      
              * platform/qt/Skipped:
      2010-01-23  Robert Hogan  <robert@roberthogan.net>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              Qt DRT: respect window.close() and window.closed()
      
              Qt DRT needs to maintain a correct count of open windows
              for windowCount(). It also needs to delete windows that
              have been closed by window.close().
      
              This fixes the following tests:
      
              plugins/destroy-during-npp-new.html
              fast/dom/Document/early-document-access.html
              fast/dom/Window/window-early-properties.html
              fast/events/open-window-from-another-frame.html
              fast/events/popup-blocking-click-in-iframe.html
      
              https://bugs.webkit.org/show_bug.cgi?id=32953
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::DumpRenderTree::DumpRenderTree):
              (WebCore::DumpRenderTree::createWindow):
              (WebCore::DumpRenderTree::windowCloseRequested):
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::maybeDump):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53770 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      52a8b624
    • eric@webkit.org's avatar
      2010-01-23 Girish Ramakrishnan <girish@forwardbias.in> · 13c01c18
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Fix positioning of ComboBox popup in QGraphicsWebView.
      
              Wrap the popup in a QGraphicsProxyWidget, so that the popup
              transforms with the item.
      
              https://bugs.webkit.org/show_bug.cgi?id=33887
      
              * WebCoreSupport/QtFallbackWebPopup.cpp:
              (WebCore::QtFallbackWebPopupCombo::hidePopup):
              (WebCore::QtFallbackWebPopup::QtFallbackWebPopup):
              (WebCore::QtFallbackWebPopup::~QtFallbackWebPopup):
              (WebCore::QtFallbackWebPopup::show):
              * WebCoreSupport/QtFallbackWebPopup.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53769 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      13c01c18
    • simon.fraser@apple.com's avatar
      2010-01-22 Simon Fraser <simon.fraser@apple.com> · 8638dfbc
      simon.fraser@apple.com authored
              Reviewed by Eric Carlson.
      
              Race condition in video setup can force videos into software mode
              https://bugs.webkit.org/show_bug.cgi?id=34034
      
              We used to call setUpVideoRendering() unconditionally from
              acceleratedRenderingStateChanged(); this could happen before the movie had any
              data, and thus force the movie into software rendering mode.
      
              Fix by returning early from setUpVideoRendering() if isReadyForRendering() returns false,
              which also allows us to remove some other checks for being ready to render.
      
              Timing dependent, hard to make a test for.
      
              * platform/graphics/mac/GraphicsLayerCA.mm:
              (WebCore::GraphicsLayerCA::setContentsToMedia): Optimize to do an early return
              if passing in the same layer that is already being used.
      
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
              (WebCore::MediaPlayerPrivate::setUpVideoRendering): Return without doing anything
              if not ready to render.
              (WebCore::MediaPlayerPrivate::updateStates): No need to call isReadyForRendering()
              any more, since setUpVideoRendering() does that.
              (WebCore::MediaPlayerPrivate::setVisible): No need to check the ready state; this
              is equivalent to the check inside of setUpVideoRendering().
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53768 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8638dfbc