- 25 Jan, 2010 21 commits
-
-
eric@webkit.org authored
Reviewed by Timothy Hatcher. Test that Web Inspector doesn't change methods declared by the inspected page. https://bugs.webkit.org/show_bug.cgi?id=34089 * inspector/inspected-objects-not-overriden-expected.txt: Added. * inspector/inspected-objects-not-overriden.html: Added. 2010-01-25 Yury Semikhatsky <yurys@chromium.org> Reviewed by Timothy Hatcher. Instead of adding inspector methods to the inspected global objects use private implementation visible from inspector code only. https://bugs.webkit.org/show_bug.cgi?id=34089 Test: inspector/inspected-objects-not-overriden.html * inspector/front-end/InjectedScript.js: (injectedScriptConstructor): git-svn-id: svn://svn.chromium.org/blink/trunk@53807 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
pfeldman@chromium.org authored
Reviewed by Timothy Hatcher. Web Inspector: don't show headers/content tabs in scripts view. https://bugs.webkit.org/show_bug.cgi?id=34083 * inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype.set headersVisible): (WebInspector.ResourceView.prototype._selectContentTab): (WebInspector.ResourceView.prototype._innerSelectContentTab): * inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded): (WebInspector.ResourcesPanel.prototype.showResource): * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype._showScriptOrResource): * inspector/front-end/inspector.css: git-svn-id: svn://svn.chromium.org/blink/trunk@53806 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
philn@webkit.org authored
Rubber-stamped by Xan Lopez. [Gtk] media/video-reverse-play-duration.html fails on and off on Gtk buildbots https://bugs.webkit.org/show_bug.cgi?id=34086 * platform/gtk/Skipped: Skipping the test, requires investigation on the failure. git-svn-id: svn://svn.chromium.org/blink/trunk@53805 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Reduce the size of the library when compiling for Maemo5 https://bugs.webkit.org/show_bug.cgi?id=34050 Exclude the Web Inspector's qrc file in the Maemo5 build, just like we do for the Symbian build. Saves about ~900k. * WebCore.pro: git-svn-id: svn://svn.chromium.org/blink/trunk@53804 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] In the StyledPainter determine the style from the Render and Scrollbar theme instead of from the paint device https://bugs.webkit.org/show_bug.cgi?id=34054 Getting the style from the painter's paint device is a hack that breaks when the paint device's style is different than the style that is used when calculating the metries earlier when there is no painter available. This change moves us closer to always using the same style. * platform/qt/RenderThemeQt.cpp: (WebCore::StylePainter::StylePainter): (WebCore::StylePainter::init): (WebCore::RenderThemeQt::paintButton): (WebCore::RenderThemeQt::paintTextField): (WebCore::RenderThemeQt::paintMenuList): (WebCore::RenderThemeQt::paintMenuListButton): (WebCore::RenderThemeQt::paintSliderTrack): (WebCore::RenderThemeQt::paintMediaMuteButton): (WebCore::RenderThemeQt::paintMediaPlayButton): (WebCore::RenderThemeQt::paintMediaSliderTrack): (WebCore::RenderThemeQt::paintMediaSliderThumb): * platform/qt/RenderThemeQt.h: * platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::paint): (WebCore::ScrollbarThemeQt::hitTest): (WebCore::ScrollbarThemeQt::shouldCenterOnThumb): (WebCore::ScrollbarThemeQt::scrollbarThickness): (WebCore::ScrollbarThemeQt::thumbLength): (WebCore::ScrollbarThemeQt::trackPosition): (WebCore::ScrollbarThemeQt::trackLength): (WebCore::ScrollbarThemeQt::paintScrollCorner): (WebCore::ScrollbarThemeQt::style): * platform/qt/ScrollbarThemeQt.h: git-svn-id: svn://svn.chromium.org/blink/trunk@53803 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] In RenderThemeQt determine the QStyle from the page client instead of the page's view https://bugs.webkit.org/show_bug.cgi?id=34053 * platform/qt/QWebPageClient.h: Add function to return the style. * platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::qStyle): Determine the style from the page client instead of the page's view. 2010-01-25 Simon Hausmann <hausmann@webkit.org> Reviewed by Kenneth Rohde Christiansen. [Qt] In RenderThemeQt determine the QStyle from the page client instead of the page's view https://bugs.webkit.org/show_bug.cgi?id=34053 * Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::style): Implement QWebPageClient::style() and return the graphics widget's style. * Api/qwebpage.cpp: (QWebPageWidgetClient::style): Implement QWebPageClient::style() and return the widget's style. git-svn-id: svn://svn.chromium.org/blink/trunk@53802 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hausmann@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=34052 Patch by Simon Hausmann <hausmann@webkit.org> on 2010-01-25 Reviewed by Kenneth Christiansen. Use the RenderTheme's associated page instead of going through the render tree and the document. * platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::setPaletteFromPageClientIfExists): (WebCore::RenderThemeQt::initializeCommonQStyleOptions): * platform/qt/RenderThemeQt.h: git-svn-id: svn://svn.chromium.org/blink/trunk@53801 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hausmann@webkit.org authored
Reviewed by Laszlo Gombos. https://bugs.webkit.org/show_bug.cgi?id=34051 * WebKit.pri: Disable the use of uitools, just like it's done for Symbian. git-svn-id: svn://svn.chromium.org/blink/trunk@53800 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Simon Hausmann. [Qt] Phone backup support for QtWebkit for Symbian devices. https://bugs.webkit.org/show_bug.cgi?id=34077 * WebCore.pro: 2010-01-25 Janne Koskinen <janne.p.koskinen@digia.com> Reviewed by Simon Hausmann. [Qt] Phone backup support for QtWebkit for Symbian devices. https://bugs.webkit.org/show_bug.cgi?id=34077 * symbian/backup_registration.xml: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@53799 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yurys@chromium.org authored
Reviewed by Pavel Feldman. Update inspector test expectations. Line number and source name are present only in Chromium when console message is logged before document load is completed. https://bugs.webkit.org/show_bug.cgi?id=34078 * platform/chromium/inspector/console-log-before-inspector-open-expected.txt: Added. * platform/gtk/inspector/console-log-before-inspector-open-expected.txt: Copied from LayoutTests/inspector/console-log-before-inspector-open-expected.txt. * platform/mac/inspector/console-log-before-inspector-open-expected.txt: Copied from LayoutTests/inspector/console-log-before-inspector-open-expected.txt. * platform/win/inspector/console-log-before-inspector-open-expected.txt: Renamed from LayoutTests/inspector/console-log-before-inspector-open-expected.txt. git-svn-id: svn://svn.chromium.org/blink/trunk@53798 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Antti Koivisto. Do not render the full frame when there is some elements with fixed positioning https://bugs.webkit.org/show_bug.cgi?id=33150 Do not render the full frame when there is some elements with fixed positioning https://bugs.webkit.org/show_bug.cgi?id=33150 * page/FrameView.cpp: (WebCore::FrameView::useSlowRepaints): (WebCore::FrameView::useSlowRepaintsIfNotOverlapped): (WebCore::FrameView::registerFixedPositionedObject): (WebCore::FrameView::unregisterFixedPositionedObject): (WebCore::FrameView::scrollContentsFastPath): * page/FrameView.h: * platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents): (WebCore::ScrollView::scrollContentsFastPath): * platform/ScrollView.h: * rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange): (WebCore::RenderObject::destroy): git-svn-id: svn://svn.chromium.org/blink/trunk@53797 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Adam Barth. Improved prepare-ChangeLog so that it preserves the relative indentation of a git commit message. https://bugs.webkit.org/show_bug.cgi?id=34058 * Scripts/prepare-ChangeLog: - Also adjusted the script so that it does not add white space characters to empty lines. git-svn-id: svn://svn.chromium.org/blink/trunk@53796 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
pfeldman@chromium.org authored
Reviewed by Timothy Hatcher. Web Inspector: Add support for addMessage/clearMessages to SourceFrame2. https://bugs.webkit.org/show_bug.cgi?id=33904 * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * inspector/front-end/SourceFrame2.js: (WebInspector.SourceFrame2): (WebInspector.SourceFrame2.prototype.addMessage): (WebInspector.SourceFrame2.prototype.clearMessages): (WebInspector.SourceFrame2.prototype._incrementMessageRepeatCount): (WebInspector.SourceFrame2.prototype._addExistingMessagesToSource): (WebInspector.SourceFrame2.prototype._addMessageToSource): (WebInspector.SourceFrame2.prototype.resize): * inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype.setDivDecoration): (WebInspector.TextEditor.prototype._lineHeight): (WebInspector.TextEditor.prototype._highlightChanged): (WebInspector.TextEditor.prototype.packAndRepaintAll): (WebInspector.TextEditor.prototype._updateSize): (WebInspector.TextEditor.prototype._repaintAll): (WebInspector.TextEditor.prototype._paint): (WebInspector.TextEditor.prototype._paintLinesContinuation): (WebInspector.TextEditor.prototype._mouseOut): (WebInspector.TextEditor.prototype._updateDivDecorations): (WebInspector.TextEditor.prototype._positionDivDecoration): (WebInspector.TextEditor.prototype._paintSelection): (WebInspector.TextEditor.prototype._replaceSelectionWith): * inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter.prototype.updateHighlight): * inspector/front-end/WebKit.qrc: * inspector/front-end/inspector.css: * inspector/front-end/inspector.html: * inspector/front-end/textEditor.css: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@53795 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
pfeldman@chromium.org authored
Reviewed by Timothy Hatcher. Web Inspector: Replace split pane with tabbed pane in resource contents view. https://bugs.webkit.org/show_bug.cgi?id=32453 * inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype.attach): (WebInspector.ResourceView.prototype.show): (WebInspector.ResourceView.prototype._selectTab): (WebInspector.ResourceView.prototype._selectHeadersTab): (WebInspector.ResourceView.prototype._selectContentTab): * inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show): git-svn-id: svn://svn.chromium.org/blink/trunk@53794 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rolandsteiner@chromium.org authored
Fix expected baselines for ruby layout tests on Windows. * platform/win/fast/ruby/ruby-empty-rt-expected.txt: * platform/win/fast/ruby/ruby-length-expected.txt: * platform/win/fast/ruby/ruby-run-break-expected.txt: * platform/win/fast/ruby/ruby-runs-expected.txt: * platform/win/fast/ruby/ruby-runs-spans-expected.txt: * platform/win/fast/ruby/ruby-simple-expected.txt: * platform/win/fast/ruby/ruby-simple-rp-expected.txt: * platform/win/fast/ruby/ruby-trailing-expected.txt: * platform/win/fast/ruby/rubyDOM-insert-rt-expected.txt: * platform/win/fast/ruby/rubyDOM-insert-text1-expected.txt: * platform/win/fast/ruby/rubyDOM-insert-text2-expected.txt: * platform/win/fast/ruby/rubyDOM-insert-text3-expected.txt: * platform/win/fast/ruby/rubyDOM-remove-rt1-expected.txt: * platform/win/fast/ruby/rubyDOM-remove-rt2-expected.txt: * platform/win/fast/ruby/rubyDOM-remove-text1-expected.txt: * platform/win/fast/ruby/rubyDOM-remove-text2-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@53793 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric.carlson@apple.com authored
Reviewed by Dan Bernstein. Media element duration changes to zero after playing in reverse https://bugs.webkit.org/show_bug.cgi?id=34041 Test: media/video-reverse-play-duration.html * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::didEnd): QTKit's ended notification fires at time zero when playing in reverse, so don't reset duration in that case. 2010-01-24 Eric Carlson <eric.carlson@apple.com> Reviewed by Dan Bernstein. Media element duration changes to zero after playing in reverse https://bugs.webkit.org/show_bug.cgi?id=34041 * media/video-reverse-play-duration-expected.txt: Added. * media/video-reverse-play-duration.html: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@53792 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rolandsteiner@chromium.org authored
(https://bugs.webkit.org/show_bug.cgi?id=28420, patch 5b) Reviewed by Maciej Stachowiak. After creating new Latin-character-only layout tests for ruby (https://bugs.webkit.org/show_bug.cgi?id=31865) and resolving the issue that caused layout tests to fail then due to the addition of the ruby layout tests (cf. https://bugs.webkit.org/show_bug.cgi?id=31200, problem not actually caused by ruby), the ruby layout tests should als be un-skipped for the Windows platform. * platform/win/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@53791 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mjs@apple.com authored
Reviewed by Dan Bernstein. Content with heavily nested residual style is so slow, it seems like a hang https://bugs.webkit.org/show_bug.cgi?id=34059 <rdar://problem/7292906> Test cast: fast/parser/residual-style-hang.html * html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Limit the number of iterations of the main loop to 5. The reason this limit is necessary is that otherwise, N misnested open tags followed by N misnested close tags will cause O(N^2) of work due to cloning and attaching subtrees; at a fixed limit, the cost is at worst O(N). The code that was in the loop originally ran exactly once - the loop was added in r21472 to fix <https://bugs.webkit.org/show_bug.cgi?id=13603>. I have verified that with the iteration limit, the bug is still fixed, both with the original test case and with the layout tests tht were added. 2010-01-24 Maciej Stachowiak <mjs@apple.com> Reviewed by Dan Bernstein. Content with heavily nested residual style is so slow, it seems like a hang https://bugs.webkit.org/show_bug.cgi?id=34059 <rdar://problem/7292906> Test case for the above bug fix. * fast/parser/residual-style-hang-expected.txt: Added. * fast/parser/residual-style-hang.html: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@53790 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Maciej Stachowiak. Refactor JITStubs.cpp so that DEFINE_STUB_FUNCTION is only used once for each function https://bugs.webkit.org/show_bug.cgi?id=33866 Place the guard USE(JSVALUE32_64) inside the body of the DEFINE_STUB_FUNCTION macro for those functions that are always present. * jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION): git-svn-id: svn://svn.chromium.org/blink/trunk@53789 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Darin Adler. Improve portability of listbox-selection-2.html https://bugs.webkit.org/show_bug.cgi?id=33994 - Convert to dumpAsText(). - Determine the height of an item at runtime * fast/forms/listbox-selection-2-expected.txt: Added. * fast/forms/listbox-selection-2.html: * fast/forms/script-tests/listbox-selection-2.js * platform/mac/fast/forms/listbox-selection-2-expected.checksum: Removed. * platform/mac/fast/forms/listbox-selection-2-expected.png: Removed. * platform/mac/fast/forms/listbox-selection-2-expected.txt: Removed. git-svn-id: svn://svn.chromium.org/blink/trunk@53788 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tkent@chromium.org authored
Reviewed by Darin Adler. HTMLInputElement::valueAsDate setter support for type=week. https://bugs.webkit.org/show_bug.cgi?id=33986 Add setter tests to input-valueasdate-datetime.js, and update the expectation. * fast/forms/input-valueasdate-week-expected.txt: * fast/forms/script-tests/input-valueasdate-week.js: 2010-01-24 Kent Tamura <tkent@chromium.org> Reviewed by Darin Adler. HTMLInputElement::valueAsDate setter support for type=week. https://bugs.webkit.org/show_bug.cgi?id=33986 Introduce ISODateTime::setMillisecondsSinceEpochForWeek() and add Week type support to ISODateTime::toString(). * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueAsDate): Avoid default:. (WebCore::HTMLInputElement::setValueAsDate): Add WEEK type handling and avoid default:. * html/ISODateTime.cpp: (WebCore::offsetTo1stWeekStart): (WebCore::ISODateTime::setMillisecondsSinceEpochForWeek): (WebCore::ISODateTime::millisecondsSinceEpoch): (WebCore::ISODateTime::toString): Add Week type support and avoid default:. * html/ISODateTime.h: git-svn-id: svn://svn.chromium.org/blink/trunk@53787 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
- 24 Jan, 2010 14 commits
-
-
eric.carlson@apple.com authored
No review, build fix. Only log the first 'timeupdate' event from audio-delete-while-slider-thumb-clicked.html as the number fired can vary according to how long it takes to run the test. * media/audio-delete-while-slider-thumb-clicked.html: git-svn-id: svn://svn.chromium.org/blink/trunk@53786 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
oliver@apple.com authored
Reviewed by Darin Adler. Object Serialization assumes deserialization will always occur in the context of a webpage https://bugs.webkit.org/show_bug.cgi?id=34056 rdar://7573833 Added ClassInfo to JSDOMGlobalObject and make the window and worker class info inherit from it. With this in place we're able to determine whether a given global object is a DOMGlobalObject, and then use that information to avoid attempting to deserialize types that require the presence of the DOM. No test as all global objects in webkit inherit from JSDOMGlobalObject. * bindings/js/JSDOMGlobalObject.cpp: (WebCore::): * bindings/js/JSDOMGlobalObject.h: (WebCore::JSDOMGlobalObject::classInfo): * bindings/js/JSDOMWindowBase.cpp: (WebCore::): * bindings/js/JSWorkerContextBase.cpp: (WebCore::): * bindings/js/SerializedScriptValue.cpp: (WebCore::DeserializingTreeWalker::DeserializingTreeWalker): (WebCore::DeserializingTreeWalker::convertIfTerminal): git-svn-id: svn://svn.chromium.org/blink/trunk@53785 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
No review. Middle clicking the primary scroll bars on Chromium Linux triggers a paste event https://bugs.webkit.org/show_bug.cgi?id=33062 * platform/gtk/Skipped: - This new test fails on Gtk for unknown reasons. - Skipping for now to make the bots green, until a Gtk person can look. git-svn-id: svn://svn.chromium.org/blink/trunk@53784 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
No review, rolling out r53763. http://trac.webkit.org/changeset/53763 https://bugs.webkit.org/show_bug.cgi?id=33895 Broke 20+ tests on Windows. * Scripts/run-webkit-tests: * Scripts/webkitdirs.pm: git-svn-id: svn://svn.chromium.org/blink/trunk@53783 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
cjerdonek@webkit.org authored
license text. Also added information about copyright lines. Reviewed by David Kilzer. https://bugs.webkit.org/show_bug.cgi?id=34017 * coding/contributing.html: * css/main.css: - Added CSS class for books. git-svn-id: svn://svn.chromium.org/blink/trunk@53782 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
simon.fraser@apple.com authored
No review. Fix incorrect layout test that I checked in earlier. * platform/mac/compositing/reflections/load-video-in-reflection-expected.checksum: * platform/mac/compositing/reflections/load-video-in-reflection-expected.png: * platform/mac/compositing/reflections/load-video-in-reflection-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@53781 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric.carlson@apple.com authored
Reviewed by Simon Fraser. https://bugs.webkit.org/show_bug.cgi?id=34047 <rdar://problem/7573699> Media element "endedPlayback" logic doesn't match spec Test: media/video-timeupdate-reverse-play.html * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::ended): The 'ended' attribute should only be true when playback rate is positive. (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Always schedule a 'timeupdate' event when the media engine signals a time discontinuity, scheduleTimeupdateEvent will only queue an event if one hasn't already been posted for the current movie time. (WebCore::HTMLMediaElement::endedPlayback): Update to match the spec logic. 2010-01-24 Eric Carlson <eric.carlson@apple.com> Reviewed by Simon Fraser. https://bugs.webkit.org/show_bug.cgi?id=34047 <rdar://problem/7573699> Media element "endedPlayback" logic doesn't match spec * media/video-timeupdate-reverse-play-expected.txt: Added. * media/video-timeupdate-reverse-play.html: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@53780 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
simon.fraser@apple.com authored
Reviewed by Darin Adler. Video that loads inside reflection doesn't get reflected https://bugs.webkit.org/show_bug.cgi?id=34046 ensureCloneLayers() made an incorrect assumption that if a clone of the primaryLayer exists already, then the structural layer and content layer can just be returned. However, this doesn't account for the situation where a content layer may have been create after the clone tree was last updated. Fix by always creating the structural and clone layers on demand. Test: compositing/reflections/load-video-in-reflection.html * platform/graphics/mac/GraphicsLayerCA.h: Added utility method, findOrMakeClone(). * platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::findOrMakeClone): Utility that efficiently finds or creates a layer in a LayerMap. (WebCore::GraphicsLayerCA::ensureCloneLayers): Always look for or clone the structural and content layers, rather than relying on whether there's a primary layer clone already. git-svn-id: svn://svn.chromium.org/blink/trunk@53779 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
abarth@webkit.org authored
More pep8 compliance. * Scripts/webkitpy/mock_bugzillatool.py: git-svn-id: svn://svn.chromium.org/blink/trunk@53778 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
abarth@webkit.org authored
More pep8 compliance. * Scripts/webkitpy/executive.py: * Scripts/webkitpy/grammar.py: git-svn-id: svn://svn.chromium.org/blink/trunk@53777 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
abarth@webkit.org authored
More pep8 compliance. * Scripts/webkitpy/comments.py: * Scripts/webkitpy/committers.py: * Scripts/webkitpy/credentials.py: git-svn-id: svn://svn.chromium.org/blink/trunk@53776 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
abarth@webkit.org authored
Make changelogs.py pass pep8. * Scripts/webkitpy/changelogs.py: git-svn-id: svn://svn.chromium.org/blink/trunk@53775 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
oliver@apple.com authored
Reviewed by Maciej Stachowiak. Implement support for FileList cloning in postMessage https://bugs.webkit.org/show_bug.cgi?id=34048 Add test for passing a FileList through postMessage, and correct testing already present to test what it was meant to be. * fast/dom/Window/window-postmessage-clone-expected.txt: * fast/dom/Window/window-postmessage-clone.html: 2010-01-23 Oliver Hunt <oliver@apple.com> Reviewed by Maciej Stachowiak. Implement support for FileList cloning in postMessage https://bugs.webkit.org/show_bug.cgi?id=34048 Support passing FileList through postMessage APIs. Basically mechanical task in line with other terminals in the object graph. * bindings/js/SerializedScriptValue.cpp: (WebCore::SerializedFileList::create): (WebCore::SerializedFileList::length): (WebCore::SerializedFileList::item): (WebCore::SerializedFileList::SerializedFileList): (WebCore::SerializedScriptValueData::SerializedScriptValueData): (WebCore::SharedSerializedData::asFileList): (WebCore::SerializingTreeWalker::convertIfTerminal): (WebCore::DeserializingTreeWalker::convertIfTerminal): (WebCore::TeardownTreeWalker::convertIfTerminal): Rearrange these functions to not use 'default:' handling so that the compiler will actually tell us when we're not handling cases. * bindings/js/SerializedScriptValue.h: (WebCore::SerializedScriptValueData::): (WebCore::SerializedScriptValueData::asFileList): git-svn-id: svn://svn.chromium.org/blink/trunk@53774 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rdar://problem/7569820mitz@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=34006 Reviewed by Maciej Stachowiak. WebKit/win: * WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Added WebKitZoomsTextOnlyPreferenceKey with a default value of true. LayoutTests: * platform/win/svg/custom/text-zoom-expected.txt: Removed. git-svn-id: svn://svn.chromium.org/blink/trunk@53773 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
- 23 Jan, 2010 5 commits
-
-
kenneth@webkit.org authored
* QtLauncher/QtLauncher.pro: * QtLauncher/webinspector.h: git-svn-id: svn://svn.chromium.org/blink/trunk@53772 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kenneth@webkit.org authored
[Qt] Move the WebInspector class to it's own header file. * QtLauncher/main.cpp: * QtLauncher/webinspector.h: Added. (WebInspector::WebInspector): (WebInspector::showEvent): (WebInspector::hideEvent): git-svn-id: svn://svn.chromium.org/blink/trunk@53771 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. Qt DRT: respect window.close() and window.closed() Qt DRT needs to maintain a correct count of open windows for windowCount(). It also needs to delete windows that have been closed by window.close(). This fixes the following tests: plugins/destroy-during-npp-new.html fast/dom/Document/early-document-access.html fast/dom/Window/window-early-properties.html fast/events/open-window-from-another-frame.html fast/events/popup-blocking-click-in-iframe.html https://bugs.webkit.org/show_bug.cgi?id=32953 * platform/qt/Skipped: 2010-01-23 Robert Hogan <robert@roberthogan.net> Reviewed by Kenneth Rohde Christiansen. Qt DRT: respect window.close() and window.closed() Qt DRT needs to maintain a correct count of open windows for windowCount(). It also needs to delete windows that have been closed by window.close(). This fixes the following tests: plugins/destroy-during-npp-new.html fast/dom/Document/early-document-access.html fast/dom/Window/window-early-properties.html fast/events/open-window-from-another-frame.html fast/events/popup-blocking-click-in-iframe.html https://bugs.webkit.org/show_bug.cgi?id=32953 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::createWindow): (WebCore::DumpRenderTree::windowCloseRequested): * DumpRenderTree/qt/DumpRenderTreeQt.h: * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::maybeDump): git-svn-id: svn://svn.chromium.org/blink/trunk@53770 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Fix positioning of ComboBox popup in QGraphicsWebView. Wrap the popup in a QGraphicsProxyWidget, so that the popup transforms with the item. https://bugs.webkit.org/show_bug.cgi?id=33887 * WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopupCombo::hidePopup): (WebCore::QtFallbackWebPopup::QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::~QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::show): * WebCoreSupport/QtFallbackWebPopup.h: git-svn-id: svn://svn.chromium.org/blink/trunk@53769 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
simon.fraser@apple.com authored
Reviewed by Eric Carlson. Race condition in video setup can force videos into software mode https://bugs.webkit.org/show_bug.cgi?id=34034 We used to call setUpVideoRendering() unconditionally from acceleratedRenderingStateChanged(); this could happen before the movie had any data, and thus force the movie into software rendering mode. Fix by returning early from setUpVideoRendering() if isReadyForRendering() returns false, which also allows us to remove some other checks for being ready to render. Timing dependent, hard to make a test for. * platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToMedia): Optimize to do an early return if passing in the same layer that is already being used. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::setUpVideoRendering): Return without doing anything if not ready to render. (WebCore::MediaPlayerPrivate::updateStates): No need to call isReadyForRendering() any more, since setUpVideoRendering() does that. (WebCore::MediaPlayerPrivate::setVisible): No need to check the ready state; this is equivalent to the check inside of setUpVideoRendering(). git-svn-id: svn://svn.chromium.org/blink/trunk@53768 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-