GitLab

Developers can use this column to see what resources share connection.

BUG=

Review URL: https://codereview.chromium.org/513703002

git-svn-id: svn://svn.chromium.org/blink/trunk@181461 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
TBR=tkent@chromium.org
BUG=411175

Review URL: https://codereview.chromium.org/538343003

git-svn-id: svn://svn.chromium.org/blink/trunk@181460 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is required for CL, https://codereview.chromium.org/456413002, to run webkit_unit_tests on android.

R=jochen@chromium.org

Review URL: https://codereview.chromium.org/542003002

git-svn-id: svn://svn.chromium.org/blink/trunk@181459 bbb929c8-8fbe-4397-9dbb-9b2b20218538

deps.py was used before the Blink fork. We don't need this anymore
and also the code that was using it was already removed long ago.

BUG=none

Review URL: https://codereview.chromium.org/536273003

git-svn-id: svn://svn.chromium.org/blink/trunk@181458 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Based on issue 519653002

BUG=391593

Review URL: https://codereview.chromium.org/541603003

git-svn-id: svn://svn.chromium.org/blink/trunk@181457 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes the instance() function and adds a new function
callbackQueues() to keep the map in the schedular itself. This
function will return the map.

Review URL: https://codereview.chromium.org/528373003

git-svn-id: svn://svn.chromium.org/blink/trunk@181456 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=410988

Review URL: https://codereview.chromium.org/541913004

git-svn-id: svn://svn.chromium.org/blink/trunk@181455 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If for some reason the webkitpy tools can't create a pretty diff
then we should not ask if the diff was correct.

BUG=

Review URL: https://codereview.chromium.org/544593003

git-svn-id: svn://svn.chromium.org/blink/trunk@181454 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=keishi@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/545133002

git-svn-id: svn://svn.chromium.org/blink/trunk@181453 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=410298
R=lushnikov

Review URL: https://codereview.chromium.org/536323003

git-svn-id: svn://svn.chromium.org/blink/trunk@181452 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The frames of bitmap images can change due to extrinsic reasons, other than new
network data arrival or image frame animations. Add a new ImageResoruce api for
updating images for extrinsic reasons, with optional decoder reset support used
to force image re-decoding if needed.

TEST=webkit_unit_tests --gtest_filter="ImageResource*UpdateBitmapImages"
BUG=410135, 369901

Review URL: https://codereview.chromium.org/526153002

git-svn-id: svn://svn.chromium.org/blink/trunk@181451 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Renames the following functions / methods.
- ScriptWrappable::
  - fromInternalPointer -> toImpl
  - toInternalPointer -> toScriptWrappableBase
- blink::toInternalPointer -> toScriptWrappableBase
- V8T::
  - toNative -> toImpl
  - toNativeWithTypeCheck -> toImplWithTypeCheck
  - fromInternalPointer -> toImpl
  - toInternalPointer -> toScriptWrappableBase

BUG=235436
TBR=tkent@chromium.org

Review URL: https://codereview.chromium.org/537403002

git-svn-id: svn://svn.chromium.org/blink/trunk@181450 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Replace m_which with m_callbackType

Review URL: https://codereview.chromium.org/539943003

git-svn-id: svn://svn.chromium.org/blink/trunk@181449 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=351204

Review URL: https://codereview.chromium.org/540803003

git-svn-id: svn://svn.chromium.org/blink/trunk@181448 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently MIDIAccess.inputs is a function that returns a sequence. With this CL
it will be an attribute of type MIDIInputMap, as specified in the spec.
MIDIAccess.outputs will be an attribute of type MIDIOutputMap in the same
manner. |forEach| is not yet supported.
The existing MIDIAccess.inputs and MIDIAccess.outputs functions cannot
be used with this CL.

BUG=341423

Review URL: https://codereview.chromium.org/513203002

git-svn-id: svn://svn.chromium.org/blink/trunk@181447 bbb929c8-8fbe-4397-9dbb-9b2b20218538

That call takes an optional list of paths to restrict the list of tests
to. In some cases, the paths may refer to directories or tests in virtual
test suites.

Previously, we would load all of the virtual test suites and compute all
of the underlying actual tests for each suite, even if the list of paths
made no reference to the suite. This would result in us doing a lot of
unnecessary file system traversals to do path discovery, which is pretty
fast most of the time. It turns out we only notice this during
'webkit-patch optimize-baselines', where we do a lot of test discovery over
and over again.

Fixing the tests() implementation to only discover the tests for the paths
we care about makes optimize-baselines 3x faster on mac and almost 20x faster on linux.

Existing test cases are reused to guarantee coverage.

R=ojan@chromium.org
BUG=410626

Review URL: https://codereview.chromium.org/539793002

git-svn-id: svn://svn.chromium.org/blink/trunk@181446 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
TBR=tkent@chromium.org
BUG=411175

Review URL: https://codereview.chromium.org/542053002

git-svn-id: svn://svn.chromium.org/blink/trunk@181445 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Inside of VectorMatch::vsmul is calling vDSP_vsmul when MACOS macro is enabled.
FFTFrameMac is used both method VectorMatch::vsmul and  vDSP_vsmul.
It needs to change to VectorMatch for code maintenance.

BUG=411128

Review URL: https://codereview.chromium.org/545773002

git-svn-id: svn://svn.chromium.org/blink/trunk@181444 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I don't believe this was a recent regression, it's possible that recent
changes simply made it easier to trigger this crash.

BUG=409506

Review URL: https://codereview.chromium.org/539603002

git-svn-id: svn://svn.chromium.org/blink/trunk@181443 bbb929c8-8fbe-4397-9dbb-9b2b20218538

realData, imagData are common members for all platform and solution.
It doesn't need to be under each solution's macro.
Then, additionally wrong style has been fixed.

BUG=411127

Review URL: https://codereview.chromium.org/536843002

git-svn-id: svn://svn.chromium.org/blink/trunk@181442 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The default value of text parameter was handled in C++ code. Now the IDL
parser supports optional default value syntax, let's use it.

BUG=
TEST=fast/css/font*

Review URL: https://codereview.chromium.org/540223002

git-svn-id: svn://svn.chromium.org/blink/trunk@181441 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Retires manual dispatching of 'wrap' in createV8{HTML,SVG}Wrapper in
V8{HTML,SVG}ElementWrapperFactory.cpp and its dependents.

This is part of the V8 binding refactoring (Issue 235436) and also
this CL fixes Issue 408160 by removing wrong downcasts by toHTMLUnknownElement().

There are much more code to be removed as part of the refactoring, but let me remove the code in this CL first.  Will continue to remove more unnecessary code.

BUG=408160,235436

Review URL: https://codereview.chromium.org/531183003

git-svn-id: svn://svn.chromium.org/blink/trunk@181440 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The spots where allDataReceived() was checked in an if statement, or
asserted against were switched, so the release build was going right
through the code in getYUVComponentSizes(), without returning early,
which could lead to a crash.

Added safety checks inside the JPEG decoder just in case we get into
this situation some other way.

BUG=410788,410586

Review URL: https://codereview.chromium.org/528293003

git-svn-id: svn://svn.chromium.org/blink/trunk@181439 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=tkent
NOTRY=true
BUG=411164

Review URL: https://codereview.chromium.org/546703002

git-svn-id: svn://svn.chromium.org/blink/trunk@181438 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=340522

Review URL: https://codereview.chromium.org/527183002

git-svn-id: svn://svn.chromium.org/blink/trunk@181437 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TEST=LayoutTests/http/tests/serviceworker/resources/request-worker.js
BUG=402387

Review URL: https://codereview.chromium.org/533123002

git-svn-id: svn://svn.chromium.org/blink/trunk@181436 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change makes navigator.serviceWorker.ready return a promise to be resolved
with ServiceWorkerRegistration object instead of ServiceWorker object.

Tests for '.ready' (ie. 'ready.html') are now disabled and those will be
re-enabled by the 3rd patch.

1) Blink: THIS PATCH
2) Chromium: https://codereview.chromium.org/477593007/
3) Blink: https://codereview.chromium.org/532653002/

Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-container


BUG=399533
TEST=run_webkit_tests.py --debug http/tests/serviceworker/

Review URL: https://codereview.chromium.org/476043002

git-svn-id: svn://svn.chromium.org/blink/trunk@181435 bbb929c8-8fbe-4397-9dbb-9b2b20218538

> Reduce hit test on ShowPress by moving hit testing to WebViewImpl.
> 
> Previously there was a hit test for link highlighting in WebViewImpl and then a                                          
> separate one in EventHandler::handleGestureEvent. This CL makes it so that a                                             
> single hit test in WebViewImpl is reused by the EventHandler. Scroll events                                              
> still need to hit test in a separate fashion though and their handling has been                                          
> refactored into a separate code path.
> 
> BUG=381728
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181009
> 
> Review URL: https://codereview.chromium.org/490783003

TBR=zeeshanq@chromium.org

Review URL: https://codereview.chromium.org/546693002

git-svn-id: svn://svn.chromium.org/blink/trunk@181434 bbb929c8-8fbe-4397-9dbb-9b2b20218538

> Partial revert of r178392
>
> An unnecessary modification that was made in Blink r178392 was causing
> a regression in the rendering of the inspector timeline.  Pulling it
> out
>
> BUG=408080
> R=kbr@chromium.org
>
> Review URL: https://codereview.chromium.org/541783002

TBR=junov@chromium.org
BUG=

Review URL: https://codereview.chromium.org/542963002

git-svn-id: svn://svn.chromium.org/blink/trunk@181433 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously, :link/:visited style was only updated when the href was changed
to/from a clickable anchor. The :enabled style still only needs updating
when wasLink and isLink differ.

BUG=63372

Review URL: https://codereview.chromium.org/537353002

git-svn-id: svn://svn.chromium.org/blink/trunk@181432 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adds trooper feed type & pulling of trooper alerts feed from trooper-o-matic.
Refactors ct-failure-card to accept different card types.
Adds failure card types for sheriff, cq-latency, cycle-time and tree-status.

BUG=399732

Review URL: https://codereview.chromium.org/476903004

git-svn-id: svn://svn.chromium.org/blink/trunk@181431 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Profiling data from perf for content_shell on android shows that ImageResource::didDraw 
is a bottleneck when drawImage APIs are frequently called in Canvas2D benchmarks.

ImageResource::didDraw update info (access time, etc) in MemoryCache and prune the cache if 
necessary. But Images are decoded into DiscardableMemory, which is another cache mechanism 
except for MemoryCache. Images are not in MemoryCache at all, so we don't need to update the 
info in MemoryCache for these resources.

This small CL avoid updating MemoryCache during drawImage to improve performance. Table below 
lists how much BitmapResource::didDraw costs in the whole render process w/ or w/o this CL. 
All benchmarks are tested on Nexus 7.
benchmark           original percentage       CL applied percentage
speedReading               6.9 %                  0.05 % 
GM3 bitmap                 4.5 %                  0.04 %

The FPS of speedReading improved more than 5%. The FPS of GM3_Bitmap improved a little, because 
the original FPS is as high as 58. For other Canvas2D benchmarks(FishIETank, Galactic, etc), 
BitmapResource::didDraw costs ~1.5%. After this CL is applied, it costs about 0.02%. The FPS 
of these benchmarks basically keeps the same because didDraw in these cases is not as heavy as 
it is in speedReading/GM3_Bitmap.

BUG=410663

Review URL: https://codereview.chromium.org/534963003

git-svn-id: svn://svn.chromium.org/blink/trunk@181430 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=340522

Review URL: https://codereview.chromium.org/478693005

git-svn-id: svn://svn.chromium.org/blink/trunk@181429 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181419

BUG=410491
TBR=rob.buis@samsung.com

Review URL: https://codereview.chromium.org/545753002

git-svn-id: svn://svn.chromium.org/blink/trunk@181428 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously there was a hit test for link highlighting in WebViewImpl and then a                                          
separate one in EventHandler::handleGestureEvent. This CL makes it so that a                                             
single hit test in WebViewImpl is reused by the EventHandler. Scroll events                                              
still need to hit test in a separate fashion though and their handling has been                                          
refactored into a separate code path.

BUG=381728

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181009

Review URL: https://codereview.chromium.org/490783003

git-svn-id: svn://svn.chromium.org/blink/trunk@181427 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181413

BUG=409593
TBR=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/543953002

git-svn-id: svn://svn.chromium.org/blink/trunk@181426 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We run into issues where a cl lands through Chromium's trybots and then breaks the main waterfall because of this. Chromium's trybots use release-with-asserts builds.

BUG=410916

Review URL: https://codereview.chromium.org/544773003

git-svn-id: svn://svn.chromium.org/blink/trunk@181425 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Otherwise, those children can be rendered as pat of the software rendering of the current
layer and its non-compositing descendants.

BUG=

Review URL: https://codereview.chromium.org/535553002

git-svn-id: svn://svn.chromium.org/blink/trunk@181424 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Move position changed case from
RenderStyle::diffNeedsFullLayoutAndPaintInvalidation()
to RenderStyle::diffNeedsFullLayout().

Our layout code can issue invalidations if actually needed.

BUG=408697
TEST=fast/repaint/position-change-keeping-geometry.html

Review URL: https://codereview.chromium.org/536183002

git-svn-id: svn://svn.chromium.org/blink/trunk@181423 bbb929c8-8fbe-4397-9dbb-9b2b20218538

state of FormControlElements.

This patch does a lazy update of validity, avoiding caching stale value.
setNeedsValidityCheck() now does not update validity, but flags it for update.

BUG=400618,403313
TEST=LayoutTests/fast/forms/number/number-validity-badinput.html

Review URL: https://codereview.chromium.org/460343004

git-svn-id: svn://svn.chromium.org/blink/trunk@181422 bbb929c8-8fbe-4397-9dbb-9b2b20218538