- 29 Jul, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/90836d9a6e45..e4645dda2096 Created with: gclient setdep -r src-internal@e4645dda2096 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I151486459e5e55d090e09c5931d968413f1fadb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723577Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681911}
-
yilkal authored
This CL corrects settings_private.idl and prefs_util.cc so that it is consistent with the javascript implementation. Bug: 945082 Change-Id: I29777701297057d9cf262fb235ccb4291e4d699e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724814Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#681910}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b51a6f0c4638..8cce70e1a7c6 git log b51a6f0c4638..8cce70e1a7c6 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 capn@google.com Fail GLSL compilation if compiler initialization fails Created with: gclient setdep -r src/third_party/swiftshader@8cce70e1a7c6 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/137828018 Change-Id: I250175c1966068bc9f98b824f8a3111bbc207aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723579Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681909}
-
Istiaque Ahmed authored
This is currently unused, and has been so for quite some time. Bug: None Change-Id: If1504fcec2aee489ce6c53e686ef433d26d4849c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723166Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#681908}
-
sczs authored
Bug: 804656 Change-Id: If64d08303a860f3c67c7e61be254ad1363d93137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721930 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#681907}
-
Jian Li authored
Reason for revert: Caused crash in ProtoBackgroundTracingTest.ProtoTraceReceived [12270:12270:0729/060351.545777:FATAL:privacy_filtering_check.cc(48)] Unexpected field in TracePacket proto. IDs from root to child : 35 : 10 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8906596135024273344/+/steps/content_browsertests_on_Ubuntu-14.04/0/logs/Deterministic_failure:_ProtoBackgroundTracingTest.ProtoTraceReceived__status_CRASH_/0 Bug: 988528 Change-Id: Ic79b173cccdd46dc92875d4e1a2e4fe5aa2bd099 Tbr: skyosti@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724125Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#681906}
-
Jacob DeWitt authored
Now, only XRWebGLLayer is defined by the spec and it does not inherit from XRLayer. Bug: 987023 Change-Id: Iaf4f878b33ef816df1e85a39642dea25f318bfa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721929Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#681905}
-
Christopher Cameron authored
There exist 3 bugs related to custom UserDataDir and PWAs. 1. If Chrome is launched by the PWA, then the UserDataDir is not specified to Chrome. - Fix this by specifying switches::kUserDataDir on the command line 2. If the PWA attempts to launch Chrome, it does not specify the flag NSWorkspaceLaunchNewInstance, and so any existing instance of Chrome (even one with a different UserDataDir) will be returned. - Fix this by specifying NSWorkspaceLaunchNewInstance 3. When the PWA determines if an instance of Chrome is running, the PWA will find any running Chrome instance, not necessarily the one with the PWA's UserDataDir. - The fix for this is more complicated and described below. Instead of looking up running Chrome instances using +[NSRunningApplication runningApplicationsWithBundleIdentifier:], use the same mechanism that Chrome uses to detect multiple instances running using the same UserDataDir. In particular - Check the chrome::kSingletonLockFilename symlink in the UserDataDir - Parse this to find the pid of the running Chrome instance - If this pid is a valid Chrome instance, use that - Otherwise, launch a new instance of Chrome As before, allow the PWA to wait for up to 60 seconds for Chrome to start. During this polling period: - If the process we found via chrome::kSingletonLockFilename quits, then give up and quit the PWA. - If we launched a Chrome process and it has quit, and we haven't yet found a process via chrome::kSingletonLockFilename, then give up and quit the PWA. Bug: 980099 Change-Id: Id322e30da99fdc72319497ead84948d7aff426f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693906Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#681904}
-
Jun Mukai authored
My CL r681543 removed the layer for PageSwitcher and reused a new AppsContainerView's layer, but it turned out this was wrong since the opacity of parent layer affects the descendent layer opacities. This CL revives the PageSwitcher layer to recover the original behavior of the opacity when dragging the app-list. Since all of AppsContainerView's children have their own layers, this is okay to be ui::LAYER_NOT_DRAWN and hence it won't affect the drawing performance. Bug: 988494 Test: manually Change-Id: If1913b5fa426b7ee63bb25ac7fef180375cdd30d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722408Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#681903}
-
Armando Miraglia authored
BUG=986494, 986500 Change-Id: I9b83632caae4e53c5f7430a01bf27c83ff2a8cbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722937Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#681902}
-
Mark Mentovai authored
32475fa2 changed the GPU helper's bundle ID to {org.chromium.Chromium,com.google.Chrome}.helper, omitting the .gpu that used to be there, to solve bug 985486. This helper's bundle ID is also mentioned in the signing script, where it's part of the helper's designated requirement. In order for signing to succeed, .gpu must also be removed from this requirement string. Bug: 985486, 988387, 988506 Change-Id: Ieecae6c82dc38f5a150c0e03e4f750d618ab45fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724661Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#681901}
-
Hiroki Nakagawa authored
In the current implementation, WorkerShadowPage provides DocumentLoader to ApplicationCacheHost for shared workers. This blocks WorkerShadowPage removal (see the issue). To unblock it, this series of CLs reduce dependencies on DocumentLoader from ApplicationCacheHost for shared workers. This CL moves ApplicationCacheHost::NotifyApplicationCache() to ApplicationCacheHostForFrame. That function is called for dispatching DOMEvent related appcache, but it's not necessary for shared workers because shared workers don't have any appcache interfaces. Bug: 982996 Change-Id: I019ee6df5850408b160bd09663be246071bb0c48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722135Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#681900}
-
Steven Bennetts authored
This CL: * Adds ManagedProperties and its many subobjects to network_config.mojom * Adds and implements CrosNetworkConfig.GetManagedProperties for retrieving managed properties. * Uses GetManagedProperties in the chrome://network test UI. Bug: 853953 Change-Id: I11cbef3ffcf814335c4b4cdafda31c0ef19ff4fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680778 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#681899}
-
Matthew Mourgos authored
- The launcher search box will now only process events when the app list main view can process events. Bug: 985583 Change-Id: I0716a84dece411ede7a905932d70e55ece78e8eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722249 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
Carlos Caballero authored
MessageLoopForUI will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=sczs@chromium.org Change-Id: Icff05dbcd5ffbea9419cd257203d739e5eb226f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718026 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#681897}
-
Maksim Ivanov authored
1. Wire up the Chrome OS Lock Screen UI code with the challenge-response authentication (a.k.a. smart card login) bits from the browser process. 2. Add a UI control into the Lock Screen for starting the challenge-response authentication. (The UI control is temporarily an unstyled button, but will be replaced with the real UI in follow-ups.) Bug: 964069 Test: enroll a Chromebook, configure device policies to force-install smart card middleware onto Login Screen, log in using a SAML account that uses smart card authentication, lock the Chromebook, check that "Unlock with smart card" appears, click it, check that the user session gets unlocked Change-Id: Icf0ccc80b6778d318c115f79072fdd6595a034b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720640Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#681896}
-
Caroline Rising authored
Make MenuRunner use the MenuModelAdapter. Bug: 943702 Change-Id: Ia05b47e207b4d1d1cc73b046a7fee54432ae84b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724577Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#681895}
-
Kevin Babbitt authored
With UI Automation enabled, the top-level node for the Chrome window would show most properties as empty. This was happening because our fragment root was mapping values from an empty AXNodeData. UI Automation has a built-in provider for HWNDs. In our implementation, fragment roots do not contain any useful accessibility information beyond what the built-in provider would expose, so we simply return VT_EMPTY for most properties, so that we don't override values returned by the built-in provider. The exceptions are IsControlElement and IsContentElement. We implement these properties to exclude the legacy HWND from the control and content views, because we don't want screen readers to stop on the legacy HWND and announce "Chrome Legacy Window." Other HWNDs are allowed in the control and content views so that, for example, an assistive technology can manipulate the window using WindowPattern. R=iapres@microsoft.com Bug: 928811 Change-Id: If606f399c386109adc3bd56bf081b2e5c2362070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716010Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#681894}
-
Mei Liang authored
https://crrev.com/c/1680953 sets root id of a tab when that tab is being added to the filter. However, when resetFilterState() is called after setRootId(), the root id of that tab can be overridden if its parent tab is still around. This CL fixes the issue above and adds unit tests. Change-Id: If8332053a4255f01a4f618f1b0367f9fd6729a8f Bug: 987153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717558 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#681893}
-
Rayan Kanso authored
According to the spec, the contact picker can only be brought up once per browsing context until the operation is complete. Subsequent navigator.contacts.select calls should throw an InvalidState DOMException. https://wicg.github.io/contact-api/spec/#dom-contactsmanager-select Bug: 985702 Change-Id: I838534bd84877079eec7740c773d18567acac3a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724514 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#681892}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/96ea8c00e70c..425d6aaa4ce2 git log 96ea8c00e70c..425d6aaa4ce2 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 sprang@webrtc.org Add RtpPacketPacer interface for pacer control Created with: gclient setdep -r src/third_party/webrtc@425d6aaa4ce2 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I9257b712cea988838e9a2335793e729ccfc2de6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723576Reviewed-by:
-
Gabriel Charette authored
Blocks https://chromium-review.googlesource.com/c/chromium/src/+/1689339/21 R=altimin@chromium.org Bug: 984057 Change-Id: I48f93eced8391c2b8f85bd4b27ccd3891f6b429d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724689 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#681890}
-
Stephen Nusko authored
This prevents the producer from being set when a new trace gets started. Also add a TODO to refactor the data source so this can't be forgotten. Bug: 987887 Change-Id: I1a6d5efad9d635a4325c19dcce1a5cae9925bf0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722938 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#681889}
-
Vaclav Brozek authored
CSVPassword represents a credential stored in one CSV line. For parsing the CSV line, CSVPassword needs to understand the meaning of columns, which it does through a ColumnMap -- a map from column indices to column types. Currently, CSVPassword stores its own copy of the map. This map is the same for all lines in a single CSV blob. Sharing this single map among all CSVPassword instances avoids many copies of the map. Therefore this CL changes CSVPassword to keep a reference to the map. Bug: 934326 Change-Id: Id52e3db26fa1fd804f987103bf62e295102f2ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698401 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#681888}
-
David Bokan authored
These tests were DCHECKing because the TouchlessActivity generates cursor changes on state changes like becoming hidden. This causes us to notify the renderer about the change. However, the fallback cursor mode enabled flag is set from AppHooks which don't get initialized in browser tests. This means the renderer is receiving these notifications with the flag turned off. This CL filters the notifications at the browser level. Ideally we would avoid sending them in the first place but querying the state of the feature flag is difficult because the sending code lives in ui/ while Java FeatureList code is implemented only in chrome/browser/. Bug: 987353 Change-Id: Ida01168493200ee47f598a567f1d1afdcaf0a262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721229 Commit-Queue: David Bokan <bokan@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#681887}
-
David Black authored
Setting user agent via InternalOptions is deprecated in LibAssistant 1.42s. Prior to upreving LibAssistant we need to set user agent via internal config. A follow up CL will remove the code which sets user agent via InternalOptions and we will uprev that change in tandem with upreving the 1.42s changes to avoid breaking the public build. Bug: b:138583234 Change-Id: I110a7f16ea53f38eaeac7f7065e628f7eec1ffc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724829Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#681886}
-
Jacob DeWitt authored
This hasn't been an issue since Gamepads on the navigator array should always have index >= 0. However, WebXR Gamepads that are not on the navigator array must have an index of -1. Bug: 950202 Change-Id: Ia3abd606ae491cbdc738fc7a0c8fbde9eaf57e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721057Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
-
Dominic Battre authored
If many independent strings are appended to the LogBuffer, this used to emit a separate text node for each string to the DOM. With this CL, the strings are coalesced in the browser process, which results in less data being sent to the WebUI and less text nodes being kept in memory. Bug: 928595 Change-Id: I09e9673a06f0cae426f7e0b25ad27b98c0f43272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722791 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
-
Christopher Grant authored
This change flips on the switch for putting the VR UI's native code in the feature DFM. In doing so, it enables a partitioned Chrome library for Android, which changes how libchrome.so (and libmonochrome.so) are generated. The link stage now generates libchrome__combined.so, a special library that uses lld linker capabilities to put feature code into separate sections. The main and feature libraries are then extracted in a follow-on step, producing discrete libchrome.so and feature libs. As a result, this change has the potential to break scripts that (for example) induce re-linking of libraries by deleting libchrome.so. Bug: 874564 Change-Id: I708e990b3aa6b1abe71b28a67add51662c268276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663486Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#681883}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/96827b125f3a..b05ca08cfab8 git log 96827b125f3a..b05ca08cfab8 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 senorblanco@chromium.org Update Dawn backend to ToT Skia. 2019-07-29 benjaminwagner@google.com Omit test that sometimes causes Chromebook to die 2019-07-29 egdaniel@google.com Fix valgrind crash in TransferFrom test. Created with: gclient setdep -r src/third_party/skia@b05ca08cfab8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I6b87b9694ea7ca9bd41c183c49e4fe8d2e13178c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724572Reviewed-by:
-
Guido Urdaneta authored
This CL: 1. Moves content::MediaStreamDeviceObserver to blink/renderer/modules/mediastream, including the header. This type implements a Mojo interface, so its header cannot be on blink/public. 2. To allow existing content clients to interact with MediaStreamDeviceObserver, a thin wrapper called WebMediaStreamDeviceObserver was added to blink/public (header) and blink/renderer (implementation). 3. Blink-specific bindings for MediaStream typemaps are now generated. 4. The MediaStream typemap is updated to account for dependent media types. 5. MediaStreamDeviceObserver is updated to register with the frame's mojo interface registry instead of using its own registry. This allowed breaking the dependency on RenderFrameObserver, which was used to detect requests for interfaces made to the frame. Bug: 704136 Change-Id: Iaa191c0e990910dd2fcb512d4655abc91d56a2e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718379Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#681881}
-
Dominic Battre authored
This CL makes the logging of table rows easier to comprehend and shaves off a few characters of each line logging table rows. Bug: 928595 Change-Id: I35db6d7ddd06d184a6c14fc28847888ee3390b58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722951 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: If18912933ab3e45af55ab052654c5a3d6389e298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700911Reviewed-by:
-
Becca Hughes authored
Add a color type to MediaImageBitmap. The default color type (N32) is platform specific and is an alias for either RGBA_8888 or BGRA_8888. When deserializing we will convert all images to the platform default. The color type tells us the original color type of the image which may be different if it came from ARC or Chrome. ARC only supports RGBA_8888 and images from ARC will fallback to RGBA_8888 which is the default value. BUG=987814 Change-Id: I9fed118c85e29a24c232bc3adc52cdf64988bd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717168 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#681878}
-
Chase Phillips authored
As part of this change, also remove IDBCallbacks.SuccessValue and IDBCallbacks.SuccessCursor which are no longer used. Bug: 717812 Change-Id: I5bb3b5d77ba7248b2286dc579d8d25805b72cd5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626660 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
-
kylechar authored
Both helper functions just wait for hit test data now so rename them appropriately. Bug: 810128 Change-Id: Ia04933ee35a526a11766a5c1fbd9f75b43985bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721239Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#681876}
-
Stepan Khapugin authored
Disable Site Info on the NTP to avoid user's confusion. Bug: 977056 Change-Id: Ia47495580d8ec7a3eee3347e22f91d7c63647026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719009 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#681875}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8d269bac7c4a..b51a6f0c4638 git log 8d269bac7c4a..b51a6f0c4638 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 bclayton@google.com Revert "Temporarily disable warnings-as-errors" 2019-07-29 bclayton@google.com Merge changes I10d66439,I6bd62e7b,Iec85e0df,If16c5d11,If803398e, ... 2019-07-29 bclayton@google.com LLVMReactor: Build fixes for REACTOR_EMIT_DEBUG_INFO Created with: gclient setdep -r src/third_party/swiftshader@b51a6f0c4638 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I50bb0719e5bab6d777966140d28669868ac2faa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724574Reviewed-by:
-
Natalie Chouinard authored
This reverts commit 5a08e77e. Reason for revert: Suspected cause of Android build failures with: Class "org/chromium/net/impl/JavaUrlRequestUtils$CheckedRunnable" not found on any classpath. Used by class "org/chromium/net/impl/JavaUrlRequest$10" Original change's description: > Move Java classes needed by all Java Cronet implementations to utils. > > To minimize code duplication, code that can be shared between the > JavaUrlRequest and the FakeUrlRequest should be moved to a new shared > file: JavaUrlRequestUtils. > > Context:https://chromium-review.googlesource.com/c/chromium/src/+/1703325 > > Bug: 669707 > Change-Id: Id0dda127694090504f26b083bf4c561ee902cef4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721771 > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Commit-Queue: Benjamin Kirchman <kirchman@google.com> > Cr-Commit-Position: refs/heads/master@{#681835} TBR=pauljensen@chromium.org,caraitto@chromium.org,kirchman@google.com Change-Id: Iee84334296aa6508ee2696a9f97385a00e12924e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 669707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724576Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#681873}
-
Vladimir Levin authored
This patch adds more early outs that were missed during paint. That is we still paint the self element, but also need to skip child paint, particularly inline only children which was not done previously. R=chrishtr@chromium.org Change-Id: Ib2442ab361447940c1c0e1b4c54b1ee8273d9563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720795 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#681872}
-
