- 21 Dec, 2018 40 commits
-
-
Sidney San Martín authored
The window server enforces rounded corners on a window when its content view has a layer. BridgedNativeWidgetImpl::CreateContentView() replaces a window's content view, so it needs to make sure that the new content view has a layer. BrowserFrameMac::InitNativeWidget() already did this for browser windows, but moving it covers more cases, like app shims. Bug: 917001 Change-Id: Iab5b459ba6950ee00327c3938ab897ee0a48bb0d Reviewed-on: https://chromium-review.googlesource.com/c/1388807Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#618656}
-
Xiaocheng Hu authored
The layout test asserts mapping between logical and visual caret positions, which is changed by the bidi caret affinity flag. This patch adds new behavior under the flag to make the test pass there. Bug: 917165 Change-Id: I0494f08b7af5ddce7eeff0aff43348d84efa1931 Reviewed-on: https://chromium-review.googlesource.com/c/1388815 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#618655}
-
Kurt Horimoto authored
BVC previously used self.visible, which is set in |-viewWillAppear:|, as a trigger to start broadcasting its UI state. However, cancelled UIViewController transitions can sometimes result in |-viewWillAppear:| being called without its accompanying |-viewDidAppear:| and |-viewWillDisappear:| selectors. As a result, BVC continued to broadcast its UI even if its views were removed from the hierarchy and deallocated, thus resulting in the crash from crbug.com/915123. This CL updates BVC.broadcasting to be gated on BVC.viewVisible, which is instead set in |-viewDidAppear:| after a successful presentation. In addition to mitigating the crash, this also is an improvement semantically, as BVC should not be broadcasting its state until it is fully presented. If objects care about BVC's UI during a transition, it should be using the transition coordinator. Currently, the BVC's broadcasted values are only used by FullscreenController, and no scrolling is occurring in between |-viewWillAppear:| and |-viewDidAppear:|, meaning that this CL has no functional change. Bug: 915123, 916581 Change-Id: Ifc0245e6e93f823c733be41ea471954912e7b577 Reviewed-on: https://chromium-review.googlesource.com/c/1388713Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#618654}
-
danakj authored
SetBackgroundOpaque() is a concept that applies only to WebViews, not to WebWidgets. It is set by ChromeOS UI pieces, which each have their own WebView/Page. It is also set by webview tag, which has its own WebView contained inside another outer one. So we move the SetBackgroundOpaque() methods and IPCs from RenderWidget to RenderView. In the renderer, the WebWidget::BackgroundColor() is not used except internally, so remove it from the WebWidget API. The WebFrameWidgetImpl is only used for child frames, and during Initialize(), it will set its background color to be overridden to transparent, preventing any future colors to matter, unless the override was cleared. But since clearing overrides only happens by IPC to the main frame widget (now to the RenderView) that clearing can't happen. So remove all background color code from WebFrameWidgetImpl, and just set the compositor's background color to transparent during startup. Android WebView and ChromeCast code was also setting the base background color via the WebFrameWidget, but both are in code that corresponds to a view, not a widget, so pass the value to WebViewImpl directly instead by adding SetBaseBackgroundColor to the WebView API. Then we remove all background color APIs from WebFrameWidget as well. R=ajwong@chromium.org, avi@chromium.org, dcheng@chromium.org TBR=dcheng Change-Id: I3d83064d13836f286f8ebc89118b990bbdbb80d3 Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/1382861 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#618653}
-
Michael Ludwig authored
Bug: 915735 Change-Id: I2637ff932cbe090e41cf71d4ad0b02eff141f2b2 Reviewed-on: https://chromium-review.googlesource.com/c/1388547Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#618652}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/02cb969e13c7..f4dd96c6b81b git log 02cb969e13c7..f4dd96c6b81b --date=short --no-merges --format='%ad %ae %s' 2018-12-21 reed@google.com Reland "Revert "serialize fonts instead of paints"" 2018-12-21 ethannicholas@google.com fixed SPIR-V global initializer ordering 2018-12-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 92b16ea26290..d50521fd068e (1 commits) 2018-12-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader bb0a7f09a91e..809d01138e0a (1 commits) 2018-12-21 halcanary@google.com SkPDF: unify SkPDFOffsetMap and SkPDFObjectSerializer 2018-12-21 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-12-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e0b5a4b0416b..bb0a7f09a91e (2 commits) 2018-12-21 caryclark@skia.org fix pathops bug 8380 2018-12-21 reed@google.com Revert "share constructors/enum in both variants of SkReadBuffer" 2018-12-21 michaelludwig@google.com Implement per-edge aa as extra vertices instead of interpolated edge distances 2018-12-21 herb@google.com Move from a generalized appendGlyph to two specialized methods. 2018-12-21 reed@google.com use font for measuring/paths 2018-12-21 reed@google.com share constructors/enum in both variants of SkReadBuffer 2018-12-21 reed@google.com Revert "Revert "serialize fonts instead of paints"" 2018-12-21 reed@google.com Revert "serialize fonts instead of paints" 2018-12-21 bsalomon@google.com Move GrResourceKey.h to include/private. 2018-12-21 robertphillips@google.com Short term fix for SkClipStack unique key issue 2018-12-21 reed@google.com serialize fonts instead of paints 2018-12-21 halcanary@google.com SkPDF: debugging flag SK_PDF_BASE85_BINARY applies to JPEG Created with: gclient setdep -r src/third_party/skia@f4dd96c6b81b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:914833,chromium:b/120946388 TBR=halcanary@chromium.org Change-Id: Ide4efdfb6f874d1794316745926fc26559852da6 Reviewed-on: https://chromium-review.googlesource.com/c/1388995Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618651}
-
Lei Zhang authored
BUG=882085 Change-Id: I07243c03a28a45f3d368269668b54eadc0b50e98 Reviewed-on: https://chromium-review.googlesource.com/c/1362223Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#618650}
-
Piotr Bialecki authored
Now that we can use ARCore SDK 1.5, we can start using 3D version of hit test and remove previously used one. Since we no longer use ArFrame_hitTest, it is getting removed from arcore_shim.cc. Bug: 835948, 854823 Change-Id: Ibf8e953135b04925dbebd384e16f8f08ad52a869 Reviewed-on: https://chromium-review.googlesource.com/c/1357723Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#618649}
-
Krishna Govind authored
TBR=abdulsyed@chromium.org Change-Id: Ic98ef04581797a2cac82487adb5e0af9f547b4f2 Reviewed-on: https://chromium-review.googlesource.com/c/1388748Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#618648}
-
Dave Tapuska authored
Use size_t for hash value which matches the function definition requirement and the type. BUG=879657 Change-Id: I486cfd3adde1880c03b1657d9cb803c5d50f16f4 Reviewed-on: https://chromium-review.googlesource.com/c/1387827Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#618647}
-
Evan Stade authored
- Allow testing DesktopNativeWidgetAura on Chrome OS by doing necessary Mus setup. - To accommodate Chrome OS, tests must specify that they will be testing desktop widgets before SetUp (for tests that inherit from ViewsTestBase). On Chrome OS, these are the tests that provide Mus coverage. - Command line flags are ignored, so views_unittests will perform the same tests with and without --enable-features=SingleProcessMash - Enable some test suites on Chrome OS, such as desktop_native_widget_aura_unittest.cc, and some individual tests. Bug: 911784 Change-Id: Ic3acd21770f07fb8298a172dc556b3fa036d6791 Reviewed-on: https://chromium-review.googlesource.com/c/1378666 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#618646}
-
Pavel Feldman authored
Bug: 917477 Change-Id: Ibf881ccc9577a6aa380c07b613042395567fb39d Reviewed-on: https://chromium-review.googlesource.com/c/1388751Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#618645}
-
Xiaohan Wang authored
Adds two test cases covering: - Encrytped() - OnWaiting(WaitingReason::kNoDecryptionKey) Bug: 858286 Test: New tests added. Change-Id: I344aa85795c2a77d34d7cb5e41500902bb8bdbb1 Reviewed-on: https://chromium-review.googlesource.com/c/1388753Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#618644}
-
Eric Karl authored
This change adds a RequestForceSendMetadata method to LayerTreeView/Host/Impl, which allows us to force sending RFM with the next frame. This ensures that CursorAnchorInfoController receives updates on any frame with a text change. Bug: 912309 Change-Id: I21185b57c2937c94d306d4ceed239d2f49bc824d Reviewed-on: https://chromium-review.googlesource.com/c/1383533Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#618643}
-
Doug Turner authored
Running blink_tool.py rebaseline-cl output per instructions. TBR=foolip Bug: 916899 Change-Id: I77b10bcf57a20c511bed0509acbe596ebb1d7526 Reviewed-on: https://chromium-review.googlesource.com/c/1388652Reviewed-by:
Doug Turner <dougt@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#618642}
-
Vlad Tsyrklevich authored
I was hitting an unexpected bug where one of the GWP-ASan tests was failing on OS X but not Windows. I realized this was because the test never ran on Windows in the component build (due to how the allocator shim works on Windows) but was failing when I ported it to OS X. Save a note to save future devs some debugging time. Change-Id: I107113eab8e808d8837f5e56b15ca53006436c95 Reviewed-on: https://chromium-review.googlesource.com/c/1379182Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#618641}
-
Doug Turner authored
Bug: 897312 Change-Id: Ia5f70cc255b7e2a537e89a20fffa8b93f1305b68 Reviewed-on: https://chromium-review.googlesource.com/c/1388214 Commit-Queue: Doug Turner <dougt@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#618640}
-
Danyao Wang authored
This is the first step to change Chrome's PaymentRequest implementation to match the proposed spec change: https://lists.w3.org/Archives/Public/public-payments-wg/2018Nov/0018.html This CL aligns mojom::PaymentRequest API with the new spec proposal by renaming CanMakePayment to HasEnrolledInstrument and leaving a stub for CanMakePayment. Blink's canMakePayemnt is switched to using HasEnrolledInstrument so there is no behavior change visible to the web platform. There will be a few subsequent changes: - Implement new CanMakePayment behavior - Expose hasEnrolledInstrument and new canMakePayment in Blink behind a runtime flag. Bug: 915907 Change-Id: I137110de0077fb4e243b883d27c82109f8d2afbb Reviewed-on: https://chromium-review.googlesource.com/c/1383445Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#618639}
-
Xiaocheng Hu authored
The layout test asserts visual caret positions, which is changed by the bidi caret affinity flag. This patch adds new behavior under the flag to make the test pass there. Bug: 917165 Change-Id: I6bcbff036d8239c66e62c19bbc1170b725b11d89 Reviewed-on: https://chromium-review.googlesource.com/c/1387478 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Kenneth Russell authored
Some of these configurations have relatively few machines, and the default Swarming shard timeout of 1 hour is too short. The following machines are affected: Mac FYI Experimental Release (Intel) Mac FYI Experimental Retina Release (AMD) Win10 FYI Exp Release (Intel HD 630) Win10 FYI Exp Release (NVIDIA) Win7 ANGLE Tryserver (AMD) Win7 FYI Debug (AMD) Win7 FYI Release (AMD) Win7 FYI Release (NVIDIA) Win7 FYI dEQP Release (AMD) Win7 FYI x64 Release (NVIDIA) Bug: 917183 No-Try: True Change-Id: I8e602e9713a378c9da43e1410644d214d00c7d24 Reviewed-on: https://chromium-review.googlesource.com/c/1388166 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#618637}
-
Xiaocheng Hu authored
The layout tests assert mapping between logical and visual caret positions, which is changed by the bidi caret affinity flag. This patch adds new behavior under the flag to make the tests pass there. Bug: 917165 Change-Id: I273d1194e7f011deccb05d33d2a3304b03bfd90a Reviewed-on: https://chromium-review.googlesource.com/c/1388810 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
Remove virtual/bidi-caret-affinity/editing/selection/modify_extend/extend_by_character.html from "true failures" The web test is already flaky on Mac and Win even without the bidi caret affinity flag. Hence, this patch moves it from the "true failures" section to the "already failing" section. Bug: 917165 Change-Id: I01f06cbf13009504af6d3a908564b3e5a96f2d79 Reviewed-on: https://chromium-review.googlesource.com/c/1388719 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Tom Sepez authored
Currently, this path is avoided via an |if (false) { ... }| in the code above it when SaturateFastAsmOp is not supported for a given pair of types. However, instantiating the template for 64-bit sources will give a truncation warning for arm (at the line where we do |int32_t src = value;|) under strict compiler modes (even though the path can't be reached). Avoid the error by conditionalizing its instatiation for cases where it is actually usable. BUG=879657 Change-Id: I40bee5a4686b89c1d35c7b93804b215afe25dd68 Reviewed-on: https://chromium-review.googlesource.com/c/1387958Reviewed-by:Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#618634}
-
Dave Tapuska authored
Use a range iterator to avoid 64 bit truncation with size_t. BUG=879657 Change-Id: Ic776d3aae635b47d24a0d548c0a260840e8c5656 Reviewed-on: https://chromium-review.googlesource.com/c/1387652Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#618633}
-
Lei Zhang authored
Remove comment about shrink_to_fit() being missing in some STL deque implementations, along with manual shrink_to_fit() equivalent. Change-Id: I0b4443731755a98ea63b44830db3261577af6bfc Reviewed-on: https://chromium-review.googlesource.com/c/1388394 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#618632}
-
Vikas Soni authored
Move android_image_reader_utils to a new source set. This helps to reduce unwanted dependencies in the places which needs to use android_image_reader_utils* files. Bug: 891060 Change-Id: I2557ca40d5ab011de800d842cf2ab18dcb238381 Reviewed-on: https://chromium-review.googlesource.com/c/1388389 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#618631}
-
Marina Ciocea authored
Bug: 899789 Change-Id: I28f538888f1bd041ffa31cc650d19245228e044f Reviewed-on: https://chromium-review.googlesource.com/c/1388436 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#618630}
-
Xiaocheng Hu authored
The layout test asserts visual caret positions, which is changed by the bidi caret affinity flag. This patch adds new behavior under the flag to make the test pass there. Bug: 917165 Change-Id: I801d11574658ab9efcd18d284187db08d669c1e3 Reviewed-on: https://chromium-review.googlesource.com/c/1388024 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I23a6b1f69dd61795ade84151a2beb65eea005a3e Reviewed-on: https://chromium-review.googlesource.com/c/1388955Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/92b16ea26290..d50521fd068e git log 92b16ea26290..d50521fd068e --date=short --no-merges --format='%ad %ae %s' 2018-12-21 ianelliott@google.com Only enable VK_KHR_maintenance1 when available. Created with: gclient setdep -r src/third_party/angle@d50521fd068e The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I9e4409ed196b8ad44ac816fc154ac7aee72d959a Reviewed-on: https://chromium-review.googlesource.com/c/1388628Reviewed-by:
-
Sebastien Lalancette authored
Some context from base/values.h: base::Value is currently in the process of being refactored. Design doc: https://docs.google.com/document/d/1uDLu5uTRlCWePxQUEHc8yNQdEoE1BDISYdpggWEABnw Previously (which is how most code that currently exists is written), Value used derived types to implement the individual data types, and base::Value was just a base class to refer to them. This required everything be heap allocated. OLD WAY: std::unique_ptr<base::Value> GetFoo() { std::unique_ptr<DictionaryValue> dict; dict->SetString("mykey", foo); return dict; } The new design makes base::Value a variant type that holds everything in a union. It is now recommended to pass by value with std::move rather than use heap allocated values. The DictionaryValue and ListValue subclasses exist only as a compatibility shim that we're in the process of removing. NEW WAY: base::Value GetFoo() { base::Value dict(base::Value::Type::DICTIONARY); dict.SetKey("mykey", base::Value(foo)); return dict; } Bug: 877281 Change-Id: Ia16fb806a3de551dc427ed6e9a8600f0f8e5acb7 Reviewed-on: https://chromium-review.googlesource.com/c/1384608Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#618626}
-
Ben Pastene authored
And disable the one failing test. Bug: 917086 Change-Id: I3abc37faef3b2c5fb182075b48737c3e512d8e72 Reviewed-on: https://chromium-review.googlesource.com/c/1387548Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#618625}
-
manuk authored
This CL wires in the current_page and from_omnibox_focus autocomplete input fields to the UI. Adding these fields allows the debug page to work with the zero suggest provider, but they also affect other providers, such as search provider. Adds 'zero suggest' checkbox which controls the from_omnibox_focus autocomplete input field. This field enables the zero suggest and clipboard providers while also disabling the bookmarks, built in, history, history url, keyword, search, and shortcut providers. Also adds a 'current url' input box which controls the current_url autocomplete input field. This field is essential for the zero suggest provider but may also affect the search and clipboard providers. To avoid redundant typing, when 'zero suggest' is checked, the 'current url' input becomes disabled and auto-populated with the contents of the 'omnibox text' input. Lastly, changed the accesskey of 'current page context' from 'u' to 'o' in order to use the accesskey 'u' for the 'current url' input. Bug: 891303 Change-Id: I51f4815d9f837245b6b6fab03dcec5d009783b6b Reviewed-on: https://chromium-review.googlesource.com/c/1378246Reviewed-by:
Orin Jaworski <orinj@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#618624}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/817c32843267..ae3945f4d219 git log 817c32843267..ae3945f4d219 --date=short --no-merges --format='%ad %ae %s' 2018-12-21 thestig@chromium.org Make FPDFPage_SetRotation() take effect immediately. 2018-12-21 thestig@chromium.org Add more resource params to CPDF_PageObjectHolder ctor. Created with: gclient setdep -r src/third_party/pdfium@ae3945f4d219 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I95f3622cadb24348a75ff9c87a20dca5f15b7bf4 Reviewed-on: https://chromium-review.googlesource.com/c/1387851Reviewed-by:
-
manuk authored
Bug: 891303 Change-Id: If58334d48debc7c5e23717f4cd13f2a77bb2c286 Reviewed-on: https://chromium-review.googlesource.com/c/1388705Reviewed-by:
-
Lei Zhang authored
The renderer is working in a nested message loop. Since the outer loop is deliberately stuck, the hung-renderer detection mechanism triggers. PrintViewManager already knows which RenderProcessHost is starting/finishing window.print(). Call RenderProcessHost::SetBlocked() as needed. BUG=903296 Change-Id: Icf61083f840155f00878080959744e84f3e5cb62 Reviewed-on: https://chromium-review.googlesource.com/c/1368582Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ccf97ef6bafc..89e50af847ea git log ccf97ef6bafc..89e50af847ea --date=short --no-merges --format='%ad %ae %s' 2018-12-21 allenwebb@google.com cros_install_debug_syms: Temporary hack to fix crbug.com/917405. Created with: gclient setdep -r src/third_party/chromite@89e50af847ea The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Iba04322da44392a3b113659f420f8f990e9af52e Reviewed-on: https://chromium-review.googlesource.com/c/1388670Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, Chrome would crash after reading from disk a binary dictionary file with Affix structure offsets very close to maximum integer values. Adding up the Affix structure offset and size was overflowing the integer into a value that is smaller than the size of the input, thus bypassing Chrome's validity checks for the binary dictionary file. This patch checks that the Affix structure offset is less than the binary size, that adding the Affix structure offset to its size would not cause an integer overflow, and that adding the Affix group offset to the size of an integer would not cause an integer overflow either. After this patch, Chrome invalidates a binary dictionary file with invalid structure offsets. Bug: 916873 Change-Id: I9aa7139a1dd610e23234339cb24d948b5f95b522 Reviewed-on: https://chromium-review.googlesource.com/c/1388150Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#618619}
-
Eric Karl authored
This UMA will allow us to understand hether we actually have long- duration (but not hung) tear-downs. Bug: 899705 Change-Id: If993447678821b8ec9a714448c94ba405d27fc74 Reviewed-on: https://chromium-review.googlesource.com/c/1388002Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#618618}
-
Zhenyao Mo authored
We believe they still use OpenGL 3.3 and will be blacklisted anyway. By explicitly blacklisting these GPUs instead of GL version will put them to SwiftShader sooner, and hopefully this resolved the GPU process hang during loading SwiftShader libs inside gpu_init.cc BUG=902247 TEST=crash reports R=kbr@chromium.org,ccameron@chromium.org Change-Id: Ia93343c265052d83b8d5dae688ddf0b6f4eba5cd Reviewed-on: https://chromium-review.googlesource.com/c/1385113Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#618617}
-
