- 14 Oct, 2020 40 commits
-
-
chrome://sync-internalsPaula Vidas authored
This CL replaces all occurrences of "about:sync" with "chrome://sync-internals", so the URL is the same everywhere. Bug: 1137739 Change-Id: I461582da8aa9d809ffe72715d09456fc7818652c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470077Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Paula Vidas <paulavidas@google.com> Cr-Commit-Position: refs/heads/master@{#817002}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I2999de2b9ad8c3039a0338fbb9e0d5e4655beabe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470457Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#817001}
-
Alice Wang authored
This CL adds type information for the generic test rule in AccountPickerBottomSheetTest. Bug: 1120258 Change-Id: Ia672bf78b84a1aadfe3056fc030135310de99a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470564Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#817000}
-
Rune Lillesveen authored
Wrap CSSValue and the corresponding TreeScope from MatchResult in a ScopedCSSValue passing it to StyleBuilder. Currently use a nullptr TreeScope in the cases where we don't have one to look up tree-scoped references. We do not support such names/ references in UA stylesheets. We currently support @keyframes in user stylesheets, but collect them from the StyleEngine regardless of which scope the animation-name came from. It would be possible to have a TreeScope for user sheets (and even UA sheets) and use ScopedStyleResolvers instead of extra structures in StyleEngine. For now pass null TreeScopes for UA and user style values. Bug: 336876 Change-Id: I4c5af46bde94b9fda41d676982d9e9386b652538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455609Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#816999}
-
Richard Knoll authored
If an origin is capturing a screen we want to allow it to show notifications. The site knows that the user is actively presenting the screen and should mute notifications itself if it wants to. Otherwise it should be able to show notifications. Bug: 1131375 Change-Id: I455c9c8822cb6f3bda31d7f1b590f0843a336ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462076Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#816998}
-
Alexander Surkov authored
TimingUpdate::MovePolicy shadows ShadowStyle enum fields. Bug: 294205 Change-Id: Idf16e65353f4a21b2dea1ba4e74c8bb5d07c7744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468505 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#816997}
-
Rayan Kanso authored
I'm not really sure why this is happening as we only store strings in the dictionary. However there have been a few crash reports. Bug: 1136031 Change-Id: I105bc90e4897ac01d3db5550382ac8b38e566347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470633Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#816996}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/45f024b330f8..ea954d80edb7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC swapnilgupta@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: swapnilgupta@google.com Change-Id: Icdbf90578cde927fe1be75593bd22ec4db5df3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470743Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816995}
-
Roman Sorokin authored
Bug: None Change-Id: I40f1f737e254d7c78d9324bb95ef42b71482f374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453258Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Greg Levin <glevin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#816994}
-
Jan Wilken Dörrie authored
This change adds a fieldtrial testing config for the PasswordsWeaknessCheck feature. R=chromium-metrics-reviews@google.com Bug: 1119752 Change-Id: I214a56f8a6a986d824046eaab9ce36dc29234c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469561 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#816993}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/46129e98d33a..52c138e36e87 2020-10-14 olka@webrtc.org Revert "Improve screen sharing with PipeWire on Wayland" 2020-10-14 perkj@webrtc.org Add RtpVideoSender::SendVideoLayersAllocation 2020-10-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6aee44cd..51f6153d (816729:816858) 2020-10-14 roman.gaiu@ringcentral.com Improve checks for "child" windows of selected capture targets. 2020-10-13 sprang@webrtc.org Makes WebRTC-Pacer-SmallFirstProbePacket default enabled. 2020-10-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 144d0d0b..6aee44cd (816585:816729) 2020-10-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7c745202..144d0d0b (816476:816585) 2020-10-13 nisse@webrtc.org Add back AndroidVideoBuffer::CropAndScale 2020-10-13 ilnik@webrtc.org Reland "Remove deprecated video_frame_i420 build target" 2020-10-13 eshr@google.com Use VideoFrameBuffer::Scale in encoder wrappers 2020-10-13 grulja@gmail.com Improve screen sharing with PipeWire on Wayland If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1132299,chromium:682122 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If89f53e660b0529ca86cfd42e99c473f95c5ca3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470742Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816992}
-
Stephen McGruer authored
This rolls up to c808aa3d15a42648d8b25a838024813990959e37 Bug: None Change-Id: I46407cabbe41fff8dc0b8aef766fb66baf59f9a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468897 Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#816991}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0150a791fcb7..19ee1c94588a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I157d00dfeb60912d7b098aace3948e81223fe302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470776Reviewed-by:
-
Maksim Moskvitin authored
The end goal is to remove verifier completely, but it's still used in many tests. First step, to isolate further work and prevent new usages of verifier is to change default behavior and force tests to specify UseVerifier(). Changes: 1. DisableVerifier() removed. 2. UseVerifier() now virtual and returns false by default. 3. Many tests that didn't use verifier before for expectations, now don't initialize verifier. 4. TwoClientsBookmarksSyncTest.Sanity don't use verifier anymore. 5. Code modernization (=default, -DISALLOW_COPY_AND_ASSIGN). Bug: 1033848 Change-Id: I417b9a24f610a15241f5b4a1237bad79df56cf34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467996Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#816989}
-
Felipe Andrade authored
Adds a feature flag for the new Kerberos section in ChromeOS settings. When disabled, Kerberos settings will stay under People Section, keeping current behaviour. Bug: 983041 Change-Id: Id750ae851c6a3ef522c0afdf6d29a91014f63cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462255 Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#816988}
-
Benoit Lize authored
SpinningFutex is essentially an OS-provided lock with spinning in userspace before sleeping. This is implemented on Linux using futex(), which is not available on Windows. However, SRWLocks have the TryAcquireSRWLockExclusive() function which is functionally equivalent to the userspace CAS for futex()s. This CL: - Renames SpinningFutex to SpinningMutex - Extracts the common code - Extends it to Windows by using SRWLock instead of futex() The fast path is likely a bit slower than on Linux, as there is still an external function call, but it should be pretty comparable. Bug: 1061437 Change-Id: I7d71055865568738a569d7252f38a7a6773795e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467916 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#816987}
-
harrisonsean authored
The update check for iOS is much faster than the desktop equivalent, so we will always delay the update check if supported or not in order to momentarily show the loading wheel before getting a new status. Bug: 1078782 Change-Id: Ieb2f42c24365dc3c650a7e769eb1fc851a06ab5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461269 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#816986}
-
Luke Zielinski authored
This only includes the vr bindings to support webxr tests. More will be added in follow-up CLs. For now just getting agreement on the structure. Bug: 1033611 Change-Id: I2afc01fb75984ce0826b566b37648c26336d62de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459006Reviewed-by:
-
Ian Kilpatrick authored
There should be no behaviour change. Change-Id: Ic935f758ffff558a4d746518cf413dde275e04e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468540Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#816984}
-
sandromaggi authored
These tests ran stably on a real Nexus5. This CL adds new waiting conditions before clicking the confirm button for the CVC dialog. This CL adds a new restriction to tapping HTML elements by restricting the area to the visible webpage, not obstructed by the BottomSheet. Bug: 1136166 Change-Id: I84753527d8260a6bc4bc38e4f6fc0b1df1e921ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470660 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#816983}
-
Rohit Agarwal authored
Bug: 1137747 Change-Id: I70d9f659a72524c8f8e3549414569bdb44ba008b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467858 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#816982}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/166d4461bb51..8d314a40a3aa 2020-10-14 aerotwist@chromium.org TypeScriptify media MainView 2020-10-14 aerotwist@chromium.org TypeScriptify sdk.js 2020-10-14 szuend@chromium.org [ts] Type-check network/NetworkLogViewColumns.js with TypeScript 2020-10-14 sigurds@chromium.org Update protocol If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iee30dfd006e920df2637ba7a191374a6ce9868e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470739Reviewed-by:
-
Illia Klimov authored
SMSReceiverOutcome was renamed to WebOTPServiceOutcome in https://chromium-review.googlesource.com/c/chromium/src/+/2424707 Fix the enum name in UKM.xml TBR=rkaplow@chromium.org,swapnilgupta@google.com Bug: 1138180 Change-Id: Ieb6e540eed2a88c8421c2e1f93abef51ee69d6d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470565Reviewed-by:
Illia Klimov <elklm@google.com> Reviewed-by:
Swapnil Gupta <swapnilgupta@google.com> Commit-Queue: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#816980}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/39b5e771cd8e..c7dae0ea7ee7 2020-10-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from a6b7134c to 20d60a85 (447 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I6c5849ca0aa86bba22b09d2c18f59965fc1fb915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470738Reviewed-by:
-
Maksim Moskvitin authored
PassphraseRequiredReason::REASON_ENCRYPTION isn't used anymore (it was used for setting implicit passphrase first time). This CL removes PassphraseRequiredReason enum, together with code related to REASON_ENCRYPTION (such as RequiredUserAction::kPassphraseRequiredForEncryption). Changes is JsSyncEncryptionHandler is safe, because it's used only to populate events to sync_internals page and where |details| value simply serialized to string (see sync_log.js). Bug: 970213 Change-Id: I755ea11ff555dd537cd2919aa37e80dc1c17612c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470080 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Reda Tawfik authored
Bug: 1104132 Change-Id: I482cceb98f881be84f2e980dd3d9e62a7415978d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465852 Commit-Queue: Reda Tawfik <redatawfik@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#816977}
-
Peter Marshall authored
Re-baseline tests for updated devtools behavior. Feature CL: http://crrev.com/c/2443620 Disable CL: http://crrev.com/c/2454721 Bug: 1127827 Change-Id: I3190ae5b0b5498fae3f9a278f5c3d886ec08b647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454085Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#816976}
-
Monica Basta authored
This CL adds tests for all the profile picker main view functionalities. More tests will be added to cover the profile card menu. Bug: 1063856 Change-Id: I89c4e9dfadb38a9635fee10543a10bbedfd06eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461231 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#816975}
-
Robbie Gibson authored
Now that there is an exernal and internal implementation of this method, it can be used to determine availability of text zoom. Bug: 1061119 Change-Id: Iac6a5ce396f6a153d42502da17f06661ce2052cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465848Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#816974}
-
Clemens Arbesser authored
The main reason for the UaFs was UiController synchronously destroying itself, which lead to UaFs in cases where code was executed after the call to DestroySelf returned. As a workaround, DestroySelf is now asynchronous and merely schedules a call to Shutdown, which will let the current callstack complete and unwind gracefully. Bug: 1134192 Change-Id: I4c42a608b08af0a9243ede2e8ca21808889abc2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461378Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#816973}
-
Peter Beverloo authored
Stop recording the number of sender IDs used for creating a GCM registration, as the data is no longer being used. Extend the LoadStatus one as it reflects our ability to load an on-disk database, failure within which would interfere with the entire system. Bug: 1117108, 1088805 Change-Id: I6f4a90adb637df47b0b7d24f442fd5eb5021bc99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461317 Auto-Submit: Peter Beverloo <peter@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#816972}
-
Anastasiia N authored
Bug: 1135980 Change-Id: Icc9ddf49dc0aa4f077a6312931f6aedd69823bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453990 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#816971}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1602633476-7a781163f6d564d4e8e8516c828c3e90624a360b.profdata to chrome-win64-master-1602644333-c5d02301d4a6428e8ec60219d0e73c3fd904c678.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8c9687c6171928b53177fcfbd4e82220b32985e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469285Reviewed-by:
-
Tanmoy Mollik authored
If the user has only signed in without giving sync consent then toggling "Allow Chrome sign in" off should not show the sign out dialog. Instead it will sign the user out directly without deleting data saved on device Bug: 1136075 Change-Id: I7d8a75a9c2474759f67fbb0018fa68ad3fa16163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460729Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0150a791fcb7..19ee1c94588a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If53e584e8370695297e3d1168de90d6ec6215111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470498Reviewed-by:
-
Polina Bondarenko authored
This is a reland of 725f9a2e Original change's description: > arc: auto-login to MGS with blocked UI screen > > Add an auto-login to Managed Guest Session / public account to start ARC > snapshot creation. > Block auto-login flow even if specified by policy. > Wait for ArcDataSnapshotdManager successfully generates a key pair and > auto-login to MGS once it is ready. > > BUG=b:161221001 > TEST=components_unittests > TEST=browser_tests > > Change-Id: Ib7895f49f9295b3959226cde3e304c9c78614e93 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440872 > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Commit-Queue: Polina Bondarenko <pbond@chromium.org> > Auto-Submit: Polina Bondarenko <pbond@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816186} Bug: b:161221001 Change-Id: I8d435cd9a29e813a473defd695fc25676ec85ae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468118 Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#816967}
-
Renato Silva authored
A minor glitch in the UI was causing both user pods to be active at the same time showing authentication methods. This glitch was only present in real devices since OnSetTpmLockedState is only called when a TPM is available. This CL also fixes a very old bug in the public session pod. When not active, the public session pod shows an arrow that appears when the user hovers on it. When the pod is active, the same arrow is always visible. Clicking on the arrow without the pod being active violates an invariant in the code that requires the pod to be active. With this fix, the public session pod will first simulate a user tap on itself, if it isn't the current active pod. The first issue, coupled with the preexisting public session pod issue made logging in into a managed guest session impossible when there is a user pod in addition to the public session pod. Fixed: 1131704, 1127156, 1127161, 1133926 Change-Id: I0bd0d5d29b0b99c267f2f30283a598955379666a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443291 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#816966}
-
Renato Silva authored
Pressing 'Return' on the PIN input field will now trigger a SmartLock unlock attempt just like on the password field. Added tests to cover this case. Fixed: 1129458 Change-Id: I0ac5860f89f9723a7670aa390fc27e946aac8de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437387 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#816965}
-
Jamie Madill authored
The new oncall is sourced from the internal go/rotations tool. Bug: chromium:1138008 Bug: angleproject:4730 Change-Id: Ide6b3119f86ec65e1298fd64597e9a91fced03c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469716Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#816964}
-
Mohamed Adel authored
- Moves setIcon from notification_builder_base to notification_builder_mac as it is not shared between the builders. - Adds setImagePath in unnotification_builder_mac to set the path of the image that will be attached to the notification Bug: 1136930 Change-Id: I9f5acfac73fc6dd738c4326d865059506e332ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463828 Commit-Queue: Mohamed Adel <adelm@google.com> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#816963}
-
