- 13 Jul, 2020 40 commits
-
-
Becca Hughes authored
BUG=1024351 Change-Id: Id01595e63f5f776a226087741ef602ba30b80328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295224 Auto-Submit: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#787954}
-
David Bertoni authored
This test was disabled for flakiness many moons ago. It passed 3000 iterations on the bots without difficulty, delta the necessary changes to account for the new "pendingUrl" field. Bug: 59198 Change-Id: I8978048083fdb1b01be68b053021b8e67ac188a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265352Reviewed-by:
Archana Simha <archanasimha@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#787953}
-
chrome://media-appZain Afzal authored
Google3 side of this change: ccl/320140322. When we do a save copy operation we have to prompt the user to choose a destination but for security reasons our call to saveFilePicker has to be tied to a user gesture and needs to be triggered within a certain timeframe of the user gesture being registered. Our current flow for save copy is to do an encode of the current image then trigger the file picker,sometimes this takes so long that our time window expires and our call to saveFilePicker gets blocked by security policies. This cl adds a new delegate function called "requestSaveFile" which does just the step of calling showFilePicker to create a file handler allowing us to do the actual file write later on once the encode is done. As such SaveCopy now takes in a file token which the client gets from requestSaveFile. Additionally since this CL will land before the google3 side has been rolled in saveCopy will still respect the old interface, calling requestSaveFile implicitly if a token is not provided. Change-Id: I0d06803cae819163c54f38bbcd170d064c78c316 bug: b/160658703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291810 Commit-Queue: Zain Afzal <zafzal@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#787952}
-
Alex Gough authored
COM says this should be an unsigned 32 bit integer internally. https://docs.microsoft.com/en-us/windows/win32/api/unknwn/nf-unknwn-iunknown-addref Bug: 1101547 Change-Id: Ib9f2dac4b243aee86332a94bf6f2c5b9aca3040d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295689 Auto-Submit: Alex Gough <ajgo@chromium.org> Commit-Queue: Yohei Yukawa <yukawa@chromium.org> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#787951}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4f438a5a6738..cd0af6456eb1 2020-07-13 capn@google.com Remove dead ASTC code for GLES 2020-07-13 capn@google.com Rename command classes to match API calls 2020-07-13 srisser@google.com Add decoder for BC6h If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I1c75ef5ae8d800fc58f43cbb31ec03681957c0ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295883Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787950}
-
Anastasia Helfinstein authored
Occasionally when Switch Access is trying to recover from an error condition, the action menu remains open when the user is not navigating through it. Close the action menu when recovering from invalid states. AX-Relnotes: n/a. Bug: None. Change-Id: Iced9e6a480e85b02d10a75704b71200bfa6271d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292994Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#787949}
-
Maxime Charland authored
The new TableViewIllustratedItem and Cell duo will be used in the Recent Tabs view. The new cell will contain an image, a title label, a subtitle label, a button and a SignInPromoView, of which only the buttons will be visible. All elements of this cell are optional. The following states are going to be used in the Recent Tabs view: - image+title+subtitle - image+title+subtitle+button - image+title+subtitle+signinpromo(cold state) - image+title+subtitle+signinpromo(warm state) (Googlers only links) Design Doc for Chrome Empties: https://docs.google.com/document/d/1JM2sKT4oghkol51U7_3xv9sfaB26C89CCGa2uwYBgsI/edit?usp=sharing Mocks of the new Chrome Empties look: https://docs.google.com/presentation/d/1x1lSTOSQ1zkJu87SoigiUhX2f9oHACglR22yYg-lSHo/edit?usp=sharing Bug: 1098328 Change-Id: Ic47c867aebbb33d8d49cb729f0512e403c9c84c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288483 Commit-Queue: Maxime Charland <mcharland@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#787948}
-
Thomas Guilbert authored
This CL adds Web Platform Tests that check the behavior of the preservesPitch flag. The tests rely on WebAudio to analyze the frequency of an Audio element, as the playback rate changes. Firefox's mozPreservePitch does not affect MediaElementAudioSourceNode, which means that these tests won't work on Firefox. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1648277 Change-Id: Ic25d474f96e32eb8d8584188d879a018daa6ae73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259375 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#787947}
-
Garrett Beaty authored
A branched version of a CI builder is necessary only if the builder appears on the main console or if it is a mirror for a try builder that is on the CQ. There are a handful of builders that do not meet this criteria. Bug: 1105179 Change-Id: I08365854bd1cea4570ad99f91d0e90e8ae42609a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295812 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#787946}
-
Marzena Dell'Aquila authored
This change will allow loading IDR_PORT_CONNECTOR_JS from a resource pak instead of opening and reading the JS file directly. Bug: b/160811610 Test: CQ Change-Id: I02cbfbc41cc983043658bbe57ac15033f0d457e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290530Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Marzena Dell'Aquila <mdellaquila@google.com> Cr-Commit-Position: refs/heads/master@{#787945}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/92ffd40efaac..e5c184751160 2020-07-13 nguyenmh@google.com Multi-frames serialization + comparision for capture replay test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I5f9e54238e91dea5f90f104868f49e1e23899aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296179Reviewed-by:
-
David Trainor authored
Disable flaky test. Tbr: changwan@chromium.org Bug: 1105220 Change-Id: Ib87d611e9e348e806dcbb47755ae6ba373f2b8d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295935Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Auto-Submit: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#787943}
-
K. Moon authored
Adds a new function, SkBitmapFromPPImageData(), that converts from pp::ImageData to SkBitmap. SkBitmap can then be used to replace any instances of pp::ImageData. Note that the underlying pixel memory is shared, so these conversions are relatively cheap. As an example, converts chrome_pdf::draw_utils::DrawShadow() to accept an SkBitmap& instead of a pp::ImageData*. Bug: 1099020 Change-Id: Ib5ed84fe45f2a4ac882ba6b367a02398ba256c5f Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270813Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Mike Klein <mtklein@google.com> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#787942}
-
Haiyang Pan authored
Bug: 1105214, 10815149 Change-Id: If9eecfd741567fa6e9fad7b2e154e9fa8c124e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295793 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#787941}
-
Kenichi Ishibashi authored
Before this CL, tests in ServiceWorkerMainResourceLoaderTest implicitly depended on a specific ordering of task executions which isn't always guaranteed. This CL removes such an implicit dependency by waiting for the main script response is received before calling ServiceWorkerMainResourceLoader::StartRequest(). Details: ServiceWorkerVersion::SetMainScriptResponse() should be called before ServiceWorkerMainResourceLoader::StartResponse(). This is satisfied just because ServiceWorkerInstalledScriptsSender::OnStarted() is called synchronously in ServiceWorkerInstalledScriptReader::OnReadResponseHeadComplete(). However, there is no guarantee that OnStarted() is called synchronously, especially after ServiceWorkerInstalledScriptReader starts using mojo version of reader. This was found in WIP CL [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2282552/1/content/browser/service_worker/service_worker_installed_script_reader.cc#183 Bug: 1055677 Change-Id: I16fca7c04d3b867ca00e405db7329d2834c2d598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291790Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#787940}
-
siashah authored
Screenshot: https://screenshot.googleplex.com/1ynJ0MFDGbt Bug: 1082013 Change-Id: I3689de3ada2e772aff94376748e57097fe0359f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291530Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#787939}
-
Yuwei Huang authored
This CL introduces a ProtobufHttpClient class for sending REST/protobuf requests over HTTP using Chromium net libraries. This is the first step of moving away from gRPC. Bug: 1103416 Change-Id: Ic9b32e166c27f1098fcf24da831e1bdf836fa95a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293422 Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#787938}
-
Peng Huang authored
Vulkan and GL inerop doesn't works with bgra8888 texture format for some GL implementations, so use pixels copy for it. Bug: 1104509,angleproject:4831 Change-Id: I60d0bbeb3354abc57473087a1b9e32ca2933e0ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291981 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#787937}
-
Dominic Mazzoni authored
The previous URL-keyed metrics landed in http://crrev.com/c/2237912 fired too often. Update them to keep track of the slowest serialization and only fire once every several minutes, or when navigating to a new page. Some refactoring was needed to make this testable; hopefully that should benefit any future tests we write too. Bug: 1092944 Change-Id: Icf86f0234b79f15ce27d7ccb9d45841676c1a7d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277338Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#787936}
-
Yaron Friedman authored
KitKat is no longer supported. BUG=1073043 Change-Id: I16b0b5179818bd3b32f70cf80f9b6455f4daa50e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296002 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#787935}
-
Steven Bennetts authored
This is a part of a greater effort to cleanup callbacks in chromeos/network. GetDeviceProperties causes complications in Get*Properties calls, which will be cleaned up in followup CLs. Bug: 1007660 Change-Id: I4039ea1a672890b6c24cb6057394377c302c6200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291233 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#787934}
-
Andre Le authored
BUG=1093614 Change-Id: Icd7494c741d250da64e304d12f10da52f32852bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296059Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/master@{#787933}
-
Peter Kasting authored
Both of these locations are approximating a higher-precision number with a lower one for human consumption, so rounding produces the least error. (In practice the difference won't be noticed; the more desirable effect of this change is to use explicit safe float->int conversions.) Bug: 1104532 Change-Id: I2173e7848778c99f9eb629870bc0c5383d5cb263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293630 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#787932}
-
Khushal Sagar authored
Change-Id: Iaf3937b6646ff042471caaa3f52a8971b4bd52ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288362 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#787931}
-
Roger Tawa authored
Bug: 1088131 Change-Id: I89a6daac836f7576c6819e3927cf3ab9652c920d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288811 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#787930}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/38ef299a..d120885f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8f73f6fb67af49f4040cefd2b169833b694b59e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295712Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787929}
-
Peter Kasting authored
By inlining GetDownload() into ShowDownloadById() and making OnGetDownloadDoneForOfflineItem() a member, the code becomes clearer and more direct (mostly by converting the bound ShowDownload() callback into direct calls). Bug: none Change-Id: I92e424ee658e00aff5fbb243d4b6b574fc6285f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296001 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#787928}
-
Pete Williamson authored
This is attempting to mock out the profile that we get from getLastUsedRegularProfile. Change-Id: Icf3cbd3931c146e8ebeb6a46e0033101112789ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290759 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#787927}
-
Xinghui Lu authored
Currently desktop and Android share the same study. They are both enabled to 1% Stable. Going forward, we will roll out desktop study to 100% Stable in M83 and roll out Android study to 100% Stable in M85. Server-side CL: http://cl/320706459 See https://crbug.com/1040670#c122 for more context. Bug: 1070324 Change-Id: I8fc93d5fe470678c669ffb8d7544a78ba84bc328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295924Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#787926}
-
Lijin Shen authored
Reland https://crrev.com/c/2272131 1. Enable only on P+ 2. Use new Critical Helper API Bug: 1088202 Change-Id: I9d07ceee98d138a6468c6280266a14aea8e20b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290961Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
Sammie Quon authored
It wasn't matching the regular fling to minimize normal window animation, even if the maximized windows was sized to look like a normal window (happens during drag). That was because on complete it restores the window, which triggers another animation, and then minimizes, so the resulting animation is something in between. For drag to unmaximize, the restore bounds animation can actually be disabled as the window bounds are already set to the restore location. Test: manual Change-Id: Idca3efeb1b9392805430342770c9263e04a3d2cb Fixed: 1084355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289356Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#787924}
-
Livvie Lin authored
Bug: 1092654 Change-Id: I4119710b44204dcf48a7a0d5910a43e44bf702ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285917 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#787923}
-
Chris Thompson authored
This bumps the expiration for various security-related histograms and adds second owners where needed. Bug: 1102466, 1102467, 1102468, 1102469, 1102470, 1102471, 1102472, 1104987, 1104988, 1104989, 1104990, 1105022, 1105023, 1105024, 1105025, 1105027, 1105028, 1105029, 1105030, 1105031, 1105032, 1105033, 1105034, 1105035, 1105036, 1105037, 1105038, 1105039, 1105040, 1105041, 1105042, 1105043, 1105044, 105045, 1105046, 1105047, 1105048, 1105049, 1105050, 1105051, 1105052, 1105053, 1105054, 1105055, 1105056, 1105057, 1105058, 1105059, 1105060, 1105061, 1105062, 1104991 Change-Id: I3da4cc28654621d499f02dcb83664eb2d3b2f53c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295807 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Auto-Submit: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#787922}
-
Peter Kotwicz authored
This CL: - Fixes strict mode detection on Android P - Imports list of "unfixable strict mode violations" from other google apps - Avoids reporting strict mode violation (uploading stack trace) or preforming penalty if the strict mode violation is whitelisted. BUG=1038384 Change-Id: Ib125d08104225af0e1dafb1be1afc5ef8d8e128e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258578Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#787921}
-
David Black authored
Previously, AssistantSuggestions only supported remote icons. Now, they will optionally support local icons as well. These will be specified by use of resource links (a similar concept to deep links which instead of pointing to some action to be performed point to some resource to be used). This will be utilized in a follow up CL to provide local icons to Assistant onboarding suggestions. Bug: b:157510970 Change-Id: I488865044c1485b1e431cd843f2d0ea0ad146be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289074Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#787920}
-
Lei Zhang authored
Switch to the 1-parameter version, or switch to base::DeletePathRecursively(). Bug: 1009837 Change-Id: Iab8258f3d8b29c308758096299a8e6702230484a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293282Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#787919}
-
Peng Huang authored
When context is lost, the SharedContextState::gr_context_ could be nullptr, we should check it is not nullptr, before using it to avoid crashes. Bug: 1103726 Change-Id: I50a84d3cd2ffff05095ce682f80ddf31d5304d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295683Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#787918}
-
Sebastien Marchand authored
There's some concern that the cost of the Segment heap doesn't justify its cost (see crbug.com/1102281). This CL disable it by default and put this feature behind a GN flag to let us keep experimenting with it. Bug: 1102281, 1014701 Change-Id: I411b61efc6927ba5d9f1496990a44c44ab8ea6a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292824Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#787917}
-
karandeepb authored
One of the files in the GCS webstore bucket doesn't seem to be updating. Bump the server version as a short term fix. Skipping presubmits since they seem to be timing out. BUG=1105212 TBR=rdevlin.cronin@chromium.org No-Presubmit: true Change-Id: I26250426eb7ff47c553591c5475f066b15f4157e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295933Reviewed-by:
-
David Trainor authored
Disabling flay test. Tbr: ckitagawa@chromium.org Bug: 1105164 Change-Id: I837fb6a37360eff3aa78fe10b94b146c46d2bf76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295923Reviewed-by:
-
