- 10 Jul, 2018 40 commits
-
-
Raymond Toy authored
If the AudioParam is constant over a rendering quantum, we're allowed to set the parameter value array to have a length one to indicate that the audio param is constant. Make this so if the audio param is truly constant. Bug: 814796 Test: audioworklet-audioparam-size.https.html Change-Id: Ib6e5805dbeb418ad3c202c9c79adc87bc93dad4a Reviewed-on: https://chromium-review.googlesource.com/1097977Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#573985}
-
Kenichi Ishibashi authored
It seems we don't use this flag. Change-Id: If9dbdb7d9a733f4a8698b06b7afae7aef439873a Reviewed-on: https://chromium-review.googlesource.com/1131017Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#573984}
-
Hiroki Nakagawa authored
This is a reland CL for: https://chromium-review.googlesource.com/c/chromium/src/+/1124209 The original CL was reverted because of the random crashes in the WebGL 2.0 conformance tests: https://chromium-review.googlesource.com/c/chromium/src/+/1127420 This was caused by an Oilpan's GC bug happening only on the debug build. That was already fixed by keishi@chromium.org: https://chromium-review.googlesource.com/c/chromium/src/+/1131154 Therefore, this CL changes nothing from the original CL. ===== Original CL description ===== <Overview> This CL introduces FetchSettingsClientObject in BaseFetchContext and replaces some functions of BaseFetchContext with that. This makes the scope of responsibilities of BaseFetchContext clearer. Also, this is a preparation for separating ResourceFetcher for main resource request and subresource requests for workers and worklets. The main resource request needs a snapshot of the fetch client settings object of the parent execution context, while the subresource requests need up-to-date values of the fetch client settings object of the worker / worklet execution context. This change enables a subsequent CL easily to inject the fetch client settings object from externals of WorkerFetchContext. <Technical details> - This CL introduces FetchSettingsClientObject interface and FetchSettingsClientObjectImpl. Also, this makes FetchSettingsClientObjectSnapshot inherit the interface so that BaseFetchContext doesn't have to take care of an actual implementation. - FrameFetchContext has the FrozenState concept that is used for keeping states even after the frame is detached. Similarly, this CL makes FrameFetchContext creates a new instance of FetchSettingsClientObjectSnapshot on frame detach, and replace the current |fetch_client_settings_object_| with that. Bug: 845285 Change-Id: I74b43722002bb07197d718d3f266bbe384636b66 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR: kouhei@chromium.org, kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1127202Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#573983}
-
Dirk Pranke authored
TBR: oysteine@chromium.org, primiano@chromium.org Bug: 862414 Change-Id: I931b169a0ee99acefb1ce666e8bb5457731b5555 Reviewed-on: https://chromium-review.googlesource.com/1132429Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#573982}
-
Parastoo Geranmayeh authored
UKM is logged for the fields whose types are rationalized because they shared the same server type predictions. For now it includes two field types: Address lines, and state/country. Tests Added. New UKM collection review: go/1121206-ukm-review. Bug: 857601, 850552 Change-Id: Ibcddf4ea3fb0a72cd59df7d1434b97c5e7c32f44 Reviewed-on: https://chromium-review.googlesource.com/1121206Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#573981}
-
Robert Flack authored
When starting transitions we check if they are interpolable, and don't start a TransitionInterpolation if not. When retargeting, the start keyframe from the previously active interpolation may cause an incompatible interpolation so we must take this into account. Bug: 853698 Change-Id: Iaeeba35c64c659818c68d30e8f999e704b382926 Reviewed-on: https://chromium-review.googlesource.com/1126519 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#573980}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3b1c86144cc8..1230eb961dc4 git log 3b1c86144cc8..1230eb961dc4 --date=short --no-merges --format='%ad %ae %s' 2018-07-10 simonhatch@chromium.org Dashboard - Use msBestFitFormat for dashboard stats. 2018-07-10 eakuefner@chromium.org [TBMv2] Make timeInMsAutoFormat available in Python Created with: gclient setdep -r src/third_party/catapult@1230eb961dc4 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:861837,chromium:861837 TBR=sullivan@chromium.org Change-Id: Id236f43859df3e36ff64c6501bf1b3b539a4ba9c Reviewed-on: https://chromium-review.googlesource.com/1131963Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573979}
-
Tessa Nijssen authored
The following changes were made: - Menu coordinates stored in gfx::Rect object - Menu's y-coordinate initialization moved - Store monitor bounds as variable - Store initial location bounds as variable - Move menu height check - Re-order menu position conditionals - Replace monitor width check with IsEmpty() check - Moved offset check - Added unit tests Menu Coordinates Stored in gfx::Rect Object Within the function CalculateMenuBounds(), menu coordinates were stored as a gfx::Size (which stores a width and a height) and two integers, x and y. At the end of the function, the Size object and the integers representing the coordinates were used to create a gfx::Rect object which was then returned. The gfx::Rect class consists of two integers, x and y, and a gfx::Size object. By creating a gfx::Rect early in CalculateMenuBounds(), all the coordinate information is encapsulated in the Rect object. This also abstracts away some of the arithmetic done to calculate the menu's right and bottom coordinates. Then, at the end of the method, the created Rect object can be returned. Y-Coordinate Initialization Moved The menu's y-coordinate is now moved to be under the comment that explains the initialization of the menu's coordinates. Store Monitor Bounds as Variable I created a variable that's a const reference to state_.monitor_bounds. This way, the shorter, simpler variable can be used which is more readable. Store Initial Location Bounds as Variable I created a variable that's a const reference to state_.initial_bounds. This way, the shorter, simpler variable can be used which is more readable. Move Menu Height Check The check that the menu height is not greater than the monitor height was moved to be next to the check that the menu width is not greater than the monitor width. These checks are very similar in nature and therefore it makes sense for them to be near each other. Re-Order Menu Position Conditionals The previous ordering of menu position conditionals was hard to read and understand. The new ordering moves the cases where the menu position has been previously set to the front so that they're easier to find. It then re-organizes some of the conditionals in the case that the menu position is still best fit so that they check for positives instead of negatives (i.e. check that the menu fits in a certain position rather than checking if it doesn't). Repetitive checks were also removed (e.g. menu doesn't fit below initial bounds and its position is above initial bounds and menu position is above initial bounds). Replace Monitor Width Check with IsEmpty() Check The method Rect::IsEmpty() includes the case in which the width is 0. Rather than checking if the monitor's width is 0, check that the monitor Rect is not IsEmpty() which is cleaner and easier to read. The check was also moved to its own conditional which returns early if the monitor is empty. This way, the check doesn't have to be repeatedly made in other conditionals. Moved Offsetting Offsetting was moved to the end of the function so that it's not undone and redone repeatedly. Added Unit Tests Unit tests were added that test that the menu bounds are calculated properly depending on where the menu best fits, what the menu anchor is, and whether the menu is a context menu and should be offset. Change-Id: I34c29dbf22fe2956761c99f8e1702ff43816413c Reviewed-on: https://chromium-review.googlesource.com/1114073 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#573978}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eb4bb04d120f..bc787be40f68 Created with: gclient setdep -r src-internal@bc787be40f68 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If4d866ed8c8e5c17b79d5ba5c012945302da8bbb Reviewed-on: https://chromium-review.googlesource.com/1132354Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573977}
-
Brandon Jones authored
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5dfaa8182e83eb20c459ab9363ee7de41a627a43 Bug: 696637 Reviewed-on: https://chromium-review.googlesource.com/1125341 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#573976}
-
Daniel Rubery authored
For safe browsing protection (e.g. PhishGuard, download protection) that uses referrer chain, we'd like to skip navigations initiated by reload. This is because these navigations are marked as BROWSER_INITIATED, they would break current attribution logic. Bug: 862290 Change-Id: Ia7d43df441ce47ceb09c8458942ad933ccc9a2ad Reviewed-on: https://chromium-review.googlesource.com/1132077 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#573975}
-
Peter Kvitek authored
This reverts commit 401e3a6e. Reason for revert: breaks VirtualTimeErrorLoop browser tests. Original change's description: > Added headless protocol browser test harness flags > > Change-Id: I4d0a224d4a256a96a6b8fdfa798f0b9a14c02ee1 > Reviewed-on: https://chromium-review.googlesource.com/1129472 > Commit-Queue: Peter Kvitek <kvitekp@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#573388} TBR=pfeldman@chromium.org,kvitekp@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ia4562c937961e24debdad2dfbb57386cf3c8cea2 Reviewed-on: https://chromium-review.googlesource.com/1132304Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#573974}
-
Danyao Wang authored
This fixes NavigationTestCase/testRestoreHistoryToNTPAndNavigateForward. Bug: 807428 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib49522b7740fae867e2b7e3c6e03abf3aefb50e6 Reviewed-on: https://chromium-review.googlesource.com/1127466 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#573973}
-
Mustafa Emre Acer authored
Bug: 843361 Change-Id: I824aa69e64565bb6f05204df3b2ad65a86889c91 Reviewed-on: https://chromium-review.googlesource.com/1132454 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Jialiu Lin authored
Previously, we don't distinguish verdicts that are triggered by saved password or sync password. As a result, if use have a saved password that is a prefix of a sync password, then PhishGuard will only trigger saved password ping. This CL changes the way we cache verdicts. Previously for password reuse verdicts, there're two levels of keys: (1) primary URL, (2) cache expression. Now, we add another key: (1) primary URL, (2) reused password type, (3)cache expression. In addition, minor refactoring due to : (a) base::DictionaryValue::Iterator, DictionaryValue::GetInteger(...) DictionaryValue::GetString(...) are deprecated. (b) GetDictionaryWithoutPathExpansion(...) is deprecated. (c) base::Bind(...) is deprecated. Bug: 770725 Change-Id: Icb3ed840a4bbe54683e0fa0aff79ab2cd6bb5bfb Reviewed-on: https://chromium-review.googlesource.com/1119251 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#573971}
-
Wez authored
Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I7b1f08d8ef5a04c6d4dce6f2a63a678d074ab3a0 Reviewed-on: https://chromium-review.googlesource.com/1132377Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#573970}
-
Emily Stark authored
These keys have been blacklisted in https://chromium-review.googlesource.com/1103224. We can use dynamic interstitials to trigger the special MITM interstitial for them. This interstitial can be seen at chrome://interstitials/mitm-software-ssl. It informs the user that there is misconfigured software and that they should contact their network administrator. Bug: 844069 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I21a5257f48e88347792e9e5c9ed0d45cfa7f4ee2 Reviewed-on: https://chromium-review.googlesource.com/1132379Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#573969}
-
dpapad authored
In Polymer 2 the following pattern throws a runtime error: <template is="dom-if" no-search$="[[foo]]>...</template> This CL introduces a backward compatible solution such that the no-search mechanism works both in Polymer 1 and Polymer 2. Some cleanups can be done once migration has completed. Bug: 859689 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I0732a8c6cd48b94ad3d81cc017fe59688fe3df13 Reviewed-on: https://chromium-review.googlesource.com/1123711Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#573968}
-
Kent Tamura authored
runtime_call_stats.h is used in 3,700+ compilation units, and this CL reduces its pre-processed size by 1.09MB. - In order to remove trace_event.h include, move some part of RuntimeCallStatsScopedTracer constructor to AddBeginTraceEventIfEnabled(). This change didn't regress Speedometer locally. - trace_event.h provided base::size() indirectly for many files. We need to update them to include base/stl_util.h. Bug: 242216 Change-Id: I283bde2c0f2f78b95ce88885054cea1086579d74 Reviewed-on: https://chromium-review.googlesource.com/1130962 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#573967}
-
Albert J. Wong authored
This will facilitate further detangling of RenderWidget and RenderView. In the current CL, there is an odd setup where a RenderView still inherits from RenderWidget meaning that a single object (the RenderView) ends up being assigned 2 different routing ids. Because prior work already separated out messages into the appropriates classes, and because RenderView::OnMessageReceived() delegates up to RenderWidget::OnMessageReceived(), this chimera object ends up working okay. Next step is to break the inheritance relationship. Bug: 545684, 841065 Change-Id: I6548b4f82f8a040bbc1cb6b309ab1e9383004d9c Reviewed-on: https://chromium-review.googlesource.com/1028846 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#573966}
-
Tobias Sargeant authored
In the case where two calls are made to the singleton getter and interleave due to ensureChromiumStartedLocked having released mLock, both calls should not create the singleton instance. Bug: 817444 Change-Id: Ief28fa8818b7d50f921ffd13c0dca0c59ac1fd6b Reviewed-on: https://chromium-review.googlesource.com/1125841Reviewed-by:
-
Farah Charab authored
1) Modify the entry points in the fuzzer from only posting a task to any other action (defined in the SequenceManagerTestDescription proto). 2) Add support to log actions executed (for unit tests). Bug: 852076 Change-Id: I90641da29e346730057444827438368dcd1d9f56 Reviewed-on: https://chromium-review.googlesource.com/1129226 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#573964}
-
Jennifer Apacible authored
MacOS and other OS have slightly different formats, where: - MacOS: "Picture in Picture" - Non-MacOS: "Picture in picture" - Instructional (non-menu/titles): "...picture-in-picture mode..." Bug: 859670 Change-Id: I424bb618b9b337bf944d2f082522b9539d25e43c Reviewed-on: https://chromium-review.googlesource.com/1123321 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#573963}
-
bsheedy authored
Regular roll to most recent production APKs. TBR=bajones@chromium.org Change-Id: Idad64a50473bc6438e06dd46f9d59aa28802c4ad Reviewed-on: https://chromium-review.googlesource.com/1132393Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#573962}
-
Jun Choi authored
Complete dialog view for very first step of WebAuthN request UI flow. That is, when a user first invokes WebAuthN Make/Get request, show a initial welcome screen and then show "activate usb device view" once the user clicks the continue button. Bug: 849323 Change-Id: I89c961c6278a68082675fe5a024a51bd9d1d15bb Reviewed-on: https://chromium-review.googlesource.com/1130829Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#573961}
-
Wez authored
- Migrate Chromium call-sites to appropriate libzx containers. - Mojo / IPC callers still often need to use generic zx::handle. - Redefine ScopedZxHandle as a typedef to zx::handle, for Crashpad code to build against. Bug: 852541 Change-Id: Idc317a91e718c680de7d01e53c92e83b5950b146 Reviewed-on: https://chromium-review.googlesource.com/1130540Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#573960}
-
Joshua Peraza authored
Bug: crashpad:30 Change-Id: I1a85d5d3428b5f801c570dc1add043f0697ba0e3 Reviewed-on: https://chromium-review.googlesource.com/1119383 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#573959}
-
Danyao Wang authored
With WKBasedNavigationManager, repost dialog is presented before isLoading becomes false. Bug: 807428 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I82eedbeeeb31a3f2d3ae120c040c0a7eff4b0ab1 Reviewed-on: https://chromium-review.googlesource.com/1127450Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b77822b4442d..c69c4410be7d git log b77822b4442d..c69c4410be7d --date=short --no-merges --format='%ad %ae %s' 2018-07-10 brianosman@google.com Remove matrixconvolution GM hacks for linear blending 2018-07-10 mtklein@google.com update (non-sprite) image shader color management 2018-07-10 mtklein@google.com transform paint color to dst colorspace 2018-07-10 bungeman@google.com Make SkTypefacePlayback use smart pointers. 2018-07-10 brianosman@google.com Merge "All" and "Default" path renderer options in viewer 2018-07-10 herb@google.com Add field to directly pass glyphs when using glyph encoding 2018-07-10 fmalita@chromium.org [skottie] Fix polystar points distribution 2018-07-10 fmalita@chromium.org [skottie] Misc cleanup 2018-07-10 borenet@google.com [infra] Determine Android device location based on bot ID 2018-07-10 fmalita@chromium.org [skottie] Log (unsupported) layer effects 2018-07-10 fmalita@chromium.org [skottie] Fix spurious gradient error messages 2018-07-10 borenet@google.com [infra] Remove Nexus 5x from CQ Created with: gclient setdep -r src/third_party/skia@c69c4410be7d The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I120170c20d5efc9969b68e28c3d6848d9462ae9d Reviewed-on: https://chromium-review.googlesource.com/1131961Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573957}
-
Ken Rockot authored
This replaces use of ReadOnlyBuffer with a new mojom Message type specific to //ipc. This type maps to another new C++ MessageView type which in turn wraps a BigBufferView. This allows us to transparently fall back onto shared memory for large IPC messages without increasing the number of copies during send or receive in any (small- or large-message) cases. In order to avoid introducing more mojo-base targets, this also removes the remaining [Native] structs from mojo_base mojom (LOGFONT and FileInfo) and replaces them with real mojom structures + StructTraits, thus allowing //ipc to depend on mojo/public/*/base in its entirety. Also fixes random missing public_deps entries for a chrome/services/file_util typemap, because it decided to start breaking all of my local builds. :3 Bug: 784069 Change-Id: I359b964ffc1fe44ffd6aa704405ea63156f4fbc9 Reviewed-on: https://chromium-review.googlesource.com/1131685 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
-
Sebastien Marchand authored
Follow up on https://chromium-review.googlesource.com/c/chromium/src/+/1131556 Bug: 773382 Change-Id: Idddda163085d58aa4a351ae528544dd9968daaf1 Reviewed-on: https://chromium-review.googlesource.com/1132107Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#573955}
-
May Lippert authored
Add a new policy that will allow administrators to specify a schedule for slowly updating their fleet. BUG=chromium:858621 Change-Id: Ie21e538660a2d8d71c263a0f04397720820ce12a Reviewed-on: https://chromium-review.googlesource.com/1119162 Commit-Queue: May Lippert <maybelle@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#573954}
-
Kyle Milka authored
Correct alignment of elements in the dialog title bar. Make the selected check mark larger. Split the check icon and the colored background into two elements to make this work properly. Add a background color to image tiles. This will be seen before the images fully load. Bug: 852462 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I3ae7d925acddc5968f45d31c06cb7d358156b819 Reviewed-on: https://chromium-review.googlesource.com/1132090Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#573953}
-
Evangelos Foutras authored
ffmpeg_features is the target used in src/media/ffmpeg and elsewhere. The target appears to have been accidentally renamed in: https://chromium-review.googlesource.com/935296 Fixes the following dependency errors when configured with system ffmpeg: ERROR Unresolved dependencies. //chrome/services/media_gallery_util:lib needs //third_party/ffmpeg:ffmpeg_features //chrome/services/media_gallery_util/public/cpp:browser_tests needs //third_party/ffmpeg:ffmpeg_features //chrome/services/media_gallery_util/public/cpp:cpp needs //third_party/ffmpeg:ffmpeg_features //media/base:base needs //third_party/ffmpeg:ffmpeg_features //media/ffmpeg:ffmpeg needs //third_party/ffmpeg:ffmpeg_features //media/filters:filters needs //third_party/ffmpeg:ffmpeg_features Change-Id: I2218c1dfb20de87958eeb8c23b18eebbea384c36 Reviewed-on: https://chromium-review.googlesource.com/1131941 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#573952}
-
Ryan Hansberry authored
This log is not informative, and spams dozens of lines in the logs. R=khorimoto@chromium.org Bug: 824568, 752273 Change-Id: Ied74c5747977719a63a698fb687f0415d8a5bc3b Reviewed-on: https://chromium-review.googlesource.com/1102980Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#573951}
-
Scott Violet authored
HostContextFactoryPrivate shouldn't have reconnection logic, instead DefaultGpuHost should. TEST=none BUG=855613 TBR=sadrul@chromium.org Change-Id: I23b927997b0be98268123acd4cc09015cf12bc8e Reviewed-on: https://chromium-review.googlesource.com/1132295Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#573950}
-
Mike Frysinger authored
On macOS, Command-Enter is available via the ⌘ key, but Windows & Linux can trigger this equivalent functionality via the Windows ⊞ key, and Chrome OS has a search
🔍 key. Support passing this disposition in the omnibox on all platforms. Bug: None Change-Id: I9a477678abbb8b369bee0eb9352f769d6b5d8fd8 Reviewed-on: https://chromium-review.googlesource.com/1132102Reviewed-by:Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#573949}
-
Mina Almasry authored
AvSync also needs to know the start_pts. Only then can it actually correctly log the a/v start error when starting in the middle of playback. Also, driveby fix to the unittests to tighten their checks and use the updated audio pipeline API. Now they pass within 16ms error. Bug: b/110569201 Test: cast_media_unittests Mp4Playback test case on device. Change-Id: I0dd13e3fc58e4d3ae0fe398a469c6fb1be43192f Reviewed-on: https://chromium-review.googlesource.com/1125527 Commit-Queue: Mina Almasry <almasrymina@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#573948}
-
Toni Barzic authored
For offline demo mode sessions, skip account auth, and pass empty user credentials to ARC. BUG=b:110276688 Change-Id: Ibefbde51831a82f2bf6a3a6bad80395c9227a544 Reviewed-on: https://chromium-review.googlesource.com/1125505 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#573947}
-
Dirk Pranke authored
It looks like the test started becoming flaky across most platforms yesterday afternoon (9-Jul, somewhere between r573370..r573480, though there's not an obvious regression window). TBR=kvitekp@chromium.org, pfeldman@chromium.org BUG=860123 Change-Id: I144073f934cf6571d6864f858710cbd07c667059 Reviewed-on: https://chromium-review.googlesource.com/1132375Reviewed-by:
-
