GitLab

I'm going to be writing the renderer-side code to interface with the
NetErrorTabHelper, and it will need to understand DNS probe results, so move
that enum to common.

BUG=156415

Review URL: https://chromiumcodereview.appspot.com/11776031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175628 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168294
TEST=see the repro steps and the expected behavior in the bug.

Review URL: https://codereview.chromium.org/11759021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175627 0039d316-1c4b-4281-b951-d872f2087c98

The new flag is --enable-new-message-center-popup, due to the discussion of crbug.com/164598
The user code: https://codereview.chromium.org/11773004/

BUG=161052
TEST=None

Review URL: https://codereview.chromium.org/11773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175624 0039d316-1c4b-4281-b951-d872f2087c98

We can not currently try a patch containing a binary blob, so we
submit the binary blob first, then try the rest of the patch
seperately.

NOTRY=true
TBR=binji@chromium.org
BUG=168867

Review URL: https://codereview.chromium.org/11817003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175623 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TBR=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/11819015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175622 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11776034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175620 0039d316-1c4b-4281-b951-d872f2087c98

BUG=167991


Review URL: https://chromiumcodereview.appspot.com/11788034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175619 0039d316-1c4b-4281-b951-d872f2087c98

This method is required to implement the CapturePicture API in Android WebView.

BUG=167908


Review URL: https://chromiumcodereview.appspot.com/11731002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175618 0039d316-1c4b-4281-b951-d872f2087c98

Shell::SetDisplayWorkAreaInsets (called from ShelfLayoutManager if launcher was set to autohide) applied while some
containers were transform-animated (lock window animation) resulted in incorrect offsets.

BUG=167215


Review URL: https://chromiumcodereview.appspot.com/11682006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175617 0039d316-1c4b-4281-b951-d872f2087c98

BUG=153359

Review URL: https://codereview.chromium.org/11787042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175616 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TBR=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/11818005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175615 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168360

Review URL: https://codereview.chromium.org/11791026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175614 0039d316-1c4b-4281-b951-d872f2087c98

Hot on the heels of r175591, we're now using the centered
asset everywhere.

This moves the mac asset over to common, removes the one in the
root directory (which was used by gtk), and updates the grd file.

BUG=168897
TEST=look at browser actions overflow asset, it's vertically centered.
on all platforms.
TBR=sail

Review URL: https://codereview.chromium.org/11824009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175612 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168676 (part 2 of comment 0)
TEST=have enough bookmarks that the overflow chevron shows up.
observer it's now centered vertically.
TBR=sail

Review URL: https://codereview.chromium.org/11820007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175610 0039d316-1c4b-4281-b951-d872f2087c98

- unitialized variables

Example:

[320:320:0108/121207:1124051475207:FATAL:browser_main_loop.cc(175)] Gtk: IA__gtk_widget_set_size_request: assertion `width >= -1' failed
	base::debug::StackTrace::StackTrace() [0xc57eac]
	logging::LogMessage::~LogMessage() [0xc77719]
	content::(anonymous namespace)::GLibLogHandler() [0x33f749c]
	<unknown> [0x7fe62ad7ffa1]
	<unknown> [0x7fe62ad801b2]
	content::Shell::SizeTo() [0x81f69c]
	content::Shell::PlatformResizeSubViews() [0x81f6cc]
	content::Shell::CreateShell() [0x81c3f2]
	content::Shell::CreateNewWindow() [0x81c6fa]
	content::WebKitTestController::PrepareForLayoutTest() [0x829e82]
	content::InProcessBrowserLayoutTest::RunLayoutTestInternal() [0x5790f7]
	content::InProcessBrowserLayoutTest::RunLayoutTest() [0x578d91]
	content::MediaLayoutTest_VideoLoopTest_Test::RunTestOnMainThread() [0x4d93ba]
	content::ContentBrowserTest::RunTestOnMainThreadLoop() [0x573ba2]
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() [0x83e5ab]
	base::internal::RunnableAdapter<>::Run() [0x83eb7e]
	base::internal::InvokeHelper<>::MakeItSo() [0x83eb16]
	base::internal::Invoker<>::Run() [0x83eac3]
	base::Callback<>::Run() [0x459f2d]
	content::ShellBrowserMainParts::PreMainMessageLoopRun() [0x838a4e]
	content::BrowserMainLoop::CreateThreads() [0x33f846e]
	content::BrowserMainRunnerImpl::Initialize() [0x326bd64]
	content::BrowserMain() [0x326b96b]
	content::BrowserTestBase::SetUp() [0x83e536]
	content::ContentBrowserTest::SetUp() [0x573a15]

BUG=30715

Review URL: https://codereview.chromium.org/11777028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175608 0039d316-1c4b-4281-b951-d872f2087c98

This patch started out trying to add support for benchmarks that had different
outputs for each page. This is required for benchmarks that report [filtered]
profiling data, for instance something that simply groups timeline data and
reports it. To do csv output in taht situation, we have to hold output until
the end of the benchmark.

Making this work cleanly in the multi page benchmark code turned out to be
easily hacked, but unearthed a pretty hefty amount of deep, branchy code. So,
to make this cleaner, I cleaned up the results object.

We now have:
 - PageBenchmarkResults: all results for the benchmark
 - ValuesForSinglePage: all the results for a page
 - PageBenchmarkValues: a single value from a benchmark

PerfBot benchmark output is managed by PageBenchmarkResults. Csv and Block

terminal-block was renamed to block, but with backcompat to terminal-block.
Nobody could remember terminal-block.

R=tonyg,hartmanng
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/11779041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175602 0039d316-1c4b-4281-b951-d872f2087c98

TBR=thestig@chromium.org
BUG=166818
TEST=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11778046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175601 0039d316-1c4b-4281-b951-d872f2087c98

guava and jsr305 libraries are already present in the downstream build,
just need to not use the upstream third_party version and modify the
build script

BUG=
TBR=torne@chromium.org
Android only build fix. Ran through android bots with compile step.
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11822002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175600 0039d316-1c4b-4281-b951-d872f2087c98

This change replaces serveral instances of Get(PREV_ID) and Get(NEXT_ID)
with calls to the newly introduced GetPredecessorId() and
GetSuccessorId().

This is done in anticipation of the change that will remove PREV_ID and
NEXT_ID entirely.  By making this change in advance, that patch will be
smaller and easier to review.

BUG=145412,126505


Review URL: https://chromiumcodereview.appspot.com/11637053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175599 0039d316-1c4b-4281-b951-d872f2087c98

The change in render_widget_host_view_aura.cc is to prevent mouse events generated via touch events
on Windows being sent to the renderer. This is necessary as the touch events which are now sent to
the renderer ensure that clicks/moves, etc are handled correctly.

BUG=168427
Review URL: https://codereview.chromium.org/11773007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175598 0039d316-1c4b-4281-b951-d872f2087c98

As a prerequisite to supporting window.open, ViewHostMsg_CreateWindow messages need to be handled by BrowserPluginGuest as all guest-related state is accessed and handled there.

This patch handles and forwards ViewHostMsg_CreateWindow messages intercepted on the I/O thread from the guest process prior to reaching RenderMessageFilter and forwards them to BrowserPluginGuest to reject, instead of rejecting them immediately in BrowserPluginMessageFilter.

Future patches will replace the simple reject logic in BrowserPluginGuest with additional logic that will enable creating new windows.

BUG=140316

Review URL: https://codereview.chromium.org/11753030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175597 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168225


Review URL: https://chromiumcodereview.appspot.com/11740036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175596 0039d316-1c4b-4281-b951-d872f2087c98

TransportSecurityState, fix some book-keeping bugs, and hopefully add TACK.
This sequence of CLs will be derived from the original, overly-large CL
#11191005.

This CL does a few things:
- Adds a high-level API for processing HSTS/HPKP
- Move the code for handling HSTS/HPKP headers out of transport_security_state
- Move HashValue out of x509_cert_types
- Addresses several HSTS/HPKP parsing bugs identified during review of the cleanup
  - Ignore unknown HSTS/HPKP directives
  - Ignore unknown hash algorithms
  - Handle overly-large (> int64) expirations without parsing issues
  - Reject invalid pins entered by users


Review URL: https://chromiumcodereview.appspot.com/11274032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175595 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sgjesse@chromium.org
BUG=167175
TEST=none
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11820002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175594 0039d316-1c4b-4281-b951-d872f2087c98

BUG=146640
TEST=unit_tests on Windows pass with --gtest_filter=ProfileShortcutManagerTest.*.


Review URL: https://chromiumcodereview.appspot.com/11786008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175593 0039d316-1c4b-4281-b951-d872f2087c98

This doesn't include switching to a frame by element yet.
BUG=166797

Review URL: https://codereview.chromium.org/11639019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175592 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168675
TEST=look at browser actions overflow asset, it's vertically centered
TBR=sail

Review URL: https://codereview.chromium.org/11824006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175591 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168822

Review URL: https://codereview.chromium.org/11778047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175590 0039d316-1c4b-4281-b951-d872f2087c98

Changes:

1. Move most of logic in BrowserPluginEmbedder:OnCreateGuest to BrowserPluginEmbedder::CreateGuest. BrowserPluginEmbedder::CreateGuest takes in an opener guest and a routing ID. BrowserPluginEmbedder::OnCreateGuest calls CreateGuest with a NULL opener.

2. WebContentsImpl::CreateGuest now takes in a routing_id, and a base_web_contents.

3. WebContentsImpl::opener() is now a public accessor.

4. BrowserPluginEmbedder::GetGuestByInstanceID and BrowserPluginEmbedder::DestroyGuestByInstanceID are now public to allow a guest to take (temporary) "ownership" of another guest until it is attached to the embedder's DOM tree.

BUG=140316

Review URL: https://codereview.chromium.org/11748034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175588 0039d316-1c4b-4281-b951-d872f2087c98

The new clang has some bug fixes and is slightly pickier about
unused variables.

BUG=NONE
TBR=mark

Review URL: https://chromiumcodereview.appspot.com/11635050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175587 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102172


Review URL: https://chromiumcodereview.appspot.com/11552029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175586 0039d316-1c4b-4281-b951-d872f2087c98

This will allow the instant page to redirect based on country specific pages.
The change is a somewhat temporary fix and will be redundant when
InstantLoader lives in its own privileged process.

BUG=167982


Review URL: https://chromiumcodereview.appspot.com/11785025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175585 0039d316-1c4b-4281-b951-d872f2087c98

BUG=134694


Review URL: https://chromiumcodereview.appspot.com/11773027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175584 0039d316-1c4b-4281-b951-d872f2087c98

Testing test-disabler, and mistakenly committed.


> Disable GamepadProviderTest.UserGesture: testing auto-disable script
> 
> TBR=brettw@chromium.org
> Review URL: https://codereview.chromium.org/11828004

TBR=scottmg@chromium.org
Review URL: https://codereview.chromium.org/11823004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175582 0039d316-1c4b-4281-b951-d872f2087c98

TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/11828004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175581 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168820,166115
TEST=open lots and lots of tabs. The close button stays centered in
the selected tab, and the background tabs don't become so small that
they look clipped. If too many tabs are opened, they just wander
out of the window to the right, like previously.

Review URL: https://codereview.chromium.org/11821002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175580 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175578 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168710
Review URL: https://codereview.chromium.org/11794037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175576 0039d316-1c4b-4281-b951-d872f2087c98

The menu-item under the finger gets selected on tap-down. However,
if the gesture ends up scrolling the menu, then the item should be
unselected.

BUG=161487

Review URL: https://codereview.chromium.org/11751002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175575 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175574 0039d316-1c4b-4281-b951-d872f2087c98