GitLab

Some methods are not currently supported by common.checkout.git, and
Git.run is used in such cases for now. Later we would like to port some
of them (the reusable ones) to common.checkout.git.

Bug: 676399
Change-Id: I42459221c684f8ffeabb9991a64dea3489663d19
Reviewed-on: https://chromium-review.googlesource.com/793984Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519777}

Turns out its still doing some FS access via stat() and
readlink().

TBR=piman@chromium.org

Change-Id: I927f55eaec732bcf600d3f43a135f2680d9b424f
Reviewed-on: https://chromium-review.googlesource.com/792296Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519776}

Change-Id: I96707a3d692c0065f5ab9f87e7265df14b5e82de
Reviewed-on: https://chromium-review.googlesource.com/786095Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519775}

https://pdfium.googlesource.com/pdfium.git/+log/fee749f0a141..99acb1c816dc

$ git log fee749f0a..99acb1c81 --date=short --no-merges --format='%ad %ae %s'
2017-11-28 dsinclair [XFA] Use default values to optionals
2017-11-28 dsinclair [XFA] Fix reading off end of name list

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ie5db6327ef396552ef355e11e9fa1a29da8bf87b
Reviewed-on: https://chromium-review.googlesource.com/794059
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519774}

Changed Assert to Criteria checks for SpaceDisplay text updates.
Removed @RetryOnFailure flag.

Bug: 751492
Change-Id: I04b2cfdbb058ed50daa0187ae95117801f4a5073
Reviewed-on: https://chromium-review.googlesource.com/792392Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519773}

This better describes its function, and avoids confusion later on
should we broker an unlink() call. In that case, the correct permission
check would have nothing to do with the unlink_ member.

Tidy while we're at it:
Remove unused static method (apart from test).
Convert bool functions to return bool expressions.
General readability stuff.

TBR=piman@chromium.org

Change-Id: Id81b9d494a677f8c37865e5145158a03bdb18ae8
Reviewed-on: https://chromium-review.googlesource.com/786083Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519772}

Update the chrome://download-internals page to add some text describing
what modifications we make on the URLs.

BUG=776146

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie63a17722bda00baec8806395fd0c8dce3f5cdba
Reviewed-on: https://chromium-review.googlesource.com/728350
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519771}

This CL adds base::Feature flags which independently control the enforcement
of a minimum number of required field for heuristics, queries and uploads.

This allows autofill to:

(1) generally enable uploading of form/field type votes for 1-field and
    2-field forms. This will populate the crowd-sourced predictions for
    these forms.

(2) experiment with expanding the scope of field prediction (both heuristic
    and queried) and filling to single field forms.

The primary motivation for this change is to support single field forms in
payment gateway iframes (usually cc-num or cvc). It will also enable single
Zip code forms (shipping estimates) and email subscription forms.

This CL defaults to the exact same behavior as before the CL: enforcement
of the same minimum value (3) for heuristics, query and upload. The unit
and browser tests have however been updated to test both enforced and
relaxed minimums (unit-tests) and with the upload minimum relaxed (data-
driven browser tests).

TBR: mahmadi, olivierrobin
Bug: 731719, 626785, 604994
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If91ec4c68e1e2d819a03818a6766f0fec9d04e32
Reviewed-on: https://chromium-review.googlesource.com/692674
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519770}

Bug: 788939
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I29772945465558910f6aa8758939c5225a877383
Reviewed-on: https://chromium-review.googlesource.com/791829Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519769}

R=scottchen@chromium.org

Bug: NONE
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic85659a4598037f029f49f3ce073f4b53ac3860f
Reviewed-on: https://chromium-review.googlesource.com/790941Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519768}

The write index for the buffer that holds the time domain data is read
from the main thread and written by the audio thread.  Atomically
access these and also read (and write) them exactly once in each
routine so that they don't get out of sync within each routine.

Can't add a trylock to protect access in WriteInput because if the
audio thread can't get the lock, there will be strange gaps in the
saved data.  It's ok if the main thread reads a slightly old value of
the index; the data is just a bit stale, which is fine for the
AnalyserNode.

Bug: 786829
Test: test case from bug passes
Change-Id: Id8d5658b9610beb0d78c2c16d9eac579406e4c2b
Reviewed-on: https://chromium-review.googlesource.com/790945Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519767}

Flaky on --mus.

Test: none
Bug: 765794
Change-Id: I7b5ccaeb2da6ebbb233c33ece7fb813949c99bec
Reviewed-on: https://chromium-review.googlesource.com/791522Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519766}

The test is causing crash on devices which do not suport OpenGL ES3.

Bug: 644265
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id98475c27897e1ca4cd207af4d145ab0c4733a85
Reviewed-on: https://chromium-review.googlesource.com/788112Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519765}

Bug: 787581
Change-Id: Iba4ae13dbeacbf8f731c4a9d712eb1e0f95f61d1
Reviewed-on: https://chromium-review.googlesource.com/786612
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519764}

If we lose our context (or potentially in rare OOM cases), gpu::buffer
allocation can fail. In these cases the discardable system shouldn't
crash, but should fail gracefully.

Bug: 762645
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I9d56536fd21893689ef993a68ee2a5639947e612
Reviewed-on: https://chromium-review.googlesource.com/782647Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519763}

Bug: 667560
Change-Id: Ib684737981db2d50aba7031a26d4e48cfc3fb1bf
Reviewed-on: https://chromium-review.googlesource.com/792263
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Reviewed-by: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519762}

Currently, if the user changes the default search engine in
settings, the touch bar does not update to reflect the change.

To fix this issue, the BrowserWindowTouchBar is modified so
that it observers changes to the default search engine.

Tests: browser test BrowserWindowTouchBarTest.SearchEngineChanges

Bug: 696702
Change-Id: I92861aabf9ab2e87ba6d1d32fda975d9a10bdf26
Reviewed-on: https://chromium-review.googlesource.com/792034
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519761}

This CL removes testing fieldtrial config for a fully launched feature.
The change has been omitted in the previous CL 781780.

Bug: 695810
Change-Id: I9c6bc13207193ea3dfd8072196ccdb1ecedf9692
Reviewed-on: https://chromium-review.googlesource.com/790390Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519760}

TBR=miu@chromium.org

BUG=789192

Change-Id: Iac44a0facb28d55b744ce11c1de9add0cf0944a0
Reviewed-on: https://chromium-review.googlesource.com/794271Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519759}

Prior to this patch AuraTestHelper configured TestScreen in such a way
that it would create a WindowTreeHost to represent a screen. The
WindowTreeHost was created was not a WindowTreeHostMus, rather a
WindowTreeHostPlatform. This doesn't make sense for mus.

As part of this I'm also moving how ash configures Env to
AuraTestBase. This way other code using AuraTestBase can work better
with mus.

Lastly I needed to make sure sure AuraTestHelper resets some state
that was persisting between runs. This is necessitated by Env being
created at the TestSuite level, not per test.

BUG=776514
TEST=covered by tests

Change-Id: Icb1b5342f962f44c03185a3e40097491532c4efe
Reviewed-on: https://chromium-review.googlesource.com/791821Reviewed-by: Elliot Glaysher <erg@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519758}

BUG=788993

Change-Id: I9fc477c0ba27283c5aa2d00400b510705e1929d9
Reviewed-on: https://chromium-review.googlesource.com/792538Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519757}

In 48bedbd2 a new reason was added to force an Indexed DB closed:
for migration. This change failed to add a value in enums.xml for UMA.

Not strictly related to 643544, but was noticed when reviewing UMA
values post change.

Bug: 643544
Change-Id: I793df6967a80046775babb1cf0af242b2c148374
Reviewed-on: https://chromium-review.googlesource.com/792031Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519756}

This CL contains minor changes in ImageBitmap and ImageBuffer to:

- use blending in SkCanvas::drawImage() only if needed
- fix ImageBitmap->CopyImageData() behavior to match the signature
- use SkImageInfo::minRowBytes() in SkImage::readPixels() call sites

Bug: 785313,788879,788881
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I1473fc71ce1785f87c0f3e47441515f6cd3dd7a7
Reviewed-on: https://chromium-review.googlesource.com/793951
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519755}

Bug: 786349
Test: Manually. ARC can be started.
Change-Id: I4bbe58284642b8792095088dea7ccc6b9f337976
Reviewed-on: https://chromium-review.googlesource.com/792259
Commit-Queue: Yury Khmel <khmel@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519754}

Checks if a test has the PRE_ prefix. Use it for tests that wants to
know, so they do not have to have their own version.

Change-Id: I4c0dbf38ab5c3ab5b088b5564a91acc61f275656
Reviewed-on: https://chromium-review.googlesource.com/786771
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519753}

It was possible to put thing in a bad state by calling glBind* with an
invalid client id (which binds the invalid service id) and then calling
glDelete* with an invalid client id (which deletes the invald service
id).

BUG=785753

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4628f964e9d14a1d87bc12b1cde3f056acb8314e
Reviewed-on: https://chromium-review.googlesource.com/791011Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519752}

https://webrtc.googlesource.com/src.git/+log/e9619f8f81de..b874a352272a

$ git log e9619f8f8..b874a3522 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I792b134a8649f2623e08de5b891c627170240384
Reviewed-on: https://chromium-review.googlesource.com/794056Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519751}

https://skia.googlesource.com/skia.git/+log/9f553932a4a4..12b69eedeed5

$ git log 9f553932a..12b69eede --date=short --no-merges --format='%ad %ae %s'
2017-11-20 ethannicholas shader cache now ignores shaders with a length of 0
2017-11-14 ethannicholas Fix shader initialization on a cache hit
2017-11-28 jvanverth Add create_bundle support for GN

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=allanmac@chromium.org

Change-Id: I64a40bba4b6d805993bccce82205711700d29f4c
Reviewed-on: https://chromium-review.googlesource.com/794057Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519750}

Bug: 788900
Change-Id: Ia15c1712bc894b2c69920d37192c75b47dc67fbe
Reviewed-on: https://chromium-review.googlesource.com/794170Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519749}

These bots are no longer split between builders and testers.

Part 2 after https://chromium-review.googlesource.com/783518

R=hans@chromium.org

No-Try: true
Bug: 587879
Change-Id: I98201d6582933e1e86e3762abfe2923bdad7c21e
Reviewed-on: https://chromium-review.googlesource.com/792346
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519748}

Bug: 789145
Change-Id: Iffd4099a6eb58cc532fb39bddda8581fd5a65a31
Reviewed-on: https://chromium-review.googlesource.com/793810
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519747}

With event sender input is possibly injected solely on the main thread and
a host may not be bound yet. So protect against null host objects on
the main thread.

BUG=788886

Change-Id: I6b8d1449ce01e3a1f0872133440839fa445d1567
Reviewed-on: https://chromium-review.googlesource.com/793971Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519746}

Sometimes it times out.

Also moved animations/animation-ready-reject-script-forbidden.html
expectation to where it belongs.

TBR=kojii@chromium.org

Change-Id: I36b75d39be98ff57f235fe768259ae37d65b271d
Reviewed-on: https://chromium-review.googlesource.com/793192Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519745}

An interesting note is that the spec says scroll-behavior on BODY should
not propagate to the viewport. Firefox currently does that.

Bug: 788347
Change-Id: Id82deeac64177bce05268bb5fdb2df144f808800
Reviewed-on: https://chromium-review.googlesource.com/793045Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519744}

To reduce modifications to SecurityContext's SecurityOrigin and
make it easier to make SecurityContext's SecurityOrigin const.
No behavior changes are expected.

Bug: 779730
Change-Id: I03ac5b2a22eb84cce8cd287eed3a4c13cb639f2f
Reviewed-on: https://chromium-review.googlesource.com/762360
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519743}

Instead of sharing this code, it should be replaced by directly using
the Embedded Test Server.

Bug: 638674
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If887548078abe90314363a39c33980225239a523
Reviewed-on: https://chromium-review.googlesource.com/791810
Commit-Queue: Mike Baxley <baxley@chromium.org>
Reviewed-by: Menglu Huang <huangml@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519742}

This CL changes the callback of SysLogsSources::Fetch such that the generated
SystemLogsResponse is passed as a unique_ptr instead of a raw pointer. This
allows further cleanup in the form of processing the SystemLogsResponse
asynchronously, because the receiver of the SystemLogsResponse can be sure to
be the true owner and does not need to worry about the caller deallocating the
object.

TBR=rkc@chromium.org

Bug: 787554
Change-Id: I85ddfd2f3972039cea0eca43b0fce3bc5d0ba105
Reviewed-on: https://chromium-review.googlesource.com/787470
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519741}

Bug: chromium:788796
Change-Id: I208022746d63a6379dcf55cb12c1ec8fea8aabcc
Reviewed-on: https://chromium-review.googlesource.com/794110Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519740}

ArcMetricsService used to be simple, but it's not anymore and needs
some tests. For example, since b/62703685 has been fully implemented,
ArcMetricsService::ReportBootProgress() may receive event timestamps
that are smaller than |arc_start_time|.

BUG=b:65128488
BUG=b:62703685
TEST=try

Change-Id: Idd2aed6bdc2cbdb970d8e9b0e02987377ae1cfd6
Reviewed-on: https://chromium-review.googlesource.com/785110Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519739}

These fixes will make it easier to autogenerate this file with full
fidelity.

BUG=662541
TBR=dpranke@chromium.org
NOTRY=true

Change-Id: Iab5fc98e13b9ce4c4b61d29fa72d08bc06b3c8b1
Reviewed-on: https://chromium-review.googlesource.com/790131
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519738}