GitLab

In Web applications, the Filesystem API is used to create sandboxed
filesystems. Files in these filesystems should never be shown in a
filepicker. ChromeOS supports a few special filesystems (Downloads,
Gallery) where the files should be shown in filepickers.

This change fixes the userVisibility property for File instances created
from such filesystems.

BUG=398366

Review URL: https://codereview.chromium.org/516763002

git-svn-id: svn://svn.chromium.org/blink/trunk@181530 bbb929c8-8fbe-4397-9dbb-9b2b20218538

On non-intel (aka non x86/x64) we can compile the assembly stubs as a
source_set and not use yasm.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/541933003

git-svn-id: svn://svn.chromium.org/blink/trunk@181529 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes the unused MarginSign enum. I noticed this while
searching how we name enums in Blink as part of another patch.

Since I was in the area, I fixed the comment about margins as well.

R=esprehn

Review URL: https://codereview.chromium.org/548113002

git-svn-id: svn://svn.chromium.org/blink/trunk@181528 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added all the plumbing to make Blink aware of the top controls position
and how its viewport has been resized as a result. This CL adds all the
machinery and plumbing but does not yet connect main-thread scrolls to
the top controls. This is needed to support scrolling the top controls
during slow-scrolls as well as correct viewport behavior in the virtual
viewport pinch-to-zoom.

The machinery for top controls now includes two values:

top_controls_layout_height: The amount that the viewport was shrunk to
accommodate the top controls. This is updated only during a layout that
causes a viewport resize (i.e. RenderWidget::OnResize). The compositor
needs this to know how much the viewport layer has already been resized
by Blink.

top_controls_content_offset: The amount that the top controls are showing.
This will be the same as top_controls_layout_height right after a viewport
resize, but will diverge since the top controls will move without
immediately causing a RenderWidget resize.

Blink now keeps track of the top controls "content offset", which is the
distance the content is offset from the top of the screen due to top
controls. It receives updates to this value from the Impl thread during
a commit and echos them back to the compositor.

On the compositor side, the top controls layout height is moved into the
LayerTreeImpl. This is necessary since a commit will change the viewport
layer's size on the pending tree. Keeping it in LayerTreeHostImpl meant
that, until the pending tree was activated, the top controls layout height
corresponded to the viewport bounds in the pending tree. This was causing
flickering as the viewport container was the incorrect size for a short
time. The compositor also keeps track of the top controls content offset
value. The top controls offset uses the same model as page scale, keeping
an offset (the value as known by the main thread), a delta from the main
thread's value, and a sent_delta to keep track of what has been sent to
the main thread.

See: https://codereview.chromium.org/511253003 for Chromium-side patch.

BUG=333143

Review URL: https://codereview.chromium.org/513053003

git-svn-id: svn://svn.chromium.org/blink/trunk@181527 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes some deadcode from CompositedLayerMapping:
1) hasContentsLayer - this function name was confusing.
2) isMainFrameRenderViewLayer - state is now all within CLM.

No new tests, no change in behavior.

Review URL: https://codereview.chromium.org/542863007

git-svn-id: svn://svn.chromium.org/blink/trunk@181526 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rebaseline-o-matic failing to rebaseline these results: some issue with
changing to it's third_party/WebKit directory. Remove baseline requests
for multicol tests on Snowleopard Debug:

fast/multicol/pagination-h-horizontal-bt.html
fast/multicol/pagination-h-horizontal-tb.html
fast/multicol/pagination-v-horizontal-bt.html
fast/multicol/pagination-v-horizontal-tb.html
fast/multicol/client-rects.html

TBR=wangxianzhu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=409708

Review URL: https://codereview.chromium.org/553673002

git-svn-id: svn://svn.chromium.org/blink/trunk@181525 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rebaseline server is not submitting them at thit time, event though it
has been asked to do so. Ran webkit-patch rebaseline-expectations, and
pulled results from the 10.6 Mac bots for submit (old skool).

TBR=wangxianzhu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/554503002

git-svn-id: svn://svn.chromium.org/blink/trunk@181524 bbb929c8-8fbe-4397-9dbb-9b2b20218538

fast/multicol/client-rects.html
fast/multicol/pagination-h-horizontal-bt.html
fast/multicol/pagination-h-horizontal-tb.html
fast/multicol/pagination-v-horizontal-bt.html
fast/multicol/pagination-v-horizontal-tb.html

TBR=ccameron@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=409708

Review URL: https://codereview.chromium.org/548173002

git-svn-id: svn://svn.chromium.org/blink/trunk@181522 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181520

TBR=noel@chromium.org

Review URL: https://codereview.chromium.org/551633002

git-svn-id: svn://svn.chromium.org/blink/trunk@181521 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rebaseline fast/layers/scroll-descendant-with-cached-cliprects.html on mac
after blink r181475 and r181499

TBR=ccameron@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=409708

Review URL: https://codereview.chromium.org/547233002

git-svn-id: svn://svn.chromium.org/blink/trunk@181520 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181492

BUG=395425
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/551613002

git-svn-id: svn://svn.chromium.org/blink/trunk@181519 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181492

BUG=395425
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/546273002

git-svn-id: svn://svn.chromium.org/blink/trunk@181518 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181492

BUG=395425
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/549963002

git-svn-id: svn://svn.chromium.org/blink/trunk@181517 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181492

BUG=395425
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/546663004

git-svn-id: svn://svn.chromium.org/blink/trunk@181516 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181492

BUG=395425
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/554483002

git-svn-id: svn://svn.chromium.org/blink/trunk@181515 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add null checking in EventTarget::removeEventListener,
because we shouldn't be passing in a null listener reference to the ==()operator.

BUG=377425
R=sigbjornf@opera.com

Review URL: https://codereview.chromium.org/539453002

git-svn-id: svn://svn.chromium.org/blink/trunk@181514 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also clarify some comments (I'm not sure why this needs this stuff
callable from any thread anyway) and organize the members by user.

BUG=

Review URL: https://codereview.chromium.org/553553002

git-svn-id: svn://svn.chromium.org/blink/trunk@181513 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181493

BUG=408260
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/547113003

git-svn-id: svn://svn.chromium.org/blink/trunk@181512 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181499

BUG=409708
TBR=ccameron@chromium.org

Review URL: https://codereview.chromium.org/548933002

git-svn-id: svn://svn.chromium.org/blink/trunk@181511 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Simplify the implementation by having it mirror the addEventListener() version.

Which means creating a correct protector and passing it inwards.

Review URL: https://codereview.chromium.org/547103002

git-svn-id: svn://svn.chromium.org/blink/trunk@181510 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is another speculative crash fix (previous one was r181045).

BUG=400483

Review URL: https://codereview.chromium.org/546633006

git-svn-id: svn://svn.chromium.org/blink/trunk@181509 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1. save page scale factor if it is greater than minimal legible/readable scale
2. normalize sizeRect on current page scale factor to be measurable with caret and textboxRect

R=aelias@chromium.org

Review URL: https://codereview.chromium.org/527003002

git-svn-id: svn://svn.chromium.org/blink/trunk@181508 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Retires ScriptWrappable::init and renames m_wrapperOrTypeInfo to m_wrapper
because we no longer need WrapperTypeInfo in m_wrapperOrTypeInfo.
Removes related code, too.

BUG=235436

Review URL: https://codereview.chromium.org/540283003

git-svn-id: svn://svn.chromium.org/blink/trunk@181507 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181499

BUG=409708
TBR=ccameron@chromium.org

Review URL: https://codereview.chromium.org/551593002

git-svn-id: svn://svn.chromium.org/blink/trunk@181506 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These forward references are not needed anymore.

Review URL: https://codereview.chromium.org/541383003

git-svn-id: svn://svn.chromium.org/blink/trunk@181505 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Import these polygon shapes reftests and fix them.
Note that these tests should be imported at some point.

This is based on http://trac.webkit.org/changeset/172973 by Zoltan Horvath <zoltan@webkit.org>.

From the WebKit patch commit log:
We didn't respect the shape-margin before a positioned polygon, since we checked
the shape-margin for only 1 vertex for a polygon edge. This patch fixes the behavior,
removes the tests from the skipped list and updates 1 test, which was incorrect.

Review URL: https://codereview.chromium.org/510513002

git-svn-id: svn://svn.chromium.org/blink/trunk@181504 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This depends on HTMLDocumentParser fix: https://codereview.chromium.org/532343002/

XMLHttpRequest and HTMLImport need callback when document has finished
parsing. This CL introduces an interface DocumentParserClient for receiving the
"parser stopped" notification, and migrates HTMLImportLoader to use the
interface.

BUG=409461

Review URL: https://codereview.chromium.org/535403002

git-svn-id: svn://svn.chromium.org/blink/trunk@181503 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add clipping.
Add transform.
Change recording to be driven by GraphicsContext.
Update dependent code.
Move a method used only by SVGFEImage from AffineTransform to SVGFEImage

R=pdr,senorblanco
BUG=410019

Review URL: https://codereview.chromium.org/536573002

git-svn-id: svn://svn.chromium.org/blink/trunk@181502 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181494

BUG=410541
TBR=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/553613002

git-svn-id: svn://svn.chromium.org/blink/trunk@181501 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instead of needing to update both loops any time we change anything we
should just put the Element specific things in Element::recalcStyle and
then put the shared method into ContainerNode. I also removed an old
comment about ShadowRoot::recalcStyle not supporting adjacent selectors
properly (I fixed that bug a long time ago).

There should be no change in behavior, I just moved the code around.

BUG=399816

Review URL: https://codereview.chromium.org/548693002

git-svn-id: svn://svn.chromium.org/blink/trunk@181500 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The function ScrollbarThemeMacNonOverlayAPI::paint calls into
HIThemeDrawTrack to draw the track alone, then calls into
WebThemeEngineImpl::paintScrollbarThumb (a la Mac), to make
the exact same HIThemeDrawTrack call, just with a thumb added.
Coalesce these into a single call to HIThemeDrawTrack, which
makes the thumb actually appear.

The reason that the thumb wasn't appearing in the first place is
that the nested gfx::SkiaBitLocker instances weren't playing nice
with each other. In non-impl-side painting, the gfx::SkiaBitLocker
instances would draw to the underlying canvas. With impl-side
painting, they were drawn offscreen, and this evidently doesn't
work (tested by passing the CGContextRef directly to the
WebThemeEngineImpl::paintScrollbarThumb call rather than
creating a separate gfx::SkiaBitLocker, not root-caused).

So, the solution is a bit roundabout in the sense that it just
side-steps the gfx::SkiaBitLocker problem, but this is better
than fixing that problem and continuing to do this in the
double-identical-draw-for-no-reason manner.

BUG=409708

Review URL: https://codereview.chromium.org/544913002

git-svn-id: svn://svn.chromium.org/blink/trunk@181499 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ToT currently doesn't pass lint-test-expectations; address.

TBR=eae
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/547023003

git-svn-id: svn://svn.chromium.org/blink/trunk@181498 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This avoids crashing in call sites that happen during document setup and shutdown
of the document. An example of the former appears to be in the attached bug.

An example of the latter is easily reproducible: load a document with hyperlinks
in it, select some text via the text finding widget (ctrl-f), then click on the 
hyperlink. The code to close the find box will call into Blink and check
if the elements are focusable. However, the elements no longer have renderers
since the document has been deactivated to prepare for navigation.

TBR=abarth@chromium.org
BUG=251163

Review URL: https://codereview.chromium.org/533963002

git-svn-id: svn://svn.chromium.org/blink/trunk@181497 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=409727

Review URL: https://codereview.chromium.org/547493002

git-svn-id: svn://svn.chromium.org/blink/trunk@181496 bbb929c8-8fbe-4397-9dbb-9b2b20218538

overflow clip.

Previously it checked for clip but not overflow clip.

BUG=409680

Review URL: https://codereview.chromium.org/543123003

git-svn-id: svn://svn.chromium.org/blink/trunk@181495 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously, there was some special logic in RenderText::clippedOverflowRectForPaintInvalidation
to detect a special scenario when the paint invalidation container of the
RenderText was a child of the containing block/layer of the RenderText.
This had two flaws: one, it was checking for a condition different than that, and
two the descendant check is quite expensive if the paint invalidation container
is far away in the render tree from the RenderText.

The intent of the code is to delegate invalidation to the containing block/layer.
The new implementation does that directly, by overriding containerForPaintInvalidation as well as
clippedOverflowRectForPaintInvalidation
to delegate directly.

This also fixes a bug in which RenderText objects invalidate much too widely
if the RenderText is being reparented accross a frame boundary. This started
happening because now we let paint invalidation containers cross frame boundaries.

BUG=410541

Review URL: https://codereview.chromium.org/544743003

git-svn-id: svn://svn.chromium.org/blink/trunk@181494 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add support for font family names with a font-weight suffix (such as
Light, Semibold, Black  etc). If the full name fails to match an 
installed font check for a font-weight suffix and if so strip it and set
the weight according to the prefix.

The current implementation matches IE when it comes to picking or
overriding the weight based on the suffix.

TEST=fast/text/font-weight-variant.html
BUG=335323, 410333, 410865, 408260
R=cpu@chromium.org, dglazkov@chromium.org

Review URL: https://codereview.chromium.org/542603004

git-svn-id: svn://svn.chromium.org/blink/trunk@181493 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Conditionally disable subpixel text for certain older fonts at sizes
below 16px in order to improve legibility and rendering quality. This is
limited to a specific set of fonts and does not apply to webfonts.
This list of fonts in question includes all fonts in the "Microsoft Core
fonts for the Web" collection.

Specifically the following fonts: arial, courier new, times new roman,
andale mono, comic sans, impact, georgia, trebuchet, verdana, webdings,
tahoma, and lucida console.

R=cpu@chromium.org, scottmg@chromium.org
BUG=405445,395425

Review URL: https://codereview.chromium.org/544843004

git-svn-id: svn://svn.chromium.org/blink/trunk@181492 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fix to keep the selection of the text field in input element after setSelectionRange is called by dom events related to mouse

The problem is that the selection is cleared when handling mouse release.
The selection should be kept if the selection is set by setSelectionRange during handling mouse event.

BUG=32865
R=yosin@chromium.org
R=rbyers@chromium.org
TEST=LayoutTests/fast/forms/setrangetext-within-events.html

Review URL: https://codereview.chromium.org/507533002

git-svn-id: svn://svn.chromium.org/blink/trunk@181490 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181485

TBR=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/547873002

git-svn-id: svn://svn.chromium.org/blink/trunk@181489 bbb929c8-8fbe-4397-9dbb-9b2b20218538