- 04 May, 2018 40 commits
-
-
rodmartin authored
The test was taking too much time in debug mode. This CL improves the time needed to test by not editing the session using the UI. Change-Id: I9809dc08b15deb988f3bbc09b00d3f4ba0a5eda8 Reviewed-on: https://chromium-review.googlesource.com/1042998 Commit-Queue: Martin Rodriguez <rodmartin@google.com> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#556180}
-
Min Qin authored
Splits downloadEntry into UkmInfo and InProgressInfo, added new information needed to resume the download item after chrome crashes. Bug: 803135 Change-Id: Ided64d9801a3e8e1d8390a4190d17aa3b58d652c Reviewed-on: https://chromium-review.googlesource.com/1036539 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#556179}
-
Dan Sanders authored
Bug: 522298, 839951 Change-Id: I106c081d21c69b3802d4e50ce8ce74f54f6590b1 Reviewed-on: https://chromium-review.googlesource.com/1043252 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#556178}
-
Eric Orth authored
Created as two separate methods, one for reports and one for clients, to avoid polluting the interface with a data_type_mask as is used internally. Also, to avoid dealing with confusing difference between always-true filter and null filter when they should logically be equivalent, cleaned up ReportingCache to explicitly have two separate clear data methods, one that clears everything without filter and one that always assumes it has a valid filter. Bug: 824997 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: If8fc3698eb61efbdee566dbd55e649723ff1e3d8 Reviewed-on: https://chromium-review.googlesource.com/1038524 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#556177}
-
Xiyuan Xia authored
TARGET_AND_DESCENDANTS event targeting policy does not work properly under mus/mash. As a result, mouse events are not delivered to the windows under ExoShellSurface in SystemModalContainer even though ExoShellSurface says it does not handle the events. Use DESCENDANTS_ONLY for mus/mash until event dispatching code is fixed to handle such case. Bug: 839521 Change-Id: I8e949164d2cd9666468a8995d0bdb8e29f6b9301 Reviewed-on: https://chromium-review.googlesource.com/1044542 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#556176}
-
kylechar authored
Add a manually triggered GPU trybot that runs the same configuration as "Win7 FYI Release (NVIDIA)". Bug: 838895 Change-Id: I2a2f87ee7b452200a860282b01c673493adbea00 Reviewed-on: https://chromium-review.googlesource.com/1044767Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#556175}
-
Wenzhao Zang authored
1) Update the UI to be the same with the web-ui implementation. 2) Add a button to lock_debug_view.cc|h for easy debugging. Bug: 836336 Change-Id: I89143c7db149dea31bc6848de18e6ecc6386f98b Reviewed-on: https://chromium-review.googlesource.com/1044746Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#556174}
-
xlai authored
The previous flakiness might be a device-specific issue that is seen in Intel HD 530 but not Intel HD 630. Bug: 690663 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I18b2c9822bf39cfbcd233e2219ac460eb51875b6 Reviewed-on: https://chromium-review.googlesource.com/1044656Reviewed-by:
-
Roger Tawa authored
This CL simply adds the new policies and hooks them up the appropriate local state preferences. A follow up CL will start using the policies to control chrome behaviour. Bug: 834939 Change-Id: If8a0984a118383a375f2a72c71f0b1cf555fbb6a Reviewed-on: https://chromium-review.googlesource.com/1032797Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Robert Shield <robertshield@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#556172}
-
Peng Huang authored
Bug: 776877 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4135777822e41a928906e5d42308afd36f8ee40f Reviewed-on: https://chromium-review.googlesource.com/1044290 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#556171}
-
Kevin Marshall authored
Serial kernel logging is a deprecated feature of Zircon and should not be used anymore. This uses a long-running SSH invocation of "dlog" to pull the logs over the wire. It works equally well on QEMU and on devices. Created a stream multiplexer using "poll" to merge the kernel log and application log into a single stream, which is passed to the symbolizing filter. Modified the symbolizer regex rules to allow kernel log timestamps. Kernel log timestamps can be omitted from the output, but they seem to be helpful at visually distinguishing kernel output from app output. Bug: 838671 Change-Id: Icd45f902a49983b4e4ee262de474d69fbef56860 Reviewed-on: https://chromium-review.googlesource.com/1038423 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#556170}
-
Gabriel Charette authored
I intentionally didn't add "Foreground" to non "Background" workers as they may be used for background tasks in some configurations and I don't want it to be confusing for developers. R=fdoray@chromium.org Bug: 839525 Change-Id: I8c1e928914aa6d2e35fedc1db4e8a639d39116b2 Reviewed-on: https://chromium-review.googlesource.com/1044501 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#556169}
-
Raphael Kubo da Costa authored
https://chromium-review.googlesource.com/c/chromium/src/+/705955 ("base::flat_map was missing defaults for duplication handling") removed them in favor of inheriting them from flat_tree. This can cause problems with GCC due to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84782, and the build has been failing with it since https://chromium-review.googlesource.com/1000393 ("Mojo C++ Bindings: unordered_map => flat_map") with a message like this: gen/mojo/public/interfaces/bindings/tests/test_unions.mojom.cc: In member function ‘void mojo::test::ObjectUnion::set_f_map_int8(const base::flat_map<std::__cxx11::basic_string<char>, signed char>&)’: gen/mojo/public/interfaces/bindings/tests/test_unions.mojom.cc:455:30: error: use of deleted function ‘base::flat_map<std::__cxx11::basic_string<char>, signed char>::flat_map(const base::flat_map<std::__cxx11::basic_string<char>, signed char>&)’ std::move(f_map_int8)); ^ In file included from ../../mojo/public/cpp/bindings/clone_traits.h:11:0, from gen/mojo/public/interfaces/bindings/tests/test_unions.mojom.h:22, from gen/mojo/public/interfaces/bindings/tests/test_unions.mojom.cc:15: ../../base/containers/flat_map.h:152:7: note: ‘base::flat_map<std::__cxx11::basic_string<char>, signed char>::flat_map(const base::flat_map<std::__cxx11::basic_string<char>, signed char>&)’ is implicitly declared as deleted because ‘base::flat_map<std::__cxx11::basic_string<char>, signed char>’ declares a move constructor or move assignment operator class flat_map : public ::base::internal::flat_tree< ^~~~~~~~ Work around it by replacing the inheritance statements with actual constructors and operator=() overloads again. This change does not completely revert https://chromium-review.googlesource.com/1000393, as the constructors maintain their new signature (so that they look like flat_tree's). Bug: 819294, 837221 Change-Id: I8f37a2c8aa269b3c1025cdc009518a7709e95947 Reviewed-on: https://chromium-review.googlesource.com/1038103 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#556168}
-
Emircan Uysaler authored
We should set this field to distinguish HW codec implementations of Chromium from SW codecs of WebRTC. googCodecName field already sets VP8/VP9/H264 information, so setting this field to a generic name "HW*coder" should be enough. Bug: 838739 Change-Id: I9936daef9a53b6f004ede357e37fd976ca0d9c9e Reviewed-on: https://chromium-review.googlesource.com/1039023 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#556167}
-
Victor Costan authored
Bug: 829893 Change-Id: I245991138fe88d662d374ec2fe45e08424bd1366 Reviewed-on: https://chromium-review.googlesource.com/1036861Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#556166}
-
Edward Lemur authored
This adds {win,mac}_chromium_compile_dbg_ng_patch_on_gclient to make sure that patching on gclient works as expected. Bug: 643346 Change-Id: Ife7cb26c1b699be50d85f5e629824e7f205781cd Reviewed-on: https://chromium-review.googlesource.com/1043345Reviewed-by: -
Dan Sanders authored
This moves logging of bitstream errors that were previously in the GPU log to the media log. To support async destruction correctly, VdaVideoDecoder now implements the MediaLog interface and handles thread hopping. Also includes some additional cleanups in VTVDA: improved log messages, increase the number of requested picture buffers to match recent changes in DXVAVD, and returns no supported profiles if VideoToolbox fails to initialize. Bug: 522298 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7f13deb9e92fdeeeac60479e17081e72c5f22066 Reviewed-on: https://chromium-review.googlesource.com/1038609 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
-
Alexis Hetu authored
The SwiftShader library was failing to load properly when used as a WebGL fallback because of a sandboxing issue. This cl works around that issue by changing where the SwiftShader initializatin is done. Credit to zmo@ for this fix, which I cherry picked from: https://chromium-review.googlesource.com/c/chromium/src/+/1005017/20..21 Fixes: gpu_tests.gpu_process_integration_test.GpuProcessIntegrationTest.GpuProcess_feature_status_under_swiftshader Bug: chromium:726075 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I56a00cef70cb630bbf6d5fe7f342a8d5b1c2211d Reviewed-on: https://chromium-review.googlesource.com/1042496 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
edchin authored
When closing tabs, an observer immediately deletes snapshots from the snapshot cache. This prevents snapshots from reappearing in an undo close all tabs operation. This CL enables snapshot restoration on undo close all tabs by extending the life of a snapshot when closed with a "close all" operation. Note this is only extended for regular tabs, not incognito tabs. The extended life is accomplished by marking tabs for deletion during a close all operation, rather than immediately deleting the image from the cache. Later, the marked images are either purged from the cache, or the marked list is cleared (therefore leaving the images in the cache). Bug: 804567 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4710bf46d3ebd4ad347563e5f6a6208a68a58209 Reviewed-on: https://chromium-review.googlesource.com/1041545 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556162}
-
Michael Thiessen authored
In https://chromium-review.googlesource.com/c/chromium/src/+/1042500 I missed a commit which added a crucial line :) TBR=tedchoc@chromium.org Bug: 837807 Change-Id: Ibc8f4f69e86ba16cfcff223c72b64481d9289549 Reviewed-on: https://chromium-review.googlesource.com/1044754Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#556161}
-
xlai authored
We were too conservative in setting a larger-than-enough threshold for complete idle task detection in canvas_async_blob_creator. Based on latest user statistics, 5 seconds delay for desktop and 9 seconds delay for mobile are good for 99% users. This long threshold might be contributing to the flakiness on leak bot of the convertToBlob tests--the delayed task for current thread takes too long to finish, even longer than the timeout limit of the test, causing a JS object leak. Bug: 836278, 787972 Change-Id: I01ced35c4f910b4193adec6f8b26d9a02885a279 Reviewed-on: https://chromium-review.googlesource.com/1042534Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Olivia Lai <xlai@chromium.org> Cr-Commit-Position: refs/heads/master@{#556160}
-
Tarun Bansal authored
Also, change the expected HTTP response code from 204 to a list containing 3 codes (200, 404,and a 3rd one configurable via field trial experiment). Change-Id: I403841d93b9f7c8f9096e827ac67116658b15c82 Bug: 839628 Reviewed-on: https://chromium-review.googlesource.com/1043269 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#556159}
-
Owen Min authored
This is a reland of 86dafb90 Original change's description: > Add chrome enterprise logo in the theme_resources.grd > > The logo is located in > default_100_percent/google_chrome > default_200_percent/google_chrome > > Bug: 838156 > Change-Id: Id300ef64e70cdc92bcdbad89b5aad00bc5bbd777 > Reviewed-on: https://chromium-review.googlesource.com/1042491 > Reviewed-by: Greg Thompson <grt@chromium.org> > Commit-Queue: Owen Min <zmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556093} TBR=grt@chromium.org Bug: 838156 Change-Id: I4f05111772577a3b68e1dcea1550792268cabbb0 Reviewed-on: https://chromium-review.googlesource.com/1044572Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556158}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/848c86e3e858..15759121361d $ git log 848c86e3e..157591213 --date=short --no-merges --format='%ad %ae %s' 2018-05-03 tandrii Update windows bleeding-edge git to 2.17.0 Created with: roll-dep src/third_party/depot_tools BUG=chromium:811681 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I316a0f743f65642a2c299797055256ab9f9f5dd5 Reviewed-on: https://chromium-review.googlesource.com/1044544Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556157}
-
Istiaque Ahmed authored
Bug: 769012 Change-Id: Iae7e7ff1b338c2302476002c28dcc58378292404 Reviewed-on: https://chromium-review.googlesource.com/1028617 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556156}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I55617b91fb756ad4f2d94b02dbc6b39b812cf7ce Reviewed-on: https://chromium-review.googlesource.com/1044890Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#556155}
-
Ahmed Fakhry authored
Make the docked magnifier follow touch events. BUG=837285 TEST=Added new test Change-Id: Id1fdbe047cdcbf3e8cd35cbf5ddd8712c0c3828c Reviewed-on: https://chromium-review.googlesource.com/1044493Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#556154}
-
Daniel Park authored
Removes divs from Clear Browsing Data, Accessibility, Site Settings, and Site Settings sub pages Bug: 834600 Change-Id: I28afdc9e4a3823b082dc22da6c44653eabfcdb84 Reviewed-on: https://chromium-review.googlesource.com/1044273 Commit-Queue: Daniel Park <danielpark@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#556153}
-
Becky Zhou authored
Use server-controlled 1) maximum number of peeks and 2) minimum delay in seconds after page loaded to adjust whether to auto peek the bottom sheet on reverse scroll. Bug: 833865 Change-Id: I021f94236d8f59a8fac9057b80130e4326517c4e Reviewed-on: https://chromium-review.googlesource.com/1040345Reviewed-by:
-
Lei Zhang authored
BUG=746768 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I70bf50ac9a9b4708af4bfac0e975a727c9a82edb Reviewed-on: https://chromium-review.googlesource.com/1043649Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#556151}
-
Becky Zhou authored
Original CL: https://chromium-review.googlesource.com/821492 Bug: 839511 Change-Id: I99bf98a4ef9a369b6d1c7e3dfee3c9aa9d357e9b Reviewed-on: https://chromium-review.googlesource.com/1043351Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#556150}
-
Tim Zheng authored
BUG=chromium:839149 TEST=Verified manually on an eve device. Change-Id: If25b73896c7049f20c565621c9c50aad39709acc Reviewed-on: https://chromium-review.googlesource.com/1043357 Commit-Queue: Tim Zheng <timzheng@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#556149}
-
Xi Cheng authored
These two switches are not intended to be used together. On the off chance that they are, process the former and ignore the latter. Bug: 734095 Change-Id: Iede04895e9bef055df66fff4019e091ba7e8f09b Reviewed-on: https://chromium-review.googlesource.com/1044543Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#556148}
-
Lei Zhang authored
Change-Id: I431828148e9f93eadd290493e848331f996cbd69 Reviewed-on: https://chromium-review.googlesource.com/1043657Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#556147}
-
Jordy Greenblatt authored
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3e0a93d5540b3a822de001fa7f9ae2c8191463f8 Reviewed-on: https://chromium-review.googlesource.com/1036584 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#556146}
-
David Tseng authored
TBR=derat@chromium.org Change-Id: I5b31bee43dfca9de4d4aa188642a1f1ff9cfbca5 Reviewed-on: https://chromium-review.googlesource.com/1044289Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#556145}
-
CJ DiMeglio authored
This reverts commit 686a5f7b. Reason for revert: suspected cause for https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/ failures external/wpt/websockets/constructor/014.html?wss ( Code Search ) external/wpt/websockets/keeping-connection-open/001.html?wss ( Code Search ) virtual/off-main-thread-websocket/external/wpt/websockets/constructor/014.html?wss ( Code Search ) virtual/off-main-thread-websocket/external/wpt/websockets/keeping-connection-open/001.html?wss ( Code Search ) Original change's description: > [PageLifecycle] Update the TabManager with the page freezing state > > In this CL, each frame updates its FrameResourceCoordinator with any > updates the lifecycle state. If the main frame lifecycle state is > updated, then the page inherit the new state. > > The PageSignalGeneratorImpl then updates the state in TabLifecycleUnit > which is used by the chrome:://discards UI. > > The CL also disables freezing a Tab that is already frozen. > > Bug: chromium:804976 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: Iba82286a06af17ccb74a7f6fac18cdb7914c003a > Reviewed-on: https://chromium-review.googlesource.com/942022 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > Reviewed-by: Shubhie Panicker <panicker@chromium.org> > Commit-Queue: Fadi Meawad <fmeawad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556084} TBR=dcheng@chromium.org,chrisha@chromium.org,fdoray@chromium.org,fmeawad@chromium.org,altimin@chromium.org,panicker@chromium.org Change-Id: Id1f8907c265e249d4bbe87cf514d66e6612fe18a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:804976 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1044573Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: Fadi Meawad <fmeawad@chromium.org> Cr-Commit-Position: refs/heads/master@{#556144}
-
Fadi Meawad authored
https://chromium-review.googlesource.com/c/chromium/src/+/1044573 Reverting it to allow the other CL to revert. Revert "Refactor to have a LifecycleState separate from the mojom::LifecycleState" This reverts commit bcc19833. Reason for revert: <INSERT REASONING HERE> Original change's description: > Refactor to have a LifecycleState separate from the mojom::LifecycleState > > This refactor was done to allow for greater granularity for internal LifecycleUnit state representation. > > Change-Id: I27c20eec8e5fe7f1365b64fe87b32cfdf124fbb8 > Reviewed-on: https://chromium-review.googlesource.com/1041010 > Commit-Queue: Varun Mohan <varunmohan@google.com> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556109} TBR=fdoray@chromium.org,varunmohan@google.com Change-Id: Ia95c828a2ad9a6a2c771c9b575da81073e5b2a2e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1044727Reviewed-by:
Fadi Meawad <fmeawad@chromium.org> Commit-Queue: Fadi Meawad <fmeawad@chromium.org> Cr-Commit-Position: refs/heads/master@{#556143}
-
Kevin Marshall authored
Add logic to inspect the ELF headers of the packaged binary and its libraries, to prune the libraries not marked as NEEDED by their ELF headers. Change-Id: Ie74864860f53a28b3dd8cd1f65b8dd24166c4395 Reviewed-on: https://chromium-review.googlesource.com/1041075 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#556142}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: none Test: none Change-Id: I1903abccc4d34d62a6f422f10106eac28c55e039 Reviewed-on: https://chromium-review.googlesource.com/1043102 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
-
