- 07 Jan, 2021 40 commits
-
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/e6e704145b31..8144af91b4f9 2021-01-07 dneto@google.com spirv-reader: ignore PointSize builtin declared at module-scope 2021-01-06 bclayton@google.com wgsl: Treat // as comment 2021-01-06 bclayton@google.com Implement clamping of runtime array accesses 2021-01-06 bclayton@google.com Fix ast_clone_fuzzer tests 2021-01-06 bclayton@google.com src/transform: Reimplement tests in WGSL 2021-01-05 dneto@google.com Add --demangle option to command example 2021-01-05 dneto@google.com spirv-reader: support OpArrayLength 2021-01-05 bclayton@google.com reader/wgsl: Fix parsing of matrices. 2021-01-05 dneto@google.com spirv-reader: rename to isNan, isInf 2021-01-05 bclayton@google.com Validate that runtime arrays aren't used as parameters 2021-01-05 dneto@google.com spirv-reader: ImageQuerySize can be on readonly image 2021-01-05 bclayton@google.com cleanup: Refactor tests to use ast::Builder helpers 2021-01-05 bclayton@google.com reader/spirv: Move common test name to fixture name If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: I6518089addf52550bc7ad05115191910d19b5eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612574Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840895}
-
chromium-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/5cb564b68580..7ca666453540 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 4cc0932495ec to a7825740f316 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com Change-Id: I3632ad2f899481d7cb05399081c854c87b768918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612568Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1bd38fed1b9e..f902efb9511c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I61ae1e6c0f1a348165bcaea268eaabdfb76f4e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612383Reviewed-by:
-
Shengsong Tan authored
This is part of the "Views Posse" effort. See this document: https://docs.google.com/document/d/1Rst3792TjXtVA8k8GXaPD8MnuB1JAneSOpIILdA4268/edit?usp=sharing Bug: 1159562 Test: build Change-Id: Id54167a8b23b0e2cf0046de263510c7e3526f470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596711Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Shengsong Tan <sstan@google.com> Cr-Commit-Position: refs/heads/master@{#840892}
-
Mei Liang authored
Bug: 1163744 Change-Id: Ie2261964525e1ecf3ae274645ba7534510fcb6cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613947 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#840891}
-
Shengsong Tan authored
This is part of the "Views Posse" effort. See this document: https://docs.google.com/document/d/1Rst3792TjXtVA8k8GXaPD8MnuB1JAneSOpIILdA4268/edit?usp=sharing Bug: 1159562 Test: build Change-Id: I4a9cb578e0cc7af1eb78d1af4f7c9c7b92926ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602959Reviewed-by:
-
Shengsong Tan authored
This is part of the "Views Posse" effort. See this document: https://docs.google.com/document/d/1Rst3792TjXtVA8k8GXaPD8MnuB1JAneSOpIILdA4268/edit?usp=sharing Bug: 1159562 Test: build Change-Id: I4f9845c124968d4fa9e5a10683eadf24228e3868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603760Reviewed-by:
-
Evan Stade authored
TBR=estaab@chromium.org Bug: 1158928 Change-Id: I4cebb92b0e7b6520dd057d5714dd492e7fe38c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612204Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#840888}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d48aa437c9e8..b34cd6d8fa4d 2021-01-07 ehmaldonado@chromium.org Revert "[owners] Refactor OwnersClient." 2021-01-07 ehmaldonado@chromium.org Revert "presubmit: Don't print comments for missing reviewers." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1163731 Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I71197fb9fcbbb077f560cf893fa02305fd0f3b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612572Reviewed-by:
-
Azeem Arshad authored
This CL moves qr_code_generator code from //chrome/common to //components/qr_code_generator. This move will allow the QRCodeGenerator class to be used in chromeos/services/cellular_setup/esim_manager service where a direct dependency to //chrome/common creates indirect DEPS violations. Bug: 1093185 Change-Id: I923d1613c46c2e1b194cb4eb3378db7aa5d51220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595199Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Travis Skare <skare@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#840886}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a7b7964a237a..9730dc4041f5 2021-01-06 johnstiles@google.com Revert "Fix GPU improved noise impl and add to perlinnoise GM." 2021-01-06 bsalomon@google.com Fix GPU improved noise impl and add to perlinnoise GM. 2021-01-06 brianosman@google.com Use SkVM for (many) interpreter tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I70514c6db2f9a0d2e8e2668f3a41808ea784821b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612567Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609955739-6b0df8082f85d23ee00a8173801024bf5e32803c.profdata to chrome-linux-master-1609977525-bd4b14e8a3331d25b143eda6470a50c1959dbc36.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I54a96a1becb0611b45065b6ea5d6256aab6c3540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613791Reviewed-by:
-
Jeroen Dhollander authored
This could lead to the following chain of events: - (Browser thread) Starts Assistant, and calls mojom method |ServiceController::Start()|. - (Browser thread) Stops Assistant, and calls mojom method |ServiceController::Stop()|. - (Mojom thread) ServiceController::Start() - Creates |AssistantManager| - Publishes it through the singleton |LibassistantV1Api|. - Informs browser thread through mojom method |StateObserver::OnStateChanged(started)|. - Here we get an interwoven sequence of events between the mojom thread and the browser thread: - (Mojom thread) ServiceController::Stop() - Informs browser thread through mojom method |StateObserver::OnStateChanged(stopped)|. - (Here we are 'interrupted' by the browser thread) - (Browser thread) StateObserver::OnStateChanged(started) calls AssistantManagerServiceImpl::PostInitAssistant() which accesses the |LibassistantV1Api| which is not null yet. - (Mojom thread) now destroys |LibassistantV1Api| and |AssistantManager|. - (Browser thread) dereferences the (now deleted) |AssistantManager| object and crashes. Bug: 1162136 Test: Compiled and deployed Change-Id: I86b30c76c544a926e46e7817540f17f0910da192 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612402 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#840883}
-
Alexander Cooper authored
Remove reference to needing to switch to the RBE backend now that it is default, and add current needed workaround. Change-Id: I52bcf7301c87f30258babba91ddbbff574dbd77d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612218 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#840882}
-
Sara Kato authored
Bug: crbug.com/1159562 Change-Id: Ifffe7c432a6516fad11ce5175073f20f6073915e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612288Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
-
Song Fangzhen authored
As Glen's suggestion in https://chromium-review.googlesource.com/c/chromium/src/+/2603063 We update PopulateLocalAddr() to make this function more readable. Bug: 905818 Change-Id: I39f131dcdb20b8990e3018358bc4ba316c59f0a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612610Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Ke He <kehe@chromium.org> Cr-Commit-Position: refs/heads/master@{#840880}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dc2cf6fc370e..46d3f02acfab 2021-01-06 ynovikov@chromium.org Suppress dEQP.KHR_GLES31/core_vertex_attrib_binding_basicinputcase5 2021-01-06 jdarpinian@chromium.org angle_end2end_tests passes on iOS! 2021-01-06 syoussefi@chromium.org Use is_apple instead of is_mac and is_ios everywhere 2021-01-06 jmadill@chromium.org Update auto-roller docs with vulkan-deps repo. 2021-01-06 timvp@google.com Tests: Add FIFA Mobile trace 2021-01-06 jonahr@google.com GL: Add function pointers for EXT/NV_framebuffer_blit If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1161513 Tbr: ianelliott@google.com Test: Test: angle_perftests --gtest_filter=TracePerfTest.Run/*fifa_mobile* Change-Id: I92a954f377645247b237c624e7ea8b7ffb4e6ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613809Reviewed-by:
-
Shengsong Tan authored
This is part of the "Views Posse" effort. See this document: https://docs.google.com/document/d/1Rst3792TjXtVA8k8GXaPD8MnuB1JAneSOpIILdA4268/edit?usp=sharing Bug: 1159562 Test: build Change-Id: I447708cdb7a93afece8b11605b873d64a65db95e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600429Reviewed-by:
-
Dale Curtis authored
VEA flush support isn't known until Initialize() completes, which happens by way of RequireBitstreamBuffers(). The old code uses the value of |flush_support_| during InitCompleted() despite it not being set until after InitCompleted() runs. The fix is to ensure we set |flush_support_| correctly before we use it and to switch to a base::Optional for its value to prevent accidental incorrect usage in the future. R=sandersd Fixed: 1163673 Test: New unittest. Change-Id: I69cec2f954ffc68773984ab59227b2cd10079820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613670 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#840877}
-
Andrew Grieve authored
On my machine, blink_public_mojom_mojom_platform with python3 goes from: I 21 Started (mojom_parser.py) I 33 Parsing 177 .mojom into ASTs I 2178 Processing dependencies I 2425 Loaded 92 modules from dependencies I 2425 Ensuring inputs are loaded I 2571 Serializing 177 modules I 3083 Finished to: 21 Started (mojom_parser.py) I 33 Parsing 177 .mojom into ASTs I 195 Processing dependencies I 455 Loaded 92 modules from dependencies I 455 Ensuring inputs are loaded I 537 Serializing 177 modules I 677 Finished It's still the case that for some steps "Processing dependencies" can be the majority of time spent. E.g. 2 of 2.7 seconds for content_common_mojo_bindings Bug: 1143399 Change-Id: I3fc6b7003f3d222da8743bec38bb9718aabb983e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605350 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#840876}
-
David Bienvenu authored
Bug: 229301 Change-Id: I93ed4493ae7a190a8e6d46f3d680b78d73eee882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613637Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840875}
-
Tsuyoshi Horo authored
This reverts commit 2cda8338. Reason for revert: This test is still flaky. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=All%2FPaintPreviewBrowserTest.DontReloadInRenderProcessExit%2FFileSystem Original change's description: > Reland "[Paint Preview] Post task captured callback" > > This is a reland of c669ac6b > > This is the test only, the fix was landed in https://crrev.com/c/2598087 > > - the previous test did not reproduce the crash, this one has crash a > crash that matches the trace in the wild > https://ci.chromium.org/p/chromium/builders/try/linux-dcheck-off-rel/16863? > It differs from the previous test by > - calling SetNeedsReload (emulating Clank's autorefresh) > - navigating to another frame afterwards, triggering Unload > > - the previous test timed out on some builders. It's possible that > the callback was already called before the test's own RunlLoop > started, which would mean that the loop never exits. This is avoided > by recording whether it has run or not. > > Original change's description: > > [Paint Preview] Post task captured callback > > > > This CL attempts to fix a bug where calling > > WebContents::DecrementCapturerCount in the callback passed to > > PaintPreviewClient can result in reloading a crashed render frame. > > This is problematic and crashes if it occurs inside RenderFrameDeleted > > and PaintPreviewClient::OnFinished is invoked. By posting the callback > > it should be invoked after RenderFrameDeleted cleanup is done resulting > > in DecrementCapturerCount no longer being called inside > > RenderFrameDeleted. > > > > Bug: 1146573 > > Change-Id: Iccb612d89135e058d8fc06de018e7c95cd91657a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595247 > > Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> > > Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> > > Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#837649} > > Bug: 1146573, 1160608 > > > Cq-Include-Trybots: luci.chromium.try:linux-dcheck-off-rel > Change-Id: I3ef0a81bb4fa99e2f42c6278ba53931aa934793e > Cq-Do-Not-Cancel-Tryjobs: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596697 > Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org> > Commit-Queue: Fergal Daly <fergal@chromium.org> > Auto-Submit: Fergal Daly <fergal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840497} TBR=mahmoudi@chromium.org,fergal@chromium.org,ckitagawa@chromium.org,fredmello@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ic6a0823155037dfd95e93bf030030d643178f153 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1146573 Bug: 1160608 Cq-Include-Trybots: luci.chromium.try:linux-dcheck-off-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612674Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#840874}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f902efb9511c..7f2db542af0f 2021-01-06 primiano@google.com Merge "trace_processor: make diff test more Win-friendly" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic5a49d8d31658e94a73d2f4ad1539b889386fce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613808Reviewed-by:
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/4fe018038f87..1b0cdaae57c0 This CL rolls googletest right before CL 315255779, which introduces a breaking change. $ git log 4fe018038..1b0cdaae5 --date=short --no-merges --format='%ad %ae %s' 2020-06-05 dmauro Googletest export Created with: roll-dep src/third_party/googletest/src Bug: 1163396 Change-Id: I96dde56036490f900637b39ff497cb4bc60c43f7 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chrome.try:win-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613521 Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#840872}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1609955739-17392bee52c5ddaf377dfb436abb48268c54a32a.profdata to chrome-win32-master-1609966729-d2f14914e2dc3c551a62ea16c0e882a0a5ae75ef.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8bf7a0700c633d7451dfd5acb286d7d3e171fce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613864Reviewed-by:
-
Luciano Pacheco authored
Bug: 1133186 Change-Id: I7525d713a176757056e3b944be0c602eabae1739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612285 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#840870}
-
Tsuyoshi Horo authored
This reverts commit 82afac04. Reason for revert: This CL broke StartupBrowserCreatorPickerTest.TestSetup. Bug: 1163675 Original change's description: > [ProfilePicker] Enable picker on startup only for active users > > Keep the picker disabled on startup until: > - multiple profiles were used in the last 28 days, or > - the picker has been shown once > > A new prefs::kBrowserProfilePickerShown pref is added to track whether > the picker has been shown before. > > Bug: 1063856 > Change-Id: Ia35a3b2212b3811ed592d81fa516bc1ffc07accc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598848 > Commit-Queue: Alex Ilin <alexilin@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840598} TBR=droger@chromium.org,alexilin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I306f0b7fa225b9d4043e948ec4c7a15e82ed9859 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1063856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612309Reviewed-by:
-
Harvey Yang authored
As it's only used on the UI thread, there's no need to use it with scoped_refptr. BUG=b:175355860 TEST=unit tests and run on kohaku(mojo) and octopus(file) Change-Id: I38db575b026566be963c1b772b88614318c7be24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599853 Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#840868}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1bd38fed1b9e..f902efb9511c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If05bb620519a9291ef08d58ff92c598f0a09fbec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612381Reviewed-by:
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.78. R=machenbach@chromium.org, rmhasan@google.com Bug: 1041619 Change-Id: Ia6e475e840930833a9543e378208fa16f204d337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612934 Commit-Queue: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#840866}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ca7d9ee2a720..1bd38fed1b9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic47743aa788b201fef5770236bf5d4d3186b287e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611218Reviewed-by:
-
Alan Cutter authored
This histogram is still useful for monitoring web app manifest updating issues. Bug: 1153779 Change-Id: Ib8cdc18d88755c51574abb109cd039ee81aa77c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592168 Auto-Submit: Alan Cutter <alancutter@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#840864}
-
James Cook authored
We want Lacros to be a separate platform for Finch targeting. The server side CL (cl/346677573) must land first. Bug: 1155704 Test: existing unit_tests Change-Id: I7e269abdd428131bd0a9fcadddc70f63c65126f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586245 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
-
Mei Liang authored
This CL disables the testCreateShippingAddressAndCreditCard test. It is flaky on builder: * android-pie-x86-rel TBR=micantox@google.com Bug: 1163659 Change-Id: I4431d9f180968a2548aed29c415ad143bdfd4c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612382Reviewed-by:
-
Evan Stade authored
This removes a dependency on TabAndroid. Bug: 1147268 Change-Id: Icbfa0ab7c0853b1935cf6bf9d9a52a4054302226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613535Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#840861}
-
Scott Violet authored
It looks like HistoryDeletionBridge is never destroyed. This ensures the observer it adds to HistoryService is properly cleaned up. BUG=1158388 TEST=none Change-Id: Idc2f65405d277bb3b58fe3e821472f581d7df1fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613645Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#840860}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609955739-bf9ad8193fca8e166eb0096fb68a4e9db5e69d48.profdata to chrome-win64-master-1609966729-f10b4c89116276ddc6d9d2f94d5dc003384dbd78.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I326307d03c9403672f8f95ec1d5a80fd6adb171b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613734Reviewed-by:
-
Scott Violet authored
It looks like ChromeBrowserProvider is never destroyed. This ensures the observer it adds to HistoryService is properly removed. BUG=1158388 TEST=none Change-Id: Ia29320b74dd807bfc12a69a5f8adc803e7a6b82e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613351Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#840858}
-
Shane Fitzpatrick authored
the eligible list. Bug: 923594 Change-Id: I00f5efb6681e381cedb8938c09554a8796933583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612264 Commit-Queue: Shane Fitzpatrick <shanefitz@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#840857}
-
Glen Robertson authored
Clarifies changes being made in crrev.com/c/2610531 Change-Id: I53cf89cbfb2ceb303430b248c44954fda14c8141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612608Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
-
