- 07 Feb, 2019 40 commits
-
-
Kush Sinha authored
Bug: 816954 Change-Id: I4ee640075af0948cbb8b5bfcc127123348cad98b Reviewed-on: https://chromium-review.googlesource.com/c/1426779 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#629940}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f0a00cd7f17b..93c01741f610 git log f0a00cd7f17b..93c01741f610 --date=short --no-merges --format='%ad %ae %s' 2019-02-07 evanhernandez@chromium.org cros branch: Support custom repo root. 2019-02-07 zwisler@google.com portage_util: unit test for always_live GetSourceInfo() call 2019-02-07 ahassani@chromium.org cros_generate_update_payload: Use new paygen library 2019-02-07 saklein@chromium.org build_api: Implement ImageService/Test Created with: gclient setdep -r src/third_party/chromite@93c01741f610 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib85a3a46d1f4e977ca010f8e02f20abe9c8a9506 Reviewed-on: https://chromium-review.googlesource.com/c/1457534Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629939}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b68e715cb291..2a54660850c3 Created with: gclient setdep -r src-internal@2a54660850c3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2787fc634d12614c6d848d39dca3eb200480eb44 Reviewed-on: https://chromium-review.googlesource.com/c/1457530Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629938}
-
Nikita Podguzov authored
Bug: 848942 Change-Id: I5e98582e5d1a949c8db25846068655ed2c551068 Reviewed-on: https://chromium-review.googlesource.com/c/1454897 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#629937}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/859db6b5a03c..382b122e45dc git log 859db6b5a03c..382b122e45dc --date=short --no-merges --format='%ad %ae %s' 2019-02-07 csmartdalton@google.com Revert "Add a GpuGM class for GPU-only tests" Created with: gclient setdep -r src/third_party/skia@382b122e45dc The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I024bed8810e3f1f7a9149e673fb4770e68357be9 Reviewed-on: https://chromium-review.googlesource.com/c/1457531Reviewed-by:
-
Alan Cutter authored
This CL ensures we do not spam the user's Application directory on Mac when syncing down installed PWAs. This makes Mac behave the same as Windows and Linux. Bug: 929559 Change-Id: I31df57e7d8228b2a47cc362f258afeee2dc840ef Reviewed-on: https://chromium-review.googlesource.com/c/1457698 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#629935}
-
Kush Sinha authored
AccountManagerMigrator used |AccountReconcilor::Initialize| as a way of starting account reconciliation because |AccountReconcilor::Start| is a private method. Make |AccountReconcilor::EnableReconcile| call |AccountReconcilor::StartReconcile| in its implementation and call |EnableReconcile| from AccountManagerMigrator. Bug: 904128 Test: components_unittests --gtest_filter="*AccountReconcilorTest*" Change-Id: I7899fb261080c10bb62ebdefe31c45d3a9a4754c Reviewed-on: https://chromium-review.googlesource.com/c/1424299 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#629934}
-
Kush Sinha authored
Th test assumed that Mirror account consistency will only be available if the logged in account is a child account. This assumption is no longer true. Bug: 915628 Test: browser_tests --gtest_filter="*ChromeOsMirrorAccountConsistencyTest*" Change-Id: I99a1f672949e76c22db159c0d69384f50727670d Reviewed-on: https://chromium-review.googlesource.com/c/1437285 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
The 'page_image_annotation' component uses V8 headers (transitively through blink) without importing the right build config for unittests, hence getting potentially wrong definitions due to missing #defines from the V8 build config. This CL adds blink_headers to public_deps of the renderer target, which fixes the problem for unit_tests and all future dependencies. Bug: v8:8788 Change-Id: I8ed60c8dc3f107c660235954a326e64a7b907e1d Reviewed-on: https://chromium-review.googlesource.com/c/1454491 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#629932}
-
Olya Kalitova authored
After PluginVm image is successfully downloaded it needs to be unzipped to a specific location. This CL adds unzipping functionality to the PluginVmImageManager so unzipping of the downloaded image could be called using manager and observer could receive events regarding status of the unzipping. Bug: 904851 Test: unit_tests --gtest_filter="PluginVmImageManagerTest.*" Change-Id: I005929fccbeec191951a054e303bc816e853285a Reviewed-on: https://chromium-review.googlesource.com/c/1443171 Commit-Queue: Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#629931}
-
Hiroki Nakagawa authored
This CL introduces a new mojo method in DedicatedWorkerFactory interface that is the browser-side entry point of PlzDedicatedWorker, and wires it up with worker script loaders. The script loaders are shared with PlzSharedWorker. PlzDedicatedWorker depends on off-the-main-thread dedicated worker script fetch and NetworkService. IsPlzDedicatedWorkerEnabled() helper makes sure it. Follow-up CLs will implement the renderer-side, and add tests. See also the class diagram in the design doc: https://docs.google.com/document/d/1fWsD0oIa5sNDfUFWGJZ41pDo3zzsbFGyQSNdV8nOG4I/edit?usp=sharing Bug: 731604, 906991 Change-Id: I1a7392b68f33a68dec22e347d931a0bb757fb38a Reviewed-on: https://chromium-review.googlesource.com/c/1445037Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#629930}
-
Markus Heintz authored
This is the first part (cl) for adding a new record only sync data type for recording security events. This CL adds the Chrome Sync Specifics proto. In the next CL the Sync Data type will be wired. Bug: 919489 Change-Id: I542f5cae27568927e614f793edfaf374058ea70a Reviewed-on: https://chromium-review.googlesource.com/c/1455998 Commit-Queue: Markus Heintz <markusheintz@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#629929}
-
Sergio Villar Senin authored
In crrev.com/c/1454618 FamilyInfoFetcher was migrated to use PrimaryAccountAccessTokenFetcher. However the code is still observing IdentityManager for the OnRefreshTokensLoaded() notification. It turns out that it is not very useful to listen to that as it's really unreliable. The reason is that at the time StartFetching gets called, OnRefreshTokensLoaded might or might not have happened already. If it has *not* already happened, then we'll report an error to the client. But if it *has* already happened, then we'll just end up waiting forever anyway. And there's not even a way for the client to know. Bug: 920965 Change-Id: I49b8741bfe438855bdf9c74c1a52528bba3baa79 Reviewed-on: https://chromium-review.googlesource.com/c/1454959 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2af003349292..29ecb64560ae git log 2af003349292..29ecb64560ae --date=short --no-merges --format='%ad %ae %s' 2019-02-07 lalitm@google.com Merge "trace_processor: make kernel lmk events lookup the upid for utid" 2019-02-07 taylori@google.com Merge "perfetto-ui: Add deselection" Created with: gclient setdep -r src/third_party/perfetto@29ecb64560ae The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iaf99164c4e5c299bf98c440279b7c7ac26e4cdc9 Reviewed-on: https://chromium-review.googlesource.com/c/1457529Reviewed-by:
-
Benoît Lizé authored
The original size is the size without compression. This allows to see the savings in memory-infra memory dumps. Also add a trace event for the aging task. Bug: 924164 Change-Id: I5cb2f968f8ec51d330b66fa211fde048bb5e2323 Reviewed-on: https://chromium-review.googlesource.com/c/1456657 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#629926}
-
Kush Sinha authored
A lot of tests fail with with Chrome OS Account Manager enabled. This patch fixes all of them in preparation of https://crrev.com/c/1426779. Failure details: https://crbug.com/915628#c8 Summary of (non-tests) changes: - Allow setting a fake URL loader factory in Account Manager - Initialize Account Manager for |TestingProfile| Bug: 915628 Test: interactive_ui_tests Test: sync_integration_tests Test: browser_tests Change-Id: I93aa1107fc1c48ed5e48bd38c0847e98ee15bcc6 Reviewed-on: https://chromium-review.googlesource.com/c/1437209 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I31902ed557d0dbc70df6dc3647d5de13ea641630 Reviewed-on: https://chromium-review.googlesource.com/c/1457528Reviewed-by:
-
David Roger authored
As this observer method has no production listeners, it is simply dead code. Bug: 922406 Change-Id: I9aa23327aed829111ca03ba3013840fdac5542d7 Reviewed-on: https://chromium-review.googlesource.com/c/1452443 Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
AutofillDownloadManager calls variations::ShouldAppendVariationsHeader() to know if the specified URL is trusted by Google. But this call has a side effect to record histograms, and results in double counting for those uses. This patch factors out Google trusted URL checks into google_util, and change variations:: and AutofillDownloadManager to call google_util::IsGoogleRelevantUrl for each slightly different purpose. Bug: None Change-Id: I66dc666011e4cc57327e06889adaeb2828ac6232 Tbr: mahmadi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1451504 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#629922}
-
Christian Dullweber authored
Add RemovalOptions.origins and RemovalOptions.exludeOrigins parameters to allow extensions to delete only a specific set of origins or exclude some origins from deletion. Bug: 78093, 113621, 924113 Change-Id: I42dbdf785ea5ef1cf9a3a95981a7551f2fadd2e2 Reviewed-on: https://chromium-review.googlesource.com/c/1405012 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#629921}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8200b1f0ea55..b68e715cb291 Created with: gclient setdep -r src-internal@b68e715cb291 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id1ad2dbc028b0cb1283f80248993c13cfa82540d Reviewed-on: https://chromium-review.googlesource.com/c/1457527Reviewed-by:
-
Marek Haranczyk authored
Bug: 854329 Change-Id: Ia163d503a4207859cd41c847c9d5f67e77580fbc Reviewed-on: https://chromium-review.googlesource.com/c/1456080Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Marek Haranczyk <mharanczyk@opera.com> Cr-Commit-Position: refs/heads/master@{#629919}
-
Pavol Marko authored
To be consistent with usage of base::Value::SetKey (as opposed to base::Value::SetPath). Bug: none Change-Id: I07648205e14cb17a22409d11cd5d3737f53e01e8 Reviewed-on: https://chromium-review.googlesource.com/c/1449577Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#629918}
-
Mike Wasserman authored
The system tray bubble's shadow should not overlap the shelf. This regressed in https://chromium-review.googlesource.com/c/1386432 Add a flag to apply shadow insets before calculating coordinates. This should restore the previous behavior for tray bubbles. Bug: 919645 Test: Tray/volume/etc. bubbles placed correctly for all shelf positions. Change-Id: I3592e73fc67b32dead470e25e14e450fadc08aba Reviewed-on: https://chromium-review.googlesource.com/c/1457434 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#629917}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f36ad269e88a..859db6b5a03c git log f36ad269e88a..859db6b5a03c --date=short --no-merges --format='%ad %ae %s' 2019-02-07 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@859db6b5a03c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: Ife617a875cc35d7192de405bb5dfb0dd744f6f9c Reviewed-on: https://chromium-review.googlesource.com/c/1457526Reviewed-by:
-
Patrick Noland authored
Bug: 929077 Change-Id: I0bde7e81451a8ada188bc5a515ae60e0aaaf1957 Reviewed-on: https://chromium-review.googlesource.com/c/1456216Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#629915}
-
Alexandre Courbot authored
Until now we were checking that the device thread methods are running in the right thread by directly calling BelongToCurrentThread() on the device thread's task runner. Change this to using a thread checker. Bug: None Test: Ran VDA unittest on Hana and VEA unittest on peach_pit, in debug mode. Change-Id: I86e8b6265e56ace5b20f51a1a70a41d1082f8f0f Reviewed-on: https://chromium-review.googlesource.com/c/1454020Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#629914}
-
Findit authored
This reverts commit bed0ba39. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 629880 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYmVkMGJhMzliN2JmNTMwMjQ2OGQyNTFjM2UxYzVhZTFhZDdkZWFjNgw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/10685 Sample Failed Step: ash_unittests Sample Flaky Test: ScreenRotationAnimatorSmoothAnimationTest.Observer Original change's description: > Disable shadow and mask while rotating in tablet mode > > Delay re-adding shadow and mask as it can interfere with > still animation. > > Bug: 923391 > Test: ScrenRotationAnimatorTest updated, OverviewSessionTest.RoundedEdgeMaskVisibility > Change-Id: Ie6455a40e2c796914f4fe04f4fa04cc13fc6fefc > Reviewed-on: https://chromium-review.googlesource.com/c/1453541 > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#629880} Change-Id: Ib4b62291f9f0e95356c3a6d035479f5abdc22c48 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 923391 Reviewed-on: https://chromium-review.googlesource.com/c/1457925 Cr-Commit-Position: refs/heads/master@{#629913}
-
Julie Jeongeun Kim authored
This CL makes ProfileDownloader use AccessTokenFetcher in kWaitUntilAvailable mode, which simplifies it as it doesn't need to observe OnRefreshTokenUpdatedForAccount(). This is a follow-up CL of https://crrev.com/c/1436780. Bug: 922757, 922758 Change-Id: If2b664a6e4e303db16cf028b947592e2f463c291 Reviewed-on: https://chromium-review.googlesource.com/c/1457575Reviewed-by:
-
Luciano Pacheco authored
Used lebab to convert to ES6 class with the following command: lebab --replace \ ui/file_manager/file_manager/foreground/js/file_selection.js \ --transform class Manual fixes: - Fix closure markup to go to constructor() instead of class definition. - Fix Mock class to be ES6 class too, since closure doesn't allow old style classes to extends from ES6 classes. - Rename MockFileSelectionHandler to FakeSelectionHandler. This fake lies to closure by saying that it extends FileSelectionHandler to allow it to be passed as FileSelectionHandler in closure compilation. - Add addEventListener() method to FakeFileSelectionHandler to fix tests that use this method. Bug: 778674 Change-Id: I39fb5ef7d7d8ef9c7fbc2b64244a26b9ebe23584 Reviewed-on: https://chromium-review.googlesource.com/c/1457700Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#629911}
-
Yoshifumi Inoue authored
This patches imports test cases for |SearchBufferTest| to |FindBufferTest| as preparation for getting rid of |SearchBuffer|. This patch also introduces |BufferMatchResult::operator==()| for testing. Change-Id: I5c8be1ca1e77e76b454341dad098f007a68ab376 Reviewed-on: https://chromium-review.googlesource.com/c/1457804Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#629910}
-
Yoshifumi Inoue authored
This patch introduces a performance test file "select-all-words.html" for measuring painting selection. See https://bit.ly/2SyNQS1 for profiling sample comparing legacy layout and LayoutNG. As of February 7, 2019, LayoutNG is two times slower than legacy layout. Change-Id: I8c5fe8418715b7d0078f6f1186c4191a1fb7d850 Reviewed-on: https://chromium-review.googlesource.com/c/1457701 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#629909}
-
David Roger authored
Following files are no longer built on ChromeOS: c/b/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc c/b/ui/bookmarks/bookmark_bubble_sign_in_delegate.h c/b/ui/views/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.cc c/b/ui/views/sync/bubble_sync_promo_view_unittest.cc c/b/ui/views/sync/bubble_sync_promo_view.cc c/b/ui/views/sync/bubble_sync_promo_view.h Dead ChromeOS code is removed from c/b/signin/ Some duplicated code is refactored into: chrome/browser/ui/views/sync/bubble_sync_promo_view_util.h Change-Id: I30eee77bdf856282e50a5315944c606559e41047 Reviewed-on: https://chromium-review.googlesource.com/c/1445940Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#629908}
-
Luciano Pacheco authored
Bug: 778674 Change-Id: Ie99662ee0fe609cf19218c818703b57e309013d4 Reviewed-on: https://chromium-review.googlesource.com/c/1457881 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
Let the style recalc pass mark for re-attachment and re-attach in the RebuildLayoutTree pass instead. Only call DetachLayoutTree for nodes which were slotted but are not part of the flat tree anymore. This is similar to removing nodes from the DOM tree where we also call DetachLayoutTree synchronously. This is to fix performance regressions in 926268. Ran a pinpoint job[1] to confirm that at least some of the tests improved/recovered. This means we will also avoid subtree recalc on re-slotting since we are marking the slotted nodes with kLocalStyleChange (to recalc if the inheritance parent changed), not kSubtreeStyleChange like we used to with LazyReattachIfAttached(). The new code for HTMLSummaryElement is to trigger a recalc/reattach for the details marker when the main summary element changes. That was not necessary before because of the kSubtreeStyleChange which forced the recalc down the UA shadow for <details>. [1] https://pinpoint-dot-chromeperf.appspot.com/job/13e09791d40000 Bug: 926268, 734908 Change-Id: I49c483a6cc5ee945270753b0e4b261202facd10c Reviewed-on: https://chromium-review.googlesource.com/c/1452167Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#629906}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e09b459b..69a830d3 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0111f3a4dd990bf0a52827b2918bb259cf0d0da5 Reviewed-on: https://chromium-review.googlesource.com/c/1457917Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629905}
-
Konstantin Ganenko authored
Service worker's version has nullptr GetMainScriptHttpResponseInfo when script loaded via ServiceWorkerInstalledScriptLoader. It is case when non-installed service worker requests script that is already installed. R=falken@chromium.org Bug: 929017 Change-Id: Ic4663fec8f2ad51982ac50a2fa2bd69fab67928b Reviewed-on: https://chromium-review.googlesource.com/c/1455138 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
Bug: 929042 Change-Id: I82dd5a4251457a6693a8780846e93d7b83bddf5b Reviewed-on: https://chromium-review.googlesource.com/c/1457574Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#629903}
-
Eric Seckler authored
Addresses a bug where we end up tracing to the buffer of a previous tracing session. Bug: 929080 Change-Id: I4b4f21a994eddf66b6714b43185c3f78a2ea1532 Reviewed-on: https://chromium-review.googlesource.com/c/1456006 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#629902}
-
Yoshifumi Inoue authored
This patch changes |EnclosingElementWithTag()| to use |InclusiveAncestorsOf()| to simplify source code for improving readability. Change-Id: Ica7d58f0dd4d44573ecf937d21b9855d2b8210d1 Reviewed-on: https://chromium-review.googlesource.com/c/1454210Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#629901}
-
