- 17 Nov, 2020 40 commits
-
-
Joey Arhar authored
If you call AbortSignal.abort() and then pass that AbortSignal to addEventListener, it shouldn't add the event listener. It currently adds the event listener and still runs the handler, and this patch stops it from adding the listener in that case. Fixed: 1149553 Change-Id: I7aee86d3fb2901947054c66d50e2aef1bb9467bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541503 Auto-Submit: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#828071}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: Ia1de93b4a1f628fd0598d81e6f969ae569faa3f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543368Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828070}
-
Lukasz Anforowicz authored
Bug: 888079 Change-Id: Ia471fbadb864570f5aa48e0ca032ea5d889a0d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533280 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#828069}
-
Noel Gordon authored
Initialize this.backgroundPage_ with new BackgroundWindowSWA() fake if Files app is running in the SWA container. window.BackgroundWindowSWA || null is used to pass Closure compile for current Files app (there are no extern defines for the SWA fakes). No change in Files app behavior. Test: browser_tests --gtest_filter="*launchFilesAppSwa*" Bug: 1113981 Change-Id: Ia079ea266583afd5a2ea67412758a77939327c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542931Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#828068}
-
Jesse McKenna authored
This change migrates uses of base::Bind to BindOnce/BindRepeating, and uses of base::Callback to OnceCallback/RepeatingCallback, in c/b/chromeos/base/locale_util*. Please see crbug.com/714018 for full details about the migration. Bug: 1148570 Change-Id: If16174080f643fddcd5c2d1c1ca86417c5b0b913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536473Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#828067}
-
Harry Cutts authored
This CL adds a new setting for pointing stick sensitivity, with a corresponding slider on the pointers subpage. If the flag is disabled, changes to the mouse sensitivity are copied to the pointing stick setting as well. See go/cros-pointing-stick-settings (Googlers only, sorry) for the design doc. Bug: 1114828 Test: check the new slider changes pointer speed Change-Id: I76d49f66f259276bb90427b4b32e00b415e328f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487253 Commit-Queue: Harry Cutts <hcutts@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#828066}
-
Gavin Williams authored
This change makes sure that on all platforms each expected destination icon is tested for. Bug: 1146550 Change-Id: I79a2c4407c8439d9988534b2f9e3ddbd99509a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539669 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#828065}
-
Yutaka Hirano authored
We had to calculate https://fetch.spec.whatwg.org/#concept-request-response-tainting in core/fetch because the CORS logic implemented in ThreadableLoader didin't support the concept. Now the CORS logic in /services/network calculates reponse's type, so we can use the value. Bug: None Change-Id: I98b56e1d79a73e364a7bec709e8cc4437131b261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537522 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#828064}
-
Leo Lai authored
Since chromium:1109629, eula screen doesn't show the owner password but it still tryies to fetch the password before showing the security system settings. Thus, cleaning it up for sake of security as well as for product excellence. Also, it is part of steps getting rid of `TpmGetPassword()` D-Bus method. BUG=b:172748724 BUG=b:168852740 BUG=chromium:1109629 TEST=browser_tests. Change-Id: If5c0829658753aacadc1dfc3df7d054e6f458851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536657 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#828063}
-
Mitsuru Oshima authored
Intoduce WMHelper::AppPropertyResolver to populate window properties for given |app_id| and |startup_id". Move the code to identify AppType property to app service directory. EXO should be generic window/composition server and should is a generic window server and should interpret the application id. Bug: None Test: covered by unittest Change-Id: I134c4071a515a0b9bdee7fbb17d1487c2eb60b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526500 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#828062}
-
Fergal Daly authored
This reverts commit bea26525. Reason for revert: This debugging has made it into M88 but it's a too noisy to allow into the release. This revert will be cherry- picked and then the debugging will be restored and improved. Original change's description: > Add DumpWithoutCrashing to try find navigations that later hit a CHECK. > > > > Bug: 1146573 > Change-Id: I695cecab30b60028a6003245da150b1a72089706 > Cq-Do-Not-Cancel-Tryjobs: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531334 > Commit-Queue: Fergal Daly <fergal@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Auto-Submit: Fergal Daly <fergal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826624} TBR=alexmos@chromium.org,fergal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1146573 Change-Id: I8b1c55e206f1b2b0353df2eb8f303b18efd13bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543523Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#828061}
-
Gabriel Charette authored
R=altimin@chromium.org Change-Id: Ia0794808672a61a70b7a3dd5e5f15ff4e6ec0a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537140 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#828060}
-
Nina Satragno authored
Plumb the minimum PIN length into the security key PIN settings page. forcePINChange will be implemented in a follow-up. Bug: 1143427 Change-Id: I399712fd00de1dda50a29b0e8e95fa77e34cca44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528624 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#828059}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metatada from OWNERS files for //components/content_settings Bug:1113033 Add DIR_METADATA files to //components/about_ui Generate DIR_METADATA files and remove metatada from OWNERS files for //components/about_ui Bug: 1113033 Change-Id: I556e7821267dab5eeb003b8b6935d7337e172838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543195Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#828058}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bee2bff5b0e1..bde2c3c32a2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tasak@google.com,tguilbert@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1149580 Tbr: tasak@google.com,tguilbert@google.com Change-Id: I84e95f3b36cca27473215885cff0f2dba35441d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543307Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828057}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/620cb770e3dd..c669bf529619 2020-11-16 syoussefi@chromium.org Vulkan: Optimize PBO copy from depth xor stencil src 2020-11-16 jdarpinian@chromium.org Remove trailing whitespace. 2020-11-16 geofflang@chromium.org GL: Implement EXT_YUV_target 2020-11-16 jmadill@chromium.org Vulkan: Fix serial handling for queries 2020-11-16 syoussefi@chromium.org Vulkan: prerotation deqp expectations 2020-11-16 syoussefi@chromium.org Optimize building prerotation deqp targets 2020-11-16 jmadill@chromium.org Vulkan: Remove RendererVk::getNextSubmitFence. 2020-11-16 syoussefi@chromium.org Vulkan: Expose OES_shader_image_atomic without VS/FS atomics 2020-11-16 jmadill@chromium.org Vulkan: Give CommandQueue an abstract interface. 2020-11-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 670ffea9d61b to 11c6670b4a4f (1 revision) 2020-11-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 1cda495274bb to 1f2fcddd3963 (2 revisions) 2020-11-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 128608f6da3a to 9d3ef3258715 (31 revisions) 2020-11-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 28c8eb1a to 089f5a3e (514 revisions) 2020-11-16 xiaoxuan.liu@arm.com Vulkan: Add support for headless surface 2020-11-14 timvp@google.com Update emulated_prerotation_ to emulatedPrerotation 2020-11-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from e2b55419a370 to be6ccb9ecaf7 (1 revision) 2020-11-14 syoussefi@chromium.org Fix texture buffer width query 2020-11-14 timvp@google.com Metal: Suppress TransformFeedbackTest::BufferOutOfMemory() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Test: Test: TextureBufferTestES31.QueryWidthAfterBufferResizeTest: Test: TransformFeedbackTest.BufferOutOfMemory/ES3_MetalTest: Test: dEQP-GLES31.functional.state_query.texture_level.texture_buffer.width_* Change-Id: Ib1e5d1446cc883a52864cd649945f737f466ce55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543309Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828056}
-
Harvey Yang authored
As the samples' channels should be ordered (accel_x, accel_y, accel_z), using ++it should reduce the complexity slightly compared with using find for each channel. BUG=b:172208566, b:172414227 TEST=builds, unit tests, and run on octopus Change-Id: Ibfcb385f71aec5c202a50940c04954393be0817a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519348 Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#828055}
-
Thanh Nguyen authored
Bug: 1149451, 1149504 Change-Id: Ic24dcb714db843aae17aafd6ba83a2c7a83d7ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543522Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#828054}
-
Min Qin authored
complete notification The download complete notification use Uri as an extra type. But when reading the extra, we treat it as an String. This CL fixes the issue BUG=1149649 Change-Id: If937c3688f4af8482fd4e7bbdc392cfcc84ff8f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542665Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#828053}
-
Preethi Mohan authored
See crbug.com/1149035 as well. Bug: 739522 Change-Id: Iaba40802428c26075162298cbcd013fca3adfc7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486482 Commit-Queue: Preethi Mohan <preethim@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#828052}
-
Patrick Monette authored
Bug: 971272 Change-Id: I35e1dc341bbf62b1639e03620ed549f2effd4678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530239 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#828051}
-
David Schinazi authored
Bug: 1148860 Change-Id: Ide0b89604da9d0bdbc9f0b57bd1794fc727fa4b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538135 Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#828050}
-
Evan Stade authored
VR browser is no longer supported, so this suppression is obsolete. Bug: 840811, 1147268 Change-Id: I6f6acbfad0c59ff1e1f12ac25a9d65de7d817f50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542806Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#828049}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605526350-6d778517c3f2c76fab9ee032fc1ed855eedd9044.profdata to chrome-linux-master-1605571148-8e0456d32b4535b8a26e31eb6f964ebd3417aaef.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ice610b3b757916db793e30c68630f3c20949e75d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543450Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828048}
-
Adam Langley authored
When a caBLEv2 tunnel server responds with a 410 status to a contact request it means that the contact ID is now invalid and should never be used again. This change notices that status code and erases pairings when that happens. (No UI changes since the UI for this is still unclear. I.e. the UI telling the user to check their phone still appears for the duration of the operation even through Chromium quickly knows that it's not going to work.) BUG=1002262 Change-Id: Iecf8fafe26d92aae1767df02267e1f2545d0ad0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538157 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#828047}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605526350-20402e3f73add4bc72f047c8e3796b7e4e1e9320.profdata to chrome-win32-master-1605538580-853d8fcb404f37acc68f0179b58be2e881687944.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I54fd935ec92a7445d07b2cdd77b7ac70c4ef7049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542482Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828046}
-
Sammie Quon authored
Minimized and non minimized windows have their rounded corners applied in overview differently, minimized on the mirror view layer, and normal windows on the actual window layer. Due to the setup of the current logic, minimized windows do not reset the windows layer rounded corners on exit. This was problematic if the window was not minimized when entering, and then minimized at exit which is a common workflow in tablet mode. Bug: 1146240 Test: added tests Change-Id: I9b3f9c465bb1bdfc5bf1acbe727ea9743472edcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542605Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#828045}
-
Darren Shen authored
IME service always expects an OnInputMethodChanged message first, then an OnFocus. However, if we enable NativeInputMethodEngine and then immediately focus, it will send out OnFocus then OnInputMethodChanged. This is because OnInputMethodChanged is sent in an async callback, which may run after we send OnFocus. Move the code to send OnInputMethodChanged out of the callback and call it immediately after connecting to IME service. This is ok because Mojo will queue up any messages automatically if the IME service is not yet ready. Bug: b/172990698 Change-Id: I81bc0062f867131d0c8faf32411a845f676b5aeb Fixed: b/172990698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537443 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#828044}
-
Kenneth Russell authored
This reverts commit 7cc6fb54. Reason for revert: root cause of flakiness has been addressed. Original change's description: > Retry conformance/textures/misc/exif-orientation.html . > > A recent change, still being tracked down, has made this test flaky on > macOS and ChromeOS. > > Bug: 1146687 > Change-Id: If22497aeefa8fa582124dce83c1e8fcf53bde479 > No-Try: True > Tbr: jdarpinian@chromium.org > Tbr: schenney@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528295 > Commit-Queue: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Reviewed-by: James Darpinian <jdarpinian@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825595} TBR=kbr@chromium.org,jdarpinian@chromium.org,schenney@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1146687 Change-Id: I87b3bbdfc2d822f39bc6f113781ae4633464afcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543190Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#828043}
-
Kenichi Ishibashi authored
`resource_ids` isn't used anymore. Removing it simplifies retries of DoomUncommittedResources(). Bug: 1133143 Change-Id: I99183060434429615b294538b8d719e3f4c49397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542928Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828042}
-
Matt Wolenetz authored
BUG=1149601 Change-Id: I6a38cd899ed4a862489616b5e1c7dfe608ea04a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541668 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#828041}
-
Andrew Xu authored
It is confusing that the count of items in the menu model is different from that of the item views in the context menu. In the current code, we have to insert the deletion command because MenuModelAdapter::ExecuteCommand() checks whether the command to execute is contained in the menu model. In this CL, the special command id (i.e. the item deletion command id) is removed. Instead, We use the command id to indicate which menu item is activated. When the clipboard history controller is notified of the activation, it queries the menu item specified by the command id about the action to take. This CL should not introduce any visual difference Bug: 1131556 Change-Id: I51b6c56aea656c1a2c764d756e616823c0bbf850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531063 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#828040}
-
Yuchen Liu authored
Implement LoadSession and RemoveSession for FuchsiaCdm: LoadSession -> fuchsia CDM::LoadLicenseSession RemoveSession -> fuchsia LicenseSession::GenerateLicenseRelease Bug: internal b/162078899 Test: https://storage.googleapis.com/m3u8_lag/persistent_license/index.html Change-Id: I151645ecaee800979690bd47936cc27584322acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373403 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#828039}
-
Alexander Dunaev authored
This is a reland of 30a60064 The difference to the original change is that here media_unittests are added to the list of test suites that run with Wayland. Original change's description: > [ozone/x11] Enabled user input monitor unit tests. > > This CL adds Ozone platform initialisation to the user input monitor tests > so they can now work with Ozone enabled. > > Bug: 1109112 > Change-Id: I31f9dabf2da9eed85cd05fe27017899b0247f4bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521144 > Commit-Queue: Alexander Dunaev <adunaev@igalia.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826638} Bug: 1109112 Change-Id: Id9de3d5985b9fe13c4b073b4f2731fc1df2966f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532776Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#828038}
-
Ryan Sturm authored
This also refactors the content/ accept header code to be in public along with the signed exchange accept header suffix. Bug: 1138648 Change-Id: Idf3f5d4f8b3034e301318bdb29d509ee46bc3d10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533331 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#828037}
-
Mitsuru Oshima authored
Bug: None Change-Id: Id30641a3ad725a93c0d05109a4d8115253805cf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537575Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#828036}
-
Ryan Sturm authored
When a prefetch is requested for a Google SRP via omnibox suggest hints, the query should include pf=cs. This adds a template URL case and a search data args field to accomplish this. If more sources of prediction become available, pf=c* should be used for those. Bug: 1148924 Change-Id: Icbbd9633c54199e23fee4f007d5e086dfe6041c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536987 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#828035}
-
Sammie Quon authored
The previous attempt [1] added checks for whether the starting or ending screenshot was taken. In the case of the starting screenshot missing, it would signal the animation to remove some RootWindowDeskSwitchAnimators, leading to a vector out of bounds. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2506356 Bug: 1148607 Test: added regression test Change-Id: I7f14df877cb93619a0ca8a85f5d0ad434dda3ad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536934 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#828034}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e05d24f9..89e3ceea Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I14e3d94c3021b99edfbe7b26c6c144570f79265c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542844Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828033}
-
Patrick Noland authored
ownership to LBC This puts LocationBarCoordinator in charge of constructing and destroying UrlBarCoordinator, StatusCoordinator, and AutocompleteCoordinator. This allows us to wire a few more dependencies into constructors instead of via setters. The coordinators are still passed to LocationBarLayout for it to use via a new initialize() method that consolidates a few different setter methods on LocationBarLayout. initialize() helps avoid bugs that could arise when calling these setters out of order. There is an additional change to LocationBarLayoutTest that fixes a DCHECK when running tests on a debug build. Reland fixes: * shouldShowDeleteButton can get called before initialize() when, e.g. we re-create the activity for a theme change, so it should account for UrlCoordinator possibly being null. We call updateButtonVisibility when the coordinator gets set, so the state should remain fresh * LocationBarTablet called methods on StatusCoordinator before initialize(). The fix, moving them to initialize, is easy, but revealed a spurious assert in StatusView that has been removed. Bug: 1146057, 1146062, 11493484, 1149245, 1149382, 1149242 Change-Id: Ia6aba188821a64d94a5f27136b54dbc7540547b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541812 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#828032}
-