GitLab

Avoid creating a temporary |gfx::Font| just to get its
name and size to pass it to Skia.

Note: There's room for further optimizations here, such
as caching, which I plan to look at in a future CL.

BUG=107394
TEST=Run aura and check that omnibox still looks fine. Run about:tracing and check that time used by this code is significantly decreased.

Review URL: http://codereview.chromium.org/8910004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114541 0039d316-1c4b-4281-b951-d872f2087c98

Change-Id: I43866084657d7d9c9ebcdd466684ac6f3e993f1e

BUG=chromium-os:23912
TEST=Log in, lock the screen, and unlock it. Ensure that the network menu ends with 'Network settings...' + IP, not 'More...'

Review URL: http://codereview.chromium.org/8913017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114540 0039d316-1c4b-4281-b951-d872f2087c98

The nacl_helper program uses content::MakeSharedMemorySegmentViaIPC but
none of the other proxy functions in the same source file.  Some of those
functions refer to symbols that bring in a great deal of other code, e.g.
most of v8.  We don't want all that code linked into nacl_helper--it bloats
the binary by a factor of ten or so.

Moving the function out to its own file prevents the other dependencies
coming in unnecessarily.

BUG= http://code.google.com/p/chromium/issues/detail?id=106986
TEST= still builds and nacl_helper binary is much smaller

R=jam@chromium.org,bradchen@google.com

Review URL: http://codereview.chromium.org/8893009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114539 0039d316-1c4b-4281-b951-d872f2087c98

Showing the avatar menu crashes after crrev.com/114330.
SizeToContents was called before BubbleFrameView init.

This workaround checks GetBubbleFrameView before calling SizeToContents.
Also, run OnAvatarMenuModelChanged on Init, not ctor.

BUG=106989,107574
TEST=No crash and doesn't regress crbug.com/106989.

Review URL: http://codereview.chromium.org/8909013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114538 0039d316-1c4b-4281-b951-d872f2087c98

Upcoming test infrastructure requires access to this meember.

TEST=try bots.
BUG=none.


Review URL: http://codereview.chromium.org/8917020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114537 0039d316-1c4b-4281-b951-d872f2087c98

R=maruel@chromium.org
BUG=
TEST=Verified that this produces verbose debug spew in VS2008 official builds.


Review URL: http://codereview.chromium.org/8910022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114536 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107470
TEST=Check output log, and compare CPU usage with the non-XDamage case.


Review URL: http://codereview.chromium.org/8937019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114535 0039d316-1c4b-4281-b951-d872f2087c98

This adds support for IDL in the private directory. Some of the interfaces there don't actually work, they were a work in progress and this breaks everything, so I moved the broken files to a new subdirectory. Everything left in the api/private directory can be autogenerated now.

BUG=
TEST=

Review URL: http://codereview.chromium.org/8930023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114534 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107548
TEST=


Review URL: http://codereview.chromium.org/8942001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114533 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8907048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114532 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98591
TEST=

Review URL: http://codereview.chromium.org/8916013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114531 0039d316-1c4b-4281-b951-d872f2087c98

R=mmoss@chromium.org


Review URL: http://codereview.chromium.org/8909011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114530 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS/builds/2495/steps/unit_tests/logs/stdio

Show parse errors in the UI when loading ONC files.
BUG=chromium-os:23757
TEST=manual
Review URL: http://codereview.chromium.org/8883046

TBR=chocobo@chromium.org
Review URL: http://codereview.chromium.org/8947002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114528 0039d316-1c4b-4281-b951-d872f2087c98

This is the first of several CLs to add a "laptop mode" to Aura that works like the traditional ChromeOS browser view.  In particular:
* Keep the browser maximized.
* Hide window caption buttons.
* Suppress the launcher and related shelf items.
* Suppress background image.
* Add the switch to about:flags.

These things don't work yet:
* Status area is wedged in upper-left corner.
* Popup browser windows are maximized and they shouldn't be.

BUG=106898
TEST=manual, run ChromeOS Aura build and turn the flag on and off

Review URL: http://codereview.chromium.org/8895003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114527 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8911011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114526 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107047
TEST=none


Review URL: http://codereview.chromium.org/8890074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114525 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107047
TEST=crypto_unittests


Review URL: http://codereview.chromium.org/8894023

TBR=mattm@chromium.org
Review URL: http://codereview.chromium.org/8913018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114524 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114522 0039d316-1c4b-4281-b951-d872f2087c98

There was a problem on one of the canaries yesterday that prevented a roll.
On current TOT WebKit there have been some build problems, but this
revision looks OK on the canaries.

BUG=none
TEST=canaries
TBR=morrita
Review URL: http://codereview.chromium.org/8930025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114521 0039d316-1c4b-4281-b951-d872f2087c98

The tests should all succeed but on bots where audio hardware is missing, we should get a printout that no devices were detected.

Notably the mac bots do have the necessary equipment which is how I ran into the bug.

TEST=This runs more tests in media_unittests on the bots.
Review URL: http://codereview.chromium.org/8941001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114520 0039d316-1c4b-4281-b951-d872f2087c98

of the forwarding headers for webkit to be reported as missing.

R=tony@chromium.org
BUG=107444
TEST="missing file" warnings gone from build.webkit.org win bots

Review URL: http://codereview.chromium.org/8933019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114519 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8909007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114518 0039d316-1c4b-4281-b951-d872f2087c98

R=bradnelson@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8945001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114517 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none


Review URL: http://codereview.chromium.org/8936011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114516 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23757
TEST=manual
Review URL: http://codereview.chromium.org/8883046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114515 0039d316-1c4b-4281-b951-d872f2087c98

Change-Id: I78ca835371a0cf70e3dcb7630a91838ca40e9005

BUG=107596
TEST=See issue

Review URL: http://codereview.chromium.org/8914017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114513 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8931018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114512 0039d316-1c4b-4281-b951-d872f2087c98

linux-release-lowmem/dom_perf: http://build.chromium.org/f/chromium/perf/linux-release-lowmem/dom_perf/report.html?history=250&rev=114487

TBR=cmp 
BUG=107486
Review URL: http://codereview.chromium.org/8909016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114511 0039d316-1c4b-4281-b951-d872f2087c98

Previously, the pyauto remote inspector module only allowed a test to take
a v8 heap snapshot, as follows:

import perf_snapshot
snapshotter = perf_snapshot.PerformanceSnapshotter()
snapshot = snapshotter.HeapSnapshot()

With this change, the same object now provides the GarbageCollect() function,
which forces a garbage collection:

import perf_snapshot
snapshotter = perf_snapshot.PerformanceSnapshotter()
snapshot = snapshotter.GarbageCollect()

Refactoring of perf_snapshot.py still needs to be done to make it more
general (useful for various kinds of interaction with the remote inspector).
This CL includes a portion of this refactoring: I separated the
_PerformanceSnapshotterThread class into 2 classes: a base class called
_RemoteInspectorBaseThread, and a subclass called
_PerformanceSnapshotterThread.  There is a new subclass called
_GarbageCollectThread to implement the garbage collection functionality.

In a future CL, I intend to do some additional refactoring of comments
and organization of the code, and also change the name of the file itself.

BUG=chromium-os:23962
TEST=None

Review URL: http://codereview.chromium.org/8885025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114510 0039d316-1c4b-4281-b951-d872f2087c98

Change-Id: I02b3329104f9c54580143595abfebff5079eb84a

BUG=107028,107242
TEST=See issue. Make sure status buttons are correctly enabled from the login screen and once logged in, and that clicking on them during login does not crash or cause any bad behavior. Also check with the screen locker.

Review URL: http://codereview.chromium.org/8907008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114509 0039d316-1c4b-4281-b951-d872f2087c98

/mac-release/sizes: http://build.chromium.org/f/chromium/perf/mac-release/sizes/report.html?history=50&header=Chromium.app&graph=Chromium.app&rev=114493

http://build.chromium.org/f/chromium/perf/mac-release/sizes/report.html?history=50&header=Chromium.app&graph=chrome-si&rev=114493

TBR=cmp 
BUG=107594
Review URL: http://codereview.chromium.org/8916017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114508 0039d316-1c4b-4281-b951-d872f2087c98

TEST=None
BUG=None
Review URL: http://codereview.chromium.org/8911014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114507 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105879
R=ben@chromium.org
TBR=stevenjb@chromium.org

Review URL: http://codereview.chromium.org/8915007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114506 0039d316-1c4b-4281-b951-d872f2087c98

SyncErrorTest.AuthErrorTest is a test for authentication errors that was
recently added. It is timing out on Mac.

This patch disables it.

TBR=mmenke@chromium.org
BUG=107611
TEST=

Review URL: http://codereview.chromium.org/8916015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114505 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8900001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114504 0039d316-1c4b-4281-b951-d872f2087c98

together, so I'm relanding together. Here's the original descriptions:

    Fixes layout bugs in ShelfLayoutManager. The problem with invoking
    SetBounds on the widget during the animation is we end up back in the
    layoutmanager and cancel the change. Also adds some tests for
    ShelfLayoutManager.

and

    Create a visible shelf and constrain window movement

This also includes the fix, which you reviewed @
http://codereview.chromium.org/8914012 .

BUG=106432 107287 107401
TEST=none
TBR=ben@chromium.org

Review URL: http://codereview.chromium.org/8914023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114502 0039d316-1c4b-4281-b951-d872f2087c98

Change-Id: I461b53554bb67f6fe9681d04940e2131e2a9224c

BUG=chromium-os:107309
TEST=See issue


Review URL: http://codereview.chromium.org/8932001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114501 0039d316-1c4b-4281-b951-d872f2087c98

TBR=zmo
BUG=104142

Review URL: http://codereview.chromium.org/8914008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114500 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107047
TEST=crypto_unittests


Review URL: http://codereview.chromium.org/8894023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114499 0039d316-1c4b-4281-b951-d872f2087c98

 This passes locally and was passing two days ago on aura bot, but now it's failing.  Disabling again

TBR=thestig@chromium.org
BUG=103497
TEST=none

Review URL: http://codereview.chromium.org/8907030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114498 0039d316-1c4b-4281-b951-d872f2087c98